Nikita Popov [Sat, 18 Feb 2012 13:39:13 +0000 (13:39 +0000)]
Fix headers generated by phar
sapi_header_line.line_len is the length without null terminator, so one has to
take sizeof - 1. This fixes some test failures as the NUL bytes were causing
warnings.
Rasmus Lerdorf [Fri, 17 Feb 2012 17:54:11 +0000 (17:54 +0000)]
I think we should let this be settable from .htaccess to match the other post/upload
related limits like upload_max_filesize, post_max_size, and max_input_vars.
Xinchen Hui [Wed, 8 Feb 2012 03:03:05 +0000 (03:03 +0000)]
Revert -r319102 and -r322922 in 5.4 branch since they introduce #60978
Fixed #60978 in trunk without reverting previous fix
#see http://news.php.net/php.internals/57789
- Fixed possible unsigned int wrap around in html.c. Note that 5.3 has the same
(potential) problem; even though the code is substantially different, the
variable name and the fashion it was incremented was kept.
Rasmus Lerdorf [Sun, 5 Feb 2012 10:08:16 +0000 (10:08 +0000)]
Another openssl test that is dependent on the openssl version. The output has
changed in more recent versions. Synch with newer output and consider changing
the test to only pick out the more stable fields instead of all of them.
Rasmus Lerdorf [Sun, 5 Feb 2012 09:32:20 +0000 (09:32 +0000)]
According to the reports on qa this test is failing the same way for everyone.
See: http://qa.php.net/reports/viewreports.php?version=5.3.10&test=%2Fext%2Fopenssl%2Ftests%2Fbug28382.phpt
I'm not sure if this is due to a change in the openssl library or in the extension, so perhaps the test
itself needs to change, but for now synch it with the new output and watch for failures.
- Fixed bug #60965 (Buffer overflow on htmlspecialchars/entities with
$double=false).
- Removed unused variable.
- Given maxlen the usual meaning of *len variables (terminator not included).
- Changed some comments.
Michael Wallner [Tue, 31 Jan 2012 08:51:24 +0000 (08:51 +0000)]
fix headers print to stdout/stderr if no output written; need to make some more testsbefore committing to PHP_5_4; fix crashes and invalid usage of output control in cli server while passing by
Michael Wallner [Mon, 23 Jan 2012 09:48:18 +0000 (09:48 +0000)]
LTP/gcov/lcov
- allow ltp v1.9
- make sure `test`s are catched by `if`s
- introduce LCOV_INCLUDE make variable, simple coverage for your extension:
./configure --enable-gcov && make lcov TESTS=~/src/pecl/http/test LCOV_INCLUDE=/http/
coverage takes just a few seconds instead of a few minutes for the full source tree
- Further fix for bug #60455 (stream_get_line misbehaves if EOF is not detected
together with the last read).
- Fixed bug #60817 (stream_get_line() reads from stream even when there is
already sufficient data buffered). stream_get_line() now behaves more like
fgets(), as is documented.
#withheld commit to 5.4
Nuno Lopes [Sat, 21 Jan 2012 11:32:56 +0000 (11:32 +0000)]
revert r319254 (fix bug #54682) since it is not correct
add test that was broken with that patch.
this bug is probably in libtidy itself and not in PHP. I didn't investigate it enough to confirm, though
Dmitry Stogov [Fri, 20 Jan 2012 12:30:57 +0000 (12:30 +0000)]
Fixed Bug #60809 (TRAITS - PHPDoc Comment Style Bug)
Fixed some other traits related bugs (uninitialized variable, return => continue)
Removed some trait related redundant code and variables
Ferenc Kovacs [Thu, 19 Jan 2012 00:20:04 +0000 (00:20 +0000)]
merging the patch from #52078, fixes the test on disk with huge inode size(fileinode() can overflow and return negative values there). will merge this to PHP_5_4 after the commit freeze.
Dmitry Stogov [Tue, 17 Jan 2012 08:09:13 +0000 (08:09 +0000)]
Improved traits implementation. Now to support __CLASS__ constant in traits php doesn't have to copy the complete compiled method, but can reuse the same code. The resolution of __CLASS__ constants in methods defined in traits are delayed till run-time. This approach also made possible to use __CLASS__ constant as default value for traits properties and method arguments.
Michael Wallner [Mon, 16 Jan 2012 17:51:35 +0000 (17:51 +0000)]
Fix bug #60768 Output buffer not discarded
in php_output_handler_op():
* if appending to buffer succeeds, just return HANDLER_NO_DATA
and do nothing else
* if a zero sized string or true is returned from the handler
function, reset the context as well as the handler's buffer