Tim Peters [Fri, 10 Mar 2006 23:37:10 +0000 (23:37 +0000)]
When the new -w option (yay! great idea) reruns a
failed test, first display the name of the test (else
it's not always clear from the output which test is
getting run).
Guido van Rossum [Fri, 10 Mar 2006 02:28:35 +0000 (02:28 +0000)]
Um, I thought I'd already checked this in.
Anyway, this is the changes to the with-statement
so that __exit__ must return a true value in order
for a pending exception to be ignored.
The PEP (343) is already updated.
Tim Peters [Thu, 9 Mar 2006 22:31:45 +0000 (22:31 +0000)]
NodeInfo.__gen_init(): Fiddle so that reindent.py is
happy with the output as-is. This incidentally also
gets rid of "an extra" blank line at the end of the output
block that probably wasn't intended (although it doesn't
matter one way or the other).
Tim Peters [Thu, 9 Mar 2006 01:42:24 +0000 (01:42 +0000)]
Simple utility to add svn:eol-style to text files under
SVN control. Like reindent.py, I expect to run this
mindlessly from time to time, checking in whatever it
happens to do ;-)
Georg Brandl [Wed, 8 Mar 2006 18:09:27 +0000 (18:09 +0000)]
Patch #1434038: property() now uses the getter's docstring if there is
no "doc" argument given. This makes it possible to legitimately use
property() as a decorator to produce a read-only property.
Thomas Wouters [Wed, 8 Mar 2006 01:47:19 +0000 (01:47 +0000)]
Clean up _bsddb.c: add a couple dozen missing Py_DECREF()'s, a handful of
missing PyObject_Del()'s, simplify some code by using Py_BuildValue()
instead of creating a tuple with items manually, stop clobbering builtin
exceptions in a few places, and guard against NULL-returning functions some
more.
This fixes 117 of the 780 (!?!#%@#$!!) reference leaks in test_bsddb3. I
ain't not done yet, although this review of 5kloc was just the easy part.
Tim Peters [Tue, 7 Mar 2006 23:53:32 +0000 (23:53 +0000)]
_hotshot hotshot_profiler(): If write_header() returned
an error code, this let `self` leak. This is a disaster
on Windows, since `self` already points to a newly-opened
file object, and it was impossible for Python code to
close the thing since the only reference to it was in a
blob of leaked C memory.
test_hotshot test_bad_sys_path(): This new test provoked
the C bug above. This test passed, but left an open
"@test" file behind, which caused a massive cascade of
bogus test failures in later, unrelated tests on Windows.
Changed the test code to remove the @test file it leaves
behind, which relies on the change above to close that
file first.
Checking in the code for PEP 357.
This was mostly written by Travis Oliphant.
I've inspected it all; Neal Norwitz and MvL have also looked at it
(in an earlier incarnation).
Neal Norwitz [Tue, 7 Mar 2006 04:48:24 +0000 (04:48 +0000)]
Thanks to Coverity, these were all reported by their Prevent tool.
All of these (except _lsprof.c) should be backported. Particularly
the hotshot change which validates sys.path. Can someone backport?
Neal Norwitz [Mon, 6 Mar 2006 23:07:34 +0000 (23:07 +0000)]
Try to cleanup the error handling a bit so there aren't false positives
from static analysis. v was already checked for NULL above, so we don't
need a second check.
Neal Norwitz [Sun, 5 Mar 2006 02:16:12 +0000 (02:16 +0000)]
Backout the last hack and add in this new one.
The failure definitely seems timing related. This change *seems* to work.
Since the failure isn't doesn't occur consistently, it's hard to tell.
Running these tests on Solaris in this order:
test_urllibnet test_operator test_cgi \
test_isinstance test_future test_ast test_logging
generally caused a failure (about 50% of the time) before the sleep.
I couldn't provoke the failure with the sleep.
This should really be cleaned up by using threading.Events or something
so it is not timing dependent and doesn't hang forever on failure.
Neal Norwitz [Sat, 4 Mar 2006 18:52:26 +0000 (18:52 +0000)]
Get rid of run_err_mod(). It was only used in two places.
One place it wasn't necessary since mod was already checked.
Inline the check that mod != NULL for the other use.
Neal Norwitz [Fri, 3 Mar 2006 21:53:14 +0000 (21:53 +0000)]
I think the test_logging failure on Solaris is timing related. We don't
want to wait forever if we don't receive the last message. But we also
don't want the test to fail if we shutdown too quickly. I can't reliably
reproduce this failure, so I'm kinda guessing this is the problem.
We'll see if this band-aid helps.