Marc G. Fournier [Mon, 26 Jan 1998 00:21:02 +0000 (00:21 +0000)]
From: Darren King <darrenk@insightdist.com>
I have always been under the impression that NULL is not equal to
NULL and that NULL is not equal to anything else either. If this
is the case, then this patch is correct.
If NULL _is_ equal to NULL, then I think there are other problems
in the Group By logic.
Marc G. Fournier [Sun, 25 Jan 1998 07:11:07 +0000 (07:11 +0000)]
From: Tom I Helbekkmo <tih@Hamartun.Priv.NO>
PostgreSQL type extensions for IP and MAC addresses.
I needed to record IP and MAC level ethernet addresses in a data
base, and I really didn't want to store them as plain strings, with
no enforced error checking, so I put together the accompanying code
as my first experiment with adding a data type to PostgreSQL. I
then thought that this might be useful to others, both directly and
as a very simple example of how to do this sort of thing, so here
it is, in the hope that it will be useful.
Marc G. Fournier [Sun, 25 Jan 1998 04:14:36 +0000 (04:14 +0000)]
From: Tom I Helbekkmo <tih@Hamartun.Priv.NO>
Hi -- a couple of small items concerning the January 23rd snapshot:
the inclusion of the Kerberos stuff in one Makefile, a "leading tab"
cleanup in another, and a fix for a typo in the configure script.
Bruce Momjian [Fri, 23 Jan 1998 22:16:48 +0000 (22:16 +0000)]
Fix a variety of locking problems like newer lock waiters getting
lock before older waiters, and having readlock people not share
locks if a writer is waiting for a lock, and waiting writers not
getting priority over waiting readers.
Marc G. Fournier [Fri, 23 Jan 1998 19:22:24 +0000 (19:22 +0000)]
From: James Hughes <jamesh@interpath.com>
This is a patch to fix crashes in psql when executing queries from
an external file. The code also adds error checking to verify that
memory for "query" was allocated. The conditional for the block of
code was changed from "query == NULL" to "query_alloced == false".
The conditional, "query == NULL", was never true. This prevented
the memory being allocated for "query". A few lines later, an attempt
to write to an un-allocated memory area generated a SIGSEGV causing
the frontend to crash.
Marc G. Fournier [Thu, 15 Jan 1998 20:54:52 +0000 (20:54 +0000)]
Fix:
nodeAgg.c: WARN -> NOTICE for elog
parse_oper.c: was created after patch for fmgr_info, so function call wrong
scan.c: regenerated for i386_solaris using flex 2.5.4
gethostname.c: required prototype for gethostname() function
config.h.in: create prototype for isinfo() function
isinf.c: "fake" isinf() under i386_solaris using fpclass() call...
One of the design rules of PostgreSQL is extensibility. And
to follow this rule means (at least for me) that there should
not only be a builtin PL. Instead I would prefer a defined
interface for PL implemetations.
Marc G. Fournier [Tue, 13 Jan 1998 04:20:51 +0000 (04:20 +0000)]
One more src/interfaces/libpq/Makefile problem: there's an explicit
reference to the name of the shared library, instead of dereferencing
the definition from the top of the file.
Marc G. Fournier [Tue, 13 Jan 1998 04:05:12 +0000 (04:05 +0000)]
Some *very* major changes by darrenk@insightdist.com (Darren King)
==========================================
What follows is a set of diffs that cleans up the usage of BLCKSZ.
As a side effect, the person compiling the code can change the
value of BLCKSZ _at_their_own_risk_. By that, I mean that I've
tried it here at 4096 and 16384 with no ill-effects. A value
of 4096 _shouldn't_ affect much as far as the kernel/file system
goes, but making it bigger than 8192 can have severe consequences
if you don't know what you're doing. 16394 worked for me, _BUT_
when I went to 32768 and did an initdb, the SCSI driver broke and
the partition that I was running under went to hell in a hand
basket. Had to reboot and do a good bit of fsck'ing to fix things up.
The patch can be safely applied though. Just leave BLCKSZ = 8192
and everything is as before. It basically only cleans up all of the
references to BLCKSZ in the code.
If this patch is applied, a comment in the config.h file though above
the BLCKSZ define with warning about monkeying around with it would
be a good idea.
Darren darrenk@insightdist.com
(Also cleans up some of the #includes in files referencing BLCKSZ.)
==========================================
Marc G. Fournier [Tue, 13 Jan 1998 03:49:51 +0000 (03:49 +0000)]
> It seems there is a mistake in substr function:
> then you try get substr, which consists only of last char in string
> you get all string
>
> For example:
> userbase=> select substr('123456', 6,1) ;
> substr
> ------
> 123456
> (1 row)
>
Fix up for recent changes in elog error messages.
Some behavior of the triggers test cases changed for the least week or two;
now back to the usual expected behavior.