]>
granicus.if.org Git - neomutt/log
Pietro Cerutti [Fri, 16 Nov 2018 15:55:16 +0000 (15:55 +0000)]
Avoid segfault when an IMAP connection cannot be opened (II)
Part II of 6a2e9f, which broke edit-msg. It turns out that mx_ac_add()
is not required to be successful, e.g., when opening a temporary file.
This means we must be extra cautious and check that m->account->adata is
valid before using it
Pietro Cerutti [Fri, 16 Nov 2018 13:11:17 +0000 (13:11 +0000)]
Make sure error buffer is properly initialized
Richard Russon [Fri, 16 Nov 2018 13:07:49 +0000 (13:07 +0000)]
merge: update translations
* Update zh_CN translation
* Update Czech translation
* More translations
* Update lt_LT translations
* Update Polish translation
* update German translation
* fix Polish format spec
* Update lt_LT translation
* Update Czech translation
* Update Slovak translation
* fixing typos in Polish translation
* update filenames
* sync translations
Richard Russon [Fri, 16 Nov 2018 13:06:36 +0000 (13:06 +0000)]
sync translations
Richard Russon [Fri, 16 Nov 2018 13:03:37 +0000 (13:03 +0000)]
update filenames
Marcin Rajner [Tue, 13 Nov 2018 09:23:33 +0000 (10:23 +0100)]
fixing typos in Polish translation
David Sterba [Fri, 1 Jun 2018 10:37:25 +0000 (12:37 +0200)]
Update Slovak translation
David Sterba [Thu, 1 Nov 2018 13:03:22 +0000 (14:03 +0100)]
Update Czech translation
Marius Gedminas [Wed, 31 Oct 2018 14:51:53 +0000 (16:51 +0200)]
Update lt_LT translation
(I accidentally re-translated lt.po in master, and when I tried to
cherry-pick my translation onto the translate branch I noticed that I'd
translated a couple of messages incorrectly.)
Richard Russon [Fri, 12 Oct 2018 16:26:29 +0000 (17:26 +0100)]
fix Polish format spec
ab [Fri, 12 Oct 2018 15:44:14 +0000 (17:44 +0200)]
update German translation
Marcin Rajner [Tue, 9 Oct 2018 15:40:55 +0000 (17:40 +0200)]
Update Polish translation
Marius Gedminas [Tue, 18 Sep 2018 10:19:50 +0000 (13:19 +0300)]
Update lt_LT translations
New messages, new fuzz, some old typos.
Winderickx Eli (p087068) [Thu, 13 Sep 2018 12:58:18 +0000 (14:58 +0200)]
More translations
David Sterba [Fri, 7 Sep 2018 09:54:19 +0000 (11:54 +0200)]
Update Czech translation
Zero King [Tue, 4 Sep 2018 03:41:35 +0000 (03:41 +0000)]
Update zh_CN translation
Richard Russon [Fri, 16 Nov 2018 12:55:11 +0000 (12:55 +0000)]
merge: trivial fixes
* doxygen: sort out Email descriptions
* boolify params/retvals
* imap: simplify some helper functions
* remove unused member
* imap: tiny refactor
* doxygen: unify docs for private data
* rename: _create to _new for simple allocs
Richard Russon [Fri, 16 Nov 2018 12:51:10 +0000 (12:51 +0000)]
rename: _create to _new for simple allocs
Richard Russon [Fri, 16 Nov 2018 12:23:03 +0000 (12:23 +0000)]
doxygen: unify docs for private data
Richard Russon [Fri, 16 Nov 2018 12:01:54 +0000 (12:01 +0000)]
imap: tiny refactor
Richard Russon [Fri, 16 Nov 2018 12:00:09 +0000 (12:00 +0000)]
remove unused member
Richard Russon [Fri, 16 Nov 2018 11:59:08 +0000 (11:59 +0000)]
imap: simplify some helper functions
Richard Russon [Fri, 16 Nov 2018 11:47:16 +0000 (11:47 +0000)]
boolify params/retvals
Richard Russon [Fri, 16 Nov 2018 11:42:31 +0000 (11:42 +0000)]
doxygen: sort out Email descriptions
Richard Russon [Fri, 16 Nov 2018 12:33:00 +0000 (12:33 +0000)]
clang-format
Richard Russon [Fri, 16 Nov 2018 11:14:44 +0000 (11:14 +0000)]
rename: curs_main.c to index.c
Richard Russon [Fri, 16 Nov 2018 11:26:21 +0000 (11:26 +0000)]
merge: Simplify URL APIs
* Simplify URL APIs
* Remove unused U_DECODE_PASSWD flag
* Add a basic unit test for URL
* Convert NotMuch to the new URL API
* Additional improvements to URL API and implementation
* Additional tests for URL
* Avoid flexible array members, improve URL test code
Pietro Cerutti [Fri, 16 Nov 2018 07:57:41 +0000 (07:57 +0000)]
Avoid flexible array members, improve URL test code
Pietro Cerutti [Thu, 15 Nov 2018 16:38:51 +0000 (16:38 +0000)]
Additional tests for URL
Pietro Cerutti [Thu, 15 Nov 2018 16:37:47 +0000 (16:37 +0000)]
Additional improvements to URL API and implementation
Pietro Cerutti [Thu, 15 Nov 2018 14:28:38 +0000 (14:28 +0000)]
Convert NotMuch to the new URL API
Pietro Cerutti [Thu, 15 Nov 2018 14:12:26 +0000 (14:12 +0000)]
Add a basic unit test for URL
Pietro Cerutti [Thu, 15 Nov 2018 13:33:17 +0000 (13:33 +0000)]
Remove unused U_DECODE_PASSWD flag
Pietro Cerutti [Thu, 15 Nov 2018 13:28:47 +0000 (13:28 +0000)]
Simplify URL APIs
Mehdi Abaakouk [Fri, 16 Nov 2018 09:00:23 +0000 (10:00 +0100)]
imap: ensure we can't delete the current selected mailbox
Closes #1417
Mehdi Abaakouk [Fri, 16 Nov 2018 05:51:25 +0000 (06:51 +0100)]
imap: add missing conn_account free
Pietro Cerutti [Fri, 16 Nov 2018 09:42:51 +0000 (09:42 +0000)]
Avoid segfault when an IMAP connection cannot be opened
This could be reproduced trying to open an IMAPS connection with a
NeoMutt built without SSL support.
Richard Russon [Thu, 15 Nov 2018 16:09:40 +0000 (16:09 +0000)]
merge: remove ImapMbox
* imap: make imap_mailbox_check aware of Mailbox
* imap: setup a mdata struct for each mailboxes
* imap: remove ImapMbox from imap_prepare_mailbox
* imap: remove ImapMbox from imap_adata_find signature
* imap: remove get_mailbox()
* imap: remove ImapMbox from imap_fast_trash()
* imap: remove ImapMbox from imap_ac_add()
* imap: remove ImapMbox from imap_mbox_open()
* imap: remove ImapMbox from imap_delete_mailbox()
* imap: remove ImapMbox from imap_adata_find()
* imap: remove ImapMbox from imap_append_message()
* imap: remove ImapMbox from imap_copy_messages()
* imap: remove ImapMbox from imap_hcache_open()
* imap: remove ImapMbox from imap_browse()
* imap: remove useless allocation in imap_mailbox_create()
* imap: create mdata in imap_prepare_mailbox()
* imap: remove ImapMbox from cmd_parse_status()
* imap: remove ImapMbox from add_folder()
* imap: remove ImapMbox from browse_add_list_result()
* imap: remove ImapMbox from imap_pretty_mailbox()
* imap: remove ImapMbox and imap_parse_path()
* imap: remove now useless param of imap_prepare_mailbox
* imap: remove imap_parse_path2() from imap_hcache_open()
* imap: remove imap_parse_path2() from imap_rename_mailbox()
* imap: remove imap_parse_path2() from imap_append_message()
* imap: always parse account in imap_parse_path2()
* imap: remove old PINE url format
* imap: handle all mailbox name with ImapMailboxData struct
* imap: ensure account flags are zero'ed
* imap: Check m->has_new to increase MailboxCount
* imap: rename imap_parse_path2() imap_parse_path()
* imap: rename imap_qualify_path2() to imap_qualify_path()
* imap: rename ImapMailboxData to ImapMboxData
Mehdi Abaakouk [Thu, 15 Nov 2018 13:50:17 +0000 (14:50 +0100)]
imap: rename ImapMailboxData to ImapMboxData
Mehdi Abaakouk [Thu, 15 Nov 2018 11:02:16 +0000 (12:02 +0100)]
imap: rename imap_qualify_path2() to imap_qualify_path()
Mehdi Abaakouk [Thu, 15 Nov 2018 10:57:41 +0000 (11:57 +0100)]
imap: rename imap_parse_path2() imap_parse_path()
Mehdi Abaakouk [Thu, 15 Nov 2018 09:26:41 +0000 (10:26 +0100)]
imap: Check m->has_new to increase MailboxCount
Mehdi Abaakouk [Thu, 15 Nov 2018 06:56:48 +0000 (07:56 +0100)]
imap: ensure account flags are zero'ed
Mehdi Abaakouk [Wed, 14 Nov 2018 13:13:42 +0000 (14:13 +0100)]
imap: handle all mailbox name with ImapMailboxData struct
Mehdi Abaakouk [Wed, 14 Nov 2018 09:22:06 +0000 (10:22 +0100)]
imap: remove old PINE url format
This format is broken since a while (when we started to use url_parse
to get the mailbox name).
This change removes it.
Mehdi Abaakouk [Wed, 14 Nov 2018 09:12:06 +0000 (10:12 +0100)]
imap: always parse account in imap_parse_path2()
Mehdi Abaakouk [Wed, 14 Nov 2018 09:14:04 +0000 (10:14 +0100)]
imap: remove imap_parse_path2() from imap_append_message()
Mehdi Abaakouk [Wed, 14 Nov 2018 09:10:06 +0000 (10:10 +0100)]
imap: remove imap_parse_path2() from imap_rename_mailbox()
Mehdi Abaakouk [Wed, 14 Nov 2018 09:07:37 +0000 (10:07 +0100)]
imap: remove imap_parse_path2() from imap_hcache_open()
Mehdi Abaakouk [Wed, 14 Nov 2018 08:56:09 +0000 (09:56 +0100)]
imap: remove now useless param of imap_prepare_mailbox
Mehdi Abaakouk [Wed, 14 Nov 2018 08:47:28 +0000 (09:47 +0100)]
imap: remove ImapMbox and imap_parse_path()
Mehdi Abaakouk [Wed, 14 Nov 2018 08:46:06 +0000 (09:46 +0100)]
imap: remove ImapMbox from imap_pretty_mailbox()
Mehdi Abaakouk [Wed, 14 Nov 2018 08:36:44 +0000 (09:36 +0100)]
imap: remove ImapMbox from browse_add_list_result()
Mehdi Abaakouk [Wed, 14 Nov 2018 08:27:08 +0000 (09:27 +0100)]
imap: remove ImapMbox from add_folder()
Mehdi Abaakouk [Wed, 14 Nov 2018 08:24:49 +0000 (09:24 +0100)]
imap: remove ImapMbox from cmd_parse_status()
Mehdi Abaakouk [Wed, 14 Nov 2018 08:15:53 +0000 (09:15 +0100)]
imap: create mdata in imap_prepare_mailbox()
Hidden mailbox does not call mx_ac_add(). So this change
moves the ImapMailboxData initialisation in imap_prepare_mailbox().
This ensures we always have a valid m->mdata;
Mehdi Abaakouk [Wed, 14 Nov 2018 06:54:24 +0000 (07:54 +0100)]
imap: remove useless allocation in imap_mailbox_create()
Mehdi Abaakouk [Wed, 14 Nov 2018 06:39:06 +0000 (07:39 +0100)]
imap: remove ImapMbox from imap_browse()
Mehdi Abaakouk [Tue, 13 Nov 2018 23:38:30 +0000 (00:38 +0100)]
imap: remove ImapMbox from imap_hcache_open()
Mehdi Abaakouk [Tue, 13 Nov 2018 23:36:45 +0000 (00:36 +0100)]
imap: remove ImapMbox from imap_copy_messages()
Mehdi Abaakouk [Tue, 13 Nov 2018 23:33:34 +0000 (00:33 +0100)]
imap: remove ImapMbox from imap_append_message()
Mehdi Abaakouk [Tue, 13 Nov 2018 23:31:41 +0000 (00:31 +0100)]
imap: remove ImapMbox from imap_adata_find()
Mehdi Abaakouk [Tue, 13 Nov 2018 23:18:08 +0000 (00:18 +0100)]
imap: remove ImapMbox from imap_delete_mailbox()
Mehdi Abaakouk [Tue, 13 Nov 2018 22:51:21 +0000 (23:51 +0100)]
imap: remove ImapMbox from imap_mbox_open()
Mehdi Abaakouk [Tue, 13 Nov 2018 22:47:07 +0000 (23:47 +0100)]
imap: remove ImapMbox from imap_ac_add()
Mehdi Abaakouk [Tue, 13 Nov 2018 17:24:31 +0000 (18:24 +0100)]
imap: remove ImapMbox from imap_fast_trash()
Mehdi Abaakouk [Tue, 13 Nov 2018 17:01:12 +0000 (18:01 +0100)]
imap: remove get_mailbox()
Mehdi Abaakouk [Tue, 13 Nov 2018 16:06:01 +0000 (17:06 +0100)]
imap: remove ImapMbox from imap_adata_find signature
Mehdi Abaakouk [Tue, 13 Nov 2018 15:04:00 +0000 (16:04 +0100)]
imap: remove ImapMbox from imap_prepare_mailbox
Mehdi Abaakouk [Tue, 13 Nov 2018 14:47:00 +0000 (15:47 +0100)]
imap: setup a mdata struct for each mailboxes
This change introduces `struct ImapMailboxeData` to mainly store
the mbox name in all its form.
Next change will use this names instead of parsing again and again the
path.
At this end we should be able to drop ImapMbox and imap_parse_path().
Mehdi Abaakouk [Sat, 10 Nov 2018 19:11:15 +0000 (20:11 +0100)]
imap: make imap_mailbox_check aware of Mailbox
With multiple imap account not loaded at startup time, when we switch to
another account, stats are almost not updated. If check_stats if true at
this time by change, mutt crash. Because we unexpectly update the
msg_unread of Context->mailbox.
Imap is the only backend that check stats is done for all backends at
once.
This change makes it more like other backends, and it make all imap
mailboxes stats to be loaded on next check_stats=true without crash.
Richard Russon [Wed, 14 Nov 2018 16:47:22 +0000 (16:47 +0000)]
merge: refactor Context/Mailbox usage
* pop: Mailbox refactor
* mbox: Mailbox refactor
* maildir: Mailbox refactor
* nntp: Mailbox refactor
* notmuch: Mailbox refactor
* compress: Mailbox refactor
* imap: Mailbox refactor
* flags: Mailbox refactor
* mx: Mailbox refactor
* threads: Mailbox refactor
* open_append: remove Context
* msg_close: remove Context
* msg_commit: remove Context
* msg_padding_size: remove Context
* tags_edit: remove Context
* mxapi: unify retval of msg_open
* path_canon: drop folder
Richard Russon [Tue, 13 Nov 2018 02:02:02 +0000 (02:02 +0000)]
path_canon: drop folder
Richard Russon [Wed, 14 Nov 2018 11:11:37 +0000 (11:11 +0000)]
mxapi: unify retval of msg_open
Richard Russon [Tue, 13 Nov 2018 01:54:20 +0000 (01:54 +0000)]
tags_edit: remove Context
Richard Russon [Tue, 13 Nov 2018 01:51:50 +0000 (01:51 +0000)]
msg_padding_size: remove Context
Richard Russon [Tue, 13 Nov 2018 01:40:26 +0000 (01:40 +0000)]
msg_commit: remove Context
Richard Russon [Tue, 13 Nov 2018 01:35:03 +0000 (01:35 +0000)]
msg_close: remove Context
Richard Russon [Tue, 13 Nov 2018 01:29:36 +0000 (01:29 +0000)]
open_append: remove Context
Richard Russon [Tue, 13 Nov 2018 01:11:19 +0000 (01:11 +0000)]
threads: Mailbox refactor
Richard Russon [Tue, 13 Nov 2018 01:11:09 +0000 (01:11 +0000)]
mx: Mailbox refactor
Richard Russon [Mon, 12 Nov 2018 17:34:04 +0000 (17:34 +0000)]
flags: Mailbox refactor
Richard Russon [Mon, 12 Nov 2018 17:08:56 +0000 (17:08 +0000)]
imap: Mailbox refactor
Richard Russon [Mon, 12 Nov 2018 17:00:16 +0000 (17:00 +0000)]
compress: Mailbox refactor
Richard Russon [Mon, 12 Nov 2018 16:54:52 +0000 (16:54 +0000)]
notmuch: Mailbox refactor
Richard Russon [Mon, 12 Nov 2018 16:30:24 +0000 (16:30 +0000)]
nntp: Mailbox refactor
Richard Russon [Mon, 12 Nov 2018 16:11:02 +0000 (16:11 +0000)]
maildir: Mailbox refactor
Richard Russon [Mon, 12 Nov 2018 16:00:29 +0000 (16:00 +0000)]
mbox: Mailbox refactor
Richard Russon [Mon, 12 Nov 2018 15:51:54 +0000 (15:51 +0000)]
pop: Mailbox refactor
Pietro Cerutti [Wed, 14 Nov 2018 12:16:06 +0000 (12:16 +0000)]
Do not create an additional ctx for syncing a mailbox
When the additional ctx is closed, the mailbox is free'd too, which
causes a crash back in the index.
Richard Russon [Wed, 14 Nov 2018 15:19:35 +0000 (15:19 +0000)]
merge: add mutt_str_startswith API
* Fix NONULL so it's usable in expressions such as `!*NONULL(str)`
* Add mutt_str_startswith API
* mutt_str_startswith - bcache.c
* mutt_str_startswith - browser.c
* mutt_str_startswith - color.c
* mutt_str_startswith - config/sort.c
* mutt_str_startswith - copy.c
* mutt_str_startswith - email/from.c
* mutt_str_startswith - email/idna.c
* mutt_str_startswith - email/parse.c
* mutt_str_startswith - handler.c
* mutt_str_startswith - imap/auth_sasl.c
* mutt_str_startswith - imap/browse.c
* mutt_str_startswith - imap/command.c
* mutt_str_startswith - imap/imap.c
* mutt_str_startswith - imap/message.c
* mutt_str_startswith - imap/util.c
* mutt_str_startswith - init.c
* mutt_str_startswith - maildir/mh.c
* mutt_str_startswith - main.c
* mutt_str_startswith - mbox/mbox.c
* mutt_str_startswith - mutt/envlist.c
* mutt_str_startswith - mutt/path.c
* mutt_str_startswith - mutt_lua.c
* mutt_str_startswith - muttlib.c
* mutt_str_startswith - ncrypt/crypt_gpgme.c
* mutt_str_startswith - ncrypt/pgp.c
* mutt_str_startswith - nntp/nntp.c
* mutt_str_startswith - pager.c
* mutt_str_startswith - pop/pop_auth.c
* mutt_str_startswith - pop/pop_lib.c
* mutt_str_startswith - postpone.c
* mutt_str_startswith - rfc3676.c
* mutt_str_startswith - sendlib.c
* mutt_str_startswith - mutt/date.c
* mutt_str_startswith - mutt/list.c
* mutt_str_startswith - mutt_header.c
* mutt_str_startswith - config/sort.c - fix logic
* mutt_str_startswith - ncrypt/crypt.c
* mutt_str_startswith - ncrypt/smime.c
* mutt_str_startswith - nntp/nntp.c
* mutt_str_startswith - notmuch/mutt_notmuch.c
* mutt_str_startswith - pop/pop_lib.c
* mutt_str_startswith - postpone.c
* mutt_str_startswith - rfc1524.c
* Remove unneeded strlen
* mutt_str_startswith - send.c
* mutt_str_startswith - sendlib.c
* mutt_str_startswith - smtp.c
* mutt_str_startswith - terminal.c
* mutt_str_startswith - browser.c (leftover)
* mutt_str_startswith - mbox/mbox.c
* mutt_str_startswith - mutt/charset.c
* mutt_str_startswith - mutt/pop.c
* mutt_str_startswith - rfc1524.c
Pietro Cerutti [Mon, 12 Nov 2018 11:35:26 +0000 (11:35 +0000)]
mutt_str_startswith - rfc1524.c
Pietro Cerutti [Mon, 12 Nov 2018 11:35:08 +0000 (11:35 +0000)]
mutt_str_startswith - mutt/pop.c
Pietro Cerutti [Mon, 12 Nov 2018 11:34:49 +0000 (11:34 +0000)]
mutt_str_startswith - mutt/charset.c
Pietro Cerutti [Mon, 12 Nov 2018 11:34:25 +0000 (11:34 +0000)]
mutt_str_startswith - mbox/mbox.c
Pietro Cerutti [Mon, 12 Nov 2018 10:52:21 +0000 (10:52 +0000)]
mutt_str_startswith - browser.c (leftover)
Pietro Cerutti [Mon, 12 Nov 2018 10:41:18 +0000 (10:41 +0000)]
mutt_str_startswith - terminal.c
Pietro Cerutti [Mon, 12 Nov 2018 10:38:53 +0000 (10:38 +0000)]
mutt_str_startswith - smtp.c
Pietro Cerutti [Mon, 12 Nov 2018 10:27:55 +0000 (10:27 +0000)]
mutt_str_startswith - sendlib.c
Pietro Cerutti [Mon, 12 Nov 2018 10:27:06 +0000 (10:27 +0000)]
mutt_str_startswith - send.c