Daniel Stenberg [Sun, 29 Nov 2015 23:11:42 +0000 (00:11 +0100)]
http2 push: add missing inits of new stream
- set the correct stream_id for pushed streams
- init maxdownload and size properly
Daniel Stenberg [Sun, 29 Nov 2015 23:10:35 +0000 (00:10 +0100)]
http2 push: set weight for new stream
give the new stream the old one's stream_weight internally to avoid
sending a PRIORITY frame unless asked for it
Daniel Stenberg [Fri, 27 Nov 2015 22:24:59 +0000 (23:24 +0100)]
curl_setup.h: undef freeaddrinfo in c-ares block to fix build
Fixes warnings
78c25c854a added.
Daniel Stenberg [Fri, 27 Nov 2015 22:29:30 +0000 (23:29 +0100)]
nonblock: fix setting non-blocking mode for Amiga
IoctlSocket() apparently wants a pointer to a long, passed as a char *
in its third parameter. This bug was introduced already back in commit
c5fdeef41d from October 1 2001!
Bug: http://curl.haxx.se/mail/lib-2015-11/0088.html
Reported-by: Norbert Kett
Daniel Stenberg [Fri, 27 Nov 2015 22:24:07 +0000 (23:24 +0100)]
zsh install: fix DESTDIR support
Reported-by: Mohammad AlSaleh
Dan Fandrich [Fri, 27 Nov 2015 09:51:22 +0000 (10:51 +0100)]
lib: Only define curl_dofreeaddrinfo if struct addrinfo is available
Steve Holme [Fri, 27 Nov 2015 06:59:02 +0000 (06:59 +0000)]
tool_paramhlp: Fixed display of URL index in password prompt for --next
Commit
f3bae6ed73 added the URL index to the password prompt when using
--next. Unfortunately, because the size_t specifier (%zu) is not
supported by all sprintf() implementations we use the curl_off_t format
specifier instead. The display of an incorrect value arises on platforms
where size_t and curl_off_t are of a different size.
Daniel Stenberg [Wed, 25 Nov 2015 10:38:10 +0000 (11:38 +0100)]
timecond: do not add if-modified-since without timecondition
The RTSP code path didn't skip adding the if-modified-since for certain
RTSP code paths, even if CURLOPT_TIMECONDITION was set to
CURL_TIMECOND_NONE.
Also, an unknown non-zero CURLOPT_TIMECONDITION value no longer equals
CURL_TIMECOND_IFMODSINCE.
Bug: http://stackoverflow.com/questions/
33903982/curl-timecond-none-doesnt-work-how-to-remove-if-modified-since-header
Daniel Stenberg [Wed, 25 Nov 2015 10:29:00 +0000 (11:29 +0100)]
RELEASE-NOTES: synced with
99d17a5e2ba77e58
Daniel Stenberg [Wed, 25 Nov 2015 09:49:22 +0000 (10:49 +0100)]
examples/README: cut out the incomplete list
... and add a generic explanation for them instead. Each example file
should contain its own description these days.
Daniel Stenberg [Tue, 24 Nov 2015 22:33:37 +0000 (23:33 +0100)]
test1513: make sure the callback is only called once
Daniel Shahaf [Fri, 20 Nov 2015 04:56:10 +0000 (04:56 +0000)]
build: Install zsh completion
Fixes #534
Closes #537
Daniel Stenberg [Tue, 24 Nov 2015 18:51:59 +0000 (19:51 +0100)]
done: make sure the final progress update is made
It would previously be skipped if an existing error was returned, but
would lead to a previous value being left there and later used.
CURLINFO_TOTAL_TIME for example.
Still it avoids that final progress update if we reached DONE as the
result of a callback abort to avoid another callback to be called after
an abort-by-callback.
Reported-by: Lukas Ruzicka
Closes #538
Daniel Stenberg [Tue, 24 Nov 2015 09:11:06 +0000 (10:11 +0100)]
curl: expanded the -XHEAD warning text
... to also mention the specific options used.
Daniel Stenberg [Tue, 24 Nov 2015 08:32:42 +0000 (09:32 +0100)]
Revert "cleanup: general removal of TODO (and similar) comments"
This reverts commit
64e959ffe37c436503f9fed1ce2d6ee6ae50bd9a.
Feedback-by: Dan Fandrich
URL: http://curl.haxx.se/mail/lib-2015-11/0062.html
Daniel Stenberg [Mon, 23 Nov 2015 15:11:57 +0000 (16:11 +0100)]
CURLOPT_HEADERFUNCTION.3: fix typo
Refer to _HEADERDATA not _WRITEDATA.
Reported-by: Michał Piechowski
Daniel Stenberg [Mon, 23 Nov 2015 09:58:12 +0000 (10:58 +0100)]
TODO: TCP Fast Open
Steve Holme [Sun, 22 Nov 2015 11:55:10 +0000 (11:55 +0000)]
examples: Added website parse-able descriptions to the e-mail examples
Steve Holme [Sat, 21 Nov 2015 17:59:14 +0000 (17:59 +0000)]
TODO: Added another 'multi-interface' idea
Steve Holme [Sat, 21 Nov 2015 11:41:20 +0000 (11:41 +0000)]
smb.c: Fixed compilation warnings
smb.c:134:3: warning: conversion to 'short unsigned int' from 'int' may
alter its value
smb.c:146:42: warning: conversion to 'unsigned int' from 'long long
unsigned int' may alter its value
smb.c:146:65: warning: conversion to 'unsigned int' from 'long long
unsigned int' may alter its value
Steve Holme [Sat, 21 Nov 2015 02:54:44 +0000 (02:54 +0000)]
schannel: Corrected copy/paste error in commit
8d17117683
Steve Holme [Sat, 21 Nov 2015 02:43:17 +0000 (02:43 +0000)]
schannel: Use GetVersionEx() when VerifyVersionInfo() isn't available
Regression from commit
7a8e861a5 as highlighted in the msys autobuilds.
Steve Holme [Sat, 21 Nov 2015 01:47:02 +0000 (01:47 +0000)]
examples: Fixed compilation warnings
pop3-multi.c:96:5: warning: implicit declaration of function 'memset'
imap-multi.c:96:5: warning: implicit declaration of function 'memset'
http2-download.c:226:5: warning: implicit declaration of function 'memset'
http2-upload.c:290:5: warning: implicit declaration of function 'memset'
http2-upload.c:290:5: warning: implicit declaration of function 'memset'
Steve Holme [Sat, 21 Nov 2015 00:04:57 +0000 (00:04 +0000)]
Makefile.inc: Fixed test run error
test845 not present in tests/data/Makefile.inc
Daniel Stenberg [Fri, 20 Nov 2015 08:37:11 +0000 (09:37 +0100)]
TODO: remove duplicated title
Daniel Stenberg [Fri, 20 Nov 2015 07:39:59 +0000 (08:39 +0100)]
TODO: added two more libcurl ideas
Moved some ideas from "next major" to just ordinary ideas since we can
always add new things while keeping the old without doing a "next
major".
Steve Holme [Fri, 20 Nov 2015 07:04:19 +0000 (07:04 +0000)]
tests: Re-enabled tests 889 and 890 following POP3 fix
Steve Holme [Fri, 20 Nov 2015 07:01:01 +0000 (07:01 +0000)]
pop3: Differentiate between success and continuation responses
Steve Holme [Fri, 20 Nov 2015 06:41:53 +0000 (06:41 +0000)]
pop3: Added clarity on some server response codes
Daniel Shahaf [Thu, 19 Nov 2015 22:23:11 +0000 (22:23 +0000)]
build: Fix theoretical infinite loops
Add error-checking to 'cd' in a few cases where omitting the checks
might result in an infinite loop.
Closes #535
Patrick Monnerat [Thu, 19 Nov 2015 12:53:47 +0000 (13:53 +0100)]
curl.h: s/#defien/#define/
Patrick Monnerat [Thu, 19 Nov 2015 12:52:06 +0000 (13:52 +0100)]
os400: synchronize ILE/RPG header file
Patrick Monnerat [Thu, 19 Nov 2015 12:35:29 +0000 (13:35 +0100)]
os400: Provide options for libssh2 use in compile scripts. Adjust README.
danielsh@apache.org [Wed, 18 Nov 2015 21:52:32 +0000 (21:52 +0000)]
zsh completion: Preserve single quotes in output
When an option's help string contains literal single quotes, those
single quotes would be stripped from the option's description in the
completion output (unless the zsh RC_QUOTES option were set while the
completion function was being sourced, which is not the default). This
patch makes the completion output contain single quotes where the --help
output does.
Closes #532
MaxGiting [Thu, 19 Nov 2015 04:00:24 +0000 (23:00 -0500)]
FAQ: Grammar changes
Closes https://github.com/bagder/curl/pull/533
Daniel Stenberg [Tue, 17 Nov 2015 08:47:58 +0000 (09:47 +0100)]
http2: http_done: don't free already-freed push headers
The push headers are freed after the push callback has been invoked,
meaning this code should only free the headers if the callback was never
invoked and thus the headers weren't freed at that time.
Reported-by: Davey Shafik
Anders Bakken [Mon, 16 Nov 2015 20:50:41 +0000 (12:50 -0800)]
getconnectinfo: Don't call recv(2) if socket == -1
Closes #528
Daniel Stenberg [Mon, 16 Nov 2015 07:26:22 +0000 (08:26 +0100)]
CURLMOPT_PUSHFUNCTION.3: *_byname() returns only the first header
... if there are more than one using the same name
Daniel Stenberg [Mon, 16 Nov 2015 07:22:08 +0000 (08:22 +0100)]
http2: minor comment typo
Daniel Stenberg [Sun, 15 Nov 2015 22:15:00 +0000 (23:15 +0100)]
sasl; fix checksrc warnings
Steve Holme [Sun, 15 Nov 2015 20:18:44 +0000 (20:18 +0000)]
RELEASE-NOTES: Adjusted for the recent OAuth 2.0 activity
Steve Holme [Sun, 15 Nov 2015 20:14:46 +0000 (20:14 +0000)]
tests: Disabled 889 and 890 until we support POP3 continuation responses
As POP3 final and continuation responses both begin with a + character,
and both the finalcode and contcode variables in SASLprotoc are set as
such, we cannot tell the difference between them when we are expecting
an optional continuation from the server such as the following:
+ something else from the server
+OK final response
Disabled these tests until such a time we can tell the responses apart.
Steve Holme [Sun, 15 Nov 2015 17:39:05 +0000 (17:39 +0000)]
tests: Corrected typos from commit
ba4d8f7eba
Steve Holme [Sun, 15 Nov 2015 17:36:59 +0000 (17:36 +0000)]
tests: Added OAUTHBEARER failure response tests
Steve Holme [Sat, 5 Sep 2015 17:35:47 +0000 (18:35 +0100)]
oauth2: Support OAUTHBEARER failures sent as continuation responses
According to RFC7628 a failure message may be sent by the server in a
base64 encoded JSON string as a continuation response.
Currently only implemented for OAUTHBEARER and not XAUTH2.
Daniel Stenberg [Sun, 15 Nov 2015 18:12:06 +0000 (19:12 +0100)]
RELEASE-NOTES: synced with
808a17ee675
Steve Holme [Sat, 14 Nov 2015 11:19:57 +0000 (11:19 +0000)]
tests: Renamed existing OAuth 2.0 (XOAUTH) tests
Steve Holme [Sat, 14 Nov 2015 11:16:04 +0000 (11:16 +0000)]
tests: Added OAuth 2.0 (OAUTHBEARER) tests
Steve Holme [Sat, 5 Sep 2015 17:09:40 +0000 (18:09 +0100)]
oauth2: Added support for OAUTHBEARER SASL mechanism to IMAP, POP3 and SNMP
OAUTHBEARER is now the official "registered" SASL mechanism name for
OAuth 2.0. However, we don't want to drop support for XOAUTH2 as some
servers won't support the new mechanism yet.
Daniel Stenberg [Fri, 13 Nov 2015 22:40:40 +0000 (23:40 +0100)]
RELEASE-NOTES: recounted curl_easy_setopt() options
Daniel Stenberg [Fri, 13 Nov 2015 22:19:19 +0000 (23:19 +0100)]
typecheck-gcc.h: add missing slist-using options
CURLOPT_RESOLVE and CURLOPT_PROXYHEADER were missing
Also sorted the list.
Daniel Stenberg [Fri, 13 Nov 2015 22:12:18 +0000 (23:12 +0100)]
typecheck-gcc.h: added CURLOPT_CLOSESOCKETDATA
... and sorted curl_is_cb_data_option alphabetically
Sebastian Pohlschmidt [Fri, 13 Nov 2015 21:07:11 +0000 (16:07 -0500)]
openssl: Free modules on cleanup
Curl_ossl_init calls OPENSSL_load_builtin_modules() but
Curl_ossl_cleanup doesn't make a call to free these modules.
Bug: https://github.com/bagder/curl/issues/526
Steve Holme [Fri, 13 Nov 2015 20:42:35 +0000 (20:42 +0000)]
symbols-in-versions: Added new CURLOPTTYPE_STRINGPOINT alias
...following commit
aba281e762 to fix test 1119.
Daniel Stenberg [Fri, 13 Nov 2015 15:59:09 +0000 (16:59 +0100)]
curl: mark two more options strings for --libcurl output
Daniel Stenberg [Fri, 13 Nov 2015 15:53:17 +0000 (16:53 +0100)]
typecheck-gcc.h: add some missing string types
Also sorted that list alphabetically
Daniel Stenberg [Fri, 13 Nov 2015 15:50:10 +0000 (16:50 +0100)]
curl.h: introducing the STRINGPOINT alias
As an alias for OBJECTPOINT. Provided to allow us to grep for all string
options easier.
Daniel Stenberg [Fri, 13 Nov 2015 15:15:26 +0000 (16:15 +0100)]
cleanup: general removal of TODO (and similar) comments
They tend to never get updated anyway so they're frequently inaccurate
and we never go back to revisit them anyway. We document issues to work
on properly in KNOWN_BUGS and TODO instead.
Daniel Stenberg [Fri, 13 Nov 2015 15:12:18 +0000 (16:12 +0100)]
ftplistparser: remove empty function
Daniel Stenberg [Fri, 13 Nov 2015 14:55:52 +0000 (15:55 +0100)]
openssl: remove #if check for 0.9.7 for ENGINE_load_private_key
Daniel Stenberg [Fri, 13 Nov 2015 14:52:39 +0000 (15:52 +0100)]
openssl: all supported versions have X509_STORE_set_flags
Simplify by removing #ifdefs and macros
Daniel Stenberg [Fri, 13 Nov 2015 14:51:46 +0000 (15:51 +0100)]
openssl: remove 0.9.3 check
Daniel Stenberg [Fri, 13 Nov 2015 14:49:49 +0000 (15:49 +0100)]
openssl: remove #ifdefs for < 0.9.5 support
We only support >= 0.9.7
Daniel Stenberg [Fri, 13 Nov 2015 14:48:04 +0000 (15:48 +0100)]
lib/vtls/openssl: remove unused traces of yassl ifdefs
dfandrich [Thu, 12 Nov 2015 22:45:56 +0000 (23:45 +0100)]
unit1603: Demote hash mismatch failure to a warning
The hashes can vary between architectures (e.g. Sparc differs from x86_64).
This is not a fatal problem but just reduces the coverage of these white-box
tests, as the assumptions about into which hash bucket each key falls are no
longer valid.
dfandrich [Thu, 12 Nov 2015 19:40:26 +0000 (20:40 +0100)]
unit1603: Added unit tests for hash functions
dfandrich [Thu, 12 Nov 2015 18:30:59 +0000 (19:30 +0100)]
unit1602: Fixed failure in torture test
Steve Holme [Thu, 12 Nov 2015 19:45:24 +0000 (19:45 +0000)]
sasl: Re-introduced XOAUTH2 in the default enabled authentication mechanism
Following the fix in commit
d6d58dd558 it is necessary to re-introduce
XOAUTH2 in the default enabled authentication mechanism, which was
removed in commit
7b2012f262, otherwise users will have to specify
AUTH=XOAUTH2 in the URL.
Note: OAuth 2.0 will only be used when the bearer is specified.
Stefan Bühler [Thu, 12 Nov 2015 10:10:32 +0000 (11:10 +0100)]
sasl_sspi: fix identity memory leak in digest authentication
Stefan Bühler [Thu, 12 Nov 2015 10:09:21 +0000 (11:09 +0100)]
sasl_sspi: fixed unicode build for digest authentication
Closes #525
Steve Holme [Sat, 5 Sep 2015 16:32:37 +0000 (17:32 +0100)]
oauth2: Re-factored OAuth 2.0 state variable
Steve Holme [Sat, 5 Sep 2015 16:29:49 +0000 (17:29 +0100)]
sasl: Don't choose OAuth 2.0 if mechanism not advertised
Regression from commit
9e8ced9890 which meant if --oauth2-bearer was
specified but the SASL mechanism wasn't supported by the server then
the mechanism would be chosen.
Daniel Stenberg [Thu, 12 Nov 2015 14:32:48 +0000 (15:32 +0100)]
runtests: more compact "System characteristics" output
- no point in repeating curl features that is already listed as features
from the curl -V output
- remove the port numbers/unix domain path from the output unless
verbose is used, as that is rarely interesting to users.
Daniel Stenberg [Thu, 12 Nov 2015 13:50:13 +0000 (14:50 +0100)]
runtests: rename conditional curl-features to $has_[name]
Steve Holme [Sat, 5 Sep 2015 16:08:54 +0000 (17:08 +0100)]
oauth2: Introduced support for host and port details
Added support to the OAuth 2.0 message function for host and port, in
order to accommodate the official OAUTHBEARER SASL mechanism which is
to be added shortly.
Steve Holme [Wed, 11 Nov 2015 22:19:39 +0000 (22:19 +0000)]
curl_setup.h: Removed duplicate CURL_DISABLE_RTSP when HTTP_ONLY defined
Steve Holme [Wed, 11 Nov 2015 22:18:24 +0000 (22:18 +0000)]
cmake: Add missing feature macros in config header (Part 2)
In addition to commit
a215381c94 added the RTSP, RTMP and SMB protocols.
Douglas Creager [Tue, 10 Nov 2015 19:46:49 +0000 (14:46 -0500)]
cmake: Add missing feature macros in config header
The curl_config.h file can be generated either from curl_config.h.cmake
or curl_config.h.in, depending on whether you're building using CMake or
the autotools. The CMake template header doesn't include entries for
all of the protocols that you can disable, which (I think) means that
you can't actually disable those protocols when building via CMake.
Closes #523
Douglas Creager [Tue, 10 Nov 2015 20:05:18 +0000 (15:05 -0500)]
BoringSSL: Work with stricter BIO_get_mem_data()
BoringSSL implements `BIO_get_mem_data` as a function, instead of a
macro, and expects the output pointer to be a `char **`. We have to add
an explicit cast to grab the pointer as a `const char **`.
Closes #524
Daniel Stenberg [Tue, 10 Nov 2015 08:10:46 +0000 (09:10 +0100)]
http2: rectify the http2 version #if check
We need 1.0.0 or later. Also verified by configure.
Steve Holme [Wed, 4 Nov 2015 07:20:21 +0000 (07:20 +0000)]
oauth2: Don't use XAUTH2 in OAuth 2.0 function name
Steve Holme [Fri, 4 Sep 2015 06:11:09 +0000 (07:11 +0100)]
oauth2: Don't use XOAUTH2 in OAuth 2.0 variables
Steve Holme [Fri, 4 Sep 2015 05:56:26 +0000 (06:56 +0100)]
oauth2: Use OAuth 2.0 rather than XOAUTH2 in comments
When referring to OAuth 2.0 we should use the official name rather the
SASL mechanism name.
Daniel Stenberg [Mon, 9 Nov 2015 09:54:55 +0000 (10:54 +0100)]
imap: avoid freeing constant string
The fix in
1a614c6c3 was wrong and would leed to free() of a fixed
string.
Pointed-out-by: Kamil Dudka
Daniel Stenberg [Mon, 9 Nov 2015 08:05:43 +0000 (09:05 +0100)]
ROADMAP: remove two items already done
Daniel Stenberg [Mon, 9 Nov 2015 07:56:28 +0000 (08:56 +0100)]
RELEASE-NOTES: synced with
2200bf62054
Jay Satiro [Mon, 9 Nov 2015 07:56:40 +0000 (02:56 -0500)]
acinclude: Remove check for 16-bit curl_off_t
Because it's illogical to check for a 16-bit curl_off_t.
Ref: https://github.com/bagder/curl/issues/425#issuecomment-
154964205
Dan Fandrich [Sun, 8 Nov 2015 15:50:25 +0000 (16:50 +0100)]
tool: Fixed a memory leak on OOM introduced in
19cb0c4a
Justin Ehlert [Tue, 13 Oct 2015 13:55:05 +0000 (08:55 -0500)]
imap: Don't check for continuation when executing a CUSTOMREQUEST
Bug: https://github.com/bagder/curl/issues/486
Closes https://github.com/bagder/curl/pull/487
Daniel Stenberg [Sat, 7 Nov 2015 22:21:29 +0000 (23:21 +0100)]
imap: checksrc: remove space after while before paren
Daniel Stenberg [Sat, 7 Nov 2015 22:20:50 +0000 (23:20 +0100)]
checksrc.whitelist: "missing space after close paren"
... when it was within a string!
Steve Holme [Sat, 7 Nov 2015 22:11:04 +0000 (22:11 +0000)]
opts: Corrected TLS protocols list to include POP3S rather than POP3
Steve Holme [Sat, 7 Nov 2015 11:59:32 +0000 (11:59 +0000)]
imap: Quote other 'atom-specials' and not just the space character
Closes #517
Steve Holme [Sat, 7 Nov 2015 11:20:34 +0000 (11:20 +0000)]
imap: Fixed double quote in LIST command when mailbox contains spaces
Daniel Stenberg [Fri, 6 Nov 2015 22:44:27 +0000 (23:44 +0100)]
imap: fix compiler warning
imap.c:657:13: error: assignment discards 'const' qualifier from pointer
target type [-Werror=discarded-qualifiers]
Steve Holme [Fri, 6 Nov 2015 21:49:26 +0000 (21:49 +0000)]
imap: Don't call imap_atom() when no mailbox specified in LIST command
Daniel Stenberg [Fri, 6 Nov 2015 14:03:00 +0000 (15:03 +0100)]
curl.1: remove the overlap --range example
... it is just weird to include by default even if it still works.
Daniel Stenberg [Fri, 6 Nov 2015 09:52:19 +0000 (10:52 +0100)]
tftp tests: verify sent options too
The tftpd test server now logs all received options and thus all TFTP
test cases need to match them exactly.
Extended test 283 to use and verify --tftp-blksize.
Jay Satiro [Fri, 6 Nov 2015 05:30:16 +0000 (00:30 -0500)]
getinfo: CURLINFO_ACTIVESOCKET: fix bad socket value
- Set user info param to the socket returned by Curl_getconnectinfo,
regardless of if the socket is bad. Effectively this means the user info
param now will receive CURL_SOCKET_BAD instead of -1 on bad socket.
- Remove incorrect comments.
CURLINFO_ACTIVESOCKET is documented to write CURL_SOCKET_BAD to user
info param but prior to this change it wrote -1.
Bug: https://github.com/bagder/curl/pull/518
Reported-by: Marcel Raad
Patrick Monnerat [Thu, 5 Nov 2015 14:20:43 +0000 (15:20 +0100)]
curl_ntlm_core: fix 2 curl_off_t constant overflows.