]> granicus.if.org Git - neomutt/log
neomutt
6 years agomerge: refactoring to simplify functions
Richard Russon [Tue, 6 Mar 2018 13:27:52 +0000 (13:27 +0000)]
merge: refactoring to simplify functions

 * Avoid unnecessary reassignment
 * Restore old behaviour
 * Reduce variable scope and avoid conversion
 * Refactor decode_xbit
 * Refactor encode_block
 * Remove unused variable

6 years agomerge: refactor to reduce variable scope
Richard Russon [Tue, 6 Mar 2018 13:13:59 +0000 (13:13 +0000)]
merge: refactor to reduce variable scope

These changes should not affect the behaviour of the code.

 * init.c
 * main.c
 * mbox.c
 * menu.c
 * mh.c
 * mutt/base64.c
 * mutt/charset.c
 * mutt/file.c
 * mutt/hash.c
 * mutt/rfc2047.c
 * mutt_notmuch.c
 * muttlib.c
 * mx.c
 * ncrypt/crypt.c
 * ncrypt/crypt_gpgme.c
 * ncrypt/pgp.c
 * ncrypt/smime.c

6 years agoReduce variable scope - ncrypt/smime.c
Federico Kircheis [Mon, 5 Mar 2018 18:20:19 +0000 (19:20 +0100)]
Reduce variable scope - ncrypt/smime.c

6 years agoReduce variable scope - ncrypt/pgp.c
Federico Kircheis [Mon, 5 Mar 2018 18:13:26 +0000 (19:13 +0100)]
Reduce variable scope - ncrypt/pgp.c

6 years agoReduce variable scope - ncrypt/crypt_gpgme.c
Federico Kircheis [Mon, 5 Mar 2018 18:11:48 +0000 (19:11 +0100)]
Reduce variable scope - ncrypt/crypt_gpgme.c

6 years agoReduce variable scope - ncrypt/crypt.c
Federico Kircheis [Mon, 5 Mar 2018 18:03:41 +0000 (19:03 +0100)]
Reduce variable scope - ncrypt/crypt.c

6 years agoReduce variable scope - mx.c
Federico Kircheis [Mon, 5 Mar 2018 17:58:53 +0000 (18:58 +0100)]
Reduce variable scope - mx.c

6 years agoReduce variable scope - muttlib.c
Federico Kircheis [Mon, 5 Mar 2018 17:56:03 +0000 (18:56 +0100)]
Reduce variable scope - muttlib.c

6 years agoReduce variable scope - mutt_notmuch.c
Federico Kircheis [Mon, 5 Mar 2018 17:55:45 +0000 (18:55 +0100)]
Reduce variable scope - mutt_notmuch.c

6 years agoReduce variable scope - mutt/rfc2047.c
Federico Kircheis [Mon, 5 Mar 2018 17:48:59 +0000 (18:48 +0100)]
Reduce variable scope - mutt/rfc2047.c

6 years agoReduce variable scope - mutt/hash.c
Federico Kircheis [Mon, 5 Mar 2018 17:39:47 +0000 (18:39 +0100)]
Reduce variable scope - mutt/hash.c

6 years agoReduce variable scope - mutt/file.c
Federico Kircheis [Mon, 5 Mar 2018 17:37:13 +0000 (18:37 +0100)]
Reduce variable scope - mutt/file.c

6 years agoReduce variable scope - mutt/charset.c
Federico Kircheis [Mon, 5 Mar 2018 17:34:58 +0000 (18:34 +0100)]
Reduce variable scope - mutt/charset.c

6 years agoReduce variable scope - mutt/base64.c
Federico Kircheis [Mon, 5 Mar 2018 17:34:51 +0000 (18:34 +0100)]
Reduce variable scope - mutt/base64.c

6 years agoReduce variable scope - mh.c
Federico Kircheis [Mon, 5 Mar 2018 17:17:44 +0000 (18:17 +0100)]
Reduce variable scope - mh.c

6 years agoReduce variable scope - menu.c
Federico Kircheis [Mon, 5 Mar 2018 17:16:14 +0000 (18:16 +0100)]
Reduce variable scope - menu.c

6 years agoReduce variable scope - mbox.c
Federico Kircheis [Mon, 5 Mar 2018 17:10:53 +0000 (18:10 +0100)]
Reduce variable scope - mbox.c

6 years agoReduce variable scope - main.c
Federico Kircheis [Mon, 5 Mar 2018 17:10:43 +0000 (18:10 +0100)]
Reduce variable scope - main.c

6 years agoReduce variable scope - init.c
Federico Kircheis [Mon, 5 Mar 2018 17:10:31 +0000 (18:10 +0100)]
Reduce variable scope - init.c

6 years agoRemove unused variable
Federico Kircheis [Mon, 5 Mar 2018 18:19:05 +0000 (19:19 +0100)]
Remove unused variable

6 years agoRefactor encode_block
Federico Kircheis [Mon, 5 Mar 2018 17:50:56 +0000 (18:50 +0100)]
Refactor encode_block

6 years agoFallback to C.UTF-8 if en_US.UTF-8 cannot be set
Pietro Cerutti [Mon, 5 Mar 2018 12:47:48 +0000 (12:47 +0000)]
Fallback to C.UTF-8 if en_US.UTF-8 cannot be set

* Fallback to C.UTF-8 if en_US.UTF-8 cannot be set

Issue #1088

6 years agonotmuch_database_open_verbose is in API 4.2.0 + refactor conditional
Pietro Cerutti [Mon, 5 Mar 2018 12:14:11 +0000 (12:14 +0000)]
notmuch_database_open_verbose is in API 4.2.0 + refactor conditional

Issue #1076

6 years agonotmuch: stop if db open fails
Richard Russon [Tue, 27 Feb 2018 13:29:44 +0000 (13:29 +0000)]
notmuch: stop if db open fails

* If the database open fails, stop
* Use the verbose version of open so we can catch the error message

issue #1076

6 years agomerge: refactor to reduce variable scope
Richard Russon [Sat, 3 Mar 2018 13:42:42 +0000 (13:42 +0000)]
merge: refactor to reduce variable scope

These changes should not affect the behaviour of the code.

 * alias.c
 * attach.c
 * browser.c
 * buffy.c
 * color.c
 * commands.c
 * compose.c
 * conn/getdomain.c
 * conn/socket.c
 * conn/ssl.c
 * conn/ssl_gnutls.c
 * conn/tunnel.c
 * copy.c
 * curs_lib.c
 * curs_main.c
 * doc/makedoc.c
 * filter.c
 * from.c
 * handler.c
 * hdrline.c
 * header.c
 * help.c
 * hook.c
 * imap/auth_cram.c
 * imap/command.c
 * imap/imap.c
 * imap/util.c
 * init.c
 * keymap.c

6 years agoReduce variable scope - keymap.c
Federico Kircheis [Sat, 3 Mar 2018 08:38:37 +0000 (09:38 +0100)]
Reduce variable scope - keymap.c

6 years agoReduce variable scope - init.c
Federico Kircheis [Sat, 3 Mar 2018 08:44:21 +0000 (09:44 +0100)]
Reduce variable scope - init.c

6 years agoReduce variable scope - imap/util.c
Federico Kircheis [Sat, 3 Mar 2018 08:35:42 +0000 (09:35 +0100)]
Reduce variable scope - imap/util.c

6 years agoReduce variable scope - imap/imap.c
Federico Kircheis [Sat, 3 Mar 2018 08:35:37 +0000 (09:35 +0100)]
Reduce variable scope - imap/imap.c

6 years agoReduce variable scope - imap/command.c
Federico Kircheis [Sat, 3 Mar 2018 08:35:31 +0000 (09:35 +0100)]
Reduce variable scope - imap/command.c

6 years agoReduce variable scope - imap/auth_cram.c
Federico Kircheis [Sat, 3 Mar 2018 08:35:26 +0000 (09:35 +0100)]
Reduce variable scope - imap/auth_cram.c

6 years agoReduce variable scope - hook.c
Federico Kircheis [Sat, 3 Mar 2018 08:29:06 +0000 (09:29 +0100)]
Reduce variable scope - hook.c

6 years agoReduce variable scope - help.c
Federico Kircheis [Sat, 3 Mar 2018 08:24:36 +0000 (09:24 +0100)]
Reduce variable scope - help.c

6 years agoReduce variable scope - header.c
Federico Kircheis [Sat, 3 Mar 2018 08:15:56 +0000 (09:15 +0100)]
Reduce variable scope - header.c

6 years agoReduce variable scope - hdrline.c
Federico Kircheis [Fri, 2 Mar 2018 18:54:47 +0000 (19:54 +0100)]
Reduce variable scope - hdrline.c

6 years agoReduce variable scope - handler.c
Federico Kircheis [Fri, 2 Mar 2018 18:48:26 +0000 (19:48 +0100)]
Reduce variable scope - handler.c

6 years agoReduce variable scope - from.c
Federico Kircheis [Fri, 2 Mar 2018 18:20:45 +0000 (19:20 +0100)]
Reduce variable scope - from.c

6 years agoReduce variable scope - filter.c
Federico Kircheis [Fri, 2 Mar 2018 18:19:33 +0000 (19:19 +0100)]
Reduce variable scope - filter.c

6 years agoReduce variable scope - doc/makedoc.c
Federico Kircheis [Fri, 2 Mar 2018 18:19:07 +0000 (19:19 +0100)]
Reduce variable scope - doc/makedoc.c

6 years agoReduce variable scope - curs_main.c
Federico Kircheis [Thu, 1 Mar 2018 17:08:27 +0000 (18:08 +0100)]
Reduce variable scope - curs_main.c

6 years agoReduce variable scope - curs_lib.c
Federico Kircheis [Thu, 1 Mar 2018 17:07:43 +0000 (18:07 +0100)]
Reduce variable scope - curs_lib.c

6 years agoReduce variable scope - copy.c
Federico Kircheis [Wed, 28 Feb 2018 19:39:16 +0000 (20:39 +0100)]
Reduce variable scope - copy.c

6 years agoReduce variable scope - conn/tunnel.c
Federico Kircheis [Thu, 1 Mar 2018 17:57:18 +0000 (18:57 +0100)]
Reduce variable scope - conn/tunnel.c

6 years agoReduce variable scope - conn/ssl_gnutls.c
Federico Kircheis [Thu, 1 Mar 2018 17:55:03 +0000 (18:55 +0100)]
Reduce variable scope - conn/ssl_gnutls.c

6 years agoReduce variable scope - conn/ssl.c
Federico Kircheis [Thu, 1 Mar 2018 17:52:41 +0000 (18:52 +0100)]
Reduce variable scope - conn/ssl.c

6 years agoReduce variable scope - conn/socket.c
Federico Kircheis [Thu, 1 Mar 2018 17:52:08 +0000 (18:52 +0100)]
Reduce variable scope - conn/socket.c

6 years agoReduce variable scope - conn/getdomain.c
Federico Kircheis [Thu, 1 Mar 2018 17:33:32 +0000 (18:33 +0100)]
Reduce variable scope - conn/getdomain.c

6 years agoReduce variable scope - compose.c
Federico Kircheis [Wed, 28 Feb 2018 19:39:35 +0000 (20:39 +0100)]
Reduce variable scope - compose.c

6 years agoReduce variable scope - commands.c
Federico Kircheis [Wed, 28 Feb 2018 19:39:29 +0000 (20:39 +0100)]
Reduce variable scope - commands.c

6 years agoReduce variable scope - color.c
Federico Kircheis [Wed, 28 Feb 2018 19:39:22 +0000 (20:39 +0100)]
Reduce variable scope - color.c

6 years agoReduce variable scope - buffy.c
Federico Kircheis [Thu, 1 Mar 2018 17:14:55 +0000 (18:14 +0100)]
Reduce variable scope - buffy.c

6 years agoReduce variable scope - browser.c
Federico Kircheis [Thu, 1 Mar 2018 17:13:17 +0000 (18:13 +0100)]
Reduce variable scope - browser.c

6 years agoReduce variable scope - attach.c
Federico Kircheis [Thu, 1 Mar 2018 17:03:51 +0000 (18:03 +0100)]
Reduce variable scope - attach.c

6 years agoReduce variable scope - alias.c
Federico Kircheis [Wed, 28 Feb 2018 19:10:46 +0000 (20:10 +0100)]
Reduce variable scope - alias.c

6 years agoRefactor decode_xbit
Federico Kircheis [Sat, 3 Mar 2018 08:12:34 +0000 (09:12 +0100)]
Refactor decode_xbit

Reduce number of scopes, should improve readability

6 years agoReduce variable scope and avoid conversion
Federico Kircheis [Fri, 2 Mar 2018 18:32:28 +0000 (19:32 +0100)]
Reduce variable scope and avoid conversion

6 years agoFix usage of mutt_progress_init after b310689
Pietro Cerutti [Wed, 28 Feb 2018 12:07:16 +0000 (12:07 +0000)]
Fix usage of mutt_progress_init after b310689

6 years agoRestore old behaviour
Federico Kircheis [Wed, 28 Feb 2018 19:32:03 +0000 (20:32 +0100)]
Restore old behaviour

and remove unused variable

6 years agoAvoid unnecessary reassignment
Federico Kircheis [Wed, 28 Feb 2018 19:11:05 +0000 (20:11 +0100)]
Avoid unnecessary reassignment

6 years agodocs: Clarify precedence of settings in config files
rawtaz [Wed, 28 Feb 2018 15:21:20 +0000 (16:21 +0100)]
docs: Clarify precedence of settings in config files

6 years agoMove address to libmutt and merge it with mutt_address
Pietro Cerutti [Mon, 26 Feb 2018 12:14:10 +0000 (12:14 +0000)]
Move address to libmutt and merge it with mutt_address

6 years agoUpdate to latest autosetup
Pietro Cerutti [Tue, 27 Feb 2018 11:23:47 +0000 (11:23 +0000)]
Update to latest autosetup

Issue #1071

6 years agofix: add missing library externs
Richard Russon [Sun, 25 Feb 2018 12:28:23 +0000 (12:28 +0000)]
fix: add missing library externs

6 years agoNeoMutt 2018-02-23 neomutt-20180223
Richard Russon [Fri, 23 Feb 2018 03:03:54 +0000 (03:03 +0000)]
NeoMutt 2018-02-23

6 years agoupdate translations
Richard Russon [Thu, 22 Feb 2018 15:11:21 +0000 (15:11 +0000)]
update translations

6 years agoclang-format
Richard Russon [Thu, 22 Feb 2018 15:02:25 +0000 (15:02 +0000)]
clang-format

6 years agonew contributors
Richard Russon [Wed, 21 Feb 2018 14:22:53 +0000 (14:22 +0000)]
new contributors

6 years agochangelog
Richard Russon [Thu, 22 Feb 2018 14:49:38 +0000 (14:49 +0000)]
changelog

6 years agoversion 2018-02-23
Richard Russon [Thu, 22 Feb 2018 14:45:52 +0000 (14:45 +0000)]
version 2018-02-23

6 years agofix: missing ! when checking regex pointer
Theo [Thu, 22 Feb 2018 06:51:09 +0000 (07:51 +0100)]
fix: missing ! when checking regex pointer

6 years agomerge: trivial improvements
Richard Russon [Wed, 21 Feb 2018 01:25:22 +0000 (01:25 +0000)]
merge: trivial improvements

 * doxygen fix comments
 * use exit
 * constants
 * disable the folder-hook for $record
 * unused variables
 * fix redundant code

6 years agofix redundant code
Richard Russon [Wed, 21 Feb 2018 01:22:21 +0000 (01:22 +0000)]
fix redundant code

6 years agounused variables
Richard Russon [Wed, 21 Feb 2018 01:19:34 +0000 (01:19 +0000)]
unused variables

These variables set then either
- overwritten before being used
- not used before going out of scope

6 years agodisable the folder-hook for $record
Richard Russon [Fri, 16 Feb 2018 14:21:24 +0000 (14:21 +0000)]
disable the folder-hook for $record

It's possible to use $record to save an email to a different account.
The right thing to do is to call the `folder-hook` for the save folder,
save the email, then call the `folder-hook` for the 'current' folder.

Calling the hook this way causes problems for lots of people who have
commands in their hooks that are called when they didn't expect.

The hooks are left in the code wrapped in: `#ifdef RECORD_FOLDER_HOOK`

6 years agoconstants
Richard Russon [Sat, 17 Feb 2018 14:30:07 +0000 (14:30 +0000)]
constants

6 years agouse exit
Richard Russon [Sat, 17 Feb 2018 14:18:24 +0000 (14:18 +0000)]
use exit

6 years agodoxygen fix comments
Richard Russon [Mon, 5 Feb 2018 15:46:54 +0000 (15:46 +0000)]
doxygen fix comments

6 years agomerge: upstream fixes
Richard Russon [Tue, 20 Feb 2018 22:12:32 +0000 (22:12 +0000)]
merge: upstream fixes

 * Remove useless assignments in add_to_list functions.
 * Add history-search function, bound to ctrl-r.
 * Avoid a potential integer overflow if a Content-Length value is huge.
 * Updated French translation.
 * update translations

6 years agoupdate translations
Richard Russon [Sun, 21 Jan 2018 02:10:45 +0000 (02:10 +0000)]
update translations

6 years agoUpdated French translation.
Vincent Lefevre [Sun, 4 Feb 2018 17:29:52 +0000 (18:29 +0100)]
Updated French translation.

6 years agoAvoid a potential integer overflow if a Content-Length value is huge.
Vincent Lefevre [Wed, 14 Feb 2018 09:33:41 +0000 (10:33 +0100)]
Avoid a potential integer overflow if a Content-Length value is huge.

6 years agoAdd history-search function, bound to ctrl-r.
Kevin McCarthy [Sun, 4 Feb 2018 02:08:28 +0000 (18:08 -0800)]
Add history-search function, bound to ctrl-r.

Create a very basic "search history" functionality in the line editor.
It uses the current input, and searches backward through history.  If
there is one match, it immediately uses that otherwise it pops up a
simple menu of matches.

6 years agoRemove useless assignments in add_to_list functions.
Kevin McCarthy [Mon, 22 Jan 2018 03:41:47 +0000 (19:41 -0800)]
Remove useless assignments in add_to_list functions.

The code was probably pulled from some of the header processing
functions, which were in a loop.  In those versions, "last" pointed to
a collection of new entries appended, but in these two functions,
updating last just obfuscates the code.

6 years agoAllow choosing a particular version of BerkeleyDB via --with-bdb-version (#1064)
Pietro Cerutti [Mon, 19 Feb 2018 12:38:23 +0000 (12:38 +0000)]
Allow choosing a particular version of BerkeleyDB via --with-bdb-version (#1064)

Fix #1005

6 years agofix regexes using '\!' (not) (#1062)
Richard Russon [Thu, 15 Feb 2018 15:44:13 +0000 (15:44 +0000)]
fix regexes using '\!' (not) (#1062)

The flag, in struct Option, allowing a regex to use a '!' (not) is part
of the type, not the flags field.

6 years agoFix decoding of parameter in RFC2231 format (#1061)
Pietro Cerutti [Thu, 15 Feb 2018 12:10:11 +0000 (12:10 +0000)]
Fix decoding of parameter in RFC2231 format (#1061)

Issue #1060

6 years agoNcurses always has resizeterm, remove unnecessary ifdefs
Pietro Cerutti [Tue, 13 Feb 2018 13:57:34 +0000 (13:57 +0000)]
Ncurses always has resizeterm, remove unnecessary ifdefs

Issue #1057

6 years agoSplit HAVE_RESIZE out of HAVE_RESIZETERM
Pietro Cerutti [Tue, 13 Feb 2018 12:57:14 +0000 (12:57 +0000)]
Split HAVE_RESIZE out of HAVE_RESIZETERM

6 years agoUpdate autosetup, use negated and nested conditionals in @if substitutions
Pietro Cerutti [Tue, 13 Feb 2018 11:00:45 +0000 (11:00 +0000)]
Update autosetup, use negated and nested conditionals in @if substitutions

6 years agofix crash when decoding parameters (#1056)
Richard Russon [Mon, 12 Feb 2018 12:31:48 +0000 (12:31 +0000)]
fix crash when decoding parameters (#1056)

6 years agoFix out-of-bounds read in mutt_str_lws_len
Pietro Cerutti [Mon, 12 Feb 2018 08:38:30 +0000 (08:38 +0000)]
Fix out-of-bounds read in mutt_str_lws_len

Issue #1054

6 years agoAlternative way to check for DocBook DTD
Pietro Cerutti [Thu, 8 Feb 2018 12:04:20 +0000 (12:04 +0000)]
Alternative way to check for DocBook DTD

6 years agomerge: regex fixes
Richard Russon [Sat, 10 Feb 2018 00:14:00 +0000 (00:14 +0000)]
merge: regex fixes

 * fix partial initialisation of Regex config
 * carefully check all regex pointers
 * Fix free_opt for regex

6 years agoFix free_opt for regex 1052/head
Pietro Cerutti [Fri, 9 Feb 2018 09:03:12 +0000 (09:03 +0000)]
Fix free_opt for regex

6 years agocarefully check all regex pointers
Richard Russon [Fri, 9 Feb 2018 03:41:26 +0000 (03:41 +0000)]
carefully check all regex pointers

6 years agofix partial initialisation of Regex config
Richard Russon [Fri, 9 Feb 2018 03:28:45 +0000 (03:28 +0000)]
fix partial initialisation of Regex config

6 years agoconfigure: Check for Docbook DTDs
Richard Russon [Thu, 8 Feb 2018 10:54:41 +0000 (10:54 +0000)]
configure: Check for Docbook DTDs

* configure: Check for Docbook DTDs

Run xsltproc with a minimal Docbook file.
If this succeeds, then the docs will probably build correctly.

Co-authored-by: Pietro Cerutti <gahr@gahr.ch>
6 years agoTidy parameter API, switch to TAILQ
Pietro Cerutti [Fri, 2 Feb 2018 15:46:42 +0000 (15:46 +0000)]
Tidy parameter API, switch to TAILQ

6 years agoMove parameter.[ch] to mutt/
Pietro Cerutti [Thu, 1 Feb 2018 16:07:14 +0000 (16:07 +0000)]
Move parameter.[ch] to mutt/

6 years agotrim some hcache descriptions
Richard Russon [Thu, 1 Feb 2018 17:23:29 +0000 (17:23 +0000)]
trim some hcache descriptions