nekral-guest [Thu, 24 Jan 2008 20:54:42 +0000 (20:54 +0000)]
Re-indent.
nekral-guest [Thu, 24 Jan 2008 20:42:12 +0000 (20:42 +0000)]
Replace printf by puts for fixed strings. This would avoid issues caused
by formats introduced in translated strings.
nekral-guest [Thu, 24 Jan 2008 19:50:09 +0000 (19:50 +0000)]
Re-indent.
nekral-guest [Thu, 24 Jan 2008 19:38:06 +0000 (19:38 +0000)]
Replace printf by puts for fixed strings. This would avoid issues caused
by formats introduced in translated strings.
nekral-guest [Thu, 24 Jan 2008 19:24:03 +0000 (19:24 +0000)]
Re-indent.
nekral-guest [Thu, 24 Jan 2008 18:39:05 +0000 (18:39 +0000)]
Replace printf by puts for fixed strings. This would avoid issues caused
by formats introduced in translated strings.
nekral-guest [Wed, 23 Jan 2008 23:48:39 +0000 (23:48 +0000)]
adduser was a typo. Move the adduser entries to the useradd section.
nekral-guest [Wed, 23 Jan 2008 22:31:38 +0000 (22:31 +0000)]
Apply Christian's recommendation:
s/can't get unique/no more available/
nekral-guest [Wed, 23 Jan 2008 21:50:27 +0000 (21:50 +0000)]
Check that the new fields set with -u, -s, -l, -g, -f, -e, -d, and -c
differ from the old ones. If a requested new value is equal to the old
one, no changes will be performed for that field. If no fields are
changed, usermod will exist successfully with a warning. This avoids
logging changes to syslog when there are actually no changes.
nekral-guest [Wed, 23 Jan 2008 21:19:08 +0000 (21:19 +0000)]
Always define user_newcomment, user_newshell, user_newexpire, and
user_newinactive. It is more simple to always have user_<x> as the old
field, and user_new<x> as the new field (even if the field did not change)
instead of changing the algorithm depending on WITH_AUDIT.
nekral-guest [Wed, 23 Jan 2008 20:08:16 +0000 (20:08 +0000)]
user_newname can only be used in WITH_AUDIT code or when lflg is set. This
issue was introduced in the code refactoring of usermod.
nekral-guest [Tue, 22 Jan 2008 22:59:06 +0000 (22:59 +0000)]
Fix typo in comment: s/find_new_uid/find_new_gid/
nekral-guest [Tue, 22 Jan 2008 22:57:55 +0000 (22:57 +0000)]
* s/gid/GID/ in message string.
* Set this string for translation.
nekral-guest [Tue, 22 Jan 2008 21:42:48 +0000 (21:42 +0000)]
* man/grpck.8.xml: Conditionally include the parts mentioning the
gshadow file (based on SHADOWGRP).
* man/grpck.8.xml: Add reference to the gshadow(5) manpage
(conditionally included).
nekral-guest [Tue, 22 Jan 2008 21:15:58 +0000 (21:15 +0000)]
Fix typo. Remove "the" from "All entries in the <filename></filename> are
checked [...]"
nekral-guest [Tue, 22 Jan 2008 21:13:43 +0000 (21:13 +0000)]
Indicate that the shadow parameter is optional (i.e. a passwd file can be
specified without a shadow file, and the group file can be specified
without the gshadow file).
nekral-guest [Tue, 22 Jan 2008 20:56:13 +0000 (20:56 +0000)]
Document the options with a list of options, as in the pwck(8) manpage.
nekral-guest [Mon, 21 Jan 2008 23:33:43 +0000 (23:33 +0000)]
* NEWS, src/newgrp.c: Fix segfault when an user returns to an
unknown GID (either the user was deleted during the user's newgrp
session or the user's passwd entry referenced an invalid group).
Add a syslog warning in that case.
* src/newgrp.c: Add an end of line when reporting an invalid
password.
nekral-guest [Sat, 12 Jan 2008 21:09:46 +0000 (21:09 +0000)]
* NEWS, src/useradd.c: Fix the handling of the --defaults option
(it required an argument, but should behave as -D)
* NEWS, man/useradd.8.xml: Document the --defaults option, which
was already described in the useradd's Usage information.
nekral-guest [Sun, 6 Jan 2008 19:26:58 +0000 (19:26 +0000)]
Avoid setting the password to a const empty string, but set the first char to \0. This avoids a warning.
nekral-guest [Sun, 6 Jan 2008 14:50:26 +0000 (14:50 +0000)]
* libmisc/salt.c: Add prototype for l64a(), gensalt(),
SHA_salt_size(), and SHA_salt_rounds().
* libmisc/salt.c: l64a() and gensalt() are static.
* libmisc/salt.c: The `meth' parameter of crypt_make_salt() is a
const. (ditto for the method variable).
* libmisc/salt.c: SHA_salt_rounds returns a const string.
* libmisc/salt.c: Avoid warnings with cast of random() to double.
* libmisc/salt.c: Replace rand() by random().
nekral-guest [Sun, 6 Jan 2008 14:19:32 +0000 (14:19 +0000)]
* lib/Makefile.am: Do not link libshadow.la with the intl, crypt,
skey and md libraries...
* src/Makefile.am: ...Specify for each binary which library is
required. skey and md are required for the binaries with
authentication of the user (chfn, chsh, login, passwd, su). intl
is required for all. mcrypt is required for user (chfn, chsh,
login, passwd, su, sulogin) and group (newgrp, gpasswd)
authentication and for the creation of passwords (chpasswd,
chgpasswd, gpasswd, newusers, passwd).
nekral-guest [Sun, 6 Jan 2008 13:57:17 +0000 (13:57 +0000)]
* lib/nscd.c, lib/nscd.h: Set the service parameter of
nscd_flush_cache() to const. This avoids a lot of warnings.
* lib/nscd.c: Include "nscd.h" to avoid inconsistent prototypes.
nekral-guest [Sun, 6 Jan 2008 13:52:21 +0000 (13:52 +0000)]
Remove prototypes for __gr_dup() and __gr_set_changed().
nekral-guest [Sun, 6 Jan 2008 13:49:00 +0000 (13:49 +0000)]
Set the method string as a constant string.
nekral-guest [Sun, 6 Jan 2008 13:42:47 +0000 (13:42 +0000)]
Assume <errno.h> declares errno.
nekral-guest [Sun, 6 Jan 2008 13:38:16 +0000 (13:38 +0000)]
* Remove prototype for sgetgrent().
* Add the name of the parameters for merge_group_entries() and split_groups().
nekral-guest [Sun, 6 Jan 2008 13:32:25 +0000 (13:32 +0000)]
Fix typo: s/rend compte indiqué/rend le compte indiqué/
nekral-guest [Sun, 6 Jan 2008 13:30:18 +0000 (13:30 +0000)]
* Remove prototype of check_su_auth(). It is redundant with prototypes.h.
* isgrp() is static.
nekral-guest [Sun, 6 Jan 2008 13:20:25 +0000 (13:20 +0000)]
* libmisc/obscure.c: Tag the `old' parameter of palindrome(),
similar(), and simple() as unused.
* libmisc/loginprompt.c: Tag the `sig' parameter of login_exit()
as unused.
* src/expiry.c: Tag the `sig' parameter of catch_signals() as
unused.
* src/su.c: Tag the `sig' parameter of catch_signals() as unused.
* src/su.c: Add int parameter to the prototype of oldsig().
* src/login.c: Tag the `sig' parameter of alarm_handler() as
unused.
* src/sulogin.c: Tag the `sig' parameter of catch_signals() as
unused.
* libmisc/getdate.y: Tag the `string' parameter of yyerror() as
unused.
* libmisc/getdate.y: The string provided to yyerror() is const.
* libmisc/getdate.y: Fix the prototypes of yylex() and yyerror().
nekral-guest [Sun, 6 Jan 2008 13:12:09 +0000 (13:12 +0000)]
* Remove teh macro definition of SETXXENT_TYPE,
SETXXENT_RET, and SETXXENT_TEST. They were used by the now
removed pwent.c and grent.c.
* Remove the definition of PASSWD_PAG_FILE,
GROUP_PAG_FILE, SHADOW_PAG_FILE, and SGROUP_PAG_FILE. They are
never used.
* Don't include "snprintf.h". The file does not
exist in shadow.
* Add new macro unused to tag unused parameters.
nekral-guest [Sun, 6 Jan 2008 13:00:17 +0000 (13:00 +0000)]
Remove prototypes for __pw_del_entry(), __pw_get_head(), __spw_del_entry(), and __spw_get_head().
nekral-guest [Sun, 6 Jan 2008 12:52:23 +0000 (12:52 +0000)]
Assume optarg and optind are declared in <getopt.h>.
nekral-guest [Sun, 6 Jan 2008 12:50:22 +0000 (12:50 +0000)]
Remove the pw_name argument of new_pw_passwd. Use the user_newname global
variable instead. This avoid using a parameter with the same name as a function.
nekral-guest [Sun, 6 Jan 2008 12:31:06 +0000 (12:31 +0000)]
* Removed unused gid parameter of syslog_sg().
* The loginname and tty buffers are never changed. Add the const qualifier.
nekral-guest [Sun, 6 Jan 2008 12:26:20 +0000 (12:26 +0000)]
The crypt_method string always points to a constant string. Add the const qualifier.
nekral-guest [Sun, 6 Jan 2008 12:12:30 +0000 (12:12 +0000)]
Remove prototype of l64a() (not used in pwunconv).
nekral-guest [Sun, 6 Jan 2008 12:09:38 +0000 (12:09 +0000)]
Remove prototypes for __gr_del_entry(), __gr_get_head(),
__sgr_del_entry(), and __sgr_get_head().
nekral-guest [Sun, 6 Jan 2008 12:07:42 +0000 (12:07 +0000)]
* src/login_nopam.c: Use an ANSI prototype for resolve_hostname()
instead of K&R prototype.
* src/login_nopam.c: Fix the prototypes of list_match(),
user_match(), from_match(), string_match(). There were no
parameters in the prototypes.
* src/login_nopam.c: Fix the prototypes of the function parameter
match_fn of list_match().
nekral-guest [Sun, 6 Jan 2008 12:02:24 +0000 (12:02 +0000)]
Remove the src parameter of copy_special().
The entry's information are taken from the stat structure.
nekral-guest [Sun, 6 Jan 2008 11:59:01 +0000 (11:59 +0000)]
* libmisc/console.c, libmisc/ulimit.c, lib/sgetgrent.c,
lib/sgetpwent.c: Include "prototypes.h" to make
sure the exported prototypes are the ones used for the definition
of functions.
* lib/prototypes.h: Added prototypes for __gr_del_entry(),
__gr_get_db(), __gr_get_head(), __gr_set_changed(), __gr_dup(),
__pw_del_entry(), __pw_get_db(), __pw_get_head(), __pw_dup(),
sgetgrent(), sgetpwent(), __sgr_del_entry(), __sgr_dup(),
__sgr_get_head(), __sgr_set_changed(), __spw_get_head(),
__spw_del_entry(), __spw_dup().
* lib/prototypes.h: Removed prototype for is_listed().
* lib/prototypes.h: Added name of the check_su_auth()'s parameters.
* lib/groupio.h: Removed prototypes for __gr_dup() and
__gr_set_changed().
* lib/sgroupio.c: Removed prototypes for putsgent(), sgetsgent(),
and __gr_get_db().
* lib/sgroupio.h: Removed prototypes for __sgr_dup() and
__sgr_set_changed().
* lib/shadowio.c: Removed prototype for __pw_get_db().
* lib/pwio.c: Removed prototype for sgetpwent() and putpwent().
* lib/shadowio.h: Removed prototypes for __spw_dup() and
__spw_set_changed().
* lib/pwio.h: Removed prototypes for __pw_dup() and
__pw_set_changed().
* lib/commonio.h: Add protection against multiple inclusions.
* lib/prototypes.h: Include commonio.h (needed for the
__xx_del_entry() functions).
nekral-guest [Sat, 5 Jan 2008 17:25:00 +0000 (17:25 +0000)]
Add documentation for the new --password options.
nekral-guest [Sat, 5 Jan 2008 17:23:46 +0000 (17:23 +0000)]
Fix find_new_gid() prototype. Add a void parameter.
nekral-guest [Sat, 5 Jan 2008 17:22:38 +0000 (17:22 +0000)]
Remove old comments in the header.
nekral-guest [Sat, 5 Jan 2008 17:20:45 +0000 (17:20 +0000)]
Include <lastlog.h> for the declaration of struct lastlog.
nekral-guest [Sat, 5 Jan 2008 16:44:51 +0000 (16:44 +0000)]
Fix typos.
nekral-guest [Sat, 5 Jan 2008 16:44:28 +0000 (16:44 +0000)]
* lib/prototypes.h: Add the dolastlog() prototype.
* lib/prototypes.h: Typo: login.c -> loginprompt.c
* src/login.c: Remove declaration of dolastlog().
* libmisc/log.c: dolastlog() should not have been changed to static.
Include prototypes.h instead.
nekral-guest [Sat, 5 Jan 2008 16:33:43 +0000 (16:33 +0000)]
* libmisc/pwdcheck.c: Do not include <pwd.h>. Include <shadow.h>
and "pwauth.h" only when compiled without PAM support.
* src/chfn.c, src/chsh.c: Do not include <shadow.h>
* lib/commonio.c: Do not include <shadow.h>. Do not include
<pwd.h>. Include "nscd.h" instead of <nscd.h>.
* configure.in: Do not check if shadow.h exist, but make sure it
exists.
* libmisc/pwdcheck.c, src/chfn.c, src/chsh.c, lib/defines.h,
lib/shadowmem.c, lib/shadowio.c, lib/commonio.c:
HAVE_SHADOW_H is no more needed (shadow.h should always exist).
nekral-guest [Sat, 5 Jan 2008 15:43:33 +0000 (15:43 +0000)]
Fix the do_pam_passwd() prototype (it returns void).
nekral-guest [Sat, 5 Jan 2008 15:41:58 +0000 (15:41 +0000)]
do_pam_passwd should not have been defined static, prototypes.h needed
to be included instead.
nekral-guest [Sat, 5 Jan 2008 14:35:13 +0000 (14:35 +0000)]
Remove prototype of putgrent(), add parameter's name of sgetgrent().
nekral-guest [Sat, 5 Jan 2008 14:17:43 +0000 (14:17 +0000)]
Add option --password to groupadd and groupmod (similar to useradd and usermod).
nekral-guest [Sat, 5 Jan 2008 14:09:56 +0000 (14:09 +0000)]
Remove the declaration of getutent(), getutline(), setutent(), and
endutent() which are declared in <utmp.h>
nekral-guest [Sat, 5 Jan 2008 14:01:34 +0000 (14:01 +0000)]
stat shadows another stat variable. Remove this
variable, and directly check the result of getfscreatecon().
nekral-guest [Sat, 5 Jan 2008 13:58:56 +0000 (13:58 +0000)]
Changelog entry forgotten in previous src/gshadow.c commit:
* list() is an external function. DO not shadow it
with a static function. The internal list() was renamed
build_list().
nekral-guest [Sat, 5 Jan 2008 13:56:21 +0000 (13:56 +0000)]
The prototypes of fgetsx() and fputsx() are already defined in
prototypes.h. Remove the declaration of these functions.
nekral-guest [Sat, 5 Jan 2008 13:54:39 +0000 (13:54 +0000)]
loginsh is a global variable, use newshell for the update_shell()'s parameter.
nekral-guest [Sat, 5 Jan 2008 13:53:14 +0000 (13:53 +0000)]
login_prompt is the name of a function, use loginprompt for the internal variable.
nekral-guest [Sat, 5 Jan 2008 13:51:43 +0000 (13:51 +0000)]
Make a proper prototype for the main() function declaration. (add void)
nekral-guest [Sat, 5 Jan 2008 13:49:32 +0000 (13:49 +0000)]
Add changelog entry for previous commit.
nekral-guest [Sat, 5 Jan 2008 13:40:49 +0000 (13:40 +0000)]
Add missing include "shadowio.h". (This was OK as long as prototypes.h included this file.)
nekral-guest [Sat, 5 Jan 2008 13:37:32 +0000 (13:37 +0000)]
* libmisc/pam_pass.c: Define do_pam_passwd() as static and add its prototype.
* libmisc/log.c: Define dolastlog() as static and add its prototype.
* src/chage.c: Define isnum() as static and add its prototype.
nekral-guest [Sat, 5 Jan 2008 13:32:32 +0000 (13:32 +0000)]
Include config.h as a system include, as recommended by the autoconf documentation.
nekral-guest [Sat, 5 Jan 2008 13:29:24 +0000 (13:29 +0000)]
Define is_listed() as static and add its prototype.
nekral-guest [Sat, 5 Jan 2008 13:23:22 +0000 (13:23 +0000)]
Include "prototypes.h" to make sure the exported prototypes are
the ones used for the definition of functions.
nekral-guest [Sat, 5 Jan 2008 13:07:54 +0000 (13:07 +0000)]
"shadowio.h" was included for the definition of the spwd structure.
Replace this include by <shadow.h>
nekral-guest [Sat, 5 Jan 2008 13:05:21 +0000 (13:05 +0000)]
grent.c does not exist anymore. Remove the putgrent prototype.
nekral-guest [Tue, 1 Jan 2008 23:56:03 +0000 (23:56 +0000)]
Add the syslog_sg prototype.
nekral-guest [Tue, 1 Jan 2008 23:54:51 +0000 (23:54 +0000)]
Also split syslog_sg() out of main().
nekral-guest [Tue, 1 Jan 2008 23:45:44 +0000 (23:45 +0000)]
Remove duplicate logging to syslog.
nekral-guest [Tue, 1 Jan 2008 23:35:55 +0000 (23:35 +0000)]
Split check_perms() out of main().
nekral-guest [Tue, 1 Jan 2008 23:07:55 +0000 (23:07 +0000)]
Avoid assignments in conditionals.
nekral-guest [Tue, 1 Jan 2008 22:21:55 +0000 (22:21 +0000)]
Avoid assignments in conditionals.
nekral-guest [Tue, 1 Jan 2008 20:47:31 +0000 (20:47 +0000)]
(split_groups): Test the pointer returned by malloc.
nekral-guest [Tue, 1 Jan 2008 20:34:47 +0000 (20:34 +0000)]
Document add_one_entry_nis(), write_all(), commonio_remove(),
commonio_locate(), and commonio_rewind().
nekral-guest [Tue, 1 Jan 2008 19:56:29 +0000 (19:56 +0000)]
Fix typo s/groupadd/chpasswd/
nekral-guest [Tue, 1 Jan 2008 19:54:37 +0000 (19:54 +0000)]
New TODO item:
- newusers: add logging to SYSLOG & AUDIT
nekral-guest [Tue, 1 Jan 2008 19:53:33 +0000 (19:53 +0000)]
Fix typo s/groupadd/chage/
nekral-guest [Tue, 1 Jan 2008 19:53:02 +0000 (19:53 +0000)]
Fix typo s/groupadd/chgpasswd/.
nekral-guest [Tue, 1 Jan 2008 18:27:40 +0000 (18:27 +0000)]
Avoid implicit conversions to booleans.
nekral-guest [Tue, 1 Jan 2008 18:04:46 +0000 (18:04 +0000)]
Avoid implicit brackets.
nekral-guest [Tue, 1 Jan 2008 17:56:33 +0000 (17:56 +0000)]
Re-indent.
nekral-guest [Tue, 1 Jan 2008 17:51:54 +0000 (17:51 +0000)]
Avoid implicit conversions to booleans.
nekral-guest [Tue, 1 Jan 2008 17:43:18 +0000 (17:43 +0000)]
use_system_pw_file and use_system_spw_file were not reset.
nekral-guest [Tue, 1 Jan 2008 16:58:13 +0000 (16:58 +0000)]
Re-indent.
nekral-guest [Tue, 1 Jan 2008 16:54:18 +0000 (16:54 +0000)]
Avoid implicit brackets.
nekral-guest [Tue, 1 Jan 2008 16:40:50 +0000 (16:40 +0000)]
ignore libmisc.a
nekral-guest [Tue, 1 Jan 2008 16:36:06 +0000 (16:36 +0000)]
No functional changes were introduced by the previous pwck and grpck
changes, except for the following bug fix: no syslog logging if a passwd
or group file was specified on the command line without a shadowed
database file, even if the system shadowed database was changed).
nekral-guest [Tue, 1 Jan 2008 16:28:01 +0000 (16:28 +0000)]
* Fix open_files prototype (void argument).
* close_file documentation (s:password/shadow:group/gshadow:)
nekral-guest [Tue, 1 Jan 2008 16:25:57 +0000 (16:25 +0000)]
Fix typos in comments (gshadow/shadow).
nekral-guest [Tue, 1 Jan 2008 15:52:07 +0000 (15:52 +0000)]
Simplify pwck's main(). Remove gotos.
nekral-guest [Tue, 1 Jan 2008 15:49:33 +0000 (15:49 +0000)]
Split also check_pw_file() and check_spw_file() out of main().
nekral-guest [Tue, 1 Jan 2008 15:29:47 +0000 (15:29 +0000)]
Also split open_files and close_files out of main().
New global variables use_system_pw_file and use_system_spw_file
nekral-guest [Tue, 1 Jan 2008 15:07:41 +0000 (15:07 +0000)]
Split process_flags() out of main(). New global variables is_shadow,
sort_mode.
nekral-guest [Tue, 1 Jan 2008 14:48:04 +0000 (14:48 +0000)]
De-comment code (duplicate the entry when the _R function is not present on the system).
nekral-guest [Tue, 1 Jan 2008 14:38:47 +0000 (14:38 +0000)]
* src/lastlog.c: Remove statbuf, not used.
* src/lastlog.c: Fix types, cast umin and umax to uid_t.
* src/lastlog.c: (option -u) user needs to be a signed long, not
uid_t (to accept rangees like -<uid>
nekral-guest [Tue, 1 Jan 2008 14:34:07 +0000 (14:34 +0000)]
Avoid ?: construct without the middle term.
nekral-guest [Tue, 1 Jan 2008 14:32:41 +0000 (14:32 +0000)]
Forgot to commit that one.
Avoid empty file when USE_PAM is set.
nekral-guest [Tue, 1 Jan 2008 14:31:00 +0000 (14:31 +0000)]
* libmisc/copydir.c, src/usermod.c, lib/prototypes.h: The uid and
gid parameters can be set to -1 to indicate that the original
owners must be kept. Change the types from uid_t/gid_t to a
long int (signed).
* libmisc/copydir.c: Change the copy_entry(), copy_dir(),
copy_symlink(), copy_special(), and copy_file() prototypes
accordingly.
* lib/prototypes.h: Add the parameters' name for the
libmisc/copydir.c functions.
nekral-guest [Tue, 1 Jan 2008 14:20:36 +0000 (14:20 +0000)]
Avoid empty file when WITH_AUDIT is not set.