]> granicus.if.org Git - pdns/log
pdns
6 years agodnsdist: Get rid of a VLA in TCP workers
Remi Gacogne [Fri, 23 Mar 2018 09:42:49 +0000 (10:42 +0100)]
dnsdist: Get rid of a VLA in TCP workers

6 years agodnsdist: Get rid of VLAs in the console
Remi Gacogne [Mon, 19 Mar 2018 13:00:26 +0000 (14:00 +0100)]
dnsdist: Get rid of VLAs in the console

6 years agoMerge pull request #6317 from rgacogne/dnsdist-source-ports
Pieter Lexis [Thu, 22 Mar 2018 13:43:13 +0000 (14:43 +0100)]
Merge pull request #6317 from rgacogne/dnsdist-source-ports

dnsdist: Add an option to use several source ports toward a backend

6 years agoMerge pull request #6069 from Habbie/no-more-bootstrap
Pieter Lexis [Thu, 22 Mar 2018 09:47:31 +0000 (10:47 +0100)]
Merge pull request #6069 from Habbie/no-more-bootstrap

[WIP] get rid of useless bootstrap scripts; related cleanups

6 years agoMerge pull request #6045 from rgacogne/dnscrypt-xchacha20
Pieter Lexis [Thu, 22 Mar 2018 09:47:16 +0000 (10:47 +0100)]
Merge pull request #6045 from rgacogne/dnscrypt-xchacha20

dnsdist: Implement xchacha20 support for DNSCrypt

6 years agoMerge pull request #6374 from chbruyand/auth-quiet-rectify
Pieter Lexis [Wed, 21 Mar 2018 17:53:07 +0000 (18:53 +0100)]
Merge pull request #6374 from chbruyand/auth-quiet-rectify

auth: add quiet modifier to pdnsutil rectify-all-zones command

6 years agoAdd missing README symlink
Pieter Lexis [Wed, 21 Mar 2018 16:20:43 +0000 (17:20 +0100)]
Add missing README symlink

6 years agoSmall documentation fixes
Pieter Lexis [Wed, 21 Mar 2018 16:17:29 +0000 (17:17 +0100)]
Small documentation fixes

6 years agoMerge pull request #6370 from chbruyand/auth-issue-6228
Pieter Lexis [Wed, 21 Mar 2018 13:43:17 +0000 (14:43 +0100)]
Merge pull request #6370 from chbruyand/auth-issue-6228

auth: fix handling of user-defined axfr filters return values

6 years agoMerge pull request #6342 from chbruyand/reload-resolvconf
Pieter Lexis [Wed, 21 Mar 2018 13:38:14 +0000 (14:38 +0100)]
Merge pull request #6342 from chbruyand/reload-resolvconf

Auth: Reload /etc/resolv.conf when modified. Fix #6263

6 years agoMerge pull request #6352 from cmouse/lua
Pieter Lexis [Wed, 21 Mar 2018 13:37:45 +0000 (14:37 +0100)]
Merge pull request #6352 from cmouse/lua

build-scripts: Use correct example file for lua2

6 years agoauth: fix typo in command description
Charles-Henri Bruyand [Tue, 20 Mar 2018 00:22:56 +0000 (01:22 +0100)]
auth: fix typo in command description

6 years agoMerge pull request #6376 from pieterlexis/travis-bulktest-percentage
Remi Gacogne [Wed, 21 Mar 2018 12:05:20 +0000 (13:05 +0100)]
Merge pull request #6376 from pieterlexis/travis-bulktest-percentage

tests: lower dnsbulktest threshold in travis

6 years agotests: lower dnsbulktest threshold in travis
Pieter Lexis [Wed, 21 Mar 2018 12:00:22 +0000 (13:00 +0100)]
tests: lower dnsbulktest threshold in travis

6 years agoMerge pull request #6364 from rgacogne/dnsdist-macro-sonar
Remi Gacogne [Tue, 20 Mar 2018 15:12:56 +0000 (16:12 +0100)]
Merge pull request #6364 from rgacogne/dnsdist-macro-sonar

dnsdist: Fix 'unreachable code' warnings reported by SonarCloud

6 years agoMerge pull request #6327 from lowellmower/server-up-metric
Remi Gacogne [Tue, 20 Mar 2018 15:12:17 +0000 (16:12 +0100)]
Merge pull request #6327 from lowellmower/server-up-metric

Add Metric "server-up" Count to Carbon Reporting

6 years agoMerge pull request #6372 from krionbsd/pedantic
Remi Gacogne [Tue, 20 Mar 2018 14:47:43 +0000 (15:47 +0100)]
Merge pull request #6372 from krionbsd/pedantic

Remove extra semicolons to remove some -pedantic warnings.

6 years agoRemove extra semicolons to remove some -pedantic warnings.
krion [Tue, 20 Mar 2018 11:27:43 +0000 (12:27 +0100)]
Remove extra semicolons to remove some -pedantic warnings.

6 years agoMerge pull request #6363 from chbruyand/issue-6346
Remi Gacogne [Tue, 20 Mar 2018 08:58:57 +0000 (09:58 +0100)]
Merge pull request #6363 from chbruyand/issue-6346

dnsdist: Make custom LuaAction and LuaResponsAction second return value optional

6 years agoMerge pull request #6366 from rgacogne/dnsdist-exceed-reserve
Remi Gacogne [Tue, 20 Mar 2018 08:57:57 +0000 (09:57 +0100)]
Merge pull request #6366 from rgacogne/dnsdist-exceed-reserve

dnsdist: Reserve according to the _query_ ring size in exceedQueryGen

6 years agoMerge pull request #6368 from rgacogne/dnsdist-faster-dynblocks
Remi Gacogne [Tue, 20 Mar 2018 08:57:15 +0000 (09:57 +0100)]
Merge pull request #6368 from rgacogne/dnsdist-faster-dynblocks

dnsdist: Only update the DynBlock state holders when needed

6 years agoauth: add quiet modifier to pdnsutil rectify-all-zones command
Charles-Henri Bruyand [Mon, 19 Mar 2018 23:54:03 +0000 (00:54 +0100)]
auth: add quiet modifier to pdnsutil rectify-all-zones command

6 years agoauth: fix regression while handling user-defined axfr filters return values, and...
Charles-Henri Bruyand [Mon, 19 Mar 2018 18:47:25 +0000 (19:47 +0100)]
auth: fix regression while handling user-defined axfr filters return values, and a typo in a documentation example

6 years agodnsdist: Only update the DynBlock state holders when needed
Remi Gacogne [Mon, 19 Mar 2018 18:03:11 +0000 (19:03 +0100)]
dnsdist: Only update the DynBlock state holders when needed

6 years agodnsdist: Reserve according to the _query_ ring size in exceedQueryGen
Remi Gacogne [Mon, 19 Mar 2018 13:48:57 +0000 (14:48 +0100)]
dnsdist: Reserve according to the _query_ ring size in exceedQueryGen

6 years agoMerge pull request #6350 from rgacogne/dnsdist-lua-inspection-perfs
Remi Gacogne [Mon, 19 Mar 2018 13:37:34 +0000 (14:37 +0100)]
Merge pull request #6350 from rgacogne/dnsdist-lua-inspection-perfs

dnsdist: Speed up the processing of large ring buffers

6 years agodnsdist: correct typos in doc, adjust regression test
Charles-Henri Bruyand [Mon, 19 Mar 2018 12:38:57 +0000 (13:38 +0100)]
dnsdist: correct typos in doc, adjust regression test

6 years agodnsdist: ignore certificate files used by the tests
Charles-Henri Bruyand [Mon, 19 Mar 2018 12:02:58 +0000 (13:02 +0100)]
dnsdist: ignore certificate files used by the tests

6 years agodnsdist: test LuaAction optional second return value
Charles-Henri Bruyand [Mon, 19 Mar 2018 11:44:46 +0000 (12:44 +0100)]
dnsdist: test LuaAction optional second return value

6 years agodnsdist: add missing definition for DNSResponseAction
Charles-Henri Bruyand [Mon, 19 Mar 2018 11:29:10 +0000 (12:29 +0100)]
dnsdist: add missing definition for DNSResponseAction

6 years agoMerge branch 'master' into issue-6346
Charles-Henri Bruyand [Mon, 19 Mar 2018 10:20:04 +0000 (11:20 +0100)]
Merge branch 'master' into issue-6346

* master:
  use mirror for dnsperf
  rather than crash, sheepishly report no file/linenum
  dnsdist: Update deprecated syntax used in dist configuration file
  Update secpoll
  build lua2 backend packages
  calidns: Add the --ecs parameter to add random ECS values to queries

6 years agoimprove documentation of addLuaAction and addLuaResponseAction
Charles-Henri Bruyand [Mon, 19 Mar 2018 10:16:30 +0000 (11:16 +0100)]
improve documentation of addLuaAction and addLuaResponseAction

6 years agodnsdist: make lua actions second return value optional
Charles-Henri Bruyand [Fri, 16 Mar 2018 03:43:13 +0000 (04:43 +0100)]
dnsdist: make lua actions second return value optional

6 years agodnsdist: Fix 'unreachable code' warnings reported by SonarCloud
Remi Gacogne [Mon, 19 Mar 2018 08:41:38 +0000 (09:41 +0100)]
dnsdist: Fix 'unreachable code' warnings reported by SonarCloud

6 years agoMerge pull request #6354 from Habbie/zpt-eof-crash
Peter van Dijk [Fri, 16 Mar 2018 15:58:15 +0000 (16:58 +0100)]
Merge pull request #6354 from Habbie/zpt-eof-crash

rather than crash, sheepishly report no file/linenum

6 years agoMerge pull request #6360 from Habbie/mirror-dnsperf
Peter van Dijk [Fri, 16 Mar 2018 14:48:54 +0000 (15:48 +0100)]
Merge pull request #6360 from Habbie/mirror-dnsperf

use mirror for dnsperf

6 years agouse mirror for dnsperf
Peter van Dijk [Fri, 16 Mar 2018 13:33:58 +0000 (14:33 +0100)]
use mirror for dnsperf

6 years agoremove typo
Charles-Henri Bruyand [Fri, 16 Mar 2018 00:53:46 +0000 (01:53 +0100)]
remove typo

6 years agoMerge pull request #6356 from chbruyand/update-dnsdistconf-lua
Peter van Dijk [Thu, 15 Mar 2018 17:47:43 +0000 (18:47 +0100)]
Merge pull request #6356 from chbruyand/update-dnsdistconf-lua

dnsdist: Update deprecated syntax used in dist configuration file

6 years agorather than crash, sheepishly report no file/linenum
Peter van Dijk [Thu, 15 Mar 2018 16:51:18 +0000 (17:51 +0100)]
rather than crash, sheepishly report no file/linenum

Before this commit, you could crash pdnsutil edit-zone this way:
1) run pdnsutil edit-zone example.org
2) add a line saying: IN TXT ("
3) exit editor

I suspect other consumers of the zone file parser could also crash this way.

After this commit, we don't crash but we fail to report the line number.
There is room for more improvement here.

6 years agobuild-scripts: Use correct example file for lua2
Aki Tuomi [Thu, 15 Mar 2018 16:33:22 +0000 (18:33 +0200)]
build-scripts: Use correct example file for lua2

6 years agodnsdist: Move StatNode's counters to uint64_t
Remi Gacogne [Thu, 15 Mar 2018 14:27:44 +0000 (15:27 +0100)]
dnsdist: Move StatNode's counters to uint64_t

6 years agodnsdist: Fix StatNode stats update
Remi Gacogne [Thu, 15 Mar 2018 13:59:47 +0000 (14:59 +0100)]
dnsdist: Fix StatNode stats update

6 years agodnsdist: Restore StatNode's children (optionnally) for dnsscope
Remi Gacogne [Thu, 15 Mar 2018 11:09:48 +0000 (12:09 +0100)]
dnsdist: Restore StatNode's children (optionnally) for dnsscope

6 years agodnsdist: Use a reserve()'d unordered_map for exceed* functions
Remi Gacogne [Thu, 15 Mar 2018 09:49:25 +0000 (10:49 +0100)]
dnsdist: Use a reserve()'d unordered_map for exceed* functions

6 years agoMerge pull request #6326 from rgacogne/calidns-ecs
bert hubert [Thu, 15 Mar 2018 09:38:21 +0000 (10:38 +0100)]
Merge pull request #6326 from rgacogne/calidns-ecs

calidns: Add the --ecs parameter to add random ECS values to queries

6 years agodnsdist: Update deprecated syntax used in dist configuration file
Charles-Henri Bruyand [Thu, 15 Mar 2018 09:18:49 +0000 (10:18 +0100)]
dnsdist: Update deprecated syntax used in dist configuration file

6 years agoMerge pull request #6345 from pieterlexis/secpoll-update
Pieter Lexis [Thu, 15 Mar 2018 08:23:48 +0000 (09:23 +0100)]
Merge pull request #6345 from pieterlexis/secpoll-update

Update secpoll

6 years agodnsdist: Don't copy data around in the exceed* functions
Remi Gacogne [Wed, 14 Mar 2018 17:28:25 +0000 (18:28 +0100)]
dnsdist: Don't copy data around in the exceed* functions

6 years agodnsdist: Don't copy labels into a deque when inserting in StatNode
Remi Gacogne [Wed, 14 Mar 2018 17:27:33 +0000 (18:27 +0100)]
dnsdist: Don't copy labels into a deque when inserting in StatNode

6 years agodnsdist: Don't keep track of the remote in StatNode
Remi Gacogne [Wed, 14 Mar 2018 17:24:30 +0000 (18:24 +0100)]
dnsdist: Don't keep track of the remote in StatNode

We don't use them (they are not even available from Lua) and it
becomes very painful when you have a lot of different remotes in
the ring buffers.

6 years agoMerge pull request #6338 from cmouse/lua
Pieter Lexis [Wed, 14 Mar 2018 16:07:18 +0000 (17:07 +0100)]
Merge pull request #6338 from cmouse/lua

build lua2 backend packages

6 years agoUpdate secpoll
Pieter Lexis [Wed, 14 Mar 2018 14:48:28 +0000 (15:48 +0100)]
Update secpoll

6 years agomove constant in countServersUp() signature
Lowell Mower [Wed, 14 Mar 2018 12:58:23 +0000 (08:58 -0400)]
move constant in countServersUp() signature

6 years agoDon't check for changes more than once every 60 secs
Charles-Henri Bruyand [Wed, 14 Mar 2018 00:26:22 +0000 (00:26 +0000)]
Don't check for changes more than once every 60 secs

6 years agoUse RAII wrappers for locks and some cleaning following reviews
Charles-Henri Bruyand [Tue, 13 Mar 2018 21:59:05 +0000 (21:59 +0000)]
Use RAII wrappers for locks and some cleaning following reviews

6 years agoAuth: Reload /etc/resolv.conf when modified. Fix #6263
Charles-Henri Bruyand [Tue, 13 Mar 2018 18:08:22 +0000 (18:08 +0000)]
Auth: Reload /etc/resolv.conf when modified. Fix #6263

6 years agobuild lua2 backend packages
Aki Tuomi [Mon, 12 Mar 2018 17:35:25 +0000 (19:35 +0200)]
build lua2 backend packages

6 years agoMerge pull request #6335 from Habbie/jessie-unbound
Peter van Dijk [Mon, 12 Mar 2018 19:12:27 +0000 (20:12 +0100)]
Merge pull request #6335 from Habbie/jessie-unbound

note that libunbound also needs to come from backports

6 years agoMerge pull request #6334 from Habbie/deb892718
Peter van Dijk [Mon, 12 Mar 2018 16:47:02 +0000 (17:47 +0100)]
Merge pull request #6334 from Habbie/deb892718

add latest deb9 auth to secpoll

6 years agonote that libunbound also needs to come from backports
Peter van Dijk [Mon, 12 Mar 2018 12:36:50 +0000 (13:36 +0100)]
note that libunbound also needs to come from backports

6 years agoadd latest deb9 auth to secpoll
Peter van Dijk [Mon, 12 Mar 2018 11:31:42 +0000 (12:31 +0100)]
add latest deb9 auth to secpoll

6 years agoremove unnecessary class attributes
Lowell Mower [Mon, 12 Mar 2018 11:00:09 +0000 (07:00 -0400)]
remove unnecessary class attributes

6 years agochange return value to size_t for countServerUp
Lowell Mower [Mon, 12 Mar 2018 10:58:26 +0000 (06:58 -0400)]
change return value to size_t for countServerUp

6 years agoMerge pull request #6330 from Habbie/tkey-py3
Remi Gacogne [Mon, 12 Mar 2018 09:02:46 +0000 (10:02 +0100)]
Merge pull request #6330 from Habbie/tkey-py3

make tkey.py work on Python 3

6 years agohardcode servers and up/down in the configuration attribute
Lowell Mower [Fri, 9 Mar 2018 15:46:48 +0000 (10:46 -0500)]
hardcode servers and up/down in the configuration attribute

6 years agoc++11 loop style for countServerUp()
Lowell Mower [Fri, 9 Mar 2018 15:45:36 +0000 (10:45 -0500)]
c++11 loop style for countServerUp()

6 years agomake tkey.py work on Python 3
Peter van Dijk [Fri, 9 Mar 2018 12:51:49 +0000 (13:51 +0100)]
make tkey.py work on Python 3

6 years agoadd function to get count for servers with status UP within a pool
Lowell Mower [Thu, 8 Mar 2018 21:27:55 +0000 (16:27 -0500)]
add function to get count for servers with status UP within a pool

6 years agoadd metric line to interpolate value returned from countServersUp
Lowell Mower [Thu, 8 Mar 2018 21:26:35 +0000 (16:26 -0500)]
add metric line to interpolate value returned from countServersUp

6 years agoadd regression test for server-up metric
Lowell Mower [Thu, 8 Mar 2018 21:25:00 +0000 (16:25 -0500)]
add regression test for server-up metric

6 years agocalidns: Add the --ecs parameter to add random ECS values to queries
Remi Gacogne [Thu, 8 Mar 2018 14:26:07 +0000 (15:26 +0100)]
calidns: Add the --ecs parameter to add random ECS values to queries

6 years agodnsdist: Remove functions that relied on only one active certificate
Remi Gacogne [Sun, 19 Nov 2017 20:31:04 +0000 (21:31 +0100)]
dnsdist: Remove functions that relied on only one active certificate

6 years agodnsdist: Document the new DNSCrypt calls, restore compatibility
Remi Gacogne [Sun, 29 Oct 2017 22:14:27 +0000 (23:14 +0100)]
dnsdist: Document the new DNSCrypt calls, restore compatibility

6 years agoDNSCrypt: Document certificates versions
Remi Gacogne [Sun, 29 Oct 2017 17:50:04 +0000 (18:50 +0100)]
DNSCrypt: Document certificates versions

6 years agoDNSCrypt: Certificate serials should be in network byte order
Remi Gacogne [Sun, 29 Oct 2017 17:49:05 +0000 (18:49 +0100)]
DNSCrypt: Certificate serials should be in network byte order

6 years agodnsdist: Add support for DNSCrypt's xchacha20, n active certs
Remi Gacogne [Sun, 15 Oct 2017 20:28:32 +0000 (22:28 +0200)]
dnsdist: Add support for DNSCrypt's xchacha20, n active certs

6 years agoMerge pull request #6157 from cmouse/lua
Peter van Dijk [Thu, 8 Mar 2018 08:55:16 +0000 (09:55 +0100)]
Merge pull request #6157 from cmouse/lua

Lua2 backend

6 years agoMerge pull request #5361 from oridistor/master
Pieter Lexis [Wed, 7 Mar 2018 12:37:20 +0000 (13:37 +0100)]
Merge pull request #5361 from oridistor/master

See #3602, made requests always return to sender, for usage in multi …

6 years agoMerge pull request #6324 from pieterlexis/waitForMultiData-unused-var-fix
Pieter Lexis [Wed, 7 Mar 2018 09:28:40 +0000 (10:28 +0100)]
Merge pull request #6324 from pieterlexis/waitForMultiData-unused-var-fix

Fix unused variable compiler warning

6 years agoMerge pull request #6325 from zeha/auth-api-409
Pieter Lexis [Wed, 7 Mar 2018 09:28:22 +0000 (10:28 +0100)]
Merge pull request #6325 from zeha/auth-api-409

Auth API: return status 409 if domain already exists (+test cleanup

6 years agodnsdist: Use the best multiplexer available instead of poll()
Remi Gacogne [Tue, 6 Mar 2018 15:20:48 +0000 (16:20 +0100)]
dnsdist: Use the best multiplexer available instead of poll()

6 years agodnsdist: Account for more than one socket per backend
Remi Gacogne [Mon, 5 Mar 2018 09:49:52 +0000 (10:49 +0100)]
dnsdist: Account for more than one socket per backend

6 years agodnsdist: If at least one (re-)connection failed, close all sockets
Remi Gacogne [Mon, 5 Mar 2018 09:44:41 +0000 (10:44 +0100)]
dnsdist: If at least one (re-)connection failed, close all sockets

6 years agodnsdist: Check that the number of sockets is > 0
Remi Gacogne [Mon, 5 Mar 2018 09:43:44 +0000 (10:43 +0100)]
dnsdist: Check that the number of sockets is > 0

6 years agodnsdist: Add an option to use several source ports toward a backend
Remi Gacogne [Thu, 1 Mar 2018 11:19:29 +0000 (11:19 +0000)]
dnsdist: Add an option to use several source ports toward a backend

This is very useful if the backend is distributing queries based
only on (source IP, source port, destination IP, destination port),
which is for example the case of PowerDNS Recursor with several
threads, reuseport set and pdns-distribute-queries not set.

6 years agoMerge pull request #6289 from zeha/dnsdist-stats
Remi Gacogne [Tue, 6 Mar 2018 15:56:08 +0000 (15:56 +0000)]
Merge pull request #6289 from zeha/dnsdist-stats

dnsdist: unify global stats accounting

6 years agoMerge pull request #6322 from zeha/dnsdist-tests
Remi Gacogne [Tue, 6 Mar 2018 15:53:55 +0000 (15:53 +0000)]
Merge pull request #6322 from zeha/dnsdist-tests

dnsdist tests: make py3k compatible and pick py3k if available

6 years agoMerge pull request #6323 from zeha/dnsdist-remotelogger-checkconfig
Remi Gacogne [Tue, 6 Mar 2018 15:53:30 +0000 (15:53 +0000)]
Merge pull request #6323 from zeha/dnsdist-remotelogger-checkconfig

dnsdist: create RemoteLoggers in client mode, but avoid connecting

6 years agotravis: Run tests for lua2
Aki Tuomi [Tue, 23 Jan 2018 11:54:25 +0000 (13:54 +0200)]
travis: Run tests for lua2

6 years agolua2backend: Add new backend
Aki Tuomi [Sun, 7 Jan 2018 17:39:47 +0000 (19:39 +0200)]
lua2backend: Add new backend

This is API version 1 of lua2 backend.

It provides improved interface for Lua script to act as backends.

Configuration
 - `lua2-filename` - path to script
 - `lua2-query-logging` - log lua queries and results
 - `lua2-api' - API version (default 2)

6 years agopdns: Include lua-auth and it's dependencies in pdnsutil
Aki Tuomi [Sun, 7 Jan 2018 18:53:06 +0000 (20:53 +0200)]
pdns: Include lua-auth and it's dependencies in pdnsutil

Needed by lua2 backend

6 years agolua-base4: Add QType methods
Aki Tuomi [Fri, 26 Jan 2018 12:51:34 +0000 (14:51 +0200)]
lua-base4: Add QType methods

6 years agolua-base4: Expose more DNSName methods
Aki Tuomi [Tue, 23 Jan 2018 11:52:19 +0000 (13:52 +0200)]
lua-base4: Expose more DNSName methods

These are needed to implement lua2 backend

6 years agolua-base4: Add newDRR for making DNSResourceRecords
Aki Tuomi [Sun, 7 Jan 2018 16:45:58 +0000 (18:45 +0200)]
lua-base4: Add newDRR for making DNSResourceRecords

6 years agoRemove latency tracking for TCP again, for now
Chris Hofstaedtler [Tue, 6 Mar 2018 07:49:25 +0000 (08:49 +0100)]
Remove latency tracking for TCP again, for now

6 years agoapi tests: pick python3 if available
Chris Hofstaedtler [Tue, 6 Mar 2018 07:45:25 +0000 (08:45 +0100)]
api tests: pick python3 if available

6 years agoAuth API: return status 409 if domain already exists #4482
Chris Hofstaedtler [Tue, 6 Mar 2018 07:41:19 +0000 (08:41 +0100)]
Auth API: return status 409 if domain already exists #4482

6 years agoapi tests: fix up for py3k and other cleanup
Chris Hofstaedtler [Tue, 6 Mar 2018 07:40:53 +0000 (08:40 +0100)]
api tests: fix up for py3k and other cleanup

6 years agoFix unused variable compiler warning
Pieter Lexis [Mon, 5 Mar 2018 15:25:35 +0000 (16:25 +0100)]
Fix unused variable compiler warning