]> granicus.if.org Git - taglib/log
taglib
8 years agoSafer conversion of boolean values in ASF attributes.
Tsuda Kageyu [Mon, 19 Dec 2016 01:37:10 +0000 (10:37 +0900)]
Safer conversion of boolean values in ASF attributes.

Technically, boolean values in Extended Content Description Object is not necessarily be 0 or 1.

8 years agoMake use of increment/decrement operators of std::atomic.
Tsuda Kageyu [Fri, 9 Dec 2016 00:56:37 +0000 (09:56 +0900)]
Make use of increment/decrement operators of std::atomic.

8 years agoRemove optional dependencies on Boost's dynamic libraries.
Tsuda Kageyu [Fri, 9 Dec 2016 00:42:29 +0000 (09:42 +0900)]
Remove optional dependencies on Boost's dynamic libraries.

Using precompiled Boost libraries can lead to depending on external dynamic libraries.

8 years agoMerge pull request #784 from haoxi911/master
Tsuda Kageyu [Fri, 9 Dec 2016 00:00:04 +0000 (09:00 +0900)]
Merge pull request #784 from haoxi911/master

Fix #667: Compiled TagLib framework for OS X fails at codesign.

8 years agoFix #667: Compiled TagLib framework for OS X fails at codesign.
Hao Xi [Thu, 8 Dec 2016 04:53:40 +0000 (12:53 +0800)]
Fix #667: Compiled TagLib framework for OS X fails at codesign.

8 years agoRewrite ByteVector::replace() to run in O(n) time.
Tsuda Kageyu [Fri, 2 Dec 2016 07:31:27 +0000 (16:31 +0900)]
Rewrite ByteVector::replace() to run in O(n) time.

8 years agoAdd a test to check if ByteVector is detached correctly when being replaced.
Tsuda Kageyu [Mon, 5 Dec 2016 01:15:26 +0000 (10:15 +0900)]
Add a test to check if ByteVector is detached correctly when being replaced.

8 years ago#include guards in CMake generated headers.
Tsuda Kageyu [Fri, 2 Dec 2016 08:26:43 +0000 (17:26 +0900)]
#include guards in CMake generated headers.

8 years agoUpdate NEWS.
Tsuda Kageyu [Thu, 1 Dec 2016 06:25:30 +0000 (15:25 +0900)]
Update NEWS.

8 years agoFix possible Ogg packet losses.
Tsuda Kageyu [Thu, 1 Dec 2016 02:32:01 +0000 (11:32 +0900)]
Fix possible Ogg packet losses.

8 years agoPrevent the segment table of Ogg pages from exceeding the size limit.
Tsuda Kageyu [Thu, 1 Dec 2016 01:50:30 +0000 (10:50 +0900)]
Prevent the segment table of Ogg pages from exceeding the size limit.

8 years agoRemove Utils::floatByteOrder() and use systemByteOrder() instead.
Tsuda Kageyu [Tue, 29 Nov 2016 05:58:39 +0000 (14:58 +0900)]
Remove Utils::floatByteOrder() and use systemByteOrder() instead.

We can safely assume that the integer and float byte orders are the same on IEEE754 compliant systems.

8 years agoAdd a test for #743/#779.
Tsuda Kageyu [Tue, 29 Nov 2016 01:53:33 +0000 (10:53 +0900)]
Add a test for #743/#779.

8 years agoSmall fix in style.
Tsuda Kageyu [Tue, 29 Nov 2016 01:38:11 +0000 (10:38 +0900)]
Small fix in style.

8 years agoMerge pull request #779 from supermihi/master
Tsuda Kageyu [Mon, 28 Nov 2016 12:03:39 +0000 (21:03 +0900)]
Merge pull request #779 from supermihi/master

Fixes #743 by not overwriting existing Xiph comment in FLAC::File::save

8 years agoFixes #743 by not overwriting existing Xiph comment in FLAC::File::save
Michael Helmling [Sun, 27 Nov 2016 18:17:13 +0000 (19:17 +0100)]
Fixes #743 by not overwriting existing Xiph comment in FLAC::File::save

8 years agoA bit more tolerant check to return itself in String::substr().
Tsuda Kageyu [Sat, 26 Nov 2016 04:05:14 +0000 (13:05 +0900)]
A bit more tolerant check to return itself in String::substr().

8 years agoMerge pull request #778 from martin-flaska/optimization
Stephen F. Booth [Fri, 25 Nov 2016 21:38:32 +0000 (16:38 -0500)]
Merge pull request #778 from martin-flaska/optimization

String::substr optimization

8 years agotstring: String::substr optimization when returning itself as a substring
Martin Flaska [Fri, 25 Nov 2016 14:32:26 +0000 (15:32 +0100)]
tstring: String::substr optimization when returning itself as a substring

Use copy ctor to return in a case whole string is being returned.

The intention was to optimize String::stripWhiteSpace for no-strip case
(without any leading or trailing white space removal).

copyFromUTF16 was used in any case previously and allocated duplicate
buffer for the same string - no implicit sharing.

Signed-off-by: Martin Flaska <martin.flaska@legrand.us>
8 years agotest_string: Make 'stripWhiteSpace' test more complex
Martin Flaska [Fri, 25 Nov 2016 11:58:25 +0000 (12:58 +0100)]
test_string: Make 'stripWhiteSpace' test more complex

No string without leading/trailing spaces was used in the test.

Signed-off-by: Martin Flaska <martin.flaska@legrand.us>
8 years agoSuppress MSVC warnings in test.
Tsuda Kageyu [Thu, 24 Nov 2016 05:45:22 +0000 (14:45 +0900)]
Suppress MSVC warnings in test.

8 years agoMerge pull request #776 from mathbunnyru/small_improvements
Stephen F. Booth [Thu, 24 Nov 2016 04:31:49 +0000 (23:31 -0500)]
Merge pull request #776 from mathbunnyru/small_improvements

Small improvements

8 years agoSmall fixes
mathbunnyru [Wed, 23 Nov 2016 23:02:38 +0000 (02:02 +0300)]
Small fixes

8 years agoIncrement fixes
mathbunnyru [Mon, 21 Nov 2016 22:10:28 +0000 (01:10 +0300)]
Increment fixes

8 years agoUpdate NEWS.
Tsuda Kageyu [Fri, 18 Nov 2016 04:55:43 +0000 (13:55 +0900)]
Update NEWS.

8 years agoMerge pull request #772 from TsudaKageyu/vorbis-fields
Tsuda Kageyu [Fri, 18 Nov 2016 04:52:38 +0000 (13:52 +0900)]
Merge pull request #772 from TsudaKageyu/vorbis-fields

Fix handling of lowercase 'metadata_block_picture' field

8 years agoFix handling of lowercase 'metadata_block_picture' fields in Vorbis comments.
Tsuda Kageyu [Thu, 10 Nov 2016 15:07:32 +0000 (00:07 +0900)]
Fix handling of lowercase 'metadata_block_picture' fields in Vorbis comments.

Also refactored some redundant code for parsing pictures.

8 years agoAvoid adding fields with invalid keys to Vorbis Comments.
Tsuda Kageyu [Thu, 10 Nov 2016 11:02:30 +0000 (20:02 +0900)]
Avoid adding fields with invalid keys to Vorbis Comments.

According to the spec, '\x7F' is not allowed.

8 years agoDon't decode redundant UTF-8 sequences in Win32.
Tsuda Kageyu [Thu, 10 Nov 2016 08:09:40 +0000 (17:09 +0900)]
Don't decode redundant UTF-8 sequences in Win32.

Linux and OS X are working well and won't be affected.

8 years agoSeparate some tests to make them more specific.
Tsuda Kageyu [Wed, 9 Nov 2016 06:51:33 +0000 (15:51 +0900)]
Separate some tests to make them more specific.

8 years agoCheck invalid Unicode APE keys properly.
Tsuda Kageyu [Tue, 8 Nov 2016 15:28:35 +0000 (00:28 +0900)]
Check invalid Unicode APE keys properly.

8 years agoRemoved a utility function which is used only at one place.
Tsuda Kageyu [Tue, 8 Nov 2016 14:27:55 +0000 (23:27 +0900)]
Removed a utility function which is used only at one place.

8 years agoAdd README.md.
Tsuda Kageyu [Tue, 8 Nov 2016 13:50:36 +0000 (22:50 +0900)]
Add README.md.

8 years agotolower() depends on the current locale.
Tsuda Kageyu [Tue, 8 Nov 2016 12:39:53 +0000 (21:39 +0900)]
tolower() depends on the current locale.

It's much easier to write our own function than to use locales properly.

8 years agoUpdate NEWS.
Tsuda Kageyu [Tue, 8 Nov 2016 12:17:00 +0000 (21:17 +0900)]
Update NEWS.

8 years agoMerge pull request #765 from TsudaKageyu/zero-length-atom
Tsuda Kageyu [Tue, 8 Nov 2016 12:12:47 +0000 (21:12 +0900)]
Merge pull request #765 from TsudaKageyu/zero-length-atom

Proper handling of MP4 atoms with zero length.

8 years agoMerge pull request #759 from ufleisch/mp4_classical
Tsuda Kageyu [Tue, 8 Nov 2016 12:12:31 +0000 (21:12 +0900)]
Merge pull request #759 from ufleisch/mp4_classical

Support new classical music frames introduced with iTunes 12.5, #758.

8 years agoInitialize all the data members of ID3v2::ChapterFrame.
Tsuda Kageyu [Mon, 7 Nov 2016 05:12:38 +0000 (14:12 +0900)]
Initialize all the data members of ID3v2::ChapterFrame.

8 years agoValues of FILE_* macros are guaranteed in Win32.
Tsuda Kageyu [Sun, 6 Nov 2016 15:42:12 +0000 (00:42 +0900)]
Values of FILE_* macros are guaranteed in Win32.

8 years agoAdd List::swap() and Map::swap().
Tsuda Kageyu [Fri, 4 Nov 2016 07:43:14 +0000 (16:43 +0900)]
Add List::swap() and Map::swap().

8 years agoProper handling of MP4 atoms with zero length.
Tsuda Kageyu [Wed, 2 Nov 2016 06:44:50 +0000 (15:44 +0900)]
Proper handling of MP4 atoms with zero length.

If the size of an atom is 0, it designates the last atom which extends to the end of the file.

8 years agoRemove a useless branch.
Tsuda Kageyu [Tue, 1 Nov 2016 07:03:15 +0000 (16:03 +0900)]
Remove a useless branch.

longLength <= LONG_MAX is always true if sizeof(long) == sizeof(long long).

8 years agoAdd a common function to generate a long string to test.
Tsuda Kageyu [Mon, 31 Oct 2016 10:53:17 +0000 (19:53 +0900)]
Add a common function to generate a long string to test.

8 years agoAllow ScopedFileCopy to be const.
Tsuda Kageyu [Mon, 31 Oct 2016 01:29:13 +0000 (10:29 +0900)]
Allow ScopedFileCopy to be const.

8 years agoSuppress MSVC warnings about narrowing conversions.
Tsuda Kageyu [Sun, 30 Oct 2016 14:51:35 +0000 (23:51 +0900)]
Suppress MSVC warnings about narrowing conversions.

8 years agoUpdate NEWS.
Tsuda Kageyu [Sun, 30 Oct 2016 13:51:15 +0000 (22:51 +0900)]
Update NEWS.

8 years agoAssume that SetFilePointerEx() and GetFileSizeEx() are always available.
Tsuda Kageyu [Sun, 30 Oct 2016 13:36:18 +0000 (22:36 +0900)]
Assume that SetFilePointerEx() and GetFileSizeEx() are always available.

This drops support for Windows 9x and NT 4.0 or older.

8 years agoAssume that CreateFileW() is always available.
Tsuda Kageyu [Sun, 30 Oct 2016 13:25:34 +0000 (22:25 +0900)]
Assume that CreateFileW() is always available.

This drops support for Windows 9x.

8 years agoPrevent overflows, just in case.
Tsuda Kageyu [Fri, 28 Oct 2016 06:25:50 +0000 (15:25 +0900)]
Prevent overflows, just in case.

8 years agoBackport a test from taglib2 branch.
Tsuda Kageyu [Fri, 28 Oct 2016 06:19:35 +0000 (15:19 +0900)]
Backport a test from taglib2 branch.

8 years agoRemove some useless seek()/tell() from RIFF::File.
Tsuda Kageyu [Fri, 28 Oct 2016 05:22:50 +0000 (14:22 +0900)]
Remove some useless seek()/tell() from RIFF::File.

8 years agoEncourage compilers to optimize out debug() and debugData().
Tsuda Kageyu [Fri, 28 Oct 2016 02:19:51 +0000 (11:19 +0900)]
Encourage compilers to optimize out debug() and debugData().

It's sort of like a throwback, but I found that debug(const String &s) {} doesn't prevent a String from being constructed and the error messages from being embedded.

8 years agoUpdate NEWS.
Tsuda Kageyu [Thu, 27 Oct 2016 06:40:14 +0000 (15:40 +0900)]
Update NEWS.

8 years agoSuppress some warnings in test.
Tsuda Kageyu [Thu, 27 Oct 2016 06:23:24 +0000 (15:23 +0900)]
Suppress some warnings in test.

8 years agoAdd a test for File::truncate().
Tsuda Kageyu [Thu, 27 Oct 2016 06:15:22 +0000 (15:15 +0900)]
Add a test for File::truncate().

8 years agoCheck if file size <= LONG_MAX.
Tsuda Kageyu [Thu, 27 Oct 2016 06:10:34 +0000 (15:10 +0900)]
Check if file size <= LONG_MAX.

8 years agoMerge pull request #761 from albertofustinoni/master
Tsuda Kageyu [Mon, 24 Oct 2016 13:06:35 +0000 (22:06 +0900)]
Merge pull request #761 from albertofustinoni/master

WinRT compatibility

8 years agoformatting
Alberto Fustinoni [Mon, 24 Oct 2016 12:24:53 +0000 (21:24 +0900)]
formatting

8 years agoWhitespace
Alberto Fustinoni [Mon, 24 Oct 2016 12:22:57 +0000 (21:22 +0900)]
Whitespace

8 years agoRefactoring
Alberto Fustinoni [Mon, 24 Oct 2016 12:19:31 +0000 (21:19 +0900)]
Refactoring

8 years agoUpdate NEWS. v1.11.1
Tsuda Kageyu [Mon, 24 Oct 2016 03:03:23 +0000 (12:03 +0900)]
Update NEWS.

8 years agoBetter define guards
Alberto Fustinoni [Sun, 23 Oct 2016 14:25:16 +0000 (23:25 +0900)]
Better define guards

8 years agoStyling
Alberto Fustinoni [Sun, 23 Oct 2016 11:17:49 +0000 (20:17 +0900)]
Styling

8 years agoMerge branch 'master' of https://github.com/albertofustinoni/taglib.git
Alberto Fustinoni [Sun, 23 Oct 2016 11:13:26 +0000 (20:13 +0900)]
Merge branch 'master' of https://github.com/albertofustinoni/taglib.git

8 years agoUse newer file system calls when in Windows 8+ to allow compilation as WinRT asembly
Alberto Fustinoni [Sun, 23 Oct 2016 03:32:16 +0000 (12:32 +0900)]
Use newer file system calls when in Windows 8+ to allow compilation as WinRT asembly

8 years agoUpdate the version to v1.11.1.
Tsuda Kageyu [Fri, 21 Oct 2016 17:45:52 +0000 (02:45 +0900)]
Update the version to v1.11.1.

8 years agoReplace a possibly non-free file in the test suite.
Tsuda Kageyu [Fri, 21 Oct 2016 17:11:16 +0000 (02:11 +0900)]
Replace a possibly non-free file in the test suite.

8 years agoUpdate NEWS.
Tsuda Kageyu [Fri, 21 Oct 2016 16:06:57 +0000 (01:06 +0900)]
Update NEWS.

8 years agoRestore the ABI breakage by bringing back a removed private static variable.
Tsuda Kageyu [Wed, 19 Oct 2016 06:57:28 +0000 (15:57 +0900)]
Restore the ABI breakage by bringing back a removed private static variable.

8 years agoSupport new classical music frames introduced with iTunes 12.5, #758.
Urs Fleisch [Tue, 18 Oct 2016 18:34:53 +0000 (20:34 +0200)]
Support new classical music frames introduced with iTunes 12.5, #758.

M4A:
    ©wrk: Work (string)
    ©mvn: Movement Name (string)
    ©mvi: Movement Number (number)
    ©mvc: Movement Count (number)
    shwm: Show Work & Movement (0/1)

ID3 (2.3, 2.4; MVN, MVI for 2.2):
    MVNM: Movement Name
    MVIN: Movement Number/Count

8 years agoUpdate NEWS.
Tsuda Kageyu [Mon, 26 Sep 2016 08:48:44 +0000 (17:48 +0900)]
Update NEWS.

8 years agoMerge pull request #754 from hyperquantum/master
Stephen F. Booth [Fri, 16 Sep 2016 01:11:08 +0000 (21:11 -0400)]
Merge pull request #754 from hyperquantum/master

Fix defect in ByteVectorStream::seek when Position==End.

8 years agoFix defect in ByteVectorStream::seek when Position==End.
Kevin André [Thu, 15 Sep 2016 14:30:16 +0000 (16:30 +0200)]
Fix defect in ByteVectorStream::seek when Position==End.

8 years agoMerge pull request #752 from evpobr/cmake-ver
Tsuda Kageyu [Mon, 12 Sep 2016 06:56:45 +0000 (15:56 +0900)]
Merge pull request #752 from evpobr/cmake-ver

Move cmake_minimum_required at the top

8 years agoMerge pull request #753 from FestusHagen/fh1.m_AddBuildSharedLibsOption
Tsuda Kageyu [Mon, 12 Sep 2016 06:56:33 +0000 (15:56 +0900)]
Merge pull request #753 from FestusHagen/fh1.m_AddBuildSharedLibsOption

Add BUILD_SHARED_LIBS option for CMake GUI.

8 years agoAdd BUILD_SHARED_LIBS option for CMake GUI.
Festus Hagen [Thu, 25 Aug 2016 19:03:44 +0000 (15:03 -0400)]
Add BUILD_SHARED_LIBS option for CMake GUI.

8 years agoMove cmake_minimum_required at the top
evpobr [Sat, 20 Aug 2016 17:37:53 +0000 (22:37 +0500)]
Move cmake_minimum_required at the top

8 years agoMerge pull request #749 from jwelton/fix-typo
Stephen F. Booth [Sun, 14 Aug 2016 21:10:18 +0000 (17:10 -0400)]
Merge pull request #749 from jwelton/fix-typo

Fix Typo

8 years agoChange string to end offset
Jake Welton [Sun, 14 Aug 2016 21:02:33 +0000 (22:02 +0100)]
Change string to end offset

8 years agoUpdate NEWS.
Tsuda Kageyu [Sat, 14 May 2016 01:46:42 +0000 (10:46 +0900)]
Update NEWS.

8 years agoFix reading table of contents frames with a lot of children.
Tsuda Kageyu [Sat, 14 May 2016 00:58:19 +0000 (09:58 +0900)]
Fix reading table of contents frames with a lot of children.

8 years agoUpdate NEWS. v1.11
Tsuda Kageyu [Fri, 29 Apr 2016 08:26:33 +0000 (17:26 +0900)]
Update NEWS.

8 years agoMerge pull request #739 from frgm/master
Tsuda Kageyu [Fri, 22 Apr 2016 21:54:59 +0000 (06:54 +0900)]
Merge pull request #739 from frgm/master

c: fix a typo

8 years agoc: fix a typo
Svyatoslav Mishyn [Fri, 22 Apr 2016 13:46:15 +0000 (16:46 +0300)]
c: fix a typo

readble => readable

8 years agoRevert "Hide a private static variable."
Tsuda Kageyu [Fri, 22 Apr 2016 00:27:04 +0000 (09:27 +0900)]
Revert "Hide a private static variable."

This reverts commit 25ffbcb4b9b04326edd1d25a785b686951a0f235.

# Conflicts:
# taglib/mpeg/id3v2/id3v2framefactory.cpp
# taglib/mpeg/id3v2/id3v2framefactory.h

8 years agoMerge pull request #732 from dirkvdb/master
Stephen F. Booth [Sat, 2 Apr 2016 17:21:39 +0000 (13:21 -0400)]
Merge pull request #732 from dirkvdb/master

Also ignore the virtual destructor warning when compiling with clang

8 years agoAlso ignore the virtual destructor warning when compiling with clang
Dirk Vanden Boer [Sun, 20 Mar 2016 19:33:04 +0000 (20:33 +0100)]
Also ignore the virtual destructor warning when compiling with clang

8 years agoChange some static_casts to dynamic_casts in test_id3v2.cpp.
Tsuda Kageyu [Thu, 17 Mar 2016 13:50:34 +0000 (22:50 +0900)]
Change some static_casts to dynamic_casts in test_id3v2.cpp.

static_casts are unsafe and some of following tests doesn't work well with them.

8 years agoDon't stop parsing an ID3v2 SYLT frame when its description is empty.
Tsuda Kageyu [Mon, 14 Mar 2016 11:35:09 +0000 (20:35 +0900)]
Don't stop parsing an ID3v2 SYLT frame when its description is empty.

8 years agoUpdate NEWS.
Tsuda Kageyu [Thu, 10 Mar 2016 12:38:08 +0000 (21:38 +0900)]
Update NEWS.

8 years agoMerge pull request #726 from amethystAnt/ape-keys-bug
Tsuda Kageyu [Sun, 6 Mar 2016 21:41:21 +0000 (06:41 +0900)]
Merge pull request #726 from amethystAnt/ape-keys-bug

Fixed bug #725 - changed the maximum length of an APE key to 255

8 years agoFixed bug #725 - changed the maximum length of an APE key to 255
Karel Patlejch [Sun, 6 Mar 2016 20:15:18 +0000 (21:15 +0100)]
Fixed bug #725 - changed the maximum length of an APE key to 255

8 years agoAdd myself to maintainers.
Tsuda Kageyu [Thu, 3 Mar 2016 01:06:51 +0000 (10:06 +0900)]
Add myself to maintainers.

8 years agoUpdate NEWS for v1.11 BETA 2. v1.11beta2
Tsuda Kageyu [Wed, 2 Mar 2016 20:02:14 +0000 (05:02 +0900)]
Update NEWS for v1.11 BETA 2.

8 years agoSupport Boost iostreams library to decode compressed ID3v2 frames in additiion to...
Tsuda Kageyu [Tue, 23 Feb 2016 15:26:37 +0000 (00:26 +0900)]
Support Boost iostreams library to decode compressed ID3v2 frames in additiion to zlib.

This will help Windows users build TagLib without zlib source.

8 years agoSkip a useless debug message.
Tsuda Kageyu [Wed, 24 Feb 2016 12:32:25 +0000 (21:32 +0900)]
Skip a useless debug message.

8 years agoUpdate NEWS.
Tsuda Kageyu [Mon, 22 Feb 2016 14:27:46 +0000 (23:27 +0900)]
Update NEWS.

8 years agoAdd some debug messages to RIFF::File, just in case.
Tsuda Kageyu [Mon, 22 Feb 2016 14:17:17 +0000 (23:17 +0900)]
Add some debug messages to RIFF::File, just in case.

8 years agoImprove the padding handling of RIFF files a bit.
Tsuda Kageyu [Mon, 22 Feb 2016 14:12:34 +0000 (23:12 +0900)]
Improve the padding handling of RIFF files a bit.

8 years agoAlways update the global RIFF size when updating RIFF files.
Tsuda Kageyu [Mon, 22 Feb 2016 13:27:18 +0000 (22:27 +0900)]
Always update the global RIFF size when updating RIFF files.