]>
granicus.if.org Git - neomutt/log
Richard Russon [Sat, 13 May 2017 16:34:35 +0000 (17:34 +0100)]
drop obsolete forget option
The rest of the code for this obsolete option was dropped a while ago.
Richard Russon [Mon, 22 May 2017 12:06:41 +0000 (13:06 +0100)]
fix some bools
Replace 0/1 with false/true
Richard Russon [Sat, 20 May 2017 14:05:34 +0000 (15:05 +0100)]
add names prototype arguments
Header files are easier to understand if the arguments are named.
e.g., replace:
int mutt_copy_stream(FILE *, FILE *);
with:
int mutt_copy_stream(FILE *fin, FILE *fout);
Richard Russon [Tue, 23 May 2017 13:13:41 +0000 (14:13 +0100)]
abbreviate pointer tests against NULL
Replace:
if (x == NULL) -> if (!x)
if (x != NULL) -> if (x)
The conditions have only been changed for variables, not functions, e.g.
if (fn(x) == NULL)
Richard Russon [Fri, 19 May 2017 14:58:23 +0000 (15:58 +0100)]
initialise pointers to NULL
Richard Russon [Mon, 22 May 2017 18:53:00 +0000 (19:53 +0100)]
reduce the scope of for loop variables
Quite often, the loop variable in a 'for' loop isn't used elsewhere.
C99 allows us to reduce the scope to *just* the 'for' loop.
Richard Russon [Mon, 22 May 2017 19:31:47 +0000 (20:31 +0100)]
run clang-format on the code
This commit only changes the formatting, nothing else.
It tidies up after all the renaming that's happened.
Richard Russon [Tue, 23 May 2017 10:12:44 +0000 (11:12 +0100)]
doc: fix doc
By renaming all the structs in *.[ch], I broke the doc build which is
perl.
Richard Russon [Fri, 19 May 2017 00:41:07 +0000 (01:41 +0100)]
rename the remaining plain structs
struct b64_context struct B64Context
struct binding_t struct Binding
struct browser_state struct BrowserState
struct command_t struct Command
struct compile_options struct CompileOptions
struct coord struct Coord
struct crypt_cache struct CryptCache
struct crypt_module_functions struct CryptModuleFunctions
struct crypt_module_specs struct CryptModuleSpecs
struct dn_array_s struct DnArrayS
struct enriched_state struct EnrichedState
struct extkey struct Extkey
struct fgetconv_not struct FgetConvNot
struct fgetconv_s struct FgetConvS
struct folder_file struct FolderFile
struct hash_elem struct HashElem
struct hash_walk_state struct HashWalkState
struct hdr_format_info struct HdrFormatInfo
struct header_cache struct HeaderCache
struct history struct History
struct keymap_t struct Keymap
struct line_t struct Line
struct maildir struct Maildir
struct mapping_t struct Mapping
struct md5_ctx struct Md5Ctx
struct mh_data struct MhData
struct mh_sequences struct MhSequences
struct m_update_t struct MUpdate
struct mx_ops struct MxOps
struct nm_ctxdata struct NmCtxdata
struct nm_hdrdata struct NmHdrdata
struct nm_hdrtag struct NmHdrtag
struct option_t struct Option
struct pattern_flags struct PatternFlags
struct pgp_cache struct PgpCache
struct pgp_command_context struct PgpCommandContext
struct q_class_t struct QClass
struct range_regexp struct RangeRegex
struct resize struct Resize
struct rfc2231_parameter struct Rfc2231Parameter
struct smime_command_context struct SmimeCommandContext
struct syntax_t struct Syntax
struct sysexits struct Sysexits
struct _tlssockdata struct TlsSockData
struct tz_t struct Tz
struct uri_tag struct UriTag
Richard Russon [Thu, 18 May 2017 16:24:35 +0000 (17:24 +0100)]
fix idna problems
Richard Russon [Thu, 18 May 2017 14:47:52 +0000 (15:47 +0100)]
build: restore missing INTLLIBS/INTLDEPS
Restore the dependencies on libintl.
I removed them because I couldn't find any references to them
I didn't look hard enough!
Richard Russon [Thu, 18 May 2017 14:06:30 +0000 (15:06 +0100)]
merge: upstream fixes (mutt/default)
* Turn IMAP_EXPUNGE_EXPECTED back off when syncing. (closes #3940).
* Add $history_remove_dups option to remove dups from history ring.
* Also remove duplicates from the history file.
* Don't filter new entries when compacting history save file.
Kevin McCarthy [Sat, 13 May 2017 16:48:28 +0000 (09:48 -0700)]
Don't filter new entries when compacting history save file.
If new entries are added between the two passes, they won't be in the
dup_hash. The original intent was to filter added duplicates, but the
check would also filter brand new entries.
Kevin McCarthy [Sat, 13 May 2017 01:31:41 +0000 (18:31 -0700)]
Also remove duplicates from the history file.
When $history_remove_dups is set, remove duplicates from the history
file when it is periodically compacted.
Kevin McCarthy [Sat, 13 May 2017 01:31:36 +0000 (18:31 -0700)]
Add $history_remove_dups option to remove dups from history ring.
When set, duplicate entries will be removed from the history ring when
a new entry is added. The duplicate removal rearranges the history
ring such that created empty slots are right after the "last" position
in the ring, preserving the most history.
Rewrite the next/prev functions to take into account that blank slots can
now be in the middle of the array.
Kevin McCarthy [Fri, 12 May 2017 16:15:00 +0000 (09:15 -0700)]
Turn IMAP_EXPUNGE_EXPECTED back off when syncing. (closes #3940).
imap_sync_mailbox() turned on IMAP_EXPUNGE_EXPECTED when issuing a
EXPUNGE command during a sync. However, it forgot to turn it back off.
That meant that an unexpected EXPUNGE that occurred during a
mx_check_mailbox -> imap_check_mailbox() -> imap_cmd_finish() call was
not setting
idata->check_status = IMAP_EXPUNGE_PENDING;
and so imap_check_mailbox() was not returning MUTT_REOPENED.
This meant that although the Context had been changed, the index did
not run update_index(), resulting in a possible segfault.
Thanks to Uroš Juvan for reporting the issue, and his invaluable
description of how to reproduce the problem.
toogley [Fri, 28 Apr 2017 13:21:59 +0000 (15:21 +0200)]
build: remove --enable-mailtool configure option
Leave the code enabled, but hide the option.
The feature may be useful to someone.
The code isn't complicated or risky.
Richard Russon [Mon, 15 May 2017 11:20:48 +0000 (12:20 +0100)]
build: move crypto files to ncrypt dir
Richard Russon [Thu, 18 May 2017 11:42:50 +0000 (12:42 +0100)]
merge: minor build fixes/tidying
* remove unused definitions
* update distcheck build flags
* move configure-generated files
* drop docs timestamps
* add silent rules, but default to off
* tidy po/Makevars
* light tidy
* strerror
Richard Russon [Sat, 13 May 2017 13:21:22 +0000 (14:21 +0100)]
build: strerror
strerror will always be there to use.
Richard Russon [Sat, 13 May 2017 13:23:19 +0000 (14:23 +0100)]
build: light tidy
Richard Russon [Sat, 13 May 2017 13:02:25 +0000 (14:02 +0100)]
build: tidy po/Makevars
Remove all the variables that weren't used.
Remove the obvious comments.
Add a custom build rule to quieten the output.
Richard Russon [Sat, 13 May 2017 13:28:26 +0000 (14:28 +0100)]
build: add silent rules, but default to off
This extends the silent build to all make commands, e.g.
old make output:
```
( \
(gcc -v >/dev/null 2>&1 && gcc -v) || \
(gcc --version >/dev/null 2>&1 && gcc --version) || \
(gcc -V >/dev/null 2>&1 && gcc -V) || \
echo "unknown compiler"; \
) 2>&1 | ./txt2c.sh cc_version >conststrings_c
echo "-Wall -pedantic -Wno-long-long -g -Wall -O0 -Werror=format-security -fno-delete-null-pointer-checks -fno-delete-null-pointer-checks" | ./txt2c.sh cc_cflags >>conststrings_c
grep ac_cs_config= config.status | \
cut -d= -f2- | \
sed -e 's/^"//' -e 's/"$//' | ./txt2c.sh configure_options >>conststrings_c
mv -f conststrings_c conststrings.c
```
new make output:
```
GEN conststrings.c
```
Richard Russon [Sun, 7 May 2017 00:54:44 +0000 (01:54 +0100)]
build: split up mutt.h, protos.h
Move various structs out of mutt.h into their own header files.
Then run IWYU (include-what-you-use) on all files.
Richard Russon [Sat, 13 May 2017 13:27:38 +0000 (14:27 +0100)]
build: drop docs timestamps
The build of the docs generated several empty timestamp files to keep
track of what had been built. They weren't necessary.
Richard Russon [Sat, 13 May 2017 13:13:22 +0000 (14:13 +0100)]
build: move configure-generated files
This small change moves 6 configure-generated files into a directory we
won't see (.build-aux)
compile
config.guess
config.sub
depcomp
install-sh
missing
Richard Russon [Sat, 13 May 2017 13:10:47 +0000 (14:10 +0100)]
build: update distcheck build flags
"make dist" creates a .tar of the source.
"make distcheck" does a complete build on that .tar
Make sure we have an up-to-date list of configure options.
Richard Russon [Sat, 13 May 2017 13:08:37 +0000 (14:08 +0100)]
build: remove unused definitions
INTLLIBS, INTLDEPS, DEBUGGER aren't used anywhere.
Pietro Cerutti [Mon, 15 May 2017 12:14:31 +0000 (12:14 +0000)]
Kill useless crypthash.h file
Richard Russon [Wed, 17 May 2017 16:23:45 +0000 (17:23 +0100)]
merge: typedefs -> plain structs
* ACCOUNT -> struct Account
* ADDRESS -> struct Address
* ALIAS -> struct Alias
* ansi_attr -> struct AnsiAttr
* ATTACH_MATCH -> struct AttachMatch
* ATTACHPTR -> struct AttachPtr
* BODY -> struct Body
* body_cache_t -> struct BodyCache
* BUFFER -> struct Buffer
* BUFFY -> struct Buffy
* CHILD_CTX -> struct ChildCtx
* ciss_url_t -> struct CissUrl
* COLOR_LINE -> struct ColorLine
* COLOR_LIST -> struct ColorList
* compose_redraw_data_t -> struct ComposeRedrawData
* COMPRESS_INFO -> struct CompressInfo
* CONNECTION -> struct Connection
* CONTENT -> struct Content
* CONTENT_STATE -> struct ContentState
* CONTEXT -> struct Context
* crypt_entry_t -> struct CryptEntry
* crypt_key_t -> struct CryptKeyinfo
* crypt_module_t -> struct CryptModule
* ENTER_STATE -> struct EnterState
* ENTRY -> struct Entry
* ENVELOPE -> struct Envelope
* event_t -> struct Event
* FETCH_CTX -> struct FetchCtx
* flowed_state_t -> struct FlowedState
* FOLDER -> struct Folder
* group_t -> struct Group
* group_context_t -> struct GroupContext
* HASH -> struct Hash
* hcache_db_ctx_t -> struct HcacheDbCtx
* hcache_lmdb_ctx_t -> struct HcacheLmdbCtx
* HEADER -> struct Header
* HOOK -> struct Hook
* imap_auth_t -> struct ImapAuth
* IMAP_CACHE -> struct ImapCache
* IMAP_COMMAND -> struct ImapCommand
* IMAP_DATA -> struct ImapData
* IMAP_HEADER -> struct ImapHeader
* IMAP_HEADER_DATA -> struct ImapHeaderData
* IMAP_LIST -> struct ImapList
* IMAP_MBOX -> struct ImapMbox
* IMAP_STATUS -> struct ImapStatus
* LIST -> struct List
* mbchar_table -> struct MbCharTable
* MUTTMENU -> struct Menu
* MESSAGE -> struct Message
* MIXCHAIN -> struct MixChain
* THREAD -> struct MuttThread
* mutt_window_t -> struct MuttWindow
* myvar_t -> struct MyVar
* NEWSRC_ENTRY -> struct NewsrcEntry
* NNTP_ACACHE -> struct NntpAcache
* NNTP_DATA -> struct NntpData
* NNTP_HEADER_DATA -> struct NntpHeaderData
* NNTP_SERVER -> struct NntpServer
* pager_t -> struct Pager
* pager_redraw_data_t -> struct PagerRedrawData
* PARAMETER -> struct Parameter
* pattern_t -> struct Pattern
* pattern_cache_t -> struct PatternCache
* pgp_entry_t -> struct PgpEntry
* pgp_key_t -> struct PgpKeyInfo
* pgp_sig_t -> struct PgpSignature
* pgp_uid_t -> struct PgpUid
* pop_auth_t -> struct PopAuth
* POP_CACHE -> struct PopCache
* POP_DATA -> struct PopData
* progress_t -> struct Progress
* QUERY -> struct Query
* REGEXP -> struct Regex
* REMAILER -> struct Remailer
* REPLACE_LIST -> struct ReplaceList
* rfc1524_entry -> struct Rfc1524MailcapEntry
* RX_LIST -> struct RxList
* SASL_DATA -> struct SaslData
* SBENTRY -> struct SbEntry
* SCORE -> struct Score
* SHA1_CTX -> struct Sha1Ctx
* smime_key_t -> struct SmimeKey
* sslsockdata -> struct SslSockData
* STATE -> struct State
* TUNNEL_DATA -> struct TunnelData
Richard Russon [Tue, 16 May 2017 13:18:39 +0000 (14:18 +0100)]
replace 'TUNNEL_DATA' with 'struct TunnelData'
Richard Russon [Tue, 16 May 2017 13:18:38 +0000 (14:18 +0100)]
replace 'sslsockdata' with 'struct SslSockData'
Richard Russon [Tue, 16 May 2017 13:18:37 +0000 (14:18 +0100)]
replace 'SHA1_CTX' with 'struct Sha1Ctx'
Richard Russon [Tue, 16 May 2017 13:18:37 +0000 (14:18 +0100)]
replace 'SASL_DATA' with 'struct SaslData'
Richard Russon [Tue, 16 May 2017 13:18:36 +0000 (14:18 +0100)]
replace 'POP_DATA' with 'struct PopData'
Richard Russon [Tue, 16 May 2017 13:18:36 +0000 (14:18 +0100)]
replace 'POP_CACHE' with 'struct PopCache'
Richard Russon [Tue, 16 May 2017 13:18:35 +0000 (14:18 +0100)]
replace 'pop_auth_t' with 'struct PopAuth'
Richard Russon [Tue, 16 May 2017 13:18:35 +0000 (14:18 +0100)]
replace 'pattern_cache_t' with 'struct PatternCache'
Richard Russon [Tue, 16 May 2017 13:18:34 +0000 (14:18 +0100)]
replace 'pager_redraw_data_t' with 'struct PagerRedrawData'
Richard Russon [Tue, 16 May 2017 13:18:34 +0000 (14:18 +0100)]
replace 'pager_t' with 'struct Pager'
Richard Russon [Tue, 16 May 2017 13:18:33 +0000 (14:18 +0100)]
replace 'NNTP_SERVER' with 'struct NntpServer'
Richard Russon [Tue, 16 May 2017 13:18:33 +0000 (14:18 +0100)]
replace 'NNTP_HEADER_DATA' with 'struct NntpHeaderData'
Richard Russon [Tue, 16 May 2017 13:18:32 +0000 (14:18 +0100)]
replace 'NNTP_DATA' with 'struct NntpData'
Richard Russon [Tue, 16 May 2017 13:18:31 +0000 (14:18 +0100)]
replace 'NNTP_ACACHE' with 'struct NntpAcache'
Richard Russon [Tue, 16 May 2017 13:18:31 +0000 (14:18 +0100)]
replace 'NEWSRC_ENTRY' with 'struct NewsrcEntry'
Richard Russon [Tue, 16 May 2017 13:18:30 +0000 (14:18 +0100)]
replace 'IMAP_STATUS' with 'struct ImapStatus'
Richard Russon [Tue, 16 May 2017 13:18:30 +0000 (14:18 +0100)]
replace 'IMAP_MBOX' with 'struct ImapMbox'
Richard Russon [Tue, 16 May 2017 13:18:29 +0000 (14:18 +0100)]
replace 'IMAP_LIST' with 'struct ImapList'
Richard Russon [Tue, 16 May 2017 13:18:29 +0000 (14:18 +0100)]
replace 'IMAP_HEADER' with 'struct ImapHeader'
Richard Russon [Tue, 16 May 2017 13:18:28 +0000 (14:18 +0100)]
replace 'IMAP_DATA' with 'struct ImapData'
Richard Russon [Tue, 16 May 2017 13:18:28 +0000 (14:18 +0100)]
replace 'IMAP_COMMAND' with 'struct ImapCommand'
Richard Russon [Tue, 16 May 2017 13:18:27 +0000 (14:18 +0100)]
replace 'IMAP_CACHE' with 'struct ImapCache'
Richard Russon [Tue, 16 May 2017 13:18:27 +0000 (14:18 +0100)]
replace 'imap_auth_t' with 'struct ImapAuth'
Richard Russon [Tue, 16 May 2017 13:18:26 +0000 (14:18 +0100)]
replace 'hcache_lmdb_ctx_t' with 'struct HcacheLmdbCtx'
Richard Russon [Tue, 16 May 2017 13:18:26 +0000 (14:18 +0100)]
replace 'hcache_db_ctx_t' with 'struct HcacheDbCtx'
Richard Russon [Tue, 16 May 2017 13:18:25 +0000 (14:18 +0100)]
replace 'FETCH_CTX' with 'struct FetchCtx'
Richard Russon [Tue, 16 May 2017 13:18:25 +0000 (14:18 +0100)]
replace 'event_t' with 'struct Event'
Richard Russon [Tue, 16 May 2017 13:18:24 +0000 (14:18 +0100)]
replace 'CONTENT_STATE' with 'struct ContentState'
Richard Russon [Tue, 16 May 2017 13:18:24 +0000 (14:18 +0100)]
replace 'COMPRESS_INFO' with 'struct CompressInfo'
Richard Russon [Tue, 16 May 2017 13:18:23 +0000 (14:18 +0100)]
replace 'compose_redraw_data_t' with 'struct ComposeRedrawData'
Richard Russon [Tue, 16 May 2017 13:18:22 +0000 (14:18 +0100)]
replace 'CHILD_CTX' with 'struct ChildCtx'
Richard Russon [Tue, 16 May 2017 13:18:22 +0000 (14:18 +0100)]
replace 'ATTACH_MATCH' with 'struct AttachMatch'
Richard Russon [Tue, 16 May 2017 01:05:37 +0000 (02:05 +0100)]
replace 'smime_key_t' with 'struct SmimeKey'
Richard Russon [Tue, 16 May 2017 01:05:26 +0000 (02:05 +0100)]
replace 'SCORE' with 'struct Score'
Richard Russon [Tue, 16 May 2017 01:05:11 +0000 (02:05 +0100)]
replace 'SBENTRY' with 'struct SbEntry'
Richard Russon [Tue, 16 May 2017 01:05:05 +0000 (02:05 +0100)]
replace 'rfc1524_entry' with 'struct Rfc1524MailcapEntry'
Richard Russon [Tue, 16 May 2017 01:04:50 +0000 (02:04 +0100)]
replace 'REMAILER' with 'struct Remailer'
Richard Russon [Tue, 16 May 2017 01:04:44 +0000 (02:04 +0100)]
replace 'QUERY' with 'struct Query'
Richard Russon [Tue, 16 May 2017 01:04:37 +0000 (02:04 +0100)]
replace 'pgp_uid_t' with 'struct PgpUid'
Richard Russon [Tue, 16 May 2017 01:04:25 +0000 (02:04 +0100)]
replace 'pgp_sig_t' with 'struct PgpSignature'
Richard Russon [Tue, 16 May 2017 01:04:20 +0000 (02:04 +0100)]
replace 'pgp_entry_t' with 'struct PgpEntry'
Richard Russon [Tue, 16 May 2017 01:04:15 +0000 (02:04 +0100)]
replace 'myvar_t' with 'struct MyVar'
Richard Russon [Tue, 16 May 2017 01:04:02 +0000 (02:04 +0100)]
replace 'MIXCHAIN' with 'struct MixChain'
Richard Russon [Tue, 16 May 2017 01:03:38 +0000 (02:03 +0100)]
replace 'IMAP_HEADER_DATA' with 'struct ImapHeaderData'
Richard Russon [Tue, 16 May 2017 01:03:12 +0000 (02:03 +0100)]
replace 'HOOK' with 'struct Hook'
Richard Russon [Tue, 16 May 2017 01:02:58 +0000 (02:02 +0100)]
replace 'group_context_t' with 'struct GroupContext'
Richard Russon [Tue, 16 May 2017 01:02:53 +0000 (02:02 +0100)]
replace 'FOLDER' with 'struct Folder'
Richard Russon [Tue, 16 May 2017 01:02:11 +0000 (02:02 +0100)]
replace 'flowed_state_t' with 'struct FlowedState'
Richard Russon [Tue, 16 May 2017 01:01:55 +0000 (02:01 +0100)]
replace 'ENTRY' with 'struct Entry'
Richard Russon [Tue, 16 May 2017 01:07:33 +0000 (02:07 +0100)]
replace 'crypt_module_t' with 'struct CryptModule'
Richard Russon [Tue, 16 May 2017 01:01:38 +0000 (02:01 +0100)]
replace 'crypt_key_t' with 'struct CryptKeyinfo'
Richard Russon [Tue, 16 May 2017 01:01:27 +0000 (02:01 +0100)]
replace 'crypt_entry_t' with 'struct CryptEntry'
Richard Russon [Tue, 16 May 2017 01:01:20 +0000 (02:01 +0100)]
replace 'COLOR_LIST' with 'struct ColorList'
Richard Russon [Tue, 16 May 2017 01:01:05 +0000 (02:01 +0100)]
replace 'COLOR_LINE' with 'struct ColorLine'
Richard Russon [Tue, 16 May 2017 01:00:58 +0000 (02:00 +0100)]
replace 'ansi_attr' with 'struct AnsiAttr'
Richard Russon [Mon, 15 May 2017 13:51:38 +0000 (14:51 +0100)]
replace 'STATE' with 'struct State'
Richard Russon [Mon, 15 May 2017 13:51:09 +0000 (14:51 +0100)]
replace 'RX_LIST' with 'struct RxList'
Richard Russon [Mon, 15 May 2017 13:50:41 +0000 (14:50 +0100)]
replace 'REPLACE_LIST' with 'struct ReplaceList'
Richard Russon [Mon, 15 May 2017 13:50:07 +0000 (14:50 +0100)]
replace 'REGEXP' with 'struct Regex'
Richard Russon [Mon, 15 May 2017 13:49:35 +0000 (14:49 +0100)]
replace 'progress_t' with 'struct Progress'
Richard Russon [Mon, 15 May 2017 13:48:57 +0000 (14:48 +0100)]
replace 'pgp_key_t' with 'struct PgpKeyInfo'
Richard Russon [Mon, 15 May 2017 13:47:44 +0000 (14:47 +0100)]
replace 'pattern_t' with 'struct Pattern'
Richard Russon [Mon, 15 May 2017 13:47:06 +0000 (14:47 +0100)]
replace 'PARAMETER' with 'struct Parameter'
Richard Russon [Mon, 15 May 2017 13:46:34 +0000 (14:46 +0100)]
replace 'mutt_window_t' with 'struct MuttWindow'
Richard Russon [Mon, 15 May 2017 13:45:49 +0000 (14:45 +0100)]
replace 'THREAD' with 'struct MuttThread'
Richard Russon [Mon, 15 May 2017 13:44:05 +0000 (14:44 +0100)]
replace 'MESSAGE' with 'struct Message'
Richard Russon [Mon, 15 May 2017 13:43:38 +0000 (14:43 +0100)]
replace 'MUTTMENU' with 'struct Menu'
Richard Russon [Mon, 15 May 2017 13:42:40 +0000 (14:42 +0100)]
replace 'mbchar_table' with 'struct MbCharTable'
Richard Russon [Mon, 15 May 2017 13:41:57 +0000 (14:41 +0100)]
replace 'LIST' with 'struct List'
Richard Russon [Mon, 15 May 2017 13:41:30 +0000 (14:41 +0100)]
replace 'HEADER' with 'struct Header'