]> granicus.if.org Git - icu/log
icu
4 years agoOne improvement to error reporting.
Hugo van der Merwe [Tue, 5 May 2020 12:40:15 +0000 (14:40 +0200)]
One improvement to error reporting.

4 years agoFirst set of code review improvements.
Hugo van der Merwe [Tue, 5 May 2020 00:42:03 +0000 (02:42 +0200)]
First set of code review improvements.

4 years agoFix dependencies.txt, add documentation, add appropriate UMemory inheritence.
Hugo van der Merwe [Mon, 4 May 2020 19:39:37 +0000 (21:39 +0200)]
Fix dependencies.txt, add documentation, add appropriate UMemory inheritence.

4 years agoUnitPreferences class in unitsdata.cpp
Hugo van der Merwe [Wed, 29 Apr 2020 21:30:04 +0000 (23:30 +0200)]
UnitPreferences class in unitsdata.cpp

4 years agoUpdate unitsTest.txt and unitPreferencesTest.txt from current CLDR master.
Hugo van der Merwe [Thu, 30 Apr 2020 13:46:23 +0000 (15:46 +0200)]
Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master.

4 years agoMerge pull request #39 from hugovdm/unitsTestTxt
Shane F. Carr [Wed, 29 Apr 2020 21:52:34 +0000 (16:52 -0500)]
Merge pull request #39 from hugovdm/unitsTestTxt

testConversions: test convertibility of unitsTest.txt test cases.

4 years agoAdd IntlTest::assertNotEquals() for int32_t.
Hugo van der Merwe [Wed, 29 Apr 2020 19:55:13 +0000 (21:55 +0200)]
Add IntlTest::assertNotEquals() for int32_t.

4 years agoRemove hard-coded unit tests that were pulled out of unitsTest.txt.
Hugo van der Merwe [Wed, 29 Apr 2020 16:14:55 +0000 (18:14 +0200)]
Remove hard-coded unit tests that were pulled out of unitsTest.txt.

4 years agoAdd some comments to UnitsTestContext.
Hugo van der Merwe [Wed, 29 Apr 2020 16:10:08 +0000 (18:10 +0200)]
Add some comments to UnitsTestContext.

4 years agoRemove the 'FIXME_skip_tests' bool and branch.
Hugo van der Merwe [Wed, 29 Apr 2020 15:11:28 +0000 (17:11 +0200)]
Remove the 'FIXME_skip_tests' bool and branch.

4 years agoUncomment pound-force-per-square-inch test in unitsTest.txt
Hugo van der Merwe [Wed, 29 Apr 2020 12:10:28 +0000 (14:10 +0200)]
Uncomment pound-force-per-square-inch test in unitsTest.txt

4 years agotestConversions: test convertibility of unitsTest.txt test cases.
Hugo van der Merwe [Tue, 28 Apr 2020 19:48:28 +0000 (21:48 +0200)]
testConversions: test convertibility of unitsTest.txt test cases.

4 years agoMerge pull request #32 from younies/check_convirtible_units
Shane F. Carr [Tue, 28 Apr 2020 22:39:05 +0000 (17:39 -0500)]
Merge pull request #32 from younies/check_convirtible_units

Check convertible units

4 years agoadd units_extra to unitsformatter dependencies
Younies Mahmoud [Tue, 28 Apr 2020 21:54:54 +0000 (23:54 +0200)]
add units_extra to unitsformatter dependencies

4 years agoMerge pull request #31 from hugovdm/check_convirtible_units
Younies Mahmoud [Tue, 28 Apr 2020 15:35:08 +0000 (17:35 +0200)]
Merge pull request #31 from hugovdm/check_convirtible_units

Enable "testConversions" test again

4 years agoMerge branch 'check_convirtible_units' into check_convirtible_units
Younies Mahmoud [Tue, 28 Apr 2020 15:34:35 +0000 (17:34 +0200)]
Merge branch 'check_convirtible_units' into check_convirtible_units

4 years agofix unitConverter and add ConversionRates class
Younies Mahmoud [Tue, 28 Apr 2020 15:31:41 +0000 (17:31 +0200)]
fix unitConverter and add ConversionRates class

4 years agoEnable "testConversions" test again.
Hugo van der Merwe [Mon, 27 Apr 2020 17:43:08 +0000 (19:43 +0200)]
Enable "testConversions" test again.

With MeasureUnit fixes merged, these tests seem to pass now.

4 years agofix dependencies.txt
Younies Mahmoud [Mon, 27 Apr 2020 13:40:45 +0000 (15:40 +0200)]
fix dependencies.txt

4 years agomerge sffc/units-staging
Younies Mahmoud [Wed, 22 Apr 2020 14:19:32 +0000 (16:19 +0200)]
merge sffc/units-staging

4 years agoMerge pull request #31 from hugovdm/units-staging-getConversionRatesInfo
Shane F. Carr [Tue, 21 Apr 2020 20:47:01 +0000 (15:47 -0500)]
Merge pull request #31 from hugovdm/units-staging-getConversionRatesInfo

Add unitsdata.cpp, getConversionRatesInfo, and unit tests.

4 years agoMerge pull request #30 from hugovdm/check_convertible_units_identifierfixes
Younies Mahmoud [Fri, 17 Apr 2020 12:23:29 +0000 (14:23 +0200)]
Merge pull request #30 from hugovdm/check_convertible_units_identifierfixes

Fix the broken testConversionCapability unit identifiers.

4 years agoFix the broken testConversionCapability unit identifiers.
Hugo van der Merwe [Fri, 17 Apr 2020 00:57:09 +0000 (02:57 +0200)]
Fix the broken testConversionCapability unit identifiers.

4 years agoRemove testGetConversionRateInfo.
Hugo van der Merwe [Thu, 16 Apr 2020 23:49:29 +0000 (01:49 +0200)]
Remove testGetConversionRateInfo.

4 years agoFix deps: use UMemory as base class for it's new().
Hugo van der Merwe [Thu, 16 Apr 2020 23:47:57 +0000 (01:47 +0200)]
Fix deps: use UMemory as base class for it's new().

4 years agodependencies.txt attempt #1: where's "operator new(unsigned long)" coming from?
Hugo van der Merwe [Thu, 16 Apr 2020 22:49:06 +0000 (00:49 +0200)]
dependencies.txt attempt #1: where's "operator new(unsigned long)" coming from?

4 years agoNit: remove two unneeded #includes
Hugo van der Merwe [Thu, 16 Apr 2020 22:47:30 +0000 (00:47 +0200)]
Nit: remove two unneeded #includes

4 years agoComment out broken test cases as per younies' 476ca805c
Hugo van der Merwe [Thu, 16 Apr 2020 02:10:43 +0000 (04:10 +0200)]
Comment out broken test cases as per younies' 476ca805c

4 years agoLint: add copyright notices to .txt files from CLDR.
Hugo van der Merwe [Thu, 16 Apr 2020 01:59:44 +0000 (03:59 +0200)]
Lint: add copyright notices to .txt files from CLDR.

4 years agoSwitch result parameter from pointer to reference.
Hugo van der Merwe [Wed, 15 Apr 2020 11:59:48 +0000 (13:59 +0200)]
Switch result parameter from pointer to reference.

4 years agoReturn getAllConversionRates result via pointer parameter.
Hugo van der Merwe [Wed, 15 Apr 2020 11:55:00 +0000 (13:55 +0200)]
Return getAllConversionRates result via pointer parameter.

4 years agofix check Convertibility
Younies Mahmoud [Tue, 14 Apr 2020 21:01:57 +0000 (23:01 +0200)]
fix check Convertibility

4 years agoImprove documentation comments.
Hugo van der Merwe [Tue, 14 Apr 2020 18:59:41 +0000 (20:59 +0200)]
Improve documentation comments.

4 years agoChange outVector from reference to pointer for clarity of lack of ownership.
Hugo van der Merwe [Tue, 14 Apr 2020 15:10:56 +0000 (17:10 +0200)]
Change outVector from reference to pointer for clarity of lack of ownership.

4 years agoAdd getAllConversionRates(), drop selective code.
Hugo van der Merwe [Tue, 14 Apr 2020 14:33:59 +0000 (16:33 +0200)]
Add getAllConversionRates(), drop selective code.

4 years agofix compound basic unit
Younies Mahmoud [Tue, 14 Apr 2020 13:52:51 +0000 (15:52 +0200)]
fix compound basic unit

4 years agoMerge pull request #28 from hugovdm/hugovdm_check_convertible_units_unitstest
Younies Mahmoud [Tue, 14 Apr 2020 12:13:39 +0000 (14:13 +0200)]
Merge pull request #28 from hugovdm/hugovdm_check_convertible_units_unitstest

Test convertibility of some unitsTest.txt tests

4 years agosmall fixes
Younies Mahmoud [Tue, 14 Apr 2020 09:13:28 +0000 (11:13 +0200)]
small fixes

4 years agoMerge branch 'check_convirtible_units' of github.com:younies/icu into check_convirtib...
Younies Mahmoud [Tue, 7 Apr 2020 20:15:34 +0000 (22:15 +0200)]
Merge branch 'check_convirtible_units' of github.com:younies/icu into check_convirtible_units

4 years agoMerge remote-tracking branch 'upstream/maint/maint-67' into units-staging
Shane F. Carr [Tue, 7 Apr 2020 16:44:16 +0000 (11:44 -0500)]
Merge remote-tracking branch 'upstream/maint/maint-67' into units-staging

4 years agofixup! Rip out compound base unit calculation.
Hugo van der Merwe [Tue, 7 Apr 2020 14:14:24 +0000 (16:14 +0200)]
fixup! Rip out compound base unit calculation.

4 years agoCopy failing unitsTest.txt examples into testConversionCapability.
Hugo van der Merwe [Tue, 7 Apr 2020 13:18:03 +0000 (15:18 +0200)]
Copy failing unitsTest.txt examples into testConversionCapability.

4 years agoMerge pull request #33 from hugovdm/units-staging-testcases
Hugo [Tue, 7 Apr 2020 12:06:50 +0000 (14:06 +0200)]
Merge pull request #33 from hugovdm/units-staging-testcases

Update to latest CLDR test files: b7a23f3f41 CLDR-13587.

4 years agoMerge pull request #34 from hugovdm/units-staging-testimprovements
Hugo [Tue, 7 Apr 2020 12:05:48 +0000 (14:05 +0200)]
Merge pull request #34 from hugovdm/units-staging-testimprovements

Improve test output: no more fprintfs.

4 years agoICU-21060 Fix the foo-per-a-b -> foo-b-per-a bug.
Hugo van der Merwe [Fri, 3 Apr 2020 02:35:29 +0000 (04:35 +0200)]
ICU-21060 Fix the foo-per-a-b -> foo-b-per-a bug.

4 years agoMerge branch 'master' into units-staging
Shane F. Carr [Fri, 3 Apr 2020 21:47:36 +0000 (16:47 -0500)]
Merge branch 'master' into units-staging

4 years agoICU-20979 API Change Report for 67 RC release-67-rc
Steven R. Loomis [Fri, 3 Apr 2020 14:28:08 +0000 (07:28 -0700)]
ICU-20979 API Change Report for 67 RC

4 years agofixup! Rip out compound base unit calculation.
Hugo van der Merwe [Fri, 3 Apr 2020 09:52:41 +0000 (11:52 +0200)]
fixup! Rip out compound base unit calculation.

4 years agoICU-20979 Update TODOs in formatting code to point to open issues.
Shane F. Carr [Fri, 3 Apr 2020 02:16:11 +0000 (21:16 -0500)]
ICU-20979 Update TODOs in formatting code to point to open issues.

Also see: ICU-20920 ICU-21059 ICU-20429 ICU-21058

4 years agoICU-21015 Fixing gcc compiler warnings
Shane F. Carr [Tue, 31 Mar 2020 03:21:24 +0000 (22:21 -0500)]
ICU-21015 Fixing gcc compiler warnings

4 years agoComment out test case that seems to trigger a MeasureUnit parsing bug.
Hugo van der Merwe [Fri, 3 Apr 2020 01:27:45 +0000 (03:27 +0200)]
Comment out test case that seems to trigger a MeasureUnit parsing bug.

4 years agoImprove test output: no more fprintfs.
Hugo van der Merwe [Fri, 3 Apr 2020 00:25:12 +0000 (02:25 +0200)]
Improve test output: no more fprintfs.

4 years agoICU-20979 Updating double-conversion from upstream master
Shane F. Carr [Tue, 31 Mar 2020 02:36:28 +0000 (21:36 -0500)]
ICU-20979 Updating double-conversion from upstream master

4 years agoICU-20979 delete no-longer-relevant comment related to U_HIDE macros
Peter Edberg [Thu, 2 Apr 2020 07:47:40 +0000 (00:47 -0700)]
ICU-20979 delete no-longer-relevant comment related to U_HIDE macros

4 years agoICU-20979 integrate CLDR release-37-beta2 to master
Peter Edberg [Wed, 1 Apr 2020 23:20:18 +0000 (16:20 -0700)]
ICU-20979 integrate CLDR release-37-beta2 to master

4 years agoICU-20979 BRS 67rc, ICU4C API promotion
Peter Edberg [Wed, 1 Apr 2020 02:43:35 +0000 (19:43 -0700)]
ICU-20979 BRS 67rc, ICU4C API promotion

4 years agoICU-20979 Update ICU4C readme
Daniel Ju [Wed, 1 Apr 2020 22:13:18 +0000 (15:13 -0700)]
ICU-20979 Update ICU4C readme

4 years agoICU-21022 Update logKnownIssue to refer to ticket for fixing in a future release
Peter Edberg [Wed, 1 Apr 2020 21:25:29 +0000 (14:25 -0700)]
ICU-21022 Update logKnownIssue to refer to ticket for fixing in a future release

4 years agoICU-20979 BRS67RC Updating ICU4J readme
Yoshito Umaoka [Wed, 1 Apr 2020 21:23:54 +0000 (17:23 -0400)]
ICU-20979 BRS67RC Updating ICU4J readme

For now, just updating version to 67, but not mentioning it's RC, so we don't need another update.

I also updated all dead ICU user guide links.

4 years agoICU-20979 BRS67RC Adding ICU4J 67 API signature data file
Yoshito Umaoka [Wed, 1 Apr 2020 21:29:40 +0000 (17:29 -0400)]
ICU-20979 BRS67RC Adding ICU4J 67 API signature data file

And removed ICU4J 57 API signature data file.

4 years agoICU-20979 BRS67RC Updating ICU4J API change report
Yoshito Umaoka [Wed, 1 Apr 2020 20:31:52 +0000 (16:31 -0400)]
ICU-20979 BRS67RC Updating ICU4J API change report

Incoorporating last minutes fixes found during change report review.

4 years agoICU-20979 Fixing instructions in commit report tool
Shane F. Carr [Tue, 31 Mar 2020 02:24:39 +0000 (21:24 -0500)]
ICU-20979 Fixing instructions in commit report tool

4 years agoICU-20979 Fixing minor MSVC warnings
Jeff Genovy [Tue, 31 Mar 2020 20:01:55 +0000 (13:01 -0700)]
ICU-20979 Fixing minor MSVC warnings

4 years agoICU-20099 Fix API tags in ListFormatter.SpanField
Shane F. Carr [Wed, 1 Apr 2020 18:42:32 +0000 (13:42 -0500)]
ICU-20099 Fix API tags in ListFormatter.SpanField

4 years agoICU-20806 Removing 'implements Cloneable' from Precision.java
Shane F. Carr [Wed, 1 Apr 2020 18:26:53 +0000 (13:26 -0500)]
ICU-20806 Removing 'implements Cloneable' from Precision.java

4 years agoICU-20979 BRS67RC ICU4J API status promotion
Yoshito Umaoka [Wed, 1 Apr 2020 00:25:38 +0000 (20:25 -0400)]
ICU-20979 BRS67RC ICU4J API status promotion

Update ICU draft API up to 64 to stable. Regenerated API change report.

4 years agoICU-20979 BRS67RC Adding ICU4J serialization test data generated by 67
Yoshito Umaoka [Wed, 1 Apr 2020 00:46:41 +0000 (20:46 -0400)]
ICU-20979 BRS67RC Adding ICU4J serialization test data generated by 67

Also dropped ICU4J 62 serialization test data.

4 years agoUpdate to latest CLDR test files: b7a23f3f41 CLDR-13587.
Hugo van der Merwe [Wed, 1 Apr 2020 16:02:23 +0000 (18:02 +0200)]
Update to latest CLDR test files: b7a23f3f41 CLDR-13587.

These files come from a CLDR commit on 2020-03-18.

4 years agoUncomment test cases that MeasureFormat used to flag as ILLEGAL_ARG.
Hugo van der Merwe [Wed, 1 Apr 2020 15:57:03 +0000 (17:57 +0200)]
Uncomment test cases that MeasureFormat used to flag as ILLEGAL_ARG.

4 years agoICU-13724 Removing obsolete numberformat2test.cpp
Shane F. Carr [Tue, 31 Mar 2020 02:48:54 +0000 (21:48 -0500)]
ICU-13724 Removing obsolete numberformat2test.cpp

4 years agoICU-20979 BRS 67rc, update urename.h
Peter Edberg [Mon, 30 Mar 2020 05:14:43 +0000 (22:14 -0700)]
ICU-20979 BRS 67rc, update urename.h

4 years agoadjust the test cases 2
Younies Mahmoud [Tue, 31 Mar 2020 11:54:57 +0000 (13:54 +0200)]
adjust the test cases 2

4 years agoadjust the test cases
Younies Mahmoud [Tue, 31 Mar 2020 11:52:41 +0000 (13:52 +0200)]
adjust the test cases

4 years agoMerge branch 'units-staging-getConversionRatesInfo' of github.com:hugovdm/icu into...
Younies Mahmoud [Tue, 31 Mar 2020 11:25:55 +0000 (13:25 +0200)]
Merge branch 'units-staging-getConversionRatesInfo' of github.com:hugovdm/icu into check_convirtible_units

4 years agoICU-20979 BRS67RC Fixed a java doc issue
Yoshito Umaoka [Mon, 30 Mar 2020 15:29:19 +0000 (11:29 -0400)]
ICU-20979 BRS67RC Fixed a java doc issue

4 years agoICU-20979 BRS67RC Clean up import statements
Yoshito Umaoka [Mon, 30 Mar 2020 14:44:28 +0000 (10:44 -0400)]
ICU-20979 BRS67RC Clean up import statements

4 years agoHave getConversionRatesInfo accept a MaybeStackVector instead of only source and...
Hugo van der Merwe [Mon, 30 Mar 2020 18:47:40 +0000 (20:47 +0200)]
Have getConversionRatesInfo accept a MaybeStackVector instead of only source and target.

4 years agoReorder unit tests, drop unneeded comments.
Hugo van der Merwe [Mon, 30 Mar 2020 16:29:39 +0000 (18:29 +0200)]
Reorder unit tests, drop unneeded comments.

This code and these tests have become quite a bit simpler since
we're no longer trying to calculate the 'compound base unit'
here.

4 years agoRip out compound base unit calculation.
Hugo van der Merwe [Mon, 30 Mar 2020 16:05:29 +0000 (18:05 +0200)]
Rip out compound base unit calculation.

4 years agoAdd failing reciprocal test that we want to have passing.
Hugo van der Merwe [Mon, 30 Mar 2020 15:35:48 +0000 (17:35 +0200)]
Add failing reciprocal test that we want to have passing.

4 years agoFix mistake in commented-out identifier in previous commit.
Hugo van der Merwe [Mon, 30 Mar 2020 12:49:03 +0000 (14:49 +0200)]
Fix mistake in commented-out identifier in previous commit.

4 years agocreate CheckUnitsState function
Younies Mahmoud [Mon, 30 Mar 2020 12:43:50 +0000 (14:43 +0200)]
create CheckUnitsState function

4 years agoFix comments: remove a WIP, fix expectations in disabled/failing test.
Hugo van der Merwe [Mon, 30 Mar 2020 12:14:02 +0000 (14:14 +0200)]
Fix comments: remove a WIP, fix expectations in disabled/failing test.

4 years agoclang-format pass over new files, for good measure
Hugo van der Merwe [Sat, 28 Mar 2020 20:10:02 +0000 (21:10 +0100)]
clang-format pass over new files, for good measure

4 years agoClean up getConversionRatesInfo to prepare for review.
Hugo van der Merwe [Sat, 28 Mar 2020 19:56:51 +0000 (20:56 +0100)]
Clean up getConversionRatesInfo to prepare for review.

4 years agoManual cherry-pick of getConversionRatesInfo
Hugo van der Merwe [Sat, 28 Mar 2020 18:47:32 +0000 (19:47 +0100)]
Manual cherry-pick of getConversionRatesInfo

4 years agoICU-20803 Pass ByteSink to _canonicalize().
Fredrik Roubert [Thu, 12 Mar 2020 21:45:00 +0000 (22:45 +0100)]
ICU-20803 Pass ByteSink to _canonicalize().

This eliminates the need for the fixed size scratch buffer inside of
locale_set_default_internal() and also eliminates the need for counting
bytes, something that ByteSink and CharString now will handle correctly,
when needed.

None of this should have any externally visible effect (apart from
removing the arbitrary size limit imposed by the fixed size scratch
buffer), it's all about cleaning up implementation internals.

4 years agoICU-20964 Fix small typo mistake
Younies Mahmoud [Thu, 26 Mar 2020 10:50:57 +0000 (10:50 +0000)]
ICU-20964 Fix small typo mistake

See #974

4 years agoICU-21026 fix GCC warnings of signed-int left shift
Elango Cheran [Thu, 26 Mar 2020 21:21:26 +0000 (14:21 -0700)]
ICU-21026 fix GCC warnings of signed-int left shift

4 years agoICU-20979 BRS67RC Update version numbers, regenerate configure, update ICU4C README
Daniel Ju [Thu, 26 Mar 2020 20:59:30 +0000 (13:59 -0700)]
ICU-20979 BRS67RC Update version numbers, regenerate configure, update ICU4C README

4 years agoICU-20854 Add support for more currency variants.
Shane F. Carr [Thu, 26 Mar 2020 01:01:59 +0000 (01:01 +0000)]
ICU-20854 Add support for more currency variants.

See #878

4 years agoICU-21020 Fix a typo in the LocalizedNumberRangeFormatter's documentation
Victor Chang [Thu, 26 Mar 2020 12:26:47 +0000 (12:26 +0000)]
ICU-21020 Fix a typo in the LocalizedNumberRangeFormatter's documentation

4 years agoICU-20435 Fix parallel builds with Cygwin to 3.x
Jeff Genovy [Wed, 25 Mar 2020 22:32:19 +0000 (15:32 -0700)]
ICU-20435 Fix parallel builds with Cygwin to 3.x

4 years agoICU-20418 Number skeletons: implement star wildcard; user guide fixes
Shane F. Carr [Wed, 25 Mar 2020 21:22:23 +0000 (21:22 +0000)]
ICU-20418 Number skeletons: implement star wildcard; user guide fixes

See #1060

4 years agoICU-21005 Fix exhaustive test failure in IntlTestNumberFormat.
Shane F. Carr [Thu, 26 Mar 2020 01:24:08 +0000 (20:24 -0500)]
ICU-21005 Fix exhaustive test failure in IntlTestNumberFormat.

4 years agoICU-20920 Changing "Sequence" to "Mixed" in ICU4C MeasureUnit
Shane F. Carr [Wed, 25 Mar 2020 19:21:07 +0000 (14:21 -0500)]
ICU-20920 Changing "Sequence" to "Mixed" in ICU4C MeasureUnit

4 years agoICU-21022 Use logKnownIssue to avoid TestDateFormatRoundTrip exhaustive fail
Peter Edberg [Wed, 25 Mar 2020 06:59:06 +0000 (23:59 -0700)]
ICU-21022 Use logKnownIssue to avoid TestDateFormatRoundTrip exhaustive fail

4 years agoICU-20919 Merge maint/maint-66 into master
Shane F. Carr [Wed, 25 Mar 2020 17:50:01 +0000 (12:50 -0500)]
ICU-20919 Merge maint/maint-66 into master

4 years agoICU-20435 Update Cygwin to 3.x to fix CI builds.
Jeff Genovy [Mon, 23 Mar 2020 19:31:15 +0000 (12:31 -0700)]
ICU-20435 Update Cygwin to 3.x to fix CI builds.

Cygwin doesn't fully build with a parallel make, so split it out
in order to speed things up somewhat.

4 years agoICU-20919 Merge branch 'maint/maint-66' into 66-merge-branch 1055/head
Shane F. Carr [Wed, 25 Mar 2020 17:42:19 +0000 (12:42 -0500)]
ICU-20919 Merge branch 'maint/maint-66' into 66-merge-branch