Jani Taskinen [Thu, 12 Jul 2007 22:05:09 +0000 (22:05 +0000)]
- Fixed bug #39291 (ldap_sasl_bind() is mising sasl_authc_id paratemeter)
# It's the equivalent for the ldapsearch -U parameter
# @doc, @DOC or whatever the tag was..
The last bunch of changes to the old 0*.phpt tests. Once final time a
verbose explanation of changes:
- take connection parameter from connect.inc
- use proper UEXPECTF
- have 'print "done!"' or similar at the end to detect crashes
- whitespace changes where needed
- take care of portability: PHP 5 vs. PHP 5, MySQL 4.1 - 6.0
- understand return value checking as sometime that makes you type
more when you write but makes you happy when you debug
I forgot to mention: some will fail. In particular in unicode mode.
Next 10 in row to be tweaked:
- take connection parameter from connect.inc
- use proper UEXPECTF
- have 'print "done!"' or similar at the end to detect crashes
- whitespace changes where needed
- take care of portability: PHP 5 vs. PHP 5, MySQL 4.1 - 6.0
- understand return value checking as sometime that makes you type
more when you write but makes you happy when you debug
- take connection parameter from connect.inc
- use proper UEXPECTF
- have 'print "done!"' or similar at the end to detect crashes
- whitespace changes where needed
- take care of portability: PHP 5 vs. PHP 5, MySQL 4.1 - 6.0
- understand return value checking as sometime that makes you type
more when you write but makes you happy when you debug
- take connection parameter from connect.inc
- use proper UEXPECTF
- have 'print "done!"' or similar at the end to detect crashes
- whitespace changes where needed
- take care of portability: PHP 5 vs. PHP 5, MySQL 4.1 - 6.0
Pretty much the same cosmetics and tweaking as before (proper UEXPECTF,
"done!" at the end to detect crashes, connection parameter tweaking, ...) -
plus: check return codes even if failures are unlikely.
1) Try to have portable SQL, don't create your own schema unless the test
wants to test exactly this
2) Don't rely on default SQL sort orders
3) Use proper UEXPECTF. There have been a lot of tiny unicode issues when
ext/mysqli has returned a binary string in unicode mode although a
unicode string could be expected and vice versa
All the upcoming changes in the 0*.phpt files are pretty much the same. I'll
describe them only once in with a bit of detail.
1) Correct Whitespace (space vs. tab) if need be
2) Recall: you get the connection parameter from connect.inc, no DB name, no
port no other connection parameter in any of the tests!
3) At the end of each test you find a "print 'done!'" or similar. This is
most helpful to detect crashing/segfaulting tests with all run-tests.php
versions.
Some tests intentionally fail connecting to the DB. Not being able to
connect is no reason to skip the test. Also, no test should have hard-wired
connection parameter in it. Connection parameters come from connect.inc
(see environment variables in connect.inc).
Starting to merge the latest set of ext/mysqli tests from the mysqlnd
SVN repro into HEAD. Again, it might happen that I crash the set of tests
and don't mention one or the other change while merging. Blame me...
1) Note the new environment variables to control the test run
2) Variables $IS_MYSQLND and $MYSQLND_VERSION are for writing portable tests
3) sys_get_temp_dir function is for PHP5/PHP6 portability
- Fixed bug #41964 (strtotime returns a timestamp for non-time string of
pattern '(A|a) .+').
- Fixed bug #41844 (Format returns incorrect number of digits for negative
years -0001 to -0999).
- Fixed bug #41842 (Cannot create years < 0100 & negative years with
date_create or new DateTime).
- Fixed bug #41709 (strtotime() does not handle 00.00.0000).
- Fixed bug #41523 (strtotime('0000-00-00 00:00:00') is parsed as 1999-11-30).
1) Whitespace/CS
2) Portability: don't expect any values and have them in the [U]EXPECTF,
if they will be available only with certain MySQL Server versions.