]> granicus.if.org Git - postgresql/log
postgresql
21 years agoAdd more footnote comments to the release notes.
Bruce Momjian [Wed, 29 Oct 2003 22:54:01 +0000 (22:54 +0000)]
Add more footnote comments to the release notes.

21 years agoFix some corner cases in ACL manipulation: don't foul up on an empty
Tom Lane [Wed, 29 Oct 2003 22:20:54 +0000 (22:20 +0000)]
Fix some corner cases in ACL manipulation: don't foul up on an empty
ACL array, and force languages to be treated as owned by the bootstrap
user ID.  (pg_language should have a lanowner column, but until it does
this will have to do as a workaround.)

21 years agoAdd first release note detail item.
Bruce Momjian [Wed, 29 Oct 2003 20:38:19 +0000 (20:38 +0000)]
Add first release note detail item.

21 years agoUpdate for 7.4 --- prefer IN to EXISTS.
Bruce Momjian [Wed, 29 Oct 2003 20:20:12 +0000 (20:20 +0000)]
Update for 7.4 --- prefer IN to EXISTS.

21 years agoGive a useful error message if a RangeVar is encountered in an expression.
Tom Lane [Wed, 29 Oct 2003 18:10:15 +0000 (18:10 +0000)]
Give a useful error message if a RangeVar is encountered in an expression.
Per example from Ian Barwick, 28-Oct-03.

21 years agocompact_fsm_storage() does need to handle the case where a relation's
Tom Lane [Wed, 29 Oct 2003 17:36:57 +0000 (17:36 +0000)]
compact_fsm_storage() does need to handle the case where a relation's
FSM data has to be both moved down and compressed.  Per report from
Dror Matalon.

21 years agoUpdate for OSF 4.0 platform.
Bruce Momjian [Wed, 29 Oct 2003 13:42:55 +0000 (13:42 +0000)]
Update for OSF 4.0 platform.

21 years agoPatches from Oliver Jowett to fix CursorFetchTest, 7.4 now does not automatically...
Dave Cramer [Wed, 29 Oct 2003 02:39:10 +0000 (02:39 +0000)]
Patches from Oliver Jowett to fix CursorFetchTest, 7.4 now does not automatically delete cursors

21 years agoDon't include "schema." in the set of possible tab completions once
Tom Lane [Tue, 28 Oct 2003 23:35:52 +0000 (23:35 +0000)]
Don't include "schema." in the set of possible tab completions once
"schema." has been typed.  This allows readline to complete subsequent
characters immediately if all relations in the target schema start with
the same prefix.  This actually worked before, but I unintentionally
broke it a few days ago.
Also, make completion schema-aware for GRANT, REVOKE, VACUUM.

21 years agoInclude -lkrb5 when needed for shlibs depending on libpq. Per report
Tom Lane [Tue, 28 Oct 2003 21:55:58 +0000 (21:55 +0000)]
Include -lkrb5 when needed for shlibs depending on libpq.  Per report
from Johan Henselmans.

21 years agoDon't choke when the handler for a procedural language is located in
Tom Lane [Tue, 28 Oct 2003 21:05:29 +0000 (21:05 +0000)]
Don't choke when the handler for a procedural language is located in
the pg_catalog schema.  Per bug report some months back from Jochem van Dieten.

21 years agoGuard against Ant versions that print CLASSPATH before the version number
Tom Lane [Tue, 28 Oct 2003 20:26:47 +0000 (20:26 +0000)]
Guard against Ant versions that print CLASSPATH before the version number
in -version output.  Per report from Johann Uhrmann.

21 years agoAdjust wording to avoid giving the impression that schema USAGE
Tom Lane [Tue, 28 Oct 2003 20:18:09 +0000 (20:18 +0000)]
Adjust wording to avoid giving the impression that schema USAGE
privilege hides system catalog entries.

21 years agoAdd --describe-config to top of postgres manual page.
Bruce Momjian [Tue, 28 Oct 2003 19:39:18 +0000 (19:39 +0000)]
Add --describe-config to top of postgres manual page.

21 years agoDocument --describe-config.
Bruce Momjian [Tue, 28 Oct 2003 15:01:27 +0000 (15:01 +0000)]
Document --describe-config.

21 years agoChange Solaris tests to test for SHM_SHARE_MMU, per Tom.
Bruce Momjian [Mon, 27 Oct 2003 18:30:07 +0000 (18:30 +0000)]
Change Solaris tests to test for SHM_SHARE_MMU, per Tom.

21 years agoUpdate Win32 clients.
Bruce Momjian [Mon, 27 Oct 2003 15:35:10 +0000 (15:35 +0000)]
Update Win32 clients.

21 years agoUn-break Darwin port.
Tom Lane [Mon, 27 Oct 2003 07:42:34 +0000 (07:42 +0000)]
Un-break Darwin port.

21 years agoHere is an update to the dbmirror README file.
Bruce Momjian [Mon, 27 Oct 2003 02:52:45 +0000 (02:52 +0000)]
Here is an update to the dbmirror README file.

-References to older versions of PostgreSQL have been removed(It no
longer
compiles against older versions)
-Added a link to PgPerl at GBorg.

Steven Singer

21 years agoFix MOVE/FETCH wording.
Bruce Momjian [Mon, 27 Oct 2003 02:51:39 +0000 (02:51 +0000)]
Fix MOVE/FETCH wording.

21 years agoUpdate intel solaris.
Bruce Momjian [Sun, 26 Oct 2003 14:31:09 +0000 (14:31 +0000)]
Update intel solaris.

21 years agoImprove indenting of port entries.
Bruce Momjian [Sun, 26 Oct 2003 13:28:46 +0000 (13:28 +0000)]
Improve indenting of port entries.

21 years agoUpdate Solaris 5.6.
Bruce Momjian [Sun, 26 Oct 2003 13:26:41 +0000 (13:26 +0000)]
Update Solaris 5.6.

21 years agoCorrect version numbers.
Peter Eisentraut [Sun, 26 Oct 2003 11:14:39 +0000 (11:14 +0000)]
Correct version numbers.

21 years agoFixed bug with indicators when storage for the string is dynamically allocated.
Michael Meskes [Sun, 26 Oct 2003 09:50:47 +0000 (09:50 +0000)]
Fixed bug with indicators when storage for the string is dynamically allocated.

21 years ago'sun' => '__sun__'
Bruce Momjian [Sun, 26 Oct 2003 04:54:44 +0000 (04:54 +0000)]
'sun' => '__sun__'

21 years agoTest for 'sun' rather than 'solaris' for intimate shared memory.
Bruce Momjian [Sun, 26 Oct 2003 04:53:24 +0000 (04:53 +0000)]
Test for 'sun' rather than 'solaris' for intimate shared memory.

21 years agoFix two bugs in funcs.source that made the tutorial script fail.
Bruce Momjian [Sun, 26 Oct 2003 04:51:51 +0000 (04:51 +0000)]
Fix two bugs in funcs.source that made the tutorial script fail.

Make a LOT of fixes to syscat.source to:

* Set search_path properly (and reset it)
* Add schema name to all results
* Add schema name to ORDER BY first
* Make checks for user-defined objects match reality
* format_type all type names
* Respect attisdropped
* Change !~ to 'not like' since it's more standard

Christopher Kings-Lynne

21 years agoUpdate MOVE/FETCH release note mention.
Bruce Momjian [Sun, 26 Oct 2003 04:50:16 +0000 (04:50 +0000)]
Update MOVE/FETCH release note mention.

21 years agoAdd:
Bruce Momjian [Sun, 26 Oct 2003 04:43:55 +0000 (04:43 +0000)]
Add:

> * Change LIMIT/OFFSET to use int8

21 years agoAdd mention of quotes on function body to NOTES section.
Bruce Momjian [Sun, 26 Oct 2003 04:34:05 +0000 (04:34 +0000)]
Add mention of quotes on function body to NOTES section.

Oliver Elphick

21 years agoAllow win32 client compiles with MSC.
Bruce Momjian [Sun, 26 Oct 2003 04:29:15 +0000 (04:29 +0000)]
Allow win32 client compiles with MSC.

Hiroshi Saito

21 years ago*** empty log message ***
Bruce Momjian [Sun, 26 Oct 2003 04:21:43 +0000 (04:21 +0000)]
*** empty log message ***

21 years agoAdd:
Bruce Momjian [Sun, 26 Oct 2003 02:57:39 +0000 (02:57 +0000)]
Add:

> * Allow more ISOLATION LEVELS to be accepted, but issue a warning for them

21 years agoUppercase a few keywords in queries.
Bruce Momjian [Sun, 26 Oct 2003 02:53:45 +0000 (02:53 +0000)]
Uppercase a few keywords in queries.

21 years agoUpdate for m68k from Peter.
Bruce Momjian [Sun, 26 Oct 2003 01:41:10 +0000 (01:41 +0000)]
Update for m68k from Peter.

21 years agoUpdate for Noèl Köthe in SGML.
Bruce Momjian [Sun, 26 Oct 2003 01:39:43 +0000 (01:39 +0000)]
Update for Noèl Köthe in SGML.

21 years agoMark Linux/ppc as working.
Bruce Momjian [Sun, 26 Oct 2003 01:32:36 +0000 (01:32 +0000)]
Mark Linux/ppc as working.

21 years agoMark linux m68k, alpha as working.
Bruce Momjian [Sun, 26 Oct 2003 01:19:57 +0000 (01:19 +0000)]
Mark linux m68k, alpha as working.

21 years agoRemove very old platforms as unsupported, <=7.0.
Bruce Momjian [Sun, 26 Oct 2003 01:17:31 +0000 (01:17 +0000)]
Remove very old platforms as unsupported, <=7.0.

21 years agoMark true64 os version as 5.1.
Bruce Momjian [Sun, 26 Oct 2003 01:06:35 +0000 (01:06 +0000)]
Mark true64 os version as 5.1.

21 years agoMark true64 alpha port as working.
Bruce Momjian [Sun, 26 Oct 2003 01:05:53 +0000 (01:05 +0000)]
Mark true64 alpha port as working.

21 years agoFix Hans' name in SGML.
Bruce Momjian [Sun, 26 Oct 2003 00:58:31 +0000 (00:58 +0000)]
Fix Hans' name in SGML.

21 years agoUpdate aix port.
Bruce Momjian [Sun, 26 Oct 2003 00:31:48 +0000 (00:31 +0000)]
Update aix port.

21 years agoFix #elif typo.
Bruce Momjian [Sun, 26 Oct 2003 00:27:59 +0000 (00:27 +0000)]
Fix #elif typo.

21 years agoUpdate linux/mips port.
Bruce Momjian [Sun, 26 Oct 2003 00:26:13 +0000 (00:26 +0000)]
Update linux/mips port.

Add m68k to linux port.

21 years agoUpdate linux/mips port.
Bruce Momjian [Sun, 26 Oct 2003 00:22:51 +0000 (00:22 +0000)]
Update linux/mips port.

21 years agoupdate linux ports for arm, s390, itanium.
Bruce Momjian [Sun, 26 Oct 2003 00:21:04 +0000 (00:21 +0000)]
update linux ports for arm, s390, itanium.

21 years agoUpdate for port freebsd/alpha.
Bruce Momjian [Sun, 26 Oct 2003 00:00:40 +0000 (00:00 +0000)]
Update for port freebsd/alpha.

21 years agoGet Tru64/cc to compile. Need to add -ieee so that it doesn't choke on
Peter Eisentraut [Sat, 25 Oct 2003 20:18:53 +0000 (20:18 +0000)]
Get Tru64/cc to compile.  Need to add -ieee so that it doesn't choke on
0.0/0.0.  That option appears to affect the regression test result as well.
The compiler documentation doesn't recommend -O4 for universal use, so
let's stick to the conservative -O (== -O2) by default.

21 years agoTranslation update
Peter Eisentraut [Sat, 25 Oct 2003 18:18:19 +0000 (18:18 +0000)]
Translation update

21 years agoTranslation updates
Peter Eisentraut [Sat, 25 Oct 2003 18:03:21 +0000 (18:03 +0000)]
Translation updates

21 years agoFix CFLAGS selection to actually work. Add test to detect whether gcc's
Peter Eisentraut [Sat, 25 Oct 2003 15:32:11 +0000 (15:32 +0000)]
Fix CFLAGS selection to actually work.  Add test to detect whether gcc's
option -fno-strict-aliasing is available.

21 years agoRemove socket credentials defines not referenced.
Bruce Momjian [Sat, 25 Oct 2003 03:48:47 +0000 (03:48 +0000)]
Remove socket credentials defines not referenced.

21 years agoUpdate Netbsd/i386 port.
Bruce Momjian [Sat, 25 Oct 2003 03:23:47 +0000 (03:23 +0000)]
Update Netbsd/i386 port.

21 years agoUpdate ports for Solaris.
Bruce Momjian [Sat, 25 Oct 2003 03:17:43 +0000 (03:17 +0000)]
Update ports for Solaris.

21 years agoRemove weird test in ccsym
Bruce Momjian [Fri, 24 Oct 2003 21:28:52 +0000 (21:28 +0000)]
Remove weird test in ccsym

21 years agoUpdate openbsd port.
Bruce Momjian [Fri, 24 Oct 2003 21:09:08 +0000 (21:09 +0000)]
Update openbsd port.

21 years agoDon't reference pthread.h unless we have threads enabled, per Peter.
Bruce Momjian [Fri, 24 Oct 2003 20:48:10 +0000 (20:48 +0000)]
Don't reference pthread.h unless we have threads enabled, per Peter.

21 years agoUpdate for osX 10.3.
Bruce Momjian [Fri, 24 Oct 2003 20:44:19 +0000 (20:44 +0000)]
Update for osX 10.3.

21 years agoUpdate ports for freebsd, cygwin.
Bruce Momjian [Fri, 24 Oct 2003 20:39:09 +0000 (20:39 +0000)]
Update ports for freebsd, cygwin.

21 years agoUse AROPT, not hard-coded flags.
Peter Eisentraut [Fri, 24 Oct 2003 20:31:43 +0000 (20:31 +0000)]
Use AROPT, not hard-coded flags.

21 years agoUpdate Linux/Sparc 32-bit port.
Bruce Momjian [Fri, 24 Oct 2003 16:30:53 +0000 (16:30 +0000)]
Update Linux/Sparc 32-bit port.

21 years agoUpdate Linux x86 port.
Bruce Momjian [Fri, 24 Oct 2003 16:29:00 +0000 (16:29 +0000)]
Update Linux x86 port.

21 years agoUpdate OSX port.
Bruce Momjian [Fri, 24 Oct 2003 15:56:29 +0000 (15:56 +0000)]
Update OSX port.

21 years agoMark BSD/OS as working in 7.4.
Bruce Momjian [Fri, 24 Oct 2003 15:31:29 +0000 (15:31 +0000)]
Mark BSD/OS as working in 7.4.

21 years agoMove pre-7.3 platforms to unsupported.
Bruce Momjian [Fri, 24 Oct 2003 15:30:52 +0000 (15:30 +0000)]
Move pre-7.3 platforms to unsupported.

21 years agoTranslation updates
Peter Eisentraut [Fri, 24 Oct 2003 12:07:56 +0000 (12:07 +0000)]
Translation updates

21 years agoMove 2phase discussion to 7.5 queue, not TODO.detail.
Bruce Momjian [Fri, 24 Oct 2003 03:24:56 +0000 (03:24 +0000)]
Move 2phase discussion to 7.5 queue, not TODO.detail.

21 years agoMove 2phase discussion to 7.5 queue, not TODO.detail.
Bruce Momjian [Fri, 24 Oct 2003 03:24:32 +0000 (03:24 +0000)]
Move 2phase discussion to 7.5 queue, not TODO.detail.

<  o Queries across databases or servers (two-phase commit) [2phase]
>  o Queries across databases or servers (two-phase commit)

21 years agoAdd 2-phase TODO.detail.
Bruce Momjian [Fri, 24 Oct 2003 03:21:37 +0000 (03:21 +0000)]
Add 2-phase TODO.detail.

21 years agoAdd TODO.detail:
Bruce Momjian [Fri, 24 Oct 2003 03:20:36 +0000 (03:20 +0000)]
Add TODO.detail:

>  o Queries across databases or servers (two-phase commit) [2phase]

21 years agoUpdate INSTALL to say beta5.
Bruce Momjian [Thu, 23 Oct 2003 16:40:14 +0000 (16:40 +0000)]
Update INSTALL to say beta5.

21 years agoRemove obsolete information about altering default optimization flags for
Tom Lane [Thu, 23 Oct 2003 13:58:43 +0000 (13:58 +0000)]
Remove obsolete information about altering default optimization flags for
gcc.  Per comment from original author, Brian Gallew:
"Ancient history.  Kill it fast."

21 years agoMove docs about index cost estimation functions and writing a procedural
Tom Lane [Wed, 22 Oct 2003 22:28:10 +0000 (22:28 +0000)]
Move docs about index cost estimation functions and writing a procedural
language handler to the 'Internals' area, per my proposal of yesterday.
Clean up the trigger documentation a bit.  Push SPI chapter to the end
of its part, and reorder the Internals chapters into what seems a more
sensible order (at the moment anyway).

21 years agoHere is a documentation patch that makes zulu, etc. all more consistent.
Bruce Momjian [Wed, 22 Oct 2003 18:10:53 +0000 (18:10 +0000)]
Here is a documentation patch that makes zulu, etc. all more consistent.

21 years agoRelease notes updates from Neil Conway.
Bruce Momjian [Wed, 22 Oct 2003 17:27:14 +0000 (17:27 +0000)]
Release notes updates from Neil Conway.

21 years agoAdd:
Bruce Momjian [Wed, 22 Oct 2003 17:14:39 +0000 (17:14 +0000)]
Add:

> * Allow functions to have a search path specified at creation time

21 years agoAdd missing semicolon, per Johann Uhrmann.
Tom Lane [Wed, 22 Oct 2003 16:43:42 +0000 (16:43 +0000)]
Add missing semicolon, per Johann Uhrmann.
Avoids warnings from newer bisons.

21 years agoAdd mention that "today" doesn't work as column default anymore.
Bruce Momjian [Wed, 22 Oct 2003 05:09:12 +0000 (05:09 +0000)]
Add mention that "today" doesn't work as column default anymore.

21 years agoup configure to beta5 REL7_4_BETA5
PostgreSQL Daemon [Wed, 22 Oct 2003 04:16:39 +0000 (04:16 +0000)]
up configure to beta5

21 years agoAnother example-to-documentation difference. Maybe we can find a
Tom Lane [Wed, 22 Oct 2003 03:50:27 +0000 (03:50 +0000)]
Another example-to-documentation difference.  Maybe we can find a
better way to keep these in sync...

21 years agoOoops, missed updating this part of the complex-datatype example.
Tom Lane [Tue, 21 Oct 2003 23:28:42 +0000 (23:28 +0000)]
Ooops, missed updating this part of the complex-datatype example.

21 years agoUpdate the complex-datatype example to V1 function calling conventions,
Tom Lane [Tue, 21 Oct 2003 22:51:14 +0000 (22:51 +0000)]
Update the complex-datatype example to V1 function calling conventions,
and add binary send/receive functions.  Fix some other grottiness such
as failure to mark the C functions STRICT.

21 years agoFor some reason, the preface mentions just six of the seven major parts
Tom Lane [Tue, 21 Oct 2003 22:47:54 +0000 (22:47 +0000)]
For some reason, the preface mentions just six of the seven major parts
of the book.  Fix it.

21 years agoFix built-in SQL-language functions to ensure that referenced names
Tom Lane [Tue, 21 Oct 2003 16:23:16 +0000 (16:23 +0000)]
Fix built-in SQL-language functions to ensure that referenced names
are properly schema-qualified.

Christopher Kings-Lynne

21 years agoRemove:
Bruce Momjian [Tue, 21 Oct 2003 15:51:41 +0000 (15:51 +0000)]
Remove:

<  o Allow BINARY option to SELECT, just like DECLARE

21 years agoUpdate:
Bruce Momjian [Tue, 21 Oct 2003 15:48:56 +0000 (15:48 +0000)]
Update:

< * Allow INET subnet tests to use indexes
> * Allow INET subnet tests using non-constants to be indexed

21 years agoCope with platforms that offer LONGLONG_MIN in place of the C99-spec
Tom Lane [Tue, 21 Oct 2003 15:34:34 +0000 (15:34 +0000)]
Cope with platforms that offer LONGLONG_MIN in place of the C99-spec
LLONG_MIN.  One example is AIX, per report from Andreas.

21 years agoRevert to 7.3-and-before practice of only including <fcntl.h> in c.h
Tom Lane [Tue, 21 Oct 2003 15:32:58 +0000 (15:32 +0000)]
Revert to 7.3-and-before practice of only including <fcntl.h> in c.h
on Windows; per complaint from Andreas that it breaks AIX build.

21 years agoFix findLastBuiltinOid_V70() to deliver correct result when running
Tom Lane [Tue, 21 Oct 2003 04:46:28 +0000 (04:46 +0000)]
Fix findLastBuiltinOid_V70() to deliver correct result when running
against a 7.0 server.

Christopher Kings-Lynne

21 years agoUpdate per Tom:
Bruce Momjian [Tue, 21 Oct 2003 02:48:09 +0000 (02:48 +0000)]
Update per Tom:

< * Allow INET subnet tests using non-constants
> * Allow INET subnet tests to use indexes
101a102
>  o Allow MIN()/MAX() on arrays
144c145
< * Allow CREATE INDEX zman_index ON test (date_trunc( 'day', zman ) datetime_ops)
> * -Allow CREATE INDEX zman_index ON test (date_trunc( 'day', zman ) datetime_ops)
166c167
< * Improve handling of index scans for NULL
> * Allow use of indexes to search for NULLs
203a205
> * Add optional textual message to NOTIFY
252c254
<  o Add SET SCHEMA
>  o Add SET PATH for schemas
297a300
> * Allow fastpast to pass values in portable format
344a348
> * Allow statement-level triggers to access modified rows
526d529
<  o Add optional textual message to NOTIFY
530d532
<  o Allow fastpast to pass values in portable format
533c535
<  o Special passing of binary values in platform-neutral format (bytea?)
>  o -Special passing of binary values in platform-neutral format (bytea?)

21 years agoAdd release info about dollar signs to migration section:
Bruce Momjian [Tue, 21 Oct 2003 01:25:31 +0000 (01:25 +0000)]
Add release info about dollar signs to migration section:

     <listitem><para> Dollar sign (<literal>$</>) is no longer allowed
in operator names</para></listitem>
     <listitem><para> Dollar sign (<literal>$</>) can be a non-first
character in identifiers</para></listitem>

21 years agoUpdate catalog version after information schema changes.
Peter Eisentraut [Mon, 20 Oct 2003 21:39:37 +0000 (21:39 +0000)]
Update catalog version after information schema changes.

21 years agoComplain if pg_restore is given both -d and -f options; this suggests
Tom Lane [Mon, 20 Oct 2003 21:05:12 +0000 (21:05 +0000)]
Complain if pg_restore is given both -d and -f options; this suggests
the user is confused about whether -f is input or output file.

21 years agoIt is possible for ResolveNew to be used to insert a sublink into a
Tom Lane [Mon, 20 Oct 2003 20:01:59 +0000 (20:01 +0000)]
It is possible for ResolveNew to be used to insert a sublink into a
subquery that didn't previously have one.  We have traditionally made
the caller of ResolveNew responsible for updating the hasSubLinks flag
of the outermost query, but this fails to account for hasSubLinks in
subqueries.  Fix ResolveNew to handle this.  We might later want to
change the calling convention of ResolveNew so that it can fix the
outer query too, simplifying callers.  But I went with the localized
fix for now.  Per bug report from J Smith, 20-Oct-03.

21 years agoImprove error reporting in parseTypeString(), motivated by confusing
Tom Lane [Mon, 20 Oct 2003 17:25:42 +0000 (17:25 +0000)]
Improve error reporting in parseTypeString(), motivated by confusing
behavior reported by Martin Marques.

21 years agoInstall dummy sqlda.h file since this is needed for compatibility.
Michael Meskes [Mon, 20 Oct 2003 12:54:29 +0000 (12:54 +0000)]
Install dummy sqlda.h file since this is needed for compatibility.

21 years agoWhen building shared libraries on HPUX with gcc, forcibly include -lgcc
Tom Lane [Mon, 20 Oct 2003 01:34:33 +0000 (01:34 +0000)]
When building shared libraries on HPUX with gcc, forcibly include -lgcc
to ensure any needed compiler support routines are included.  This is
arguably appropriate on *every* gcc platform, but for the moment I'll take
the conservative approach of only doing it on a platform where it's
provably useful.  Per complaint from Heiko Lehmann, 13-Feb-03, as well
as personal experience --- contrib/pgstattuple has never worked for me,
but it does now.

21 years agoSave_r, Save_t should be static not global variables.
Tom Lane [Sun, 19 Oct 2003 23:43:51 +0000 (23:43 +0000)]
Save_r, Save_t should be static not global variables.