]> granicus.if.org Git - postgresql/log
postgresql
20 years agoadded polish translation submitted by Piotr Maj
Dave Cramer [Wed, 17 Dec 2003 13:25:14 +0000 (13:25 +0000)]
added polish translation submitted by Piotr Maj

20 years agoRestore information schema upgrade instructions of Peter.
Bruce Momjian [Wed, 17 Dec 2003 07:07:00 +0000 (07:07 +0000)]
Restore information schema upgrade instructions of Peter.

20 years agoAdd example for converting epoch back to timestamp.
Peter Eisentraut [Tue, 16 Dec 2003 15:27:58 +0000 (15:27 +0000)]
Add example for converting epoch back to timestamp.

20 years agoFix constraint_column_usage for foreign keys.
Peter Eisentraut [Tue, 16 Dec 2003 14:57:20 +0000 (14:57 +0000)]
Fix constraint_column_usage for foreign keys.

20 years agoRepair name.
Peter Eisentraut [Tue, 16 Dec 2003 09:47:55 +0000 (09:47 +0000)]
Repair name.

20 years agoAdd mention of non-standard extension:
Bruce Momjian [Tue, 16 Dec 2003 01:35:40 +0000 (01:35 +0000)]
Add mention of non-standard extension:

<  o Make SET CONNECTION thread-aware
>  o Make SET CONNECTION thread-aware, non-standard?

20 years agoAdd for ecpg:
Bruce Momjian [Tue, 16 Dec 2003 01:08:40 +0000 (01:08 +0000)]
Add for ecpg:

>  o Make SET CONNECTION thread-aware

20 years agoMention ecpg SET CONNECTION is not thread-aware.
Bruce Momjian [Tue, 16 Dec 2003 01:06:39 +0000 (01:06 +0000)]
Mention ecpg SET CONNECTION is not thread-aware.

20 years agoOverride some of the changes in DocBook DSSSL stylesheets 1.78 to restore
Peter Eisentraut [Mon, 15 Dec 2003 23:58:12 +0000 (23:58 +0000)]
Override some of the changes in DocBook DSSSL stylesheets 1.78 to restore
previous behavior of <literal>, <envar>, <acronym>, and others.

20 years agoAdd mention with might need to use cp -R someday for portability.
Bruce Momjian [Mon, 15 Dec 2003 22:56:44 +0000 (22:56 +0000)]
Add mention with might need to use cp -R someday for portability.

20 years agoUpdate HISTORY and release notes for 7.4.1.
Bruce Momjian [Mon, 15 Dec 2003 22:24:59 +0000 (22:24 +0000)]
Update HISTORY and release notes for 7.4.1.

20 years agoFix two typos in the documentation for PREPARE.
Neil Conway [Sun, 14 Dec 2003 00:55:46 +0000 (00:55 +0000)]
Fix two typos in the documentation for PREPARE.

20 years agoI posted some bufmgr cleanup a few weeks ago, but it conflicted with
Neil Conway [Sun, 14 Dec 2003 00:34:47 +0000 (00:34 +0000)]
I posted some bufmgr cleanup a few weeks ago, but it conflicted with
some concurrent changes Jan was making to the bufmgr. Here's an
updated version of the patch -- it should apply cleanly to CVS
HEAD and passes the regression tests.

This patch makes the following changes:

     - remove the UnlockAndReleaseBuffer() and UnlockAndWriteBuffer()
       macros, and replace uses of them with calls to the appropriate
       functions.

     - remove a bunch of #ifdef BMTRACE code: it is ugly & broken
       (i.e. it doesn't compile)

     - make BufferReplace() return a bool, not an int

     - cleanup some logic in bufmgr.c; should be functionality
       equivalent to the previous code, just cleaner now

     - remove the BM_PRIVATE flag as it is unused

     - improve a few comments, etc.

20 years agoThis patch fixes a few more uppercase GUC vars. I also removed an
Neil Conway [Sun, 14 Dec 2003 00:15:03 +0000 (00:15 +0000)]
This patch fixes a few more uppercase GUC vars. I also removed an
example from the RESET reference page because it seemed completely
redundant.

20 years agoThis patch makes some improvements and adds some additional detail
Neil Conway [Sun, 14 Dec 2003 00:10:32 +0000 (00:10 +0000)]
This patch makes some improvements and adds some additional detail
to the documentation on routine database maintainence activities.
I also corrected a bunch of SGML markup.

20 years agoThis patch makes some SGML markup more consistent and makes a small
Neil Conway [Sun, 14 Dec 2003 00:05:29 +0000 (00:05 +0000)]
This patch makes some SGML markup more consistent and makes a small
improvement to the SSL auth docs.

20 years agoThis patch makes some SGML markup more consistent and makes a small
Neil Conway [Sat, 13 Dec 2003 23:59:07 +0000 (23:59 +0000)]
This patch makes some SGML markup more consistent and makes a small
improvement to the SSL auth docs.

20 years agoAdd /usr/local/sgml/docbook-dsssl to the default search patch for
Bruce Momjian [Sat, 13 Dec 2003 20:25:18 +0000 (20:25 +0000)]
Add /usr/local/sgml/docbook-dsssl to the default search patch for
docbook style sheets, as discussed with Peter.

20 years agoSGML doc build instructions --- no more DTDDECL, fix double dash in path name.
Bruce Momjian [Sat, 13 Dec 2003 20:09:15 +0000 (20:09 +0000)]
SGML doc build instructions --- no more DTDDECL, fix double dash in path name.

20 years agoAdd fadvise TODO.detail.
Bruce Momjian [Sat, 13 Dec 2003 20:02:16 +0000 (20:02 +0000)]
Add fadvise TODO.detail.

20 years agoUpdate TODO.detail syntax:
Bruce Momjian [Sat, 13 Dec 2003 20:02:01 +0000 (20:02 +0000)]
Update TODO.detail syntax:

< * Add free-behind capability for large sequential scans (fadvise)
> * Add free-behind capability for large sequential scans [fadvise]

20 years agoAdd Czech language FAQ's
Bruce Momjian [Sat, 13 Dec 2003 16:56:00 +0000 (16:56 +0000)]
Add Czech language FAQ's

Pavel Stehule

20 years agoThis patch properly sets the prototype for the on_shmem_exit and
Peter Eisentraut [Fri, 12 Dec 2003 18:45:10 +0000 (18:45 +0000)]
This patch properly sets the prototype for the on_shmem_exit and
on_proc_exit functions, and adjust all other related code to use
the proper types too.

by Kurt Roeckx

20 years agoadd missing SQLState by Patrick Higgins
Dave Cramer [Fri, 12 Dec 2003 18:36:20 +0000 (18:36 +0000)]
add missing SQLState by Patrick Higgins

20 years agocancel row updates sets values to null by Kris Jurka
Dave Cramer [Fri, 12 Dec 2003 18:34:14 +0000 (18:34 +0000)]
cancel row updates sets values to null by Kris Jurka

20 years agopatch to indicate why test cases failed from Oliver Jowett
Dave Cramer [Fri, 12 Dec 2003 18:30:27 +0000 (18:30 +0000)]
patch to indicate why test cases failed from Oliver Jowett

20 years agopatch to fix returning he information schema as a system object by Kris Jurka
Dave Cramer [Fri, 12 Dec 2003 18:27:51 +0000 (18:27 +0000)]
patch to fix returning he information schema as a system object by Kris Jurka

20 years agofix casting pooled connections to PGStatement problem patch by JariP
Dave Cramer [Fri, 12 Dec 2003 18:05:34 +0000 (18:05 +0000)]
fix casting pooled connections to PGStatement problem patch by JariP

20 years agopatch to build under jdk1.1 from Richard Scranton
Dave Cramer [Fri, 12 Dec 2003 17:58:34 +0000 (17:58 +0000)]
patch to build under jdk1.1 from Richard Scranton

20 years agobinary stream patch by Kris Jurka fixes empty stream failure
Dave Cramer [Fri, 12 Dec 2003 00:26:20 +0000 (00:26 +0000)]
binary stream patch by Kris Jurka fixes empty stream failure

20 years agometadata encoding patch from Kris Jurka
Dave Cramer [Fri, 12 Dec 2003 00:21:36 +0000 (00:21 +0000)]
metadata encoding patch from Kris Jurka

20 years agoFix for vpath build
Peter Eisentraut [Thu, 11 Dec 2003 22:10:51 +0000 (22:10 +0000)]
Fix for vpath build

20 years agoNew translation
Peter Eisentraut [Thu, 11 Dec 2003 22:03:05 +0000 (22:03 +0000)]
New translation

20 years agoFix thinko in comment.
Tom Lane [Thu, 11 Dec 2003 21:21:55 +0000 (21:21 +0000)]
Fix thinko in comment.

20 years agoMake some wording consistent with DROP OPERATOR description.
Peter Eisentraut [Thu, 11 Dec 2003 20:13:53 +0000 (20:13 +0000)]
Make some wording consistent with DROP OPERATOR description.

20 years agoFix instructions how to shut down postmaster.
Peter Eisentraut [Thu, 11 Dec 2003 19:56:54 +0000 (19:56 +0000)]
Fix instructions how to shut down postmaster.

20 years agobuild number set to 300 to avoid conflict with 7.4 builds
Dave Cramer [Thu, 11 Dec 2003 18:10:40 +0000 (18:10 +0000)]
build number set to 300 to avoid conflict with 7.4 builds
threadsafe patch from Karl von Randow applied

20 years agopatch to deal with unique foreign keys in 7.4 from Kris Jurka
Dave Cramer [Thu, 11 Dec 2003 15:50:20 +0000 (15:50 +0000)]
patch to deal with unique foreign keys in 7.4 from Kris Jurka

20 years agotch to make sure PSQLState is Serializable and a test case to prove it
Dave Cramer [Thu, 11 Dec 2003 15:13:34 +0000 (15:13 +0000)]
tch to make sure PSQLState is Serializable and a test case to prove it

20 years agopatch to make sure PSQLState is Serializable and a test case to prove it
Dave Cramer [Thu, 11 Dec 2003 15:11:43 +0000 (15:11 +0000)]
patch to make sure PSQLState is Serializable and a test case to prove it

20 years agoincremented build to 211
Dave Cramer [Wed, 10 Dec 2003 18:30:44 +0000 (18:30 +0000)]
incremented build to 211

20 years agoFix integer types to use definition from c.h. Per bug report by Patrick Boulay <patri...
Teodor Sigaev [Wed, 10 Dec 2003 15:54:58 +0000 (15:54 +0000)]
Fix integer types to use definition from c.h. Per bug report by Patrick Boulay <patrick.boulay@medrium.com>

20 years agoquery_tree_mutator should copy RangeTblEntry nodes even when it's not
Tom Lane [Tue, 9 Dec 2003 01:56:20 +0000 (01:56 +0000)]
query_tree_mutator should copy RangeTblEntry nodes even when it's not
planning to modify them itself.  Otherwise we end up with shared RTE
substructure, which breaks inheritance_planner because the rte->inh
flag needs to be independent in each copied subquery.  Per bug report
from Chris Piker.

20 years agoMinor autovacuum fixes from Matthew O'Connor.
Tom Lane [Mon, 8 Dec 2003 21:54:00 +0000 (21:54 +0000)]
Minor autovacuum fixes from Matthew O'Connor.

20 years agoAdd fflush() before sleeping, per Matthew O'Connor.
Tom Lane [Mon, 8 Dec 2003 21:51:31 +0000 (21:51 +0000)]
Add fflush() before sleeping, per Matthew O'Connor.

20 years agoWhole-row references were broken for subqueries and functions, because
Tom Lane [Mon, 8 Dec 2003 18:19:58 +0000 (18:19 +0000)]
Whole-row references were broken for subqueries and functions, because
attr_needed/attr_widths optimization failed to allow for Vars with attno
zero in this case.  Per report from Tatsuo Ishii.

20 years agoWork around naming conflict between zlib and OpenSSL by tweaking inclusion
Tom Lane [Mon, 8 Dec 2003 16:39:05 +0000 (16:39 +0000)]
Work around naming conflict between zlib and OpenSSL by tweaking inclusion
order.  Remove some unnecessary #includes (that duplicate c.h).

20 years agoDone:
Bruce Momjian [Mon, 8 Dec 2003 13:04:14 +0000 (13:04 +0000)]
Done:

< * COMMENT ON [ CAST | CONVERSION | OPERATOR CLASS | LARGE OBJECT | LANGUAGE ]
> * -COMMENT ON [ CAST | CONVERSION | OPERATOR CLASS | LARGE OBJECT | LANGUAGE ]
263c263
< * Allow pg_dump to dump CREATE CONVERSION (Christopher)
> * -Allow pg_dump to dump CREATE CONVERSION (Christopher)

20 years agoReplace unportable and overflow-prone use of 'long long' with safer
Tom Lane [Sun, 7 Dec 2003 19:55:58 +0000 (19:55 +0000)]
Replace unportable and overflow-prone use of 'long long' with safer
'double' arithmetic, per recent discussion.

20 years agoRemove test on c.relkind from check_constraints view; unnecessary and
Tom Lane [Sun, 7 Dec 2003 19:43:02 +0000 (19:43 +0000)]
Remove test on c.relkind from check_constraints view; unnecessary and
prevents view from showing constraints on domains.  This addresses the
other half of Claus Colloseus' bug report.

20 years agoFix typmod interpretation for bit types. (It was erroneously assumed that
Peter Eisentraut [Sun, 7 Dec 2003 10:21:58 +0000 (10:21 +0000)]
Fix typmod interpretation for bit types.  (It was erroneously assumed that
for bit(x), the typmod stores x+4, like for the character types.)

20 years agoOne more pass at reducing the cost of pg_dump's new implementation:
Tom Lane [Sun, 7 Dec 2003 05:44:50 +0000 (05:44 +0000)]
One more pass at reducing the cost of pg_dump's new implementation:
reduce the number of times TopoSort() has to be executed by trying to
extract multiple dependency loops from each pass, instead of only one.
This saves about another factor of ten on the regression database.
This could be considered as another exercise in grokking Fred Brooks'
maxim: Representation *is* the essence of programming.

20 years agoRepair indexed bytea like operations, and related selectivity
Joe Conway [Sun, 7 Dec 2003 04:14:10 +0000 (04:14 +0000)]
Repair indexed bytea like operations, and related selectivity
functionality. Per bug report by Alvar Freude:
http://archives.postgresql.org/pgsql-bugs/2003-12/msg00022.php

20 years agoSpeed up findObjectByCatalogId() to get rid of the other salient
Tom Lane [Sun, 7 Dec 2003 03:14:01 +0000 (03:14 +0000)]
Speed up findObjectByCatalogId() to get rid of the other salient
bottleneck in the new pg_dump code.

20 years agoDone:
Bruce Momjian [Sun, 7 Dec 2003 00:54:05 +0000 (00:54 +0000)]
Done:
> * -Use dependency information to dump data in proper order

20 years agoDocumentation update for previously committed changes: read-only GUC variables
Joe Conway [Sat, 6 Dec 2003 23:10:23 +0000 (23:10 +0000)]
Documentation update for previously committed changes: read-only GUC variables
and pg_settings view.

20 years agoReplace not-very-bright implementation of topological sort with a better
Tom Lane [Sat, 6 Dec 2003 22:55:11 +0000 (22:55 +0000)]
Replace not-very-bright implementation of topological sort with a better
one (use a priority heap to keep track of items ready to output, instead
of searching the input array each time).  This brings the runtime of
pg_dump back to about what it was in 7.4.

20 years agoMassive overhaul of pg_dump: make use of dependency information from
Tom Lane [Sat, 6 Dec 2003 03:00:16 +0000 (03:00 +0000)]
Massive overhaul of pg_dump: make use of dependency information from
pg_depend to determine a safe dump order.  Defaults and check constraints
can be emitted either as part of a table or domain definition, or
separately if that's needed to break a dependency loop.  Lots of old
half-baked code for controlling dump order removed.

20 years agoGuard against bug in Solaris' bsearch(), per Michael Wildpaner.
Tom Lane [Fri, 5 Dec 2003 15:50:31 +0000 (15:50 +0000)]
Guard against bug in Solaris' bsearch(), per Michael Wildpaner.

20 years agoOne more fix confusion
Teodor Sigaev [Fri, 5 Dec 2003 15:37:51 +0000 (15:37 +0000)]
One more fix confusion

20 years agoAvoid confusion start_parse_str function with tsearch V1
Teodor Sigaev [Fri, 5 Dec 2003 14:27:42 +0000 (14:27 +0000)]
Avoid confusion start_parse_str function with tsearch V1

20 years agoMarkup improvements
Peter Eisentraut [Thu, 4 Dec 2003 21:24:56 +0000 (21:24 +0000)]
Markup improvements

20 years agoAvoid conflict strndup with glibc
Teodor Sigaev [Thu, 4 Dec 2003 12:21:11 +0000 (12:21 +0000)]
Avoid conflict strndup with glibc

20 years agocatversion change needed by previous read-onlu GUC variables commit.
Joe Conway [Wed, 3 Dec 2003 18:53:52 +0000 (18:53 +0000)]
catversion change needed by previous read-onlu GUC variables commit.

20 years agoAdded new group of read-only GUC variables to allow simple access
Joe Conway [Wed, 3 Dec 2003 18:52:00 +0000 (18:52 +0000)]
Added new group of read-only GUC variables to allow simple access
to certain compile-time options (FUNC_MAX_ARGS, INDEX_MAX_KEYS,
NAMEDATALEN, BLCKSZ, HAVE_INT64_TIMESTAMP). Also added "category",
"short_desc", and "extra_desc" to the pg_settings view. Per recent
discussion here:
http://archives.postgresql.org/pgsql-patches/2003-11/msg00363.php

20 years agoPlanner failed to be smart about binary-compatible expressions in pathkeys
Tom Lane [Wed, 3 Dec 2003 17:45:10 +0000 (17:45 +0000)]
Planner failed to be smart about binary-compatible expressions in pathkeys
and hash bucket-size estimation.  Issue has been there awhile but is more
critical in 7.4 because it affects varchar columns.  Per report from
Greg Stark.

20 years agoFix for word with several infinitives
Teodor Sigaev [Wed, 3 Dec 2003 16:07:48 +0000 (16:07 +0000)]
Fix for word with several infinitives

20 years agoAdded patch by Dave Cramer for array handling in ecpglib.
Michael Meskes [Wed, 3 Dec 2003 08:49:17 +0000 (08:49 +0000)]
Added patch by Dave Cramer for array handling in ecpglib.

20 years agoAdd a warning to AtEOXact_SPI() to catch cases where the current
Joe Conway [Tue, 2 Dec 2003 19:26:47 +0000 (19:26 +0000)]
Add a warning to AtEOXact_SPI() to catch cases where the current
transaction has been committed without SPI_finish() being called
first. Per recent discussion here:
http://archives.postgresql.org/pgsql-patches/2003-11/msg00286.php

20 years agoUpdate release notes for 7.3.5.
Tom Lane [Tue, 2 Dec 2003 16:14:12 +0000 (16:14 +0000)]
Update release notes for 7.3.5.

20 years agoFix some small errors.
Peter Eisentraut [Tue, 2 Dec 2003 10:24:37 +0000 (10:24 +0000)]
Fix some small errors.

20 years agoCode and docs review for numeric-factorial patch.
Tom Lane [Tue, 2 Dec 2003 00:26:59 +0000 (00:26 +0000)]
Code and docs review for numeric-factorial patch.

20 years agoI've run across a pretty serious problem with pg_autovacuum.
Bruce Momjian [Mon, 1 Dec 2003 23:19:33 +0000 (23:19 +0000)]
I've run across a pretty serious problem with pg_autovacuum.
pg_autovacuum looses track of any table that's ever been truncated
(possibly other situations too).   When i truncate a table it gets a
new relfilenode in pg_class.  This is a problem because pg_autovacuum
assumes pg_class.relfilenode will join to pg_stats_all_tables.relid.
pg_stats_all_tables.relid is actallly the oid from pg_class, not the
relfilenode.   These two values start out equal so pg_autovacuum works
initially, but it fails later on because of this incorrect assumption.

This patch fixes that problem.  Applied to HEAD and 7.4.X.

Brian Hirt

20 years agoFix initdb use of mkdir_p().
Bruce Momjian [Mon, 1 Dec 2003 23:15:47 +0000 (23:15 +0000)]
Fix initdb use of mkdir_p().

Andrew Dunstan

20 years agoI noticed in the 7.4 release that in contrib/pg_autovacuum, args->logfile is
Bruce Momjian [Mon, 1 Dec 2003 23:13:07 +0000 (23:13 +0000)]
I noticed in the 7.4 release that in contrib/pg_autovacuum, args->logfile is
not initialized if a log file is not specified on the command line.  This
causes an immediate segfault on systems that fill allocated memory with some
value other than zero (my FreeBSD machine uses 0xD0).

Several crashes later I discovered that args->user, password, host, and port
are also used without being initialized.

This doesn't appear to be fixed in CVS and I came up empty on a mailing list
search -- hope it hasn't been reported already.

Craig Boston

20 years agoThe attached patch enables contrib/cube to build cleanly under Cygwin
Bruce Momjian [Mon, 1 Dec 2003 23:12:16 +0000 (23:12 +0000)]
The attached patch enables contrib/cube to build cleanly under Cygwin
(again).  Please consider this patch for the 7.4.1 branch (if there will
be one) too.

 Jason Tishler

20 years agoThis patch refactors execTuples.c in two ways.
Bruce Momjian [Mon, 1 Dec 2003 23:09:02 +0000 (23:09 +0000)]
This patch refactors execTuples.c in two ways.

Neil Conway

20 years agoHi, this doco patch is a quick one to add explicit mention of the need
Bruce Momjian [Mon, 1 Dec 2003 22:36:40 +0000 (22:36 +0000)]
Hi, this doco patch is a quick one to add explicit mention of the need
for the AT clause in threaded ECPG applications.

Philip Yarra

20 years agoThis makes help like this:
Bruce Momjian [Mon, 1 Dec 2003 22:34:48 +0000 (22:34 +0000)]
This makes help like this:

   \lo_export LOBOID FILE
   \lo_import FILE [COMMENT]
   \lo_list
   \lo_unlink LOBOID    large object operations

Instead of not saying anything about what arguments are required.

Christopher Kings-Lynne

20 years agoWin32 patch for Makefile.shlib
Bruce Momjian [Mon, 1 Dec 2003 22:23:06 +0000 (22:23 +0000)]
Win32 patch for Makefile.shlib

Claudio Natoli

20 years agoUpdate for patches applied:
Bruce Momjian [Mon, 1 Dec 2003 22:22:44 +0000 (22:22 +0000)]
Update for patches applied:

< * Change factorial to return a numeric
> * -Change factorial to return a numeric (Gavin)
258c258
< * Allow psql \du to show groups, and add \dg for groups
> * -Allow psql \du to show groups, and add \dg for groups

20 years agoattached is a patch that adds display of the groups a user belongs to to
Bruce Momjian [Mon, 1 Dec 2003 22:21:54 +0000 (22:21 +0000)]
attached is a patch that adds display of the groups a user belongs to to
\du and a \dg command to psql. It's against 7.4beta5.

Markus Bertheau <twanger@bluetwanger.de>

20 years agoAvoid assuming that type key_t is 32 bits, since it reportedly isn't
Tom Lane [Mon, 1 Dec 2003 22:15:38 +0000 (22:15 +0000)]
Avoid assuming that type key_t is 32 bits, since it reportedly isn't
on 64-bit Solaris.  Use a non-system-dependent datatype for UsedShmemSegID,
namely unsigned long (which we were already assuming could hold a shmem
key anyway, cf RecordSharedMemoryInLockFile).

20 years agoThis patch reduces some unsightly #ifdefs, and fixes two typos in
Bruce Momjian [Mon, 1 Dec 2003 22:14:40 +0000 (22:14 +0000)]
This patch reduces some unsightly #ifdefs, and fixes two typos in
comments in the psql code. This doesn't make any functional change, so
feel free to save it for 7.5

Neil Conway

20 years agoThis patch finishes off the work that I did with making view
Bruce Momjian [Mon, 1 Dec 2003 22:11:06 +0000 (22:11 +0000)]
This patch finishes off the work that I did with making view
definitions use pretty printing.

It does:

* Pretty index predicates
* Pretty rule definitions
* Uppercases PRIMARY KEY and UNIQUE to be consistent with CHECK and
FOREIGN KEY
* View rules are improved to match table rules:

Christopher Kings-Lynne

20 years agoThis patch adds a new GUC var, "default_with_oids", which follows the
Bruce Momjian [Mon, 1 Dec 2003 22:08:02 +0000 (22:08 +0000)]
This patch adds a new GUC var, "default_with_oids", which follows the
proposal for eventually deprecating OIDs on user tables that I posted
earlier to pgsql-hackers. pg_dump now always specifies WITH OIDS or
WITHOUT OIDS when dumping a table. The documentation has been updated.

Neil Conway

20 years agoTry to reduce confusion about what is a lock method identifier, a lock
Bruce Momjian [Mon, 1 Dec 2003 21:59:25 +0000 (21:59 +0000)]
Try to reduce confusion about what is a lock method identifier, a lock
method control structure, or a table of control structures.

. Use type LOCKMASK where an int is not a counter.

. Get rid of INVALID_TABLEID, use INVALID_LOCKMETHOD instead.

. Use INVALID_LOCKMETHOD instead of (LOCKMETHOD) NULL, because
  LOCKMETHOD is not a pointer.

. Define and use macro LockMethodIsValid.

. Rename LOCKMETHOD to LOCKMETHODID.

. Remove global variable LongTermTableId in lmgr.c, because it is
  never used.

. Make LockTableId static in lmgr.c, because it is used nowhere else.
  Why not remove it and use DEFAULT_LOCKMETHOD?

. Rename the lock method control structure from LOCKMETHODTABLE to
  LockMethodData.  Introduce a pointer type named LockMethod.

. Remove elog(FATAL) after InitLockTable() call in
  CreateSharedMemoryAndSemaphores(), because if something goes wrong,
  there is elog(FATAL) in LockMethodTableInit(), and if this doesn't
  help, an elog(ERROR) in InitLockTable() is promoted to FATAL.

. Make InitLockTable() void, because its only caller does not use its
  return value any more.

. Rename variables in lock.c to avoid statements like
        LockMethodTable[NumLockMethods] = lockMethodTable;
        lockMethodTable = LockMethodTable[lockmethod];

. Change LOCKMETHODID type to uint16 to fit into struct LOCKTAG.

. Remove static variables BITS_OFF and BITS_ON from lock.c, because
  I agree to this doubt:
 * XXX is a fetch from a static array really faster than a shift?

. Define and use macros LOCKBIT_ON/OFF.

Manfred Koizar

20 years agoRemove mention of factorial as casting example. New example needed.
Bruce Momjian [Mon, 1 Dec 2003 21:53:15 +0000 (21:53 +0000)]
Remove mention of factorial as casting example.  New example needed.

20 years agoAttached is a patch implementing factorial(), returning numeric. Points
Bruce Momjian [Mon, 1 Dec 2003 21:52:38 +0000 (21:52 +0000)]
Attached is a patch implementing factorial(), returning numeric. Points
to note:

1) arttype is numeric. I thought this was the best way of allowing
arbitarily large factorials, even though factorial(2^63) is a large
number. Happy to change to integers if this is overkill.
2) since we're accepting numeric arguments, the patch tests for floats.
If a numeric is passed with non-zero decimal portion, an error is raised
since (from memory) they are undefined.

Gavin Sherry

20 years agoMinor wordsmithing in datetime docs to try to address gripes raised by
Tom Lane [Mon, 1 Dec 2003 20:34:53 +0000 (20:34 +0000)]
Minor wordsmithing in datetime docs to try to address gripes raised by
cnliou.

20 years agonetmask() and hostmask() functions should return maximum-length masklen,
Tom Lane [Mon, 1 Dec 2003 18:50:19 +0000 (18:50 +0000)]
netmask() and hostmask() functions should return maximum-length masklen,
per gripe from Joe Sunday.

20 years agoFix typos noted by Halley Pacheco de Oliveira.
Tom Lane [Mon, 1 Dec 2003 17:58:27 +0000 (17:58 +0000)]
Fix typos noted by Halley Pacheco de Oliveira.

20 years agoForce zero_damaged_pages to be effectively ON during recovery from WAL,
Tom Lane [Mon, 1 Dec 2003 16:53:19 +0000 (16:53 +0000)]
Force zero_damaged_pages to be effectively ON during recovery from WAL,
since there is no need to worry about damaged pages when we are going to
overwrite them anyway from the WAL.  Per recent discussion.

20 years agoSeems there are three GUC variables that are defined as "Shows ..."
Bruce Momjian [Mon, 1 Dec 2003 03:55:21 +0000 (03:55 +0000)]
Seems there are three GUC variables that are defined as "Shows ..."
while you can actually set them with SET.

This applied patch changes the wording from "Show" to "Set".

20 years agoMake PQescapeBytea and byteaout consistent with each other, and
Joe Conway [Sun, 30 Nov 2003 20:55:09 +0000 (20:55 +0000)]
Make PQescapeBytea and byteaout consistent with each other, and
octal escape all octets outside the range 0x20 to 0x7e. This fixes
the problem pointed out by Sergey Yatskevich here:
http://archives.postgresql.org/pgsql-bugs/2003-11/msg00140.php

20 years agoBump all version numbers and version stamps mentioned in RELEASE_CHANGES.
Bruce Momjian [Sun, 30 Nov 2003 06:09:54 +0000 (06:09 +0000)]
Bump all version numbers and version stamps mentioned in RELEASE_CHANGES.

20 years agoReorder win32/bcc makefile mentions of thread.c for sanity.
Bruce Momjian [Sun, 30 Nov 2003 06:01:15 +0000 (06:01 +0000)]
Reorder win32/bcc makefile mentions of thread.c for sanity.

20 years agoAdd thread.c to Borland CC build.
Bruce Momjian [Sun, 30 Nov 2003 05:54:33 +0000 (05:54 +0000)]
Add thread.c to Borland CC build.

20 years agoRemove INTO recommendation for plpgsql language.
Bruce Momjian [Sun, 30 Nov 2003 05:45:22 +0000 (05:45 +0000)]
Remove INTO recommendation for plpgsql language.

20 years agoAdd:
Bruce Momjian [Sun, 30 Nov 2003 05:29:26 +0000 (05:29 +0000)]
Add:

> * Have pg_ctl look at PGHOST in case it is a socket directory