]>
granicus.if.org Git - graphviz/log
Magnus Jacobsson [Tue, 28 Jul 2020 12:20:22 +0000 (14:20 +0200)]
Add workaround for gvpr not supporting abs path on Windows
https://gitlab.com/graphviz/graphviz/-/issues/1780
Magnus Jacobsson [Mon, 27 Jul 2020 21:07:25 +0000 (23:07 +0200)]
Add temporary skip of examples test for MSBuild builds on Windows
Fails because of https://gitlab.com/graphviz/graphviz/-/issues/1777.
Magnus Jacobsson [Mon, 27 Jul 2020 16:24:50 +0000 (18:24 +0200)]
Run tests in CI also for CMake Debug builds on Windows
Magnus Jacobsson [Mon, 27 Jul 2020 16:05:12 +0000 (18:05 +0200)]
Run all tests under rtest also for MSBuild builds on Windows
Magnus Jacobsson [Mon, 27 Jul 2020 16:04:54 +0000 (18:04 +0200)]
Run all tests under rtest also for CMake builds on Windows
Magnus Jacobsson [Mon, 27 Jul 2020 15:38:53 +0000 (17:38 +0200)]
Add temporary skip of gvpr test for CMake builds on Windows
Fails because of https://gitlab.com/graphviz/graphviz/-/issues/1753.
Magnus Jacobsson [Mon, 27 Jul 2020 15:14:34 +0000 (17:14 +0200)]
Add temporary skip of test using ksh script rtest.sh on Windows
Cannot be run until https://gitlab.com/graphviz/graphviz/-/issues/1779
is implemented.
Magnus Jacobsson [Mon, 27 Jul 2020 14:13:19 +0000 (16:13 +0200)]
Add temporary skip of installation test for MSBuild builds on Windows
Fails because of https://gitlab.com/graphviz/graphviz/-/issues/1745.
Magnus Jacobsson [Mon, 27 Jul 2020 10:46:52 +0000 (12:46 +0200)]
Make test_installation.py self-contained to run also on Windows
Also removed the now obsolete check_installation.sh bash script.
Magnus Jacobsson [Sun, 26 Jul 2020 22:20:23 +0000 (00:20 +0200)]
Run all tests under tests in CI also for CMake builds in Windows
Magnus Jacobsson [Sun, 26 Jul 2020 22:19:39 +0000 (00:19 +0200)]
Run all tests under tests in CI for MSBuild builds on Windows
Magnus Jacobsson [Thu, 23 Jul 2020 21:13:51 +0000 (23:13 +0200)]
Add shim for python3.exe on Windows
Chocolatey doesn't install python3 as python3.exe, only as python.exe.
Magnus Jacobsson [Sat, 25 Jul 2020 21:40:20 +0000 (23:40 +0200)]
Replace regression_tests.ps1 with direct call to pytest
Magnus Jacobsson [Sat, 25 Jul 2020 21:33:51 +0000 (23:33 +0200)]
Replace call to ctest with call to pytest tests\regression_tests\shapes
which was the only test actually executed by ctest.
Magnus Jacobsson [Sat, 25 Jul 2020 21:24:15 +0000 (23:24 +0200)]
Convert test_large_graphs.py to pytest
Magnus Jacobsson [Sat, 25 Jul 2020 21:09:40 +0000 (23:09 +0200)]
Enable JUnit test reports in CI also for CMake builds on Windows
Magnus Jacobsson [Sat, 25 Jul 2020 21:03:02 +0000 (23:03 +0200)]
Refactor out pytest from test.sh and rename to install-packages.sh
Magnus Jacobsson [Sat, 25 Jul 2020 21:00:51 +0000 (23:00 +0200)]
Remove accidentally left-over debug dir:
Magnus Jacobsson [Tue, 28 Jul 2020 15:51:39 +0000 (17:51 +0200)]
Set up VCTools also for MSBuild tests
The solution comes from https://stackoverflow.com/a/
2128350 /
3122101
Magnus Jacobsson [Tue, 28 Jul 2020 15:21:17 +0000 (17:21 +0200)]
Correct VS compiler option in vmalloc test
Matthew Fernandez [Wed, 29 Jul 2020 13:51:11 +0000 (13:51 +0000)]
Merge branch '
60ddf7c4 -ae97-4594-be26-
aaf88a47d10e ' into 'master'
fix: zero allocations performed via ALLOCATE
See merge request graphviz/graphviz!1484
Mark Hansen [Wed, 29 Jul 2020 11:10:40 +0000 (11:10 +0000)]
Merge branch 'winbuild' into 'master'
Redirect winbuild.html to graphviz.org/doc/winbuild.html
See merge request graphviz/graphviz!1475
Matthew Fernandez [Sat, 18 Jul 2020 23:23:14 +0000 (16:23 -0700)]
add CI tests that GVPR lib is parseable
This does not test addedges, binduce, or histogram that require a command line
argument.
Matthew Fernandez [Wed, 29 Jul 2020 00:43:58 +0000 (17:43 -0700)]
fix: zero allocations performed via ALLOCATE
8d33fa030d308e6f5a4572a5b25bde4508757c31 refactored the site of a call to
vmnewof to remove an assumption that the returned allocation was zeroed. However
I failed to notice that the call to ALLOCATE (which eventually invokes vmnewof)
in exnewnode also relied on this assumption. This remained a latent issue until
84b2983edf458098bb6233368904265c92da4e65 whose changes meant the region returned
by vmnewof was no longer zeroed. The issue (now an active bug) still went
unnoticed until
ea791d46aa1d0f15c483d424fdddabf8f3b61cb0 was merged, which
contained a test that ran `gvpr -f cmd/gvpr/lib/color </dev/null` that triggered
a read through a bad pointer that should have been zeroed during these
allocations.
To fix this, we conservatively zero the result of all calls to ALLOCATE,
ensuring the assumptions these calls may have previously had is now restored.
Matthew Fernandez [Tue, 28 Jul 2020 14:35:40 +0000 (14:35 +0000)]
Revert "Merge branch '
99ea7101 -96e1-4730-a6bb-
60a7cef18289 ' into 'master'"
This reverts merge request !1472
Matthew Fernandez [Tue, 28 Jul 2020 13:42:47 +0000 (13:42 +0000)]
Merge branch '
99ea7101 -96e1-4730-a6bb-
60a7cef18289 ' into 'master'
add CI tests that GVPR lib is parseable
See merge request graphviz/graphviz!1472
Matthew Fernandez [Sat, 18 Jul 2020 23:23:14 +0000 (16:23 -0700)]
add CI tests that GVPR lib is parseable
This does not test addedges, binduce, or histogram that require a command line
argument.
Matthew Fernandez [Mon, 27 Jul 2020 13:40:40 +0000 (13:40 +0000)]
Merge branch '
87283f04 -c2e1-4a5b-b9c6-
a7c5ed0ef381 ' into 'master'
replace vmalloc with system allocator (malloc)
Closes #1757 and #1603
See merge request graphviz/graphviz!1460
Matthew Fernandez [Sun, 26 Jul 2020 17:48:18 +0000 (10:48 -0700)]
Merge branch 'master' of https://gitlab.com/graphviz/graphviz into
23588b12 -6184-423b-a348-
0364f98b4dee
Matthew Fernandez [Sat, 25 Jul 2020 20:37:31 +0000 (20:37 +0000)]
Merge branch '
6c6f68fb -9872-4d5f-b4c4-
1bc30f4d8e9b ' into 'master'
clean up legacy build scripts and remove non-standard configure exec in autogen.sh
Closes #1630
See merge request graphviz/graphviz!1473
Matthew Fernandez [Sat, 25 Jul 2020 20:08:16 +0000 (20:08 +0000)]
Merge branch '
10cc3882 -064d-491f-9420-
b3cd4a184cbb ' into 'master'
remove Cgraph test fragments
Closes #1768
See merge request graphviz/graphviz!1471
Matthew Fernandez [Sat, 25 Jul 2020 20:00:32 +0000 (13:00 -0700)]
add some basic unit tests for vmalloc
Matthew Fernandez [Sat, 18 Jul 2020 19:11:11 +0000 (12:11 -0700)]
expand on vmclear description
Matthew Fernandez [Fri, 17 Jul 2020 00:25:31 +0000 (17:25 -0700)]
remove legacy vmalloc README file
Matthew Fernandez [Fri, 17 Jul 2020 00:17:24 +0000 (17:17 -0700)]
fill in some missing Javadoc vmalloc comments
Matthew Fernandez [Sat, 11 Jul 2020 23:10:27 +0000 (16:10 -0700)]
remove now extraneous parts of vmalloc
Matthew Fernandez [Sat, 11 Jul 2020 22:22:08 +0000 (15:22 -0700)]
remove unused 'type' argument to vmresize
Matthew Fernandez [Sat, 11 Jul 2020 22:05:53 +0000 (15:05 -0700)]
remove a level of indirection in vmalloc
The metadata for the allocator is now allocated directly in Vmalloc_t instead of
within a Vmdata_t. This lets us allocate in a single block more efficiently.
Matthew Fernandez [Sat, 11 Jul 2020 21:57:17 +0000 (14:57 -0700)]
remove unused Vmheap
Matthew Fernandez [Sat, 11 Jul 2020 21:50:27 +0000 (14:50 -0700)]
remove unused Vmregion
Matthew Fernandez [Sat, 11 Jul 2020 21:44:17 +0000 (14:44 -0700)]
remove unused Vmbest
Matthew Fernandez [Sat, 11 Jul 2020 21:25:04 +0000 (14:25 -0700)]
remove now unused parameter to vmopen
Matthew Fernandez [Sat, 11 Jul 2020 21:16:14 +0000 (14:16 -0700)]
unconditionally use bestalloc in vmopen()
This policy is no longer configurable because we simply use the system
allocator, malloc.
Matthew Fernandez [Sat, 11 Jul 2020 21:07:20 +0000 (14:07 -0700)]
expose bestalloc, bestfree, bestresize to other parts of vmalloc
Matthew Fernandez [Sat, 11 Jul 2020 21:00:12 +0000 (14:00 -0700)]
remove unnecessary 'reg' annotations in vmalloc
Whether these parameters are provided in registers or on the stack is entirely
dictated by the platform's calling convention these days.
Matthew Fernandez [Sat, 11 Jul 2020 20:57:04 +0000 (13:57 -0700)]
remove now unused Vmdcsbrk
Closes #1603, #1757.
Matthew Fernandez [Sat, 11 Jul 2020 20:40:27 +0000 (13:40 -0700)]
remove a use of Vmdcsbrk discipline
The discipline is no longer used in vmalloc.
Matthew Fernandez [Sat, 11 Jul 2020 20:37:02 +0000 (13:37 -0700)]
remove now unused Vmdcheap
Matthew Fernandez [Sat, 11 Jul 2020 19:18:47 +0000 (12:18 -0700)]
remove now unused parameters to vmopen()
Matthew Fernandez [Sat, 11 Jul 2020 19:13:39 +0000 (12:13 -0700)]
back vmalloc by the system allocator
Here we replace the custom vmalloc allocator implementation with calls to
malloc, while preserving the overall pool abstraction. That is, it is still
possible to not free any of your vmalloc allocations but then rely on a final
call to vmclose() to clean them up. Note that this also removes the vmprivate
functionality which is no longer relevant.
Mark Hansen [Tue, 21 Jul 2020 09:17:29 +0000 (19:17 +1000)]
Redirect winbuild.html to graphviz.org/doc/
This saves us having to update the file in two repositories, for more
sustainable docs.
Addressing https://gitlab.com/graphviz/graphviz.gitlab.io/-/issues/39
Matthew Fernandez [Tue, 21 Jul 2020 01:00:37 +0000 (18:00 -0700)]
fix: unescaped backslashes in graph labels in xdot output
Variant of #165.
Matthew Fernandez [Tue, 21 Jul 2020 00:54:38 +0000 (17:54 -0700)]
fix: unescaped backslashes in edge labels in xdot output
A variant of #165.
Matthew Fernandez [Tue, 21 Jul 2020 00:18:40 +0000 (17:18 -0700)]
fix: unescaped backslashes in node labels in xdot output
Fixes #165.
Matthew Fernandez [Mon, 20 Jul 2020 14:33:04 +0000 (14:33 +0000)]
Merge branch '
bf07f37f -3fb5-4e00-80d8-
77416f3b1071 ' into 'master'
replace RBTree Assert() with assert()
Closes #1742
See merge request graphviz/graphviz!1461
Matthew Fernandez [Sun, 19 Jul 2020 23:21:19 +0000 (23:21 +0000)]
Merge branch 'subproject-rev2-1477' into 'master'
CMake subproject support - minimal - addresses 1477
See merge request graphviz/graphviz!1466
Matthew Fernandez [Sun, 19 Jul 2020 22:50:45 +0000 (15:50 -0700)]
Merge branch '
d78dd7b6 -6c75-492c-b1d8-
8fd0eaf45be7 ' of ssh://gitlab.com/smattr/graphviz
Matthew Fernandez [Sun, 19 Jul 2020 22:14:23 +0000 (22:14 +0000)]
Merge branch '
643e9f4d -5ec2-46ca-ac43-
33a612fc2e49 ' into 'master'
fix missing parameters to remove_overlap() definition
Closes #1544
See merge request graphviz/graphviz!1468
Matthew Fernandez [Sun, 19 Jul 2020 02:25:16 +0000 (19:25 -0700)]
remove non-standard ./configure step in autogen.sh
Closes #1630.
Matthew Fernandez [Sun, 19 Jul 2020 02:22:42 +0000 (19:22 -0700)]
explicitly run ./configure during CI
Related to #1630.
Matthew Fernandez [Sun, 19 Jul 2020 02:21:49 +0000 (19:21 -0700)]
remove unused CI script
Matthew Fernandez [Sun, 19 Jul 2020 02:18:56 +0000 (19:18 -0700)]
remove unused builder.sh script
Matthew Fernandez [Sat, 18 Jul 2020 18:17:08 +0000 (11:17 -0700)]
remove Cgraph test fragments
Closes #1768.
Matthew Fernandez [Sat, 18 Jul 2020 16:25:15 +0000 (16:25 +0000)]
Merge branch '
340c68ed -f0f6-43b0-aeeb-
551c42c52178 ' into 'master'
fix line numbers in GVPR error reporting
Closes #1594
See merge request graphviz/graphviz!1462
Bob Apthorpe [Thu, 16 Jul 2020 13:29:04 +0000 (08:29 -0500)]
Extended messages for missing formats, layouts. r2
Matthew Fernandez [Wed, 15 Jul 2020 00:17:29 +0000 (00:17 +0000)]
Merge branch 'osx-symbols-1613' into 'master'
Workaround for unresolved symbols in libcommon on OSX
See merge request graphviz/graphviz!1464
Magnus Jacobsson [Tue, 14 Jul 2020 16:35:22 +0000 (16:35 +0000)]
Merge branch 'update-DEVELOPERS.md-after-2.44.1-release' into 'master'
Update DEVELOPERS.md after 2.44.1 release
See merge request graphviz/graphviz!1451
Matthew Fernandez [Sun, 12 Jul 2020 03:07:52 +0000 (20:07 -0700)]
remove no longer used Assert()
Related to #1742.
Matthew Fernandez [Sun, 12 Jul 2020 03:00:27 +0000 (20:00 -0700)]
replace RBTree assertion calls with libc assert() calls
This change uses the idiom `assert(expression && "message")`. This is a way to
attach readable messages to assertion failures in C, as the libc assert
interface has no way to do this natively. Related to #1742.
Matthew Fernandez [Tue, 14 Jul 2020 13:52:04 +0000 (13:52 +0000)]
Merge branch '
6378F0F2 -12A2-4AB8-8A80-
72F7C7F91A55 ' into 'master'
fix: update README CI badges
See merge request graphviz/graphviz!1458
Bob Apthorpe [Fri, 10 Jul 2020 19:05:42 +0000 (19:05 +0000)]
Initial workaround for clang/lld/osx
(cherry picked from commit
992e6c2693c16c2a056efe849c612d0e1ee6d85e )
(cherry picked from commit
1b628544f02f65cc1e54fb9522f0f6ee2542cbc7 )
Matthew Fernandez [Tue, 14 Jul 2020 03:10:07 +0000 (20:10 -0700)]
suppress compile errors from unused remove_overlap() parameters
Related to #1544.
Matthew Fernandez [Tue, 14 Jul 2020 03:02:53 +0000 (20:02 -0700)]
make overlap.h prototypes unconditionally visible to remove_overlap()
This makes it difficult for remove_overlap() definitions to drift out of line
from its declaration without causing a compile error. Related to #1544.
Matthew Fernandez [Tue, 14 Jul 2020 02:56:18 +0000 (19:56 -0700)]
fix: realign non-triangle remove_overlap() with its prototype
There are two definitions of remove_overlap(), one in use when triangulation or
GTS is enabled and the other in use when either of these is disabled. The latter
definition did not match its declaration. As a result, any attempt to use this
function would most likely have resulted in stack corruption. Fixes #1544.
Matthew Fernandez [Tue, 14 Jul 2020 00:44:21 +0000 (17:44 -0700)]
update some legacy Graphviz URLs to HTTPS
Matthew Fernandez [Tue, 14 Jul 2020 00:36:22 +0000 (17:36 -0700)]
fix typo in patchwork man page
This was accidentally introduced by myself in
965aa14cff6a6ac6ec26501a93c7ad27a7887689 .
Bob Apthorpe [Mon, 13 Jul 2020 22:41:13 +0000 (22:41 +0000)]
CMAKE_SOURCE_DIR -> CMAKE_CURRENT_SOURCE_DIR
Matthew Fernandez [Sun, 12 Jul 2020 17:32:55 +0000 (10:32 -0700)]
fix line numbers in GVPR error reporting
When swallowing a single line comment (C-style "//..." or shell-style "#..."),
lib/gvpr would push the trailing newline into its output buffer as well as
yielding it. The effect of this was that the second stage parsing done by
lib/expr would see two newlines, throwing off its recorded line number by one
for each single line comment. Fixes #1594.
Magnus Jacobsson [Sun, 12 Jul 2020 10:29:30 +0000 (10:29 +0000)]
Merge branch '
509c2d33 -d4f6-4cde-bd74-
1e6bf700d8eb ' into 'master'
Test C examples in CI also on Windows
See merge request graphviz/graphviz!1457
Magnus Jacobsson [Wed, 8 Jul 2020 19:28:30 +0000 (21:28 +0200)]
Include pack_graph from pack into gvc
See https://gitlab.com/graphviz/graphviz/-/issues/1761 for why this
change is duplicated.
Magnus Jacobsson [Wed, 8 Jul 2020 17:17:22 +0000 (19:17 +0200)]
Workaround captured output lost in GitLab CI
Magnus Jacobsson [Tue, 7 Jul 2020 07:29:51 +0000 (09:29 +0200)]
Join path to C sourc file os-independently
Magnus Jacobsson [Mon, 6 Jul 2020 18:06:16 +0000 (20:06 +0200)]
Add run of test_examples.py to Windows CMake test
Magnus Jacobsson [Mon, 6 Jul 2020 17:24:07 +0000 (19:24 +0200)]
Install pytest in Windows CI
Magnus Jacobsson [Mon, 6 Jul 2020 17:22:57 +0000 (19:22 +0200)]
Adapt test_examples.py to Windows
Matthew Fernandez [Sat, 11 Jul 2020 22:33:55 +0000 (15:33 -0700)]
zero out the result of a vmnewof()
This is the only instance of a call to vmnewof() that appears to rely on the
semantics of the returned memory having been zeroed. We are about to make some
changes that make it impossible for the allocator to zero extra memory in a
vmresize() because it does not know the size of the original allocation. This
change makes it safe for vmresize() to stop providing zeroed out extra memory.
Matthew Fernandez [Sat, 11 Jul 2020 17:53:56 +0000 (10:53 -0700)]
remove agheap()
Accessing the internals of the allocator via Cgraph is no longer supported.
Matthew Fernandez [Sat, 11 Jul 2020 17:36:14 +0000 (17:36 +0000)]
Merge branch '
9bc7e01e -5811-4256-92ed-
85b323261351 ' into 'master'
clean up unused parts of vmalloc
Closes #1757, #1603, #1424, and #975
See merge request graphviz/graphviz!1456
Matthew Fernandez [Sat, 11 Jul 2020 17:03:10 +0000 (17:03 +0000)]
Merge branch 'date2' into 'master'
gv_doc_template.tcl: Pass "-gmt True" to support reproducible dates.
See merge request graphviz/graphviz!1454
Matthew Fernandez [Sat, 11 Jul 2020 15:21:00 +0000 (15:21 +0000)]
Merge branch '
509c2d33 -d4f6-4cde-bd74-
1e6bf700d8eb ' into 'master'
test C examples in CI
See merge request graphviz/graphviz!1455
Matthew Fernandez [Fri, 10 Jul 2020 00:46:53 +0000 (00:46 +0000)]
Merge branch '
4b832e74 -d1b7-45bf-8b80-
32ba42272311 ' into 'master'
remove legacy malloc.h stub
See merge request graphviz/graphviz!1453
Matthew Fernandez [Fri, 10 Jul 2020 00:07:02 +0000 (00:07 +0000)]
Merge branch '
c2a8c9c1 -033c-43dc-82f9-
8424e1da84c6 ' into 'master'
remove some compiler warnings
See merge request graphviz/graphviz!1452
Matthew Fernandez [Thu, 9 Jul 2020 00:51:39 +0000 (17:51 -0700)]
fix: update README CI badges
Matthew Fernandez [Sat, 4 Jul 2020 17:28:35 +0000 (10:28 -0700)]
add compilation of the C examples to the test suite
Matthew Fernandez [Sun, 5 Jul 2020 18:53:42 +0000 (11:53 -0700)]
install Graphviz dev libraries during CI testing
This allows us to begin testing code that compiles and links against Graphviz
libraries.
Matthew Fernandez [Sat, 4 Jul 2020 17:12:05 +0000 (10:12 -0700)]
fix: update simple.c example for latest API
Matthew Fernandez [Sat, 4 Jul 2020 17:11:12 +0000 (10:11 -0700)]
fix: update neatopack.c example for latest API
Matthew Fernandez [Sat, 4 Jul 2020 17:10:16 +0000 (10:10 -0700)]
fix: update dot.c example for latest API
Matthew Fernandez [Sat, 4 Jul 2020 17:09:22 +0000 (10:09 -0700)]
fix: update example.c to latest API
Matthew Fernandez [Sun, 5 Jul 2020 23:59:36 +0000 (16:59 -0700)]
remove unused vmwalk API