Richard Russon [Fri, 1 Jun 2018 09:47:04 +0000 (10:47 +0100)]
remove last references to pgpring
Bo YU [Fri, 1 Jun 2018 08:48:30 +0000 (16:48 +0800)]
remove pgpring from docs
Bo YU [Thu, 31 May 2018 08:44:55 +0000 (16:44 +0800)]
Remove PgpSignature
The PgpSignature is only used by the pgpring tool.
The pgpring tool is only needed by users of PGP2 and PGP5.
PGP5 is over twenty years old.
- remove PgpSignature from ncrypt/pgplib.[ch]
- remove pgppubring.c
- update Makefile.autosetup
- remove contrib/pgp2.rc
- remove contrib/pgp5.rc
- remove contrib/pgp6.rc
- update contrib/Makefile.autosetup
Mehdi ABAAKOUK [Wed, 30 May 2018 14:27:38 +0000 (16:27 +0200)]
pager: index must be rebuilt on MUTT_REOPENED
When we call mx_check_mailbox() and something change
header in Context->hdrs may have been updated.
In case of MUTT_NEW_MAIL, the page rebuild the index, and fixup
rd.index->current/max and extra->hdr. If the extra->hdr change
like when an above the opened one, or the selected one, is deleted, the
pager is closed.
In case of MUTT_REOPENED we do nothing. Making rd.index->current/max
wrong and extra->hdr perhaps pointing to something that doesn't exist
anymore.
This change makes the MUTT_REOPENED behavior similar to MUTT_NEW_MAIL.
Note that we this the pager have good change to be closed with the
mailbox is modified externally, just like the current MUTT_NEW_MAIL
behavior.
Closes #796
Pietro Cerutti [Wed, 30 May 2018 12:44:14 +0000 (13:44 +0100)]
Handle a BAD response in AUTH PLAIN w/o initial response (#1237)
The incorrect assumption was that the first line of an AUTH PLAIN w/o
I-R was always successful, so the client could write the second line and
end up with a readable socket that would be activated by the server
sending the final OK or BAD response.
If however the first line results in a BAD response already, the server
wouldn't write anything else and the client would be left polling for an
additional response that never arrives, effectively hanging the process.
Issue #1236
Pietro Cerutti [Tue, 29 May 2018 15:39:23 +0000 (15:39 +0000)]
Avoid regenerating hcache/hcversion.h after building objects in hcache
Specifying the hcache directory asqa dependency for hcache/hcversion.h
means that the latter will be regenerated whenever the hcache directory
is changed, such as when object files are written into it. The net
effect is that "make; make" regenerates hcache/hcversion.h twice.
This commit fixes this problem by explicitely creating the hcache
directory as part of the hcache/hcversion.h target.
Pietro Cerutti [Tue, 29 May 2018 13:29:02 +0000 (14:29 +0100)]
Add the mutt_ch_check API (#1139)
* Add the mutt_ch_check API
This adds the mutt_ch_check API that can be used to check whether a
string can be converted between character sets. It is stricter than
mutt_ch_convert_string in that it doesn't apply any replacement chars to
unconvertible characters and doesn't return the converted string.
* Fix ICONV_CONST
* Fix arguments to iconv()
* Free the correct pointer
Pietro Cerutti [Tue, 29 May 2018 12:05:10 +0000 (13:05 +0100)]
Don't let info messages reset error messages' timeouts (#1234)
Issue #1100
Pietro Cerutti [Tue, 29 May 2018 08:13:11 +0000 (08:13 +0000)]
Fix typo in comment
Richard Russon [Tue, 29 May 2018 03:03:52 +0000 (04:03 +0100)]
merge: update translations
* add missing format specifier
* curs_main.c: Fix plural messages with "messages"
* drop dupe bad IDN messages
* handler.c: Partly fix plural message about attachment size
* make room for translation
* mx.c: Fix plural message "messages(s) not deleted"
* mx.c: Fix plural message "Move %d read messages to %s?"
* ncrypt/crypt_gpgme.c: Fix plural message "%s, %lu bit %s\n"
* ncrypt/ncrypt.c: Fix plural message "Passphrases forgotten."
* opcodes.h: Fix plural messages with "<word>(s)"
* pager.c: Fix plural messages with "messages"
* pager.c: Mark two strings for translation
* pop.c: Fix plural message "Reading new messages (%d bytes)..."
* recvattach.c: Fix plural message "Print tagged attachments?"
* sync translations
* translate status 'all' and 'end'
* Update Czech translation
* Update lt_LT translation
* Update po files
* Update pt_BR translation
* Update zh_CN translation
* Updated Catalan translation.
* Updated Japanese translation.
* Updated Russian translation.
* Updated Slovak translation
* Updated Ukrainian translation.
Richard Russon [Tue, 29 May 2018 02:54:50 +0000 (03:54 +0100)]
sync translations
Ivan Vilata i Balaguer [Thu, 17 May 2018 19:24:31 +0000 (12:24 -0700)]
Updated Catalan translation.
TAKAHASHI Tamotsu [Thu, 17 May 2018 17:10:52 +0000 (10:10 -0700)]
Updated Japanese translation.
Vsevolod Volkov [Wed, 9 May 2018 16:32:48 +0000 (09:32 -0700)]
Updated Russian translation.
Vsevolod Volkov [Wed, 9 May 2018 16:30:55 +0000 (09:30 -0700)]
Updated Ukrainian translation.
Zero King [Sun, 27 May 2018 13:09:32 +0000 (13:09 +0000)]
Update zh_CN translation
Richard Russon [Sun, 27 May 2018 23:20:03 +0000 (00:20 +0100)]
drop dupe bad IDN messages
Zero King [Sat, 26 May 2018 10:13:16 +0000 (10:13 +0000)]
Update zh_CN translation
Bo YU [Thu, 24 May 2018 12:11:31 +0000 (08:11 -0400)]
Translate: update zh_cn
The translate would be better
Signed-off-by: Bo YU <yuzibode@126.com>
Bo YU [Thu, 24 May 2018 11:42:00 +0000 (07:42 -0400)]
Translate zh_cn update
msgid "Print tagged attachment?"
msgid_plural "Print %d tagged attachments?"
msgstr[0] "打印 %d 件已标记的附件?"
And i want to make clear for that:if i place %d into msgstr[0],then
msgid "Print tagged attachment" how to translate?Under my understand,if
program invokes msgid, it will display "打印 件已标记的附件",just left a
space.
Signed-off-by: Bo YU <yuzibode@126.com>
Bo YU [Thu, 24 May 2018 10:56:21 +0000 (06:56 -0400)]
Translate: update zh_CN translate
add missing format specifier: %d
Signed-off-by: Bo YU <yuzibode@126.com>
Richard Russon [Wed, 23 May 2018 16:53:04 +0000 (17:53 +0100)]
add missing format specifier
Bo Yu [Thu, 24 May 2018 01:45:28 +0000 (21:45 -0400)]
Translate: Update zh_CN translates
Zh_CN translate update.Now, i removed about 15 string "fuzzy" tagged.
Signed-off-by: Bo Yu <tsu.yubo@gmail.com>
Richard Russon [Wed, 23 May 2018 16:34:48 +0000 (17:34 +0100)]
translate status 'all' and 'end'
David Sterba [Wed, 23 May 2018 14:18:10 +0000 (16:18 +0200)]
Update Czech translation
Richard Russon [Wed, 23 May 2018 14:01:36 +0000 (15:01 +0100)]
make room for translation
Marius Gedminas [Wed, 23 May 2018 13:07:03 +0000 (16:07 +0300)]
Update lt_LT translation
Two new strings, a bunch of fuzzy strings. Back to 100%.
Thiago Costa de Paiva [Wed, 23 May 2018 13:08:55 +0000 (09:08 -0400)]
Update pt_BR translation
Thiago Costa de Paiva [Wed, 23 May 2018 13:00:59 +0000 (09:00 -0400)]
Update pt_BR translation
Thiago Costa de Paiva [Wed, 9 May 2018 10:40:17 +0000 (06:40 -0400)]
Update pt_BR translation
Reis Radomil [Tue, 22 May 2018 14:18:53 +0000 (14:18 +0000)]
Update po files to match new code base
Most changes are splitting up plural constructions into more "saner"
versions, e.g. _("message(s)") becomes ngettext("message", "messages",
n). In all the cases we used the old translation for the new pluralised
translation (in all plural forms). This might not be correct but yields
the same result as before the change to the end user.
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
opcodes.h: Fix plural messages with "<word>(s)"
Due to the implementation details we do not know whether we work with
zero, 1, 12, ... messages/files/.... So in English we use normal plural.
We leave it up to the translator to choose a fitting translation. Some
language might have other means to express this situation.
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
curs_main.c: Fix plural messages with "messages"
Due to the implementation details we do not know whether we
delete/undelete/mark/... zero, 1, 12, ... messages. So in English we use
"messages". We leave it up to the translator to choose a fitting
translation. Some language might have other means to express this
situation.
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
pager.c: Fix plural messages with "messages"
Due to the implementation details we do not know whether we
delete/undelete zero, 1, 12, ... messages. So in English we use
"messages". We leave it up to the translator to choose a fitting
translation. Some language might have other means to express this
situation.
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
handler.c: Partly fix plural message about attachment size
Use ngettext() to choose a (more) correct plural form for 'byte'
depending on the attachment size. There is a caveat though: We do not
print the size as number but as a prettified number, e.g. 2048 will be
printed as 2K. Some languages might inflect 'byte' different depending
on whether it is '1K byte' or '1024'. Sadly there is nothing we can do
about that in the moment (besides not using the prettified version but
that is not an option).
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
ncrypt/crypt_gpgme.c: Fix plural message "%s, %lu bit %s\n"
Give translators to opportunity to inflect "bit" according to the bit
size of the key.
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
pop.c: Fix plural message "Reading new messages (%d bytes)..."
Although the English use case with "1 byte" is unlikely to happen, other
languages might have other rules.
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
mx.c: Fix plural message "Move %d read messages to %s?"
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
recvattach.c: Fix plural message "Print tagged attachments?"
If messages are tagged, then count them and use the number to pluralise
the phrase "tagged messages" correctly.
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
ncrypt/ncrypt.c: Fix plural message "Passphrases forgotten."
Due to the implementation details (e.g. some passwords are managed by
gpg-agent) we cannot know whether we forgot zero, 1, 12, ... passwords.
So in English we use a generic plural. Different languages might have
other means, so we leave the decision what to choose to the translator.
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
mx.c: Fix plural message "messages(s) not deleted"
Reis Radomil [Sun, 20 May 2018 02:03:58 +0000 (02:03 +0000)]
Update po files
Reis Radomil [Sun, 20 May 2018 02:02:01 +0000 (02:02 +0000)]
pager.c: Mark two strings for translation
Mark to strings which are displayed to the end user for translation.
Fixes #1217
David Sterba [Tue, 22 May 2018 13:49:19 +0000 (15:49 +0200)]
Updated Slovak translation
Oswald Buddenhagen [Sun, 6 Jan 2013 18:24:18 +0000 (19:24 +0100)]
fix inappropriate use of FREE() in ssl init error path
OpenSSL structures need to be freed with dedicated functions.
Kevin McCarthy [Mon, 21 May 2018 22:12:47 +0000 (15:12 -0700)]
Remove mutt_buffer_new() NULL retval checks.
It will fail, rather than return NULL.
Further clean up imap_new_data() since it also had NULL checks for
safe_calloc() that shouldn't happen.
Richard Russon [Tue, 29 May 2018 01:48:27 +0000 (02:48 +0100)]
merge: trivial improvements
* fix comment
* fix formatting
* tidy main
* mutt_file_sanitize_filename bool param
* mutt_param_cmp_strict bool retval
* content state bools
* use buffer printf
* include queue.h in mutt/mutt.h
* bool param
* tidy handler.c
* split out enriched text code
Richard Russon [Tue, 29 May 2018 01:35:18 +0000 (02:35 +0100)]
split out enriched text code
Richard Russon [Mon, 28 May 2018 19:42:51 +0000 (20:42 +0100)]
tidy handler.c
Richard Russon [Mon, 28 May 2018 18:45:04 +0000 (19:45 +0100)]
bool param
Richard Russon [Mon, 28 May 2018 18:43:30 +0000 (19:43 +0100)]
include queue.h in mutt/mutt.h
Richard Russon [Mon, 28 May 2018 13:17:32 +0000 (14:17 +0100)]
use buffer printf
Richard Russon [Sun, 27 May 2018 19:22:35 +0000 (20:22 +0100)]
content state bools
Richard Russon [Sun, 27 May 2018 18:40:58 +0000 (19:40 +0100)]
mutt_param_cmp_strict bool retval
Richard Russon [Sun, 27 May 2018 18:33:25 +0000 (19:33 +0100)]
mutt_file_sanitize_filename bool param
Richard Russon [Fri, 25 May 2018 00:20:00 +0000 (01:20 +0100)]
tidy main
Richard Russon [Thu, 24 May 2018 11:13:40 +0000 (12:13 +0100)]
fix formatting
Richard Russon [Wed, 23 May 2018 12:34:28 +0000 (13:34 +0100)]
fix comment
Pietro Cerutti [Mon, 28 May 2018 12:42:30 +0000 (13:42 +0100)]
Move LSUB call from connection establishment to mailbox SELECTion (#1232)
* Move LSUB call from connection establishment to mailbox SELECTion
This changes the place where an LSUB is issued to an IMAP server in
order to populate the buffy list, when imap_check_subscribed is set.
Previously, LSUB was issued when a connection to an IMAP server was
*first* established. This caused the commands sequence
":unmailboxes *<enter><change-folder>imaps://foo.com<enter>"
to populate the buffy list when *first* opening a connection to foo.com,
but not on subsequent back-and-forth between IMAP servers.
The new code moves the LSUB call - and thus the population of the buffy
list - to just before a mailbox is selected.
This fixes the above-mentioned issue, at the cost of additional LSUB
calls when switching between mailboxes on the same server. Given that
the list of subscribed mailboxes is expected to be in the tens, I think
this is a reasonable tradeoff.
Issue #1225
Pietro Cerutti [Thu, 24 May 2018 10:51:28 +0000 (11:51 +0100)]
Honour SASL-IR IMAP capability in SASL PLAIN
* Honour SASL-IR IMAP capability
* Tidy auth plain logic
* Keep the buffer static
Fixes #1211
Marius Gedminas [Wed, 23 May 2018 09:59:18 +0000 (12:59 +0300)]
Apply coding style with clang-format
Marius Gedminas [Wed, 23 May 2018 09:53:47 +0000 (12:53 +0300)]
Do not truncate shell commands on ; or #
Fixes #1216.
Richard Russon [Wed, 23 May 2018 14:15:35 +0000 (15:15 +0100)]
check that PreferredLanguages is set
Richard Russon [Tue, 22 May 2018 11:05:00 +0000 (12:05 +0100)]
merge: trivial improvements
* tidy param names
* fix cppcheck issues
* comment blocks for aliases
* comment blocks for command parsing
* regroup functions
Richard Russon [Tue, 22 May 2018 02:26:18 +0000 (03:26 +0100)]
regroup functions
Richard Russon [Mon, 21 May 2018 22:34:19 +0000 (23:34 +0100)]
comment blocks for command parsing
Richard Russon [Sun, 20 May 2018 00:42:26 +0000 (01:42 +0100)]
comment blocks for aliases
Richard Russon [Mon, 21 May 2018 16:05:07 +0000 (17:05 +0100)]
fix cppcheck issues
Richard Russon [Mon, 21 May 2018 15:21:15 +0000 (16:21 +0100)]
tidy param names
Richard Russon [Sat, 19 May 2018 21:08:29 +0000 (22:08 +0100)]
merge: update translations
* fix some accidental fuzzyness
* Update lt_LT translation
* Update lt_LT translations
* Update zh_CN translation
* sync translations
Richard Russon [Sat, 19 May 2018 21:07:52 +0000 (22:07 +0100)]
sync translations
Marius Gedminas [Sat, 19 May 2018 18:34:37 +0000 (21:34 +0300)]
Update lt_LT translation
We're at 100%! The fifth language to reach this goal (after recent
changes).
Marius Gedminas [Sat, 19 May 2018 14:28:44 +0000 (17:28 +0300)]
Update lt_LT translation
Most of the remaining untranslated messagers
Marius Gedminas [Sat, 19 May 2018 13:31:23 +0000 (16:31 +0300)]
Update lt_LT translation
Small fixes.
Marius Gedminas [Sat, 19 May 2018 13:01:09 +0000 (16:01 +0300)]
Update lt_LT translations
Low-hanging fruit among missing translations in the rest of the file.
Marius Gedminas [Sat, 19 May 2018 12:19:44 +0000 (15:19 +0300)]
Update lt_LT translation
Translating missing entries in the first 25% of the file.
Marius Gedminas [Fri, 18 May 2018 14:19:12 +0000 (17:19 +0300)]
Update lt_LT translations
All fuzzy entries have been translated.
Marius Gedminas [Fri, 18 May 2018 12:23:44 +0000 (15:23 +0300)]
Update lt_LT translation
Reviewing fuzzy entries in the first 90% of the file.
Marius Gedminas [Fri, 18 May 2018 10:30:34 +0000 (13:30 +0300)]
Update lt_LT translation
Going over fuzzy entries in the first 80% of the file
Marius Gedminas [Fri, 18 May 2018 09:45:59 +0000 (12:45 +0300)]
Update lt_LT translation
The Great PGP/S/MIME Option Translation.
Wow this was hard.
Marius Gedminas [Thu, 17 May 2018 07:14:11 +0000 (10:14 +0300)]
Update lt_LT translations
Mostly fuzzies again. Hit a roadblock with the PGP menus.
Zero King [Tue, 15 May 2018 14:59:32 +0000 (14:59 +0000)]
Update zh_CN translation
Marius Gedminas [Tue, 15 May 2018 12:03:16 +0000 (15:03 +0300)]
Update lt_LT translation
Mostly reviewing fuzzy entries in the first 60% of the file, but I also
added some missing translations and reviewed some older translations for
consistency.
Marius Gedminas [Mon, 14 May 2018 10:29:14 +0000 (13:29 +0300)]
Update lt_LT translation
Reviewed fuzzy entries (and some adjacent ones) in the first 50% of the
file.
Zero King [Sun, 13 May 2018 03:23:46 +0000 (03:23 +0000)]
Update zh_CN translation
Richard Russon [Sat, 12 May 2018 12:17:21 +0000 (13:17 +0100)]
fix some accidental fuzzyness
Marius Gedminas [Sat, 12 May 2018 07:49:58 +0000 (10:49 +0300)]
Update lt_LT translation
Mostly fuzzy strings in the first 40% of the file
Marius Gedminas [Sat, 12 May 2018 06:55:21 +0000 (09:55 +0300)]
Update lt_LT translation
Mostly fuzzy entries in the first 30% of the file.
Zero King [Sat, 12 May 2018 06:07:26 +0000 (06:07 +0000)]
Update zh_CN translation
Richard Russon [Sat, 19 May 2018 17:32:49 +0000 (18:32 +0100)]
prepare to use travis' fold/timer
Vladimir Zakharov [Sat, 28 Apr 2018 10:29:00 +0000 (13:29 +0300)]
Convert Aliases to use TAILQ
Richard Russon [Mon, 14 May 2018 20:49:15 +0000 (21:49 +0100)]
build: stop on install failure
Pierre-Elliott Bécue [Thu, 17 May 2018 08:52:31 +0000 (10:52 +0200)]
reply_with_xorigto: use mutt_addr_copy instead of mutt_addr_copy_list
Richard Russon [Wed, 16 May 2018 12:17:41 +0000 (13:17 +0100)]
add missing flags
Make sure all the 'set' routes through parse_set() use
MUTT_TOKEN_BACKTICK_VARS.
Richard Russon [Wed, 16 May 2018 12:19:26 +0000 (13:19 +0100)]
Revert "Partial solution to #1165 (#1176)"
Too complicated
Lars Kellogg-Stedman [Tue, 15 May 2018 16:43:35 +0000 (12:43 -0400)]
Partial solution to #1165 (#1176)
* mutt/file.c: allow mutt_file_mkstemp to return a filename
modify mutt_file_mkstemp so that a caller may pass in a character
buffer that will be filled with the temporary filename. When a
non-null buffer is provided, mutt_file_mkstemp will *not* unlink the
temporary file and will leave cleanup to the caller.
Closes: #1165
Pietro Cerutti [Mon, 7 May 2018 13:52:55 +0000 (13:52 +0000)]
Introduce MUTT_TOKEN_BACKTICK_VARS to expand variables within backticks
This is a new flag to mutt_extract_token which triggers variable
expansion within backticks.
With this flag:
```
:set my_foo="`echo foo $pager bar`"
:set ?my_foo
foo builtin bar
```
Without this flag:
```
:set my_foo="`echo foo $pager bar`"
:set ?my_foo
foo bar
```
This flag is currently only passed when parsing a `set` command.
Pietro Cerutti [Mon, 9 Apr 2018 15:44:04 +0000 (15:44 +0000)]
Expand variables inside backticks
This allows for example to simplify the solution given here [1] as:
```
:set pager_index_lines=`dc -e "50 $pager_index_lines -p"`
```
[1]
http://mailman.neomutt.org/pipermail/neomutt-users-neomutt.org/2018-April/000325.html
Richard Russon [Tue, 15 May 2018 15:24:32 +0000 (16:24 +0100)]
fix history menu
Pietro Cerutti [Tue, 15 May 2018 12:07:13 +0000 (12:07 +0000)]
Fix toggle-read
Issue #1198