Frank Tang [Thu, 29 Apr 2021 07:07:45 +0000 (00:07 -0700)]
ICU-21569 Add GA to test LSTM configuration
1. Add GA to test BreakIterator under LSTM configuration (remove Thai
and Burmese dictionary and include Thai and Burmese LSTM)
2. Add LSTMDataName for the purpose of testing.
3. Add file base test code to test BreakIterator match results from test
file generated by pythong code in
https://github.com/unicode-org/lstm_word_segmentation/blob/master/segment_text.py
4. Fix a LSTMBreakEngine::divideUpDictionaryRange bug when the return value
should only contains the number of words found when the passed in foundBreaks
already contains some data.
5. Change the cintltest TestSwapData from testing thaidict to laodict so
it will not break while we filter out thaidict under the LSTM
configuration.
Andy Heninger [Sun, 25 Apr 2021 22:45:18 +0000 (15:45 -0700)]
ICU-21591 Release lock in SimpleDateFormat::tzFormat in case of failure
Also remove the use of the unsafe double-checked lock idiom in the same
function, SimpleDateFormat::tzFormat(). Synchronization now always uses a
mutex, which is slower, but in the context of format or parse operations,
shouldn't be significant.
Added synchronization to one more unsafe direct reference to a const
SimpleDateFormat::fTimeZoneFormat. In the assignment operator.
Mojca Miklavec [Sun, 28 Feb 2021 08:34:30 +0000 (09:34 +0100)]
ICU-21513 check if TARGET_OS_SIMULATOR has been defined
clang 11 throws an error when using undefined variables starting with
TARGET_OS_, and TARGET_OS_SIMULATOR is missing in earlier versions
of macOS, so the code would not compile without an additional guard.
Markus Scherer [Mon, 5 Apr 2021 22:57:33 +0000 (15:57 -0700)]
ICU-21459 properly guard BytesTrie.Result.getValue()
and clone/copy objects so that objects shared among instances are not modified
and use an atomic int for the C++ refcount
Markus Scherer [Mon, 5 Apr 2021 21:47:42 +0000 (14:47 -0700)]
ICU-21561 rename StringSegment.equals() to contentEquals()
and remove hashCode() because of now-missing equals() and because
StringSegment is mutable and documented as not suitable for HashMaps
Mojca Miklavec [Sun, 28 Feb 2021 08:34:30 +0000 (09:34 +0100)]
ICU-21513 check if TARGET_OS_SIMULATOR has been defined
clang 11 throws an error when using undefined variables starting with
TARGET_OS_, and TARGET_OS_SIMULATOR is missing in earlier versions
of macOS, so the code would not compile without an additional guard.
Steven R. Loomis [Mon, 22 Feb 2021 18:13:27 +0000 (12:13 -0600)]
ICU-20233 tool: improvements to commit checker for CLDR
- improve checks for CLDR resolutions
- update batch fetch from 50 to 100
- do not show no-commit tickets under illegal-state
- add navigation
- use numeric IDs for status, resolution, types with constants
(S_, R_, I_)
fix bugs from CLDR-14224
- do not show not-in-query issues as open
- cache single-issue queries
- give information on each problem as to what it is
- put 'review' in a separate section (not counted in Problems)
- more detailed fix info under each issue
- fix section headings, always show component, add nocopyright option
- sort open issues by componnent
- sort the 'review' list
ICU-20444:
- exclude (via git-cherry) any commits already cherry picked to the branch.
- used a workaround to https://github.com/gitpython-developers/GitPython/issues/846
that seemed to work well,
- warn about issues with excluded commits
CLDR-14524:
- Exclude "Obsolete" from requiring commits
gnrunge [Tue, 16 Mar 2021 23:32:07 +0000 (16:32 -0700)]
ICU-21520 Fixes typo in name of test data file; removes a regex that
evaluates to the empty string and the result files are missing the
perf test name as a result. E.g. '_Mar_16_155820.html' instead of
'unisetperf_Mar_16_155820.html'.
Not obvious why the regex was even created since it doesn't seem
necessary because the name of the caller doesn't require additional
parsing. The rpaticular code is from 2002, maybe changes in Perl
account for the issue(?)
Yoshito Umaoka [Mon, 15 Mar 2021 04:33:27 +0000 (00:33 -0400)]
ICU-21480 BRS69 ICU4J API signature file
- Supplied missing API comment to com.ibm.icu.nubmer.Precision#trailingZeroDisplay(TrailingZeroDisplay)
- Generated API signature file for ICU4J 69.1 and added to the repository
- Delete ICU4J 59 API signature file
- Deleted unused icu4j/eclipse-build/build.properties. The folder eclipse-build was deleted, but someone worked on ICU version seemed to add it back again. Delete it again.
gnrunge [Fri, 19 Feb 2021 22:00:18 +0000 (14:00 -0800)]
ICU-21323 Automates the uconfig variation BRS tasks. The test
subsequently sets each of the UCONFIG_NO_XXX flags to '1' (exceptions apply)
and runs the ICU4C unit tests and the header test. Afterwards all
UCONFIG_NO_XXX flags are set to '1' and unit tests and header test
are executed.
To allow concurrent execution and reduce total run time, the script provides
the option to execute only the unit tests or only the header test.
ICU-21323 Split the uconfig.h variation test into two to reduce
execution time. One test now tests the variations with unit tests, the
other tests with header test.
Execution time now ranges between 45 and 58 minutes.
Yoshito Umaoka [Mon, 8 Mar 2021 17:53:45 +0000 (12:53 -0500)]
ICU-21207 Remove unnecessary reflection call
The test code was written long time ago. Java 1.3 TimeZone did not have getDSTSavings() method. The test code compares DST saving of Lord_Howe between ICU and JDK, and calling getDSTSavings() through reflection for 1.3 compatibility. This is no longer necessary and replaced with regular method call.
Yoshito Umaoka [Mon, 8 Mar 2021 07:58:20 +0000 (02:58 -0500)]
ICU-21507 Removing unused class initializer code
ICUDebug seemed to check Java version whether it's 1.4 or higher. The code referencing the version is already gone. We also no longer support Java 1.3 runtime since long time ago. Remove the unused code checking Java version.