Bruce Momjian [Wed, 21 Feb 2007 22:15:21 +0000 (22:15 +0000)]
Move increase FSM warning to after lazy_truncate_heap() because the
function might reduce the number of free pages in the table. Recommend
VACUUM FULL only if 20% free.
Bruce Momjian [Wed, 21 Feb 2007 20:02:17 +0000 (20:02 +0000)]
btree source code cleanups:
I refactored findsplitloc and checksplitloc so that the division of
labor is more clear IMO. I pushed all the space calculation inside the
loop to checksplitloc.
I also fixed the off by 4 in free space calculation caused by
PageGetFreeSpace subtracting sizeof(ItemIdData), even though it was
harmless, because it was distracting and I felt it might come back to
bite us in the future if we change the page layout or alignments.
There's now a new function PageGetExactFreeSpace that doesn't do the
subtraction.
findsplitloc now tries the "just the new item to right page" split as
well. If people don't like the refactoring, I can write a patch to just
add that.
Magnus Hagander [Wed, 21 Feb 2007 12:28:27 +0000 (12:28 +0000)]
Revert changes to process pg_proc.h entries without OIDs. We're not supposed
to have such entries, and want to be notified when we do...
Leave the plain bugfix in genbki.
Andrew Dunstan [Wed, 21 Feb 2007 03:27:32 +0000 (03:27 +0000)]
Allow pltcl args to spi_prepare and plpython args to plpy.prepare to be standard type aliases as well as those known in pg_type. Similar to recent change in plperl.
Bruce Momjian [Tue, 20 Feb 2007 23:39:03 +0000 (23:39 +0000)]
Add:
>
> * Consider decreasing the amount of memory used by PrivateRefCount
>
> http://archives.postgresql.org/pgsql-hackers/2006-11/msg00797.php
> http://archives.postgresql.org/pgsql-hackers/2007-01/msg00752.php
>
Bruce Momjian [Tue, 20 Feb 2007 22:29:28 +0000 (22:29 +0000)]
Add:
> * Increase locking when DROPing objects so dependent objects cannot
> get dropped while the DROP operation is happening
>
> http://archives.postgresql.org/pgsql-hackers/2007-01/msg00937.php
Tom Lane [Tue, 20 Feb 2007 17:32:18 +0000 (17:32 +0000)]
Remove the Query structure from the executor's API. This allows us to stop
storing mostly-redundant Query trees in prepared statements, portals, etc.
To replace Query, a new node type called PlannedStmt is inserted by the
planner at the top of a completed plan tree; this carries just the fields of
Query that are still needed at runtime. The statement lists kept in portals
etc. now consist of intermixed PlannedStmt and bare utility-statement nodes
--- no Query. This incidentally allows us to remove some fields from Query
and Plan nodes that shouldn't have been there in the first place.
Still to do: simplify the execution-time range table; at the moment the
range table passed to the executor still contains Query trees for subqueries.
Bruce Momjian [Tue, 20 Feb 2007 14:17:24 +0000 (14:17 +0000)]
Add:
> * Fix IS OF so it matches the ISO specification, and add documentation
>
> http://archives.postgresql.org/pgsql-patches/2003-08/msg00060.php
> http://archives.postgresql.org/pgsql-hackers/2007-02/msg00060.php
Bruce Momjian [Mon, 19 Feb 2007 20:41:40 +0000 (20:41 +0000)]
Add:
> * Allow UPDATEs on only non-referential integrity columns not to conflict
> with referential integrity locks
>
> http://archives.postgresql.org/pgsql-hackers/2007-02/msg00073.php
Bruce Momjian [Mon, 19 Feb 2007 16:36:17 +0000 (16:36 +0000)]
Done:
< o Add long file support for binary pg_dump output
<
< While Win32 supports 64-bit files, the MinGW API does not,
< meaning we have to build an fseeko replacement on top of the
< Win32 API, and we have to make sure MinGW handles it. Another
< option is to wait for the MinGW project to fix it, or use the
< code from the LibGW32C project as a guide.
<
< http://archives.postgresql.org/pgsql-hackers/2006-12/msg00551.php
<
> o -Add long file support for binary pg_dump output
Tom Lane [Mon, 19 Feb 2007 07:03:34 +0000 (07:03 +0000)]
Get rid of some old and crufty global variables in the planner. When
this code was last gone over, there wasn't really any alternative to
globals because we didn't have the PlannerInfo struct being passed all
through the planner code. Now that we do, we can restructure things
to avoid non-reentrancy. I'm fooling with this because otherwise I'd
have had to add another global variable for the planned compact
range table list.
Tom Lane [Mon, 19 Feb 2007 02:23:12 +0000 (02:23 +0000)]
Put function expressions and values lists into FunctionScan and ValuesScan
plan nodes, so that the executor does not need to get these items from
the range table at runtime. This will avoid needing to include these
fields in the compact range table I'm expecting to make the executor use.
Tom Lane [Sun, 18 Feb 2007 19:49:25 +0000 (19:49 +0000)]
Fix portal management code to support non-default command completion tags for
portals using PORTAL_UTIL_SELECT strategy. This is currently significant only
for FETCH queries, which are supposed to include a count in the tag. Seems
it's been broken since 7.4, but nobody noticed before Knut Lehre.
Bruce Momjian [Sun, 18 Feb 2007 01:34:35 +0000 (01:34 +0000)]
Update wording:
< Currently, ALTER USER and ALTER DATABASE support per-user and
> Currently ALTER USER and ALTER DATABASE support per-user and
< Currently, subtracting one date from another that crosses a
> Currently subtracting one date from another that crosses a
< Currently, SQL-language functions can only refer to parameters via $1, etc
> Currently SQL-language functions can only refer to dollar parameters,
> e.g. $1
< Currently, queries prepared via the libpq API are planned on first
> Currently queries prepared via the libpq API are planned on first
< Currently, SET <tab> causes a database lookup to check all
> Currently SET <tab> causes a database lookup to check all
< Currently, all statement results are transferred to the libpq
> Currently all statement results are transferred to the libpq
Tom Lane [Sat, 17 Feb 2007 19:33:32 +0000 (19:33 +0000)]
Add code so that when COPY_PARSE_PLAN_TREES is defined, the copy and
equal functions are checked for raw parse trees as well as post-analysis
trees. This was never very important before, but the upcoming plan cache
control module will need to be able to do copyObject() on raw parse trees.
Bruce Momjian [Sat, 17 Feb 2007 03:11:32 +0000 (03:11 +0000)]
Remove rint() for to_char MS and US output. We can't us rint() because
we can't overflow to the next higher units, and we might print the lower
units for MS.
Bruce Momjian [Sat, 17 Feb 2007 01:35:41 +0000 (01:35 +0000)]
Add:
>
> o Allow row and record variables to be set to NULL constants,
> and allow NULL tests on such variables
>
> Because a row is not scalar, do not allow assignment
> from NULL-valued scalars.
Tom Lane [Fri, 16 Feb 2007 23:32:08 +0000 (23:32 +0000)]
Teach find_nonnullable_rels to handle OR cases: if every arm of an OR
forces a particular relation nonnullable, then we can say that the OR does.
This is worth a little extra trouble since it may allow reduction of
outer joins to plain joins.
Tom Lane [Fri, 16 Feb 2007 22:04:02 +0000 (22:04 +0000)]
Fix new RI operator selection code to do the right thing when working with
an opclass for a generic type such as ANYARRAY. The original coding failed
to check that PK and FK columns were of the same array type. Per discussion
with Tom Dunstan. Also, make the code a shade more readable by not trying
to economize on variables.
Bruce Momjian [Fri, 16 Feb 2007 21:34:04 +0000 (21:34 +0000)]
Reduce the amount of memory "clobbered" for every process title change,
on platforms that need this. This is done by only writing past the
previously stored message, if it was longer.
Tom Lane [Fri, 16 Feb 2007 20:57:19 +0000 (20:57 +0000)]
Adjust the definition of is_pushed_down so that it's always true for INNER
JOIN quals, just like WHERE quals, even if they reference every one of the
join's relations. Now that we can reorder outer and inner joins, it's
possible for such a qual to end up being assigned to an outer join plan node,
and we mustn't have it treated as a join qual rather than a filter qual for
the node. (If it were, the join could produce null-extended rows that it
shouldn't.) Per bug report from Pelle Johansson.
Alvaro Herrera [Fri, 16 Feb 2007 17:49:15 +0000 (17:49 +0000)]
Install a more correct fix in the timestamp and timestamptz regression tests:
remove duplicated tests in timestamp, and complete timestamptz with the tests
that were missing to more closely mirror timestamp.
Alvaro Herrera [Fri, 16 Feb 2007 15:42:42 +0000 (15:42 +0000)]
Fix the timestamptz test problem, by moving the tests that use the
timestamp_tbl table into the timestamp test. Also, restore a test that
used to exist as a valid test in the timestamptz test.
Tom Lane [Fri, 16 Feb 2007 03:49:04 +0000 (03:49 +0000)]
Fix another problem in 8.2 changes that allowed "one-time" qual conditions to
be checked at plan levels below the top; namely, we have to allow for Result
nodes inserted just above a nestloop inner indexscan. Should think about
using the general Param mechanism to pass down outer-relation variables, but
for the moment we need a back-patchable solution. Per report from Phil Frost.
Bruce Momjian [Fri, 16 Feb 2007 02:59:41 +0000 (02:59 +0000)]
SSL improvements:
o read global SSL configuration file
o add GUC "ssl_ciphers" to control allowed ciphers
o add libpq environment variable PGSSLKEY to control SSL hardware keys
Tom Lane [Fri, 16 Feb 2007 00:14:01 +0000 (00:14 +0000)]
Restructure code that is responsible for ensuring that clauseless joins are
considered when it is necessary to do so because of a join-order restriction
(that is, an outer-join or IN-subselect construct). The former coding was a
bit ad-hoc and inconsistent, and it missed some cases, as exposed by Mario
Weilguni's recent bug report. His specific problem was that an IN could be
turned into a "clauseless" join due to constant-propagation removing the IN's
joinclause, and if the IN's subselect involved more than one relation and
there was more than one such IN linking to the same upper relation, then the
only valid join orders involve "bushy" plans but we would fail to consider the
specific paths needed to get there. (See the example case added to the join
regression test.) On examining the code I wonder if there weren't some other
problem cases too; in particular it seems that GEQO was defending against a
different set of corner cases than the main planner was. There was also an
efficiency problem, in that when we did realize we needed a clauseless join
because of an IN, we'd consider clauseless joins against every other relation
whether this was sensible or not. It seems a better design is to use the
outer-join and in-clause lists as a backup heuristic, just as the rule of
joining only where there are joinclauses is a heuristic: we'll join two
relations if they have a usable joinclause *or* this might be necessary to
satisfy an outer-join or IN-clause join order restriction. I refactored the
code to have just one place considering this instead of three, and made sure
that it covered all the cases that any of them had been considering.
Backpatch as far as 8.1 (which has only the IN-clause form of the disease).
By rights 8.0 and 7.4 should have the bug too, but they accidentally fail
to fail, because the joininfo structure used in those releases preserves some
memory of there having once been a joinclause between the inner and outer
sides of an IN, and so it leads the code in the right direction anyway.
I'll be conservative and not touch them.
Alvaro Herrera [Thu, 15 Feb 2007 23:23:23 +0000 (23:23 +0000)]
Restructure autovacuum in two processes: a dummy process, which runs
continuously, and requests vacuum runs of "autovacuum workers" to postmaster.
The workers do the actual vacuum work. This allows for future improvements,
like allowing multiple autovacuum jobs running in parallel.
For now, the code keeps the original behavior of having a single autovac
process at any time by sleeping until the previous worker has finished.
Tom Lane [Thu, 15 Feb 2007 03:07:13 +0000 (03:07 +0000)]
Repair oversight in 8.2 change that improved the handling of "pseudoconstant"
WHERE clauses. createplan.c is now willing to stick a gating Result node
almost anywhere in the plan tree, and in particular one can wind up directly
underneath a MergeJoin node. This means it had better be willing to handle
Mark/Restore. Fortunately, that's trivial in such cases, since we can just
pass off the call to the input node (which the planner has previously ensured
can handle Mark/Restore). Per report from Phil Frost.