Brendan Cully [Mon, 20 Oct 2008 17:21:25 +0000 (10:21 -0700)]
Hack around INBOX.INBOX breakage from [
5d1cc2f0c1c4]
Vincent Lefevre [Mon, 20 Oct 2008 17:00:13 +0000 (18:00 +0100)]
Make eat_regexp static.
Kyle Wheeler [Mon, 20 Oct 2008 16:55:27 +0000 (09:55 -0700)]
Fix #3129
Brendan Cully [Mon, 20 Oct 2008 16:48:57 +0000 (09:48 -0700)]
Call imap_free_idata instead of freeing directly in imap_logout
Brendan Cully [Mon, 20 Oct 2008 16:33:52 +0000 (09:33 -0700)]
Fix memory leak in imap_mailbox_state
TAKAHASHI Tamotsu [Sun, 19 Oct 2008 23:26:29 +0000 (16:26 -0700)]
Fix up destination path when renaming mailbox. Closes #2090.
Brendan Cully [Sun, 19 Oct 2008 23:14:06 +0000 (16:14 -0700)]
Normalize path component of IMAP URLs in imap_expand_path (see #2897).
Brendan Cully [Sun, 19 Oct 2008 19:41:55 +0000 (12:41 -0700)]
Fix buglet in logging from previous commit
Brendan Cully [Sun, 19 Oct 2008 19:39:23 +0000 (12:39 -0700)]
Handle short writes in mutt_socket_write_d. See #3000.
Apparently even blocking I/O with signals masked can sometimes return
early.
Based on a patch by Patrick Welche.
Emanuele Giaquinta [Sun, 19 Oct 2008 13:14:14 +0000 (15:14 +0200)]
Remove unused functions.
Emanuele Giaquinta [Sat, 18 Oct 2008 23:50:37 +0000 (01:50 +0200)]
Make some variables static.
Emanuele Giaquinta [Sat, 18 Oct 2008 23:39:44 +0000 (01:39 +0200)]
Fix logic in [
13a831a945be].
Brendan Cully [Wed, 8 Oct 2008 02:22:53 +0000 (19:22 -0700)]
Clean up with/without-idn handling
Emanuele Giaquinta [Tue, 7 Oct 2008 22:58:24 +0000 (15:58 -0700)]
Minor simplification in mutt_socket_readln_d
Brendan Cully [Tue, 7 Oct 2008 22:27:28 +0000 (15:27 -0700)]
Build no-op versions of new IDN functions if IDN is unavailable.
Closes #3122, #3123.
Brendan Cully [Wed, 1 Oct 2008 16:33:39 +0000 (09:33 -0700)]
Clean up autoconf header cache engine selection.
Any explicit --with-$engine will force that engine to be used or make
configure fail if the engine is unavailable.
Emanuele Giaquinta [Mon, 29 Sep 2008 21:31:45 +0000 (14:31 -0700)]
Simplify host resolution code slightly.
Rocco Rutte [Fri, 26 Sep 2008 06:55:49 +0000 (08:55 +0200)]
Mention tokyocabinet in UPDATING and docs
Emanuele Giaquinta [Thu, 25 Sep 2008 22:07:16 +0000 (15:07 -0700)]
Support tokyocabinet (successor to qdbm). Closes #3112
Matthias Andree [Wed, 24 Sep 2008 13:58:22 +0000 (15:58 +0200)]
Fix compiler warning in dprint() (closes #3120)
Rocco Rutte [Wed, 24 Sep 2008 13:53:24 +0000 (15:53 +0200)]
Manual: Fix typo
Rocco Rutte [Wed, 24 Sep 2008 10:31:44 +0000 (12:31 +0200)]
Provide legacy implementations for iswalpha() and iswupper()
In mbyte.h and without using wc functions, only the prototypes were
defined but implementations were missing resulting in build
errors. These new functions are derived from the iswalnum() and
towupper() routines which don't provide full unicode coverage.
Rocco Rutte [Wed, 24 Sep 2008 10:28:16 +0000 (12:28 +0200)]
Fix an infinite loop for imap searches
Reported by Emanuele Giaquinta on #mutt.
Rocco Rutte [Thu, 18 Sep 2008 06:28:51 +0000 (08:28 +0200)]
Fix compiler warnings
Thomas Roessler [Wed, 17 Sep 2008 20:27:43 +0000 (22:27 +0200)]
sorting efficiency
Rocco Rutte [Tue, 16 Sep 2008 15:20:12 +0000 (17:20 +0200)]
UPDATING: $move now defaults to "no"
Rocco Rutte [Thu, 11 Sep 2008 07:28:10 +0000 (09:28 +0200)]
Fix IMAP keepalive if $imap_keepalive >= $timeout
Rocco Rutte [Mon, 1 Sep 2008 16:23:35 +0000 (18:23 +0200)]
Add note about locale-safe hcaches to UPDATING as it's a user-visible change
Rocco Rutte [Sun, 31 Aug 2008 21:36:36 +0000 (23:36 +0200)]
Fix pager to respect $wrap_search
Rocco Rutte [Sun, 31 Aug 2008 21:28:54 +0000 (23:28 +0200)]
Backout [
e5610347fb3f] for further discussion
Rocco Rutte [Sun, 31 Aug 2008 19:13:06 +0000 (21:13 +0200)]
Manual: Fix trailing \ for $preconnect
Rocco Rutte [Sun, 31 Aug 2008 19:12:19 +0000 (21:12 +0200)]
makedoc: Fix fall-through in [
c11ce7feaa3e]
Rocco Rutte [Sun, 31 Aug 2008 18:56:28 +0000 (20:56 +0200)]
Manual: Harmonize generated function mappings with the rest of the manual.
This includes named keys such as "<Return>", attempts to use CamelCase
and leaves the key column for unbound functions empty so they're
visually easier to spot.
Rocco Rutte [Sun, 31 Aug 2008 18:12:20 +0000 (20:12 +0200)]
Manual: Many content+markup improvements for option documentation
Rocco Rutte [Sun, 31 Aug 2008 17:30:01 +0000 (19:30 +0200)]
makedoc: Also replace | and ^ by entities in XML output
Rocco Rutte [Sun, 31 Aug 2008 16:25:48 +0000 (18:25 +0200)]
makedoc: Escape <>& in <screen/> environments
Rocco Rutte [Sun, 31 Aug 2008 13:27:11 +0000 (15:27 +0200)]
Manual: Use <quote/> quoting for DocBook rather than ``''.
All quotes characters are now rendered to Unicode quote chars
in the HTML output (as <xref/> does, too) but still " for
manual.txt.
Rocco Rutte [Sun, 31 Aug 2008 12:31:32 +0000 (14:31 +0200)]
Manual: Limit toc section depth to 1
This only lists sect1 items and prevents variables from being
shown making it unusable.
Rocco Rutte [Sun, 31 Aug 2008 12:25:45 +0000 (14:25 +0200)]
Manual: use itemizedlist for acknowledgements
DocBook XSL renders simplelist to a html table which is inappropriate.
Brendan Cully [Sun, 31 Aug 2008 03:21:45 +0000 (20:21 -0700)]
Make gnutls read function more robust against interruptions.
Signals should be masked off anyway, but see #3074.
Brendan Cully [Sun, 31 Aug 2008 03:00:06 +0000 (20:00 -0700)]
Merge with Rocco
Brendan Cully [Sun, 31 Aug 2008 02:59:42 +0000 (19:59 -0700)]
Rework timeout handling to support keepalive in the line editor.
Also allow keepalives of less than $timeout without returning before
$timeout, so people who don't want to be notified of new mail don't
have to be.
Rocco Rutte [Sat, 30 Aug 2008 21:19:31 +0000 (23:19 +0200)]
Manual: use $variable syntax, only quote non-variable links
Rocco Rutte [Sat, 30 Aug 2008 20:08:11 +0000 (22:08 +0200)]
Manual: Various fixes+improvements in chapters 1+2
Rocco Rutte [Sat, 30 Aug 2008 19:25:25 +0000 (21:25 +0200)]
Manual: Layout functions as <function-name>, s/ESC/Esc/ for consistency
Rocco Rutte [Sat, 30 Aug 2008 18:58:49 +0000 (20:58 +0200)]
makedoc: Add support for monospace fonts with \fC...\fP
Rocco Rutte [Sat, 30 Aug 2008 18:00:42 +0000 (20:00 +0200)]
Manual: trim trailing whitespace
Rocco Rutte [Sat, 30 Aug 2008 17:17:43 +0000 (19:17 +0200)]
Manual: Fix processing warnings by manually assigning missing id attributes
Rocco Rutte [Sat, 30 Aug 2008 16:36:21 +0000 (18:36 +0200)]
Manual: Add a section on mutt core concepts as introduction
Rado Smiljanic [Sat, 30 Aug 2008 06:10:50 +0000 (23:10 -0700)]
Make curses timeout the minimum of $timeout and $imap_keepalive.
Do keepalive in km_dokey instead of directly in menu. Closes #2747.
Brendan Cully [Sat, 30 Aug 2008 05:40:19 +0000 (22:40 -0700)]
Dead code
Brendan Cully [Sat, 30 Aug 2008 01:18:59 +0000 (18:18 -0700)]
Remove redundant code
Brendan Cully [Fri, 29 Aug 2008 23:54:56 +0000 (16:54 -0700)]
Use sorted headers in imap_exec_msgset. Fixes [
e68f79fef249].
Closes #3000 again.
YONETANI Tomokazu [Fri, 29 Aug 2008 08:23:28 +0000 (10:23 +0200)]
Only consider empty files non-existent for buffy's purpose.
According to SUS, the st_size member of struct stat is undefined
for directories. In case a system reports 0, the newly_created
flag will be set for a directory and the magic will be cleared.
If the folder type is cleared, mutt won't check the folder for
new mail and thus will ignore MH and Maildir type folders on
such a fs completely (e.g. the HAMMER fs on DragonFly BSD).
Brendan Cully [Thu, 28 Aug 2008 18:19:36 +0000 (11:19 -0700)]
The msgset changes seem buggy. Reverting pending further testing.
Brendan Cully [Thu, 28 Aug 2008 09:31:14 +0000 (02:31 -0700)]
Split long IMAP commands for the benefit of lazy servers (closes #3000).
Also touches lots of old, hairy code. Likely to wake sleeping dogs.
Brendan Cully [Wed, 27 Aug 2008 06:09:13 +0000 (23:09 -0700)]
Properly set the SASL external auth name when using SSL client certs.
Also zero out the account structure before filling it with available
data. Client certificates + SASL EXTERNAL were only working by luck.
Brendan Cully [Tue, 26 Aug 2008 09:07:21 +0000 (02:07 -0700)]
Remove leftover IMAP IDLE handling from before [
53d9210aa4ee].
Brendan Cully [Mon, 25 Aug 2008 07:52:17 +0000 (00:52 -0700)]
Introduce $imap_pipeline_depth.
This lets users control the number of commands that mutt will queue up
before sending them to the server. Setting this to 0 disables
pipelining, which should close #2892.
Brendan Cully [Mon, 25 Aug 2008 07:16:30 +0000 (00:16 -0700)]
Rework IMAP command queueing to allow pipelining to be disabled.
IDLE handling has been better abstracted, and there are fewer entry
points to the IMAP command issuing machinery. Any commands that
are simply queued may be executed whenever the pipeline fills,
instead of requiring explicit handling in the caller.
Tested on my Cyrus server, but I wouldn't be surprise if this causes
new problems.
Rocco Rutte [Sun, 24 Aug 2008 18:01:31 +0000 (20:01 +0200)]
Manual: Fix DTD validation error and message header display section
Rocco Rutte [Sun, 24 Aug 2008 15:06:30 +0000 (17:06 +0200)]
Manual: Fix typo
Rocco Rutte [Sun, 24 Aug 2008 15:03:42 +0000 (17:03 +0200)]
Manual: Fix style and typos.
Noted by Vincent Lefevre, see #3109.
Brendan Cully [Sat, 23 Aug 2008 22:25:49 +0000 (15:25 -0700)]
Whitespace cleanup
Brendan Cully [Sat, 23 Aug 2008 22:21:42 +0000 (15:21 -0700)]
Fix infinite loop with "mutt -", introduced in [
31c9e9727d42].
Treats - as a non-option argument. It would be reasonable to treat it
as an error instead.
Aron Griffis [Tue, 19 Aug 2008 20:44:26 +0000 (16:44 -0400)]
Handle -- correctly with or without -a, closes #3097
Prefix optstring with "+" to force POSIX behavior on GNU getopt, and thereby
prevent reordering argv. This allows us to correctly handle mixed addresses,
attachments, options and the double-dash to signal end-of-options.
Signed-off-by: Aron Griffis <agriffis@n01se.net>
Rocco Rutte [Fri, 22 Aug 2008 15:49:07 +0000 (17:49 +0200)]
Manual: fix/improve markup/content, see #3109
Rocco Rutte [Thu, 21 Aug 2008 08:42:31 +0000 (10:42 +0200)]
Clarify documentation for $config_charset.
Closes #2021.
Rocco Rutte [Thu, 21 Aug 2008 08:30:48 +0000 (10:30 +0200)]
Improve color/mono command synopsis.
Closes #2630.
Rocco Rutte [Thu, 21 Aug 2008 07:36:56 +0000 (09:36 +0200)]
Better document the effect of $thorough_search being unset.
Closes #3104.
Rocco Rutte [Thu, 21 Aug 2008 05:33:52 +0000 (07:33 +0200)]
Port certificate host checking from msmtp to mutt.
It supports IDN, wildcards and extracting the hostname from
subject alternative field as well as common name which should
be the same gnutls supports. Closes #3087.
Brendan Cully [Tue, 19 Aug 2008 20:17:18 +0000 (13:17 -0700)]
Silence an incorrect uninitialized variable warning.
Brendan Cully [Tue, 19 Aug 2008 20:14:51 +0000 (13:14 -0700)]
Better documentation for how quote_regexp determines quote level.
Closes #1463.
Rocco Rutte [Tue, 19 Aug 2008 07:39:44 +0000 (09:39 +0200)]
Make text/enriched handler multibyte aware. Closes #3033.
Vincent Lefevre [Mon, 18 Aug 2008 20:08:43 +0000 (13:08 -0700)]
Updated French translation.
Rocco Rutte [Mon, 18 Aug 2008 08:24:20 +0000 (10:24 +0200)]
Ignore zero width characters U+200B/U+FEFF which may garble the display. Closes #3061, #3048.
Rocco Rutte [Mon, 18 Aug 2008 08:20:40 +0000 (10:20 +0200)]
Validate charset names for all charset options.
Validation is either done against mutt's table of IANA assigned names or local iconv
implementation (based on the assumption that iconv_open(charset,charset) fails if charset
is unknown to the implementation). Closes #1668.
Brendan Cully [Fri, 15 Aug 2008 18:53:14 +0000 (11:53 -0700)]
Fix type-punning warning in sasl_getprop usage
Brendan Cully [Fri, 15 Aug 2008 18:41:26 +0000 (11:41 -0700)]
Fix a couple of compiler warnings introduced in [
00ce81d778bf].
Make the style of mutt_parse_references more pleasing to me.
Aron Griffis [Thu, 10 Jul 2008 13:38:25 +0000 (09:38 -0400)]
Fix three bugs handling flags in mutt_copy_header
1. mutt_copy_header incorrectly tests CH_UPDATE to determine whether to write
the In-Reply-To and References headers. CH_UPDATE refers only to Status: and
X-Status:
2. mutt_copy_header ignores CH_NOSTATUS which is supposed to indicate that the
mailbox type doesn't use those headers.
3. mutt_copy_header tests h->env->irt_changed and h->env->refs_changed when it
should be testing CH_UPDATE_IRT and CH_UPDATE_REFS, respectively. Early in
the function this happens:
if (h->env)
flags |= (h->env->irt_changed ? CH_UPDATE_IRT : 0)
| (h->env->refs_changed ? CH_UPDATE_REFS : 0);
This means that for most callers, the result is the same, but
mutt_copy_header should be testing the flags because the caller might have
set them explicitly without setting irt_changed/refs_changed.
Signed-off-by: Aron Griffis <agriffis@n01se.net>
Aron Griffis [Thu, 10 Jul 2008 23:30:00 +0000 (19:30 -0400)]
Unify parser for message-ids
Rewrite mutt_extract_message_id and change mutt_parse_references to us it. The
parser in mutt_extract_message_id is looser than the old one in
mutt_parse_references; it just looks for <[^\s>]+> and doesn't worry about
@-signs. Additionally it doesn't use strtok, so the input string can be const.
Closes #3090, #1935, #1116 (both the stated bug and the conversation following).
Signed-off-by: Aron Griffis <agriffis@n01se.net>
Rocco Rutte [Mon, 11 Aug 2008 14:42:06 +0000 (16:42 +0200)]
Prefer "backtick" over "backtic" on comments and docs as it's more common, closes #3101.
Aron Griffis [Sun, 27 Jul 2008 14:48:45 +0000 (10:48 -0400)]
doc: semi-colon needs quoting too
If semi-colon is bound or macro'd, it needs to be quoted like space, otherwise
mutt thinks it's separating commands.
Signed-off-by: Aron Griffis <agriffis@n01se.net>
Rocco Rutte [Fri, 25 Jul 2008 17:24:22 +0000 (19:24 +0200)]
Merge with brendan
Rocco Rutte [Fri, 25 Jul 2008 17:23:21 +0000 (19:23 +0200)]
Document that my_ variables aren't expanded in backticks, too
Vincent Lefevre [Tue, 22 Jul 2008 14:30:42 +0000 (16:30 +0200)]
Fix typos in manual.xml.head and init.h. Closes #3096.
Aron Griffis [Mon, 21 Jul 2008 14:24:58 +0000 (10:24 -0400)]
noop cleanup: move mutt_copy_header flags to copy.h
Noticed while reading that these flags are better defined in copy.h than mutt.h.
Builds without warnings.
Signed-off-by: Aron Griffis <agriffis@n01se.net>
Brendan Cully [Thu, 24 Jul 2008 20:19:56 +0000 (16:19 -0400)]
Fix m4 serial numbers to avoid aclocal 1.10 warnings
Brendan Cully [Thu, 24 Jul 2008 16:15:29 +0000 (12:15 -0400)]
Remove variables no longer used since [
7729b1ad530c]
Brendan Cully [Thu, 24 Jul 2008 16:13:03 +0000 (12:13 -0400)]
Disable GCC long long warnings with -pedantic. Closes #2823.
Thanks to Aron Griffis for the suggestion.
Rocco Rutte [Mon, 21 Jul 2008 09:53:42 +0000 (11:53 +0200)]
Use itemized lists for listing possible sort config settings.
Rocco Rutte [Mon, 21 Jul 2008 09:42:27 +0000 (11:42 +0200)]
makedoc: Add ".ie" and ".il" to support itemized lists.
Some settings docs use verbatim screen environments to print
lists while support for real lists will make it look nicer:
for docbook use <itemizedlist/>, \(hy for roff and '-' for text.
Rocco Rutte [Mon, 21 Jul 2008 09:41:38 +0000 (11:41 +0200)]
Document that account-hook is intended for connection-related settings only
Rocco Rutte [Mon, 21 Jul 2008 09:40:44 +0000 (11:40 +0200)]
Manual: Use tables for message flags as it's more compact
Rocco Rutte [Mon, 21 Jul 2008 09:40:07 +0000 (11:40 +0200)]
Manual: minor formatting tweaks
Rocco Rutte [Mon, 21 Jul 2008 07:11:40 +0000 (09:11 +0200)]
Encode lines written to $alias_file in $config_charset if set. Closes #3095
Aron Griffis [Thu, 10 Jul 2008 13:38:25 +0000 (09:38 -0400)]
Unify mutt_write_references
copy.c and sendlib.c have independent and different implementations of writing
references to a file. Choose the one in sendlib since it's conservative with
mallocs and supports trimming the list.
Signed-off-by: Aron Griffis <agriffis@n01se.net>
Aron Griffis [Thu, 10 Jul 2008 13:38:25 +0000 (09:38 -0400)]
Clean up error handling in mutt_copy_header
mutt_copy_header unnecessarily tests the result of each fputc/fputs (well, most
of them anyway, it's not consistent). This obfuscates the code and hides bugs.
Remove these extraneous checks since ferror/feof are checked at the bottom of
the function, and get rid of all the early returns.
Signed-off-by: Aron Griffis <agriffis@n01se.net>
Rocco Rutte [Thu, 17 Jul 2008 17:48:16 +0000 (19:48 +0200)]
Cleanup unused vars changeset
ba0d96408425 didn't remove
Rocco Rutte [Fri, 11 Jul 2008 09:34:42 +0000 (11:34 +0200)]
Mention that @ can be used in usernames in URLs