]> granicus.if.org Git - icu/log
icu
3 years agoICU-21668 Fix nickel rounding with away-from-zero rounding mode
Shane F. Carr [Tue, 14 Sep 2021 08:08:10 +0000 (08:08 +0000)]
ICU-21668 Fix nickel rounding with away-from-zero rounding mode

See #1814

3 years agoICU-21684 Fix performance issue in NumberRangeFormatter cldr/2021-09-15
Shane F. Carr [Wed, 15 Sep 2021 05:39:06 +0000 (00:39 -0500)]
ICU-21684 Fix performance issue in NumberRangeFormatter

3 years agoICU-21675 Add Infinity and NaN tests for NumberRangeFormatter
Shane F. Carr [Wed, 15 Sep 2021 06:34:01 +0000 (01:34 -0500)]
ICU-21675 Add Infinity and NaN tests for NumberRangeFormatter

3 years agoICU-21749 Fix stack-use-after-scope bug in uloc
Frank Tang [Sat, 11 Sep 2021 03:46:00 +0000 (03:46 +0000)]
ICU-21749 Fix stack-use-after-scope bug in uloc

See #1858

3 years agoICU-21752 fix wrong link of howtouseicu
Jacky_Yin [Fri, 10 Sep 2021 06:34:16 +0000 (14:34 +0800)]
ICU-21752 fix wrong link of howtouseicu

3 years agoICU-21662 UVector Error Handling in Regex
Andy Heninger [Fri, 10 Sep 2021 21:59:46 +0000 (14:59 -0700)]
ICU-21662 UVector Error Handling in Regex

Clean up some oversights from commit 0ec329c. This was triggered by fuzz testing finding
a memory leak with the original commit, see https://oss-fuzz.com/testcase-detail/4656781834452992

I was unable to replicate the fuzzing failure, but reviewing the nearby code showed
some likely problems.

In this commit,
- Fix UStack::pop() to not delete the popped element when a deleter function is present.
  This was a bug, but because there were no stacks with deleters, was not causing trouble.

- Change RegexCompile::compileSet() to delete the set if it cannot be added to the internal
  vector of sets. I suspect this is the cause of the fuzzing leak - 0ec329c changed the
  behavior of UVector in the presence of errors.

- Changed RegexCompile::fSetStack to use an object deleter function. This fixes the
  leak checking at the points new elements are pushed onto this stack.

3 years agoICU-21669 UPRV_UNREACHABLE > UPRV_UNREACHABLE_EXIT/ASSERT, update usages
Peter Edberg [Tue, 14 Sep 2021 05:46:55 +0000 (22:46 -0700)]
ICU-21669 UPRV_UNREACHABLE > UPRV_UNREACHABLE_EXIT/ASSERT, update usages

3 years agoICU-21654 Fix skeleton output for rounding increment in C++
Shane F. Carr [Sat, 11 Sep 2021 06:48:58 +0000 (06:48 +0000)]
ICU-21654 Fix skeleton output for rounding increment in C++

See #1813

3 years agoICU-20870 Fix breakage on UCONFIG_NO_FORMATTING
Frank Tang [Mon, 13 Sep 2021 21:54:42 +0000 (14:54 -0700)]
ICU-20870 Fix breakage on UCONFIG_NO_FORMATTING

3 years agoICU-20870 If locale/lang name lookup fails, canonicalize lang and try again
Peter Edberg [Wed, 8 Sep 2021 22:20:48 +0000 (15:20 -0700)]
ICU-20870 If locale/lang name lookup fails, canonicalize lang and try again

3 years agoICU-21750 Output tail end of the uconfig variation test run in case of failure
gnrunge [Fri, 10 Sep 2021 20:15:17 +0000 (13:15 -0700)]
ICU-21750 Output tail end of the uconfig variation test run in case of failure
to allow easier identification of build or test failures.

3 years agoICU-13353 Fixed several problems preventing horizontal resource inheritance from...
Rich Gillam [Fri, 6 Aug 2021 21:00:41 +0000 (14:00 -0700)]
ICU-13353 Fixed several problems preventing horizontal resource inheritance from working as intended, and added a
Java version of a unit test I'd previously only added on the C++ side.

3 years agoICU-21735 Fixed two old references to UNUM_CURRENCY_CASH, one in a comment, one in...
Rich Gillam [Wed, 8 Sep 2021 22:53:34 +0000 (15:53 -0700)]
ICU-21735 Fixed two old references to UNUM_CURRENCY_CASH, one in a comment, one in a unit-test failure message--
to refer to the now-correct UNUM_CASH_CURRENCY.

3 years agoICU-21581 integrate CLDR release-40-alpha3 to ICU trunk
Peter Edberg [Thu, 9 Sep 2021 04:42:54 +0000 (21:42 -0700)]
ICU-21581 integrate CLDR release-40-alpha3 to ICU trunk

3 years agoICU-21662 Improve UVector error handling.
Andy Heninger [Thu, 2 Sep 2021 23:09:04 +0000 (16:09 -0700)]
ICU-21662 Improve UVector error handling.

This is the next installment of UVector error handling cleanup. It includes:

- Revise UStack to follow the conventions of UVector, to leave the stack
  unmodified when there is an incoming error code. And, for stacks with a
  deleter function, to delete the incoming object if it cannot be
  succesfully pushed.

 - Review all useage of UStack in ICU; adjust call sites as needed.

 - Review all uses of UVector::addElementX() in the implementation of
   - Regular Expressions
   - Break Iteration
   - toolutil/xmlparser

   changing to the updated functions, and adjusting call sites as needed.

3 years agoICU-21730 Port `testGetPreferencesFor` ICU4C tests to ICU4J
Younies [Wed, 8 Sep 2021 16:58:23 +0000 (16:58 +0000)]
ICU-21730 Port `testGetPreferencesFor` ICU4C tests to ICU4J

See #1850

3 years agoICU-21545 Add icuwriteuprops tool
Shane F. Carr [Wed, 1 Sep 2021 18:30:14 +0000 (18:30 +0000)]
ICU-21545 Add icuwriteuprops tool

See #1741

3 years agoICU-21652 add emoji properties of strings
Markus Scherer [Fri, 3 Sep 2021 21:53:25 +0000 (14:53 -0700)]
ICU-21652 add emoji properties of strings
- 7 new properties: API constants & property names
- u_stringHasBinaryProperty(s, property) & UCharacter.hasBinaryProperty(s, property)
- two additional source data files
- new genprops part for writing new binary data file uemoji.icu
- data for existing emoji properties moved from uprops.icu (hardcoded in C++) to uemoji.icu (always loaded)
- new EmojiProps implementation

3 years agoICU-21685 In list of currencies from ucurr_openISOCurrencies(): add VES, remove EQE
Peter Edberg [Fri, 23 Jul 2021 06:24:51 +0000 (23:24 -0700)]
ICU-21685 In list of currencies from ucurr_openISOCurrencies(): add VES, remove EQE

3 years agoICU-21734 Add -Wsuggest-override to Build only WarningsAsErrors buildbot
Frank Tang [Wed, 8 Sep 2021 01:26:53 +0000 (01:26 +0000)]
ICU-21734 Add -Wsuggest-override to  Build only WarningsAsErrors buildbot

See #1842

3 years agoICU-21630 Ignore .DS_Store files
Leander Schulten [Fri, 28 May 2021 12:06:52 +0000 (14:06 +0200)]
ICU-21630 Ignore .DS_Store files

3 years agoICU-21741 remove redundant html tag: </pre>
Jacky_Yin [Tue, 31 Aug 2021 11:01:57 +0000 (11:01 +0000)]
ICU-21741 remove redundant html tag: </pre>

See #1838

3 years agoICU-21734 Add missing overrides
Peter Varga [Thu, 26 Aug 2021 08:26:58 +0000 (10:26 +0200)]
ICU-21734 Add missing overrides

3 years agoICU-21734 Add missing overrides to pure virtual methods
Peter Varga [Thu, 2 Sep 2021 07:26:11 +0000 (09:26 +0200)]
ICU-21734 Add missing overrides to pure virtual methods

These methods are pure virtual in the base class too.

3 years agoICU-21734 Add missing overrides in tests
Peter Varga [Thu, 2 Sep 2021 08:45:26 +0000 (10:45 +0200)]
ICU-21734 Add missing overrides in tests

3 years agoICU-20992 Added new API for iterating child resources while following aliases, and...
Rich Gillam [Sat, 24 Jul 2021 00:18:41 +0000 (17:18 -0700)]
ICU-20992 Added new API for iterating child resources while following aliases, and changed DateTimePatternGenerator
to use it.

3 years agoICU-21460 Changed the ULocale initializers to allow locale IDs that use BCP47 syntax...
Rich Gillam [Tue, 17 Aug 2021 23:28:32 +0000 (16:28 -0700)]
ICU-21460 Changed the ULocale initializers to allow locale IDs that use BCP47 syntax, but with '_' as a field delimiter.
(APIs that specifically require BCP47 syntax are unaffected-- they still require '-').

3 years agoICU-21727 Commit Checker: add Reviewer: header
Steven R. Loomis [Tue, 31 Aug 2021 22:59:44 +0000 (17:59 -0500)]
ICU-21727 Commit Checker: add Reviewer: header

3 years agoICU-21038 Run ICU4J localespiCheck as a part of CI build
Yoshito Umaoka [Thu, 26 Aug 2021 21:41:47 +0000 (21:41 +0000)]
ICU-21038 Run ICU4J localespiCheck as a part of CI build

See #1797

3 years agoICU-21530 Added U_HIDE_DEPRECATED_API to deprecated methods.
yumaoka [Thu, 2 Sep 2021 22:03:41 +0000 (22:03 +0000)]
ICU-21530 Added U_HIDE_DEPRECATED_API to deprecated methods.

3 years agoICU-21662 Improve UVector error handling.
Andy Heninger [Wed, 28 Jul 2021 18:20:53 +0000 (11:20 -0700)]
ICU-21662 Improve UVector error handling.

- Add updated versions of UVector::addElement() and ensureCapacity() that respect
  incoming errors.
  Follow on to c26aebe, which renamed the original versions.

- Add UVector::adoptElement() as a replacement for addElement() when the vector
  has a deleter function set, meaning that it adopts ownership of its elements.

  The intent is to make the behavior clearer at the call sites when looking
  at unfamiliar code.

- Make all functions with an incoming failure, as indicated by a UErrorCode parameter,
  leave the vector unchanged.

- Change all functions that store object pointers into the vector such that,
  when the store cannot be completed for any reason _and_ the vector has a deleter function,
  then the incoming object is deleted.

  This change can simplify the error handling code around calls to the affected functions
  (addElement() and insertElementAt(), in particular)

- Add index bounds checking on functions where it was possible - that is, on functions
  with both U_ErrorCode and index parameters.

- Changed to more modern C++ idioms in some parts of the UVector implementation.

- Review & update as required all uses of the UVector functions
  setElementAt(), insertElementAt(), setSize(), sortedInsert()
  these being the functions with changed behavior on error conditions
  (aside from addElement()).

This PR will be followed by more, switching call sites in various ICU services
from UVector::addElementX() (old behavior on errors)
to   UVector::addElement()  (new behavior on errors)

3 years agoICU-21551 Fixing unit prefix normalization order to match LDML spec
Younies Mahmoud [Tue, 31 Aug 2021 16:40:17 +0000 (16:40 +0000)]
ICU-21551 Fixing unit prefix normalization order to match LDML spec

See #1754

3 years agoICU-21747 Add check for expectedBreakCount in Java
Jeff Genovy [Wed, 1 Sep 2021 23:27:52 +0000 (16:27 -0700)]
ICU-21747 Add check for expectedBreakCount in Java

3 years agoICU-21747 Upgrade WarningsAsErrors build bot to Clang-13 on Ubuntu 20.04
Jeff Genovy [Wed, 1 Sep 2021 21:01:00 +0000 (14:01 -0700)]
ICU-21747 Upgrade WarningsAsErrors build bot to Clang-13 on Ubuntu 20.04

3 years agoICU-21581 integrate CLDR release-40-alpha2 to ICU trunk
Peter Edberg [Wed, 1 Sep 2021 21:00:29 +0000 (14:00 -0700)]
ICU-21581 integrate CLDR release-40-alpha2 to ICU trunk

3 years agoICU-20769 getAliasTargetAsResourceBundle() only needs ResourceData
Markus Scherer [Wed, 1 Sep 2021 16:35:43 +0000 (09:35 -0700)]
ICU-20769 getAliasTargetAsResourceBundle() only needs ResourceData

3 years agoICU-21740 Output source code line when an error occurs when building with MSVC.
Jeff Genovy [Mon, 30 Aug 2021 20:15:08 +0000 (13:15 -0700)]
ICU-21740 Output source code line when an error occurs when building with MSVC.

3 years agoICU-21579 Fix compiler warnings with MSVC.
Jeff Genovy [Mon, 30 Aug 2021 20:57:01 +0000 (13:57 -0700)]
ICU-21579 Fix compiler warnings with MSVC.

3 years agoICU-21730 Check unit aliases support.
Younies [Tue, 31 Aug 2021 13:13:13 +0000 (13:13 +0000)]
ICU-21730 Check unit aliases support.

See #1804

3 years agoICU-20769 refactor UResourceBundle.fResData & init_resb_result()
Markus Scherer [Thu, 26 Aug 2021 21:44:49 +0000 (14:44 -0700)]
ICU-20769 refactor UResourceBundle.fResData & init_resb_result()
- replace UResourceBundle.fResData with access via fData
- change ResourceDataValue.resData into a pointer
- move C tests to C++ that stack-allocate now-C++ UResourceBundle
- init_resb_result():
  - remove redundant ResourceData parameter
  - simplify memory management, and various small simplifications
  - /LOCALE/path reuse valid locale, no ures_open()
  - pull alias-fetching code into separate function getAliasTargetAsResourceBundle()
  - `const char *` for keyPath pieces
  - s/noAlias/recursionDepth/
- getAllItemsWithFallback() set correct parentBundle.fValidLocaleDataEntry

3 years agoICU-21671 Corrected a bug in SimpleDateFormat.subParse() that was causing us to alway...
Rich Gillam [Sat, 28 Aug 2021 00:03:22 +0000 (17:03 -0700)]
ICU-21671 Corrected a bug in SimpleDateFormat.subParse() that was causing us to always parse quarter names that begin
with numbers as though the number was the whole quarter name.

3 years agoICU-21710 Additional clean up after removing BOYER_MOORE code from usearch.cpp
Jeff Genovy [Fri, 27 Aug 2021 02:23:16 +0000 (19:23 -0700)]
ICU-21710 Additional clean up after removing BOYER_MOORE code from usearch.cpp

Changes:
- We can completely remove the shift tables and related fields from
  data structs.

- Creation of UStringSearch objects should be faster now,
  as it doesn't waste time computing the unused shift tables.

- The sizeof(UStringSearch) is decreased from 5240 to 3192, so
  this should help to reduce memory for applications that create many string search objects.

Note regarding the comments on initialize(). It actually does not set illegal argument error if pattern is all ignoreables. Added a test case for it.

3 years agoICU-21555 Fix typos in repo from letter d to i
Erik Torres [Fri, 27 Aug 2021 01:16:53 +0000 (01:16 +0000)]
ICU-21555 Fix typos in repo from letter d to i

Fix typos in repo from letter d to i

3 years agoICU-21617 Remove work around of uninstalling GCC11 in CI build
Erik Torres [Fri, 27 Aug 2021 00:20:33 +0000 (00:20 +0000)]
ICU-21617 Remove work around of uninstalling GCC11 in CI build

Remove work around of uninstalling GCC11 in CI build

3 years agoICU-21130 Update cpp14 to cpp17 in CI builds
Erik Torres [Thu, 26 Aug 2021 21:46:57 +0000 (21:46 +0000)]
ICU-21130 Update cpp14 to cpp17 in CI builds

See #1827

3 years agoICU-21598 Add CI builds that exercises the data filtering on windows
Erik Torres [Thu, 26 Aug 2021 20:52:58 +0000 (20:52 +0000)]
ICU-21598 Add CI builds that exercises the data filtering on windows

See #1820

3 years agoICU-20973 Use standard keywords true & false to initialize type bool.
Fredrik Roubert [Thu, 26 Aug 2021 13:15:30 +0000 (15:15 +0200)]
ICU-20973 Use standard keywords true & false to initialize type bool.

Now when all equality operators return standard bool (commit 633438f),
it no longer makes any sense to use the ICU4C constants TRUE & FALSE
or local variables of type UBool for their return value.

3 years agoICU-21710 Remove BOYER_MOORE dead code from usearch.cpp
Jeff Genovy [Thu, 12 Aug 2021 20:17:52 +0000 (13:17 -0700)]
ICU-21710 Remove BOYER_MOORE dead code from usearch.cpp

3 years agoICU-21705 ICU-21706 Fix crash if ICU's default locale has BCP47 Unicode Extensions...
Jeff Genovy [Tue, 10 Aug 2021 01:37:22 +0000 (18:37 -0700)]
ICU-21705 ICU-21706 Fix crash if ICU's default locale has BCP47 Unicode Extensions, and fix ures_openDirect crash with NULL locale ID.

Add test case for ures_openDirect with NULL locale ID.

3 years agoICU-20973 Rewrite polymorphic CacheKeyBase equality operators for C++20.
Fredrik Roubert [Wed, 25 Aug 2021 16:11:20 +0000 (18:11 +0200)]
ICU-20973 Rewrite polymorphic CacheKeyBase equality operators for C++20.

The existing polymorphic equality operators that use different types for
the `this` and `other` objects are ambiguous with C++20 resolution rules
that require equality for reversed arguments.

In order to resolve that, while also possibly making the implementation
somewhat simpler overall, the implementation classes (LocaleCacheKey
and DateFmtBestPatternKey) now get normal (non-polymorphic) equality
operators that are trivially non-ambiguous (and as a bonus also don't
need any type casts), while the dynamic type checking logic is moved
into protected helper functions, which in the end are invoked
(without any ambiguity) by friend operators in the base class.

This way, all equality testing of cache key objects ends up taking one
of these two possible paths:

1. Both sides of the equality operator are of the same implementation
   type (ie. LocaleCacheKey or DateFmtBestPatternKey):

   The type specific equality operator is called directly, comparing the
   relevant attributes of the two objects directly.

2. The two sides of the equality operator are either of different types
   or of some base class type:

   The friend equality operators of CacheKeyBase call the virtual helper
   function to figure out whether the two objects are actually of the
   same type and if they are and this type is an implementation type
   then does the necessary type cast to get to 1.

3 years agoICU-21215 Add default constructor to FormattedNumberRange cldr/2021-08-25
Shane F. Carr [Fri, 20 Aug 2021 20:04:37 +0000 (15:04 -0500)]
ICU-21215 Add default constructor to FormattedNumberRange

3 years agoICU-21590 Add skeleton syntax for integer-width-trunc
Shane F. Carr [Fri, 20 Aug 2021 23:01:26 +0000 (18:01 -0500)]
ICU-21590 Add skeleton syntax for integer-width-trunc

3 years agoICU-21648 limit backslash-uhhhh escapes to ASCII hex digits
Markus Scherer [Tue, 24 Aug 2021 19:42:40 +0000 (12:42 -0700)]
ICU-21648 limit backslash-uhhhh escapes to ASCII hex digits

3 years agoICU-21663 UnicodeSetIterator: make protected members private
Markus Scherer [Tue, 24 Aug 2021 21:12:55 +0000 (14:12 -0700)]
ICU-21663 UnicodeSetIterator: make protected members private

3 years agoICU-21708 Update ant version in cldr-to-icu tool
Yoshito Umaoka [Mon, 23 Aug 2021 22:24:49 +0000 (18:24 -0400)]
ICU-21708 Update ant version in cldr-to-icu tool

dependabot reported ant 1.10.9 has a security problem and suggested to update to 1.10.11.

3 years agoICU-21655 widen Java character APIs from char to int arguments
Markus Scherer [Tue, 24 Aug 2021 01:36:57 +0000 (18:36 -0700)]
ICU-21655 widen Java character APIs from char to int arguments

3 years agoICU-21581 Update ICU4J LICENSE file
Yoshito Umaoka [Wed, 18 Aug 2021 16:34:58 +0000 (12:34 -0400)]
ICU-21581 Update ICU4J LICENSE file

3 years agoICU-21693 Fix FormattedNumber::toDecimalNumber on 0
Shane F. Carr [Sat, 21 Aug 2021 03:30:31 +0000 (22:30 -0500)]
ICU-21693 Fix FormattedNumber::toDecimalNumber on 0

3 years agoICU-21635 Unicode 14 data files 20210820, line break LB30b.2
Markus Scherer [Mon, 23 Aug 2021 03:24:02 +0000 (03:24 +0000)]
ICU-21635 Unicode 14 data files 20210820, line break LB30b.2

See #1807

3 years agoICU-21584 Fixed Java7 build error in earlier fix.
Rich Gillam [Fri, 20 Aug 2021 17:28:02 +0000 (10:28 -0700)]
ICU-21584 Fixed Java7 build error in earlier fix.

3 years agoICU-21581 lingering exhaustive fail, need to separately skip sd_Deva month name exemp...
Peter Edberg [Thu, 19 Aug 2021 23:00:54 +0000 (16:00 -0700)]
ICU-21581 lingering exhaustive fail, need to separately skip sd_Deva month name exemplar test

3 years agoICU-21581 integrate CLDR release-40-alpha1 to ICU trunk
Peter Edberg [Thu, 19 Aug 2021 20:28:43 +0000 (13:28 -0700)]
ICU-21581 integrate CLDR release-40-alpha1 to ICU trunk

3 years agoICU-21358 Use sign position to format approximate numbers
Shane F. Carr [Wed, 17 Mar 2021 17:45:58 +0000 (17:45 +0000)]
ICU-21358 Use sign position to format approximate numbers

See #1635

3 years agoICU-21581 integrate CLDR 40a0 to ICU trunk
Peter Edberg [Wed, 18 Aug 2021 23:51:53 +0000 (16:51 -0700)]
ICU-21581 integrate CLDR 40a0 to ICU trunk

3 years agoICU-21244 Fix the Valgrind status badge in the top-level Readme.
Jeff Genovy [Wed, 18 Aug 2021 20:07:55 +0000 (13:07 -0700)]
ICU-21244 Fix the Valgrind status badge in the top-level Readme.

3 years agoICU-20973 Delete unnecessary deprecated TimeUnitFormat::operator!=().
Fredrik Roubert [Tue, 17 Aug 2021 13:28:19 +0000 (15:28 +0200)]
ICU-20973 Delete unnecessary deprecated TimeUnitFormat::operator!=().

An operator!=() is already defined by a base class so this class doesn't
need to define it again and not doing so avoids a C++20 ambiguity.

This simplifies the code.

3 years agoICU-21729 Fix setLanguageTag doc matching Java
Frank Tang [Wed, 18 Aug 2021 19:00:03 +0000 (12:00 -0700)]
ICU-21729 Fix setLanguageTag doc matching Java

3 years agoICU-21202 Fixed error in alias resolution in uresbund.cpp.
Rich Gillam [Mon, 19 Jul 2021 23:39:34 +0000 (16:39 -0700)]
ICU-21202 Fixed error in alias resolution in uresbund.cpp.

3 years agoICU-20973 Add C++20 build bots to Azure CI: Clang-13, GCC-11, MSVC with std:c++latest
Jeff Genovy [Tue, 17 Aug 2021 00:31:44 +0000 (17:31 -0700)]
ICU-20973 Add C++20 build bots to Azure CI: Clang-13, GCC-11, MSVC with std:c++latest

3 years agoICU-21581 BRS#18 Promote @draft ICU4J API elements from version 68 to @stable
Craig Cornelius [Tue, 17 Aug 2021 00:10:46 +0000 (00:10 +0000)]
ICU-21581 BRS#18 Promote @draft ICU4J API elements from version 68 to @stable

See #1788

3 years agoICU-20973 Update the Coding Guidelines with bool equality operators.
Fredrik Roubert [Tue, 10 Aug 2021 20:30:07 +0000 (22:30 +0200)]
ICU-20973 Update the Coding Guidelines with bool equality operators.

3 years agoICU-20973 Update configure files from configure.ac using autoreconf.
Fredrik Roubert [Wed, 4 Aug 2021 16:10:54 +0000 (18:10 +0200)]
ICU-20973 Update configure files from configure.ac using autoreconf.

3 years agoICU-20973 Use the Clang -Wno-ambiguous-reversed-operator flag.
Fredrik Roubert [Wed, 4 Aug 2021 15:27:52 +0000 (17:27 +0200)]
ICU-20973 Use the Clang -Wno-ambiguous-reversed-operator flag.

3 years agoICU-20973 Manually resolve C++20 reversed argument order ambiguity.
Fredrik Roubert [Wed, 4 Aug 2021 14:25:34 +0000 (16:25 +0200)]
ICU-20973 Manually resolve C++20 reversed argument order ambiguity.

3 years agoICU-20973 Change all equality operator return types from UBool to bool.
Fredrik Roubert [Wed, 16 Sep 2020 14:50:15 +0000 (16:50 +0200)]
ICU-20973 Change all equality operator return types from UBool to bool.

3 years agoICU-21064 Fix declspec macro conflict on clang.
Gregorio Litenstein [Thu, 5 Aug 2021 06:02:32 +0000 (02:02 -0400)]
ICU-21064 Fix declspec macro conflict on clang.

3 years agoICU-21707 Fix LocaleBuilder assumption that the default locale doesn't have any BCP47...
Jeff Genovy [Wed, 11 Aug 2021 00:35:34 +0000 (17:35 -0700)]
ICU-21707 Fix LocaleBuilder assumption that the default locale doesn't have any BCP47 extension tags.

Add test case for LocaleBuilder with default locale with extensions.

Use Locale::getRoot().clone() instead of new Locale();

Add CI build bot with LANG that has extension tags

3 years agoICU-21694 ubidi.h sample code would not compile cldr/2021-08-11
Myles C. Maxfield [Fri, 30 Jul 2021 04:49:55 +0000 (21:49 -0700)]
ICU-21694 ubidi.h sample code would not compile

3 years agoICU-21639 Added an internal utility class to streamline preflighting and heap-allocat...
Rich Gillam [Thu, 8 Jul 2021 00:35:00 +0000 (17:35 -0700)]
ICU-21639 Added an internal utility class to streamline preflighting and heap-allocating a char buffer for a locale ID
and changed several internal methods in ULocale to use it, so that they work correctly on locale IDs that are longer
than ULOC_FULLNAME_CAPACITY.

3 years agoICU-21581 BRS 70 front-load task scrub closed issues: replace ticket# ICU-11234,
gnrunge [Tue, 27 Jul 2021 20:43:37 +0000 (13:43 -0700)]
ICU-21581 BRS 70 front-load task scrub closed issues: replace ticket# ICU-11234,
which was closed as invalid, with its successor ticket ICU-21257.

3 years agoICU-21424 Migrate bldicures.py to Python 3
gnrunge [Thu, 29 Jul 2021 22:21:26 +0000 (15:21 -0700)]
ICU-21424 Migrate bldicures.py to Python 3

3 years agoICU-21581 BRS 70 front-load task: scrub logKnownIssue for ticket CLDR-14477,
gnrunge [Tue, 27 Jul 2021 20:18:47 +0000 (13:18 -0700)]
ICU-21581 BRS 70 front-load task: scrub logKnownIssue for ticket CLDR-14477,
which is completed.

3 years agoICU-21662 Rename UVector::addElement().
Andy Heninger [Tue, 27 Jul 2021 22:51:34 +0000 (15:51 -0700)]
ICU-21662 Rename UVector::addElement().

This is the first step towards improving the error handling and out-of-memory
behavior of UVector::addElement(). A followup PR will add back a new addElement()
with corrected error handling, then additional followups will switch call sites
from the original (renamed) function to the new addElement().

This commit includes no logic or behavior changes; it only renames the existing functions.

3 years agoICU-21688 escape angle bracket in non-HTML content
DungSaga [Thu, 22 Jul 2021 02:42:02 +0000 (09:42 +0700)]
ICU-21688 escape angle bracket in non-HTML content

`<name>` should be escaped with backslash to prevent it from being rendered as a HTML tag

3 years agoICU-21647 Added support for narrow quarter names to DateFormatSymbols and SimpleDateF...
Rich Gillam [Thu, 8 Jul 2021 00:03:03 +0000 (17:03 -0700)]
ICU-21647 Added support for narrow quarter names to DateFormatSymbols and SimpleDateFormat.

3 years agoICU-21680 Add -std flag when generating dependency information
David Haney [Sun, 18 Jul 2021 15:01:50 +0000 (15:01 +0000)]
ICU-21680 Add -std flag when generating dependency information

3 years agoICU-21638 re-enable some of the ICU4J performance tests
Craig Cornelius [Fri, 23 Jul 2021 17:19:42 +0000 (17:19 +0000)]
ICU-21638 re-enable some of the ICU4J performance tests

See #1773

3 years agoICU-21622 Add UYW to list of currencies from ucurr_openISOCurrencies()
Peter Edberg [Thu, 22 Jul 2021 04:21:54 +0000 (21:21 -0700)]
ICU-21622 Add UYW to list of currencies from ucurr_openISOCurrencies()

3 years agoICU-21624 Fixed it so that a DecimalFormat no longer owns two separate DecimalFormatS...
Rich Gillam [Thu, 8 Jul 2021 01:23:45 +0000 (18:23 -0700)]
ICU-21624 Fixed it so that a DecimalFormat no longer owns two separate DecimalFormatSymbols objects.

3 years agoICU-21584 Added code to allow regions of type "grouping" to return their children.
Rich Gillam [Fri, 9 Jul 2021 00:06:11 +0000 (17:06 -0700)]
ICU-21584 Added code to allow regions of type "grouping" to return their children.

3 years agoICU-21581 BRS 70rc, update urename.h pass 1
Peter Edberg [Wed, 21 Jul 2021 21:20:17 +0000 (14:20 -0700)]
ICU-21581 BRS 70rc, update urename.h pass 1

3 years agoICU-21581 Promoted @draft 68 APIs to stable
Rich Gillam [Fri, 2 Jul 2021 21:43:29 +0000 (14:43 -0700)]
ICU-21581 Promoted @draft 68 APIs to stable

3 years agoICU-21580 Fix typos in icu4j/
luz paz [Wed, 14 Jul 2021 21:03:25 +0000 (17:03 -0400)]
ICU-21580 Fix typos in icu4j/

Found via `codespell -q 3 -L ans,anumber,atleast,ba,bre,hace,nd,nin,ois,rsource,som,sur,tht -S icu4c/source/data/zone,icu4c/source/data/lang`

3 years agoICU-21580 Fix typos in icu4c/
luz paz [Wed, 14 Jul 2021 22:45:49 +0000 (18:45 -0400)]
ICU-21580 Fix typos in icu4c/

Found via `codespell -q 3 -L ans,anumber,atleast,ba,bre,hace,nd,nin,ois,rsource,som,sur,tht -S icu4c/source/data/zone,icu4c/source/data/lang`
ICU-21580 Fix source (related) typos
ICU-21580 Revert extraneous auto-encoding
ICU-21580 Re-add previous reverted fix without auto-encoding

3 years agoICU-21650 Modified DateTimePatternGenerator to handle skeletons with "e" and "c"...
Rich Gillam [Tue, 6 Jul 2021 20:56:15 +0000 (13:56 -0700)]
ICU-21650 Modified DateTimePatternGenerator to handle skeletons with "e" and "c" better (allowing support for numeric
day-of-week abbreviations).

3 years agoICU-21676 Fix strcpy buffer override in ultag_parse
Frank Yung-Fong Tang [Wed, 14 Jul 2021 00:47:01 +0000 (00:47 +0000)]
ICU-21676 Fix strcpy buffer override in ultag_parse

See #1767

3 years agoICU-21641 Fix "emoji" and "eor" for Collator::getKeywordValues
Frank Tang [Fri, 9 Jul 2021 00:40:23 +0000 (00:40 +0000)]
ICU-21641 Fix "emoji" and "eor" for Collator::getKeywordValues

See #1743

3 years agoICU-21664 Fix set but unused warning in locid.cpp
Jeff Genovy [Wed, 30 Jun 2021 19:20:46 +0000 (12:20 -0700)]
ICU-21664 Fix set but unused warning in locid.cpp

3 years agoICU-21659 Adding test for exabyte
Shane F. Carr [Wed, 30 Jun 2021 21:08:46 +0000 (16:08 -0500)]
ICU-21659 Adding test for exabyte

3 years agoICU-21525 UnicodeSet.hasString(), UnicodeSetIterator.skipToStrings() & C API
Markus Scherer [Tue, 29 Jun 2021 17:27:09 +0000 (17:27 +0000)]
ICU-21525 UnicodeSet.hasString(), UnicodeSetIterator.skipToStrings() & C API