]> granicus.if.org Git - fcron/log
fcron
11 years agoUpdated copyright years to 2013 ver3_1_2
Thibault Godouet [Sun, 3 Mar 2013 20:01:05 +0000 (20:01 +0000)]
Updated copyright years to 2013

11 years agoUpdated change log
Thibault Godouet [Sun, 3 Mar 2013 19:56:24 +0000 (19:56 +0000)]
Updated change log

11 years agoApplied indentation with 'make indent'
Thibault Godouet [Mon, 4 Feb 2013 19:37:42 +0000 (19:37 +0000)]
Applied indentation with 'make indent'

11 years agoFixed configure --without-sendmail, and compilation errors when sendmail is disabled
Thibault Godouet [Sun, 3 Feb 2013 13:03:52 +0000 (13:03 +0000)]
Fixed configure --without-sendmail, and compilation errors when sendmail is disabled
Also don't check if email should be output if sendmail is disabled
(Thank you Thomas Trepl for pointing out the problem and submitting a patch)

11 years agoFixed fcron crash bug when using fcrondyn.
Thibault Godouet [Sun, 3 Feb 2013 11:12:29 +0000 (11:12 +0000)]
Fixed fcron crash bug when using fcrondyn.
This bug was introduced in 25e9c80848acb89e6320ed6261a4d1c75b60b1c8, and we were using a fd after xclose() was called on it, so its value was no longer valid.
Audited the code for similar problems and didn't find any other.

11 years agoInline runas wouldn't work with Vixie-cron style shortcut lines.
Thibault Godouet [Sun, 3 Feb 2013 10:34:53 +0000 (10:34 +0000)]
Inline runas wouldn't work with Vixie-cron style shortcut lines.

11 years agoadded unit tests on todo list
Thibault Godouet [Sat, 19 Jan 2013 13:44:51 +0000 (13:44 +0000)]
added unit tests on todo list

11 years agoRemoving auto-generated test files
Thibault Godouet [Sat, 19 Jan 2013 13:04:38 +0000 (13:04 +0000)]
Removing auto-generated test files

11 years agoMoved to version 3.1.2
Thibault Godouet [Sun, 13 Jan 2013 17:35:30 +0000 (17:35 +0000)]
Moved to version 3.1.2

11 years agoFixed bug in logging to a file and made file closure more robust
Thibault Godouet [Sun, 13 Jan 2013 17:31:17 +0000 (17:31 +0000)]
Fixed bug in logging to a file and made file closure more robust
- when logging to a file, fcron would log a line to the pid file
- adding helpers functions to close files properly: check for errors, and set FILE* to NULL / fd to -1

11 years agosystemd: installation fix + don't kill jobs when killing fcron
Thibault Godouet [Sat, 5 Jan 2013 11:26:22 +0000 (11:26 +0000)]
systemd: installation fix + don't kill jobs when killing fcron

11 years agoupdated changes ver3_1_1
Thibault Godouet [Tue, 1 Jan 2013 18:47:59 +0000 (18:47 +0000)]
updated changes

11 years agoFixed changes
Thibault Godouet [Tue, 1 Jan 2013 18:44:36 +0000 (18:44 +0000)]
Fixed changes

11 years agoAdded optional readline requirement for compilation
Thibault Godouet [Tue, 1 Jan 2013 18:39:03 +0000 (18:39 +0000)]
Added optional readline requirement for compilation

11 years agoUpdated documentation
Thibault Godouet [Tue, 1 Jan 2013 18:24:52 +0000 (18:24 +0000)]
Updated documentation

11 years agoApplied indentation
Thibault Godouet [Tue, 1 Jan 2013 18:14:10 +0000 (18:14 +0000)]
Applied indentation

11 years agoonly call xopenlog when necessary
Thibault Godouet [Tue, 1 Jan 2013 18:13:34 +0000 (18:13 +0000)]
only call xopenlog when necessary

11 years agoMerge branch 'log-to-file'
Thibault Godouet [Tue, 1 Jan 2013 17:56:27 +0000 (17:56 +0000)]
Merge branch 'log-to-file'

Conflicts:
convert-fcrontab.c
fcron.c
log.c
subs.c

11 years agotweaked fcron logging to file
Thibault Godouet [Tue, 1 Jan 2013 17:33:53 +0000 (17:33 +0000)]
tweaked fcron logging to file
- only enabled for fcron via a command line option (rather than fcron.conf)
  I doubt people need this feature for command line tools, and we would need to manage the log file perms more closely to allow all tools to write to it
- reworked log.c/log.h: more sensible function names, better error checks
- changed the line format when logging to files/console
- added documentation on logging to file

11 years agobetter errno management in open_as_user()
Thibault Godouet [Tue, 1 Jan 2013 17:32:57 +0000 (17:32 +0000)]
better errno management in open_as_user()

11 years agoRenamed fcronlog in fcronconf.h to fcronlogfile, to avoid shadowing the function...
Matt Signorini [Fri, 28 Dec 2012 01:59:05 +0000 (12:59 +1100)]
Renamed fcronlog in fcronconf.h to fcronlogfile, to avoid shadowing the function fcronlog.

Modified convert-fcrontab to include fcronconf.o, to fix an undefined
symbol issue with fcronlogfile. Also added code to parse a config file with
read_conf, and an extra flag '-c' to specify a config file. Docs have not
been updated in this commit.

11 years agoModifications to log.c to ensure that a log file specified in fcron.conf takes preced...
Matt Signorini [Thu, 27 Dec 2012 05:06:56 +0000 (16:06 +1100)]
Modifications to log.c to ensure that a log file specified in fcron.conf takes precedence over syslog.

11 years agoAdded code to facilitate logging to a separate file.
Matt Signorini [Thu, 27 Dec 2012 05:00:44 +0000 (16:00 +1100)]
Added code to facilitate logging to a separate file.

- modified fcronconf.c and .h to parse an fcronlog entry in the conf file.

- modified xopenlog and xcloselog to handle a file, if specified, and added
a procedure fcronlog, which prints a message to the log file.

11 years agoFixed bug in change_user_setup_env() which could make fcron crash when sending a...
Thibault Godouet [Thu, 27 Dec 2012 17:48:11 +0000 (17:48 +0000)]
Fixed bug in change_user_setup_env() which could make fcron crash when sending a 'not run' email

11 years agoMerge remote-tracking branch 'origin/master'
Thibault Godouet [Wed, 26 Dec 2012 18:20:22 +0000 (18:20 +0000)]
Merge remote-tracking branch 'origin/master'

Conflicts:
fileconf.c

11 years agoAdded readline support to fcrondyn
Thibault Godouet [Wed, 26 Dec 2012 17:43:29 +0000 (17:43 +0000)]
Added readline support to fcrondyn

12 years agoApplied indentation with 'make indent'
Thibault Godouet [Mon, 24 Dec 2012 15:19:41 +0000 (15:19 +0000)]
Applied indentation with 'make indent'

12 years agoupdated to-do list
Thibault Godouet [Mon, 24 Dec 2012 11:53:01 +0000 (11:53 +0000)]
updated to-do list

12 years agoonly check for erroneous space if option takes an argument
Thibault Godouet [Thu, 20 Dec 2012 21:48:43 +0000 (21:48 +0000)]
only check for erroneous space if option takes an argument

12 years agoMoved to version 3.1.1
Thibault Godouet [Wed, 19 Dec 2012 22:11:37 +0000 (22:11 +0000)]
Moved to version 3.1.1

12 years agoUpdated copyright and marked as DEV release ver3_1_0
Thibault Godouet [Wed, 19 Dec 2012 18:50:18 +0000 (18:50 +0000)]
Updated copyright and marked as DEV release

12 years agoUpdated to-do list
Thibault Godouet [Wed, 19 Dec 2012 18:37:28 +0000 (18:37 +0000)]
Updated to-do list

12 years agorenamed 'doc' make target to 'documentation' or make gets confused with the 'doc...
Thibault Godouet [Wed, 19 Dec 2012 18:02:17 +0000 (18:02 +0000)]
renamed 'doc' make target to 'documentation' or make gets confused with the 'doc' directory

12 years agoensure the documentation is generated by "make all" rather than waiting for make...
Thibault Godouet [Wed, 19 Dec 2012 17:57:34 +0000 (17:57 +0000)]
ensure the documentation is generated by "make all" rather than waiting for make install

12 years agoAdded compilation requirements
Thibault Godouet [Wed, 19 Dec 2012 17:57:17 +0000 (17:57 +0000)]
Added compilation requirements

12 years agoupdated changes/todo
Thibault Godouet [Wed, 5 Dec 2012 22:25:52 +0000 (22:25 +0000)]
updated changes/todo

12 years agocosmetic change of socket.c so as indent works ok
Thibault Godouet [Wed, 5 Dec 2012 21:55:07 +0000 (21:55 +0000)]
cosmetic change of socket.c so as indent works ok

12 years agoAllow make parallelism: use $(MAKE) in Makefile and added dependencies
Thibault Godouet [Wed, 5 Dec 2012 21:19:06 +0000 (21:19 +0000)]
Allow make parallelism: use $(MAKE) in Makefile and added dependencies

12 years agoclearer error messages in gen-in.pl
Thibault Godouet [Wed, 5 Dec 2012 21:18:43 +0000 (21:18 +0000)]
clearer error messages in gen-in.pl

12 years agofixed a potential (unlikely) 1 byte buffer overflow in strncat()
Thibault Godouet [Wed, 5 Dec 2012 19:52:18 +0000 (19:52 +0000)]
fixed a potential (unlikely) 1 byte buffer overflow in strncat()

12 years agogenerate init scripts in 'make all' rather than 'make install' (so as they are not...
Thibault Godouet [Wed, 5 Dec 2012 19:49:46 +0000 (19:49 +0000)]
generate init scripts in 'make all' rather than 'make install' (so as they are not owned by root)

12 years agoAdded systemd support
Thibault Godouet [Wed, 5 Dec 2012 19:22:57 +0000 (19:22 +0000)]
Added systemd support

12 years agoadded pam_loginuid to default fcron daemon PAM profile
Thibault Godouet [Wed, 5 Dec 2012 18:23:14 +0000 (18:23 +0000)]
added pam_loginuid to default fcron daemon PAM profile
This is so as when a fcron job runs, the audit system is able to account for the actions that fcron job does and tie it to the user that did it.

12 years agoUpdated doc
Thibault Godouet [Tue, 27 Nov 2012 00:28:44 +0000 (00:28 +0000)]
Updated doc

12 years agostartup script removes fcron.reboot (in case the OS doesn't do it)
Thibault Godouet [Tue, 27 Nov 2012 00:12:40 +0000 (00:12 +0000)]
startup script removes fcron.reboot (in case the OS doesn't do it)

12 years agoMore portable code for va_arg() with mode_t (thank you Chris Calvey)
Thibault Godouet [Mon, 26 Nov 2012 20:31:30 +0000 (20:31 +0000)]
More portable code for va_arg() with mode_t (thank you Chris Calvey)
(followed recommendation from http://www.gnu.org/software/gnulib/manual/html_node/va_005farg.html)

12 years agoImproved documentation
Thibault Godouet [Mon, 26 Nov 2012 19:43:28 +0000 (19:43 +0000)]
Improved documentation

12 years agoUpdated copyright dates and removed old CVS $id$ which are no longer relevant in git
Thibault Godouet [Thu, 22 Nov 2012 00:25:50 +0000 (00:25 +0000)]
Updated copyright dates and removed old CVS $id$ which are no longer relevant in git

12 years agorefactored and made more stricter reading of string values for options
Thibault Godouet [Thu, 22 Nov 2012 00:08:31 +0000 (00:08 +0000)]
refactored and made more stricter reading of string values for options

12 years agofcrontab: don't alert about invalid character when correcting fcrontab twice
Thibault Godouet [Wed, 21 Nov 2012 23:34:11 +0000 (23:34 +0000)]
fcrontab: don't alert about invalid character when correcting fcrontab twice

12 years agoadded cl.c/cl.h to define the cl_t type with associated functions
Thibault Godouet [Wed, 21 Nov 2012 22:45:23 +0000 (22:45 +0000)]
added cl.c/cl.h to define the cl_t type with associated functions

12 years agoReplaced function free_safe by macro Free_safe, and moved memory management functions...
Thibault Godouet [Wed, 21 Nov 2012 22:16:25 +0000 (22:16 +0000)]
Replaced function free_safe by macro Free_safe, and moved memory management functions to new mem.h/mem.c.
free_safe() was broken, as the pointer was not set to NULL outside of free_safe(). Simplest/cleanest way to fix this was to replace it by a macro doing the same. Now the pointers are correctly set to NULL, and things are actually safe.

12 years agoUpdated todo list
thib [Wed, 21 Nov 2012 22:11:45 +0000 (22:11 +0000)]
Updated todo list

13 years agoFixed gcc warning about unused variable
Thibault Godouet [Sun, 6 Nov 2011 18:39:19 +0000 (18:39 +0000)]
Fixed gcc warning about unused variable

13 years agoallow tasks to be run every second
thib [Thu, 29 Sep 2011 20:56:10 +0000 (21:56 +0100)]
allow tasks to be run every second

13 years agotweaked indent flags
Thibault Godouet [Sun, 10 Apr 2011 14:39:38 +0000 (15:39 +0100)]
tweaked indent flags

13 years agoAdded libaudit support
Thibault Godouet [Sun, 10 Apr 2011 14:03:08 +0000 (15:03 +0100)]
Added libaudit support

13 years agoAdded test programs -- some could later be used as basis for unit-tests
Thibault Godouet [Sun, 10 Apr 2011 13:57:17 +0000 (14:57 +0100)]
Added test programs -- some could later be used as basis for unit-tests

13 years agofixed error checking on setexeccon()
Thibault Godouet [Sun, 10 Apr 2011 13:53:45 +0000 (14:53 +0100)]
fixed error checking on setexeccon()

13 years agoadded indent Makefile command
Thibault Godouet [Sun, 10 Apr 2011 13:51:14 +0000 (14:51 +0100)]
added indent Makefile command

13 years agoMerge branch 'fcron-3.0'
thib [Sat, 12 Mar 2011 12:46:31 +0000 (12:46 +0000)]
Merge branch 'fcron-3.0'

Conflicts:
.gitignore
doc/en/changes.sgml

13 years agoFixed bug with step incorrectly parsed for months on & lines
thib [Sat, 12 Mar 2011 12:37:09 +0000 (12:37 +0000)]
Fixed bug with step incorrectly parsed for months on & lines

14 years agoRemoved unused environ variable
Thibault Godouet [Sun, 26 Sep 2010 18:26:13 +0000 (19:26 +0100)]
Removed unused environ variable

14 years agoAdded Content-Type and Content-Transfer-Encoding to output emails
Thibault Godouet [Sat, 25 Sep 2010 12:39:14 +0000 (13:39 +0100)]
Added Content-Type and Content-Transfer-Encoding to output emails

14 years agoUpdated doc: todo, FAQ entry on anacron, runatreboot example
Thibault Godouet [Fri, 24 Sep 2010 16:10:04 +0000 (17:10 +0100)]
Updated doc: todo, FAQ entry on anacron, runatreboot example

14 years agoMerge branch 'fcron-3.0'
Thibault Godouet [Fri, 24 Sep 2010 15:09:36 +0000 (16:09 +0100)]
Merge branch 'fcron-3.0'
Fixed some typos related to env var in job.c

Conflicts:
configure
configure.in
doc/en/todo.sgml
fcrondyn.c
fcrontab.c
read_string.c
subs.c

14 years agoUpdated copyright years to 2010
Thibault Godouet [Fri, 24 Sep 2010 12:56:01 +0000 (13:56 +0100)]
Updated copyright years to 2010

14 years agoAdded options runatreboot, runonce, rebootreset, and cron-like shortcuts @reboot...
thib [Wed, 22 Sep 2010 23:40:03 +0000 (00:40 +0100)]
Added options runatreboot, runonce, rebootreset, and cron-like shortcuts @reboot/@hourly/@monthly/...
Save cl_first for all @-lines (we only did it for volatile lines in the past)
added function mail_notrun_time_t()
added function free_line()
added function job_queue_remove()
added function init_default_line()

14 years agoFixed typo in fcrontab.5
thib [Sun, 6 Jun 2010 20:39:30 +0000 (21:39 +0100)]
Fixed typo in fcrontab.5

14 years agoFixed fcron.conf path to install from in Makefile (generated file -> not in $SRCDIR) ver3_0_6
thib [Mon, 5 Apr 2010 19:20:08 +0000 (20:20 +0100)]
Fixed fcron.conf path to install from in Makefile (generated file -> not in $SRCDIR)

14 years agoUpdated changes
thib [Mon, 5 Apr 2010 19:00:59 +0000 (20:00 +0100)]
Updated changes

14 years agoAllow user to specify a fcron.conf file in check_system_crontabs.sh
thib [Mon, 5 Apr 2010 18:59:44 +0000 (19:59 +0100)]
Allow user to specify a fcron.conf file in check_system_crontabs.sh

14 years agoRemoving bashims in check_system_crontabs
thib [Mon, 5 Apr 2010 18:44:11 +0000 (19:44 +0100)]
Removing bashims in check_system_crontabs

14 years agoLinked mail and forcemail: mail(no) implies forcemail(no) and forcemail(true) implies...
Thibault Godouet [Mon, 5 Apr 2010 17:40:25 +0000 (18:40 +0100)]
Linked mail and forcemail: mail(no) implies forcemail(no) and forcemail(true) implies mail(true)

14 years agoIgnore auto-generated files
thib [Mon, 5 Apr 2010 16:56:28 +0000 (17:56 +0100)]
Ignore auto-generated files

14 years agoInitialize fcrontab's PAM with runas and not user so as things works fine when user...
thib [Mon, 5 Apr 2010 12:37:27 +0000 (13:37 +0100)]
Initialize fcrontab's PAM with runas and not user so as things works fine when user=systab (pseudo-user)

14 years agoFixed bug preventing normal user from running fcrontab -l if fcron's uid!=gid
thib [Sat, 27 Mar 2010 15:06:40 +0000 (15:06 +0000)]
Fixed bug preventing normal user from running fcrontab -l if fcron's uid!=gid

14 years agoChanged version to 3.0.6
thib [Sat, 6 Mar 2010 10:40:20 +0000 (10:40 +0000)]
Changed version to 3.0.6

14 years agoFixed warning on freopen() return value not checked ver3_0_5
thib [Sat, 6 Mar 2010 10:37:58 +0000 (10:37 +0000)]
Fixed warning on freopen() return value not checked

14 years agoFixed compilation warnings
thib [Mon, 1 Mar 2010 09:11:46 +0000 (09:11 +0000)]
Fixed compilation warnings

14 years agoUpdated Makefile to ignore git files when tarring up -- also don't ci on make tar...
thib [Mon, 1 Mar 2010 09:11:16 +0000 (09:11 +0000)]
Updated Makefile to ignore git files when tarring up -- also don't ci on make tar anymore

14 years agoAdded missing bitstring.3 man page
thib [Sun, 28 Feb 2010 23:20:52 +0000 (23:20 +0000)]
Added missing bitstring.3 man page

14 years agoUpdated copyright to 2008-2010
thib [Sun, 28 Feb 2010 23:16:47 +0000 (23:16 +0000)]
Updated copyright to 2008-2010
Updated changes

14 years agoFixed fcrontab when running without seteuid()
thib [Sun, 28 Feb 2010 22:48:40 +0000 (22:48 +0000)]
Fixed fcrontab when running without seteuid()
updated configure with new version of autoconf

14 years ago- fcrontab: drop all privileges and only get them back when necessary
thib [Sun, 28 Feb 2010 20:59:38 +0000 (20:59 +0000)]
- fcrontab: drop all privileges and only get them back when necessary
- fcrondyn: drop sgid privileges as well as soon as they are not necessary anymore
- fixed a couple gcc warnings

14 years agoImproved fcrontab security fix which allowed to read file readable by the group fcron
thib [Wed, 24 Feb 2010 23:40:59 +0000 (23:40 +0000)]
Improved fcrontab security fix which allowed to read file readable by the group fcron

14 years agoFixed fcrontab vulnerability that would let an ill-intended user read files that...
thib [Wed, 24 Feb 2010 00:27:12 +0000 (00:27 +0000)]
Fixed fcrontab vulnerability that would let an ill-intended user read files that the user fcron can read

14 years agoMerge branch 'master' of ssh://yo4096@git.tuxfamily.org/gitroot/fcron/fcron
thib [Sat, 16 Jan 2010 19:50:45 +0000 (19:50 +0000)]
Merge branch 'master' of ssh://yo4096@git.tuxfamily.org/gitroot/fcron/fcron

14 years agoAdditional comment on bitstring.h
thib [Sat, 16 Jan 2010 19:50:15 +0000 (19:50 +0000)]
Additional comment on bitstring.h

14 years agoMerge branch 'master' of ssh://yo4096@git.tuxfamily.org/gitroot/fcron/fcron
Thibault Godouet [Sat, 16 Jan 2010 10:46:00 +0000 (10:46 +0000)]
Merge branch 'master' of ssh://yo4096@git.tuxfamily.org/gitroot/fcron/fcron

Conflicts:
doc/en/todo.sgml
read_string.c

14 years agoMoved fcron.conf code from sub.{c,h} to fcronconf.{c,h}
Thibault Godouet [Sat, 16 Jan 2010 10:33:33 +0000 (10:33 +0000)]
Moved fcron.conf code from sub.{c,h} to fcronconf.{c,h}

14 years ago- removed Flush() macro (replaced by free_safe())
Thibault Godouet [Sun, 10 Jan 2010 17:11:13 +0000 (17:11 +0000)]
- removed Flush() macro (replaced by free_safe())
- added alloc_safe() and realloc_safe(): wrappers around calloc() and realloc() that die on error
- checked the code to use free_safe(), Set(),  Alloc(), alloc_safe() and realloc_safe() whenever appropriate

14 years ago- Rewrote the env var management code with Vixie cron compatibility in mind
Thibault Godouet [Sat, 9 Jan 2010 15:28:31 +0000 (15:28 +0000)]
- Rewrote the env var management code with Vixie cron compatibility in mind
 * new env_list_t type with associated functions
 * build some char **envp arrays and pass them to execle()
 * cleaner management of env var defined several times
 * don't inherit fcron's environment when running a job but build the environment from scratch
 * list the env var as X-Cron-Env headers in the job output emails
 * add Auto-Submitted headers to the job output emails (as cronie, i.e. cron on RedHat)
 * added a default path for jobs: /usr/bin:/bin (as Vixie cron)
 * ignore not only USER but LOGNAME assigments as well
 * added my_unsetenv() and my_setenv_overwrite() to make the direct manipulation (without env_list_t) of env var easier
- no longer try to run a job with execlp("sh", ...) if execl(curshell, ...) fails (as vixie cron)
- improved u_list: realloc() instead of free() followed by a calloc()
- debug_opt is now defined by log.c (instead of fcron.c/fcrontab.c/...)

14 years agoInital implementation of a new env var type env_list_t based on u_list
Thibault Godouet [Wed, 30 Dec 2009 22:50:36 +0000 (22:50 +0000)]
Inital implementation of a new env var type env_list_t based on u_list

14 years agoFixed --with-sendmail bug: sendmail was disabled if not explicitely set
Thibault Godouet [Wed, 30 Dec 2009 22:46:58 +0000 (22:46 +0000)]
Fixed --with-sendmail bug: sendmail was disabled if not explicitely set

14 years ago- use realloc() when growing u_list
Thibault Godouet [Wed, 30 Dec 2009 22:44:01 +0000 (22:44 +0000)]
- use realloc() when growing u_list
- added function to copy u_list
- added function to know if we are in an iteration

15 years agoMerge branch 'master' of ssh://yo4096@git.tuxfamily.org/gitroot/fcron/fcron
thib [Tue, 8 Dec 2009 22:38:07 +0000 (22:38 +0000)]
Merge branch 'master' of ssh://yo4096@git.tuxfamily.org/gitroot/fcron/fcron

15 years agoFixed some gcc warnings (first char of string array referenced as var instead of...
thib [Tue, 8 Dec 2009 22:30:11 +0000 (22:30 +0000)]
Fixed some gcc warnings (first char of string array referenced as var instead of var[0]

15 years agoAdded option jitter
thib [Sun, 29 Mar 2009 20:31:53 +0000 (21:31 +0100)]
Added option jitter

15 years agofixed configure script so as the usage of sendmail can be disabled (previously it...
thib [Sun, 15 Feb 2009 17:08:40 +0000 (17:08 +0000)]
fixed configure script so as the usage of sendmail can be disabled (previously it would then try to run "no"!)