On Sunday, 13 July 2003 at 18:09, Brendan Cully wrote:
> The attached patch should help when the connection to your postponed
> folder times out and you can't reconnect without restarting mutt. I'd
> like anyone who has that problem to try it and let me know how it
> works.
I dug a little deeper. The attached patch seems to work better. It
complains the first time you try to recall a message, but works the
second.
The attached patch prevents mutt from reading the push buffer when
asking for passwords. This is a proper fix for bug 1312. I think
it's uncontroversial.
Thomas Roessler [Fri, 4 Jul 2003 16:57:56 +0000 (16:57 +0000)]
Add a ':' flag to % expandos. This will make sure that any
dots are converted into underscores. (_ is already used for
lowercasing the result of an expando.)
view-attachments does not extract the message within a x-pkcs7-mime
if it's only signed, but not encrypted. Such a message results, for
example, from a decrypt-save if the message was previously encrypted
and signed.
David Shaw [Tue, 13 May 2003 12:43:45 +0000 (12:43 +0000)]
Currently, mutt uses the OpenPGP key algorithm to determine the
capabilities of the key. For example, in mutt, a key of type 1 (RSA)
can both encrypt & sign. This is not correct as per OpenPGP, however,
where the capabilities of the key are determined by both the algorithm
and key capability flags that are set on the key. This can lead to
user confusion when their RSA encrypt-only or sign-only key is listed
for both signing and encryption in mutt.
GnuPG lists these flags in key listings, so it is easy to take
advantage of them. Here is a patch to use the flags, as well as
provide the flags in pgpring. Note that the pgp+pgpring users won't
see any change since the flags there are based on the key algorithm as
they are now, but the GnuPG users will see an improvement.
The "sign (a)s" code strips the pgp application bit causing drawing
issues in redraw_crypt_lines(). Other bits (well bit = encrypt) are
ignored as a result. I've only tested with pgp, but the same
problem exists in the smime code too. This inline patch (against
cvs head revision) fixes the problem.
Thomas Roessler [Mon, 14 Apr 2003 09:09:53 +0000 (09:09 +0000)]
Fix the PGP / S/MIME selection mess in send.c. This patch adds two
new configuration variables, $crypt_autopgp and $crypt_autsmime.
Both are set to "yes" by default. By turning them off, you can
disable the automatic selection of one or both mechanisms. (Useful
when your mutt is PGP- and S/MIME enabled, but you only use, say
S/MIME.)
Thomas Roessler [Tue, 8 Apr 2003 21:41:39 +0000 (21:41 +0000)]
Make sure has_colors() is only invoked when OPTNOCURSES is unset.
This fixes a segmentation fault on RH 8.0 which was observed by Matt
Larson <mlarson@verisign.com>.
Thomas Roessler [Wed, 2 Apr 2003 08:47:28 +0000 (08:47 +0000)]
sample.muttrc-tlr would try to include my color configurations,
which weren't distrubted. Fix that. (Bug noted while helping
someone else to configure mutt during a conference.)
Gary Johnson [Wed, 2 Apr 2003 08:40:50 +0000 (08:40 +0000)]
Here is the patch to fix the bug I reported earlier in this thread,
that sometimes when changing folders, mutt would generate an error
message and stop the further processing of folder-hooks.
David Shaw [Wed, 2 Apr 2003 08:28:24 +0000 (08:28 +0000)]
Here is the pgp_check_exit patch updated for 1.5.4. This patch adds
the pgp_check_exit option (enabled by default) that causes mutt to
check the exit code of the PGP subprocess. A non-zero exit code means
that the subprocess failed and mutt will not continue to send the
message.
This is needed as in certain cases, PGP or GnuPG can fail to
completely process a document (say, if the gpg.conf file is mangled,
which is how I discovered the problem). Without an exit code check,
mutt will continue anyway and send the half processed file.
(mutt_addr_for_display): Fix memory leak. `user' and `domain'
buffers was never deallocated.
(mbox_to_udomain): Fix memory leak. `scratch' buffer was not
deallocated when `mbx' doesn't contain '@'. Also rewritten for
allocating memory only when needed and only how many as needed.
Brendan Cully [Fri, 7 Mar 2003 14:55:53 +0000 (14:55 +0000)]
The global callbacks set up in sasl_client_init are not copied by
the SASL library, so they can't be allocated on the stack. This is
the case with both versions of the SASL library, and I frankly don't
understand why it hasn't caused problems before. Since it segfaults
reliably on OS X for me now, I thought a patch would be in order.
Thomas Roessler [Thu, 6 Mar 2003 21:23:53 +0000 (21:23 +0000)]
Fixing a segmentation fault. Here's how to reproduce it: Start
mutt. Compose a new message, with an attachment. Turn on PGP
signing. Press C-G on the pass phrase prompt. Turn off PGP
signing. Try to send the message.