]> granicus.if.org Git - php/log
php
5 years agoAdd missing ZPP_none()
Christoph M. Becker [Sun, 15 Sep 2019 19:27:45 +0000 (21:27 +0200)]
Add missing ZPP_none()

5 years agoMerge branch 'PHP-7.4'
Christoph M. Becker [Sun, 15 Sep 2019 13:14:46 +0000 (15:14 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Stick with zend_long for ABI compatibility

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Sun, 15 Sep 2019 13:14:02 +0000 (15:14 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Stick with zend_long for ABI compatibility

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Christoph M. Becker [Sun, 15 Sep 2019 13:13:13 +0000 (15:13 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Stick with zend_long for ABI compatibility

5 years agoStick with zend_long for ABI compatibility
Christoph M. Becker [Sun, 15 Sep 2019 13:11:25 +0000 (15:11 +0200)]
Stick with zend_long for ABI compatibility

Cf. <https://github.com/php/php-src/pull/4700#issuecomment-531515689>.

5 years agoMerge branch 'PHP-7.4'
Christoph M. Becker [Sat, 14 Sep 2019 16:49:00 +0000 (18:49 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fix #78535: auto_detect_line_endings value not parsed as bool

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Sat, 14 Sep 2019 16:47:53 +0000 (18:47 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Fix #78535: auto_detect_line_endings value not parsed as bool

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Christoph M. Becker [Sat, 14 Sep 2019 16:46:34 +0000 (18:46 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Fix #78535: auto_detect_line_endings value not parsed as bool

5 years agoFix #78535: auto_detect_line_endings value not parsed as bool
bugreportuser [Thu, 12 Sep 2019 18:44:08 +0000 (12:44 -0600)]
Fix #78535: auto_detect_line_endings value not parsed as bool

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Sat, 14 Sep 2019 10:10:15 +0000 (12:10 +0200)]
Merge branch 'PHP-7.4'

5 years agoFix double-free on invalid large octal with separators
Nikita Popov [Sat, 14 Sep 2019 10:08:20 +0000 (12:08 +0200)]
Fix double-free on invalid large octal with separators

To clean up the mess here a bit, check for invalid octal digits
with an explicit loop instead of mixing this into the string to
number conversion.

Also clean up some type usage.

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Fri, 13 Sep 2019 22:25:39 +0000 (00:25 +0200)]
Merge branch 'PHP-7.4'

5 years agoUse XtOffsetOf() in url_scanner_ex
Nikita Popov [Fri, 13 Sep 2019 22:00:04 +0000 (00:00 +0200)]
Use XtOffsetOf() in url_scanner_ex

Instead of a manual implementation.

5 years agoFix symtable_cache_limit assignment in phpdbg
Nikita Popov [Fri, 13 Sep 2019 21:49:50 +0000 (23:49 +0200)]
Fix symtable_cache_limit assignment in phpdbg

The meaning of the limit changed in 7.4, it now points one past the
end. Adjust code accordingly.

5 years agoFix tautological compare warning
David Carlier [Fri, 13 Sep 2019 10:37:53 +0000 (11:37 +0100)]
Fix tautological compare warning

The ZEND_ALLOCATOR() macro compares against constants that are
larger than the unsigned short type, resulting in warnings on
clang. Avoid this by explicitly casting to size_t.

5 years agoDefine OBJ_PROP_TO_OFFSET() using XtOffsetOf()
Nikita Popov [Fri, 13 Sep 2019 20:04:58 +0000 (22:04 +0200)]
Define OBJ_PROP_TO_OFFSET() using XtOffsetOf()

This avoids null pointer arithmetic UB.

5 years agoInclude stddef.h in zend_portability.h for offsetof() macro
Nikita Popov [Fri, 13 Sep 2019 19:52:17 +0000 (21:52 +0200)]
Include stddef.h in zend_portability.h for offsetof() macro

This makes sure that we use compiler builtins when they are
available and thus avoid ubsan warnings in clang.

And also reindent the fallback implementation.

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Fri, 13 Sep 2019 16:23:47 +0000 (18:23 +0200)]
Merge branch 'PHP-7.4'

5 years agoFix use-after-free in assign-ref compilation
Nikita Popov [Fri, 13 Sep 2019 15:09:24 +0000 (17:09 +0200)]
Fix use-after-free in assign-ref compilation

zend_emit_op_data may reallocate the op_array, so the assignment
of the RETURNS_FUNCTION flag may happen on an outdated opline.

Restructure the code a bit to set the flag before calling
zend_emit_op_data().

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Fri, 13 Sep 2019 12:37:28 +0000 (14:37 +0200)]
Merge branch 'PHP-7.4'

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Fri, 13 Sep 2019 12:37:15 +0000 (14:37 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

5 years agoFix bug #78525
Nikita Popov [Thu, 12 Sep 2019 11:17:27 +0000 (13:17 +0200)]
Fix bug #78525

When calling free_result_buffers(), also free field metadata and
restore the mempool state to what it was before any allocations
have been made. Remove the mempool save/restore logic for the
inner result set as this is now handled on a higher level.

5 years agoMerge branch 'PHP-7.4'
Dmitry Stogov [Fri, 13 Sep 2019 09:39:45 +0000 (12:39 +0300)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Make constant and copy propagation only for IS_TMP_VAR operands

5 years agoMake constant and copy propagation only for IS_TMP_VAR operands
Dmitry Stogov [Fri, 13 Sep 2019 09:38:57 +0000 (12:38 +0300)]
Make constant and copy propagation only for IS_TMP_VAR operands

5 years agoMerge branch 'PHP-7.4'
Dmitry Stogov [Fri, 13 Sep 2019 09:13:25 +0000 (12:13 +0300)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fixed incorrect usage of QM_ASSIGN instruction

5 years agoFixed incorrect usage of QM_ASSIGN instruction
Dmitry Stogov [Fri, 13 Sep 2019 09:08:59 +0000 (12:08 +0300)]
Fixed incorrect usage of QM_ASSIGN instruction

5 years agoMerge branch 'PHP-7.4'
Dmitry Stogov [Thu, 12 Sep 2019 22:43:40 +0000 (01:43 +0300)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fixed bug #78531 (Crash when using undefined variable as object

5 years agoFixed bug #78531 (Crash when using undefined variable as object
Dmitry Stogov [Thu, 12 Sep 2019 22:42:02 +0000 (01:42 +0300)]
Fixed bug #78531 (Crash when using undefined variable as object

5 years agoUse zval_try_get_tmp_string() instead of zval_get_tmp_string() for cheaper EG(excepti...
Dmitry Stogov [Thu, 12 Sep 2019 21:20:06 +0000 (00:20 +0300)]
Use zval_try_get_tmp_string() instead of zval_get_tmp_string() for cheaper EG(exception) check

5 years agoAvoid reloading
Dmitry Stogov [Thu, 12 Sep 2019 17:13:31 +0000 (20:13 +0300)]
Avoid reloading

5 years agoReorder conditions
Dmitry Stogov [Thu, 12 Sep 2019 16:43:45 +0000 (19:43 +0300)]
Reorder conditions

5 years agoMerge branch 'PHP-7.4'
Dmitry Stogov [Thu, 12 Sep 2019 15:53:26 +0000 (18:53 +0300)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Load string once

5 years agoLoad string once
Dmitry Stogov [Thu, 12 Sep 2019 15:46:13 +0000 (18:46 +0300)]
Load string once

5 years agoMerge branch 'PHP-7.4'
Dmitry Stogov [Thu, 12 Sep 2019 15:29:58 +0000 (18:29 +0300)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Eliminate checks using ZEND_CONST_COND() macro

5 years agoEliminate checks using ZEND_CONST_COND() macro
Dmitry Stogov [Thu, 12 Sep 2019 15:29:19 +0000 (18:29 +0300)]
Eliminate checks using ZEND_CONST_COND() macro

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Thu, 12 Sep 2019 14:41:45 +0000 (16:41 +0200)]
Merge branch 'PHP-7.4'

5 years agoAllow throwing exception while loading parent class
Nikita Popov [Wed, 11 Sep 2019 13:31:04 +0000 (15:31 +0200)]
Allow throwing exception while loading parent class

This is a fix for symfony/symfony#32995.

The behavior is:

* Throwing exception when loading parent/interface is allowed
  (and we will also throw one if the class is simply not found).
* If this happens, the bucket key for the class is reset, so
  it's possibly to try registering the same class again.
* However, if the class has already been used due to a variance
  obligation, the exception is upgraded to a fatal error, as we
  cannot safely unregister the class stub anymore.

5 years agoMerge branch 'PHP-7.4'
Christoph M. Becker [Thu, 12 Sep 2019 07:14:27 +0000 (09:14 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fix exif build
  NEWS

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Thu, 12 Sep 2019 07:14:08 +0000 (09:14 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Fix exif build
  NEWS

5 years agoFix exif build
Christoph M. Becker [Thu, 12 Sep 2019 07:11:14 +0000 (09:11 +0200)]
Fix exif build

As of PHP 7.3.0 the `model` field is removed.

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Kalle Sommer Nielsen [Thu, 12 Sep 2019 03:52:24 +0000 (06:52 +0300)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  NEWS

5 years agoNEWS
Kalle Sommer Nielsen [Thu, 12 Sep 2019 03:50:53 +0000 (06:50 +0300)]
NEWS

5 years agoMerge branch 'PHP-7.4'
Kalle Sommer Nielsen [Thu, 12 Sep 2019 03:34:35 +0000 (06:34 +0300)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fixed bug #78442 ('Illegal component' on exif_read_data since PHP7)

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Kalle Sommer Nielsen [Thu, 12 Sep 2019 03:33:40 +0000 (06:33 +0300)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Fixed bug #78442 ('Illegal component' on exif_read_data since PHP7)

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Kalle Sommer Nielsen [Thu, 12 Sep 2019 03:31:52 +0000 (06:31 +0300)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Fixed bug #78442 ('Illegal component' on exif_read_data since PHP7)

5 years agoFixed bug #78442 ('Illegal component' on exif_read_data since PHP7)
Kalle Sommer Nielsen [Thu, 12 Sep 2019 03:21:39 +0000 (06:21 +0300)]
Fixed bug #78442 ('Illegal component' on exif_read_data since PHP7)

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Wed, 11 Sep 2019 15:05:07 +0000 (17:05 +0200)]
Merge branch 'PHP-7.4'

5 years agoImprove "already declared" error message
Nikita Popov [Wed, 11 Sep 2019 15:04:13 +0000 (17:04 +0200)]
Improve "already declared" error message

If this error is missing because the rtd_key was renamed to lcname,
fetch the class based on lcname and use the class type and cased
name from there.

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Wed, 11 Sep 2019 14:51:30 +0000 (16:51 +0200)]
Merge branch 'PHP-7.4'

5 years agoFix typo in unlinked_instanceof assertion
Nikita Popov [Wed, 11 Sep 2019 14:50:16 +0000 (16:50 +0200)]
Fix typo in unlinked_instanceof assertion

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Wed, 11 Sep 2019 14:30:59 +0000 (16:30 +0200)]
Merge branch 'PHP-7.4'

5 years agoOnly allow "nearly linked" classes for parent/interface
Nikita Popov [Wed, 11 Sep 2019 14:27:28 +0000 (16:27 +0200)]
Only allow "nearly linked" classes for parent/interface

The requirements for parent/interface are difference than for the
variance checks in type declarations. The latter can work on fully
unlinked classes, but the former need inheritance to be essentially
finished, only variance checks may still be outstanding.

Adding a new flag for this because we have lots of space, but we
could also represent these "inheritance states" more compactly in
the future.

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Wed, 11 Sep 2019 10:02:39 +0000 (12:02 +0200)]
Merge branch 'PHP-7.4'

5 years agoSpecify -fsanitize-no-recover
Nikita Popov [Tue, 3 Sep 2019 08:06:09 +0000 (10:06 +0200)]
Specify -fsanitize-no-recover

To make it more obvious when there are ubsan failures.

5 years agoImprove Symfony test setup
Nicolas Grekas [Tue, 3 Sep 2019 08:02:30 +0000 (10:02 +0200)]
Improve Symfony test setup

Perform PHPUnit installation under php7.3 -- which will also make
it work on master.

Also properly resolve the tty issue by specifying excluded groups
during the test run.

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Wed, 11 Sep 2019 09:13:33 +0000 (11:13 +0200)]
Merge branch 'PHP-7.4'

5 years agoFree history_get_history_state() result
Nikita Popov [Wed, 11 Sep 2019 08:59:04 +0000 (10:59 +0200)]
Free history_get_history_state() result

It's not documented, but per https://bugs.python.org/issue8065
the result is freshly malloc'd and needs to be freed.

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Wed, 11 Sep 2019 08:32:27 +0000 (10:32 +0200)]
Merge branch 'PHP-7.4'

5 years agoFix another pointer indexing UB in http_fopen_wrapper
Nikita Popov [Wed, 11 Sep 2019 08:31:03 +0000 (10:31 +0200)]
Fix another pointer indexing UB in http_fopen_wrapper

Only compute the gep after checking whether the pointer is NULL.

5 years agoFixed bug #78506
Nikita Popov [Wed, 11 Sep 2019 08:27:32 +0000 (10:27 +0200)]
Fixed bug #78506

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Wed, 11 Sep 2019 07:53:18 +0000 (09:53 +0200)]
Merge branch 'PHP-7.4'

5 years agoPreloading: Fix handling of static vars in inherited methods
Nikita Popov [Wed, 11 Sep 2019 07:52:31 +0000 (09:52 +0200)]
Preloading: Fix handling of static vars in inherited methods

Part of bug #78512.

5 years agoMerge branch 'PHP-7.4'
Dmitry Stogov [Tue, 10 Sep 2019 21:53:30 +0000 (00:53 +0300)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fixed bad format string

5 years agoFixed bad format string
Dmitry Stogov [Tue, 10 Sep 2019 21:52:54 +0000 (00:52 +0300)]
Fixed bad format string

5 years agoMerge branch 'PHP-7.4'
Sara Golemon [Tue, 10 Sep 2019 17:05:56 +0000 (13:05 -0400)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Bump for 7.2.24

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Sara Golemon [Tue, 10 Sep 2019 17:05:38 +0000 (13:05 -0400)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Bump for 7.2.24

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Sara Golemon [Tue, 10 Sep 2019 17:05:17 +0000 (13:05 -0400)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Bump for 7.2.24

5 years agoBump for 7.2.24
Sara Golemon [Tue, 10 Sep 2019 17:03:27 +0000 (13:03 -0400)]
Bump for 7.2.24

5 years agoMerge branch 'PHP-7.4'
Remi Collet [Tue, 10 Sep 2019 14:30:39 +0000 (16:30 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Raise minimal GCC version, Test with 4.8 is OK With 4.4: error: #pragma GCC diagnostic not allowed inside functions

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Remi Collet [Tue, 10 Sep 2019 14:29:44 +0000 (16:29 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Raise minimal GCC version, Test with 4.8 is OK With 4.4: error: #pragma GCC diagnostic not allowed inside functions

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Remi Collet [Tue, 10 Sep 2019 14:29:30 +0000 (16:29 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Raise minimal GCC version, Test with 4.8 is OK With 4.4: error: #pragma GCC diagnostic not allowed inside functions

5 years agoRaise minimal GCC version,
Remi Collet [Tue, 10 Sep 2019 14:28:35 +0000 (16:28 +0200)]
Raise minimal GCC version,
Test with 4.8 is OK
With 4.4: error: #pragma GCC diagnostic not allowed inside functions

5 years agoMerge branch 'PHP-7.4'
Christoph M. Becker [Tue, 10 Sep 2019 13:13:52 +0000 (15:13 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  PHP 7.3.10RC1 has been tagged

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Tue, 10 Sep 2019 13:13:11 +0000 (15:13 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  PHP 7.3.10RC1 has been tagged

5 years agoPHP 7.3.10RC1 has been tagged
Christoph M. Becker [Tue, 10 Sep 2019 13:11:54 +0000 (15:11 +0200)]
PHP 7.3.10RC1 has been tagged

5 years agoupgrading notes for ValueError/zend_value_error()
Peter Cowburn [Tue, 10 Sep 2019 12:18:53 +0000 (13:18 +0100)]
upgrading notes for ValueError/zend_value_error()

5 years agoceanup
Dmitry Stogov [Tue, 10 Sep 2019 12:12:42 +0000 (15:12 +0300)]
ceanup

5 years agoPrefer ValueError over Error in GD
Christoph M. Becker [Tue, 10 Sep 2019 10:36:57 +0000 (12:36 +0200)]
Prefer ValueError over Error in GD

Cf. <https://github.com/php/php-src/pull/4682>.

5 years agoPort various autoconf bits to C99 compilers
Florian Weimer [Mon, 9 Sep 2019 19:29:03 +0000 (21:29 +0200)]
Port various autoconf bits to C99 compilers

C99 no longer has implicit function declarations and implicit ints.
Current GCC versions enable them as an extension, but this will
change in a future GCC version.

5 years agoMerge branch 'PHP-7.4'
Dmitry Stogov [Tue, 10 Sep 2019 08:34:08 +0000 (11:34 +0300)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  NEWS entry, test and minor cleanup for FFI::isNull()
  add FFI::isNull() to check whether a FFI\CData is a null pointer

5 years agoMerge branch 'master' of git.php.net:php-src
Dmitry Stogov [Tue, 10 Sep 2019 08:23:53 +0000 (11:23 +0300)]
Merge branch 'master' of git.php.net:php-src

* 'master' of git.php.net:php-src:
  Drop regression test

5 years agoNEWS entry, test and minor cleanup for FFI::isNull()
Dmitry Stogov [Tue, 10 Sep 2019 08:23:12 +0000 (11:23 +0300)]
NEWS entry, test and minor cleanup for FFI::isNull()

5 years agoMerge branch 'PHP-7.4' of git.php.net:php-src into PHP-7.4
Dmitry Stogov [Tue, 10 Sep 2019 08:22:05 +0000 (11:22 +0300)]
Merge branch 'PHP-7.4' of git.php.net:php-src into PHP-7.4

* 'PHP-7.4' of git.php.net:php-src:
  Drop regression test

5 years agoMerge branch 'PHP-7.4'
Christoph M. Becker [Tue, 10 Sep 2019 08:09:02 +0000 (10:09 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Drop regression test

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Tue, 10 Sep 2019 08:08:42 +0000 (10:08 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Drop regression test

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Christoph M. Becker [Tue, 10 Sep 2019 08:08:07 +0000 (10:08 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Drop regression test

5 years agoDrop regression test
Christoph M. Becker [Tue, 10 Sep 2019 08:07:39 +0000 (10:07 +0200)]
Drop regression test

The state returned by `sodium_crypto_generichash_init()` has to be
regarded as opaque byte string; neither its size nor its exact
structure are fixed, and actually vary for diffent libsodium versions.
Therefore we drop the test altogether.

5 years agoadd FFI::isNull() to check whether a FFI\CData is a null pointer
Philip Hofstetter [Mon, 9 Sep 2019 11:14:59 +0000 (13:14 +0200)]
add FFI::isNull() to check whether a FFI\CData is a null pointer

5 years agoMerge branch 'PHP-7.4'
Dmitry Stogov [Tue, 10 Sep 2019 08:02:03 +0000 (11:02 +0300)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Stop after exceptions

5 years agoStop after exceptions
Dmitry Stogov [Tue, 10 Sep 2019 08:01:36 +0000 (11:01 +0300)]
Stop after exceptions

5 years agoMerge branch 'PHP-7.4'
Christoph M. Becker [Tue, 10 Sep 2019 07:23:05 +0000 (09:23 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Request #77863: PDO firebird support type Boolean in input parameters

5 years agoRequest #77863: PDO firebird support type Boolean in input parameters
Simonov Denis [Tue, 10 Sep 2019 07:22:26 +0000 (09:22 +0200)]
Request #77863: PDO firebird support type Boolean in input parameters

5 years agoraise ValueError from imagecreate/imagecreatetruecolor
Peter Cowburn [Wed, 4 Sep 2019 20:42:43 +0000 (21:42 +0100)]
raise ValueError from imagecreate/imagecreatetruecolor

Raise a ValueError instead of a plain Error when calling imagecreate()
or imagecreatetruecolor() with too big or small values for the width or
height arguments.

5 years agoadd ValueError
Peter Cowburn [Wed, 4 Sep 2019 20:39:02 +0000 (21:39 +0100)]
add ValueError

ValueError is intended to be thrown when a function or method receives
an argument that has the right type (incorrect type should throw a
TypeError) but an inappropriate value.

5 years agoclenup
Dmitry Stogov [Mon, 9 Sep 2019 19:40:28 +0000 (22:40 +0300)]
clenup

5 years agoAvoid hash value recalculation on each counter update
Dmitry Stogov [Mon, 9 Sep 2019 18:25:54 +0000 (21:25 +0300)]
Avoid hash value recalculation on each counter update

5 years agoMerge branch 'PHP-7.4'
Christoph M. Becker [Mon, 9 Sep 2019 17:06:43 +0000 (19:06 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  new_variable '{' expr '}' is deprecated as well

5 years agonew_variable '{' expr '}' is deprecated as well
Christoph M. Becker [Mon, 9 Sep 2019 14:57:23 +0000 (16:57 +0200)]
new_variable '{' expr '}' is deprecated as well

Curly brace syntax for accessing array elements and string offsets is
deprecated [1]; this should also be the case for respective `new`
expressions.

This issue has been reported by brzuchal@php.net.

[1] <https://wiki.php.net/rfc/deprecate_curly_braces_array_access>

5 years agoMention that arg_info[-1] holds the return info
Ivan Enderlin [Mon, 2 Sep 2019 11:32:40 +0000 (13:32 +0200)]
Mention that arg_info[-1] holds the return info

I lost some time trying to know how to find the returned type.
It's not that obvious it is stored in the _argument_ information array.

For the sake of Internet, here is the full code checking that a function _has_ a returned type:

```c
zend_function *function = /* e.g. fci_cache->function_handler */;

if (!(function->op_array.fn_flags & ZEND_ACC_HAS_RETURN_TYPE)) {
    php_printf("no return type\n");
} else {
    php_printf("has a return type\n");
    php_printf("return type = %s\n", zend_get_type_by_const(ZEND_TYPE_CODE(function->common.arg_info[-1].type)));
}
```

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Mon, 9 Sep 2019 15:30:07 +0000 (17:30 +0200)]
Merge branch 'PHP-7.4'