]> granicus.if.org Git - php/log
php
6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Tue, 20 Nov 2018 20:16:19 +0000 (21:16 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

6 years agoDefine __APPLE_USE_RFC_3542 for new ipv6 constants
Mizunashi Mana [Sat, 10 Nov 2018 18:17:11 +0000 (03:17 +0900)]
Define __APPLE_USE_RFC_3542 for new ipv6 constants

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Sara Golemon [Tue, 20 Nov 2018 19:41:31 +0000 (14:41 -0500)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Bump for 7.2.14

6 years agoBump for 7.2.14
Sara Golemon [Tue, 20 Nov 2018 19:40:21 +0000 (14:40 -0500)]
Bump for 7.2.14

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Stanislav Malyshev [Tue, 20 Nov 2018 19:19:51 +0000 (11:19 -0800)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Disable rsh/ssh functionality in imap by default (bug #77153)

6 years agoDisable rsh/ssh functionality in imap by default (bug #77153)
Stanislav Malyshev [Mon, 19 Nov 2018 01:10:43 +0000 (17:10 -0800)]
Disable rsh/ssh functionality in imap by default (bug #77153)

6 years agoDisable rsh/ssh functionality in imap by default (bug #77153)
Stanislav Malyshev [Mon, 19 Nov 2018 01:10:43 +0000 (17:10 -0800)]
Disable rsh/ssh functionality in imap by default (bug #77153)

6 years ago[ci skip] Update NEWS wrt. php-7.3.0RC6 tagging
Christoph M. Becker [Tue, 20 Nov 2018 12:36:10 +0000 (13:36 +0100)]
[ci skip] Update NEWS wrt. php-7.3.0RC6 tagging

6 years agoNEWS
Remi Collet [Tue, 20 Nov 2018 10:20:40 +0000 (11:20 +0100)]
NEWS

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Remi Collet [Tue, 20 Nov 2018 10:20:26 +0000 (11:20 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  NEWS
  NEWS
  Fix #77151 ftp_close(): SSL_read on shutdown

6 years agoNEWS
Remi Collet [Tue, 20 Nov 2018 10:20:05 +0000 (11:20 +0100)]
NEWS

6 years agoMerge branch 'PHP-7.1' into PHP-7.2
Remi Collet [Tue, 20 Nov 2018 10:19:52 +0000 (11:19 +0100)]
Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
  NEWS
  Fix #77151 ftp_close(): SSL_read on shutdown

6 years agoNEWS
Remi Collet [Tue, 20 Nov 2018 10:19:29 +0000 (11:19 +0100)]
NEWS

6 years agoFix #77151 ftp_close(): SSL_read on shutdown
Remi Collet [Thu, 15 Nov 2018 07:58:08 +0000 (08:58 +0100)]
Fix #77151 ftp_close(): SSL_read on shutdown

Regression introduced in fix for #76972

only display the error message when sslerror
or if errno is set (for SSL_ERROR_SYSCALL case)

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Anatol Belski [Sun, 18 Nov 2018 13:41:14 +0000 (14:41 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  [ci skip] Update NEWS
  [ci skip] Update NEWS

6 years ago[ci skip] Update NEWS
Anatol Belski [Sun, 18 Nov 2018 13:40:00 +0000 (14:40 +0100)]
[ci skip] Update NEWS

6 years ago[ci skip] Update NEWS
Anatol Belski [Sun, 18 Nov 2018 13:38:35 +0000 (14:38 +0100)]
[ci skip] Update NEWS

6 years agoMerge branch 'PHP-7.1' into PHP-7.2
Anatol Belski [Sun, 18 Nov 2018 13:37:56 +0000 (14:37 +0100)]
Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
  [ci skip] Update NEWS

6 years ago[ci skip] Update NEWS
Anatol Belski [Sun, 18 Nov 2018 13:37:04 +0000 (14:37 +0100)]
[ci skip] Update NEWS

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Anatol Belski [Sun, 18 Nov 2018 11:33:35 +0000 (12:33 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Fixed bug #77047 pg_convert has a broken regex for the 'TIME WITHOUT TIMEZONE' data type

6 years agoMerge branch 'PHP-7.1' into PHP-7.2
Anatol Belski [Sun, 18 Nov 2018 11:32:47 +0000 (12:32 +0100)]
Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
  Fixed bug #77047 pg_convert has a broken regex for the 'TIME WITHOUT TIMEZONE' data type

6 years agoFixed bug #77047 pg_convert has a broken regex for the 'TIME WITHOUT TIMEZONE' data...
Anatol Belski [Sun, 18 Nov 2018 11:29:34 +0000 (12:29 +0100)]
Fixed bug #77047 pg_convert has a broken regex for the 'TIME WITHOUT TIMEZONE' data type

Backport 369c991d and 282a63da to 7.1, closes #3634

6 years agoAdd test for bug #77047
Anatol Belski [Sun, 18 Nov 2018 10:52:00 +0000 (11:52 +0100)]
Add test for bug #77047

6 years agoFIX #77047: fixes regex for "time" data type
andy [Mon, 22 Oct 2018 14:57:28 +0000 (08:57 -0600)]
FIX #77047: fixes regex for "time" data type

6 years ago[ci skip] Update NEWS
Anatol Belski [Sat, 17 Nov 2018 22:01:17 +0000 (23:01 +0100)]
[ci skip] Update NEWS

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Anatol Belski [Sat, 17 Nov 2018 22:00:50 +0000 (23:00 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  [ci skip] Update NEWS

6 years ago[ci skip] Update NEWS
Anatol Belski [Sat, 17 Nov 2018 22:00:12 +0000 (23:00 +0100)]
[ci skip] Update NEWS

6 years agoSimplify assignment on 64-bit
Anatol Belski [Sat, 17 Nov 2018 21:56:39 +0000 (22:56 +0100)]
Simplify assignment on 64-bit

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Anatol Belski [Fri, 16 Nov 2018 22:22:19 +0000 (23:22 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Fixed bug #77111 php-win.exe corrupts unicode symbols from cli parameters

6 years agoFixed bug #77111 php-win.exe corrupts unicode symbols from cli parameters
Anatol Belski [Fri, 16 Nov 2018 22:19:33 +0000 (23:19 +0100)]
Fixed bug #77111 php-win.exe corrupts unicode symbols from cli parameters

The binary can be of course used on console, for whatever reasons, so
UNICODE API should be used in that case. That might however not work as
expected, if the binary is used for a service.

6 years agoFixed bug #77165
Nikita Popov [Thu, 15 Nov 2018 16:13:12 +0000 (17:13 +0100)]
Fixed bug #77165

Also add some helper macros for PROTECT/UNPROTECT that check for
IMMUTABLE. These checks are needed for nearly any use of
PROTECT/UNPROTECT.

6 years agoRework magic data once more
Anatol Belski [Wed, 14 Nov 2018 21:23:24 +0000 (22:23 +0100)]
Rework magic data once more

The change reduces the input size on patterns using posix character
classes. It is still better than reverting to the patterns from the
older version, as the upstream data uses posix classes also in the later
versions. The input reduction speeds up the pattern matching in some
cases.

This patch is functionally almost same as upstream, but might show some diff
when the input is very long. While the magic data in the newer versions is
functionally an improvement, with jit=0 it might show a performance regression.
The slowdown is negligible in the normal usage and is still acceptable for the
malicious input. If some functional regressions show up, this patch should be
reverted and the tests timing should be adapted instead.

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Christoph M. Becker [Wed, 14 Nov 2018 13:58:45 +0000 (14:58 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Fix #77147: Fix for 60494 ignores ICONV_MIME_DECODE_CONTINUE_ON_ERROR

6 years agoMerge branch 'PHP-7.1' into PHP-7.2
Christoph M. Becker [Wed, 14 Nov 2018 13:56:41 +0000 (14:56 +0100)]
Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
  Fix #77147: Fix for 60494 ignores ICONV_MIME_DECODE_CONTINUE_ON_ERROR

6 years agoFix #77147: Fix for 60494 ignores ICONV_MIME_DECODE_CONTINUE_ON_ERROR
Christoph M. Becker [Wed, 14 Nov 2018 13:55:38 +0000 (14:55 +0100)]
Fix #77147: Fix for 60494 ignores ICONV_MIME_DECODE_CONTINUE_ON_ERROR

If the `ICONV_MIME_DECODE_CONTINUE_ON_ERROR` flag is set, parsing
should not fail, if there are illegal characters in the headers;
instead we silently ignore these like before.

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Joe Watkins [Tue, 13 Nov 2018 11:59:50 +0000 (12:59 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Validate length on socket_write

6 years agoMerge branch 'PHP-7.1' into PHP-7.2
Joe Watkins [Tue, 13 Nov 2018 11:57:38 +0000 (12:57 +0100)]
Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
  Validate length on socket_write

6 years agoValidate length on socket_write
Thiago Carvalho [Sun, 21 Oct 2018 19:42:29 +0000 (21:42 +0200)]
Validate length on socket_write

6 years agoFix compilation on x32
Jan Rękorajski [Wed, 24 Oct 2018 21:02:33 +0000 (23:02 +0200)]
Fix compilation on x32

Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Christoph M. Becker [Mon, 12 Nov 2018 22:24:17 +0000 (23:24 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Fix #77141: Signedness issue in SOAP when precision=-1

6 years agoMerge branch 'PHP-7.1' into PHP-7.2
Christoph M. Becker [Mon, 12 Nov 2018 22:21:04 +0000 (23:21 +0100)]
Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
  Fix #77141: Signedness issue in SOAP when precision=-1

6 years agoFix #77141: Signedness issue in SOAP when precision=-1
Christoph M. Becker [Mon, 12 Nov 2018 22:00:25 +0000 (23:00 +0100)]
Fix #77141: Signedness issue in SOAP when precision=-1

According to php_gcvt(), we assume at most 17 fractional digits for
negative precision.

6 years agoUpdate libmagic.patch [ci skip]
Anatol Belski [Sat, 10 Nov 2018 21:02:44 +0000 (22:02 +0100)]
Update libmagic.patch [ci skip]

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Anatol Belski [Sat, 10 Nov 2018 21:02:24 +0000 (22:02 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Update libmagic.patch [ci skip]

6 years agoUpdate libmagic.patch [ci skip]
Anatol Belski [Sat, 10 Nov 2018 21:01:49 +0000 (22:01 +0100)]
Update libmagic.patch [ci skip]

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Anatol Belski [Sat, 10 Nov 2018 19:07:25 +0000 (20:07 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Fork test with pcre.jit=0

6 years agoFork test with pcre.jit=0
Anatol Belski [Sat, 10 Nov 2018 19:05:56 +0000 (20:05 +0100)]
Fork test with pcre.jit=0

6 years agoRework magic data
Anatol Belski [Sat, 10 Nov 2018 17:22:44 +0000 (18:22 +0100)]
Rework magic data

Still upstream contains some slower patterns. Those might need to
be patched, if regressions arise.

6 years agoFix regex
Anatol Belski [Sat, 10 Nov 2018 11:13:03 +0000 (12:13 +0100)]
Fix regex

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Anatol Belski [Sat, 10 Nov 2018 11:12:25 +0000 (12:12 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Fix regex

6 years agoFix regex
Anatol Belski [Sat, 10 Nov 2018 11:11:02 +0000 (12:11 +0100)]
Fix regex

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Anatol Belski [Sat, 10 Nov 2018 00:32:35 +0000 (01:32 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Rework magic data

6 years agoRework magic data
Anatol Belski [Sat, 10 Nov 2018 00:28:23 +0000 (01:28 +0100)]
Rework magic data

Avoid patching where vanilla data suffices. More precisely, avoid data
using [:space:] posix class in regex, as it is likely to cause performance
regressions.

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Anatol Belski [Fri, 9 Nov 2018 23:20:39 +0000 (00:20 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Sync one more upstream libmagic piece

6 years agoSync one more upstream libmagic piece
Anatol Belski [Fri, 9 Nov 2018 23:18:30 +0000 (00:18 +0100)]
Sync one more upstream libmagic piece

6 years ago[ci skip] Update NEWS wrt. php-7.3.0RC5 tagging
Christoph M. Becker [Tue, 6 Nov 2018 10:45:18 +0000 (11:45 +0100)]
[ci skip] Update NEWS wrt. php-7.3.0RC5 tagging

6 years agoUpdate NEWS [ci skip]
Anatol Belski [Mon, 5 Nov 2018 21:53:45 +0000 (22:53 +0100)]
Update NEWS [ci skip]

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Anatol Belski [Mon, 5 Nov 2018 21:53:19 +0000 (22:53 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Update NEWS [ci skip]

6 years agoUpdate NEWS [ci skip]
Anatol Belski [Mon, 5 Nov 2018 21:53:01 +0000 (22:53 +0100)]
Update NEWS [ci skip]

6 years agoUpdate libmagic.patch [ci skip]
Anatol Belski [Mon, 5 Nov 2018 21:25:31 +0000 (22:25 +0100)]
Update libmagic.patch [ci skip]

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Anatol Belski [Mon, 5 Nov 2018 21:25:04 +0000 (22:25 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Update libmagic.patch [ci skip]

6 years agoUpdate libmagic.patch [ci skip]
Anatol Belski [Mon, 5 Nov 2018 21:22:49 +0000 (22:22 +0100)]
Update libmagic.patch [ci skip]

6 years agoDeclare function proto in header
Anatol Belski [Mon, 5 Nov 2018 20:29:35 +0000 (21:29 +0100)]
Declare function proto in header

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Anatol Belski [Mon, 5 Nov 2018 20:29:06 +0000 (21:29 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Declare function proto in header

6 years agoDeclare function proto in header
Anatol Belski [Mon, 5 Nov 2018 20:28:04 +0000 (21:28 +0100)]
Declare function proto in header

6 years agoFix #76825: Undefined symbols ___cpuid_count
Christoph M. Becker [Mon, 5 Nov 2018 17:24:39 +0000 (18:24 +0100)]
Fix #76825: Undefined symbols ___cpuid_count

Apparently, the presence of `cpuid.h` is not necessarily sufficient to
guarantee the availability of `__cpuid_count()`.  We therefore test for
the latter explicitly.

6 years agoNEWS
Remi Collet [Mon, 5 Nov 2018 16:06:40 +0000 (17:06 +0100)]
NEWS

6 years agoFix: #77110 undefined symbol zend_string_equal_val in C++ build
Remi Collet [Mon, 5 Nov 2018 16:05:49 +0000 (17:05 +0100)]
Fix: #77110 undefined symbol zend_string_equal_val in C++ build

6 years agoImplement handling for JIT recognition when cross compiling
Anatol Belski [Mon, 5 Nov 2018 00:15:09 +0000 (01:15 +0100)]
Implement handling for JIT recognition when cross compiling

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Anatol Belski [Sun, 4 Nov 2018 15:59:27 +0000 (16:59 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Backport 7f5f4601 for 7.2

6 years agoBackport 7f5f4601 for 7.2
Anatol Belski [Sun, 4 Nov 2018 15:56:43 +0000 (16:56 +0100)]
Backport 7f5f4601 for 7.2

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Christoph M. Becker [Sun, 4 Nov 2018 15:46:27 +0000 (16:46 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Fix #76348: WSDL_CACHE_MEMORY causes Segmentation fault

6 years agoMerge branch 'PHP-7.1' into PHP-7.2
Christoph M. Becker [Sun, 4 Nov 2018 15:44:06 +0000 (16:44 +0100)]
Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
  Fix #76348: WSDL_CACHE_MEMORY causes Segmentation fault

6 years agoFix #76348: WSDL_CACHE_MEMORY causes Segmentation fault
Christoph M. Becker [Sun, 4 Nov 2018 15:40:27 +0000 (16:40 +0100)]
Fix #76348: WSDL_CACHE_MEMORY causes Segmentation fault

“Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end.”

6 years agoRework places in libmagic regarding previous CVE-2014-3538 fixes
Anatol Belski [Sun, 4 Nov 2018 12:11:28 +0000 (13:11 +0100)]
Rework places in libmagic regarding previous CVE-2014-3538 fixes

CVE-2014-3538 was fixed upstream, but the old patch was still kept in
the PHP port. This patch causes performance regressions when PCRE JIT is
not enabled. This is fixed by applying the relevant original code from
the newer libmagic, which makes the old patch obsolete as the
CVE-2014-3538 tests still pass.

6 years agoChange the way JIT availability is checked
Anatol Belski [Sat, 3 Nov 2018 19:29:51 +0000 (20:29 +0100)]
Change the way JIT availability is checked

The pcre2_jit_compile_8 sysmbol is always available, even JIT might be
not. If JIT is not enabled explicitly and is enabled in the PHP runtime,
this will lead to a malfunction. This approach ensures JIT is indeed
available on the given platform. For cross compilation this might get
complicated, as it would require an explicit processor architecture and
PCRE2 version check.

Another solution for this case is to run pcre2_config at runtime. That
however would require more condition checks that would impact
architectures where JIT is available.

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Fri, 2 Nov 2018 13:30:23 +0000 (14:30 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

6 years agoFixed bug #77092
Nikita Popov [Fri, 2 Nov 2018 13:26:24 +0000 (14:26 +0100)]
Fixed bug #77092

Weird that this worked for so long, probably because nearly all
ext/standard functions use fast ZPP rather than ordinary ZPP.

6 years agoFuture-proof email addresses
Zeev Suraski [Thu, 1 Nov 2018 16:35:32 +0000 (18:35 +0200)]
Future-proof email addresses

6 years agoFix stray newline that caused this test to fail
Rasmus Lerdorf [Wed, 31 Oct 2018 18:41:17 +0000 (11:41 -0700)]
Fix stray newline that caused this test to fail

6 years agoFix session tests that fail if error_log is set
Rasmus Lerdorf [Wed, 31 Oct 2018 17:58:45 +0000 (10:58 -0700)]
Fix session tests that fail if error_log is set

6 years agoThis test needs to log to stdout
Rasmus Lerdorf [Wed, 31 Oct 2018 17:43:45 +0000 (10:43 -0700)]
This test needs to log to stdout

6 years agoFix error condition
Anatol Belski [Tue, 30 Oct 2018 19:43:45 +0000 (20:43 +0100)]
Fix error condition

6 years agoFixed bug #77081 ftruncate() changes seek pointer in c mode
Anatol Belski [Tue, 30 Oct 2018 19:42:00 +0000 (20:42 +0100)]
Fixed bug #77081 ftruncate() changes seek pointer in c mode

6 years agoFix and improve test case
Christoph M. Becker [Tue, 30 Oct 2018 17:53:03 +0000 (18:53 +0100)]
Fix and improve test case

We fix the erroneous doctype declaration, clarify the expectation, and
add a comment to clarify the purpose of the tag mismatch in the XML.

6 years agoUpdated to version 2018.7 (2018g)
Derick Rethans [Tue, 30 Oct 2018 11:25:48 +0000 (11:25 +0000)]
Updated to version 2018.7 (2018g)

6 years agoEmpty merge
Derick Rethans [Tue, 30 Oct 2018 11:25:47 +0000 (11:25 +0000)]
Empty merge

6 years agoUpdated to version 2018.7 (2018g)
Derick Rethans [Tue, 30 Oct 2018 11:25:45 +0000 (11:25 +0000)]
Updated to version 2018.7 (2018g)

6 years ago[ci skip] Update NEWS
Peter Kokot [Mon, 29 Oct 2018 23:24:07 +0000 (00:24 +0100)]
[ci skip] Update NEWS

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Peter Kokot [Mon, 29 Oct 2018 23:23:38 +0000 (00:23 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  [ci skip] Update NEWS
  [ci skip] Update NEWS
  fix bug #77079

6 years ago[ci skip] Update NEWS
Peter Kokot [Mon, 29 Oct 2018 23:23:20 +0000 (00:23 +0100)]
[ci skip] Update NEWS

6 years agoMerge branch 'PHP-7.1' into PHP-7.2
Peter Kokot [Mon, 29 Oct 2018 23:22:26 +0000 (00:22 +0100)]
Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
  [ci skip] Update NEWS
  fix bug #77079

6 years ago[ci skip] Update NEWS
Peter Kokot [Mon, 29 Oct 2018 23:22:03 +0000 (00:22 +0100)]
[ci skip] Update NEWS

6 years agofix bug #77079
Jon Allen [Mon, 29 Oct 2018 13:44:37 +0000 (14:44 +0100)]
fix bug #77079

6 years agoFix mb_strrpos() with encoding passed as 3rd param
Nikita Popov [Mon, 29 Oct 2018 17:56:17 +0000 (18:56 +0100)]
Fix mb_strrpos() with encoding passed as 3rd param

6 years ago[ci skip] Update UPGRADING
Christoph M. Becker [Sun, 28 Oct 2018 11:48:07 +0000 (12:48 +0100)]
[ci skip] Update UPGRADING

PR #3317[1] is relevant for the migration guide, so we add a respective
note in UPGRADING.

[1] <https://github.com/php/php-src/pull/3317>

6 years agoFix #71592: External entity processing never fails
Christoph M. Becker [Sat, 27 Oct 2018 15:30:13 +0000 (17:30 +0200)]
Fix #71592: External entity processing never fails

If the callback set via `xml_set_external_entity_ref_handler()` returns
a falsy value, parsing is supposed to stop and the error number set to
`XML_ERROR_EXTERNAL_ENTITY_HANDLING`.  This is already correctly done
by the libexpat binding, but the libxml2 binding ignores the return
value.  We fix this by calling `xmlStopParser()` which is available as
of libxml 2.1.0[1] (PHP-7.1 requires at least libxml 2.6.11 anyway),
and setting the desired `errNo` ourselves.

[1] <http://xmlsoft.org/news.html>

6 years ago[ci skip] Fix indentation in UPGRADING.
Adam Harvey [Thu, 25 Oct 2018 18:55:43 +0000 (11:55 -0700)]
[ci skip] Fix indentation in UPGRADING.

6 years agoDon't optimize function if inference failed
Nikita Popov [Thu, 25 Oct 2018 14:31:10 +0000 (16:31 +0200)]
Don't optimize function if inference failed

This was respected only for the single-function optimizations, not
in func-info mode.

6 years agoMerge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Thu, 25 Oct 2018 14:44:07 +0000 (16:44 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3