]> granicus.if.org Git - curl/log
curl
15 years agoReplaced tabs with spaces
Yang Tse [Mon, 21 Dec 2009 02:37:23 +0000 (02:37 +0000)]
Replaced tabs with spaces

15 years agoremove some unused code
Daniel Stenberg [Sun, 20 Dec 2009 22:11:16 +0000 (22:11 +0000)]
remove some unused code

15 years agoImprove delay command interruptability
Yang Tse [Sun, 20 Dec 2009 22:09:53 +0000 (22:09 +0000)]
Improve delay command interruptability

15 years agorevert that, we already had a function named like that!
Daniel Stenberg [Sun, 20 Dec 2009 22:08:06 +0000 (22:08 +0000)]
revert that, we already had a function named like that!

15 years agorename the verifyftp function to verifyserver since it is used to verify
Daniel Stenberg [Sun, 20 Dec 2009 22:00:23 +0000 (22:00 +0000)]
rename the verifyftp function to verifyserver since it is used to verify
a wide variety of protocol servers

15 years agofree the allocated mailbox name at disconnect
Daniel Stenberg [Sun, 20 Dec 2009 11:10:08 +0000 (11:10 +0000)]
free the allocated mailbox name at disconnect

15 years agointroducing the first IMAP FETCH test
Daniel Stenberg [Sun, 20 Dec 2009 11:07:04 +0000 (11:07 +0000)]
introducing the first IMAP FETCH test

15 years ago- Attempt to fix script compilation failure on versions older than 5.007003,
Yang Tse [Sun, 20 Dec 2009 03:48:32 +0000 (03:48 +0000)]
- Attempt to fix script compilation failure on versions older than 5.007003,
  corelist -a Time::HiRes lists this as the first version released with it.

- Ensure ftp check delay timer is always an integral number.

15 years agosupport IMAP select and LOGOUT
Daniel Stenberg [Sat, 19 Dec 2009 23:23:26 +0000 (23:23 +0000)]
support IMAP select and LOGOUT

15 years agofix the ftp check delay timer to never be set below 1 to work correctly
Daniel Stenberg [Sat, 19 Dec 2009 23:10:33 +0000 (23:10 +0000)]
fix the ftp check delay timer to never be set below 1 to work correctly
in cases like test 190

15 years agofixed a precaution check in the cookie code, pointed out by Julien Chaffraix
Daniel Stenberg [Sat, 19 Dec 2009 19:20:26 +0000 (19:20 +0000)]
fixed a precaution check in the cookie code, pointed out by Julien Chaffraix

15 years agoSlack time reduction
Yang Tse [Sat, 19 Dec 2009 13:20:07 +0000 (13:20 +0000)]
Slack time reduction

15 years agoAdded runtests.pl '-r' option for run time statistics
Yang Tse [Sat, 19 Dec 2009 04:15:22 +0000 (04:15 +0000)]
Added runtests.pl '-r' option for run time statistics

15 years agoserver start and verification time as well as test preparation time
Yang Tse [Fri, 18 Dec 2009 19:17:14 +0000 (19:17 +0000)]
server start and verification time as well as test preparation time
data is required in order to closer match total test execution time.

15 years agoAdded test harness simple time execution stats
Yang Tse [Fri, 18 Dec 2009 15:23:18 +0000 (15:23 +0000)]
Added test harness simple time execution stats

15 years agoComment out hi resolution time logging to verify if this is what might
Yang Tse [Thu, 17 Dec 2009 22:28:40 +0000 (22:28 +0000)]
Comment out hi resolution time logging to verify if this is what might
be contributing 90 additional seconds to the total time some autobuilds
now need to make a full test-run.

15 years agoFix compilation failure
Yang Tse [Thu, 17 Dec 2009 20:01:24 +0000 (20:01 +0000)]
Fix compilation failure

15 years agoTest harness process control enhancements
Yang Tse [Thu, 17 Dec 2009 19:37:01 +0000 (19:37 +0000)]
Test harness process control enhancements

15 years agouh, assign the bool it points to properly
Daniel Stenberg [Thu, 17 Dec 2009 16:07:02 +0000 (16:07 +0000)]
uh, assign the bool it points to properly

15 years agoStop overloading the conn->protocol field with the PROT_MISSING bit. It
Daniel Stenberg [Thu, 17 Dec 2009 16:03:39 +0000 (16:03 +0000)]
Stop overloading the conn->protocol field with the PROT_MISSING bit. It
really didn't belong there and had no real point.

15 years agoRemove pointless storing of the protocol as a string within the connectdata
Daniel Stenberg [Thu, 17 Dec 2009 15:45:04 +0000 (15:45 +0000)]
Remove pointless storing of the protocol as a string within the connectdata
struct, and instead use the already stored string in the handler struct.

15 years ago- David Byron fixed Curl_ossl_cleanup to actually call ENGINE_cleanup when
Daniel Stenberg [Thu, 17 Dec 2009 13:29:41 +0000 (13:29 +0000)]
- David Byron fixed Curl_ossl_cleanup to actually call ENGINE_cleanup when
  available.

15 years agogettimeofday() requires perl version newer than 5.6
Yang Tse [Thu, 17 Dec 2009 03:50:32 +0000 (03:50 +0000)]
gettimeofday() requires perl version newer than 5.6

15 years agoFollow-up fix for the proxy fix I did for Jon Nelson's bug. It turned out I
Daniel Stenberg [Wed, 16 Dec 2009 23:11:47 +0000 (23:11 +0000)]
Follow-up fix for the proxy fix I did for Jon Nelson's bug. It turned out I
was a bit too quick and broke test case 1101 with that change. The order of
some of the setups is sensitive. I now changed it slightly again.

15 years agoTest harness process control enhancements
Yang Tse [Wed, 16 Dec 2009 19:55:35 +0000 (19:55 +0000)]
Test harness process control enhancements

15 years agoTest #1106 needs an ftp enabled client
Yang Tse [Wed, 16 Dec 2009 15:24:12 +0000 (15:24 +0000)]
Test #1106 needs an ftp enabled client

15 years agoTest harness process control enhancements
Yang Tse [Wed, 16 Dec 2009 15:16:06 +0000 (15:16 +0000)]
Test harness process control enhancements

15 years ago- Jon Nelson found a regression that turned out to be a flaw in how libcurl
Daniel Stenberg [Mon, 14 Dec 2009 23:16:09 +0000 (23:16 +0000)]
- Jon Nelson found a regression that turned out to be a flaw in how libcurl
  detects and uses proxies based on the environment variables. If the proxy
  was given as an explicit option it worked, but due to the setup order
  mistake proxies would not be used fine for a few protocols when picked up
  from '[protocol]_proxy'. Obviously this broke after 7.19.4. I now also added
  test case 1106 that verifies this functionality.

  (http://curl.haxx.se/bug/view.cgi?id=2913886)

15 years agoFix compiler warning
Yang Tse [Mon, 14 Dec 2009 16:05:57 +0000 (16:05 +0000)]
Fix compiler warning

15 years agoPrevent perl script dying messages in output, since tearing down the pinpong
Yang Tse [Mon, 14 Dec 2009 15:39:15 +0000 (15:39 +0000)]
Prevent perl script dying messages in output, since tearing down the pinpong
server in this way, upon sysread failures, is part of the expected behavior.

15 years agoAdjust uppercase protocol string usage
Yang Tse [Mon, 14 Dec 2009 14:42:48 +0000 (14:42 +0000)]
Adjust uppercase protocol string usage

15 years agoFix compiler warnings
Yang Tse [Mon, 14 Dec 2009 14:02:43 +0000 (14:02 +0000)]
Fix compiler warnings

15 years agoFix compiler warnings
Yang Tse [Mon, 14 Dec 2009 13:27:50 +0000 (13:27 +0000)]
Fix compiler warnings

15 years agosignal handling to cleanup on SIGINT and SIGTERM, followup
Yang Tse [Sun, 13 Dec 2009 03:45:32 +0000 (03:45 +0000)]
signal handling to cleanup on SIGINT and SIGTERM, followup

15 years agoreapply diff between revisions 1.103 and 1.102
Yang Tse [Sun, 13 Dec 2009 03:44:45 +0000 (03:44 +0000)]
reapply diff between revisions 1.103 and 1.102

15 years agoupdated with the new protocols
Daniel Stenberg [Sat, 12 Dec 2009 22:48:11 +0000 (22:48 +0000)]
updated with the new protocols

15 years agomight as well output all supported protocols at the end of configure to
Daniel Stenberg [Sat, 12 Dec 2009 22:39:29 +0000 (22:39 +0000)]
might as well output all supported protocols at the end of configure to
make it more obvious how the output will be

15 years agoshow POP3S, IMAPS and SMTPS as protocols if SSL is enabled
Daniel Stenberg [Sat, 12 Dec 2009 22:33:18 +0000 (22:33 +0000)]
show POP3S, IMAPS and SMTPS as protocols if SSL is enabled

15 years agosupport disabling POP3, IMAP and SMTP and now they also appear in curl-config
Daniel Stenberg [Sat, 12 Dec 2009 22:31:00 +0000 (22:31 +0000)]
support disabling POP3, IMAP and SMTP and now they also appear in curl-config
--protocols output

15 years agosplit out more protocol-specific structs from urldata.h into their own
Daniel Stenberg [Sat, 12 Dec 2009 22:17:51 +0000 (22:17 +0000)]
split out more protocol-specific structs from urldata.h into their own
protocol-specific header files

15 years agoIMAP, POP3 and SMTP support
Daniel Stenberg [Sat, 12 Dec 2009 22:05:11 +0000 (22:05 +0000)]
IMAP, POP3 and SMTP support

15 years agointroducing IMAP, POP3 and SMTP support (still lots of polish left to do)
Daniel Stenberg [Sat, 12 Dec 2009 21:54:01 +0000 (21:54 +0000)]
introducing IMAP, POP3 and SMTP support (still lots of polish left to do)

15 years agoPrevent rewinding unless pipelining.
Yang Tse [Fri, 11 Dec 2009 18:41:29 +0000 (18:41 +0000)]
Prevent rewinding unless pipelining.

See http://curl.haxx.se/mail/lib-2009-12/0107.html

15 years agoRemoved function prototype without implementation
Yang Tse [Fri, 11 Dec 2009 02:14:11 +0000 (02:14 +0000)]
Removed function prototype without implementation

15 years ago- Siegfried Gyuricsko found out that the curl manual said --retry would retry
Daniel Stenberg [Thu, 10 Dec 2009 21:02:11 +0000 (21:02 +0000)]
- Siegfried Gyuricsko found out that the curl manual said --retry would retry
  on FTP errors in the transient 5xx range. Transient FTP errors are in the
  4xx range. The code itself only tried on 5xx errors that occured _at login_.
  Now the retry code retries on all FTP transfer failures that ended with a
  4xx response.

  (http://curl.haxx.se/bug/view.cgi?id=2911279)

15 years agoargh, use the correct bug id
Daniel Stenberg [Thu, 10 Dec 2009 20:26:44 +0000 (20:26 +0000)]
argh, use the correct bug id

15 years ago- Constantine Sapuntzakis figured out a case which would lead to libcurl
Daniel Stenberg [Thu, 10 Dec 2009 20:20:15 +0000 (20:20 +0000)]
- Constantine Sapuntzakis figured out a case which would lead to libcurl
  accessing alredy freed memory and thus crash when using HTTPS (with
  OpenSSL), multi interface and the CURLOPT_DEBUGFUNCTION and a certain order
  of cleaning things up. I fixed it.

  (http://curl.haxx.se/bug/view.cgi?id=2891591)

15 years agominor indent change
Daniel Stenberg [Thu, 10 Dec 2009 20:19:56 +0000 (20:19 +0000)]
minor indent change

15 years ago- Fixed curl erroneously reporting output stream write failures with disabled buffering
Yang Tse [Thu, 10 Dec 2009 16:46:21 +0000 (16:46 +0000)]
- Fixed curl erroneously reporting output stream write failures with disabled buffering

15 years agosignal handling to cleanup on SIGINT and SIGTERM, followup
Yang Tse [Wed, 9 Dec 2009 18:41:43 +0000 (18:41 +0000)]
signal handling to cleanup on SIGINT and SIGTERM, followup

15 years ago- Martin Storsjo made libcurl use the Expect: 100-continue header for posts
Daniel Stenberg [Mon, 7 Dec 2009 20:25:17 +0000 (20:25 +0000)]
- Martin Storsjo made libcurl use the Expect: 100-continue header for posts
  with unknown size. Previously it was only used for posts with a known size
  larger than 1024 bytes.

15 years ago74. The HTTP spec allows headers to be merged and become comma-separated
Daniel Stenberg [Fri, 4 Dec 2009 21:52:58 +0000 (21:52 +0000)]
74. The HTTP spec allows headers to be merged and become comma-separated
  instead of being repeated several times. This also include Authenticate: and
  Proxy-Authenticate: headers and while this hardly every happens in real life
  it will confuse libcurl which does not properly support it for all headers -
  like those Authenticate headers.

15 years agoFix 'uploaded' file descriptor leak
Yang Tse [Thu, 3 Dec 2009 20:37:49 +0000 (20:37 +0000)]
Fix 'uploaded' file descriptor leak

15 years agosignal handling to cleanup on SIGINT and SIGTERM
Yang Tse [Thu, 3 Dec 2009 13:12:04 +0000 (13:12 +0000)]
signal handling to cleanup on SIGINT and SIGTERM

15 years agolib/nss.c: avoid use of uninitialized value
Kamil Dudka [Wed, 2 Dec 2009 17:24:38 +0000 (17:24 +0000)]
lib/nss.c: avoid use of uninitialized value

15 years agosignal handling to cleanup on SIGINT and SIGTERM
Yang Tse [Wed, 2 Dec 2009 15:02:30 +0000 (15:02 +0000)]
signal handling to cleanup on SIGINT and SIGTERM

15 years agoSet socket option SO_REUSEADDR=true on stunnel accept'ing port
Yang Tse [Tue, 1 Dec 2009 15:36:34 +0000 (15:36 +0000)]
Set socket option SO_REUSEADDR=true on stunnel accept'ing port

15 years ago- If the Expect: 100-continue header has been set by the application through
Daniel Stenberg [Tue, 1 Dec 2009 12:04:54 +0000 (12:04 +0000)]
- If the Expect: 100-continue header has been set by the application through
  curl_easy_setopt with CURLOPT_HTTPHEADER, the library should set
  data->state.expect100header accordingly - the current code (in 7.19.7 at
  least) doesn't handle this properly. Martin Storsjo provided the fix!

15 years agostart working on 1.7.1
Daniel Stenberg [Mon, 30 Nov 2009 22:39:04 +0000 (22:39 +0000)]
start working on 1.7.1

15 years ago- In order to better reflect that the returned pid is extracted from the
Yang Tse [Mon, 30 Nov 2009 13:48:51 +0000 (13:48 +0000)]
- In order to better reflect that the returned pid is extracted from the
  given file, serverpid sub is renamed to pidfromfile. In addition it is
  enhanced to make sure that it always returns zero unless a numerical
  positive value is returned.

- To better reflect that only process existance is actually checked,
  checkserver sub is renamed to processexists. In addition it is enhanced
  making it remove the given pid file when the extracted pid is no longer
  alive.

15 years ago#71 "TFTP block size / better integration in transfer" is now expected to
Daniel Stenberg [Sun, 29 Nov 2009 23:14:56 +0000 (23:14 +0000)]
#71 "TFTP block size / better integration in transfer" is now expected to
have been fixed!

15 years agoa binding for Falcon
Daniel Stenberg [Sun, 29 Nov 2009 19:12:00 +0000 (19:12 +0000)]
a binding for Falcon

15 years ago- Added Diffie-Hellman parameters to several test harness certificate files in
Yang Tse [Sat, 28 Nov 2009 10:01:21 +0000 (10:01 +0000)]
- Added Diffie-Hellman parameters to several test harness certificate files in
  PEM format. Required by several stunnel versions used by our test harness.

15 years agoUse different log files for each protocol
Yang Tse [Sat, 28 Nov 2009 05:06:19 +0000 (05:06 +0000)]
Use different log files for each protocol

15 years agos/socklen_t/curl_socklen_t/g
Yang Tse [Sat, 28 Nov 2009 04:34:46 +0000 (04:34 +0000)]
s/socklen_t/curl_socklen_t/g

15 years agoFix compiler warning: unused variable `data'
Yang Tse [Sat, 28 Nov 2009 03:00:32 +0000 (03:00 +0000)]
Fix compiler warning: unused variable `data'

15 years ago7.20.0 is the planned next version number
Daniel Stenberg [Fri, 27 Nov 2009 23:53:50 +0000 (23:53 +0000)]
7.20.0 is the planned next version number

15 years agodocument --tftp-blksize
Daniel Stenberg [Fri, 27 Nov 2009 23:51:05 +0000 (23:51 +0000)]
document --tftp-blksize

15 years ago- Markus Koetter provided a polished and updated version of Chad Monroe's TFTP
Daniel Stenberg [Fri, 27 Nov 2009 23:46:29 +0000 (23:46 +0000)]
- Markus Koetter provided a polished and updated version of Chad Monroe's TFTP
  rework patch that now integrates TFTP properly into libcurl so that it can
  be used non-blocking with the multi interface and more. BLKSIZE also works.

  The --tftp-blksize option was added to allow setting the TFTP BLKSIZE from
  the command line.

15 years agoAttempt to enhance stunnel 3.X logging
Yang Tse [Fri, 27 Nov 2009 19:52:56 +0000 (19:52 +0000)]
Attempt to enhance stunnel 3.X logging

15 years agoPrevent running stunnel unless its version can be determined.
Yang Tse [Fri, 27 Nov 2009 13:01:10 +0000 (13:01 +0000)]
Prevent running stunnel unless its version can be determined.

15 years agoLog sws IPv version, port and pid when exiting due to SIGINT or SIGTERM.
Yang Tse [Fri, 27 Nov 2009 12:01:25 +0000 (12:01 +0000)]
Log sws IPv version, port and pid when exiting due to SIGINT or SIGTERM.

15 years agoTo allow remote log inspection avoid redirecting messages to stderr.
Yang Tse [Fri, 27 Nov 2009 12:00:53 +0000 (12:00 +0000)]
To allow remote log inspection avoid redirecting messages to stderr.

Set 0600 file permissions on certificate pem files.

15 years agoPreserve empty line following last target cares-1_7_0
Yang Tse [Fri, 27 Nov 2009 05:24:44 +0000 (05:24 +0000)]
Preserve empty line following last target

15 years agoLog info for start up failures.
Yang Tse [Thu, 26 Nov 2009 22:07:47 +0000 (22:07 +0000)]
Log info for start up failures.

15 years ago - Extended and fixed the change I did on Dec 11 for the the progress
Daniel Stenberg [Thu, 26 Nov 2009 19:07:54 +0000 (19:07 +0000)]
 - Extended and fixed the change I did on Dec 11 for the the progress
   meter/callback during FTP command/response sequences. It turned out it was
   really lame before and now the progress meter SHOULD get called at least
   once per second.

15 years agoOnly attempt to clear the server-logs lock when previously set by this same server.
Yang Tse [Thu, 26 Nov 2009 10:15:08 +0000 (10:15 +0000)]
Only attempt to clear the server-logs lock when previously set by this same server.

15 years agosignal handling to cleanup on SIGINT and SIGTERM
Yang Tse [Thu, 26 Nov 2009 04:38:29 +0000 (04:38 +0000)]
signal handling to cleanup on SIGINT and SIGTERM

15 years ago- Larry Lansing fixed ares_parse_srv_reply to properly parse replies
Yang Tse [Thu, 26 Nov 2009 01:21:21 +0000 (01:21 +0000)]
- Larry Lansing fixed ares_parse_srv_reply to properly parse replies
  which might contain non-SRV answers, skipping over potential non-SRV
  ones such as CNAMEs.

15 years agoWhen using icc, compile with -fpic and link with intel dynamic libraries.
Yang Tse [Tue, 24 Nov 2009 16:12:22 +0000 (16:12 +0000)]
When using icc, compile with -fpic and link with intel dynamic libraries.

15 years agoclarify what a modern version of libcurl means
Daniel Stenberg [Tue, 24 Nov 2009 10:10:59 +0000 (10:10 +0000)]
clarify what a modern version of libcurl means

15 years agoAdded 'currently' in italics to insist on transient situation.
Yang Tse [Tue, 24 Nov 2009 10:08:45 +0000 (10:08 +0000)]
Added 'currently' in italics to insist on transient situation.

15 years agoFix language
Yang Tse [Tue, 24 Nov 2009 09:48:32 +0000 (09:48 +0000)]
Fix language

15 years agorefreshed
Daniel Stenberg [Tue, 24 Nov 2009 07:40:43 +0000 (07:40 +0000)]
refreshed

15 years ago- David Byron modified Makefile.dist vc8 and vc9 targets in order to allow
Yang Tse [Mon, 23 Nov 2009 16:48:31 +0000 (16:48 +0000)]
- David Byron modified Makefile.dist vc8 and vc9 targets in order to allow
  finer granularity control when generating src and lib makefiles.

15 years agoEnhance some debug messages for initialization failures.
Yang Tse [Mon, 23 Nov 2009 16:11:50 +0000 (16:11 +0000)]
Enhance some debug messages for initialization failures.

Fix compiler warning: conditional expression is constant.

15 years ago- Bjorn Augustsson reported a bug which made curl not report any problems even
Daniel Stenberg [Mon, 23 Nov 2009 13:56:45 +0000 (13:56 +0000)]
- Bjorn Augustsson reported a bug which made curl not report any problems even
  though it failed to write a very small download to disk (done in a single
  fwrite call). It turned out to be because fwrite() returned success, but
  there was insufficient error-checking for the fclose() call which tricked
  curl to believe things were fine.

15 years agoDaniel wants upcoming release to be 1.7.0
Yang Tse [Mon, 23 Nov 2009 12:03:32 +0000 (12:03 +0000)]
Daniel wants upcoming release to be 1.7.0

15 years agoMention last changes
Yang Tse [Mon, 23 Nov 2009 11:35:53 +0000 (11:35 +0000)]
Mention last changes

15 years ago- Removed from external interface preprocessor symbol definition for
Yang Tse [Mon, 23 Nov 2009 11:26:29 +0000 (11:26 +0000)]
- Removed from external interface preprocessor symbol definition for
  CARES_HAVE_ARES_FREE_DATA. Current functionality of ares_free_data()
  makes it unnecessary.

15 years agoAdded README.msvc
Yang Tse [Mon, 23 Nov 2009 11:07:16 +0000 (11:07 +0000)]
Added README.msvc

15 years agoChanged c-ares naming conventions when using MSVC as described in README.msvc
Yang Tse [Mon, 23 Nov 2009 11:05:47 +0000 (11:05 +0000)]
Changed c-ares naming conventions when using MSVC as described in README.msvc

15 years agofixed CURLOPT_TFTP_BLKSIZE typo
Daniel Stenberg [Mon, 23 Nov 2009 09:31:55 +0000 (09:31 +0000)]
fixed CURLOPT_TFTP_BLKSIZE typo

15 years ago- Mention other recent changes
Yang Tse [Mon, 23 Nov 2009 01:54:55 +0000 (01:54 +0000)]
- Mention other recent changes

15 years ago- Jakub Hrozek renamed addrttl and addr6ttl structs to ares_addrttl and
Yang Tse [Mon, 23 Nov 2009 01:24:17 +0000 (01:24 +0000)]
- Jakub Hrozek renamed addrttl and addr6ttl structs to ares_addrttl and
  ares_addr6ttl in order to prevent name space pollution, along with
  necessary changes to code base and man pages.This change does not break
  ABI, there is no need to recompile existing applications. But existing
  applications using these structs with the old name will need source code
  adjustments when recompiled using c-ares 1.6.1.

15 years ago- Jakub Hrozek fixed more function prototypes in man pages to sync them
Yang Tse [Mon, 23 Nov 2009 00:57:50 +0000 (00:57 +0000)]
- Jakub Hrozek fixed more function prototypes in man pages to sync them
  with the ones declared in ares.h

15 years agoMake configure remove the curlbuild.h file included in distribution tarballs
Yang Tse [Sun, 22 Nov 2009 05:31:57 +0000 (05:31 +0000)]
Make configure remove the curlbuild.h file included in distribution tarballs
for use by non-configure systems. As intended, configure would overwrite the
distributed one when doing in-tree builds. But VPATH builds would end having
two curlbuild.h files, one in the source tree and another in the build tree.

15 years agoMake configure remove the ares_build.h file included in distribution tarballs.
Yang Tse [Sun, 22 Nov 2009 05:31:31 +0000 (05:31 +0000)]
Make configure remove the ares_build.h file included in distribution tarballs.

15 years agoFix macro redefinition.
Yang Tse [Sun, 22 Nov 2009 03:51:07 +0000 (03:51 +0000)]
Fix macro redefinition.

15 years agoFix name space pollution.
Yang Tse [Sun, 22 Nov 2009 03:41:26 +0000 (03:41 +0000)]
Fix name space pollution.