]> granicus.if.org Git - php/log
php
5 years agoDon't explicitly set return value on ZFR failure in ext/xmlwriter
Christoph M. Becker [Tue, 3 Sep 2019 07:15:41 +0000 (09:15 +0200)]
Don't explicitly set return value on ZFR failure in ext/xmlwriter

Failing `zend_fetch_resource(2)` throws as of PHP 8.0.0, so explicitly
setting a return value is useless, and also slightly confusing.

5 years agoAdd ext/xmlwriter stubs
Christoph M. Becker [Tue, 3 Sep 2019 07:09:57 +0000 (09:09 +0200)]
Add ext/xmlwriter stubs

5 years agoFixed pow() function info
Dmitry Stogov [Mon, 2 Sep 2019 18:44:10 +0000 (21:44 +0300)]
Fixed pow() function info

5 years agoMerge branch 'PHP-7.4'
Dmitry Stogov [Mon, 2 Sep 2019 16:03:45 +0000 (19:03 +0300)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Update PHP_API_VERSION

5 years agoUpdate PHP_API_VERSION
Dmitry Stogov [Mon, 2 Sep 2019 16:02:40 +0000 (19:02 +0300)]
Update PHP_API_VERSION

5 years agoMake ReflectionType an abstract class
Nikita Popov [Mon, 2 Sep 2019 13:38:17 +0000 (15:38 +0200)]
Make ReflectionType an abstract class

This is never instantiated directly, only child classes are used.

5 years agoMerge branch 'PHP-7.4'
Christoph M. Becker [Mon, 2 Sep 2019 13:22:19 +0000 (15:22 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Update NEWS

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Mon, 2 Sep 2019 13:21:49 +0000 (15:21 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Update NEWS

5 years agoUpdate NEWS
Christoph M. Becker [Mon, 2 Sep 2019 13:21:20 +0000 (15:21 +0200)]
Update NEWS

5 years agoMerge branch 'PHP-7.4'
Christoph M. Becker [Mon, 2 Sep 2019 13:07:48 +0000 (15:07 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fix #76577: outdated documentation concerning track_errors

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Mon, 2 Sep 2019 13:06:45 +0000 (15:06 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Fix #76577: outdated documentation concerning track_errors

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Christoph M. Becker [Mon, 2 Sep 2019 13:05:57 +0000 (15:05 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Fix #76577: outdated documentation concerning track_errors

5 years agoFix #76577: outdated documentation concerning track_errors
Christoph M. Becker [Mon, 2 Sep 2019 13:05:01 +0000 (15:05 +0200)]
Fix #76577: outdated documentation concerning track_errors

5 years agoMove isBuiltin() method from ReflectionType to ReflectionNamedType
Nikita Popov [Mon, 2 Sep 2019 12:55:04 +0000 (14:55 +0200)]
Move isBuiltin() method from ReflectionType to ReflectionNamedType

This method only makes sense for single types, e.g. it would be
meaningless for union types.

Note that we always return ReflectionNamedType right now, so this does
not break compatibility for code using any currently existing types.

5 years agoAdd arg type assertions to DO_ICALL
Nikita Popov [Mon, 2 Sep 2019 12:30:51 +0000 (14:30 +0200)]
Add arg type assertions to DO_ICALL

Now that DO_ICALL is also used for functions with type hints, we
should include the arginfo sanity check assertions in there as
well.

5 years agoMerge branch 'PHP-7.4'
Dmitry Stogov [Mon, 2 Sep 2019 11:20:01 +0000 (14:20 +0300)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Free two bits in fn_flags by merging ZEND_ACC_HEAP_RT_CACHE/ZEND_ACC_USER_ARG_INFO and ZEND_ACC_DONE_PASS_TWO/ZEND_ACC_ARENA_ALLOCATED that may be used only for user/internal functions

5 years agoFree two bits in fn_flags by merging ZEND_ACC_HEAP_RT_CACHE/ZEND_ACC_USER_ARG_INFO...
Dmitry Stogov [Mon, 2 Sep 2019 11:05:28 +0000 (14:05 +0300)]
Free two bits in fn_flags by merging ZEND_ACC_HEAP_RT_CACHE/ZEND_ACC_USER_ARG_INFO and ZEND_ACC_DONE_PASS_TWO/ZEND_ACC_ARENA_ALLOCATED that may be used only for user/internal functions

5 years agoMerge branch 'PHP-7.4'
Dmitry Stogov [Mon, 2 Sep 2019 09:50:40 +0000 (12:50 +0300)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fixed information about unused flags

5 years agoFixed information about unused flags
Dmitry Stogov [Mon, 2 Sep 2019 09:50:05 +0000 (12:50 +0300)]
Fixed information about unused flags

5 years agoFixed performance degradation caused by arg_info of internal function
Dmitry Stogov [Mon, 2 Sep 2019 09:11:18 +0000 (12:11 +0300)]
Fixed performance degradation caused by arg_info of internal function

5 years agoFix typo in type
Nikita Popov [Mon, 2 Sep 2019 08:55:51 +0000 (10:55 +0200)]
Fix typo in type

5 years agoMake error_reporting=E_ALL the default
Nikita Popov [Fri, 30 Aug 2019 08:31:32 +0000 (10:31 +0200)]
Make error_reporting=E_ALL the default

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Mon, 2 Sep 2019 07:37:41 +0000 (09:37 +0200)]
Merge branch 'PHP-7.4'

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Mon, 2 Sep 2019 07:37:26 +0000 (09:37 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Mon, 2 Sep 2019 07:36:58 +0000 (09:36 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3

5 years agoFix pkg-config version constraint for ICU
Nikita Popov [Mon, 2 Sep 2019 07:36:20 +0000 (09:36 +0200)]
Fix pkg-config version constraint for ICU

On PHP 7.2 our minimum ICU version is 4.0, not 40.

5 years agoPromote warnings to errors in substr_count()
George Peter Banyard [Thu, 22 Aug 2019 10:27:06 +0000 (12:27 +0200)]
Promote warnings to errors in substr_count()

5 years agoPromote warnings to errors in substr_compare()
George Peter Banyard [Thu, 22 Aug 2019 09:48:21 +0000 (11:48 +0200)]
Promote warnings to errors in substr_compare()

5 years agoMerge branch 'PHP-7.4'
George Peter Banyard [Sat, 31 Aug 2019 21:17:21 +0000 (23:17 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Drop E_STRICT notice in mysqli extension

5 years agoDrop E_STRICT notice in mysqli extension
George Peter Banyard [Sun, 14 Jul 2019 19:31:21 +0000 (21:31 +0200)]
Drop E_STRICT notice in mysqli extension

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Fri, 30 Aug 2019 15:25:27 +0000 (17:25 +0200)]
Merge branch 'PHP-7.4'

5 years agoReenable alloca support on ZTS
Nikita Popov [Fri, 30 Aug 2019 15:24:06 +0000 (17:24 +0200)]
Reenable alloca support on ZTS

This got disabled due to an incorrect change in a preprocessor condition
in 2104bea5d756dfa40b605a4a2765a3bc4637a76c. It was not supposed to
be disabled.

5 years agoCheck zpp before other errors in SoapServer::addSoapHeader()
Nikita Popov [Fri, 30 Aug 2019 15:03:04 +0000 (17:03 +0200)]
Check zpp before other errors in SoapServer::addSoapHeader()

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Fri, 30 Aug 2019 14:37:20 +0000 (16:37 +0200)]
Merge branch 'PHP-7.4'

5 years agoFix file clashes in copy tests
Nikita Popov [Fri, 30 Aug 2019 14:36:49 +0000 (16:36 +0200)]
Fix file clashes in copy tests

Create the "*" file in a sub-directory rather than the main test
directory, so that it's different for each test.

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Fri, 30 Aug 2019 14:10:11 +0000 (16:10 +0200)]
Merge branch 'PHP-7.4'

5 years agoRemove bogus vcwd_open
Nikita Popov [Fri, 30 Aug 2019 13:25:23 +0000 (15:25 +0200)]
Remove bogus vcwd_open

This is a left-over from the Linux version...

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Fri, 30 Aug 2019 14:08:05 +0000 (16:08 +0200)]
Merge branch 'PHP-7.4'

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Fri, 30 Aug 2019 14:07:54 +0000 (16:07 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Fri, 30 Aug 2019 14:07:33 +0000 (16:07 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3

5 years agoFixed bug #78469
Sergei Turchanov [Wed, 28 Aug 2019 03:05:14 +0000 (13:05 +1000)]
Fixed bug #78469

fcgi_accept_request function is supposed to call a FastCGI implementation's
on_accept hook when entering an "accepting" stage (that is right before
calling "accept"). This hook implementation (fpm_request_accepting) updates
a worker state to an "accepting" state which is effectively an "Idle" state,
and updates counters on the scoreboard of the corresponding pool (idle++,
active--).

But this is not done when listening for client connections on a named pipe on
Windows platform. In that case a combination of
ConnectNamedPipe/WaitForSingleObject is used (to be able to catch in_shutdown
as far as I understand), but it is nonetheless functionally equivalent to
"accept" call. Also by not calling on_hook neither a worker's state is updated
to "accepting" state nor scoreboard counters are updated.

5 years agoEnable JIT on community_job
Nikita Popov [Fri, 30 Aug 2019 08:48:06 +0000 (10:48 +0200)]
Enable JIT on community_job

5 years agoJIT: Fix missing free on JMPZ_EX with op1 == res
Nikita Popov [Fri, 30 Aug 2019 12:48:01 +0000 (14:48 +0200)]
JIT: Fix missing free on JMPZ_EX with op1 == res

We need to free the operand before we overwrite it with the result.

5 years agoAdd jit_bisect_limit
Nikita Popov [Fri, 30 Aug 2019 10:47:49 +0000 (12:47 +0200)]
Add jit_bisect_limit

To help identify which function is being miscompiled.

5 years agoRemove duplicate md5/sha1 implementation
Christoph M. Becker [Thu, 22 Aug 2019 11:47:47 +0000 (13:47 +0200)]
Remove duplicate md5/sha1 implementation

This code was actually unused since its introduction, and since at
least the md5 implementation in the core was completely overhauled,
we're dropping the md5 and sha1 related stuff from ext/hash.

5 years agoFix func info for chop()
Nikita Popov [Fri, 30 Aug 2019 09:18:47 +0000 (11:18 +0200)]
Fix func info for chop()

chop() is an alias of rtrim() and may return copied strings, so
should use FN.

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Fri, 30 Aug 2019 09:02:40 +0000 (11:02 +0200)]
Merge branch 'PHP-7.4'

5 years agoAvoid accessing undefined index in CLI server test
Nikita Popov [Fri, 30 Aug 2019 09:01:32 +0000 (11:01 +0200)]
Avoid accessing undefined index in CLI server test

5 years agoDon't call Reflection::export() in --rf etc implementation
Nikita Popov [Fri, 30 Aug 2019 08:59:58 +0000 (10:59 +0200)]
Don't call Reflection::export() in --rf etc implementation

This method is deprecated ... instead simply directly print the
object.

5 years agoDisable symfony build on master
Nikita Popov [Fri, 30 Aug 2019 08:46:42 +0000 (10:46 +0200)]
Disable symfony build on master

5 years agoFix closure extra args freeing for JIT as well
Nikita Popov [Fri, 30 Aug 2019 08:35:41 +0000 (10:35 +0200)]
Fix closure extra args freeing for JIT as well

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Fri, 30 Aug 2019 08:33:12 +0000 (10:33 +0200)]
Merge branch 'PHP-7.4'

5 years agoModernize some connectors in tests to remove env key duplication
Fabien Villepinte [Tue, 27 Aug 2019 10:50:26 +0000 (12:50 +0200)]
Modernize some connectors in tests to remove env key duplication

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Fri, 30 Aug 2019 08:07:25 +0000 (10:07 +0200)]
Merge branch 'PHP-7.4'

5 years agoAdd job for community projects
Nikita Popov [Tue, 27 Aug 2019 18:54:50 +0000 (20:54 +0200)]
Add job for community projects

Run some open-source projects through an aggressive debug
configuration with asan and ubsan. We don't care about test results,
only check that we don't assert or crash.

Currently testing laravel, symfony and amp.

5 years agoMove and fix scandir related bug test
George Peter Banyard [Wed, 28 Aug 2019 23:35:29 +0000 (01:35 +0200)]
Move and fix scandir related bug test

5 years agoPromote warnings to errors in dir stdlib extension
George Peter Banyard [Wed, 28 Aug 2019 23:14:17 +0000 (01:14 +0200)]
Promote warnings to errors in dir stdlib extension

5 years agoMerge branch 'PHP-7.4'
Peter Kokot [Fri, 30 Aug 2019 02:32:30 +0000 (04:32 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Update NEWS
  Fix #78460: PEAR installation failure

5 years agoUpdate NEWS
Peter Kokot [Fri, 30 Aug 2019 02:32:05 +0000 (04:32 +0200)]
Update NEWS

5 years agoFix #78460: PEAR installation failure
Peter Kokot [Wed, 28 Aug 2019 15:21:46 +0000 (17:21 +0200)]
Fix #78460: PEAR installation failure

When building PHP outside of the source tree:

  mkdir custom-build-dir
  cd custom-build-dir
  ../path/to/php-src/configure

The directories need to be manually created including the pear directory
so the pear installation PHAR file doesn't need to be downloaded from
the remote location.

Closes GH-4639

5 years agoPromote warnings to errors in assert_options()
George Peter Banyard [Wed, 28 Aug 2019 21:57:51 +0000 (23:57 +0200)]
Promote warnings to errors in assert_options()

5 years agoPromote Directory handler warning to error
George Peter Banyard [Wed, 28 Aug 2019 23:30:13 +0000 (01:30 +0200)]
Promote Directory handler warning to error

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Thu, 29 Aug 2019 17:07:59 +0000 (19:07 +0200)]
Merge branch 'PHP-7.4'

5 years agoFix potentially uninitialized use in ldap
Nikita Popov [Thu, 29 Aug 2019 16:01:34 +0000 (18:01 +0200)]
Fix potentially uninitialized use in ldap

If ctrl->ldctl_value.bv_len is zero context is uninitialized. Only
free it if the call took place and succeeded.

5 years agoWarnings to Errors hash_equals
Mark [Mon, 26 Aug 2019 22:44:20 +0000 (23:44 +0100)]
Warnings to Errors hash_equals

5 years agoErrorfy hash_pbkdf2
Mark [Mon, 26 Aug 2019 22:31:28 +0000 (23:31 +0100)]
Errorfy hash_pbkdf2

5 years agoWarnings become errors for hash_hkdf
Mark [Mon, 26 Aug 2019 22:20:49 +0000 (23:20 +0100)]
Warnings become errors for hash_hkdf

5 years agoWarnings become errors hash stream functions (other than hash_init)
Mark [Mon, 26 Aug 2019 22:02:57 +0000 (23:02 +0100)]
Warnings become errors hash stream functions (other than hash_init)

5 years agoWarnings become errors hash_init
Mark [Mon, 26 Aug 2019 21:52:45 +0000 (22:52 +0100)]
Warnings become errors hash_init

5 years agoWarnings become errors hash_hmac hash_hmac_file
Mark [Mon, 26 Aug 2019 21:34:50 +0000 (22:34 +0100)]
Warnings become errors hash_hmac hash_hmac_file

5 years agoPromote warnings to errors in array_walk(_recursive)()
George Peter Banyard [Wed, 21 Aug 2019 00:57:33 +0000 (02:57 +0200)]
Promote warnings to errors in array_walk(_recursive)()

5 years agoPromote warnings to errors in compact()
George Peter Banyard [Wed, 21 Aug 2019 00:43:24 +0000 (02:43 +0200)]
Promote warnings to errors in compact()

5 years agoPromote warnings to errors in array_merge(_recursive)() and array_replace()
George Peter Banyard [Wed, 21 Aug 2019 00:36:20 +0000 (02:36 +0200)]
Promote warnings to errors in array_merge(_recursive)() and array_replace()

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Thu, 29 Aug 2019 12:47:30 +0000 (14:47 +0200)]
Merge branch 'PHP-7.4'

5 years agoAddref static vars when not copying private method
Nikita Popov [Thu, 29 Aug 2019 12:33:31 +0000 (14:33 +0200)]
Addref static vars when not copying private method

While we don't need to give this method separate static vars, we
do still need to perform an addref, as there will be a corresponding
delref in the dtor.

5 years agoUse explicit unaligned type in md5 implementation
Nikita Popov [Thu, 29 Aug 2019 10:58:22 +0000 (12:58 +0200)]
Use explicit unaligned type in md5 implementation

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Thu, 29 Aug 2019 10:34:31 +0000 (12:34 +0200)]
Merge branch 'PHP-7.4'

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Thu, 29 Aug 2019 10:34:07 +0000 (12:34 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Thu, 29 Aug 2019 10:32:23 +0000 (12:32 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3

5 years agoFix use-after-free of immediately invoked closure with extra args
Nikita Popov [Thu, 29 Aug 2019 10:30:39 +0000 (12:30 +0200)]
Fix use-after-free of immediately invoked closure with extra args

5 years agoPromote warnings to errors in extract()
George Peter Banyard [Wed, 21 Aug 2019 00:52:20 +0000 (02:52 +0200)]
Promote warnings to errors in extract()

5 years agoDon't explicitly set return value on ZFR failure in ext/odbc
Christoph M. Becker [Wed, 28 Aug 2019 16:44:57 +0000 (18:44 +0200)]
Don't explicitly set return value on ZFR failure in ext/odbc

Failing `zend_fetch_resource(2)` throws as of PHP 8.0.0, so explicitly
setting a return value is useless, and also slightly confusing.

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Wed, 28 Aug 2019 16:18:25 +0000 (18:18 +0200)]
Merge branch 'PHP-7.4'

5 years agoSet opcache.protect_memory=1 on Azure
Nikita Popov [Wed, 28 Aug 2019 15:39:39 +0000 (17:39 +0200)]
Set opcache.protect_memory=1 on Azure

5 years agoMerge branch 'PHP-7.4'
Christoph M. Becker [Wed, 28 Aug 2019 16:10:33 +0000 (18:10 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fix #78473: odbc_close() closes arbitrary resources

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Wed, 28 Aug 2019 15:58:13 +0000 (17:58 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Fix #78473: odbc_close() closes arbitrary resources

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Christoph M. Becker [Wed, 28 Aug 2019 15:56:23 +0000 (17:56 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Fix #78473: odbc_close() closes arbitrary resources

5 years agoFix #78473: odbc_close() closes arbitrary resources
Christoph M. Becker [Wed, 28 Aug 2019 15:51:57 +0000 (17:51 +0200)]
Fix #78473: odbc_close() closes arbitrary resources

We have to bail out, if an invalid resource is given.  For consistency
with the other `zend_fetch_resource(2)` calls, we return `FALSE`.

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Wed, 28 Aug 2019 15:36:31 +0000 (17:36 +0200)]
Merge branch 'PHP-7.4'

5 years agoAdd missed mutability check
Nikita Popov [Wed, 28 Aug 2019 15:31:52 +0000 (17:31 +0200)]
Add missed mutability check

5 years agoAdd ext/odbc stubs
Christoph M. Becker [Wed, 28 Aug 2019 14:07:47 +0000 (16:07 +0200)]
Add ext/odbc stubs

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Wed, 28 Aug 2019 15:04:55 +0000 (17:04 +0200)]
Merge branch 'PHP-7.4'

5 years agoRemove delref in free_object_storage
Nikita Popov [Wed, 28 Aug 2019 13:35:53 +0000 (15:35 +0200)]
Remove delref in free_object_storage

This gives us better object leak diagnostics.

5 years agoDestroy error handlers before final GC run
Nikita Popov [Wed, 28 Aug 2019 13:33:51 +0000 (15:33 +0200)]
Destroy error handlers before final GC run

5 years agoFix test regarding ZPP TypeErrors
Christoph M. Becker [Wed, 28 Aug 2019 14:43:43 +0000 (16:43 +0200)]
Fix test regarding ZPP TypeErrors

We simply remove the second call to `odbc_data_source` since it is
testing standard ZPP behavior.

5 years agoMerge branch 'PHP-7.4'
Nikita Popov [Wed, 28 Aug 2019 10:32:22 +0000 (12:32 +0200)]
Merge branch 'PHP-7.4'

5 years agoFixed bug #78335
Nikita Popov [Wed, 28 Aug 2019 10:15:28 +0000 (12:15 +0200)]
Fixed bug #78335

Destroy static properties and variables prior to the final GC run,
as they may hold GC roots.

5 years agoCompute needle end only after checking it's non-empty
Nikita Popov [Wed, 28 Aug 2019 07:32:18 +0000 (09:32 +0200)]
Compute needle end only after checking it's non-empty

5 years agoMerge branch 'PHP-7.4'
Stanislav Malyshev [Wed, 28 Aug 2019 07:12:08 +0000 (00:12 -0700)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Upgrade oniguruma lib to 6.9.3

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Stanislav Malyshev [Wed, 28 Aug 2019 07:11:50 +0000 (00:11 -0700)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Upgrade oniguruma lib to 6.9.3