Joshua Slive [Thu, 14 Feb 2002 00:48:04 +0000 (00:48 +0000)]
Add the parts for the xml to html transformation system for the module
docs. Details will be at
http://httpd.apache.org/docs-project/docsformat.html
shortly.
These files cannot be distributed at present - Justin, update your RC.32
Win32 is not escaping or rejecting ANY hazerdous shell command strings
in Apache 2.0 at present. These would include the pipe character (|)
which allows the user to construct malicious request strings.
This needs consideration in code and configuration before we reintroduce
a batch-file based example.
Reported by: Ory Segal <ORY.SEGAL@SANCTUMINC.COM> 13 Feb 2002
Aaron Bannert [Wed, 13 Feb 2002 06:09:02 +0000 (06:09 +0000)]
Just a heads up to let people know what I'm working on. I ran into
some problems with the new POD code in the worker MPM, and although
I'm almost finished I didn't want people rolling a tarball without
knowing of these problems first.
Brian Pane [Wed, 13 Feb 2002 04:49:55 +0000 (04:49 +0000)]
Performance optimization: updated the worker MPM to recycle
per-transaction pools instead of destroying them. Based on
Ian's benchmark testing, this reduces CPU utilization by
about 1% on Solaris.
The final commit to achieve a quality release. We cannot use CreateThread
on Win32 when using the clib; msvcrt has its own initialization and
destruction, so it needs its own turn. _createthreadex is the same but
different - it's implemented by msvcrt and causes all the appropriate
setup and teardown to occur.
Address the issue raised on list that users with a LanguagePriority
directive alone expect 'ForceLanguagePriority Prefer' behavior even
if that directive is omitted.
What happened? 0.9.6b built just dandy without the flags... 0.9.6c won't
build for jack without these changes. Of course they don't harm 0.9.6b
builders either, unless they are outside of the states/EU/AU and find
themselves free to ignore IP considerations.
I'd really like to know _why_ 0.9.6c doesn't configure itself rationally.
Ian Holsman [Tue, 12 Feb 2002 22:54:16 +0000 (22:54 +0000)]
once more with feeling
obj was set before the mutex so someone could have came and updated h->cache_obj
between us setting obj, and useing it.
running now for 10 minutes without core (a record!)
After hours of debugging, the answer was -trivial-, but extremely
obscure and difficult to trace. This should do away with the handle
corruption we experienced. If anyone cares to walk the crt (source
is installed in vc\src\crt if you install it w/ Visual C++/Studio)
it's worth understanding why this occured.
This patch
1. creates the pipe non-inherited, and dups the write end
for inheritence with limited permissions.
2. sets the STD_ERROR_HANDLE _after_ we fixup the FILE *stderr and fd 2.
3. Splits the signal_monitor event in two, service_init/service_term
for clarity and correctness.
Perform a serious scrubbing of the child process, before we report that
we failed to create the child. Cleans up CloseHandle() destruction to
match all created handles - and postpone populating the *child_exit_event
until we succeed.
This code seriously misassumed (and may yet) that stderr was a valid file.
It also has some bogus non-apr code that probably does great evil to win32
services. This must be bumped into .32, code review is incomplete still.
Greg Ames [Sun, 10 Feb 2002 21:16:25 +0000 (21:16 +0000)]
accept() error handling should be OK now.
I don't have a strong opinion on what we should do if the parent dies, now
that we don't have a real life example of that any more. It was a little
confusing at first, but OTOH it kept serving requests.
Greg Stein [Sat, 9 Feb 2002 01:57:38 +0000 (01:57 +0000)]
Get rid of the DAVParam support. That was a concept to help out
mod_dav providers in the 1.0.x series. Nowadays, the providers are
full-fledged Apache modules and can define their own directives and
set up per-server and per-directory parameters. (for example,
mod_dav_fs and the DAVLockDB directive)
Aaron Bannert [Thu, 7 Feb 2002 23:01:47 +0000 (23:01 +0000)]
Allow statically linked support binaries with the new
--enable-static-support flag, and enable this behavior in
the binbuild script. Also add a new --enable-static-htdbm
flag.
Allow mod_autoindex to serve symlinks if permitted and optimize our stats
so that only one stat() is needed.
If we get APR_FINFO_MIN bits, lookup_dirent won't do a repeated stat()
call. So, let's do it here. Also, if we see a symlink, expand it.
(Technically, we don't *have* to expand the symlinks - the resolve_symlink
fix handles that, but we can't really assume that.) Since we know that
dirent will be rr->finfo anyway, go back to relying on dirent only for
APR_DIR checks.
Fix resolve_symlink to save the original symlink name if known.
We would previously receive APR_INCOMPLETE on symlinks if wanted has
FINFO_NAME set because it isn't supported via apr_stat(). Furthermore, we
don't care what the real name is anyway (even if it apr_stat returned
.name) - we want to call it by the name the symlink says it is.
Eliminate tons o cruft - we are in another thread - and these can all
be longlived malloced regions, or sit upon the stack. No need to mess
with pool conflicts.
The remaining pool accesses are still a problem to resolve.
Upon advice of the FirstBill, I began looking for exceptions that occur
only in the service-mode. SetServiceDescription was borked, now fixed.
Since we don't use the posix/libc style stderr, I've also pitched that
code, which was causing an exception.
Cliff Woolley [Wed, 6 Feb 2002 22:32:34 +0000 (22:32 +0000)]
Changing my vote. I no longer have a problem with this. At the time,
lots of changes were being made to worker to fix bugs, and it seemed
premature. Haven't seen much of that as of late.
- We're not going to be doing an unmodified 2.0.31 release, so noting the
AP_DEBUG_ASSERT fix isn't helpful.
- The vote for perchild being required for GA is unanimous against. No
matter what interpretation you take, it isn't going to be a showstopper.
Ken Coar [Wed, 6 Feb 2002 19:42:12 +0000 (19:42 +0000)]
Separate showstoppers into next-beta and final-release sections.
Change a couple of my votes. Some minor formatting changes
(it's not code, so just deal with it ;-).
Move around a bit of code so I can follow it better. -> EOF should always
take us to the module struct, and working backwards, the register hooks
and then top-level init stuff. At least that's how any other Apache
module is authored.
Link to patch that incorporates all relevant bug fixes seen so far.
(only conflict from HEAD is in core.c where rbb/FirstBill snuck in some
hook changes...)
Give the child GENERIC_WRITE only to the stderr log channel,
GENERIC_READ|GENERIC_WRITE to the scoreboard mapping,
EVENT_MODIFY_STATE|SYNCHRONIZE to it's exit event,
and fix a _major_ bug in the NullACL code that set the length
by the size of the pointer-to-acl, rather than the size of an acl.
Ryan Bloom [Wed, 6 Feb 2002 16:58:37 +0000 (16:58 +0000)]
Be a bit more sane with regard to CanonicalNames. If the user has
specified they want to use the CanonicalName, but they have not
configured a port with the ServerName, then use the same port that
the original request used.
Jeff Trawick [Wed, 6 Feb 2002 16:19:03 +0000 (16:19 +0000)]
don't try to place a header field in error-notes if ap_rgetline()
returned something like APR_EOF, since len is not set in this
case and we can go off the end of storage
make sure we set r->status to something when we bail out due
to an error; otherwise, the request goes forward with meaningless
headers
projects / apache / log