Richard Levitte [Mon, 5 Feb 2001 09:15:09 +0000 (09:15 +0000)]
Fix a memory leak in BIO_get_accept_socket(). This leak was small and
only happened when the port number wasn't parsable ot the host wasn't
possible to convert to an IP address.
Contributed by Niko Baric <Niko.Baric@epost.de>
Richard Levitte [Tue, 30 Jan 2001 13:38:59 +0000 (13:38 +0000)]
Increase consistency of header data (some mail readers really do not
like spaces before the semicolon, and besides, other parts of this
file makes the values without those spaces), and move spacing of
continuation lines to support BIO's that break lines after each
write.
Geoff Thorpe [Sun, 14 Jan 2001 23:37:42 +0000 (23:37 +0000)]
Update the LHASH man page.
* Correct some prototypes and macros with respect to "const"ness.
* Add the extra macros and examples due to the lh_doall[_arg] modifications
made recently. The existing example is also reworked for consistency.
* Rewrite, tweak, and supplement bits of the existing comments that seemed
(IMHO) to be a little convoluted and misleading.
* Add a NOTE section that explains the use of macros and avoiding function
casts (ie. generate a wrapper as with the macros, or prototype any
callback functions exactly to not require casting). Also, explain the
"const" approach taken in LHASH for the purposes of API comprehensibility
and also application code auditing.
Bodo Möller [Fri, 12 Jan 2001 15:16:21 +0000 (15:16 +0000)]
Disable RegQueryValueEx() call.
Problem reported by "Wolfgang Marczy" <WMarczy@topcall.co.at>
in a message to openssl-dev (19 Dec 2000 13:40:51 +0100).
Fix typo in OCSP ASN1 module, this caused
invalid format in OCSP request signatures.
Add spaces to OCSP HTTP header.
Change X509_NAME_set() there's no reason
why it should return an error if the
destination points to NULL... though it
should if the destination is NULL.
Bodo Möller [Wed, 10 Jan 2001 18:09:57 +0000 (18:09 +0000)]
After discussion with Richard, change the new API for extended memory
allocation callbacks so that it is no longer visible to applications
that these live at a different call level than conventional memory
allocation callbacks.
Bodo Möller [Wed, 10 Jan 2001 16:46:00 +0000 (16:46 +0000)]
It's silly to use a different default for PERL than in the top
Makefile. (The default is never actually used though because
the top Makefile passes its value of PERL down to sub-Makefiles.)
Bodo Möller [Wed, 10 Jan 2001 14:10:17 +0000 (14:10 +0000)]
Change prototypes for new CRYPTO_..._mem_ex_functions functions so
that they match the function definitions (namely, remove file/line
parameters from free_func).
Richard Levitte [Wed, 10 Jan 2001 13:14:58 +0000 (13:14 +0000)]
As response to a user request to be able to use external memory
handling routines that need file name and line number information,
I've added a call level to our memory handling routines to allow that
kind of hooking.
Geoff Thorpe [Tue, 9 Jan 2001 16:59:56 +0000 (16:59 +0000)]
oops, void functions shouldn't try and return a value. Strangely, gcc
didn't even give a warning for this yet HPUX cc considered it an error.
Reported by Lutz(@openssl.org).
Lutz Jänicke [Tue, 9 Jan 2001 16:44:59 +0000 (16:44 +0000)]
Add automatic query of EGD sockets to RAND_poll(). The EGD sockets are
only queried when the /dev/[u]random devices did not return enough
entropy. Only the amount of entropy missing to reach the required minimum
is queried, as EGD may be drained.
Queried locations are: /etc/entropy, /var/run/egd-pool
Lutz Jänicke [Tue, 9 Jan 2001 10:58:36 +0000 (10:58 +0000)]
Don't cheat: when only getting several bytes from each source, n is incremented
correctly, but RAND_add(..,n) counts the increasing n several times.
Only RAND_add(..,n) once entropy collection is finished.
Geoff Thorpe [Tue, 9 Jan 2001 00:24:38 +0000 (00:24 +0000)]
Move all the existing function pointer casts associated with LHASH's two
"doall" functions to using type-safe wrappers. As and where required, this
can be replaced by redeclaring the underlying callbacks to use the
underlying "void"-based prototypes (eg. if performance suffers from an
extra level of function invocation).
Geoff Thorpe [Tue, 9 Jan 2001 00:13:25 +0000 (00:13 +0000)]
Get rid of the function pointer casting in the debugging memory code due
to LHASH usage. NB: The callback type used as been suctioned off into
crypto.h as CRYPTO_MEM_LEAK_CB to improve clarity.
Geoff Thorpe [Tue, 9 Jan 2001 00:02:09 +0000 (00:02 +0000)]
This adds macros to implement (and/or declare) type-safe wrapper functions
around the callbacks required in the LHASH code for the "doall" functions.
Also - fix the evil function pointer casting in the two lh_doall functions
by deferring to a static utility function. Previously lh_doall() was
invoking lh_doall_arg() by casting the callback to the 2-parameter
prototype and passing in a NULL argument. This appears to have been working
thus far but it's not a hot idea. If the extra level of indirection becomes
a performance hit, we can just provide two virtually identical
implementations for each variant later on.
Geoff Thorpe [Mon, 8 Jan 2001 22:03:27 +0000 (22:03 +0000)]
Whilst in the process of fixing outstanding function-pointer casts in the
LHASH code, this evil was uncovered. The cast was obscuring the fact that
the function was prototyped to take 2 parameters when in fact it is being
used as a callback that should take only one. Anyway, the function itself
ignores the second parameter (thankfully). A proper cure is on the way but
for now this corrects the inconsistency.