Bradley Sepos [Sun, 3 Jun 2018 22:35:12 +0000 (18:35 -0400)]
libhb: Cosmetic in encavcodec.c.
Michael Wootton [Tue, 23 Jan 2018 23:01:03 +0000 (17:01 -0600)]
Add support for VCE hardware encoding.
John Stebbins [Wed, 6 Jun 2018 15:03:33 +0000 (08:03 -0700)]
bd: Don't fail titles with unknown aspect
Assum 16:9 instead
Fixes https://forum.handbrake.fr/viewtopic.php?f=11&t=37836
Damiano Galassi [Wed, 6 Jun 2018 10:36:59 +0000 (12:36 +0200)]
MacGui: make it possible to resize down the "add titles to queue" toolbar button icon. It won't get as small as the others toolbar icon, but it's as good as it can get now. Fixes #1318
Scott [Tue, 5 Jun 2018 21:13:48 +0000 (22:13 +0100)]
Remove old issue template
Scott [Tue, 5 Jun 2018 21:13:04 +0000 (22:13 +0100)]
Adding Feature Request Template.
Scott [Tue, 5 Jun 2018 21:09:10 +0000 (22:09 +0100)]
Adding Bug Report Template
Scott [Tue, 5 Jun 2018 21:07:10 +0000 (22:07 +0100)]
Create CONTRIBUTING.md
Adding an GitHub CONTRIBUTING.md file
sr55 [Tue, 5 Jun 2018 20:56:23 +0000 (21:56 +0100)]
WinGui: cproj tidyup
sr55 [Tue, 5 Jun 2018 20:52:23 +0000 (21:52 +0100)]
WinGui: Rename HandBrake.ApplicationServices back to HandBrake.Interop. It's moving back to being more of an libhb interop/abstraction library only.
sr55 [Tue, 5 Jun 2018 18:32:36 +0000 (19:32 +0100)]
WinGui: Additional Error Handling in EnumHelper
John Stebbins [Tue, 5 Jun 2018 17:07:57 +0000 (10:07 -0700)]
flatpak: keep CLI in GUI package
HandBrake-<version>.flatpak contains GUI and CLI
HandBrakeCLI-<version>.flatpak is CLI only
John Stebbins [Tue, 5 Jun 2018 17:06:04 +0000 (10:06 -0700)]
flatpak: change package names
new names conform better to current win/osx snapshot names
John Stebbins [Tue, 5 Jun 2018 17:00:20 +0000 (10:00 -0700)]
flatpak: change "appdata" dir to "metainfo"
The specificaion for where appstream files go changed
John Stebbins [Tue, 5 Jun 2018 15:50:03 +0000 (08:50 -0700)]
CLI: add flatpak manifest
John Stebbins [Tue, 5 Jun 2018 15:49:16 +0000 (08:49 -0700)]
LinGui: conform to newer flatpak manifest standards
John Stebbins [Tue, 5 Jun 2018 15:08:24 +0000 (08:08 -0700)]
flatpak: uses fr.handbrake.ghb app id consistently
Damiano Galassi [Tue, 5 Jun 2018 11:46:02 +0000 (13:46 +0200)]
libhb: allow muxing E-AC3 in mp4.
John Stebbins [Tue, 5 Jun 2018 03:30:51 +0000 (20:30 -0700)]
LinGui: make flatpak pgp signature optional
To sign flatpak during build:
make pkg.create.flatpak PGP_ID=<key id>
John Stebbins [Tue, 5 Jun 2018 00:31:03 +0000 (17:31 -0700)]
LinGui: update flatpak gnome sdk version to 3.28
John Stebbins [Mon, 4 Jun 2018 22:51:36 +0000 (15:51 -0700)]
LinGui: open URLs with flatpak portal aware API
John Stebbins [Mon, 4 Jun 2018 22:26:47 +0000 (15:26 -0700)]
flatpak: add nasm to modules
nasm is a build requirement that is not provided by any of the flatpak
SDKs
John Stebbins [Mon, 4 Jun 2018 21:48:30 +0000 (14:48 -0700)]
LinGui: handle legacy preferences file better
"show_presets" key could cause the preset window to be shown at every
startup.
John Stebbins [Mon, 4 Jun 2018 18:04:11 +0000 (11:04 -0700)]
decavcodec: fix issues with audio that has no explicit channel_layout
ffmpeg doesn't set a default channel layout for audio that has no
explicit layout (e.g. pcm_216le). So we need to guess it from the
number of channels.
Fixes "no audio" in https://github.com/HandBrake/HandBrake/issues/1387
John Stebbins [Mon, 4 Jun 2018 18:02:06 +0000 (11:02 -0700)]
sync: don't drop short frames in OutputBuffer()
*really* fix https://github.com/HandBrake/HandBrake/issues/1374 this
time.
John Stebbins [Fri, 1 Jun 2018 20:56:14 +0000 (13:56 -0700)]
LinGui: Add opus for flatpak builds
flatpak sdk doesn't include opus
Bradley Sepos [Sun, 3 Jun 2018 22:30:42 +0000 (18:30 -0400)]
contrib: Remove --enable-lzma from FFmpeg.
It is the default.
John Stebbins [Sun, 3 Jun 2018 21:19:46 +0000 (14:19 -0700)]
libvpx: fix vpx.pc pkg-config file for static builds (#1385)
The generated vpx.pc file results in undefined symbols during ffmpeg's
configure tests. libpthread is not getting added to the link line as
required. The vpx.pc file needs to include -lpthread in the Libs instead
of Libs.private when generating only a static library.
Fixes https://github.com/HandBrake/HandBrake/issues/1383
Bradley Sepos [Sun, 3 Jun 2018 21:08:56 +0000 (17:08 -0400)]
contrib: Move FFmpeg dep AMF into conditional.
Practically, there is no difference. But this is how QSV was done and is easy to read.
Bradley Sepos [Sun, 3 Jun 2018 20:21:09 +0000 (16:21 -0400)]
contrib: build: Add AMF headers and --enable-vce.
#1144.
Bradley Sepos [Sun, 3 Jun 2018 16:40:23 +0000 (12:40 -0400)]
contrib: Remove workaround building x264 before FFmpeg.
Issue should be fixed by
7cddc6fe8779e1e098b48ecdfddf6b2c15050578.
John Stebbins [Sat, 2 Jun 2018 18:05:48 +0000 (11:05 -0700)]
opus: fix opus.pc pkg-config file for static builds (#1380)
The generated opus.pc file results in undefined symbols during ffmpeg's
configure tests. libm is not getting added to the link line as
required. The opus.pc file needs to include -lm in the Libs instead of
Libs.private when generating *only* a static library.
John Stebbins [Sat, 2 Jun 2018 17:55:01 +0000 (10:55 -0700)]
ffmpeg: enable all bitstream filters
There's no telling which of these may be needed internally for ffmpeg
encoders, decoders, and filters.
John Stebbins [Sat, 2 Jun 2018 17:28:33 +0000 (10:28 -0700)]
encavcodec: set AVFrame width and height
ffmpeg now requires this for video
sr55 [Fri, 1 Jun 2018 22:28:14 +0000 (23:28 +0100)]
WinGui: Make nuspec file visible in project.
sr55 [Fri, 1 Jun 2018 22:26:14 +0000 (23:26 +0100)]
WinGui: Initial NuGet nuspec file.
Bradley Sepos [Fri, 1 Jun 2018 20:13:55 +0000 (16:13 -0400)]
contrib: Explicitly pass arch to FFmpeg on macOS x86_64.
Fixes FFmpeg configure error on macOS:
```
./configure: line 588: eval: --: invalid option
eval: usage: eval [arg ...]
make[1]: *** [contrib/ffmpeg/.stamp.ffmpeg.configure] Error 2
```
...caused by attempting to `eval --arch=x86_64=yes`.
Bradley Sepos [Fri, 1 Jun 2018 19:12:50 +0000 (15:12 -0400)]
build: Detected Xcode clobbered PATH and reconfigure if necessary.
Improvement to
5c523dcaae9b69a3235a4b20631bc922afd028ca.
John Stebbins [Thu, 31 May 2018 17:27:35 +0000 (10:27 -0700)]
avfilter: fix flushing final frame
Fixes https://github.com/HandBrake/HandBrake/issues/1357
Frederick Ding [Thu, 31 May 2018 07:35:03 +0000 (03:35 -0400)]
Update WinGUI build script: allow SignTool.exe location to be specified and assume x64 (#1376)
* WinGUI: fix `SignToolLocation` typos in build.xml
Previously, a mismatch between the condition (which checked for an empty `SignToolLocation`) and the action it took (by setting `SighToolLocation`) made it difficult to override the actual location of `SignTool.exe`. The bug was introduced in HandBrake/HandBrake@
d375071be1158deb73ccb1d262310f15f231eca9
* WinGUI: Assume x64 platform in examples
Since 32-bit Windows is no longer supported (HandBrake/HandBrake@
ecbd10efbdf286b9a5248fd0a870036cd4437360), the comment at the top of `build.xml` for WinGUI shouldn't need a platform property anymore. `build.xml` is already set to assume x64 as the default platform.
* WinGUI: minor typo fixes
Just a few aesthetic changes with no effect on functionality
John Stebbins [Wed, 30 May 2018 22:11:18 +0000 (15:11 -0700)]
scan: fix crash due to last commit
check codec_name and profile_name for NULL before strstr search.
John Stebbins [Wed, 30 May 2018 22:00:04 +0000 (15:00 -0700)]
scan: rationalize ffmpeg codec/profile names
ffmpeg is inconsistent in the format of returned profile names.
Sometimes the profile name includes the codec name and sometimes it does
not. So search for the codec name in the profile name and add codec
name if it's not there. Ugh!
Fixes https://github.com/HandBrake/HandBrake/issues/1375
John Stebbins [Wed, 30 May 2018 16:21:56 +0000 (09:21 -0700)]
encx264: fix encoding of very short duration frames
We had a hash of limited size where we stored frame durations in
encx264. This hash has not been necessary since we moved to using
libavformat for muxing. Since the limited size of the hash put
constraints on how short frame durations could be, I've eliminated it.
This means that after the encoder, hb_buffer_t s.stop and s.duration are
no longer valid. But since they are not used during muxing, this is not
a problem.
Fixes https://github.com/HandBrake/HandBrake/issues/1374
Bradley Sepos [Tue, 29 May 2018 23:28:13 +0000 (19:28 -0400)]
contrib: Add libogg as a libspeex dependency.
Fixes #1372.
Bradley Sepos [Tue, 29 May 2018 23:09:16 +0000 (19:09 -0400)]
libhb: build: README: Replace instances of Libav with FFmpeg.
Bradley Sepos [Tue, 29 May 2018 23:01:09 +0000 (19:01 -0400)]
cli: Update help to list FFmpeg yadif.
Bradley Sepos [Tue, 29 May 2018 22:43:36 +0000 (18:43 -0400)]
contrib: Another FFmpeg module revision.
Addresses another suggestion here https://github.com/HandBrake/HandBrake/issues/1370#issuecomment-
392958720
Bradley Sepos [Tue, 29 May 2018 22:40:13 +0000 (18:40 -0400)]
contrib: Revise FFmpeg module.
Addresses suggestions here https://github.com/HandBrake/HandBrake/issues/1370#issuecomment-
392958720
-fomit-frame-pointer may still be required on 32-bit Intel; however, we no longer support 32-bit builds.
Bradley Sepos [Tue, 29 May 2018 22:26:03 +0000 (18:26 -0400)]
Revert "contrib: Explicitly disable bzlib and zlib during FFmpeg configure."
This reverts commit
83dfde11d85a3ee1a7583049c75f1044bd62c94b.
Apparently, I was correct the first time around and these need to be enabled, just not explicitly.
Bradley Sepos [Tue, 29 May 2018 21:49:19 +0000 (17:49 -0400)]
macosx: Add liblzma (xz) on Mac.
John Stebbins [Tue, 29 May 2018 20:22:04 +0000 (13:22 -0700)]
LinGui: add liblzma dependency for Ubuntu nightly builds
John Stebbins [Tue, 29 May 2018 19:50:22 +0000 (12:50 -0700)]
contrib: add lzma support
lzma may be used by the ffmpeg tiff decoder which can be used in
matroska files.
John Stebbins [Tue, 29 May 2018 21:27:13 +0000 (14:27 -0700)]
LinGui: remove Ubuntu xenial and trusty from nightly builds
Neither of these support a recent enough version of nasm to build x265
with assembly optimizations. Running without assembly optimizations
isn't acceptable, so just stop building these releases.
John Stebbins [Tue, 29 May 2018 20:25:26 +0000 (13:25 -0700)]
LinGui: add libspeex dependency for Ubuntu nightly builds
John Stebbins [Tue, 29 May 2018 19:59:42 +0000 (12:59 -0700)]
libhb: fix segfault when decoding empty audio track
If an audio track exists, but we receive no audio packets for that
track, this causes a condition that results in a NULL dereference.
Fixes https://github.com/HandBrake/HandBrake/issues/1358
John Stebbins [Tue, 29 May 2018 16:38:29 +0000 (09:38 -0700)]
lame: disable frontend
It's not needed and can cause build errors depending on which mingw tool
chain is installed.
John Stebbins [Tue, 29 May 2018 16:32:16 +0000 (09:32 -0700)]
LinGui: add speex decoder lib
Fixes building with new ffmpeg.
Bradley Sepos [Tue, 29 May 2018 10:27:02 +0000 (06:27 -0400)]
contrib: Explicitly disable bzlib and zlib during FFmpeg configure.
Should have been more thorough in
74dbfebb28d9e65d2f43161bb2b3db8f94005a39.
Bradley Sepos [Tue, 29 May 2018 10:22:20 +0000 (06:22 -0400)]
contrib: Fix FFmpeg configure warning.
Bradley Sepos [Tue, 29 May 2018 09:55:41 +0000 (05:55 -0400)]
Update .gitignore for new Xcode notification.
Use slightly more specific rules.
Bradley Sepos [Tue, 29 May 2018 09:51:07 +0000 (05:51 -0400)]
contrib: Add Speex decoder libspeex.
Bradley Sepos [Tue, 29 May 2018 08:35:24 +0000 (04:35 -0400)]
contrib: test: Strip dll and cli binary in build phase if debug=none.
Bradley Sepos [Tue, 29 May 2018 08:29:21 +0000 (04:29 -0400)]
contrib: Remove unused Libav patches from FFmpeg.
Closes #974 and closes #1078.
Bradley Sepos [Tue, 29 May 2018 06:19:27 +0000 (02:19 -0400)]
contrib: Do not enable bzlib and zlib in FFmpeg.
Per https://github.com/HandBrake/HandBrake/pull/1078#issuecomment-
384461808.
Bradley Sepos [Tue, 29 May 2018 07:00:19 +0000 (03:00 -0400)]
libhb: cli: Link to libbcrypt on mingw-w64.
Bradley Sepos [Tue, 29 May 2018 06:18:26 +0000 (02:18 -0400)]
contrib: Only enable pthreads for non-win32 FFmpeg.
Bradley Sepos [Tue, 29 May 2018 05:37:33 +0000 (01:37 -0400)]
contrib: Update to FFmpeg 4.0.
Use https and swap url order.
Bradley Sepos [Tue, 29 May 2018 05:24:35 +0000 (01:24 -0400)]
contrib: Disable AudioToolbox, CoreImage, VideoToolbox in FFmpeg.
Fixes the build. Hardware acceleration should really be tested before we enable it, even in the nightly.
Bradley Sepos [Tue, 29 May 2018 05:22:51 +0000 (01:22 -0400)]
Mac: Link to FFmpeg's libpostproc and libswresample.
Bradley Sepos [Tue, 29 May 2018 04:24:11 +0000 (00:24 -0400)]
contrib: Remove unnecessary FFmpeg ifeq for Mac/Darwin.
Bradley Sepos [Tue, 29 May 2018 03:58:51 +0000 (23:58 -0400)]
contrib: Use AV_CODEC_ID_ASS for FFmpeg.
Sven Gothel [Fri, 12 Jan 2018 00:53:01 +0000 (01:53 +0100)]
FFMPEG: Use avcodec_free_context(..) instead of deprecated leaking avcodec_close(..)
Hence rename hb_avcodec_close -> hb_avcodec_free_context and pass the required ptr-ptr.
avcodec_free_context(..) ensures releasing of all resources attached to the context.
Sven Gothel [Fri, 12 Jan 2018 01:02:15 +0000 (02:02 +0100)]
FFMPEG decavcodec: Consider returned error from av_buffersrc_add_frame(..)
Sven Gothel [Thu, 28 Dec 2017 11:01:41 +0000 (12:01 +0100)]
FFMPEG: Enable A01-matroskaenc-pgs-duration patch
See http://ffmpeg.org/pipermail/ffmpeg-devel/2017-November/219642.html
Sven Gothel [Thu, 28 Dec 2017 03:28:26 +0000 (04:28 +0100)]
Using AV_CODEC_ID_SUBRIP instead of AV_CODEC_ID_SRT (libav->ffmpeg)
This fixes issue https://trac.ffmpeg.org/ticket/6304
See https://github.com/HandBrake/HandBrake/pull/981#issuecomment-
347364763
See https://github.com/HandBrake/HandBrake/issues/974#issuecomment-
353986772
Sven Gothel [Mon, 25 Dec 2017 22:53:54 +0000 (23:53 +0100)]
FFMPEG #974: Use latest FFMPEG 3.4.1 (2/2)
Patch 2/2 for https://github.com/HandBrake/HandBrake/issues/974
moving to FFMPEG 3.4.1 from LIBAV 12.2.
All patches have been moved to subfolder 'old' since they do not apply cleanly anymore.
Work has to be performed to validate whether patches are still required.
Sven Gothel [Mon, 25 Dec 2017 22:51:31 +0000 (23:51 +0100)]
FFMPEG #974: Use latest FFMPEG 3.4.1 (1/2)
Patch 1/2 for https://github.com/HandBrake/HandBrake/issues/974
moving to FFMPEG 3.4.1 from LIBAV 12.2.
The re-ordering of to be linked modules was required to solve
statically linked dependencies. See libhb/module.defs etc.
Yuichiro NAITO [Tue, 22 May 2018 01:12:04 +0000 (10:12 +0900)]
Fix diff command check for FreeBSD.
FreeBSD's diff doesn't support --version option.
Use hash command to check if diff is available or not.
sr55 [Sat, 26 May 2018 18:05:48 +0000 (19:05 +0100)]
x265: Upgrade to version 2.8
sr55 [Sat, 26 May 2018 19:03:48 +0000 (20:03 +0100)]
x264: Upgrade to snapshot
7d0ff22 r2901
Bradley Sepos [Sat, 26 May 2018 22:47:35 +0000 (18:47 -0400)]
contrib: Explicitly set x265 build type to release.
Build contains debug symbols without this.
sr55 [Thu, 24 May 2018 20:24:48 +0000 (21:24 +0100)]
WinGui: Open and Save File dialogs on the main window, now have their own "MRU" initial directory target. #1353
sr55 [Thu, 24 May 2018 20:07:20 +0000 (21:07 +0100)]
WinGui: Don't allow subtitle import before a source has been scanned.
sr55 [Thu, 24 May 2018 19:59:08 +0000 (20:59 +0100)]
WinGui: Add support for dropping .srt files onto the main window. When you do this, the Subtitles tab is activated and a subtitle track for each file dropped will be added.
John Stebbins [Tue, 22 May 2018 15:12:38 +0000 (08:12 -0700)]
LinGui: fix extra space in debian changelog entry
debuild it's too smart about extra whitespace
John Stebbins [Mon, 21 May 2018 20:21:19 +0000 (13:21 -0700)]
LinGui: set the build date in the debian changelog
Ubuntu build servers appear to set the build machine date/time from
this. So hard coding it to some random date is suboptimal.
Fixes incorrect build date in the HandBrake version line of the
activity log.
sr55 [Fri, 18 May 2018 22:50:20 +0000 (23:50 +0100)]
WinGui: Potential Fix for #1288 Crash in the TreeViewHelper when selecting presets.
sr55 [Fri, 18 May 2018 22:43:01 +0000 (23:43 +0100)]
WinGui: Fix an issue with the Add preset window that prevented it from updating existing non-built-in presets. #1333
sr55 [Sun, 13 May 2018 14:56:38 +0000 (15:56 +0100)]
Lib: Update LibVPX to 1.7.0
This fixes corrupted output issue on macos
sr55 [Fri, 18 May 2018 19:47:53 +0000 (20:47 +0100)]
WinGui: Some more backend work for the upcoming Queue redesign.
John Stebbins [Fri, 18 May 2018 14:39:05 +0000 (07:39 -0700)]
LinGui: fix behaviour of queue add multiple
It was adding titles that were not selected.
Fixes https://github.com/HandBrake/HandBrake/issues/1347
John Stebbins [Thu, 17 May 2018 14:55:34 +0000 (07:55 -0700)]
LinGui: fix opening files on command line
sr55 [Wed, 16 May 2018 20:35:44 +0000 (21:35 +0100)]
WinGui: Improved behaviour of the Add Selection to Queue Window. Can now be resized to full screen and also now supports spacebar selection once a record is selected to toggle the selection checkbox. Fixes #1341
John Stebbins [Tue, 15 May 2018 16:30:25 +0000 (09:30 -0700)]
LinGui: fix display of video quality over slider
After changing video encoders, the slider value was cut off at the
right edge of the window.
Bradley Sepos [Sun, 13 May 2018 07:41:00 +0000 (03:41 -0400)]
libhb: Increase maximum packet read size in stream.c.
Previous value maxed out at lossless x264 4K or so, new value should be large enough for lossless x264 8K.
Fixes #1334.
Bradley Sepos [Thu, 10 May 2018 10:22:24 +0000 (06:22 -0400)]
scripts: Update to mingw-w64-build 4.0.1.
Downgrades binutils to workaround https://sourceware.org/bugzilla/show_bug.cgi?id=22762 until a new version is released. Fixes #1330.
sr55 [Wed, 9 May 2018 17:02:58 +0000 (18:02 +0100)]
WinGui: Make the error checking more aggressive when adding to queue. Add support for bailing out if batch adding and errors occur.
sr55 [Tue, 8 May 2018 20:31:26 +0000 (21:31 +0100)]
WinGui: Remove Logging abstraction from the Services library. Let the library consumers decide how to log instead utilising the log events instead.
sr55 [Tue, 8 May 2018 20:26:35 +0000 (21:26 +0100)]
WinGui: Remove the need for ILog on the key Interop API surface.
sr55 [Tue, 8 May 2018 20:03:21 +0000 (21:03 +0100)]
WinGui: Remove some unnecessary version / bitness calls in the Services library.