]> granicus.if.org Git - libvpx/log
libvpx
11 years agoBugfix in encode_inter_mb_segment_8x8
Deb Mukherjee [Thu, 4 Apr 2013 18:07:19 +0000 (11:07 -0700)]
Bugfix in encode_inter_mb_segment_8x8

Fixes an indexing bug. Looks like the bug has been there for a while.

Change-Id: I9fc04b0c30754bcb47366ad94a08112925600c4d

11 years agoMerge "Remove special case vp9_decode_coefs_4x4" into experimental
John Koleszar [Thu, 4 Apr 2013 14:11:31 +0000 (07:11 -0700)]
Merge "Remove special case vp9_decode_coefs_4x4" into experimental

11 years agoFixed incorrect use of compute_qdelta()
Paul Wilkins [Thu, 28 Mar 2013 19:46:35 +0000 (19:46 +0000)]
Fixed incorrect use of compute_qdelta()

This function expects real Q values as inputs
not index values.

The use-age her impacts the Q chosen for force key
frames. Though this is a bug fix I have not yet verified
whether following the bug fix the q multiplier value used is
correct.

Change-Id: I49f6da894d90baeb1e86c820c335f02dc80d3b66

11 years agoMerge "Adding decode_sb_16x16 function." into experimental
John Koleszar [Thu, 4 Apr 2013 04:07:53 +0000 (21:07 -0700)]
Merge "Adding decode_sb_16x16 function." into experimental

11 years agoMerge "Reimplementation of setup_frame_size." into experimental
John Koleszar [Thu, 4 Apr 2013 04:04:29 +0000 (21:04 -0700)]
Merge "Reimplementation of setup_frame_size." into experimental

11 years agoMerge "Adding setup_pred_probs and read_txfm_mode functions." into experimental
John Koleszar [Thu, 4 Apr 2013 04:02:59 +0000 (21:02 -0700)]
Merge "Adding setup_pred_probs and read_txfm_mode functions." into experimental

11 years agoMerge "General code cleanup." into experimental
John Koleszar [Thu, 4 Apr 2013 03:59:51 +0000 (20:59 -0700)]
Merge "General code cleanup." into experimental

11 years agoGeneral code cleanup.
Dmitry Kovalev [Thu, 4 Apr 2013 01:40:17 +0000 (18:40 -0700)]
General code cleanup.

Making code more readable in different places.

Change-Id: Iea92c9a35e64d257ee358879fc04fc926843d52e

11 years agoAdding decode_sb_16x16 function.
Dmitry Kovalev [Thu, 4 Apr 2013 01:37:28 +0000 (18:37 -0700)]
Adding decode_sb_16x16 function.

Moving command code from decode_sb32 and decode_sb64 into new
decode_sb_16x16 function.

Change-Id: I57a161300af085557adec2fe600f3c10a145faf2

11 years agoMerge "Motion vector decoder cleanup." into experimental
John Koleszar [Thu, 4 Apr 2013 01:00:31 +0000 (18:00 -0700)]
Merge "Motion vector decoder cleanup." into experimental

11 years agoMotion vector decoder cleanup.
Dmitry Kovalev [Thu, 4 Apr 2013 00:43:45 +0000 (17:43 -0700)]
Motion vector decoder cleanup.

Better formatting, shorter code, adding read_switchable_filter_type
function.

Change-Id: Ib919b529385cae34c2d682b1c3093518b6942fc1

11 years agoRemove special case vp9_decode_coefs_4x4
John Koleszar [Wed, 3 Apr 2013 23:12:11 +0000 (16:12 -0700)]
Remove special case vp9_decode_coefs_4x4

This code was only called in the BPRED case, but had no real special
case associated with it. Made BPRED behave like all other modes. No
bitstream change.

Change-Id: I87ba11fe723928b6314d094979011228d5ba006f

11 years agoMerge "Modify vp9_setup_interp_filters function" into experimental
Yunqing Wang [Wed, 3 Apr 2013 21:09:01 +0000 (14:09 -0700)]
Merge "Modify vp9_setup_interp_filters function" into experimental

11 years agoModify vp9_setup_interp_filters function
Yunqing Wang [Wed, 3 Apr 2013 19:22:50 +0000 (12:22 -0700)]
Modify vp9_setup_interp_filters function

Took vp9_setup_scale_factors_for_frame() out from
vp9_setup_interp_filters(), so that it is only called once per
frame instead of per macroblock. Decoder tests showed a 1.5%
performance gain.

Change-Id: I770cb09eb2140ab85132f82aed388ac0bdd3a0aa

11 years agoReimplementation of setup_frame_size.
Dmitry Kovalev [Wed, 3 Apr 2013 19:21:47 +0000 (12:21 -0700)]
Reimplementation of setup_frame_size.

General code cleanup in loopfilter code. Modification of setup_frame_size,
so now VP9_COMMON is modified in one place after all width/height checks
passed.

Change-Id: Iedf32df43a912d7aae788ed276ac6c429973f6fe

11 years agoAdding setup_pred_probs and read_txfm_mode functions.
Dmitry Kovalev [Wed, 3 Apr 2013 19:18:15 +0000 (12:18 -0700)]
Adding setup_pred_probs and read_txfm_mode functions.

Decomposition vp9_decode_frame function, moving code into read_txfm_mode
and setup_pred_probs functions.

Change-Id: I90970dea43cbcef4d6d61fdef267c2094ddee65d

11 years agoMerge "Fix overlapping writes by copy_and_extend_plane" into experimental
John Koleszar [Wed, 3 Apr 2013 18:54:29 +0000 (11:54 -0700)]
Merge "Fix overlapping writes by copy_and_extend_plane" into experimental

11 years agoMerge "Remove unused inplace idct_add functions" into experimental
John Koleszar [Wed, 3 Apr 2013 18:10:50 +0000 (11:10 -0700)]
Merge "Remove unused inplace idct_add functions" into experimental

11 years agoMerge "Renaming sb32_coded and sb64_coded fields." into experimental
John Koleszar [Wed, 3 Apr 2013 04:49:03 +0000 (21:49 -0700)]
Merge "Renaming sb32_coded and sb64_coded fields." into experimental

11 years agoMerge "Lower case names for struct members." into experimental
John Koleszar [Wed, 3 Apr 2013 04:27:32 +0000 (21:27 -0700)]
Merge "Lower case names for struct members." into experimental

11 years agoMerge "Adding functions with common code for superblock decoding." into experimental
John Koleszar [Wed, 3 Apr 2013 03:18:13 +0000 (20:18 -0700)]
Merge "Adding functions with common code for superblock decoding." into experimental

11 years agoMerge "Code cleanup in vp9_onyx_if.c." into experimental
John Koleszar [Wed, 3 Apr 2013 03:16:56 +0000 (20:16 -0700)]
Merge "Code cleanup in vp9_onyx_if.c." into experimental

11 years agoRenaming sb32_coded and sb64_coded fields.
Dmitry Kovalev [Wed, 3 Apr 2013 01:21:55 +0000 (18:21 -0700)]
Renaming sb32_coded and sb64_coded fields.

Renaming sb32_coded to prob_sb32_coded and sb64_coded to prob_sb64_coded.

Change-Id: I6de5cad00a57c3e066d53467f8c38cb6073dce11

11 years agoFix overlapping writes by copy_and_extend_plane
John Koleszar [Tue, 2 Apr 2013 21:57:44 +0000 (14:57 -0700)]
Fix overlapping writes by copy_and_extend_plane

Broken by refactoring commit 180cd5faa52e00a77df13da15d846cfd909fc531

Change-Id: I307f6e54d93219a31e7336f1633103ecb25e4832

11 years agoMerge branch 'master' into experimental
John Koleszar [Tue, 2 Apr 2013 21:54:44 +0000 (14:54 -0700)]
Merge branch 'master' into experimental

Conflicts:
vp9/vp9_common.mk

Change-Id: I2cd5ab47dc31c4210cefc23a282102123d5e2221

11 years agoLower case names for struct members.
Dmitry Kovalev [Tue, 2 Apr 2013 20:34:20 +0000 (13:34 -0700)]
Lower case names for struct members.

Lower case member names inside VP9D_CONFIG and VP9D_COMP structs.

Change-Id: I75af9ad2d929a35c357207a3fd9ebedddabf79c3

11 years agoDemux vp9_loopfilter_x86.c
Johann [Tue, 2 Apr 2013 18:45:01 +0000 (11:45 -0700)]
Demux vp9_loopfilter_x86.c

Allow more careful targeting of compiler flags.

Change-Id: I963ab4a6479dedb165419310dfca52a58a9877b8

11 years agoRemove unused inplace idct_add functions
John Koleszar [Tue, 2 Apr 2013 19:23:22 +0000 (12:23 -0700)]
Remove unused inplace idct_add functions

Change-Id: I1c29e041d6db4af4508356315cd65718acb1f668

11 years agovp9_sadmxn_x86 only contains SSE2 functions
Johann [Tue, 2 Apr 2013 18:20:55 +0000 (11:20 -0700)]
vp9_sadmxn_x86 only contains SSE2 functions

Rename the file and clean up includes. In the future we would like to
pattern match the files which need additional compiler flags.

Change-Id: I2c76256467f392a78dd4ccc71e6e0a580e158e56

11 years agoAdding functions with common code for superblock decoding.
Dmitry Kovalev [Fri, 29 Mar 2013 23:31:46 +0000 (16:31 -0700)]
Adding functions with common code for superblock decoding.

Adding decode_sb_8x8 and decode_sb_4x4 with common code for superblock
decoding. Renaming decode_superblock32 to decode_sb32 and
decode_superblock64 to decode_sb64.

Change-Id: Id006d7e398b9bfa3acec4326e1e0c537ebfefdd3

11 years agoCode cleanup in vp9_onyx_if.c.
Dmitry Kovalev [Tue, 2 Apr 2013 17:24:56 +0000 (10:24 -0700)]
Code cleanup in vp9_onyx_if.c.

Using clamp and MIN/MAX functions instead of plain C code. Lower case
variable names. Removing redundant parenthesis.

Change-Id: Ibf7cc5fbe4fbdb5029049a599af71534176e6f42

11 years agoMerge "Code cleanup." into experimental
John Koleszar [Tue, 2 Apr 2013 04:12:56 +0000 (21:12 -0700)]
Merge "Code cleanup." into experimental

11 years agoMerge "Removing redundant function arguments." into experimental
John Koleszar [Tue, 2 Apr 2013 04:09:48 +0000 (21:09 -0700)]
Merge "Removing redundant function arguments." into experimental

11 years agoMerge "Code cleanup in block reconstruction code." into experimental
John Koleszar [Tue, 2 Apr 2013 04:05:35 +0000 (21:05 -0700)]
Merge "Code cleanup in block reconstruction code." into experimental

11 years agoCode cleanup in block reconstruction code.
Dmitry Kovalev [Tue, 2 Apr 2013 01:26:58 +0000 (18:26 -0700)]
Code cleanup in block reconstruction code.

Adding recon, recond_sby and recon_sbuv functions.

Change-Id: I6050db233e792e73a3699d18b056eaef9c901d6d

11 years agoCode cleanup.
Dmitry Kovalev [Tue, 2 Apr 2013 01:23:04 +0000 (18:23 -0700)]
Code cleanup.

Adding multiple16 function, removing redundant code, better formatting.

Change-Id: I50195b78ac8ab803e3d05c8fb05a7ca134fab386

11 years agoMerge "Calculate SSIM over both reconstruction as well as postproc buffer." into...
Ronald S. Bultje [Tue, 2 Apr 2013 00:22:29 +0000 (17:22 -0700)]
Merge "Calculate SSIM over both reconstruction as well as postproc buffer." into experimental

11 years agoAdding/Uncommenting elements for Alpha Support
Vignesh Venkatasubramanian [Mon, 1 Apr 2013 22:36:29 +0000 (15:36 -0700)]
Adding/Uncommenting elements for Alpha Support

Uncommenting Track elements related to BlockAdditional and adding
the new AlphaMode element as specified in the matroska spec here:
http://matroska.org/technical/specs/index.html#AlphaMode

Change-Id: I87895931e8885e4832efa74776ab1bea91a634e2

11 years agoCalculate SSIM over both reconstruction as well as postproc buffer.
Ronald S. Bultje [Mon, 1 Apr 2013 16:10:27 +0000 (09:10 -0700)]
Calculate SSIM over both reconstruction as well as postproc buffer.

We used to calculate SSIM only over the postproc buffer, whereas we
calculate PSNR for both. Compared to postproc-SSIM, this is about 0.3%
higher for derf, 1.4% lower for hd and 0.5% lower for stdhd, although
it is highly variable on a per-clip basis.

Change-Id: I8dd491f0f5b4201dedfb15d288c854d5d4caa10f

11 years agoMerge "Framework changes in nzc to allow more flexibility" into experimental
Deb Mukherjee [Fri, 29 Mar 2013 22:57:27 +0000 (15:57 -0700)]
Merge "Framework changes in nzc to allow more flexibility" into experimental

11 years agoMerge "Tokenization code cleanup." into experimental
John Koleszar [Fri, 29 Mar 2013 17:55:55 +0000 (10:55 -0700)]
Merge "Tokenization code cleanup." into experimental

11 years agoMerge "Extracting common motion vector prediction code." into experimental
John Koleszar [Fri, 29 Mar 2013 17:43:38 +0000 (10:43 -0700)]
Merge "Extracting common motion vector prediction code." into experimental

11 years agoMerge "General code cleanup." into experimental
John Koleszar [Fri, 29 Mar 2013 17:40:34 +0000 (10:40 -0700)]
Merge "General code cleanup." into experimental

11 years agoMerge "Extracting decode_tiles function." into experimental
John Koleszar [Fri, 29 Mar 2013 17:25:34 +0000 (10:25 -0700)]
Merge "Extracting decode_tiles function." into experimental

11 years agoMerge "define a specific neighborhood for SB64 mv search" into experimental
Yaowu Xu [Fri, 29 Mar 2013 16:26:14 +0000 (09:26 -0700)]
Merge "define a specific neighborhood for SB64 mv search" into experimental

11 years agoMerge "remove code not in use" into experimental
Yaowu Xu [Fri, 29 Mar 2013 15:40:29 +0000 (08:40 -0700)]
Merge "remove code not in use" into experimental

11 years agoMerge "Reoptimizing the interpolation filters" into experimental
Deb Mukherjee [Fri, 29 Mar 2013 14:15:05 +0000 (07:15 -0700)]
Merge "Reoptimizing the interpolation filters" into experimental

11 years agoMerge "Bug fix: Issue 532: VPX codec executes emms instruction without"
Scott LaVarnway [Thu, 28 Mar 2013 21:26:13 +0000 (14:26 -0700)]
Merge "Bug fix: Issue 532: VPX codec executes emms instruction without"

11 years agoMerge "Adjust mv_ratio_accumulator threshold." into experimental
Paul Wilkins [Thu, 28 Mar 2013 19:53:23 +0000 (12:53 -0700)]
Merge "Adjust mv_ratio_accumulator threshold." into experimental

11 years agoMerge "Fix mix-up in pt token indexing." into experimental
Ronald S. Bultje [Thu, 28 Mar 2013 19:53:00 +0000 (12:53 -0700)]
Merge "Fix mix-up in pt token indexing." into experimental

11 years agoMerge "Fix crash when --tune=ssim is selected." into experimental
Yaowu Xu [Thu, 28 Mar 2013 18:23:44 +0000 (11:23 -0700)]
Merge "Fix crash when --tune=ssim is selected." into experimental

11 years agoMerge "Save nzcstats." into experimental
Ronald S. Bultje [Thu, 28 Mar 2013 16:36:58 +0000 (09:36 -0700)]
Merge "Save nzcstats." into experimental

11 years agoFramework changes in nzc to allow more flexibility
Deb Mukherjee [Tue, 26 Mar 2013 22:23:30 +0000 (15:23 -0700)]
Framework changes in nzc to allow more flexibility

The patch adds the flexibility to use standard EOB based coding
on smaller block sizes and nzc based coding on larger blocksizes.
The tx-sizes that use nzc based coding and those that use EOB based
coding are controlled by a function get_nzc_used().
By default, this function uses nzc based coding for 16x16 and 32x32
transform blocks, which seem to bridge the performance gap
substantially.

All sets are now lower by 0.5% to 0.7%, as opposed to ~1.8% before.

Change-Id: I06abed3df57b52d241ea1f51b0d571c71e38fd0b

11 years agoFix mix-up in pt token indexing.
Ronald S. Bultje [Thu, 28 Mar 2013 16:24:29 +0000 (09:24 -0700)]
Fix mix-up in pt token indexing.

This fixes uninitialized reads in the trellis, and probably makes the
trellis do something again.

Change-Id: Ifac8dae9aa77574bde0954a71d4571c5c556df3c

11 years agoAdjust mv_ratio_accumulator threshold.
Paul Wilkins [Tue, 26 Mar 2013 14:40:24 +0000 (14:40 +0000)]
Adjust mv_ratio_accumulator threshold.

This threshold effectively limits the amount of motion
from one end of a GF/ARF group to the other.
This patch makes the threshold depend on image size.

Change-Id: Id45d1d7bced815f86ddd037be53164894b00b82f

11 years agoFix crash when --tune=ssim is selected.
Paul Wilkins [Tue, 26 Mar 2013 13:11:52 +0000 (13:11 +0000)]
Fix crash when --tune=ssim is selected.

Crash fix only. No functional change or testing.

Change-Id: I0c6d114d024c29fc11ae61666f5938f11b01dd6a

11 years agodefine a specific neighborhood for SB64 mv search
Yaowu Xu [Wed, 27 Mar 2013 18:07:44 +0000 (11:07 -0700)]
define a specific neighborhood for SB64 mv search

Change-Id: Ifda91d697c5970c65ce3ec1feac5562124f91782

11 years agoExtracting decode_tiles function.
Dmitry Kovalev [Wed, 27 Mar 2013 23:23:12 +0000 (16:23 -0700)]
Extracting decode_tiles function.

Extracting decode_tiles function from vp9_decode_frame.

Change-Id: I02a465eeaf76138ef3559e1d46deb452c10e1219

11 years agoRemoving redundant function arguments.
Dmitry Kovalev [Wed, 27 Mar 2013 23:19:27 +0000 (16:19 -0700)]
Removing redundant function arguments.

Almost all arguments for vp9_build_inter32x32_predictors_sb and
vp9_build_inter64x64_predictors_sb can be deduced from the first macroblock
argument.

Change-Id: I5d477a607586d05698d5b3b9b9bc03891dd3fe83

11 years agoExtracting common motion vector prediction code.
Dmitry Kovalev [Wed, 27 Mar 2013 21:35:36 +0000 (14:35 -0700)]
Extracting common motion vector prediction code.

Adding b_mv_pred_row and b_mv_pred_col functions, updating
mi_mv_pred_row and mi_mv_pred_row functions.

Change-Id: I9af068442d4474478375943cc6fce1605d6fc0a5

11 years agoGeneral code cleanup.
Dmitry Kovalev [Wed, 27 Mar 2013 21:22:30 +0000 (14:22 -0700)]
General code cleanup.

Removing redundant code, lower case variable names, better indentation,
better parameter names, adding const to readonly parameters.

Change-Id: Ibfdee00f60316fdc5b3f024028c7aaa76a627483

11 years agoMerge "Extract setup_frame_size and update_frame_context functions." into experimental
John Koleszar [Wed, 27 Mar 2013 21:21:57 +0000 (14:21 -0700)]
Merge "Extract setup_frame_size and update_frame_context functions." into experimental

11 years agoExtract setup_frame_size and update_frame_context functions.
Dmitry Kovalev [Wed, 27 Mar 2013 21:04:35 +0000 (14:04 -0700)]
Extract setup_frame_size and update_frame_context functions.

Extracting setup_frame_size and update_frame_context functions. Introducing
vp9_read_prob function as shortcut for (vp9_prob)vp9_read_literal(r, 8).

Change-Id: Ia5c68fd725b2d1b9c5eb20f69cacb62361b5a3dd

11 years agoTokenization code cleanup.
Dmitry Kovalev [Wed, 27 Mar 2013 21:03:56 +0000 (14:03 -0700)]
Tokenization code cleanup.

Moving almost identical code to decode_sb32 and decode_sb64 functions.

Change-Id: Id39377aa5106be85d5b0fc3f83586b3779a6c0da

11 years agoMerge "Convert inv_tile_order to control interface" into experimental
John Koleszar [Wed, 27 Mar 2013 20:41:12 +0000 (13:41 -0700)]
Merge "Convert inv_tile_order to control interface" into experimental

11 years agoMerge "Convert g_frame_parallel_decoding to control interface" into experimental
John Koleszar [Wed, 27 Mar 2013 20:41:09 +0000 (13:41 -0700)]
Merge "Convert g_frame_parallel_decoding to control interface" into experimental

11 years agoMerge "Modify idct code to use macro" into experimental
Yunqing Wang [Wed, 27 Mar 2013 19:51:41 +0000 (12:51 -0700)]
Merge "Modify idct code to use macro" into experimental

11 years agoModify idct code to use macro
Yunqing Wang [Wed, 27 Mar 2013 19:36:08 +0000 (12:36 -0700)]
Modify idct code to use macro

Small modification of idct code.

Change-Id: I5c4e3223944c68e4ccf762f6cf07c990250e4290

11 years agoMerge "Merge branch 'master' into experimental" into experimental
John Koleszar [Wed, 27 Mar 2013 19:29:32 +0000 (12:29 -0700)]
Merge "Merge branch 'master' into experimental" into experimental

11 years agoMerge "Cleaning up rate control code." into experimental
John Koleszar [Wed, 27 Mar 2013 19:29:00 +0000 (12:29 -0700)]
Merge "Cleaning up rate control code." into experimental

11 years agoMerge "Optimize 32x32 idct function" into experimental
Yunqing Wang [Wed, 27 Mar 2013 18:30:48 +0000 (11:30 -0700)]
Merge "Optimize 32x32 idct function" into experimental

11 years agoConvert inv_tile_order to control interface
John Koleszar [Wed, 27 Mar 2013 18:22:20 +0000 (11:22 -0700)]
Convert inv_tile_order to control interface

Restore ABI compatibility with the master branch.

Change-Id: Ie9f6fdf536662bd87dfcf114d16f003422670763

11 years agoConvert g_frame_parallel_decoding to control interface
John Koleszar [Wed, 27 Mar 2013 18:07:26 +0000 (11:07 -0700)]
Convert g_frame_parallel_decoding to control interface

Restore ABI compatibility with the master branch.

Change-Id: Ic57e7e1de09ab33bd37990e52a63ba7c8f1432a4

11 years agoOptimize 32x32 idct function
Yunqing Wang [Wed, 27 Mar 2013 17:46:35 +0000 (10:46 -0700)]
Optimize 32x32 idct function

Wrote sse2 version of vp9_short_idct_32x32 function. Compared
to c version, the sse2 version is 5X faster.

Change-Id: I071ab7378358346ab4d9c6e2980f713c3c209864

11 years agoMerge branch 'master' into experimental
John Koleszar [Wed, 27 Mar 2013 17:41:29 +0000 (10:41 -0700)]
Merge branch 'master' into experimental

Pick up VP8 encryption, quantization changes, and some fixes to vpxenc

Conflicts:
test/decode_test_driver.cc
test/decode_test_driver.h
test/encode_test_driver.cc
vp8/vp8cx.mk
vpxdec.c
vpxenc.c

Change-Id: I9fbcc64808ead47e22f1f22501965cc7f0c4791c

11 years agoSave nzcstats.
Ronald S. Bultje [Mon, 25 Mar 2013 23:29:45 +0000 (16:29 -0700)]
Save nzcstats.

Change-Id: I4a3a9eb9f9d17218a0f0d7e148123d34dae879c2

11 years agoScatter-based scantables.
Ronald S. Bultje [Mon, 25 Mar 2013 19:14:01 +0000 (12:14 -0700)]
Scatter-based scantables.

This gains about 0.2% on derf, 0.1% on hd and 0.4% on stdhd. I can put
this under an experimental flag if wanted, just trying to get my patch
queue in shape.

Change-Id: Ibe1a30fe0e0b07bec4802e0f3ff0ba22e505f576

11 years agoMerge "ENTROPY_STATS -> VP8_ENTROPY_STATS in vp8/." into experimental
Ronald S. Bultje [Wed, 27 Mar 2013 02:18:02 +0000 (19:18 -0700)]
Merge "ENTROPY_STATS -> VP8_ENTROPY_STATS in vp8/." into experimental

11 years agoMerge "Add col/row-based coefficient scanning patterns for 1D 8x8/16x16 ADSTs." into...
Ronald S. Bultje [Wed, 27 Mar 2013 02:17:08 +0000 (19:17 -0700)]
Merge "Add col/row-based coefficient scanning patterns for 1D 8x8/16x16 ADSTs." into experimental

11 years agoMerge "Redo banding for all transforms." into experimental
Ronald S. Bultje [Wed, 27 Mar 2013 02:16:44 +0000 (19:16 -0700)]
Merge "Redo banding for all transforms." into experimental

11 years agoMerge "Use above/left (instead of previous in scan-order) as token context." into...
Ronald S. Bultje [Wed, 27 Mar 2013 02:16:24 +0000 (19:16 -0700)]
Merge "Use above/left (instead of previous in scan-order) as token context." into experimental

11 years agoImplicit weighted prediction experiment
Deb Mukherjee [Tue, 12 Mar 2013 21:21:08 +0000 (14:21 -0700)]
Implicit weighted prediction experiment

Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.

Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.

Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%

The experiment suggests bigger benefit for explicitly signaled weights.

Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a

11 years agoAdd col/row-based coefficient scanning patterns for 1D 8x8/16x16 ADSTs.
Ronald S. Bultje [Mon, 25 Mar 2013 19:30:00 +0000 (12:30 -0700)]
Add col/row-based coefficient scanning patterns for 1D 8x8/16x16 ADSTs.

These are mostly just for experimental purposes. I saw small gains (in
the 0.1% range) when playing with this on derf.

Change-Id: Ib21eed477bbb46bddcd73b21c5c708a5b46abedc

11 years agoRedo banding for all transforms.
Ronald S. Bultje [Mon, 25 Mar 2013 19:28:24 +0000 (12:28 -0700)]
Redo banding for all transforms.

Now that the first AC coefficient in both directions use the same DC
as their context, there no longer is a purpose in letting both have
their own band. Merging these two bands allows us to split bands for
some of the very high-frequency AC bands.

In addition, I'm redoing the banding for the 1D-ADST col/row scans. I
don't think the old banding made any sense at all (it merged the last
coefficient of the first row/col in the same band as the first two of
the second row/col), which was clearly an oversight from the band being
applied in scan-order (rather than in their actual position). Now,
coefficients at the same position will be in the same band, regardless
what scan order is used. I think this makes most sense for the purpose
of banding, which is basically "predict energy for this coefficient
depending on the energy of context coefficients" (i.e. pt).

After full re-training, together with previous patch, derf gains about
1.2-1.3%, and hd/stdhd gain about 0.9-1.0%.

Change-Id: I7a0cc12ba724e88b278034113cb4adaaebf87e0c

11 years agoUse above/left (instead of previous in scan-order) as token context.
Ronald S. Bultje [Tue, 26 Mar 2013 23:46:09 +0000 (16:46 -0700)]
Use above/left (instead of previous in scan-order) as token context.

Pearson correlation for above or left is significantly higher than for
previous-in-scan-order (absolute values depend on position in scan, but
in general, we gain about 0.1-0.2 by using either above or left; using
both basically just makes this even better). For eob branch skipping,
we continue to use the previous token in scan order.

This helps about 0.9% on derf after re-training on a limited data set.
Full re-training and results on larger-resolution clips are pending.

Note that this commit breaks trellis, so we can probably get further
gains out of it by fixing trellis at some later point.

Change-Id: Iead68e296fc3a105cca746b5e3da9555d6010cfe

11 years agoReoptimizing the interpolation filters
Deb Mukherjee [Tue, 26 Mar 2013 05:10:06 +0000 (22:10 -0700)]
Reoptimizing the interpolation filters

Reoptimizes the 8-tap smooth filter.

Results:
derf: +0.101%
yt: +0.157%
hd: +0.791%
stdhd: +0.264%

The next step will be to reoptimize the other two filters.

Change-Id: I3d256a510ad9c7c30c33fae4a70fb43dfc708ed0

11 years agoremove code not in use
Yaowu Xu [Tue, 26 Mar 2013 22:27:35 +0000 (15:27 -0700)]
remove code not in use

Change-Id: I4fa46f10e82aca36c563f7ea829e5a3177a0c740

11 years agoMerge "Cleaning up loopfilter code." into experimental
John Koleszar [Tue, 26 Mar 2013 19:40:37 +0000 (12:40 -0700)]
Merge "Cleaning up loopfilter code." into experimental

11 years agoCleaning up rate control code.
Dmitry Kovalev [Tue, 26 Mar 2013 18:25:58 +0000 (11:25 -0700)]
Cleaning up rate control code.

Lower case variable names, declaration and initialization on the same line,
removing redundant casts to double.

Change-Id: I7ea3905bed827aa6faac11a78401b85e448b57f9

11 years agoCleaning up loopfilter code.
Dmitry Kovalev [Tue, 26 Mar 2013 18:08:34 +0000 (11:08 -0700)]
Cleaning up loopfilter code.

Lower case variable names, removing redundant variables, declaration and
initialization on the same line.

Change-Id: Ie0c6c95b14103990eb6a9d7784f8259c662e1251

11 years agoDecomposition of vp9_decode_frame function.
Dmitry Kovalev [Tue, 26 Mar 2013 18:04:25 +0000 (11:04 -0700)]
Decomposition of vp9_decode_frame function.

Moving code from vp9_decode_frame function into setup_loopfilter and
setup_segmentation functions. A little bit of cleanup.

Change-Id: I2cce1813e4d7aeec701ccf752bf57e3bdd41b51c

11 years agoMerge "Add an in-loop deringing experiment" into experimental
John Koleszar [Tue, 26 Mar 2013 15:36:55 +0000 (08:36 -0700)]
Merge "Add an in-loop deringing experiment" into experimental

11 years agoMerge "Code cleanup." into experimental
John Koleszar [Tue, 26 Mar 2013 15:34:06 +0000 (08:34 -0700)]
Merge "Code cleanup." into experimental

11 years agoMerge "Code cleanup." into experimental
John Koleszar [Tue, 26 Mar 2013 15:30:46 +0000 (08:30 -0700)]
Merge "Code cleanup." into experimental

11 years agoMerge "Changing initialization order of mb_to_top_edge & mb_to_bottom_edge" into...
John Koleszar [Tue, 26 Mar 2013 15:25:45 +0000 (08:25 -0700)]
Merge "Changing initialization order of mb_to_top_edge & mb_to_bottom_edge" into experimental

11 years agoAdd an in-loop deringing experiment
John Koleszar [Wed, 20 Mar 2013 17:22:20 +0000 (10:22 -0700)]
Add an in-loop deringing experiment

Adds a per-frame, strength adjustable, in loop deringing filter. Uses
the existing vp9_post_proc_down_and_across 5 tap thresholded blur
code, with a brute force search for the threshold.

Results almost strictly positive on the YT HD set, either having no
effect or helping PSNR in the range of 1-3% (overall average 0.8%).
Results more mixed for the CIF set, (-0.5 min, 1.4 max, 0.1 avg).
This has an almost strictly negative impact to SSIM, so examining a
different filter or a more balanced search heuristic is in order.

Other test set results pending.

Change-Id: I5ca6ee8fe292dfa3f2eab7f65332423fa1710b58

11 years agoBugfix in model coef prob experiment
Deb Mukherjee [Tue, 26 Mar 2013 14:29:24 +0000 (07:29 -0700)]
Bugfix in model coef prob experiment

Fixes an issue with model based update that got into
the original patch that was merged.

Change-Id: Ie42d3d0aff2e48cd187d96664dbd3e9d6d3ac22f

11 years agoMerge "Modeling default coef probs with distribution" into experimental
Deb Mukherjee [Tue, 26 Mar 2013 14:13:13 +0000 (07:13 -0700)]
Merge "Modeling default coef probs with distribution" into experimental

11 years agoModeling default coef probs with distribution
Deb Mukherjee [Wed, 13 Mar 2013 18:03:17 +0000 (11:03 -0700)]
Modeling default coef probs with distribution

Replaces the default tables for single coefficient magnitudes with
those obtained from an appropriate distribution. The EOB node
is left unchanged. The model is represeted as a 256-size codebook
where the index corresponds to the probability of the Zero or the
One node. Two variations are implemented corresponding to whether
the Zero node or the One-node is used as the peg. The main advantage
is that the default prob tables will become considerably smaller and
manageable. Besides there is substantially less risk of over-fitting
for a training set.

Various distributions are tried and the one that gives the best
results is the family of Generalized Gaussian distributions with
shape parameter 0.75. The results are within about 0.2% of fully
trained tables for the Zero peg variant, and within 0.1% of the
One peg variant.

The forward updates are optionally (controlled by a macro)
model-based, i.e. restricted to only convey probabilities from the
codebook. Backward updates can also be optionally (controlled by
another macro) model-based, but is turned off by default. Currently
model-based forward updates work about the same as unconstrained
updates, but there is a drop in performance with backward-updates
being model based.

The model based approach also allows the probabilities for the key
frames to be adjusted from the defaults based on the base_qindex of
the frame. Currently the adjustment function is a placeholder that
adjusts the prob of EOB and Zero node from the nominal one at higher
quality (lower qindex) or lower quality (higher qindex) ends of the
range. The rest of the probabilities are then derived based on the
model from the adjusted prob of zero.

Change-Id: Iae050f3cbcc6d8b3f204e8dc395ae47b3b2192c9

11 years agoCode cleanup.
Dmitry Kovalev [Mon, 25 Mar 2013 22:16:14 +0000 (15:16 -0700)]
Code cleanup.

Fixing function arguments alignment, reusing MIN/MAX and clamp functions.

Change-Id: I87dd5a40ffb65b521b8abbf0fccf2f50552c5309