Michael Meskes [Thu, 18 Sep 2003 13:12:23 +0000 (13:12 +0000)]
- Accept output variables for FETCH in DECLARE statement.
- Synced parser.
- Allowed C variables to carry the name of prepared statements.
- Added Informix handling of datatype converion errors.
Barry Lind [Thu, 18 Sep 2003 04:14:27 +0000 (04:14 +0000)]
Applied patch from Oliver Jowett to clean up some instances where the wrong
type was being reported for PREPAREs.
Modified Files:
jdbc/org/postgresql/jdbc1/AbstractJdbc1Statement.java
jdbc/org/postgresql/test/jdbc2/ServerPreparedStmtTest.java
Barry Lind [Thu, 18 Sep 2003 04:09:02 +0000 (04:09 +0000)]
Small jdbc patch from Kim Ho at RedHat to fix some boolean problems
Modified Files:
jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSet.java
Barry Lind [Thu, 18 Sep 2003 03:58:16 +0000 (03:58 +0000)]
A minor fix to jdbc regression tests
Modified Files:
jdbc/org/postgresql/test/jdbc2/DatabaseMetaDataPropertiesTest.java
Tom Lane [Wed, 17 Sep 2003 17:19:17 +0000 (17:19 +0000)]
Disallow converting a table to a view if it has triggers, indexes, or
child tables --- all cases that will trip various sanity checks elsewhere
in the system, as well as cases that should not occur in the only intended
use of this feature, namely coping with ancient pg_dump representation
of views. Per bug report from Chris Pizzi.
Barry Lind [Wed, 17 Sep 2003 08:21:36 +0000 (08:21 +0000)]
Applied patch to jdbc from Kim Ho at RedHat, fixing improper handling of empty queries under the V3 protocol
Modified Files:
jdbc/org/postgresql/core/QueryExecutor.java
Barry Lind [Wed, 17 Sep 2003 07:00:24 +0000 (07:00 +0000)]
Applied patch for jdbc from Kim Ho at RedHat to more correctly deal with boolean values
Modified Files:
jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSet.java
Barry Lind [Wed, 17 Sep 2003 06:42:47 +0000 (06:42 +0000)]
Fixed jdbc to correctly report that constraints are supported
Modified Files:
jdbc/org/postgresql/jdbc1/AbstractJdbc1DatabaseMetaData.java
Barry Lind [Wed, 17 Sep 2003 05:14:52 +0000 (05:14 +0000)]
Applied patch from Fernando Nasser of RedHat to fix some error messages
that would not get correctly looked up in the translation files for jdbc
Modified Files:
jdbc/org/postgresql/errors.properties
jdbc/org/postgresql/jdbc2/AbstractJdbc2ResultSet.java
Barry Lind [Wed, 17 Sep 2003 05:07:38 +0000 (05:07 +0000)]
Applied patch from Kim Ho at redhat to improve boolean and bit handling
in the jdbc driver
Modified Files:
jdbc/org/postgresql/jdbc1/AbstractJdbc1Statement.java
jdbc/org/postgresql/jdbc3/AbstractJdbc3Statement.java
Tatsuo Ishii [Wed, 17 Sep 2003 04:25:29 +0000 (04:25 +0000)]
Fix typo in comment
Tom Lane [Tue, 16 Sep 2003 17:59:02 +0000 (17:59 +0000)]
Make psql correctly track the effects of SET CLIENT_ENCODING commands.
I thought I'd fixed this earlier, but I didn't get it right ...
Tatsuo Ishii [Tue, 16 Sep 2003 07:47:06 +0000 (07:47 +0000)]
fix typo in a comment
Tom Lane [Tue, 16 Sep 2003 04:32:28 +0000 (04:32 +0000)]
I don't care whether it's informix-compatible or not: #defining a word
like 'date' in a public header file is a damn fool idea.
Tom Lane [Tue, 16 Sep 2003 01:07:51 +0000 (01:07 +0000)]
Fix some problems with dropped columns in plpython trigger functions.
Tom Lane [Tue, 16 Sep 2003 00:50:09 +0000 (00:50 +0000)]
Since SPI_modifytuple's natts argument is the number of attributes to be
changed, it should allow a zero value (implying no changes to make).
Tom Lane [Mon, 15 Sep 2003 23:33:43 +0000 (23:33 +0000)]
Fix LISTEN/NOTIFY race condition reported by Gavin Sherry. While a
really general fix might be difficult, I believe the only case where
AtCommit_Notify could see an uncommitted tuple is where the other guy
has just unlistened and not yet committed. The best solution seems to
be to just skip updating that tuple, on the assumption that the other
guy does not want to hear about the notification anyway. This is not
perfect --- if the other guy rolls back his unlisten instead of committing,
then he really should have gotten this notify. But to do that, we'd have
to wait to see if he commits or not, or make UNLISTEN hold exclusive lock
on pg_listener until commit. Either of these answers is deadlock-prone,
not to mention horrible for interactive performance. Do it this way
for now. (What happened to that project to do LISTEN/NOTIFY in memory
with no table, anyway?)
Tom Lane [Mon, 15 Sep 2003 23:25:31 +0000 (23:25 +0000)]
Update regression test for message change.
Tom Lane [Mon, 15 Sep 2003 22:28:58 +0000 (22:28 +0000)]
Improve a couple of error messages per suggestions from Alvaro Herrera.
Peter Eisentraut [Mon, 15 Sep 2003 20:42:40 +0000 (20:42 +0000)]
Translation updates
Peter Eisentraut [Mon, 15 Sep 2003 20:03:37 +0000 (20:03 +0000)]
OK, some of these syntax errors should be given other codes.
PostgreSQL Daemon [Mon, 15 Sep 2003 14:32:35 +0000 (14:32 +0000)]
tag her for beta3, as announced on Friday ...
Tom Lane [Mon, 15 Sep 2003 03:32:24 +0000 (03:32 +0000)]
Okay, who left off the id= here?
Tom Lane [Mon, 15 Sep 2003 03:21:51 +0000 (03:21 +0000)]
LISTEN doesn't issue a warning for redundant listens anymore. Also,
add some 'See Also' links.
Bruce Momjian [Mon, 15 Sep 2003 02:30:29 +0000 (02:30 +0000)]
Add errno value for thread *_r function call buffer too small. Improve
thread comments.
Bruce Momjian [Mon, 15 Sep 2003 02:17:49 +0000 (02:17 +0000)]
NetBSD needs reentrant funcs.
Peter Eisentraut [Mon, 15 Sep 2003 00:26:31 +0000 (00:26 +0000)]
Remove warnings for operations that have no effect when executed repeatedly.
Peter Eisentraut [Sun, 14 Sep 2003 22:40:38 +0000 (22:40 +0000)]
Run distprep target before creating list of files that contain translatable
strings in the backend, so that .l and .y files are included. To that end,
don't make the .pot file a prerequisite on distprep.
Peter Eisentraut [Sun, 14 Sep 2003 22:37:13 +0000 (22:37 +0000)]
Allow translation of SQL help in psql.
Tom Lane [Sun, 14 Sep 2003 20:21:18 +0000 (20:21 +0000)]
Add missing support for Opteron (__x86_64__).
Tom Lane [Sun, 14 Sep 2003 18:44:23 +0000 (18:44 +0000)]
Persuade tsearch/tsearch2 to work (or at least pass their regression
tests) when using flex 2.5.31. The fix is to *not* try to use palloc
and pfree for allocations within the lexer; when you do that, the
yy_buffer_stack gets freed at inopportune times. The code is already
set up to do manual deallocation, so I see no particular advantage to
using palloc anyway.
Tom Lane [Sun, 14 Sep 2003 17:25:54 +0000 (17:25 +0000)]
Make pltcl create separate function objects when the same function is
used as trigger on different relations. I am not convinced that Tcl
actually has to have this, but it seems a good idea to make it be
parallel to the other PLs that definitely do need it.
Tom Lane [Sun, 14 Sep 2003 17:13:06 +0000 (17:13 +0000)]
Fix plpython to generate separate cached procedure data for each
relation, when the same function is used as a trigger on more than
one relation. This avoids crashes due to differing rowtypes for
different relations. Per bug report from Lance Thomas, 7-Feb-03.
Bruce Momjian [Sun, 14 Sep 2003 13:33:08 +0000 (13:33 +0000)]
Since I haven't gotten a reply, can someone REVERT the lines in
src/Makefile.shlib that adds $(libdir)/$(soname) for
port,eq,unixware to $(soname)?
Larry Rosenman
Tom Lane [Sun, 14 Sep 2003 02:30:07 +0000 (02:30 +0000)]
expected results for dblink test seem to be out of date ...
Tom Lane [Sun, 14 Sep 2003 02:18:49 +0000 (02:18 +0000)]
Make contrib/seg work with flex 2.5.31. Fix it up to have a real
btree operator class, too, since in PG 7.4 you can't GROUP without one.
Tom Lane [Sun, 14 Sep 2003 01:52:25 +0000 (01:52 +0000)]
Make contrib/cube work with flex 2.5.31. Fix it up to have a real
btree operator class, too, since in PG 7.4 you can't GROUP without one.
Tom Lane [Sun, 14 Sep 2003 00:03:32 +0000 (00:03 +0000)]
Reconsider placement of MemoryContextCheck() call --- do after commit,
not before, to avoid duplication of effort.
Tom Lane [Sat, 13 Sep 2003 22:25:38 +0000 (22:25 +0000)]
Avoid corner cases where aset.c would unnecessarily make malloc()
requests of sizes that aren't powers of 2. Per observation from
David Schultz, 28-Aug.
Tom Lane [Sat, 13 Sep 2003 21:44:50 +0000 (21:44 +0000)]
With Joe Conway's concurrence, remove srandom() call from normal_rand().
This was the last piece of code that took it upon itself to reset the
random number sequence --- now we only have srandom() in postmaster start,
backend start, and explicit setseed() operations.
Tom Lane [Sat, 13 Sep 2003 21:12:38 +0000 (21:12 +0000)]
Okay, I've had it with mktime() bugs. While chasing Torello Querci's
recent gripe, I discovered not one but two undocumented, undesirable
behaviors of glibc's mktime. So, stop using it entirely, and always
rely on inversion of localtime() to determine the local time zone.
It's not even very much slower, as it turns out that mktime (at least
in the glibc implementation) also does repeated reverse-conversions.
Tom Lane [Sat, 13 Sep 2003 17:33:46 +0000 (17:33 +0000)]
Minor wording improvements.
Bruce Momjian [Sat, 13 Sep 2003 17:01:09 +0000 (17:01 +0000)]
Rename --without-spinlocks to --disable-spinlocks, per Peter.
Bruce Momjian [Sat, 13 Sep 2003 16:44:49 +0000 (16:44 +0000)]
With pg_autovacuum becoming increasingly popular it's important to
have a working stats collector. This test is able to discover the
problem that was present in 7.4 Beta 2.
Manfred Koizar
Bruce Momjian [Sat, 13 Sep 2003 16:43:38 +0000 (16:43 +0000)]
When I sent in the sslmode patch I forgot to update the
comments/examples in pg_hba.conf. This patch remedies that, adds a brief
explanation of the connection types, and adds a missing period in the
docs.
Jon Jensen
Bruce Momjian [Sat, 13 Sep 2003 16:39:51 +0000 (16:39 +0000)]
autoconf/autoheader run.
Bruce Momjian [Sat, 13 Sep 2003 16:27:38 +0000 (16:27 +0000)]
pgindent C file, per patch request.
Bruce Momjian [Sat, 13 Sep 2003 16:26:18 +0000 (16:26 +0000)]
> OK, well as we wait on the fix for the stats system, let me submit my
> patch for pg_autovacuum. This patch assumes that the stats system will
> be fixed so that all inserts, updates and deletes performed on shared
> tables reguardless of what database those commands were executed from,
> will show up in the stats shown in each database.
I had to make a further change to this to take quotes off the 'last
ANALYZE' in order for it to not overquote the relation name, so
there's a _little_ work left to get it to play well.
I have deployed it onto several boxes that should be doing some
vacuuming over the weekend, and it is now certainly hitting pg_
tables.
I would like to present a CVS-oriented patch; unfortunately, I had to
change the indentation patterns when editing some of it :-(. The
following _may_ be good; not sure...
Matthew T. O'Connor
Christopher Browne
Bruce Momjian [Sat, 13 Sep 2003 14:49:51 +0000 (14:49 +0000)]
Attempt threading in this order:
* use non-*_r function names if they are all thread-safe
* (NEED_REENTRANT_FUNCS=no)
* use *_r functions if they exist (configure test)
* do our own locking and copying of non-threadsafe functions
New to this patch is the last option.
Barry Lind [Sat, 13 Sep 2003 04:02:16 +0000 (04:02 +0000)]
More SQLState updates from Kim Ho at Redhat.
Also a patch from Kris Jurka to correctly report SQLState support.
Modified Files:
jdbc/org/postgresql/Driver.java.in
jdbc/org/postgresql/core/QueryExecutor.java
jdbc/org/postgresql/fastpath/Fastpath.java
jdbc/org/postgresql/geometric/PGbox.java
jdbc/org/postgresql/geometric/PGcircle.java
jdbc/org/postgresql/geometric/PGline.java
jdbc/org/postgresql/geometric/PGlseg.java
jdbc/org/postgresql/geometric/PGpath.java
jdbc/org/postgresql/geometric/PGpoint.java
jdbc/org/postgresql/jdbc1/AbstractJdbc1Connection.java
jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSet.java
jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSetMetaData.java
jdbc/org/postgresql/jdbc1/AbstractJdbc1Statement.java
jdbc/org/postgresql/jdbc2/AbstractJdbc2ResultSet.java
jdbc/org/postgresql/jdbc2/AbstractJdbc2ResultSetMetaData.java
jdbc/org/postgresql/jdbc2/Array.java
jdbc/org/postgresql/jdbc3/AbstractJdbc3DatabaseMetaData.java
jdbc/org/postgresql/util/PGmoney.java
jdbc/org/postgresql/util/PSQLState.java
Tom Lane [Sat, 13 Sep 2003 00:19:43 +0000 (00:19 +0000)]
Marginal hacks to make tables format more nicely.
Tom Lane [Fri, 12 Sep 2003 23:04:46 +0000 (23:04 +0000)]
Mop-up for error-message updates in documentation.
Tom Lane [Fri, 12 Sep 2003 22:17:24 +0000 (22:17 +0000)]
Update obsolete examples of error messages; various other minor editing.
Tom Lane [Fri, 12 Sep 2003 20:18:51 +0000 (20:18 +0000)]
Revert to our pre-7.4 behavior of identifying Unix-socket connections in
ps status as '[local]', not as 'localhost' as the code has been doing
recently. That's too easily confused with TCP loopback connections,
and there is no good reason to change the behavior anyway.
Tom Lane [Fri, 12 Sep 2003 19:33:59 +0000 (19:33 +0000)]
Someone (possibly me) foolishly reduced the response for failing
to create a TCP/IP socket from FATAL to LOG. This was unwise;
historically we have expected socket conflicts to abort postmaster
startup. Conflicts on port numbers with another postmaster can only
be detected reliably at the TCP socket level.
Bruce Momjian [Fri, 12 Sep 2003 16:49:34 +0000 (16:49 +0000)]
Mark FreeBSD as non-thread-safe.
Tom Lane [Fri, 12 Sep 2003 16:34:28 +0000 (16:34 +0000)]
Fix incorrect pfree in to_tsquery_name(), per Nigel Andrews.
Bruce Momjian [Fri, 12 Sep 2003 16:10:27 +0000 (16:10 +0000)]
Implement compiler #error if spinlock code not found, add configure flag
to bypass the error, --without-spinlocks.
Bruce Momjian [Fri, 12 Sep 2003 15:49:34 +0000 (15:49 +0000)]
Enable Opteron/Itanium spinlocks.
Bruce Momjian [Fri, 12 Sep 2003 02:40:10 +0000 (02:40 +0000)]
Remove WIN32_CONSOLE support, at the request of the author.
Bruce Momjian [Fri, 12 Sep 2003 02:13:23 +0000 (02:13 +0000)]
Fix old mention of exec() in AttachSharedMemoryAndSemaphores comment.
Tom Lane [Fri, 12 Sep 2003 00:12:47 +0000 (00:12 +0000)]
More cleanup of Diagnostics sections.
Tom Lane [Thu, 11 Sep 2003 23:15:51 +0000 (23:15 +0000)]
Small typo.
Tom Lane [Thu, 11 Sep 2003 23:12:31 +0000 (23:12 +0000)]
Message in the other exit from acquire_sample_rows(), as per update
from Mark Kirkwood. Also show the sample size.
Tom Lane [Thu, 11 Sep 2003 22:59:28 +0000 (22:59 +0000)]
Try to make recently-added analyze log message look something like
the others in style.
Bruce Momjian [Thu, 11 Sep 2003 21:42:20 +0000 (21:42 +0000)]
This patch fixes a few missed GUC variables that were still upper case,
makes a few more small improvements to runtime.sgml, and makes some SGML
conventions more consistent.
Neil Conway
Bruce Momjian [Thu, 11 Sep 2003 19:01:18 +0000 (19:01 +0000)]
> It quotes table names for vacuum and analyze, and uppercases the
> keywords for clarity.
Yeah, this is basically what I meant, sorry I didn't get to it quicker.
However, I tested it out a little and the patch you made doesn't work
because it produces commands like:
VACUUM ANALYZE "public.FooBar"
Which doesn't work, so I made my own patch that creates commands like:
VACUUM ANALYZE "public"."FooBar"
This allows for mixed case schema names as well as tables.
Adam, can you please give this a test as you are the person who caught
the bug in the first place.
Thanks,
Matthew T. O'Connor
Bruce Momjian [Thu, 11 Sep 2003 18:30:39 +0000 (18:30 +0000)]
Consistenly lowercase GUC variable names, in docs and error messages.
Bruce Momjian [Thu, 11 Sep 2003 17:31:45 +0000 (17:31 +0000)]
This patch makes a few minor improvements to the docs: make the
<varname> conventions more consistent, and improve the ANALYZE ref page.
Neil Conway
Bruce Momjian [Thu, 11 Sep 2003 17:27:38 +0000 (17:27 +0000)]
This patch makes a number of improvements to the runtime config
documentation.
Neil Conway
Bruce Momjian [Thu, 11 Sep 2003 17:26:20 +0000 (17:26 +0000)]
Mention that pg_type_is_visible is used for domains as well.
Christopher Kings-Lynne
Bruce Momjian [Thu, 11 Sep 2003 17:25:14 +0000 (17:25 +0000)]
on my timetravel.c I find a bug: after the
ALTER TABLE mytable drop column last_column_of_table;
the timetravel trigger say on UPDATE/DELETE:
ERROR: parser: parse error at end of input
Here is the patch for this bug
B?jthe Zolt?n
Bruce Momjian [Thu, 11 Sep 2003 17:15:27 +0000 (17:15 +0000)]
Here is a patch that removes contrib/array, leaving only the README with
some examples of the new syntax and a reference to the documentation.
Joe Conway.
Bruce Momjian [Thu, 11 Sep 2003 16:22:42 +0000 (16:22 +0000)]
seemed like a typo in one of the appendix tables
Robert Treat
Tom Lane [Thu, 11 Sep 2003 02:40:13 +0000 (02:40 +0000)]
Fix missed message update, per Alvaro Herrera.
Bruce Momjian [Wed, 10 Sep 2003 21:35:55 +0000 (21:35 +0000)]
Update row count for \? output, used by pager.
Tom Lane [Wed, 10 Sep 2003 20:24:09 +0000 (20:24 +0000)]
Improve error message for cp or rm failur during create/drop database,
per recent discussions.
Bruce Momjian [Wed, 10 Sep 2003 20:17:21 +0000 (20:17 +0000)]
Add:
> * Issue NOTICE if foreign key data type doesn't match primary key
Bruce Momjian [Wed, 10 Sep 2003 20:14:42 +0000 (20:14 +0000)]
Add:
> * Have EXPLAIN ANALYZE highlight poor optimizer estimates
Bruce Momjian [Wed, 10 Sep 2003 20:13:45 +0000 (20:13 +0000)]
This patch fixes a trivial typo in the CREATE FUNCTION ref page.
Neil Conway
Tom Lane [Wed, 10 Sep 2003 20:12:01 +0000 (20:12 +0000)]
copydir() is supposed to return on failure, not elog(ERROR). Reduce
ERROR to WARNING so we keep control.
Bruce Momjian [Wed, 10 Sep 2003 19:59:23 +0000 (19:59 +0000)]
Add HINT if CREATE FUNCTION specifies a valid language, but the language
isn't loaded into the database.
Bruce Momjian [Wed, 10 Sep 2003 19:57:48 +0000 (19:57 +0000)]
Add quotes to vacuum/analyze for upper/lowercase table names, per
Matthew T. O'Connor.
Michael Meskes [Wed, 10 Sep 2003 18:03:08 +0000 (18:03 +0000)]
Some uppercase type definitions were left.
Bruce Momjian [Wed, 10 Sep 2003 03:56:33 +0000 (03:56 +0000)]
Here is a patch to make PostgreSQL use a full path in DT_SONAME for
UnixWare.
Larry Rosenman
Bruce Momjian [Wed, 10 Sep 2003 00:33:51 +0000 (00:33 +0000)]
Clean up printability test in dbase code.
Bruce Momjian [Wed, 10 Sep 2003 00:03:23 +0000 (00:03 +0000)]
Add:
> * Have pg_dump -c clear the database using dependency information
Peter Eisentraut [Tue, 9 Sep 2003 23:22:21 +0000 (23:22 +0000)]
Some "feature not supported" errors are better syntax errors, because the
feature they complain about isn't a feature or cannot be implemented without
definitional changes.
Bruce Momjian [Tue, 9 Sep 2003 22:43:06 +0000 (22:43 +0000)]
Improve wording of increasing page size.
Tom Lane [Tue, 9 Sep 2003 18:28:53 +0000 (18:28 +0000)]
Remove a bunch of content-free Diagnostics sections, as per previous
discussion. (Still have some work to do editing the remainder.)
Bruce Momjian [Tue, 9 Sep 2003 18:25:44 +0000 (18:25 +0000)]
Update max tasble size to 32TB.
Tom Lane [Tue, 9 Sep 2003 15:19:31 +0000 (15:19 +0000)]
Update comments about how locale settings are handled.
Barry Lind [Tue, 9 Sep 2003 11:24:04 +0000 (11:24 +0000)]
Clean up some unused import warnings in the example jdbc code
Michael Meskes [Tue, 9 Sep 2003 10:54:44 +0000 (10:54 +0000)]
Fixed a few bugs that came up on pgsql-interfaces.
Barry Lind [Tue, 9 Sep 2003 10:49:16 +0000 (10:49 +0000)]
Additional SQLState work for JDBC - thanks to Kim Ho at Redhat for input on this
Modified Files:
jdbc/build.xml jdbc/org/postgresql/core/QueryExecutor.java
jdbc/org/postgresql/jdbc1/AbstractJdbc1Connection.java
jdbc/org/postgresql/jdbc1/AbstractJdbc1DatabaseMetaData.java
jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSet.java
jdbc/org/postgresql/jdbc1/AbstractJdbc1Statement.java
jdbc/org/postgresql/jdbc2/AbstractJdbc2Statement.java
jdbc/org/postgresql/util/PSQLState.java
Michael Meskes [Tue, 9 Sep 2003 10:46:42 +0000 (10:46 +0000)]
- Added Dave patch for Informix handling of numeric/int conversion.
- Changed all new datatypes to lowercase.
- Fixed rounding bug in numerical types.
Tom Lane [Mon, 8 Sep 2003 23:17:15 +0000 (23:17 +0000)]
Fix a couple minor typos.
Peter Eisentraut [Mon, 8 Sep 2003 23:02:28 +0000 (23:02 +0000)]
Update preface.
Use question marks rather than brackets to delimit optional elements in
Tcl synopses.
Fix stylesheet misfeature leading to excessively long cross-reference text
when linking to a different "part".
Remove <body> attributes -- CSS stylesheets should handle that.
Improve bibliography formatting.
Add fast-forward links for more convenient navigation.
Bruce Momjian [Mon, 8 Sep 2003 22:48:21 +0000 (22:48 +0000)]
Add:
o Allow ALTER TABLE to change constraint deferrability and actions
Tom Lane [Mon, 8 Sep 2003 22:33:13 +0000 (22:33 +0000)]
"statenebt" ?