]> granicus.if.org Git - postgresql/log
postgresql
17 years agoSilence Solaris compiler warnings, per buildfarm.
Tom Lane [Sun, 15 Jul 2007 22:49:36 +0000 (22:49 +0000)]
Silence Solaris compiler warnings, per buildfarm.

17 years agoSilence Solaris compiler warning, per buildfarm.
Tom Lane [Sun, 15 Jul 2007 22:43:40 +0000 (22:43 +0000)]
Silence Solaris compiler warning, per buildfarm.

17 years agoFix compile warning on Solaris, per buildfarm. (Why have we got
Tom Lane [Sun, 15 Jul 2007 22:40:28 +0000 (22:40 +0000)]
Fix compile warning on Solaris, per buildfarm.  (Why have we got
three slightly different copies of this file?)

17 years agoFix possible portability problem, per buildfarm warnings.
Tom Lane [Sun, 15 Jul 2007 22:34:26 +0000 (22:34 +0000)]
Fix possible portability problem, per buildfarm warnings.

17 years agoFix unportable use of isspace(), per buildfarm results.
Tom Lane [Sun, 15 Jul 2007 22:32:53 +0000 (22:32 +0000)]
Fix unportable use of isspace(), per buildfarm results.

17 years agoBecause plpgsql's scanner uses %option case-insensitive, flex's results could
Tom Lane [Sun, 15 Jul 2007 22:18:24 +0000 (22:18 +0000)]
Because plpgsql's scanner uses %option case-insensitive, flex's results could
theoretically vary depending on what the compile-time locale setting is.
Hence, force it to see LC_CTYPE=C to ensure consistent build results.
(It's likely that this makes no difference in practice, since our
specification for "identifier" surely includes both ends of any possible
uppercase/lowercase pair anyway.  But it should silence warnings about
ambiguous character classes that are reported by some buildfarm members.)

17 years agoReject zero or negative BY step in plpgsql integer FOR-loops, and behave
Tom Lane [Sun, 15 Jul 2007 02:15:04 +0000 (02:15 +0000)]
Reject zero or negative BY step in plpgsql integer FOR-loops, and behave
sanely if the loop value overflows int32 on the way to the end value.
Avoid useless computation of "SELECT 1" when BY is omitted.  Avoid some
type-punning between Datum and int4 that dates from the original coding.

17 years agoNote incompatibility with Oracle's version of FOR ... REVERSE, per
Tom Lane [Sun, 15 Jul 2007 00:45:16 +0000 (00:45 +0000)]
Note incompatibility with Oracle's version of FOR ... REVERSE, per
Andrew Dunstan.  Minor other improvements in documentation of integer
FOR loops.

17 years agoEditorial overhaul of plpgsql documentation. Provide detailed documentation
Tom Lane [Sat, 14 Jul 2007 23:02:25 +0000 (23:02 +0000)]
Editorial overhaul of plpgsql documentation.  Provide detailed documentation
of variable substitution and plan caching behavior in dedicated sections.
(A lot of this material existed already, but was scattered in various places
in the chapter.)  Reorganize material a little bit, mostly to try to avoid
diving into deep details in the first introductory sections.  Document some
fine points that had escaped treatment before, notably the ability to qualify
plpgsql variable names with block labels.  Some minor wordsmithing here and
there.

17 years agoSupport for finding gssapi functions in the library "gss", as required
Magnus Hagander [Sat, 14 Jul 2007 11:13:28 +0000 (11:13 +0000)]
Support for finding gssapi functions in the library "gss", as required
by Solaris 10 and possibly others.

Stefan Kaltenbrunner

17 years agoVolatile-qualify a dozen variables in plpython.c to eliminate warnings
Tom Lane [Fri, 13 Jul 2007 04:57:59 +0000 (04:57 +0000)]
Volatile-qualify a dozen variables in plpython.c to eliminate warnings
from old versions of gcc.  It's not clear to me that this is really
necessary for correctness, but less warnings are always good.
Per buildfarm results and local testing.

17 years agoFix map_sql_typecoll_to_xmlschema_types() to not fail on dropped
Tom Lane [Fri, 13 Jul 2007 03:43:23 +0000 (03:43 +0000)]
Fix map_sql_typecoll_to_xmlschema_types() to not fail on dropped
columns, per my gripe earlier today.  Make it look a bit less like
someone's first effort at backend coding.

17 years agoAdd casts to suppress warnings about m68k-specific kluge in fmgr.c.
Tom Lane [Fri, 13 Jul 2007 02:25:48 +0000 (02:25 +0000)]
Add casts to suppress warnings about m68k-specific kluge in fmgr.c.

17 years agoFix a portability bug (ye olde not casting a <ctype.h> argument to
Tom Lane [Thu, 12 Jul 2007 23:51:10 +0000 (23:51 +0000)]
Fix a portability bug (ye olde not casting a <ctype.h> argument to
unsigned char).  Fortunately we still have buildfarm machines that
will flag this.  Seems to be new in CVS HEAD, so no backpatch.

17 years agoGet dirmod.c on the same page as port.h about whether we use pgsymlink
Tom Lane [Thu, 12 Jul 2007 23:28:49 +0000 (23:28 +0000)]
Get dirmod.c on the same page as port.h about whether we use pgsymlink
on Cygwin (answer: we don't).  Also try to unwind the #ifdef spaghetti
a little bit.  Untested but hopefully I didn't break anything.

17 years agoFixup the indentation of a comment that was mangled by pgindent, and
Neil Conway [Thu, 12 Jul 2007 23:25:26 +0000 (23:25 +0000)]
Fixup the indentation of a comment that was mangled by pgindent, and
add dashes to the start/end of the comment block to try to prevent
this happening in the future.

17 years agoSimplify overly-cute array coding to avoid an apparent gcc bug, which
Tom Lane [Thu, 12 Jul 2007 23:10:57 +0000 (23:10 +0000)]
Simplify overly-cute array coding to avoid an apparent gcc bug, which
may or may not be harmless.  Report from Stefan, patch from Heikki.

17 years agoSuppress Sun Studio warnings, per Stefan.
Tom Lane [Thu, 12 Jul 2007 21:27:09 +0000 (21:27 +0000)]
Suppress Sun Studio warnings, per Stefan.

17 years agoSuppress an integer-overflow warning.
Tom Lane [Thu, 12 Jul 2007 21:17:09 +0000 (21:17 +0000)]
Suppress an integer-overflow warning.

17 years agoSome of our port-specific dynloader implementations are careful to
Tom Lane [Thu, 12 Jul 2007 21:13:27 +0000 (21:13 +0000)]
Some of our port-specific dynloader implementations are careful to
define pg_dlsym() as returning a PGFunction pointer, not just any
pointer-to-function.  But many are not.  Suppress compiler warnings
on platforms that aren't careful by inserting explicit casts at the
two call sites that didn't have a cast already.  Per Stefan.

17 years agoCompute max and min int8 values using unsigned arithmetic, in hopes of
Tom Lane [Thu, 12 Jul 2007 21:04:45 +0000 (21:04 +0000)]
Compute max and min int8 values using unsigned arithmetic, in hopes of
suppressing Sun Studio compiler warnings.  Per Stefan.

17 years agoFix some warnings (probably actual bugs) generated by new GSSAPI code
Tom Lane [Thu, 12 Jul 2007 20:36:11 +0000 (20:36 +0000)]
Fix some warnings (probably actual bugs) generated by new GSSAPI code
when built on a 64-bit machine.  Per buildfarm results extracted by Stefan.

17 years agoFix mistaken Assert in adjust_appendrel_attr_needed, per Greg Stark.
Tom Lane [Thu, 12 Jul 2007 18:27:01 +0000 (18:27 +0000)]
Fix mistaken Assert in adjust_appendrel_attr_needed, per Greg Stark.

17 years agoSilence compile warning on win32, per Stefan and Buildfarm.
Magnus Hagander [Thu, 12 Jul 2007 18:15:52 +0000 (18:15 +0000)]
Silence compile warning on win32, per Stefan and Buildfarm.

17 years agoEnable GSSAPI to build using MSVC. Always build GSSAPI when Kerberos is
Magnus Hagander [Thu, 12 Jul 2007 14:43:21 +0000 (14:43 +0000)]
Enable GSSAPI to build using MSVC. Always build GSSAPI when Kerberos is
enabled, because the only Kerberos library supported always contains it.

17 years agoSupport GSSAPI builds where the header is <gssapi.h> and not <gssapi/gssapi.h>,
Magnus Hagander [Thu, 12 Jul 2007 14:36:52 +0000 (14:36 +0000)]
Support GSSAPI builds where the header is <gssapi.h> and not <gssapi/gssapi.h>,
such as OpenBSD (possibly all Heimdal).

Stefan Kaltenbrunner

17 years agoFix freenig of names in Kerberos when using MIT - need to use the
Magnus Hagander [Thu, 12 Jul 2007 14:10:39 +0000 (14:10 +0000)]
Fix freenig of names in Kerberos when using MIT - need to use the
free function provided in the Kerberos library.
This fixes a very hard to track down heap corruption on windows
when using debug runtimes.

17 years agoSuppress a warning that some versions of gcc emit about %x in strftime.
Tom Lane [Wed, 11 Jul 2007 23:15:38 +0000 (23:15 +0000)]
Suppress a warning that some versions of gcc emit about %x in strftime.
Per suggestion from Alvaro.

17 years agoA bunch of GSSAPI fixes per comments from Tom:
Magnus Hagander [Wed, 11 Jul 2007 08:27:33 +0000 (08:27 +0000)]
A bunch of GSSAPI fixes per comments from Tom:

* use elog not ereport for debug
* fix debug levels for some output
* properly check for memory allocation errors in a couple of missed places

17 years agoAdd note that building from CVS requires bison and flex, whereas
Tom Lane [Tue, 10 Jul 2007 23:03:18 +0000 (23:03 +0000)]
Add note that building from CVS requires bison and flex, whereas
building from a distribution tarball does not.

17 years agoFix misspelling.
Tom Lane [Tue, 10 Jul 2007 16:41:01 +0000 (16:41 +0000)]
Fix misspelling.

17 years agoAdd support for GSSAPI authentication.
Magnus Hagander [Tue, 10 Jul 2007 13:14:22 +0000 (13:14 +0000)]
Add support for GSSAPI authentication.

Documentation still being written, will be committed later.

Henry B. Hotz and Magnus Hagander

17 years agoAdjust processSQLNamePattern() so that $ within the pattern is always matched
Tom Lane [Tue, 10 Jul 2007 00:21:31 +0000 (00:21 +0000)]
Adjust processSQLNamePattern() so that $ within the pattern is always matched
literally, whether quoted or not.  Since we allow $ as a character within
identifiers, this behavior is useful, whereas the previous behavior of
treating it as the regexp ending anchor was nearly useless given that the
pattern is automatically anchored anyway.  This affects the arguments of
psql's \d commands as well as pg_dump's -n and -t switches.  Per discussion.

17 years agoFix stddev_pop(numeric) and var_pop(numeric), which were incorrectly producing
Tom Lane [Mon, 9 Jul 2007 16:13:57 +0000 (16:13 +0000)]
Fix stddev_pop(numeric) and var_pop(numeric), which were incorrectly producing
the same outputs as stddev_samp() and var_samp() respectively.

17 years agoFix single-user mode so that interrupts (particularly SIGTERM and
Tom Lane [Mon, 9 Jul 2007 01:15:14 +0000 (01:15 +0000)]
Fix single-user mode so that interrupts (particularly SIGTERM and
SIGQUIT) will be recognized and processed while waiting for input,
rather than only after something has been typed.  Also make SIGQUIT
do the same thing as SIGTERM in single-user mode, ie, do a normal
shutdown and exit.  Since it's relatively easy to provoke SIGQUIT
from the keyboard, people may try that instead of control-D, and we'd
rather this leads to orderly shutdown.  Per report from Leon Mergen
and subsequent discussion.

17 years agoMinor copy-editing.
Tom Lane [Mon, 9 Jul 2007 01:08:09 +0000 (01:08 +0000)]
Minor copy-editing.

17 years agoRemove the pgstat_drop_relation() call from smgr_internal_unlink(), because
Tom Lane [Sun, 8 Jul 2007 22:23:16 +0000 (22:23 +0000)]
Remove the pgstat_drop_relation() call from smgr_internal_unlink(), because
we don't know at that point which relation OID to tell pgstat to forget.
The code was passing the relfilenode, which is incorrect, and could possibly
cause some other relation's stats to be zeroed out.  While we could try to
clean this up, it seems much simpler and more reliable to let the next
invocation of pgstat_vacuum_tabstat() fix things; which indeed is how it
worked before I introduced the buggy code into 8.1.3 and later :-(.
Problem noticed by Itagaki Takahiro, fix is per subsequent discussion.

17 years agoGet rid of client-code dependencies on the exact text of the no-password
Tom Lane [Sun, 8 Jul 2007 19:07:38 +0000 (19:07 +0000)]
Get rid of client-code dependencies on the exact text of the no-password
error message, by using PQconnectionUsedPassword() instead.  Someday
we might be able to localize that error message, but not until this
coding technique has disappeared everywhere.

17 years agoCloser code review for PQconnectionUsedPassword() patch: in particular,
Tom Lane [Sun, 8 Jul 2007 18:28:56 +0000 (18:28 +0000)]
Closer code review for PQconnectionUsedPassword() patch: in particular,
not OK to include postgres_fe.h into libpq-fe.h, hence declare it as
returning int not bool.

17 years agoFix broken markup.
Tom Lane [Sun, 8 Jul 2007 17:47:38 +0000 (17:47 +0000)]
Fix broken markup.

17 years agoRestrict non-superusers to password authenticated connections
Joe Conway [Sun, 8 Jul 2007 17:12:38 +0000 (17:12 +0000)]
Restrict non-superusers to password authenticated connections
to prevent possible escalation of privilege. Provide new SECURITY
DEFINER functions with old behavior, but initially REVOKE ALL
from public for these functions. Per list discussion and design
proposed by Tom Lane. A different approach will be used for
back-branches, committed separately.

17 years agoArrange for the authentication request type to be preserved in
Joe Conway [Sun, 8 Jul 2007 17:11:51 +0000 (17:11 +0000)]
Arrange for the authentication request type to be preserved in
PGconn. Invent a new libpq connection-status function,
PQconnectionUsedPassword() that returns true if the server
demanded a password during authentication, false otherwise.
This may be useful to clients in general, but is immediately
useful to help plug a privilege escalation path in dblink.
Per list discussion and design proposed by Tom Lane.

17 years agoRemove TODO.detail/win32intr, no longer needed.
Bruce Momjian [Sun, 8 Jul 2007 00:42:07 +0000 (00:42 +0000)]
Remove TODO.detail/win32intr, no longer needed.

17 years agoRemove, per Magnus:
Bruce Momjian [Sun, 8 Jul 2007 00:41:11 +0000 (00:41 +0000)]
Remove, per Magnus:

<  o Check WSACancelBlockingCall() for interrupts [win32intr]

17 years agoFix a couple of planner bugs introduced by the new ability to discard
Tom Lane [Sat, 7 Jul 2007 20:46:45 +0000 (20:46 +0000)]
Fix a couple of planner bugs introduced by the new ability to discard
ORDER BY <constant> as redundant.  One is that this means query_planner()
has to canonicalize pathkeys even when the query jointree is empty;
the canonicalization was always a no-op in such cases before, but no more.
Also, we have to guard against thinking that a set-returning function is
"constant" for this purpose.  Add a couple of regression tests for these
evidently under-tested cases.  Per report from Greg Stark and subsequent
experimentation.

17 years agoMove parse.h into src/backend on msvc, which is where it is on Unix.
Magnus Hagander [Sat, 7 Jul 2007 07:43:21 +0000 (07:43 +0000)]
Move parse.h into src/backend on msvc, which is where it is on Unix.
Fixes builds from tarballs where the file is pre-generated.

Yoshiyuki Asaba

17 years agoChanged new \usleep command into \sleep with an optional time unit
Jan Wieck [Fri, 6 Jul 2007 20:17:02 +0000 (20:17 +0000)]
Changed new \usleep command into \sleep with an optional time unit
argument to specify us, ms or s. As per suggestion by Peter E.

Jan

17 years agoAdded a new scripting meta command
Jan Wieck [Fri, 6 Jul 2007 13:36:55 +0000 (13:36 +0000)]
Added a new scripting meta command

    \usleep [milliseconds|:variable]

which can be used in -f scripts to insert a thinking time between
other commands.

Jan

17 years agoFix up hash functions for datetime datatypes so that they don't take
Tom Lane [Fri, 6 Jul 2007 04:16:00 +0000 (04:16 +0000)]
Fix up hash functions for datetime datatypes so that they don't take
unwarranted liberties with int8 vs float8 values for these types.
Specifically, be sure to apply either hashint8 or hashfloat8 depending
on HAVE_INT64_TIMESTAMP.  Per my gripe of even date.

17 years agoImprove description of SPI_scroll_cursor_move's return values, per a
Tom Lane [Thu, 5 Jul 2007 19:15:12 +0000 (19:15 +0000)]
Improve description of SPI_scroll_cursor_move's return values, per a
gripe by Pavel Stehule awhile ago.

17 years agoFix incorrect comment about the timing of AbsorbFsyncRequests() during
Tom Lane [Tue, 3 Jul 2007 14:51:24 +0000 (14:51 +0000)]
Fix incorrect comment about the timing of AbsorbFsyncRequests() during
checkpoint.  The comment claimed that we could do this anytime after
setting the checkpoint REDO point, but actually BufferSync is relying
on the assumption that buffers dumped by other backends will be fsync'd
too.  So we really could not do it any sooner than we are doing it.

17 years agoAdd ALTER VIEW ... RENAME TO, and a RENAME TO clause to ALTER SEQUENCE.
Neil Conway [Tue, 3 Jul 2007 01:30:37 +0000 (01:30 +0000)]
Add ALTER VIEW ... RENAME TO, and a RENAME TO clause to ALTER SEQUENCE.
Sequences and views could previously be renamed using ALTER TABLE, but
this was a repeated source of confusion for users. Update the docs,
and psql tab completion. Patch from David Fetter; various minor fixes
by myself.

17 years ago- Fix the -w (wait) option to work in Windows service mode, per bug #3382.
Magnus Hagander [Mon, 2 Jul 2007 21:58:31 +0000 (21:58 +0000)]
- Fix the -w (wait) option to work in Windows service mode, per bug #3382.
- Prevent the -w option being passed to the postmaster.
- Read the postmaster options file when starting as a Windows service.

Dave Page

17 years agoFix failure to restart Postgres when Linux kernel returns EIDRM for shmctl().
Tom Lane [Mon, 2 Jul 2007 20:11:55 +0000 (20:11 +0000)]
Fix failure to restart Postgres when Linux kernel returns EIDRM for shmctl().

This is a Linux kernel bug that apparently exists in every extant kernel
version: sometimes shmctl() will fail with EIDRM when EINVAL is correct.
We were assuming that EIDRM indicates a possible conflict with pre-existing
backends, and refusing to start the postmaster when this happens.  Fortunately,
there does not seem to be any case where Linux can legitimately return EIDRM
(it doesn't track shmem segments in a way that would allow that), so we can
get away with just assuming that EIDRM means EINVAL on this platform.

Per reports from Michael Fuhr and Jon Lapham --- it's a bit surprising
we have not seen more reports, actually.

17 years agoAdd notes about configuring Visual Studio Express for use with the
Magnus Hagander [Sun, 1 Jul 2007 18:40:37 +0000 (18:40 +0000)]
Add notes about configuring Visual Studio Express for use with the
Platform SDK.

17 years agoReduce the maximum sleep interval in the autovac launcher to 1 second,
Tom Lane [Sun, 1 Jul 2007 18:30:54 +0000 (18:30 +0000)]
Reduce the maximum sleep interval in the autovac launcher to 1 second,
so that it responds to SIGQUIT reasonably promptly even on machines where
SA_RESTART signals restart a sleep from scratch.  (This whole area could
stand some rethinking, but for now make it work like the other processes
do.)  Also some marginal stylistic cleanups.

17 years agoTreat the autovac launcher more like a regular backend, in that we wait
Tom Lane [Sun, 1 Jul 2007 18:28:41 +0000 (18:28 +0000)]
Treat the autovac launcher more like a regular backend, in that we wait
for it to die before telling the bgwriter to initiate shutdown checkpoint.
Since it's connected to shared memory, this seems more prudent than the
alternative of letting it quit asynchronously.  Resolves my complaint
of yesterday about repeated shutdown checkpoints in CVS HEAD.

17 years agoAvoid memory leakage when a series of subtransactions invoke AFTER triggers
Tom Lane [Sun, 1 Jul 2007 17:45:42 +0000 (17:45 +0000)]
Avoid memory leakage when a series of subtransactions invoke AFTER triggers
that are fired at end-of-statement (as is the normal case for foreign keys,
for example).  In this situation the per-subxact deferred trigger context
is always empty when subtransaction exit is reached; so we could free it,
but were not doing so, leading to an intratransaction leak of 8K or more
per subtransaction.  Per off-list example from Viatcheslav Kalinin
subsequent to bug #3418 (his original bug report omitted a foreign key
constraint needed to cause this leak).

Back-patch to 8.2; prior versions were not using per-subxact contexts
for deferred triggers, so did not have this leak.

17 years agoFix comments not updated in recent patch.
Tom Lane [Sun, 1 Jul 2007 02:22:23 +0000 (02:22 +0000)]
Fix comments not updated in recent patch.

17 years agoAdd 'volatile' to suppress 'variable might be clobbered by longjmp'
Tom Lane [Sun, 1 Jul 2007 02:20:59 +0000 (02:20 +0000)]
Add 'volatile' to suppress 'variable might be clobbered by longjmp'
warning emitted by some versions of gcc.

17 years agoImprove logging of checkpoints. Patch by Greg Smith, worked over
Tom Lane [Sat, 30 Jun 2007 19:12:02 +0000 (19:12 +0000)]
Improve logging of checkpoints.  Patch by Greg Smith, worked over
by Heikki and a little bit by me.

17 years agoAvoid crash in interrupted autovacuum worker, caused by leaving the current
Alvaro Herrera [Sat, 30 Jun 2007 04:08:05 +0000 (04:08 +0000)]
Avoid crash in interrupted autovacuum worker, caused by leaving the current
memory context pointing at a context not long lived enough.

Also, create a fake PortalContext where to store the vac_context, if only
to avoid having it be a top-level memory context.

17 years agoArrange for SIGINT in autovacuum workers to cancel the current table and
Alvaro Herrera [Fri, 29 Jun 2007 17:07:39 +0000 (17:07 +0000)]
Arrange for SIGINT in autovacuum workers to cancel the current table and
continue with the schedule.  Change current uses of SIGINT to abort a worker
into SIGTERM, which keeps the old behaviour of terminating the process.

Patch from ITAGAKI Takahiro, with some editorializing of my own.

17 years agoFix computation of PG_VERSION_NUM by configure: remove unnecessary and
Tom Lane [Fri, 29 Jun 2007 16:18:43 +0000 (16:18 +0000)]
Fix computation of PG_VERSION_NUM by configure: remove unnecessary and
unportable backslashes in awk script (per Patrick Welche), and add
brackets to prevent autoconf from mangling sed's regexp (the sed call
here never did what was expected).

17 years agoAdd a note that pg_start_backup will take awhile because of new
Tom Lane [Fri, 29 Jun 2007 15:46:21 +0000 (15:46 +0000)]
Add a note that pg_start_backup will take awhile because of new
distributed checkpoint behavior.  Explain how to work around this
by issuing a manual CHECKPOINT command.  Per discussion with Heikki.

17 years agoFix a passel of ancient bugs in to_char(), including two distinct buffer
Tom Lane [Fri, 29 Jun 2007 01:51:35 +0000 (01:51 +0000)]
Fix a passel of ancient bugs in to_char(), including two distinct buffer
overruns (neither of which seem likely to be exploitable as security holes,
fortunately, since the provoker can't control the data written).  One of
these is due to choosing to stomp on the output of a called function, which
is bad news in any case; make it treat the called functions' results as
read-only.  Avoid some unnecessary palloc/pfree traffic too; it's not
really helpful to free small temporary objects, and again this is presuming
more than it ought to about the nature of the results of called functions.
Per report from Patrick Welche and additional code-reading by Imad.

17 years agoDone:
Bruce Momjian [Thu, 28 Jun 2007 21:55:00 +0000 (21:55 +0000)]
Done:

> * -Reduce checkpoint performance degredation by forcing data to disk

17 years agoFix incorrect tests for undef Perl values in some places in plperl.c.
Tom Lane [Thu, 28 Jun 2007 17:49:59 +0000 (17:49 +0000)]
Fix incorrect tests for undef Perl values in some places in plperl.c.
The correct test for defined-ness is SvOK(sv), not anything involving
SvTYPE.  Per bug #3415 from Matt Taylor.
Back-patch as far as 8.0; no apparent problem in 7.x.

17 years agoAdd the function's volatility to the output of psql's \df+ command.
Neil Conway [Thu, 28 Jun 2007 06:40:16 +0000 (06:40 +0000)]
Add the function's volatility to the output of psql's \df+ command.
Update the psql reference page accordingly.

17 years agoImplement "distributed" checkpoints in which the checkpoint I/O is spread
Tom Lane [Thu, 28 Jun 2007 00:02:40 +0000 (00:02 +0000)]
Implement "distributed" checkpoints in which the checkpoint I/O is spread
over a fairly long period of time, rather than being spat out in a burst.
This happens only for background checkpoints carried out by the bgwriter;
other cases, such as a shutdown checkpoint, are still done at full speed.

Remove the "all buffers" scan in the bgwriter, and associated stats
infrastructure, since this seems no longer very useful when the checkpoint
itself is properly throttled.

Original patch by Itagaki Takahiro, reworked by Heikki Linnakangas,
and some minor API editorialization by me.

17 years agoFix PGXS conventions so that extensions can be built against Postgres
Tom Lane [Tue, 26 Jun 2007 22:05:04 +0000 (22:05 +0000)]
Fix PGXS conventions so that extensions can be built against Postgres
installations whose pg_config program does not appear first in the PATH.
Per gripe from Eddie Stanley and subsequent discussions with Fabien Coelho
and others.

17 years agoRemove unused "caller" argument from stringToQualifiedNameList.
Alvaro Herrera [Tue, 26 Jun 2007 16:48:09 +0000 (16:48 +0000)]
Remove unused "caller" argument from stringToQualifiedNameList.

17 years agoAdd extra checks for buildfarm to pick up errors when running
Magnus Hagander [Tue, 26 Jun 2007 11:43:56 +0000 (11:43 +0000)]
Add extra checks for buildfarm to pick up errors when running
on XP or earlier versions of Windows.

Andrew Dunstan

17 years agoRemove unused BAD_LOCATION definition.
Alvaro Herrera [Mon, 25 Jun 2007 17:12:07 +0000 (17:12 +0000)]
Remove unused BAD_LOCATION definition.

17 years agoImprove autovacuum launcher's ability to detect a problem in worker startup,
Alvaro Herrera [Mon, 25 Jun 2007 16:09:03 +0000 (16:09 +0000)]
Improve autovacuum launcher's ability to detect a problem in worker startup,
by having the postmaster signal it when certain failures occur.  This requires
the postmaster setting a flag in shared memory, but should be as safe as the
pmsignal.c code is.

Also make sure the launcher honor's a postgresql.conf change turning it off
on SIGHUP.

17 years agoSeparate parse-analysis for utility commands out of parser/analyze.c
Tom Lane [Sat, 23 Jun 2007 22:12:52 +0000 (22:12 +0000)]
Separate parse-analysis for utility commands out of parser/analyze.c
(which now deals only in optimizable statements), and put that code
into a new file parser/parse_utilcmd.c.  This helps clarify and enforce
the design rule that utility statements shouldn't be processed during
the regular parse analysis phase; all interpretation of their meaning
should happen after they are given to ProcessUtility to execute.
(We need this because we don't retain any locks for a utility statement
that's in a plan cache, nor have any way to detect that it's stale.)

We are also able to simplify the API for parse_analyze() and related
routines, because they will now always return exactly one Query structure.

In passing, fix bug #3403 concerning trying to add a serial column to
an existing temp table (this is largely Heikki's work, but we needed
all that restructuring to make it safe).

17 years agoAdd a <tip> that log_line_prefix should usually end with a space to
Tom Lane [Fri, 22 Jun 2007 16:15:23 +0000 (16:15 +0000)]
Add a <tip> that log_line_prefix should usually end with a space to
provide visual separation from the rest of the log line; I've been
noticing lately that quite a few newbies fail to figure this out for
themselves.  Also a little editorial cleanup of the log_line_prefix
description.

17 years agoIn psql, when running a SELECT query using a cursor, flush the query
Neil Conway [Fri, 22 Jun 2007 01:09:28 +0000 (01:09 +0000)]
In psql, when running a SELECT query using a cursor, flush the query
output after each FETCH. This ensures that incremental results are
available to clients that are executing long-running SELECT queries
via the FETCH_COUNT feature.

17 years agoAllow trailing whitespace in parse_real(), for consistency with
Tom Lane [Thu, 21 Jun 2007 22:59:12 +0000 (22:59 +0000)]
Allow trailing whitespace in parse_real(), for consistency with
parse_int() and with itself (strtod allows leading whitespace, so it
seems odd not to allow trailing whitespace).  parse_bool remains
not-whitespace-friendly, but this is generically true for non-numeric
GUC variables, so I'll desist from changing it.

17 years agoProvide a HINT listing the allowed unit names when a GUC variable seems to
Tom Lane [Thu, 21 Jun 2007 18:14:21 +0000 (18:14 +0000)]
Provide a HINT listing the allowed unit names when a GUC variable seems to
contain a wrong unit specification, per discussion.
In passing, fix the code to avoid unnecessary integer overflows when
converting units, and to detect overflows when they do occur.

17 years agoUpdate password example.
Peter Eisentraut [Thu, 21 Jun 2007 12:20:10 +0000 (12:20 +0000)]
Update password example.

17 years agoUpdate examples of create/drop scripts.
Peter Eisentraut [Thu, 21 Jun 2007 10:43:09 +0000 (10:43 +0000)]
Update examples of create/drop scripts.

17 years agoAdd a caveat pointing out that constraint exclusion doesn't work with
Tom Lane [Wed, 20 Jun 2007 23:11:38 +0000 (23:11 +0000)]
Add a caveat pointing out that constraint exclusion doesn't work with
constraints the planner is unable to disprove, hence simple btree-compatible
conditions should be used.  We've seen people try to get cute with stuff
like date_part(something) = something at least twice now.  Even if we
wanted to try to teach predtest.c about the properties of date_part,
most of the useful variants aren't immutable so nothing could be proved.

17 years agoRemove some empty columns from a few system catalog tables in the
Neil Conway [Wed, 20 Jun 2007 19:24:05 +0000 (19:24 +0000)]
Remove some empty columns from a few system catalog tables in the
SGML docs.

17 years agoRestrict deadlock_timeout to the range for which the implementation
Tom Lane [Wed, 20 Jun 2007 18:31:39 +0000 (18:31 +0000)]
Restrict deadlock_timeout to the range for which the implementation
actually works sanely, viz not 0 and not more than INT_MAX/1000
(else TimestampTzPlusMilliseconds can overflow).  Per discussion with
Greg Stark.  Since this is a superuser-only setting and there was not
previously any big reason to change it, not worth back-patching.

17 years agotransformColumnDefinition failed to complain about
Tom Lane [Wed, 20 Jun 2007 18:21:00 +0000 (18:21 +0000)]
transformColumnDefinition failed to complain about
create table foo (bar int default null default 3);
due to not thinking about the special-case handling of DEFAULT NULL.
Problem noticed while investigating bug #3396.

17 years agoCREATE DOMAIN ... DEFAULT NULL failed because gram.y special-cases DEFAULT
Tom Lane [Wed, 20 Jun 2007 18:15:49 +0000 (18:15 +0000)]
CREATE DOMAIN ... DEFAULT NULL failed because gram.y special-cases DEFAULT
NULL and DefineDomain didn't.  Bug goes all the way back to original coding
of domains.  Per bug #3396 from Sergey Burladyan.

17 years agoQuiet warnings about redefined PGPORT macros for MSVC.
Andrew Dunstan [Wed, 20 Jun 2007 17:19:00 +0000 (17:19 +0000)]
Quiet warnings about redefined PGPORT macros for MSVC.

17 years agoMinor code cleanup: calling FreeFile() before ereport(ERROR) is not
Neil Conway [Wed, 20 Jun 2007 02:02:49 +0000 (02:02 +0000)]
Minor code cleanup: calling FreeFile() before ereport(ERROR) is not
necessary, since files opened via AllocateFile() are closed automatically
as part of error recovery.

17 years agoOnly log 'process acquired lock' if we actually did get the lock. This
Tom Lane [Tue, 19 Jun 2007 22:01:15 +0000 (22:01 +0000)]
Only log 'process acquired lock' if we actually did get the lock.  This
test seems inessential right now since the only control path for not
getting the lock is via CHECK_FOR_INTERRUPTS which won't return control
to ProcSleep, but it would be important if we ever allow the deadlock
code to kill someone else's transaction instead of our own.

17 years agoRemove duplicate #include.
Neil Conway [Tue, 19 Jun 2007 21:24:48 +0000 (21:24 +0000)]
Remove duplicate #include.

17 years agoCode review for log_lock_waits patch. Don't try to issue log messages from
Tom Lane [Tue, 19 Jun 2007 20:13:22 +0000 (20:13 +0000)]
Code review for log_lock_waits patch.  Don't try to issue log messages from
within a signal handler (this might be safe given the relatively narrow code
range in which the interrupt is enabled, but it seems awfully risky); do issue
more informative log messages that tell what is being waited for and the exact
length of the wait; minor other code cleanup.  Greg Stark and Tom Lane

17 years agoArrange for quote_identifier() and pg_dump to not quote keywords that are
Tom Lane [Mon, 18 Jun 2007 21:40:58 +0000 (21:40 +0000)]
Arrange for quote_identifier() and pg_dump to not quote keywords that are
unreserved according to the grammar.  The list of unreserved words has gotten
extensive enough that the unnecessary quoting is becoming a bit of an eyesore.
To do this, add knowledge of the keyword category to keywords.c's table.
(Someday we might be able to generate keywords.c's table and the keyword lists
in gram.y from a common source.)  For the moment, lie about WITH's status in
the table so it will still get quoted --- this is because of the expectation
that WITH will become reserved when the SQL recursive-queries patch gets done.

I didn't force initdb because this affects nothing on-disk; but note that a
few regression tests have changed expected output.

17 years agoRemove comment about modifying tab-complete.c for userset GUC.
Magnus Hagander [Mon, 18 Jun 2007 10:02:57 +0000 (10:02 +0000)]
Remove comment about modifying tab-complete.c for userset GUC.

Simon Riggs

17 years agoUpdate obsolete comment: it's no longer the case that mdread() will allow
Tom Lane [Mon, 18 Jun 2007 00:47:20 +0000 (00:47 +0000)]
Update obsolete comment: it's no longer the case that mdread() will allow
reads beyond EOF, except by special coercion.

17 years agoMarginal hacking to improve the speed of COPY OUT. I had found in a bit of
Tom Lane [Sun, 17 Jun 2007 23:39:28 +0000 (23:39 +0000)]
Marginal hacking to improve the speed of COPY OUT.  I had found in a bit of
profiling that CopyAttributeOutText was taking an unreasonable fraction of
the backend run time (like 66%!) on the following trivial test case:

$ time psql -c "copy (select repeat('xyzzy',50) from generate_series(1,10000000)) to stdout" regression >/dev/null

The time is all being spent on scanning the string for characters to be
escaped, which most of the time there aren't any of.  Some tweaking to take
as many tests as possible out of the inner loop reduced the runtime of this
example by more than 10%.  In a real-world case it wouldn't be as useful
a speedup, but it still seems worth adding a few lines here.

17 years agoRevert an ill-considered portion of my patch of 12-Mar, which tried to save a
Tom Lane [Sun, 17 Jun 2007 18:57:29 +0000 (18:57 +0000)]
Revert an ill-considered portion of my patch of 12-Mar, which tried to save a
few lines in sql_exec_error_callback() by using the function source string
field that the patch added to SQL function cache entries.  This doesn't work
because the fn_extra field isn't filled in yet during init_sql_fcache().
Probably it could be made to work, but it doesn't seem appropriate to contort
the main code paths to make an error-reporting path a tad faster.  Per report
from Pavel Stehule.

17 years agoTweak the API for per-datatype typmodin functions so that they are passed
Tom Lane [Fri, 15 Jun 2007 20:56:52 +0000 (20:56 +0000)]
Tweak the API for per-datatype typmodin functions so that they are passed
an array of strings rather than an array of integers, and allow any simple
constant or identifier to be used in typmods; for example
create table foo (f1 widget(42,'23skidoo',point));
Of course the typmodin function has still got to pack this info into a
non-negative int32 for storage, but it's still a useful improvement in
flexibility, especially considering that you can do nearly anything if you
are willing to keep the info in a side table.  We can get away with this
change since we have not yet released a version providing user-definable
typmods.  Per discussion.

17 years agoApplied patch by Joachim to enable checktcp again
Michael Meskes [Fri, 15 Jun 2007 08:23:52 +0000 (08:23 +0000)]
Applied patch by Joachim to enable checktcp again

17 years agoAvoid having autovacuum run multiple ANALYZE commands in a single transaction,
Alvaro Herrera [Thu, 14 Jun 2007 13:53:14 +0000 (13:53 +0000)]
Avoid having autovacuum run multiple ANALYZE commands in a single transaction,
to prevent possible deadlock problems.  Per request from Tom Lane.