]>
granicus.if.org Git - neomutt/log
Richard Russon [Sat, 23 Mar 2019 01:00:13 +0000 (01:00 +0000)]
build: fix a bunch of idn2-related problems
- hide code if IDN is disabled
- fix build tests
- add travis dependency
Richard Russon [Sat, 27 Apr 2019 21:49:49 +0000 (22:49 +0100)]
merge: add basic address tests
* test: templates for address functions
* test: add address tests for degenerate cases
* libaddress: fix address code for degenerate cases
* test: templates for group functions
* test: add group tests for degenerate cases
* libaddress: fix group code for degenerate cases
* test: templates for idna functions
* test: add idna tests for degenerate cases
Richard Russon [Sat, 27 Apr 2019 21:26:07 +0000 (22:26 +0100)]
test: add idna tests for degenerate cases
Richard Russon [Sat, 27 Apr 2019 21:08:05 +0000 (22:08 +0100)]
test: templates for idna functions
Richard Russon [Sat, 27 Apr 2019 20:26:38 +0000 (21:26 +0100)]
libaddress: fix group code for degenerate cases
Richard Russon [Sat, 27 Apr 2019 20:26:07 +0000 (21:26 +0100)]
test: add group tests for degenerate cases
Richard Russon [Sat, 27 Apr 2019 17:36:27 +0000 (18:36 +0100)]
test: templates for group functions
Richard Russon [Sat, 27 Apr 2019 16:54:12 +0000 (17:54 +0100)]
libaddress: fix address code for degenerate cases
Richard Russon [Sat, 27 Apr 2019 16:53:29 +0000 (17:53 +0100)]
test: add address tests for degenerate cases
Richard Russon [Sat, 27 Apr 2019 15:53:33 +0000 (16:53 +0100)]
test: templates for address functions
Naveen Nathan [Thu, 25 Apr 2019 13:38:25 +0000 (23:38 +1000)]
keybindings: restore nntp change-newsgroup keybindings
This restores a subset of the keybindings found in the original vvv.nntp
patch that don't clash with any of neomutt defaults.
Specifically:
i to change-newsgroup
ESC-i to change-newsgroup-readonly
Kevin McCarthy [Wed, 24 Apr 2019 02:06:11 +0000 (19:06 -0700)]
Add RECURSIVEMATCH LIST-EXTENDED selection option to query
LSUB is required to include mailboxes with subscribed children, but
the just added "LIST (SUBSCRIBED)" by default does not do that.
To match previous behavior, add RECURSIVEMATCH to make sure the
children are included. Fix the parser to trim off the CHILDINFO
suffix in the response.
Parse \NonExistent LIST attribute the same as \NoSelect.
Co-authored-by: Richard Russon <rich@flatcap.org>
Naveen Nathan [Tue, 23 Apr 2019 17:04:05 +0000 (03:04 +1000)]
Improve hierarchy information accuracy in IMAP browser
Currently the IMAP browser relies on LIST and LSUB (for listing subscribed
folders) which may not provide the required hierarchy information.
RFC3348 section 3 goes as far as stating that a client mustn't rely on LSUB
for hierarchy information.
This patch implements the LIST command extensions specified in RFC5258
requiring that a server must respond with hierarchy information for
listed folders (whether or not filtering on subscribed folders).
Richard Russon [Thu, 25 Apr 2019 09:40:02 +0000 (10:40 +0100)]
merge: add string tests
* test,tidy: mutt_str_sysexit()
* test,tidy: mutt_str_atos()
* test,tidy: mutt_str_atoi()
* test,tidy: mutt_str_atol()
* test,tidy: mutt_str_atoui()
* test,tidy: mutt_str_atoul()
* test,tidy: mutt_str_atoull()
Richard Russon [Tue, 23 Apr 2019 00:45:38 +0000 (01:45 +0100)]
tidy: mutt_str_atoull()
Richard Russon [Wed, 24 Apr 2019 19:42:17 +0000 (20:42 +0100)]
test: mutt_str_atoull()
Richard Russon [Wed, 24 Apr 2019 18:22:01 +0000 (19:22 +0100)]
tidy: mutt_str_atoul()
Richard Russon [Wed, 24 Apr 2019 18:37:23 +0000 (19:37 +0100)]
test: mutt_str_atoul()
Richard Russon [Wed, 24 Apr 2019 18:20:41 +0000 (19:20 +0100)]
tidy: mutt_str_atoui()
Richard Russon [Wed, 24 Apr 2019 14:56:48 +0000 (15:56 +0100)]
test: mutt_str_atoui()
Richard Russon [Wed, 24 Apr 2019 15:23:34 +0000 (16:23 +0100)]
tidy: mutt_str_atol()
Richard Russon [Wed, 24 Apr 2019 14:26:04 +0000 (15:26 +0100)]
test: mutt_str_atol()
Richard Russon [Mon, 22 Apr 2019 23:55:05 +0000 (00:55 +0100)]
tidy: mutt_str_atoi()
Richard Russon [Tue, 23 Apr 2019 01:26:55 +0000 (02:26 +0100)]
test: mutt_str_atoi()
Richard Russon [Mon, 22 Apr 2019 23:05:49 +0000 (00:05 +0100)]
tidy: mutt_str_atos()
Richard Russon [Mon, 22 Apr 2019 23:05:39 +0000 (00:05 +0100)]
test: mutt_str_atos()
Richard Russon [Mon, 22 Apr 2019 23:36:58 +0000 (00:36 +0100)]
tidy: mutt_str_sysexit()
Richard Russon [Mon, 22 Apr 2019 23:32:24 +0000 (00:32 +0100)]
test: mutt_str_sysexit()
Mehdi Abaakouk [Wed, 24 Apr 2019 14:34:35 +0000 (16:34 +0200)]
imap: fixing race when syncing mailbox
imap_check_mailbox return an detailled state not only 0/-1.
imap_sync_mailbox assumes that the function was returning only 0/-1.
This change fixes that.
Naveen Nathan [Wed, 24 Apr 2019 02:28:44 +0000 (12:28 +1000)]
browser: show "Subscribed" in IMAP browser
Richard Russon [Wed, 24 Apr 2019 12:14:59 +0000 (13:14 +0100)]
merge: light tidying
* clang-format
* refactor mutt_str_append_item()
* boolify retval of mutt_path_to_absolute()
* boolify mutt_date_make_time()
* boolify pattern functions
* boolify patmatch()
* flags: clear up HookFlags usage
* pattern: create typedef for parse functions
* tidy: add {}s
Richard Russon [Mon, 22 Apr 2019 17:21:18 +0000 (18:21 +0100)]
tidy: add {}s
Richard Russon [Mon, 22 Apr 2019 00:18:15 +0000 (01:18 +0100)]
pattern: create typedef for parse functions
Richard Russon [Sun, 21 Apr 2019 23:40:14 +0000 (00:40 +0100)]
flags: clear up HookFlags usage
Richard Russon [Sun, 21 Apr 2019 21:08:15 +0000 (22:08 +0100)]
boolify patmatch()
Richard Russon [Sun, 21 Apr 2019 21:08:05 +0000 (22:08 +0100)]
boolify pattern functions
Richard Russon [Sun, 21 Apr 2019 18:15:44 +0000 (19:15 +0100)]
boolify mutt_date_make_time()
Richard Russon [Sat, 20 Apr 2019 01:34:13 +0000 (02:34 +0100)]
boolify retval of mutt_path_to_absolute()
Richard Russon [Sat, 20 Apr 2019 01:43:54 +0000 (02:43 +0100)]
refactor mutt_str_append_item()
Richard Russon [Sun, 21 Apr 2019 23:17:00 +0000 (00:17 +0100)]
clang-format
Richard Russon [Wed, 24 Apr 2019 11:23:03 +0000 (12:23 +0100)]
merge: upstream add index-format-hook
* Add index-format-hook and expando
* Add a flag for dynamic date range evaluation in patterns
* Update the neomuttrc man page with added commands
Kevin McCarthy [Sat, 19 Jan 2019 04:46:07 +0000 (20:46 -0800)]
Update the neomuttrc man page with added commands
Add the "color compose", index-format-hook, and echo commands.
Add the HMS relative date units.
Co-authored-by: Richard Russon <rich@flatcap.org>
Kevin McCarthy [Tue, 30 Oct 2018 18:53:37 +0000 (11:53 -0700)]
Add a flag for dynamic date range evaluation in patterns
By default, Mutt evaluates relative date patterns, such as "~d<1d"
against the date when the pattern is compiled.
For index-format-hook, we need to pattern match against a message
based on the current date/time, so that for example, conditional date
format patterns correctly match after Mutt has been open for many
days/weeks.
Add a flag, MUTT_PATTERN_DYNAMIC, that changes ~d and ~r evaluation to
reevaluate the min/max range with each match.
This will of course be slower, but for the index, where a screenful of
messages at a time are evaluated, is an acceptable tradeoff against
accurate pattern matching.
Co-authored-by: Richard Russon <rich@flatcap.org>
Kevin McCarthy [Mon, 29 Oct 2018 20:45:02 +0000 (13:45 -0700)]
Add index-format-hook and expando
index-format-hook is used to allow dynamic insertion/evaluation of
format strings into $index_format.
It can be used, for example, to implement date formatting based on the
age of the message.
Add a new %@name@ expando to $index_format, which evaluates the
matching index-format-hooks with "name".
Co-authored-by: Richard Russon <rich@flatcap.org>
Richard Russon [Wed, 24 Apr 2019 11:19:00 +0000 (12:19 +0100)]
merge: improve test coverage
* tests: add copyright blocks
* coverage: show stats
* test: templates for path functions
* test: add path tests for degenerate cases
* libmutt: fix path code for degenerate cases
* test: merge existing path tests
* config: don't exclude testable cases
* test: add coverage of config dump functions
* test: 100% config coverage
Richard Russon [Wed, 17 Apr 2019 02:21:16 +0000 (03:21 +0100)]
test: 100% config coverage
Richard Russon [Fri, 19 Apr 2019 16:49:29 +0000 (17:49 +0100)]
test: add coverage of config dump functions
Richard Russon [Fri, 19 Apr 2019 14:11:59 +0000 (15:11 +0100)]
config: don't exclude testable cases
Richard Russon [Fri, 19 Apr 2019 08:31:42 +0000 (09:31 +0100)]
test: merge existing path tests
Richard Russon [Fri, 19 Apr 2019 13:59:45 +0000 (14:59 +0100)]
libmutt: fix path code for degenerate cases
Richard Russon [Fri, 19 Apr 2019 00:07:37 +0000 (01:07 +0100)]
test: add path tests for degenerate cases
Richard Russon [Thu, 18 Apr 2019 22:26:39 +0000 (23:26 +0100)]
test: templates for path functions
Richard Russon [Thu, 18 Apr 2019 12:15:34 +0000 (13:15 +0100)]
coverage: show stats
Richard Russon [Wed, 17 Apr 2019 11:40:40 +0000 (12:40 +0100)]
tests: add copyright blocks
Richard Russon [Tue, 23 Apr 2019 12:42:45 +0000 (13:42 +0100)]
docs: add note about line continuation
Closes: #1668
[ci skip]
Pietro Cerutti [Tue, 23 Apr 2019 11:08:30 +0000 (11:08 +0000)]
Fix uninitialized variable
Reported on https://mailman.neomutt.org/pipermail/neomutt-devel-neomutt.org/2019-April/000654.html
Mehdi Abaakouk [Sun, 21 Apr 2019 14:50:00 +0000 (16:50 +0200)]
imap: fix auth login
The auth_login returns an error when it succesfully logins.
This was introduced by
04892a48ea76b37f6aa9b369b5bc4f5cc362878c
This change fixes that.
Mehdi Abaakouk [Sun, 21 Apr 2019 13:43:03 +0000 (15:43 +0200)]
imap: fix oauth
Currently when oauth success, we got this and neomutt UI got stuck:
[2019-04-21 15:35:38]<5> mutt_socket_readln_d() 5< a0001 OK xxxxxxxxxxxxx@xxxxxxxxx authenticated (Success)
[2019-04-21 15:35:38]<2> mutt_socket_write_d() 5> [2019-04-21 15:35:38]<2> imap_login() Communication encrypted at 256 bits
[2019-04-21 15:35:38]<3> imap_mdata_new() hcache uidvalidity 1, uidnext 228, modseq 0
[2019-04-21 15:35:38]<M> mx_mbox_open() Reading imaps://imap.gmail.com/INBOX...
[2019-04-21 15:35:38]<M> imap_mbox_open() Selecting INBOX...
[2019-04-21 15:35:38]<2> mutt_socket_write_d() 5> a0002 SELECT "INBOX"
[2019-04-21 15:35:38]<5> mutt_socket_readln_d() 5< * BAD [CLIENTBUG] Invalid tag
In fact neomutt send ^A to the server, but this should occurs only if
the authentication fails.
This changes fixes that.
Pietro Cerutti [Fri, 19 Apr 2019 08:33:23 +0000 (08:33 +0000)]
Demote more 'first' and 'last' errors to messages
This should finish the job done in 8e8344.
Fixes #1311
Richard Russon [Wed, 17 Apr 2019 22:40:13 +0000 (23:40 +0100)]
update credits
Richard Russon [Tue, 16 Apr 2019 23:05:47 +0000 (00:05 +0100)]
fix release build
Pietro Cerutti [Wed, 17 Apr 2019 12:03:22 +0000 (12:03 +0000)]
Fix capitalization (now consistent with the respective code in pager.c)
Pietro Cerutti [Wed, 17 Apr 2019 09:40:45 +0000 (09:40 +0000)]
Support group-chat-reply in the index
Fixes #1654
Pietro Cerutti [Wed, 17 Apr 2019 09:29:31 +0000 (09:29 +0000)]
Make buffer pool initialization lazy
This fixes an issue in the startup sequence where a buffer is requested
from the buffer pool before mutt_buffer_pool_init is called. The latter
doubles up the number of buffers even though there are free ones.
Richard Russon [Tue, 16 Apr 2019 17:07:32 +0000 (18:07 +0100)]
tidy: config variables and comments
Rename global variables to match their config:
- `C_ImapCondStore` -> `C_ImapCondstore`
- `C_ImapOauthRefreshCmd` -> `C_ImapOauthRefreshCommand`
- `C_ImapQResync` -> `C_ImapQresync`
- `C_PopOauthRefreshCmd` -> `C_PopOauthRefreshCommand`
- `C_SidebarNonEmptyOnly` -> `C_SidebarNonEmptyMailboxOnly`
- `C_SmtpOauthRefreshCmd` -> `C_SmtpOauthRefreshCommand`
Richard Russon [Tue, 16 Apr 2019 14:34:33 +0000 (15:34 +0100)]
split Address into a separate library
Closes: #1619
Pietro Cerutti [Tue, 16 Apr 2019 13:00:27 +0000 (13:00 +0000)]
Make buffer pool parameters (compile-time) configurable
Richard Russon [Tue, 16 Apr 2019 12:48:13 +0000 (13:48 +0100)]
remove unnecesary test in mutt_str_asprintf()
Temporarily remove a valid test condition to match.
Richard Russon [Tue, 16 Apr 2019 11:52:02 +0000 (12:52 +0100)]
merge: promote two functions to libmutt
* libmutt: promote getcwd to the library
* libmutt: promote mutt_buffer_concat_path to the library
* add basic tests
Richard Russon [Tue, 16 Apr 2019 11:29:42 +0000 (12:29 +0100)]
add basic tests
Richard Russon [Thu, 11 Apr 2019 01:59:24 +0000 (02:59 +0100)]
libmutt: promote mutt_buffer_concat_path to the library
Richard Russon [Thu, 11 Apr 2019 01:52:59 +0000 (02:52 +0100)]
libmutt: promote getcwd to the library
Richard Russon [Sun, 14 Apr 2019 14:30:23 +0000 (15:30 +0100)]
fix Mailbox->append,changed flags
Replying to an email caused some unwanted side-effects:
- Updating the Context left `m->changed == false`
- `mutt_write_fcc()` left `m->append == true`
Richard Russon [Fri, 12 Apr 2019 16:17:54 +0000 (17:17 +0100)]
fix setting the 'replied' flag
When replying to an email, mark the original as 'replied'.
Fixes: #1647
Richard Russon [Tue, 16 Apr 2019 10:45:07 +0000 (11:45 +0100)]
merge: convert Buffers to use the pool
* remove unused Buffer in cs_inherit_variable()
* allocate Buffer in ac_free()
* allocate Buffer in cs_register_variables()
* allocate Buffer in mutt_folder_hook()
* allocate Buffer in lua_mutt_call()
* allocate Buffer in lua_mutt_enter()
* allocate Buffer in mutt_find_hook()
* allocate Buffer in mutt_account_hook()
* allocate Buffer in execute_commands()
* allocate Buffer in mutt_dump_variables()
Richard Russon [Fri, 12 Apr 2019 10:37:43 +0000 (11:37 +0100)]
allocate Buffer in mutt_dump_variables()
Richard Russon [Fri, 12 Apr 2019 10:37:16 +0000 (11:37 +0100)]
allocate Buffer in execute_commands()
Richard Russon [Fri, 12 Apr 2019 10:37:04 +0000 (11:37 +0100)]
allocate Buffer in mutt_account_hook()
Richard Russon [Fri, 12 Apr 2019 10:36:52 +0000 (11:36 +0100)]
allocate Buffer in mutt_find_hook()
Richard Russon [Fri, 12 Apr 2019 10:38:15 +0000 (11:38 +0100)]
allocate Buffer in lua_mutt_enter()
Richard Russon [Fri, 12 Apr 2019 10:37:56 +0000 (11:37 +0100)]
allocate Buffer in lua_mutt_call()
Richard Russon [Fri, 12 Apr 2019 10:36:37 +0000 (11:36 +0100)]
allocate Buffer in mutt_folder_hook()
Richard Russon [Fri, 12 Apr 2019 10:36:07 +0000 (11:36 +0100)]
allocate Buffer in cs_register_variables()
Richard Russon [Fri, 12 Apr 2019 10:35:58 +0000 (11:35 +0100)]
allocate Buffer in ac_free()
Richard Russon [Fri, 12 Apr 2019 10:36:26 +0000 (11:36 +0100)]
remove unused Buffer in cs_inherit_variable()
Richard Russon [Tue, 16 Apr 2019 09:49:35 +0000 (10:49 +0100)]
merge: add framework for testing string functions
* test: templates for string functions
* test: add string tests for degenerate cases
* libmutt: fix code for degenerate cases
* test: merge existing string tests
* build: add coverage testing
Richard Russon [Tue, 16 Apr 2019 00:47:40 +0000 (01:47 +0100)]
build: add coverage testing
Richard Russon [Tue, 16 Apr 2019 00:10:05 +0000 (01:10 +0100)]
test: merge existing string tests
Richard Russon [Mon, 15 Apr 2019 23:49:25 +0000 (00:49 +0100)]
libmutt: fix code for degenerate cases
Richard Russon [Mon, 15 Apr 2019 23:48:39 +0000 (00:48 +0100)]
test: add string tests for degenerate cases
Richard Russon [Mon, 15 Apr 2019 15:55:45 +0000 (16:55 +0100)]
test: templates for string functions
Richard Russon [Mon, 15 Apr 2019 12:40:53 +0000 (13:40 +0100)]
merge: trivial fixes
* refactor: light tidying
* tidy macros
* comment escape sequences
* add: PatternExecFlags for mutt_pattern_exec()
* tidy: mutt_copy_hdr()
* tidy calls to mutt_copy_hdr()
* boolify: mutt_parse_crypt_hdr()
* boolify: mutt_enter_fname()
* boolify: valid_passphrase()
Richard Russon [Sun, 14 Apr 2019 16:30:08 +0000 (17:30 +0100)]
boolify: valid_passphrase()
Richard Russon [Fri, 12 Apr 2019 13:35:41 +0000 (14:35 +0100)]
boolify: mutt_enter_fname()
Richard Russon [Wed, 10 Apr 2019 17:13:36 +0000 (18:13 +0100)]
boolify: mutt_parse_crypt_hdr()
Richard Russon [Fri, 12 Apr 2019 14:03:20 +0000 (15:03 +0100)]
tidy calls to mutt_copy_hdr()
Richard Russon [Fri, 12 Apr 2019 13:41:28 +0000 (14:41 +0100)]
tidy: mutt_copy_hdr()
Richard Russon [Wed, 10 Apr 2019 18:06:40 +0000 (19:06 +0100)]
add: PatternExecFlags for mutt_pattern_exec()
The flags were an enum, which wasn't really suitable.
Richard Russon [Fri, 12 Apr 2019 19:32:09 +0000 (20:32 +0100)]
comment escape sequences
Richard Russon [Thu, 11 Apr 2019 22:56:22 +0000 (23:56 +0100)]
tidy macros
- add underscores
- remove unused