]> granicus.if.org Git - neomutt/log
neomutt
6 years agoUpdate zh_CN translation
Zero King [Sat, 9 Jun 2018 02:31:05 +0000 (02:31 +0000)]
Update zh_CN translation

6 years agoUpdate ja translation
Zero King [Fri, 8 Jun 2018 17:28:14 +0000 (17:28 +0000)]
Update ja translation

6 years agoUpdate zh_CN translation
Zero King [Fri, 8 Jun 2018 17:05:18 +0000 (17:05 +0000)]
Update zh_CN translation

6 years agoFix env var quoting in backticks
Richard Russon [Mon, 18 Jun 2018 13:13:44 +0000 (14:13 +0100)]
Fix env var quoting in backticks

Issue #1262

6 years agoensure Buffers are initialised
Richard Russon [Fri, 22 Jun 2018 11:00:49 +0000 (12:00 +0100)]
ensure Buffers are initialised

6 years agomerge: upstream fixes
Richard Russon [Wed, 20 Jun 2018 15:29:38 +0000 (16:29 +0100)]
merge: upstream fixes

 * Add $pgp_check_gpg_decrypt_status_fd.
 * Add GnuPG status fd checks for inline pgp.
 * Allow larger passphrase timeout values
 * mutt_str_atol: better error handling

6 years agomutt_str_atol: better error handling
Vincent Lefevre [Tue, 19 Jun 2018 07:37:56 +0000 (09:37 +0200)]
mutt_str_atol: better error handling

Reset errno to 0 before calling strtol and testing it in mutt_atol.

Otherwise providing LONG_MAX+1 then LONG_MAX gave an error for LONG_MAX too.

* Detect overflow on negative numbers too (< LONG_MIN).

* Distinguish between format error and number overflow as already
  expected (e.g. for pgp_timeout and smime_timeout).

6 years agoAllow larger passphrase timeout values
Eike Rathke [Mon, 18 Jun 2018 20:04:47 +0000 (22:04 +0200)]
Allow larger passphrase timeout values

This came up in the comp.mail.mutt newsgroup where a user wasn't
satisfied with the SHORT_MAX seconds ~9 hours limit on passphrase
timeouts.

For the first time made it necessary for the options parser to be
able to parse numbers as long values. Also, introduced
mutt_add_timeout() to detect possible overflow before adding a
timeout to a time_t value and truncate to TIME_T_MAX instead.

6 years agoAdd GnuPG status fd checks for inline pgp.
Kevin McCarthy [Tue, 5 Jun 2018 04:31:33 +0000 (21:31 -0700)]
Add GnuPG status fd checks for inline pgp.

The difficulty is that "BEGIN PGP MESSAGE" could be a signed and
armored part, so we can't fail hard if it isn't encrypted.

Change pgp_check_decryption_okay() to return more status codes, with
>=0 indicating an actual decryption; -2 and -1 indicating plaintext
found; and -3 indicating an actual DECRYPTION_FAILED status code seen.

Fail hard on -3, but change the message for -2 and -1 to indicate the
message was not encrypted.

6 years agoAdd $pgp_check_gpg_decrypt_status_fd.
Kevin McCarthy [Mon, 4 Jun 2018 22:40:57 +0000 (15:40 -0700)]
Add $pgp_check_gpg_decrypt_status_fd.

If set (the default) mutt performs more thorough checking of the
$pgp_decrypt_command status output for GnuPG result codes.

Ticket #39 revealed that GnuPG (currently) does not protect against
messages that have been manipulated to contain an empty encryption
packet followed by a plaintext packet.

A huge thanks to Marcus Brinkmann for researching this issue, taking
the time to report it to us (and the GnuPG team), and taking even more
time to clarify exactly what needed to be checked for.   

6 years agotidy init.h values
Richard Russon [Wed, 20 Jun 2018 12:29:20 +0000 (13:29 +0100)]
tidy init.h values

6 years agostrip down .gitignore
Richard Russon [Wed, 20 Jun 2018 11:51:55 +0000 (12:51 +0100)]
strip down .gitignore

Get rid of all the things we don't see any more, like autoconf.

6 years agoRefactor resize.c into separate functions
Ivan J [Tue, 19 Jun 2018 14:15:13 +0000 (16:15 +0200)]
Refactor resize.c into separate functions

Splits up mutt_resize_screen() into its separate function to improve readability.

Closes #1149

6 years agomerge: minor improvements
Richard Russon [Tue, 19 Jun 2018 00:00:51 +0000 (01:00 +0100)]
merge: minor improvements

 * light tidy
 * coverity: fix defects
 * Put variable declaration inside case-break into braces.
 * Trailing spaces
 * Insert extern
 * One definition is enough
 * External linkage was not intended
 * Remove doubled #include
 * Redundant if clause

6 years agoRedundant if clause
Bertram Scharpf [Mon, 18 Jun 2018 14:41:34 +0000 (16:41 +0200)]
Redundant if clause

6 years agoRemove doubled #include
Bertram Scharpf [Mon, 18 Jun 2018 06:56:24 +0000 (08:56 +0200)]
Remove doubled #include

6 years agoExternal linkage was not intended
Bertram Scharpf [Sun, 17 Jun 2018 14:13:04 +0000 (16:13 +0200)]
External linkage was not intended

6 years agoOne definition is enough
Bertram Scharpf [Sun, 17 Jun 2018 14:11:20 +0000 (16:11 +0200)]
One definition is enough

6 years agoInsert extern
Bertram Scharpf [Sun, 17 Jun 2018 13:48:05 +0000 (15:48 +0200)]
Insert extern

The variable was already defined in "git_ver.h".

6 years agoTrailing spaces
Bertram Scharpf [Sun, 17 Jun 2018 13:47:02 +0000 (15:47 +0200)]
Trailing spaces

6 years agoPut variable declaration inside case-break into braces.
Bertram Scharpf [Sun, 17 Jun 2018 13:44:00 +0000 (15:44 +0200)]
Put variable declaration inside case-break into braces.

6 years agocoverity: fix defects
Richard Russon [Mon, 18 Jun 2018 12:24:08 +0000 (13:24 +0100)]
coverity: fix defects

6 years agolight tidy
Richard Russon [Thu, 14 Jun 2018 14:57:22 +0000 (15:57 +0100)]
light tidy

6 years agoFix for missing fingerprint
Richard Russon [Mon, 18 Jun 2018 11:01:28 +0000 (12:01 +0100)]
Fix for missing fingerprint

If GPGME doesn't return a key fingerprint, don't crash.

6 years agoFix off-by-one in index jump
Richard Russon [Mon, 18 Jun 2018 10:11:22 +0000 (11:11 +0100)]
Fix off-by-one in index jump

In an index of 'n' items, you couldn't jump to 'n', only (n-1).

Fixes #1261

6 years agoacutest: sync to upstream
Richard Russon [Sun, 17 Jun 2018 09:18:24 +0000 (10:18 +0100)]
acutest: sync to upstream

This file is from the Acutest project:

- https://github.com/mity/acutest

Specifically, from commit: `03885e23`

6 years agofcc_attach: Don't ask every time
Bertram Scharpf [Sun, 17 Jun 2018 09:06:58 +0000 (11:06 +0200)]
fcc_attach: Don't ask every time

Option fcc_attach used to ask in any case, if there were attachment nad if there weren't.
In case there is no attachment, there is no need to ask.

6 years agofix non-empty buffers
Richard Russon [Thu, 14 Jun 2018 18:12:33 +0000 (19:12 +0100)]
fix non-empty buffers

Insert a few `mutt_buffer_reset()`s.

Commit 9d6a2418 replaced a lot of `snprintf()`s with `mutt_buffer_printf()`.
Unfortunately, a few of the original lines were relying on `snprintf()`
writing over the beginning of the buffer.

6 years agodoxygen: document mh functions
Richard Russon [Wed, 13 Jun 2018 21:19:48 +0000 (22:19 +0100)]
doxygen: document mh functions

6 years agodoxygen: document menu functions
Richard Russon [Tue, 12 Jun 2018 20:40:51 +0000 (21:40 +0100)]
doxygen: document menu functions

6 years agodrop memset for simple neomutt structs
Richard Russon [Tue, 12 Jun 2018 13:28:27 +0000 (14:28 +0100)]
drop memset for simple neomutt structs

6 years agodrop memset for simple arrays
Richard Russon [Tue, 12 Jun 2018 13:06:07 +0000 (14:06 +0100)]
drop memset for simple arrays

6 years agomerge: more ncrypt tidying
Richard Russon [Tue, 12 Jun 2018 12:52:45 +0000 (13:52 +0100)]
merge: more ncrypt tidying

 * drop unused param in pgp_make_key_attachment()
 * drop unused param in pgp_extract_keys_from_attachment_list()
 * boolify need_passphrase
 * boolify params
 * boolify retval

6 years agoboolify retval
Richard Russon [Tue, 12 Jun 2018 11:36:00 +0000 (12:36 +0100)]
boolify retval

6 years agoboolify params
Richard Russon [Tue, 12 Jun 2018 11:32:53 +0000 (12:32 +0100)]
boolify params

6 years agoboolify need_passphrase
Richard Russon [Tue, 12 Jun 2018 11:08:26 +0000 (12:08 +0100)]
boolify need_passphrase

6 years agodrop unused param in pgp_extract_keys_from_attachment_list()
Richard Russon [Tue, 12 Jun 2018 10:55:52 +0000 (11:55 +0100)]
drop unused param in pgp_extract_keys_from_attachment_list()

The function wasn't being use to look for tagged messages.
So, it's been renamed to pgp_extract_key_from_attachment()

6 years agodrop unused param in pgp_make_key_attachment()
Richard Russon [Tue, 12 Jun 2018 10:41:22 +0000 (11:41 +0100)]
drop unused param in pgp_make_key_attachment()

It was unused by any of the callers of the API wrapper:
crypt_pgp_make_key_attachment().

6 years agomerge: mass tidy-up of ncrypt
Richard Russon [Tue, 12 Jun 2018 01:45:59 +0000 (02:45 +0100)]
merge: mass tidy-up of ncrypt

 * drop unnec typedefs
 * fold CryptModuleFunctions into CryptModuleSpecs
 * drop redirect functions
 * tidy headers
 * doxygen: Document the encryption API
 * doxygen: document api implementors
 * unify the naming of all the ncrypt API functions
 * doxygen: document the ncrypt api wrappers

6 years agodoxygen: document the ncrypt api wrappers
Richard Russon [Tue, 12 Jun 2018 01:31:09 +0000 (02:31 +0100)]
doxygen: document the ncrypt api wrappers

6 years agounify the naming of all the ncrypt API functions
Richard Russon [Mon, 11 Jun 2018 23:18:17 +0000 (00:18 +0100)]
unify the naming of all the ncrypt API functions

6 years agodoxygen: document api implementors
Richard Russon [Mon, 11 Jun 2018 22:35:05 +0000 (23:35 +0100)]
doxygen: document api implementors

6 years agodoxygen: Document the encryption API
Richard Russon [Mon, 11 Jun 2018 14:00:53 +0000 (15:00 +0100)]
doxygen: Document the encryption API

6 years agotidy headers
Richard Russon [Fri, 8 Jun 2018 15:09:21 +0000 (16:09 +0100)]
tidy headers

6 years agodrop redirect functions
Richard Russon [Fri, 8 Jun 2018 16:50:32 +0000 (17:50 +0100)]
drop redirect functions

6 years agofold CryptModuleFunctions into CryptModuleSpecs
Richard Russon [Fri, 8 Jun 2018 14:31:52 +0000 (15:31 +0100)]
fold CryptModuleFunctions into CryptModuleSpecs

6 years agodrop unnec typedefs
Richard Russon [Fri, 8 Jun 2018 14:30:10 +0000 (15:30 +0100)]
drop unnec typedefs

6 years agomerge: minor improvements
Richard Russon [Mon, 11 Jun 2018 12:46:27 +0000 (13:46 +0100)]
merge: minor improvements

 * tidy bcache
 * boolify function params
 * doxy: add function comments
 * fix comment order
 * tidy hcache definitions

6 years agotidy hcache definitions
Richard Russon [Thu, 7 Jun 2018 12:07:47 +0000 (13:07 +0100)]
tidy hcache definitions

6 years agofix comment order
Richard Russon [Thu, 7 Jun 2018 12:04:11 +0000 (13:04 +0100)]
fix comment order

6 years agodoxy: add function comments
Richard Russon [Fri, 8 Jun 2018 14:13:17 +0000 (15:13 +0100)]
doxy: add function comments

6 years agoboolify function params
Richard Russon [Fri, 8 Jun 2018 12:30:47 +0000 (13:30 +0100)]
boolify function params

6 years agotidy bcache
Richard Russon [Fri, 8 Jun 2018 14:11:38 +0000 (15:11 +0100)]
tidy bcache

6 years agorevert dodgy type changes
Richard Russon [Mon, 11 Jun 2018 10:46:46 +0000 (11:46 +0100)]
revert dodgy type changes

Some of the type changes I introduced in 309ecbf4 would cause problems
when strtol() and atoi() return errors.

6 years agofix trash mailbox
Richard Russon [Sun, 10 Jun 2018 14:25:48 +0000 (15:25 +0100)]
fix trash mailbox

The second `for` loop was using the value of `i` as a starting place.
By changing the first loop, the second loop wasn't doing any work.

Fixes #1253

6 years agomerge: update translations
Richard Russon [Wed, 6 Jun 2018 15:03:38 +0000 (16:03 +0100)]
merge: update translations

 * add missing 'Plural-Forms' statement
 * sync translations
 * trans: de-dupe an ssl string
 * Update Czech translation
 * Update ja translation
 * Update Slovak translation
 * Update zh_CN translation
 * use consistent expression for memory streams

6 years agosync translations
Richard Russon [Wed, 6 Jun 2018 15:02:27 +0000 (16:02 +0100)]
sync translations

6 years agoUpdate zh_CN translation
Zero King [Tue, 5 Jun 2018 10:00:30 +0000 (10:00 +0000)]
Update zh_CN translation

6 years agouse consistent expression for memory streams
Richard Russon [Tue, 5 Jun 2018 09:53:46 +0000 (10:53 +0100)]
use consistent expression for memory streams

6 years agoUpdate zh_CN translation
Zero King [Tue, 5 Jun 2018 09:35:03 +0000 (09:35 +0000)]
Update zh_CN translation

6 years agoUpdate zh_CN translation
Zero King [Tue, 5 Jun 2018 03:23:24 +0000 (03:23 +0000)]
Update zh_CN translation

6 years agoUpdate zh_CN translation
Zero King [Mon, 4 Jun 2018 13:27:20 +0000 (13:27 +0000)]
Update zh_CN translation

6 years agoUpdate ja translation
Zero King [Sun, 3 Jun 2018 12:16:32 +0000 (12:16 +0000)]
Update ja translation

6 years agoUpdate ja translation
Zero King [Sat, 2 Jun 2018 03:36:44 +0000 (03:36 +0000)]
Update ja translation

6 years agotrans: de-dupe an ssl string
Richard Russon [Fri, 1 Jun 2018 21:55:24 +0000 (22:55 +0100)]
trans: de-dupe an ssl string

6 years agoUpdate Slovak translation
David Sterba [Fri, 1 Jun 2018 10:37:25 +0000 (12:37 +0200)]
Update Slovak translation

6 years agoadd missing 'Plural-Forms' statement
Richard Russon [Thu, 31 May 2018 14:22:48 +0000 (15:22 +0100)]
add missing 'Plural-Forms' statement

6 years agoUpdate ja translation
Zero King [Thu, 31 May 2018 13:52:18 +0000 (13:52 +0000)]
Update ja translation

6 years agoUpdate zh_CN translation
Zero King [Tue, 29 May 2018 12:50:30 +0000 (12:50 +0000)]
Update zh_CN translation

6 years agoUpdate zh_CN translation
Zero King [Tue, 29 May 2018 12:33:32 +0000 (12:33 +0000)]
Update zh_CN translation

6 years agoUpdate zh_CN translation
Zero King [Tue, 29 May 2018 12:07:56 +0000 (12:07 +0000)]
Update zh_CN translation

6 years agoUpdate Czech translation
David Sterba [Tue, 29 May 2018 11:31:48 +0000 (13:31 +0200)]
Update Czech translation

6 years agoUpdate zh_CN translation
Zero King [Tue, 29 May 2018 05:21:13 +0000 (05:21 +0000)]
Update zh_CN translation

6 years agomerge: increase and unify buffer sizes
Richard Russon [Wed, 6 Jun 2018 14:58:24 +0000 (15:58 +0100)]
merge: increase and unify buffer sizes

 * adjust the size of some general buffers
 * Use sizeof() rather than constants
 * Create a large buffer for command strings
 * Enlarge buffers from _POSIX_PATH_MAX to PATH_MAX
 * Enlarge buffers from LONG_STRING to PATH_MAX

6 years agoEnlarge buffers from LONG_STRING to PATH_MAX 1229/head
Richard Russon [Tue, 29 May 2018 15:52:55 +0000 (16:52 +0100)]
Enlarge buffers from LONG_STRING to PATH_MAX

Every buffer that has a filesystem path copied into it

6 years agoEnlarge buffers from _POSIX_PATH_MAX to PATH_MAX
Richard Russon [Tue, 29 May 2018 14:55:51 +0000 (15:55 +0100)]
Enlarge buffers from _POSIX_PATH_MAX to PATH_MAX

Every buffer that has a filesystem path copied into it

6 years agoCreate a large buffer for command strings
Richard Russon [Tue, 29 May 2018 14:38:06 +0000 (15:38 +0100)]
Create a large buffer for command strings

6 years agoUse sizeof() rather than constants
Richard Russon [Tue, 29 May 2018 14:32:05 +0000 (15:32 +0100)]
Use sizeof() rather than constants

6 years agomerge: small improvements
Richard Russon [Wed, 6 Jun 2018 14:43:55 +0000 (15:43 +0100)]
merge: small improvements

 * tidy handler.c
 * tidy for loops
 * insert {}s
 * doxy: document buffy.c
 * tidy return statements
 * move new functions to reduce header deps
 * add enum for 'set' commands
 * tidy the regex types
 * minor tidying

6 years agominor tidying
Richard Russon [Sat, 2 Jun 2018 17:12:56 +0000 (18:12 +0100)]
minor tidying

- rename parameters
- change member types
- fix doxygen typo
- make variable const

6 years agotidy the regex types
Richard Russon [Thu, 31 May 2018 00:36:06 +0000 (01:36 +0100)]
tidy the regex types

- remove unnecessary casts
- fix variable types
- remove once-used macro (REGEXEC)

6 years agoadd enum for 'set' commands
Richard Russon [Sat, 2 Jun 2018 11:42:55 +0000 (12:42 +0100)]
add enum for 'set' commands

The 'set' family of commands are mutually exclusive, so change the
defines to an enumeration.

6 years agomove new functions to reduce header deps
Richard Russon [Sat, 2 Jun 2018 22:37:17 +0000 (23:37 +0100)]
move new functions to reduce header deps

Having the `new` functions in the header creates a requirement on the
mutt library.

6 years agotidy return statements
Richard Russon [Tue, 5 Jun 2018 11:00:45 +0000 (12:00 +0100)]
tidy return statements

Add ()s to return statements where the logic is non-trivial.

6 years agodoxy: document buffy.c
Richard Russon [Mon, 4 Jun 2018 23:24:38 +0000 (00:24 +0100)]
doxy: document buffy.c

6 years agoinsert {}s
Richard Russon [Sun, 3 Jun 2018 16:53:10 +0000 (17:53 +0100)]
insert {}s

Insert {}s where the conditional or body take up more than one line.

6 years agotidy for loops
Richard Russon [Sat, 2 Jun 2018 23:40:53 +0000 (00:40 +0100)]
tidy for loops

- Add {}s where the body of a `for` loop isn't obvious.
- Add ()s where the logic isn't clear

6 years agotidy handler.c
Richard Russon [Sat, 2 Jun 2018 21:33:17 +0000 (22:33 +0100)]
tidy handler.c

- Move the function prototypes to a new file `handler.h`
- Rearrange the functions

There are no changes to the code.

6 years agotidy hcache
Richard Russon [Wed, 6 Jun 2018 12:18:46 +0000 (13:18 +0100)]
tidy hcache

- Drop the typedefs -- they were only used once
- Move the backend list `HCACHE_BACKEND_LIST` into hcache.c
- Update all the source docs

6 years agomerge: tidy the mailbox API
Richard Russon [Wed, 6 Jun 2018 12:46:58 +0000 (13:46 +0100)]
merge: tidy the mailbox API

 * unify parameter naming
 * reorder functions
 * rename functions
 * rename implementation functions
 * document all implementation functions
 * swap mx_commit_message() params
 * rename mx functions to match api

6 years agomx api: rename mx functions to match api
Richard Russon [Wed, 6 Jun 2018 01:27:15 +0000 (02:27 +0100)]
mx api: rename mx functions to match api

6 years agomx api: swap mx_commit_message() params
Richard Russon [Wed, 6 Jun 2018 01:16:05 +0000 (02:16 +0100)]
mx api: swap mx_commit_message() params

for consistency with the other api functions

6 years agomx api: document all implementation functions
Richard Russon [Wed, 6 Jun 2018 01:05:11 +0000 (02:05 +0100)]
mx api: document all implementation functions

6 years agomx api: rename implementation functions
Richard Russon [Tue, 5 Jun 2018 19:55:34 +0000 (20:55 +0100)]
mx api: rename implementation functions

6 years agomx api: rename functions
Richard Russon [Tue, 5 Jun 2018 19:42:03 +0000 (20:42 +0100)]
mx api: rename functions

6 years agomx api: reorder functions
Richard Russon [Tue, 5 Jun 2018 19:22:55 +0000 (20:22 +0100)]
mx api: reorder functions

6 years agomx api: unify parameter naming
Richard Russon [Tue, 5 Jun 2018 19:10:34 +0000 (20:10 +0100)]
mx api: unify parameter naming

6 years agoDo not (try to) install / uninstall nonexistent man pages
Pietro Cerutti [Mon, 4 Jun 2018 07:37:45 +0000 (07:37 +0000)]
Do not (try to) install / uninstall nonexistent man pages

See #1247

6 years agomerge: drop pgpring references
Richard Russon [Fri, 1 Jun 2018 10:01:51 +0000 (11:01 +0100)]
merge: drop pgpring references

 * remove pgpring from docs
 * remove last references to pgpring
 * drop obsolete pgp notes

6 years agodrop obsolete pgp notes 1242/head
Richard Russon [Fri, 1 Jun 2018 09:47:58 +0000 (10:47 +0100)]
drop obsolete pgp notes