sar/sadf: Make sure we can read file headers structures from older
versions
Reading the file_header or file_activity structures from a daily data
file from an older version where fewer fields were present might be a
problem as we allocate buffers based on the size of the structure from
the file. This buffer would ithen be to small for the remap_struct()
function to remap the fields to current (larger) structures.
sysstat version 12.1.7 final packaging.
lsm and spec files updated.
Changelog added.
The main new feature brought by this version is the support for stable
identifiers for sar disks statistics. This stable identifier (which
won't change across reboots) is the WWN (World-Wide Name) of the device.
The sar and sadf commands included in this version are also ready to read
new formats of binary data files which could arrive in a (hopefully)
distant future.
This variable contains the name of sysstat main configuration file
(this file is named sysstat by default and is normally located in the
/etc/sysconfig directory)
simtest: Add non regression test on datafiles extra structures
data-extra-12.1.7 is a binary datafile with a next generation format (it
contains various extra structures that could be added in a future
sysstat version).
This test makes sure that current sysstat version will be able to read
such a format.
sar/sadf: Add extra flexibility in case of a change of file format
Add some extra code to sar and sadf so that they can read new
structures saved in daily binary data files. No changes in binary data
files are planned at the present time, but should a change happen in a
(hopefully) distant future, current sar and sadf commands will be able
to read this new format.
sar/sadc: Add stable identifier support for disks statistics
This patch adds new fields to stats_disk structure to save a stable
identifier for each block device (see issue #195).
A stable identifier is a name that should not change across reboots for
the same physical device.
At the present time this stable identifier is the WWN (World Wide Name)
id that is read from /dev/disk/by-id if it exists for the device.
If it doesn't exist then we fall back on using the pretty name (sda,
sda1, etc.).
The stable identifier is always collected by sadc when disks statistics
are collected (sadc option "-S DISK | XDISK").
It can be printed by sar (or sadf) with the option "-j SID" (SID stands
for Stable IDentifier).
Sebastien GODARD [Wed, 14 Aug 2019 16:35:09 +0000 (18:35 +0200)]
sysstat-12.1.6
sysstat version 12.1.6 final packaging.
lsm and spec files updated.
Changelog added.
In this version, the iostat command has been heavily modified for better
performance. In particular devices structures are now dynamically allocated
to make sure you won't miss a device if many of them are added to the
system while iostat is running. Also sysstat test environment now
includes a large set of non regression tests for iostat.
Sebastien GODARD [Tue, 13 Aug 2019 12:53:29 +0000 (14:53 +0200)]
Fix #230: Memory corruption bug due to Integer Overflow in remap_struct()
(See problem description in issue #230.)
Check that the number of fields (long long integers, long integers or
integers) as read from a system activity binary datafile multiplied by
its alignment width doesn't overflow, i.e. the result must not be
smaller than the number of fields.
iostat: Make sure that devices that have a slash in their name get
properly printed
Make sure that devices that have a slash in their name (e.g.
cciss/c0d0...) are displayed with their real name, not their name used
to save them in the linked list ('/' character is replaced with '!'
there).
iostat: Fix issue when a UUID is given on the command line
A command like "iostat -j UUID 2578463f-6947-48c7-8b09-876a4145cfb1 1 2"
didn't work because the UUID name was considered as the interval of time
to use. This patch fixes the problem.
This patch adds the following features:
* Structures for devices statistics are now dynamically allocated. It is
no longer possible to miss a device if many of them are added into the
system while iostat is running.
* Check for devices which are removed then inserted again into the
system. iostat will no longer display abormally high numbers in these
cases.
* Better handle devices entered on the command line, which may be
partitions and/or whole devices.
Sebastien GODARD [Fri, 28 Jun 2019 09:33:14 +0000 (11:33 +0200)]
simtest: sar: Add non regression tests for sensors statistics
Sensors statistics cannot be read in Travis CI environment because the
requested library is not available. But we can at least display sensors
statistics from a binary datafile already containing them.
Sebastien GODARD [Fri, 28 Jun 2019 07:23:51 +0000 (09:23 +0200)]
simtest: Try to simulate the addition of a new FB host
For this, we need to make sure that FB hosts will always be read in
the same order (and especially on Travis CI VM) though this may depend
on the underlying filesystem implementation.
Sebastien GODARD [Fri, 28 Jun 2019 06:54:36 +0000 (08:54 +0200)]
sar: Better handle the case when FB hosts are added to the system
If a new Fibre Channel host is registered in the system, now display its
statistics even for the interval during which it has been registered. In
this case, its initial counters values are considered as 0.
Sebastien GODARD [Fri, 28 Jun 2019 06:00:05 +0000 (08:00 +0200)]
simtest: Make it possible to use /dev/sdb in iostat test
/dev/sdb probably doesn't exist on Travis CI virtual machine, making
iostat non regression test using it fail.
Make sure we stay in our simulation environment by providing a
replacement function for realpath() system call.
Sebastien GODARD [Fri, 21 Jun 2019 15:48:44 +0000 (17:48 +0200)]
iostat: Fix wrong CPU stats displayed with option -y
CPU statistics written for the first sample was wrong when option -y was
used. This was because the interval of time used was that since system
startup whereas it should have been the interval of time since last
sample (which is not displayed with option -y).
In 789cd86fb0, read_net_icmp() obtained code to differentiate between
the old and new format of /proc/net/snmp, which differ by the addition
of "InCsumErrors" in the 3rd position. Add the exact same handling logic
to read_net_eicmp() as well
sar/sadf: Allow to select individual CPU/interrupts with option -A
Previously, using option -A with sar or sadf would display statistics
for all CPU and interrupts (i.e. using -A would also imply -P ALL -I
ALL).
Now this will be true only if the user didn't specify explicitly a list
of CPU or interrupts using options -P or -I.
Example: "sar -A -P1,4" will display all possible statistics but only those
concerning CPU 1 and 4 for CPU-related metrics.
Sebastien GODARD [Fri, 31 May 2019 07:00:08 +0000 (09:00 +0200)]
sysstat-12.1.5
sysstat version 12.1.5 final packaging.
lsm and spec files updated.
Changelog added.
This version completes the support for PCP (Performance Co-Pilote)
output format with sadf: All statistics collected by sar/sadc can now
be exported to a PCP archive file.
This version also includes now a simulation test environment. This makes
it possible to run non regression tests with reproducible results. The
tests are run in a simulated environment composed of kernel files with
predefined values.
For now, only non regression tests have been added for sar, sadc and
sadf commands. Yet they have permitted to identify several bugs which
have been fixed here and also backported to version 12.0.5.
projects / sysstat / log