]> granicus.if.org Git - postgresql/log
postgresql
19 years agothere's a paragraph in the ALTER TABLE reference page that reads:
Bruce Momjian [Thu, 8 Dec 2005 21:35:41 +0000 (21:35 +0000)]
there's a paragraph in the ALTER TABLE reference page that reads:

DROP CONSTRAINT

    This form drops constraints on a table. Currently, constraints on tables
    are not required to have unique names, so there may be more than one
    constraint matching the specified name. All matching constraints will be
    dropped.

To my knowledge, it is no longer possible to create constraints with the
same name for the same relation. When you create a constraint and specify
the same name explictly, an error is raised. Implicit constraint creation
won't choose an existing name either and up to now you could not rename a
constraint. Renaming works with the patch I sent in a few hours ago but this
patch as well won't allow constraints with identical names on the same
relation.

The attached patch thus removes the note in the docs.

Joachim Wieland

19 years agoRemove empty heading row in error table.
Bruce Momjian [Thu, 8 Dec 2005 21:23:13 +0000 (21:23 +0000)]
Remove empty heading row in error table.

19 years agoAdd missing translation marker
Peter Eisentraut [Thu, 8 Dec 2005 21:17:46 +0000 (21:17 +0000)]
Add missing translation marker

19 years agoAdd "Constant" column to error code table.
Bruce Momjian [Thu, 8 Dec 2005 21:01:55 +0000 (21:01 +0000)]
Add "Constant" column to error code table.

Also, better mark section headings.

kdio@uenf.br

19 years agoDocumentation fix: s/event_object_name/event_object_table/g
Peter Eisentraut [Thu, 8 Dec 2005 20:46:54 +0000 (20:46 +0000)]
Documentation fix: s/event_object_name/event_object_table/g

19 years agoFix bgwriter's failure to release buffer pins and open files after an
Tom Lane [Thu, 8 Dec 2005 19:19:31 +0000 (19:19 +0000)]
Fix bgwriter's failure to release buffer pins and open files after an
error.  This probably explains bug #2099 and could also account for
mysterious VACUUM hangups.

19 years agoI recently received the Debian bug report below about missing iconv
Bruce Momjian [Thu, 8 Dec 2005 18:04:38 +0000 (18:04 +0000)]
I recently received the Debian bug report below about missing iconv
support for the dbf2pg contrib module.

The submitter created a patch which replaces the silent ignoring of -F
(when iconv support is disabled) with a meaningful warning.

Martin Pitt

19 years agoAdd documentation about the inability of plpsql to use parameter names
Bruce Momjian [Thu, 8 Dec 2005 18:02:10 +0000 (18:02 +0000)]
Add documentation about the inability of plpsql to use parameter names
that are the same as column names used in the function.

19 years agoDisble some Win32-specific code in win32-client-only builds:
Bruce Momjian [Thu, 8 Dec 2005 17:52:20 +0000 (17:52 +0000)]
Disble some Win32-specific code in win32-client-only builds:

I have the problem, when building by MS-VC6.
An error occurs in the 8.1.0 present source codes.

nmake -f win32.mak
..\..\port\getaddrinfo.c(244) : error C2065: 'WSA_NOT_ENOUGH_MEMORY'
..\..\port\getaddrinfo.c(342) : error C2065: 'WSATYPE_NOT_FOUND'

This is used by winsock2.h. However, Construction of a windows base is
winsock.h.
Then, Since MinGW has special environment, this is right. but, it is not
found in VC6.
Furthermore, in getaddrinfo.c, IPV6-API is used by
LoadLibraryA("ws2_32");
Referring to of dll the external memory generates this violation by VC6
specification.

I considered whether the whole should have been converted into winsock2.
However, Now, DLL of MinGW creation operates wonderfully as it is.
That's right, it has pliability by replacement of simple DLL.
Then, I propose the system using winsock(non IPV6) in construction of
VC6.

Hiroshi Saito

19 years agoFix incorrect SPI example, per Yoshihisa Nakano.
Tom Lane [Wed, 7 Dec 2005 15:39:32 +0000 (15:39 +0000)]
Fix incorrect SPI example, per Yoshihisa Nakano.

19 years agoImprove lazy vacuum wording.
Bruce Momjian [Wed, 7 Dec 2005 14:36:08 +0000 (14:36 +0000)]
Improve lazy vacuum wording.

19 years agoClarify vacuum lazy can shrink a file under certain circumstances.
Bruce Momjian [Wed, 7 Dec 2005 05:36:08 +0000 (05:36 +0000)]
Clarify vacuum lazy can shrink a file under certain circumstances.

19 years agoUpdate iconv wording, per Peter.
Bruce Momjian [Tue, 6 Dec 2005 21:01:32 +0000 (21:01 +0000)]
Update iconv wording, per Peter.

19 years agoHighlight diff idea for iconv.
Bruce Momjian [Tue, 6 Dec 2005 20:26:02 +0000 (20:26 +0000)]
Highlight diff idea for iconv.

19 years agoiconv uses UTF-8, not UTF8.
Bruce Momjian [Tue, 6 Dec 2005 20:19:38 +0000 (20:19 +0000)]
iconv uses UTF-8, not UTF8.

19 years agoDocument method of removing invalid UTF8 escape sequences from dump
Bruce Momjian [Tue, 6 Dec 2005 19:27:09 +0000 (19:27 +0000)]
Document method of removing invalid UTF8 escape sequences from dump
file.  Backpatch to 8.1.X.

Paul Lindner

19 years agoSince my name has a non-ascii-letter in it, it's often spelled wrong. In
Bruce Momjian [Tue, 6 Dec 2005 18:43:40 +0000 (18:43 +0000)]
Since my name has a non-ascii-letter in it, it's often spelled wrong. In
the latest release notes there is a latin1 character that shouldn't be
there so I made a patch to fix that. This patch also fixes some old
entries that uses o instead of ö (which is also wrong but not as
bad as including a latin1 character in the sgml file).

Dennis Bj?rklund

19 years agoAdd documentation on the use of *printf() macros and libintl.
Bruce Momjian [Tue, 6 Dec 2005 18:35:36 +0000 (18:35 +0000)]
Add documentation on the use of *printf() macros and libintl.

Backpatch to 8.1.X.

19 years agoFix stupid bug with sizeof
Teodor Sigaev [Tue, 6 Dec 2005 18:22:27 +0000 (18:22 +0000)]
Fix stupid bug with sizeof

19 years agoIn a nestloop inner indexscan, it's OK to use pushed-down baserestrictinfo
Tom Lane [Tue, 6 Dec 2005 16:50:46 +0000 (16:50 +0000)]
In a nestloop inner indexscan, it's OK to use pushed-down baserestrictinfo
clauses even if it's an outer join.  This is a corner case since such
clauses could only arise from weird OUTER JOIN ON conditions, but worth
fixing.  Per example from Ron at cheapcomplexdevices.com.

19 years agoecpg/pgtypeslib seems to need snprintf.c pulled in, too.
Tom Lane [Tue, 6 Dec 2005 05:26:30 +0000 (05:26 +0000)]
ecpg/pgtypeslib seems to need snprintf.c pulled in, too.

19 years agoPut undef's before extern declarations that need 'em, per Andrew Dunstan.
Tom Lane [Tue, 6 Dec 2005 05:13:56 +0000 (05:13 +0000)]
Put undef's before extern declarations that need 'em, per Andrew Dunstan.

19 years agoAdd comment on why pg *printf functions are used unconditionally on
Bruce Momjian [Tue, 6 Dec 2005 04:53:28 +0000 (04:53 +0000)]
Add comment on why pg *printf functions are used unconditionally on
Win32.

Backpatch to 8.1.X.

19 years agoMake Win32 build use our port/snprintf.c routines, instead of depending
Tom Lane [Tue, 6 Dec 2005 02:29:27 +0000 (02:29 +0000)]
Make Win32 build use our port/snprintf.c routines, instead of depending
on libintl which may or may not provide what we need.  Make a few marginal
cleanups to ensure this works.  Andrew Dunstan and Tom Lane.

19 years agoAdd regression test to see if the min/max values of int8 convert correctly.
Tom Lane [Mon, 5 Dec 2005 04:13:53 +0000 (04:13 +0000)]
Add regression test to see if the min/max values of int8 convert correctly.

19 years agoFix a rather sizable number of problems in our homegrown snprintf, such as
Tom Lane [Mon, 5 Dec 2005 02:39:43 +0000 (02:39 +0000)]
Fix a rather sizable number of problems in our homegrown snprintf, such as
incorrect implementation of argument reordering, arbitrary limit of output
size for sprintf and fprintf, willingness to access more bytes than "%.Ns"
specification allows, wrong formatting of LONGLONG_MIN, various field-padding
bugs and omissions.  I believe it now accurately implements a subset of
the Single Unix Spec requirements (remaining unimplemented features are
documented, too).  Bruce Momjian and Tom Lane.

19 years agoTwo fixes from Tom Lan. See the posting "[PATCHES] A couple of
Tatsuo Ishii [Sun, 4 Dec 2005 01:22:42 +0000 (01:22 +0000)]
Two fixes from Tom Lan. See the posting "[PATCHES] A couple of
proposed pgbench changes" on 2005/11/29 for more details.

The change at line 490 updates doCustom's local variable "commands"
after selecting a new file (command sequence).  I think that the
existing coding will cause the thing to use the first command of the
old sequence in the remainder of the routine, which would be a bug.
I have not tried to set up a test case to prove it, though.

The other two changes cause doCustom to loop after processing a
meta-command.  This might be a bit controversial, but as the code
is currently written, each meta-command "costs" one cycle of the
outer select() loop.  Thus, for example, with the default TPC-B script,
once a backend returns "COMMIT" it will not receive a new command
until four cycles of issuing commands to other backends have elapsed.
(You can see this very easily by strace'ing pgbench under load.)

19 years agoFix out-of-order inclusion of -L switches from LDFLAGS on AIX and HPUX.
Tom Lane [Sat, 3 Dec 2005 20:16:39 +0000 (20:16 +0000)]
Fix out-of-order inclusion of -L switches from LDFLAGS on AIX and HPUX.
Per example from Dirk Pirschel.

19 years agoAllow to_char(interval) and to_char(time) to use AM/PM specifications.
Bruce Momjian [Sat, 3 Dec 2005 16:45:23 +0000 (16:45 +0000)]
Allow to_char(interval) and to_char(time) to use AM/PM specifications.
Map them to a single day, so '30 hours' is 'AM'.

Have to_char(interval) and to_char(time) use "HH", "HH12" as 12-hour
intervals, rather than bypass and print the full interval hours.  This
is neeeded because to_char(time) is mapped to interval in this function.
Intervals should use "HH24", and document suggestion.

Allow "D" format specifiers for interval/time.

19 years agoFix obsolete description of -h option, per Andreas Schmidt.
Tom Lane [Fri, 2 Dec 2005 23:13:53 +0000 (23:13 +0000)]
Fix obsolete description of -h option, per Andreas Schmidt.

19 years agoAdded special handling of CONNECTION variable that is used by ECPG instead of given...
Michael Meskes [Fri, 2 Dec 2005 15:04:48 +0000 (15:04 +0000)]
Added special handling of CONNECTION variable that is used by ECPG instead of given to the backend.
I failed to notice that CONNECTION had become a keyword in 8.1.

19 years agoRearrange code in ExecInitBitmapHeapScan so that we don't initialize the
Tom Lane [Fri, 2 Dec 2005 01:30:26 +0000 (01:30 +0000)]
Rearrange code in ExecInitBitmapHeapScan so that we don't initialize the
child plan nodes until we have acquired lock on the relation to scan.
The relative order of initialization of plan nodes isn't real important in
other cases, but it's critical here because one is supposed to lock a
relation before its indexes, not vice versa.  The original coding was at
least vulnerable to deadlock against DROP INDEX, and perhaps worse things.

19 years agoRetry in FileRead and FileWrite if Windows returns ERROR_NO_SYSTEM_RESOURCES.
Tom Lane [Thu, 1 Dec 2005 20:24:31 +0000 (20:24 +0000)]
Retry in FileRead and FileWrite if Windows returns ERROR_NO_SYSTEM_RESOURCES.
Also add a retry for Unixen returning EINTR, which hasn't been reported
as an issue but at least theoretically could be.  Patch by Qingqing Zhou,
some minor adjustments by me.

19 years agoCheck for overflow in strtol() while parsing datetime inputs.
Tom Lane [Thu, 1 Dec 2005 17:56:43 +0000 (17:56 +0000)]
Check for overflow in strtol() while parsing datetime inputs.
Michael Fuhr.

19 years agoFix typo in PL/PgSQL documentation, per Chris KL.
Neil Conway [Thu, 1 Dec 2005 10:38:09 +0000 (10:38 +0000)]
Fix typo in PL/PgSQL documentation, per Chris KL.

19 years agoRearrange code in pg_atoi() to avoid assuming that isspace() cannot
Tom Lane [Wed, 30 Nov 2005 23:10:16 +0000 (23:10 +0000)]
Rearrange code in pg_atoi() to avoid assuming that isspace() cannot
change errno.  No reported bugs here, but why take a chance?

19 years agoTweak choose_bitmap_and() heuristics in the light of example provided in bug
Tom Lane [Wed, 30 Nov 2005 17:10:25 +0000 (17:10 +0000)]
Tweak choose_bitmap_and() heuristics in the light of example provided in bug
#2075: consider an index redundant if any of its index conditions were already
used, rather than if all of them were.  Also, make the selectivity comparison
a bit fuzzy, so that very small differences in estimated selectivities don't
skew the results.

19 years ago- Made several variables "const char *" instead of "char *" as proposed by Qingqing...
Michael Meskes [Wed, 30 Nov 2005 12:50:37 +0000 (12:50 +0000)]
- Made several variables "const char *" instead of "char *" as proposed by Qingqing Zhou <zhouqq@cs.toronto.edu>.
- Replaced all strdup() calls by ECPGstrdup().

19 years agoTweak hash join code to use an additional heuristic for deciding whether
Tom Lane [Mon, 28 Nov 2005 23:46:25 +0000 (23:46 +0000)]
Tweak hash join code to use an additional heuristic for deciding whether
it's worth probing the outer relation for emptiness before building the
hash table.  To wit, if we're rescanning a join previously performed,
remember whether we found it nonempty the previous time, and don't bother
with the probe if it was nonempty.  This buys back the performance lost
in examples like Mario Weilguni's.

19 years agoImprove documentation for COALESCE and NULLIF. Add references for NVL
Bruce Momjian [Mon, 28 Nov 2005 23:19:03 +0000 (23:19 +0000)]
Improve documentation for COALESCE and NULLIF.  Add references for NVL
and IFNULL.

Backpatch to 8.1.X.

19 years agoInstall a more future-proof fix for the snapshot-unset bug just found.
Alvaro Herrera [Mon, 28 Nov 2005 17:23:12 +0000 (17:23 +0000)]
Install a more future-proof fix for the snapshot-unset bug just found.
Per suggestion from Tom Lane.

19 years agoRecent changes to allow hash join to exit early given empty input from
Tom Lane [Mon, 28 Nov 2005 17:14:47 +0000 (17:14 +0000)]
Recent changes to allow hash join to exit early given empty input from
one child or the other had a problem: they did not leave the node in a
state that ExecReScanHashJoin would understand.  In particular it would
tend to fail to reset the child plans when needed.  Per report from
Mario Weilguni.

19 years agoSet a snapshot before running analyze on a single table, to avoid a
Alvaro Herrera [Mon, 28 Nov 2005 13:34:10 +0000 (13:34 +0000)]
Set a snapshot before running analyze on a single table, to avoid a
crash when analyzing tables with expressional indexes.

19 years agoAdd missing semicolon. Recent versions of bison seem to choke on this,
Tom Lane [Sun, 27 Nov 2005 01:22:36 +0000 (01:22 +0000)]
Add missing semicolon.  Recent versions of bison seem to choke on this,
per buildfarm report from platypus, even though older versions let it pass.

19 years agoGet rid of ExecAssignResultTypeFromOuterPlan() and make all plan node types
Tom Lane [Wed, 23 Nov 2005 20:28:05 +0000 (20:28 +0000)]
Get rid of ExecAssignResultTypeFromOuterPlan() and make all plan node types
generate their output tuple descriptors from their target lists (ie, using
ExecAssignResultTypeFromTL()).  We long ago fixed things so that all node
types have minimally valid tlists, so there's no longer any good reason to
have two different ways of doing it.  This change is needed to fix bug
reported by Hayden James: the fix of 2005-11-03 to emit the correct column
names after optimizing away a SubqueryScan node didn't work if the new
top-level plan node used ExecAssignResultTypeFromOuterPlan to generate its
tupdesc, since the next plan node down won't have the correct column labels.

19 years agoFix problems with rewriter failing to set Query.hasSubLinks when inserting
Tom Lane [Wed, 23 Nov 2005 17:21:22 +0000 (17:21 +0000)]
Fix problems with rewriter failing to set Query.hasSubLinks when inserting
a SubLink expression into a rule query.  Pre-8.1 we essentially did this
unconditionally; 8.1 tries to do it only when needed, but was missing a
couple of cases.  Per report from Kyle Bateman.  Add some regression test
cases covering this area.

19 years agoHaving blank lines in -f scripts was causing silent failures.
Tatsuo Ishii [Wed, 23 Nov 2005 13:23:34 +0000 (13:23 +0000)]
Having blank lines in -f scripts was causing silent failures.
per David Fetter

19 years agoRe-run pgindent, fixing a problem where comment lines after a blank
Bruce Momjian [Tue, 22 Nov 2005 18:23:31 +0000 (18:23 +0000)]
Re-run pgindent, fixing a problem where comment lines after a blank
comment line where output as too long, and update typedefs for /lib
directory.  Also fix case where identifiers were used as variable names
in the backend, but as typedefs in ecpg (favor the backend for
indenting).

Backpatch to 8.1.X.

19 years agoModify tuptoaster's API so that it does not try to modify the passed
Tom Lane [Sun, 20 Nov 2005 18:38:42 +0000 (18:38 +0000)]
Modify tuptoaster's API so that it does not try to modify the passed
tuple in-place, but instead passes back an all-new tuple structure if
any changes are needed.  This is a much cleaner and more robust solution
for the bug discovered by Alexey Beschiokov; accordingly, revert the
quick hack I installed yesterday.
With this change, HeapTupleData.t_datamcxt is no longer needed; will
remove it in a separate commit in HEAD only.

19 years agoStopgap solution for problem reported by Alexey Beschiokov: after
Tom Lane [Sat, 19 Nov 2005 20:58:42 +0000 (20:58 +0000)]
Stopgap solution for problem reported by Alexey Beschiokov: after
doing heap_insert or heap_update, wipe out any extracted fields in
the TupleTableSlot containing the tuple, because they might not be valid
anymore if tuptoaster.c changed the tuple.  Safe because slot must be
in the materialized state, but mighty ugly --- find a better answer!

19 years agoFix performance issue in exprTypmod(): for a COALESCE expression, it
Tom Lane [Fri, 18 Nov 2005 23:08:13 +0000 (23:08 +0000)]
Fix performance issue in exprTypmod(): for a COALESCE expression, it
recursed twice on its first argument, leading to exponential time spent
on a deep nest of COALESCEs ... such as a deeply nested FULL JOIN would
produce.  Per report from Matt Carter.

19 years agoUpdate Japanese FAQ.
Bruce Momjian [Fri, 18 Nov 2005 00:41:26 +0000 (00:41 +0000)]
Update Japanese FAQ.

J.Kuwamura

19 years agomake psql honor explicit database parameter in -l mode, in case "postgres" database...
Andrew Dunstan [Thu, 17 Nov 2005 23:49:44 +0000 (23:49 +0000)]
make psql honor explicit database parameter in -l mode, in case "postgres" database is missing - per complaint from Philip Yarra.

19 years agoDropRelFileNodeBuffers failed to fix the state of the lookup hash table
Tom Lane [Thu, 17 Nov 2005 17:42:24 +0000 (17:42 +0000)]
DropRelFileNodeBuffers failed to fix the state of the lookup hash table
that was added to localbuf.c in 8.1; therefore, applying it to a temp table
left corrupt lookup state in memory.  The only case where this had a
significant chance of causing problems was an ON COMMIT DELETE ROWS temp
table; the other possible paths left bogus state that was unlikely to
be used again.  Per report from Csaba Nagy.

19 years agomake_restrictinfo() failed to attach the specified required_relids to
Tom Lane [Wed, 16 Nov 2005 17:08:12 +0000 (17:08 +0000)]
make_restrictinfo() failed to attach the specified required_relids to
its result when the clause was an OR clause.  Brain fade exposed by
example from Sebastian BÎck.

19 years agoProperly document return value of strpos().
Bruce Momjian [Wed, 16 Nov 2005 03:56:35 +0000 (03:56 +0000)]
Properly document return value of strpos().

19 years agoHave test_fsync honor -f filename argument.
Bruce Momjian [Wed, 16 Nov 2005 01:31:14 +0000 (01:31 +0000)]
Have test_fsync honor -f filename argument.

19 years agoPrevent certain symbols that are used for both typedefs and variable
Bruce Momjian [Tue, 15 Nov 2005 14:45:14 +0000 (14:45 +0000)]
Prevent certain symbols that are used for both typedefs and variable
names from being added to pgindent's typedef list.  The existance of
them caused weird formatting in the date/type files, and in keywords.c.

Backpatch to 8.1.X.

19 years agoFix recent problems with BSD indent, including indenting past 80
Bruce Momjian [Tue, 15 Nov 2005 01:02:13 +0000 (01:02 +0000)]
Fix recent problems with BSD indent, including indenting past 80
columns, shifting comment to the right when more than 150 'else if'
clauses were used, and update typedefs for 8.1.X.

NetBSD patched updated, with documentation.

19 years agoRestore the former RestrictInfo field valid_everywhere (but invert the flag
Tom Lane [Mon, 14 Nov 2005 23:54:36 +0000 (23:54 +0000)]
Restore the former RestrictInfo field valid_everywhere (but invert the flag
sense and rename to "outerjoin_delayed" to more clearly reflect what it
means).  I had decided that it was redundant in 8.1, but the folly of this
is exposed by a bug report from Sebastian Böck.  The place where it's
needed is to prevent orindxpath.c from cherry-picking arms of an outer-join
OR clause to form a relation restriction that isn't actually legal to push
down to the relation scan level.  There may be some legal cases that this
forbids optimizing, but we'd need much closer analysis to determine it.

19 years agoTranslation typo fix
Alvaro Herrera [Mon, 14 Nov 2005 22:08:29 +0000 (22:08 +0000)]
Translation typo fix

19 years agoRe-run pgindent to fix breakage when exceeding 150 'else if' clauses.
Bruce Momjian [Mon, 14 Nov 2005 17:46:07 +0000 (17:46 +0000)]
Re-run pgindent to fix breakage when exceeding 150 'else if' clauses.

Cosmetic fix only.

19 years agoPrevent ExecInsert() and ExecUpdate() from scribbling on the result tuple
Tom Lane [Mon, 14 Nov 2005 17:43:13 +0000 (17:43 +0000)]
Prevent ExecInsert() and ExecUpdate() from scribbling on the result tuple
slot of the topmost plan node when a trigger returns a modified tuple.
These appear to be the only places where a plan node's caller did not
treat the result slot as read-only, which is an assumption that nodeUnique
makes as of 8.1.  Fixes trigger-vs-DISTINCT bug reported by Frank van Vugt.

19 years agoForce the second argument of SUBSTRING(foo FOR bar) to be int4, to avoid
Tom Lane [Sun, 13 Nov 2005 19:11:45 +0000 (19:11 +0000)]
Force the second argument of SUBSTRING(foo FOR bar) to be int4, to avoid
surprising results when it's some other numeric type.  This doesn't solve
the generic problem of surprising implicit casts to text, but it's a
low-impact way of making sure this particular case behaves sanely.
Per gripe from Harald Fuchs and subsequent discussion.

19 years agoRevert pgindent length back to 79 because we are going to fix the BSD
Bruce Momjian [Sun, 13 Nov 2005 02:42:24 +0000 (02:42 +0000)]
Revert pgindent length back to 79 because we are going to fix the BSD
indent bug.

19 years agoadd missing quote mark to ident_file sample line - per Hiroshi Saito
Andrew Dunstan [Thu, 10 Nov 2005 14:02:59 +0000 (14:02 +0000)]
add missing quote mark to ident_file sample line - per Hiroshi Saito

19 years agoWhen in transaction-aborted state, reject Bind message for portals containing
Tom Lane [Thu, 10 Nov 2005 00:31:40 +0000 (00:31 +0000)]
When in transaction-aborted state, reject Bind message for portals containing
anything but transaction-exiting commands (ROLLBACK etc).  We already rejected
Parse and Execute in such cases, so there seems little point in allowing Bind.
This prevents at least an Assert failure, and probably worse things, since
there's a lot of infrastructure that doesn't work when not in a live
transaction.  We can also simplify the Bind logic a bit by rejecting messages
with a nonzero number of parameters, instead of the former kluge to silently
substitute NULL for each parameter.  Per bug #2033 from Joel Stevenson.

19 years agoFix misspelling of 'listen_addresses', per Devrim.
Tom Lane [Wed, 9 Nov 2005 17:44:15 +0000 (17:44 +0000)]
Fix misspelling of 'listen_addresses', per Devrim.

19 years agoTranslation updates.
Alvaro Herrera [Mon, 7 Nov 2005 02:21:26 +0000 (02:21 +0000)]
Translation updates.

19 years agoTranslation updates.
Alvaro Herrera [Sun, 6 Nov 2005 02:55:16 +0000 (02:55 +0000)]
Translation updates.

19 years agoTag everything for 8.1.0 ... Finally, a relesae on scheduale!! REL8_1_0
PostgreSQL Daemon [Sat, 5 Nov 2005 04:01:57 +0000 (04:01 +0000)]
Tag everything for 8.1.0 ... Finally, a relesae on scheduale!!

19 years agoRepair an error introduced by log_line_prefix patch: it is not acceptable
Tom Lane [Sat, 5 Nov 2005 03:04:53 +0000 (03:04 +0000)]
Repair an error introduced by log_line_prefix patch: it is not acceptable
to assume that the string pointer passed to set_ps_display is good forever.
There's no need to anyway since ps_status.c itself saves the string, and
we already had an API (get_ps_display) to return it.
I believe this explains Jim Nasby's report of intermittent crashes in
elog.c when %i format code is in use in log_line_prefix.
While at it, repair a previously unnoticed problem: on some platforms such as
Darwin, the string returned by get_ps_display was blank-padded to the maximum
length, meaning that lock.c's attempt to append " waiting" to it never worked.

19 years agoAdd mention to update FAQ item on most recent release to RELEASE_CHANGES.
Bruce Momjian [Sat, 5 Nov 2005 01:38:44 +0000 (01:38 +0000)]
Add mention to update FAQ item on most recent release to RELEASE_CHANGES.

19 years agoUpdate FAQ for most recent release as 8.1.
Bruce Momjian [Sat, 5 Nov 2005 01:35:18 +0000 (01:35 +0000)]
Update FAQ for most recent release as 8.1.

19 years agoYet another supported-platforms update.
Tom Lane [Sat, 5 Nov 2005 00:04:04 +0000 (00:04 +0000)]
Yet another supported-platforms update.

19 years agoEditorial review for partitioning/constraint exclusion documentation.
Tom Lane [Fri, 4 Nov 2005 23:53:18 +0000 (23:53 +0000)]
Editorial review for partitioning/constraint exclusion documentation.

19 years agoImprove description of constraint_exclusion variable.
Tom Lane [Fri, 4 Nov 2005 23:50:30 +0000 (23:50 +0000)]
Improve description of constraint_exclusion variable.

19 years agoTranslation updates
Peter Eisentraut [Fri, 4 Nov 2005 23:31:12 +0000 (23:31 +0000)]
Translation updates

19 years agoSpellchecking run, final cleanups
Peter Eisentraut [Fri, 4 Nov 2005 23:14:02 +0000 (23:14 +0000)]
Spellchecking run, final cleanups

19 years agoUpdate release notes for 8.1.
Bruce Momjian [Fri, 4 Nov 2005 22:21:33 +0000 (22:21 +0000)]
Update release notes for 8.1.

19 years agoRemove a gratuitous string difference (does not affect translations).
Peter Eisentraut [Fri, 4 Nov 2005 22:19:04 +0000 (22:19 +0000)]
Remove a gratuitous string difference (does not affect translations).

19 years agoFix logical error in option description.
Peter Eisentraut [Fri, 4 Nov 2005 22:18:26 +0000 (22:18 +0000)]
Fix logical error in option description.

19 years agoEnsure that we only create one ConsoleCtrlHandler per psql process,
Tom Lane [Fri, 4 Nov 2005 18:35:40 +0000 (18:35 +0000)]
Ensure that we only create one ConsoleCtrlHandler per psql process,
so as to avoid performance issues and possible ultimate crash on long
psql scripts.  Per Merlin Moncure.

19 years agoWe haven't seen any agreement emerge as to what is causing AIX 5.3 ML3
Bruce Momjian [Fri, 4 Nov 2005 18:16:50 +0000 (18:16 +0000)]
We haven't seen any agreement emerge as to what is causing AIX 5.3 ML3
to fail to successfully build the release candidates.

However, a patch has emerged (thanks, Seneca!) that does allow it to
work, and which I'd expect to be portable (better still!).

We are still actively pursuing why it breaks, but supposing that still
remains outstanding, at least the following would allow AIX users to
better survive a build...

Chris Browne

19 years agoDisregard superuserness when checking to see if a role GRANT would
Tom Lane [Fri, 4 Nov 2005 17:25:15 +0000 (17:25 +0000)]
Disregard superuserness when checking to see if a role GRANT would
create circularity of role memberships.  This is a minimum-impact fix
for the problem reported by Florian Pflug.  I thought about removing
the superuser_arg test from is_member_of_role() altogether, as it seems
redundant for many of the callers --- but not all, and it's way too late
in the 8.1 cycle to be making large changes.  Perhaps reconsider this
later.

19 years agoUpdate supported-platforms list.
Tom Lane [Fri, 4 Nov 2005 16:15:20 +0000 (16:15 +0000)]
Update supported-platforms list.

19 years agoAvoid referring to a specific version of the SQL standard except where
Tom Lane [Fri, 4 Nov 2005 02:56:31 +0000 (02:56 +0000)]
Avoid referring to a specific version of the SQL standard except where
necessary, and be careful to refer to the right version where it is
useful to do so.  This partially reverts an ill-considered search and
replace from a few months ago.

19 years agoFix a couple of missed None -> DestNone in comments.
Tom Lane [Thu, 3 Nov 2005 21:35:57 +0000 (21:35 +0000)]
Fix a couple of missed None -> DestNone in comments.

19 years agoFix one overlooked ocurrence of "None" in EXEC_BACKEND block.
Alvaro Herrera [Thu, 3 Nov 2005 20:02:50 +0000 (20:02 +0000)]
Fix one overlooked ocurrence of "None" in EXEC_BACKEND block.

19 years agoFix incorrect header size macros
Teodor Sigaev [Thu, 3 Nov 2005 18:16:31 +0000 (18:16 +0000)]
Fix incorrect header size macros

19 years agoThinking further, it seems we had better also copy down resorigtbl/resorigcol
Tom Lane [Thu, 3 Nov 2005 17:45:29 +0000 (17:45 +0000)]
Thinking further, it seems we had better also copy down resorigtbl/resorigcol
to ensure that SubqueryScan elimination doesn't change the behavior of
reporting of original column sources.

19 years agoFix the recently-added code that eliminates unnecessary SubqueryScan nodes
Tom Lane [Thu, 3 Nov 2005 17:34:03 +0000 (17:34 +0000)]
Fix the recently-added code that eliminates unnecessary SubqueryScan nodes
from a finished plan tree.  We have to copy the output column names
(resname fields) from the SubqueryScan down to its child plan node;
else, if this is the topmost level of the plan, the wrong column names
will be delivered to the client.  Per bug #2017 reported by Jolly Chen.

19 years agoRename the members of CommandDest enum so they don't collide with other uses of
Alvaro Herrera [Thu, 3 Nov 2005 17:11:40 +0000 (17:11 +0000)]
Rename the members of CommandDest enum so they don't collide with other uses of
those names.  (Debug and None were pretty bad names anyway.)  I hope I catched
all uses of the names in comments too.

19 years agoTranslation updates.
Alvaro Herrera [Thu, 3 Nov 2005 17:00:54 +0000 (17:00 +0000)]
Translation updates.

19 years agopgcrypto documentation polishing from Marko Kreen, and a small amount
Tom Lane [Thu, 3 Nov 2005 02:54:07 +0000 (02:54 +0000)]
pgcrypto documentation polishing from Marko Kreen, and a small amount
of copy-editing from myself.

19 years agoSome minor improvements to the CE docs. Also fix a bit of SGML markup
Neil Conway [Thu, 3 Nov 2005 00:51:43 +0000 (00:51 +0000)]
Some minor improvements to the CE docs. Also fix a bit of SGML markup
elsewhere.

19 years agoFix longstanding race condition in transaction log management: there was a
Tom Lane [Thu, 3 Nov 2005 00:23:36 +0000 (00:23 +0000)]
Fix longstanding race condition in transaction log management: there was a
very narrow window in which SimpleLruReadPage or SimpleLruWritePage could
think that I/O was needed when it wasn't (and indeed the buffer had already
been assigned to another page).  This would result in an Assert failure if
Asserts were enabled, and probably in silent data corruption if not.
Reported independently by Jim Nasby and Robert Creager.

I intend a more extensive fix when 8.2 development starts, but this is a
reasonably low-impact patch for the existing branches.

19 years agoAdd Tomoaki Sato to pgbench changes in release notes.
Bruce Momjian [Wed, 2 Nov 2005 14:08:43 +0000 (14:08 +0000)]
Add Tomoaki Sato to pgbench changes in release notes.

19 years agoAdd some documentation for constraint exclusion and basic partitioning.
Neil Conway [Tue, 1 Nov 2005 23:19:05 +0000 (23:19 +0000)]
Add some documentation for constraint exclusion and basic partitioning.
From Simon Riggs; cleanup and editorialization by Neil Conway.

19 years agoMake an editorial pass over the reference pages.
Tom Lane [Tue, 1 Nov 2005 21:09:51 +0000 (21:09 +0000)]
Make an editorial pass over the reference pages.