LinGui: add audio gain adjustment and create advanced audio dialog.
Gain, DRC, and Sample Rate are now in an advanced audio dialog.
This makes the audio tab less crowded and makes room for future
improvements.
Add audio gain adjustment to libhb and CLI
New CLI option is --gain <float>. Value is measured in dB. Negative values are
quieter, positive values are louder.
Start mkv clusters with a video keyframe whenever possible
libmkv now starts a new cluster whever there is a video keyframe if
the new cluster would not be closer than 2 seconds to the previous cluster.
Fix the volume output level of our dts decoder
dcadec returns samples that have values in the range -1.0 to 1.0.
We need these to be converted to the range -32768 to 32767. For some
reason, decdca was scaling by 16768 instead of 32767. This has been
like this since dts support was initially added by maurj.
Make logging of audio and subtitle id's more consistant
1) whenever we log audio->id or subtitle->id using hex formatting, precede
the hex with 0x (which was already done in some places but not others)
2) format audio->id as hex instead of decimal in sync.c (makes it much easier
to see which track "went backwards" or had silence added to it, checking
the job configuration logged by work.c)
Shorten instead of dropping overlapping subtitles in mp4
If the non-overlaping remainder is greater than 0.5 seconds, shorten
the subtitle instead of completely dropping it.
Flush ffmpeg codec buffers after every seek.
According to several e-mails I've read on ffmpeg-devel, avcodec_flush_buffers
should be called after any seek. It appears this is even more critical to do
when using frame based multi-threading. I don't see any immediate difference
in functionality by adding this, but it may prevent surprises in the future.
Forome reason, frames that are tagged as recovery points in many BD h.264
streams do not result in complete frames when decoded. Pushing 2 extra
frames through the decoder seems to always fix this. This patch extends
something I was already doing when generating previews from a BD structure.
This just applies the same logic to ffmpeg streams that have h.264 video.
jstebbins [Thu, 31 Mar 2011 00:05:23 +0000 (00:05 +0000)]
True SSA passthru for MKV.
We were converting SSA to UTF8 subs which looses a lot of formatting.
Now we pass through the ssa unmodified and add all fonts as attachments
to the mkv.
davidfstr [Wed, 30 Mar 2011 02:50:42 +0000 (02:50 +0000)]
MP4 muxer ignores all but the first of overlapping UTF-8 subtitles.
This is necessary because MP4 does not support overlapping subtitles. Attempting to use overlapping subtitles causes the display of subsequent subtitles to be delayed incorrectly.
Subsequent patches may merge UTF-8 subtitles (upstream) so that this case does not occur.
jstebbins [Tue, 29 Mar 2011 22:43:07 +0000 (22:43 +0000)]
Fix chapter passthru problems with some files.
If the video stream is not the first track in the file, chapters were lost.
During scan, we identify which track is video and stash this in title.
While reading, when a chapter is found we want to tag the next video buffer.
But the video track id stored in the title was not being applied when
opening the file for reading, so the chapter mark always went on track id 0.
dynaflash [Tue, 29 Mar 2011 17:55:25 +0000 (17:55 +0000)]
MacGui: Never disable the chapter markers checkbox.
Patch by Rodeo ... Thanks!
- Discussed here https://reviews.handbrake.fr/r/58/
This allows users to enable/disable chapter markers regardless of whether the source has chapters, which is very useful when saving a preset.
This will not cause chapter markers to be inserted if we only have one chapter, as this is sanitized twice:
- once in macosx/Controller.m, in createQueueFileItem
- once in libhb/work.c, in do_job()
In autoSetM4vExtension, update the condition for chapter markers being on or off, since we can no longer rely on the checkbox being enabled/disabled.
jstebbins [Mon, 28 Mar 2011 17:47:21 +0000 (17:47 +0000)]
Fix problem with qt7 playback of mpeg4 video
The reference frames were not being tagged correctly during muxing
which really screwes up qt7 but appears to have little effect on qtx
or other players.
sr55 [Sun, 27 Mar 2011 13:52:36 +0000 (13:52 +0000)]
WinGui:
- Remove built-in quicktime based video preview support.
- Resigned the Preview window as a result. Currently only supports VLC launching, but will later add an option to use the systems default player for the format produced.
jstebbins [Tue, 22 Mar 2011 02:25:05 +0000 (02:25 +0000)]
LinGui: use g_object_set to set widget properties
instead of directly setting the member variables. The member variables
dissepear into priv data in gtk+-3.0.
jstebbins [Tue, 22 Mar 2011 01:08:37 +0000 (01:08 +0000)]
LinGui: No need to call gtk_set_locale
gtk_init does it for us. And since gtk_set_locale is being removed
from gtk+-3.0, might as well remove the call.
jstebbins [Mon, 21 Mar 2011 18:14:04 +0000 (18:14 +0000)]
Fix linking on mingw when using libtool
Linking the gtk gui uses libtool. The *.la files libtool uses specify
the dependency libraries that libraries are built against. Our
libbluray contrib was being built against the system libxml2 due to
dependencies that were not set in our build system and PKG_CONFIG_PATH
not being set when configuring.
Note that on fedora (and possibly other systems) the ${cross}-pkg-config
script provided is broken and explicitely sets PKG_CONFIG_PATH="". You
need to replace this script with something like this:
PKG_CONFIG_LIBDIR=$(${cross}-gcc --print-sysroot)/mingw/lib/pkgconfig pkg-config $*
jstebbins [Mon, 21 Mar 2011 02:20:48 +0000 (02:20 +0000)]
Remove legacy % to RF mapping.
Although the % option has been gone for a while in the cli and gui's,
there were some mappings happening in libhb and for preset imports.
This removes the last vestages of % quality mapping.
Thanks to Rodeo for the patch.
jstebbins [Sun, 13 Mar 2011 21:51:14 +0000 (21:51 +0000)]
fix 2 pass cfr x264 crash
An error in interjob->vrate calculation lead to specifying a different
timebase for the 1st and 2nd pass which x264 does not allow. This
improves the interjob->vrate calculation accuracy and also guarantees
the timebase is the same on both passes regardless of the calculations
accuracy.
jstebbins [Sun, 13 Mar 2011 17:14:36 +0000 (17:14 +0000)]
Fix source dimensions problem with some mpeg2 streams
Was using the incorrect field for actual "display" dimensions of video.
The field I was using is most often used for pan and scan which
crops a 16:9 image to fit a 4:3 display.
jstebbins [Fri, 11 Mar 2011 22:40:30 +0000 (22:40 +0000)]
Add parameter parsing and b-frame support to ffmpeg mpeg-4 encoder
The cli will now accept ':' separated parameters using the '-x' option
for ffmpeg mpeg-4. The linux gui has an entry box on the advanced tab
to add options. The option keys and values are the same as what the
ffmpeg command line allows.
Calculation of DTS timestamps was added to encavcodec.c in order to allow
out of order b-frames. The algorithm is similar to what x264 uses.
jstebbins [Fri, 11 Mar 2011 22:09:18 +0000 (22:09 +0000)]
Fix PAR and height of mpeg-2 1080 content.
mpeg-2 dimensions must be multiples of 16, so the actual coded height
is 1088. But there are fields in the sequence header that define
the "display" height and width. We were ignoring these which lead
to slightly incorrect height and PAR.
jstebbins [Fri, 11 Mar 2011 15:26:31 +0000 (15:26 +0000)]
Fix mkv timestamps that derive from SimpleBlock and default track duration.
Since I've gotten no response to this patch yet on ffmpeg-devel, I'm
committing it here till someone has the time to look at it.
When a SimpleBlock has lacing (multiple frames in a block) the duration
of each frame should come from the default track duration. An initialization
error in ffmpeg causes them to set the duration to 0 which triggers
code higher in the stack to estimate the duration based on bitrate
and frame size. This is wildly inaccurate and leads to very bad timestamps.
jstebbins [Thu, 10 Mar 2011 23:34:08 +0000 (23:34 +0000)]
Use ffmpeg's lock manager for locking needed by ffmpeg
This lets ffmpeg tell us when it needs a lock instead of
us trying to guess which functions we need to wrap in a mutex.
jstebbins [Tue, 8 Mar 2011 17:05:34 +0000 (17:05 +0000)]
Remove a workaround for an ffmpeg bug that has been fixed.
Removal of the workaround also removes the need for a patch
that fails to apply cleanly to latest ffmpeg git. So remove
the patch as well.
jstebbins [Tue, 8 Mar 2011 16:12:57 +0000 (16:12 +0000)]
make keyint match between 1st and 2nd passes of vfr and pfr encodes.
make keyint and fps settings consistent across video encoders.
make interjob->vrate changes for pfr mode like we do for vfr since
pfr is the same as vfr except when it hits it's peak.
in mkv, set track default duration to actual measured vrate on 2 pass encodes.
sr55 [Sun, 6 Mar 2011 15:43:37 +0000 (15:43 +0000)]
WinGui:
- Another change to the video tab to make it consistent with the lingui.
- Fix for the Audio Panel to correctly set the default bit-rate for each encoder.
sr55 [Fri, 4 Mar 2011 21:30:37 +0000 (21:30 +0000)]
WinGui:
- Updated layout of the "Video" tab to empathises Constant Quality.
* Added far better tooltips on the controls.
- Added better control over the encoding methods (VFR, PFR, CFR)
* "Same as source" can now be Constant or Variable
* "5,10,15,20....." framerates can now be set as WConstant Framerate" or "Peak Framerates (VFR)"
dynaflash [Tue, 1 Mar 2011 18:45:17 +0000 (18:45 +0000)]
MacGui: Remove Target Size as a rate control option as it doesn't really work correctly and should die an overdue death.
- Also rearranged the video quality layout a bit.
- Moved Constant Quality above Average Bitrate
- Moved the entire Video Quality matrix down below frame rate where it belongs.
- Presets are mapped accordingly internally in the macgui code so that they are unchanged across platforms.
jstebbins [Mon, 28 Feb 2011 22:00:26 +0000 (22:00 +0000)]
Fix PFR issue where there are different number of frames in 1st and 2nd pass.
Waiting for a fill threshhold in the fifos causes some non-determinism
in finding the first PTS value. Sometimes the fill level of one fifo
would not be reached until after another fifo is completely full, causing
an early exit in the loop that looks for the first PTS. When the initial PTS
is different between passes, the duration of the first frame is different.
This affects the PFR algorithm and can cause it to drop a different number
of frames.
The fill level was initially intended as a way to prevent thrashing between
threads to improve performance. But my testing indicates no degradation
when removing it.
davidfstr [Fri, 25 Feb 2011 01:08:33 +0000 (01:08 +0000)]
Add temporally overlapping subtitle support.
* New subtitle sync algorithm added to sync work-object ("simultaneous").
Classic algorithm preserved but disabled.
* Render work-object now supports queueing a /list/ of subtitles.
* FIFOs have been extended to support pushing/popping buffer-lists as single elements.
* Added SUBSYNC_VERBOSE_TIMING flag to debug timing issues related to subtitle display.
Observable behaviors changed in the new subtitle sync algorithm:
* Temporally overlapping subtitles are no longer trimmed to be non-overlapping.
* Subtitles less than two seconds long are no longer artificially extended. Sorry, Indochine fans.
* Subtitles that stop before they start will never be displayed. The old algorithm will display such subtitles if they begin in the future (relative to the current video frame being processed).
projects / handbrake / log