jbrjake [Mon, 13 Aug 2007 18:14:28 +0000 (18:14 +0000)]
MacGui: nerfs the presets, as collapsible triangle folder thingies are waiting for the next release. Also adds one for CRF (shamelessly ripped from Sharktooth's CQ-ASP_Q2_eq(crf) profile for MEGui.) Hopefully I watered the presets down enough, but who knows...they might still encode too slowly for the masses.
dynaflash [Mon, 13 Aug 2007 17:02:37 +0000 (17:02 +0000)]
MacGui: Detelecine initial implementation
- Added -VideoFramerateChanged method to controller.mm to detect NTSC Film content to error check detelecine.
- Auto detected or manually choosing 23.967 (NTSC Film) disables detelecine checkbox in the picture preview window.
jbrjake [Mon, 13 Aug 2007 16:14:06 +0000 (16:14 +0000)]
"Same as source" changes. Old behavior: mark all NTSC content as 23.976. New behavior: mark all NTSC content as 29.97, only use 23.976 when scanning shows a title reporting itself as mostly progressive.
Also threw in a bunch of commented out logging messages for diagnostic usage.
And notification during encodes when progressive flags go on or off (only works in jam builds until the contrib binary packs get rebuilt).
jbrjake [Fri, 10 Aug 2007 21:47:23 +0000 (21:47 +0000)]
MacGui: modifies some presets.
- Removes "HB-" from the preset names.
- Adds Broke preset for people who still encode to CD size.
- Adds Blind preset for people who want an encode done *right now*.
- Adds Deux Six Quatre preset with commonly found x264 settings.
- Changes iPhone preset audio bitrate to 128 (160 is incompatible, unlike on the iPod).
- Applies turbo to all existing presets that used 2-pass.
- Switches the Animation and Television presets to use "Same as source" fps.
jbrjake [Mon, 6 Aug 2007 21:05:50 +0000 (21:05 +0000)]
Display thread IDs in hb_log messages with %x instead of %d, so they aren't negative numbers in 32-bit Ubuntu (and maybe other places). Thanks for the suggestion, mr_cheese_.
sr55 [Sat, 4 Aug 2007 16:00:30 +0000 (16:00 +0000)]
WinGui:
- Readded a bit of code that was accidentally removed in the last commit.
- Removed some old error handling code that is no longer required.
- Set frmReadDVD to always display on top
dynaflash [Fri, 3 Aug 2007 14:54:51 +0000 (14:54 +0000)]
MacGui: Send to MetaX upon completion preference initial implementation.
- Thanks Rodney (MetaX dev)!
- Default is off
- Upon completion of encode, if checked in prefs, HB will send the finished movie to MetaX for meta tagging.
- currently only sends a single encode. If using the queue, will send the last job in the queue only.
- In talking to Rodney some work might have to be done on the MetaX side if we ever want to be able to send an entire queue to MetaX all at once.
jbrjake [Fri, 3 Aug 2007 05:39:51 +0000 (05:39 +0000)]
Tip: Never ever use the PPC include directory when building the Mac contribs.
Mac OS X contrib version ++ to 0017.
This'll fix anamorphic width on x86. Thanks to Ritsuka for isolating the problem and saintdev for explaining it to me in small words I could understand.
dynaflash [Thu, 2 Aug 2007 05:11:48 +0000 (05:11 +0000)]
MacGui: Use Ritsuka's gear icon at the bottom of the preset drawer.
- Thanks Ritsuka!
- Replaces fugly "Make Default" and "Update" buttons
- Contains a contextual menu which currently contains "Make Default" and "Update Built-In Presets"
jbrjake [Wed, 1 Aug 2007 17:13:36 +0000 (17:13 +0000)]
Implements libswscale in HandBrake, giving it Lanczos scaling! This major enhancement comes to us courtesy of superdump, who deserves much praise and glory. To make this work, ffmpeg's been updated to a recent revision.
Darwin contrib binary pack ++ to 0016. Includes fresh ffmpeg and libswscale as well as the recently-patched libmp4v2.
I've also added the configure option --disable-sdl to libmpeg2 in the contrib/Jamfile, because without it jam always fails for me and I'm sick of adding it in every time. Hopefully this doesn't break anything for anyone, but if it does it's just a one-word change.
dynaflash [Wed, 1 Aug 2007 15:55:33 +0000 (15:55 +0000)]
MacGui: Fix broken progress bar when selecting a non existing row in the Presets NSTableView
- bug was introduced on a recent checkin.
- Thanks gbooker for the patch and bringing it to our attention!
MacGui: New deinterlace initial implementation
- Replace old deinterlace checkbox with NSPopUp Button
New Settings:
- None: No deinterlacing
- Fast: Original HB deinterlacing
- Slow: Yadif Mode 1
- Slower: Yadif and Mcdeint
- Slowest: Yadif and Mcdeint
Presets still work, any old one will use None or Fast above. New ones will accurately reflect the correct choice.
Note: need to determine if the preview is still reflecting deinterlacing on or off.
WinGui:
- New deinterlace options done.
- Place holders for deblock denoise and detelecine ready.
- Picture Settings and Video Settings tabs re-arranged slightly.
WinGui:
- Few queue bugs fixed.
- Active queueing now works properly. Items can be added on the fly. DVD's can be scanned on the fly while the there is an encode process already going etc.
- Fixed a potential unhandled exception in the DVD information window.
MacGui: Fixed a minor bug where selecting the HB factory supplied default preset (currently HB-Normal) as your user specified preset would not make it bold until next launch.
MacGui: Add Update button to bottom of presets drawer
- Same as "Update Built In Presets" in the main menu
- as per jbrjake, those buttons could use a redo
- function over form, I always say :)
MacGui: Preset cropping
- forgot to add the code to revert autocropping back to on and set values if "Source Maximum" was set for a preset in previous commit :)
MacGui: Enhanced Picture Settings in Presets (esp. cropping)
When creating a preset, three choices exist for picture settings:
- None: Preset has no effect on any picture settings
- Current: Preset will apply whatever picture settings were in effect at the time the preset was created (including deinterlace, par and *cropping)
- Source Maximum (post scan): Preset will apply the maximum picture settings for each source and auto crop (basically the same picture settings that were in effect right after the source scan and nothing was modified with auto cropping enabled) Anamorphic and Deinterlace will be set according to general preferences
- * Note on cropping with Current set for preset: If cropping was set to "Auto" at the time the preset was created, the preset will then use the sources auto crop values. If, however the cropping was set to "Custom" at the time the preset was created the preset will apply the custom cropping values to each source from when the preset was created.
MacGui: Default Presets Initial Implementation
- Allows user to set a given preset as a default which will be used upon launch. As well, if user has not specified a preset as the default, HB will use the "HB - Normal" Built-in Preset at launch.
- Added the "Make Default" button at the bottom of the Presets Drawer.
- Default Preset is shown in Bold in the Presets Drawer
- Added a Select Default Preset command to the "Presets" Menu in the Menu Bar.
-- Note: the buttons and other display stuff is not set in stone, once again, initial function over form on intitial implementation.
MacGui: Added "Put Computer to Sleep" and "Shut Down Computer" to the notifications when encode is done.
- Thanks hawkman!
- In ComboBox, left only the original selections visible unless you scroll down.
- When one of these is selected, especially shutdown computer, we might want to post an alert when you start encoding to remind you that HB will shut down your computer when it done.
MacGui: Add the Disc icon for the toolbar that I forgot in the last commit :(
- changed the NSTimer for UpdateUI from .2 to .5 which should alleviate a bit of the gui's overhead and HB can use all of the cpu cycles it can get.
MacGui: Add a "Source" icon to the toolbar
- Replaces the old "Browse" button that was in the Source section of the main window
- For now, uses a Disc icon from the icon developer Matt Ball. Should get replaced with something less "Disc-centrict" as we can now use Transport Streams as a source.
- Thanks hawman for this one !
This huge patch from huevos_rancheros ports a number of video filters from mencoder to HandBrake: yadif+mcdeint, hqdn3d, pp7, and pullup+softskip+harddup. What this means is that HB now has stateless inverse telecine, temporal denoising, and motion-adaptive deinterlacing!
We don't need to write end times for chapters, these are automatically calculated figured out from the beginning of the next chapter.
Also, start at display strings at 'Chapter 01' instead of 'Chapter 00'.
MacGui: adds advanced x264 option widgets for analyse, 8x8dct, and, just for eddyg, cabac.
Been awhile since I added any of these; hopefully I didn't break anything in the process.
God do we need to split these and the presets off to separate source files.
WinGui:
- Disabled Encode progress on GUI Window. CLI now allowed to appear and standard error is no longer re-directed. (BUG: Standard error causing video distortions when used)
- If scanning a Source fails, the GUI will now attempt to scan the title a 2nd time automatically. Same issue, Standard error causing hbcli to randomly fail.
MacGui: Integrate Source Scanning into Main Window and permanently disable DVD Drive Auto Detect
- Choose DVD directly if necessary out of the Browse window
- No longer use sheets to show scan progress
- Added Scan Progress bar under Source section of main window
- Removed the "Browse" button in source section in anticipation of a "Source" icon in Toolbar
- For now, use File -> Select Source in Main Menu to get a new source (used to be "Select DVD"). Note: this is the same as 0.7.1
- Removed disable dvd auto detect from the prefs nib
This patch from eddyg should help alleviate HandBrake's audio drop issues. It also adds a number of beautiful comments to sync.c that really help clarify the code. Thanks, eddy!
MacGui: Change sizing of Presets drawer back from last commit
- move + and - buttons back as well
- Change "Debug" window in main menu to new name "Activity Window".
MacGui: "Ritsuka Bar" toolbar initial implementation
- Thanks goes to Ritsuka!
- Moves the Start/Cancel, Pause/Resume, Presets Drawer and Activity Window (previously debug) controls into a nice toolbar at the top of the main window
- Resizes the height of the main window to allow for the progress bar at the bottom during encoding
- Small change in that now muxmkv.c is included in the xcode project under libhb resources. Instead of under the main project heading.
Ok, this should fix compilation. Instead of using the 2-letter language code for "Unknown" (which is a blank string) I've set it to use the 3-letter code ("und" for undetermined). There could easily be a better way to do this. C strings are not my forte.
WinGui:
- Splash screen added. (Bit of a hack but will work until such time it can be done properly)
- Added temporary splash screen image.
- Disbaled cancel button on frmReadDVD until such time it can be coded.
- HB-Normal (a new default, not yet active)
- HB-Classic (the default up until now)
- HB-QuickTime
- HB-Film
- HB-Television
- HB-Animation
- HB-Bedlam (maxed out settings, crazier than MeGUI's HQ-Insane)
- HB-iPhone
Also touched up some of the existing ones' descriptions and increased the motion estimation and subpixels for the PS3.
WinGui:
- Fixed one cross-threading bug with a dirty hack. This will need to be sorted out properly later.
- Added cancel button place holder on frmReadDVD. (will be used for instances where hbcli stalls or crashes)
- Fixed a few Design issues with windows appearing with the wrong dimensions.
- Updated some comments about bugs that need fixed.
WinGui:
- Automatically disable options which are H.264 only when a non H.264 encoder is selected. (Instead of annoying alerts)
-Trimed the size of the GUI down a bit. Slight re-arrange on the Video Settings tab.
- Initial Debug window. Still to be written.
WinGui:
- Updated some tooltips for the main items on frmMain
- Created a Debug window.
- Added comments relating to a cross-thread bug with frmDvdInfo
- A few other code small code tweaks
Speeds up the make build process in OS X by removing Instant HandBrake from the default make. To still build IHB, do "make all-chunky". I also added a "make test" for OS X that only builds HandBrakeCLI, because it saves me quite a bit of time when debugging.
These hopefully-innocuous changes to hb.c should help with the active queuing in the MacGui. Adds a new counter variable, h->job_count_permanent, so the task list readout ("Encoding job x of y") stays correct even if the user adds or removes items on the jobs list during an encode. Seems to work ok for me and Dynaflash, but who knows? This might need to be reverted, and/or maybe someone can come up with a less hackish way of doing it.
WinGui:
misc UI control placement changes
updates to some FormBorderStyle's
converted Parsing code to use regex instead of substrings and string splitting
added a couple of additional code comments
WinGui:
- Changed the progress bar on frmReadDVD to a text value. Progress bar wasn't really needed here.
- Few design tweaks to the frmReadDVD window.
WinGui:
added OnScanProgress event to Parser class which is raised upon noticing "Scanning title # of #..." in the output
added progress bar to frmReadDVD to give better visual notification of scan progress
projects / handbrake / log