Greg Stein [Fri, 2 Nov 2001 19:25:50 +0000 (19:25 +0000)]
Don't change the type of the new resource. The provider will update it
when the copy/move takes place.
Specifically, the new location might imply a different type from the
original, so updating the type is bad mojo. In the observed case, a
resource was copied into a working collection; the type of the new
resource is supposed to be WORKING. Copying the type would be wrong if
the source was REGULAR.
Make this a bit more formal, as in httpd.conf. Also should cite the
contributor, but only Ralf knows who all should be the primary citation,
if not simply "the modssl project". I don't know if this conf is all
new material, significantly created by the modssl project, or if much
of it goes all the way back to ApacheSSL. Rather that miss-attribute,
I'm leaving line one for someone else [Ralf?] to add, vis-a-vie the
citation in httpd-std.conf line 2.
Roy T. Fielding [Thu, 1 Nov 2001 00:05:58 +0000 (00:05 +0000)]
Since we are in a file that is only included with mod_ssl.c and
there is no point in any of it if SSL is not defined, just wrap
the whole thing in one IfDefine.
Greg Ames [Wed, 31 Oct 2001 21:14:23 +0000 (21:14 +0000)]
change ap_getline to return the size of the buffer when there's no apparent end
to an input line. This is more like the 1.3 behavior which should help the
callers recognize this condition.
Greg Ames [Wed, 31 Oct 2001 20:18:56 +0000 (20:18 +0000)]
return the actual number of bytes read when we're in "read a line" mode and it
looks like the line may never end.
This lets ap_getline determine whether there's excessive bytes or not,
depending on the size of its caller's buffers. If the buffer can accomodate
more bytes, ap_getline will continue to read.
Aaron Bannert [Wed, 31 Oct 2001 18:21:53 +0000 (18:21 +0000)]
Fix a big memory leak bug related to arbitrarily large header lines.
The core input filter would happily consume all the data you gave it
in a header line, looking for that one LF. This patch limits that
"getline" functionality to HUGE_STRING_LEN (8192 bytes).
Joshua Slive [Sat, 27 Oct 2001 22:22:00 +0000 (22:22 +0000)]
Fix some broken links, change to the simplest possible example, and add a
couple notes to give hints to people running servers behind port-forwarding
firewalls.
Jeff Trawick [Sat, 27 Oct 2001 14:01:13 +0000 (14:01 +0000)]
make shared libraries executable so they work on HP-UX
(I'm not sure that this logic for copying DSOs will survive
in the libtool scheme; I'm putting this 1.3 fix in just in
case.)
Fix RedirectMatch handling to properly handle URLs with host portions.
Previously, we would segfault if no path is specified (case 1 below).
We would also ignore any host and scheme portion of the URL (which is
how we specify it on daedalus), so restore that capability.
The query strings will still not be escaped (standards cops can
determine if this is correct behavior).
The following directives now work as expected:
RedirectMatch /jakarta1(.*) http://jakarta.apache.org$1
RedirectMatch /jakarta2(.*) http://jakarta.apache.org/dist$1
RedirectMatch /jakarta3(.*) http://jakarta.apache.org/dist$1?bar=foo
RedirectMatch /jakarta4(.*) http://jakarta.apache.org/dist$1?bar=foo#spaz
Greg Ames [Fri, 26 Oct 2001 15:40:04 +0000 (15:40 +0000)]
prevent seg faults in mod_status trying to access vhost structures from
the former generation, after a restart. It happens mostly when the MPM has
threads.
Aaron Bannert [Wed, 24 Oct 2001 17:20:44 +0000 (17:20 +0000)]
Two more mod_so configure-time fixes:
- Treat --enable-so=yes as "static" (this includes --enable-so, etc).
- An explicit --enable-so=shared issues an error.
Put in a note about the last condition that I'm not as sure how to fix:
If the user doesn't explicitly request mod_so, but instead gives a
mass-enable parameter like --enable-modules=most or
--enable-mods-shared=most then it is still possible to enable a bunch
of modules while mod_so itself is not buildable (ie no APR_HAS_DSO or
other build dependency failure).
Aaron Bannert [Tue, 23 Oct 2001 23:13:27 +0000 (23:13 +0000)]
If the user explicitly requests --enable-so, --enable-so=yes,
--enable-so=static, or --enable-so=shared but APR_HAS_DSO is
not defined on their system, then it is a fatal error.
Tested on Solaris, but I think it should work everywhere else.
Feel free to change the error message to something
better/more descriptive/etc.
Bill Stoddard [Tue, 23 Oct 2001 17:13:26 +0000 (17:13 +0000)]
Win32: Track and display "Parent Server Generation:" in
mod_status output. The generation will be bumped at
server graceful restart, when the child process exits
by hitting MaxRequestsPerChild or if the child
process exits abnormally. [Bill Stoddard]
Cliff Woolley [Tue, 23 Oct 2001 09:41:54 +0000 (09:41 +0000)]
Fix a segfault seen on daedalus earlier this evening. All that was happening
was that we forgot to check whether ctx->bb was empty, so when we pulled the
first bucket, it would be the sentinel, and we'd segfault trying to apr_bucket_read
the sentinel.
Jeff Trawick [Mon, 22 Oct 2001 13:04:12 +0000 (13:04 +0000)]
Fix some bungling of the remote port in rfc1413.c so that
IdentityCheck retrieves the proper user id instead of failing
and thus always returning "nobody."
Submitted by: Dick Streefland <Dick.Streefland@xs4all.nl>
Reviewed by: Jeff Trawick
Simplified mod_env's directives to behave as most directives are
expected, in that UnsetEnv will not unset a SetEnv and PassEnv
directive following that UnsetEnv within the same container.
Also provides a runtime startup warning if a PassEnv configured
environment value is undefined.
Restrict by content type and encoding before we go and try to drag in some
text to merge as headers and footers to autoindex pages. This will escape
index.gif from a bold attempt to use IndexHeader index ;)
Also pass in the args to the subrequest, for anyone trying to decode what
the user is looking at. A great example of this coming up.
Canonicalize all absolute <Directory > sections, not simply those that
fail to end in a '/'. Slash test is afterwords, once we've canonicalized
any '\' and other aliases to '/'.
Oh, don't you love buffer overflows?
We need to allocate storage space for the terminating NULL AND the extra /
we may tack on to the string at some point.
How in the hell the stars were aligned for this to corrupt newv via the
strcat at line 580 is unknown.
Aaron Bannert [Fri, 19 Oct 2001 23:36:55 +0000 (23:36 +0000)]
The worker MPM is now completely ported to APR's new lock API. It
uses native APR types for thread mutexes, cross-process mutexes,
and condition variables. Who's next?
Aaron Bannert [Fri, 19 Oct 2001 23:32:43 +0000 (23:32 +0000)]
Use the APR's new OS-specific proc mutex accessors -- they are used
here to set permissions on SysV Semaphores. MPMs will be modified to
call this new function as they are ported to the new APR lock API.
Bill Stoddard [Fri, 19 Oct 2001 21:11:03 +0000 (21:11 +0000)]
Win32: ap_max_requests_per_child should not be a local static in mpm_winnt.c.
This was preventing the MaxRequestsPerChild config directive from working
properly.
Handle MaxRequestsPerChild a bit more sanely. When MaxRequestsPerChild is hit,
the child signals an event that causes the main child thread to signal the parent
to restart.
Hey, we tagged 2.0.26. =)
We're now waiting for it to be discarded or we need to bump the tag on
server/core.c. And, we need to fix the proc_wait thing to someone's
satisfaction.