]> granicus.if.org Git - pdns/log
pdns
6 years agoUpdate rec_channel_rec.cc
phonedph1 [Wed, 5 Sep 2018 20:19:47 +0000 (14:19 -0600)]
Update rec_channel_rec.cc

Noticed a missing newline that I didn't catch before.

6 years agoMerge pull request #6925 from phonedph1/tologstr
Remi Gacogne [Wed, 5 Sep 2018 07:42:48 +0000 (09:42 +0200)]
Merge pull request #6925 from phonedph1/tologstr

rec: rec_control/ws toLogString

6 years agoPrint possibly empty dnsnames safer; this one shouldn't be reachable - I think -...
phonedph1 [Tue, 4 Sep 2018 22:06:32 +0000 (22:06 +0000)]
Print possibly empty dnsnames safer; this one shouldn't be reachable - I think - but convert anyways

6 years agoPrint possibly empty dnsnames safer
phonedph1 [Tue, 4 Sep 2018 22:05:56 +0000 (22:05 +0000)]
Print possibly empty dnsnames safer

6 years agoMerge pull request #6847 from rgacogne/dnsdist-edns-self-generated
Remi Gacogne [Tue, 4 Sep 2018 14:01:23 +0000 (16:01 +0200)]
Merge pull request #6847 from rgacogne/dnsdist-edns-self-generated

dnsdist: Set a correct EDNS OPT RR for self-generated answers

6 years agoMerge pull request #6917 from rgacogne/ecdsa-signer-leak-oom
Remi Gacogne [Tue, 4 Sep 2018 14:01:05 +0000 (16:01 +0200)]
Merge pull request #6917 from rgacogne/ecdsa-signer-leak-oom

Release memory in case of error in the OpenSSL ECDSA constructor

6 years agoMerge pull request #6913 from Habbie/truncate-truncated
Pieter Lexis [Tue, 4 Sep 2018 08:58:42 +0000 (10:58 +0200)]
Merge pull request #6913 from Habbie/truncate-truncated

actually truncate truncated responses; fixes #6912

6 years agoMerge pull request #6905 from pieterlexis/boost.m4
Pieter Lexis [Tue, 4 Sep 2018 08:58:29 +0000 (10:58 +0200)]
Merge pull request #6905 from pieterlexis/boost.m4

Update boost.m4

6 years agoMerge pull request #6895 from rgacogne/ixfrdist-optims
Pieter Lexis [Tue, 4 Sep 2018 08:58:14 +0000 (10:58 +0200)]
Merge pull request #6895 from rgacogne/ixfrdist-optims

ixfrdist: Fix TTL, optimize the construction of answers

6 years agoMerge pull request #6915 from Habbie/reg-test-nobackend-macos
Pieter Lexis [Tue, 4 Sep 2018 08:57:44 +0000 (10:57 +0200)]
Merge pull request #6915 from Habbie/reg-test-nobackend-macos

 make negcache-tests-dotted-cname test portable between Python versions

6 years agoMerge pull request #6921 from pieterlexis/rm-gost
Remi Gacogne [Tue, 4 Sep 2018 08:34:56 +0000 (10:34 +0200)]
Merge pull request #6921 from pieterlexis/rm-gost

Remove GOST support and Botan in the process

6 years agoMerge pull request #6920 from jannyg/remove-master-zone-query
Remi Gacogne [Tue, 4 Sep 2018 08:31:14 +0000 (10:31 +0200)]
Merge pull request #6920 from jannyg/remove-master-zone-query

Removed master-zone-query from documentation; fixes #6818

6 years agoMerge pull request #6882 from phonedph1/throttle-map
Remi Gacogne [Tue, 4 Sep 2018 07:58:38 +0000 (09:58 +0200)]
Merge pull request #6882 from phonedph1/throttle-map

Dump the throttle map

6 years agoUse proper type
phonedph1 [Tue, 4 Sep 2018 01:13:18 +0000 (01:13 +0000)]
Use proper type

6 years agoMerge pull request #6848 from zeha/luaconfig-pdnslog
Peter van Dijk [Mon, 3 Sep 2018 10:26:46 +0000 (12:26 +0200)]
Merge pull request #6848 from zeha/luaconfig-pdnslog

recursor: Add pdnslog to Lua configuration scripts

6 years agoRemoved master-zone-query from documentation
Jan-Arve Nygård [Mon, 3 Sep 2018 09:53:39 +0000 (11:53 +0200)]
Removed master-zone-query from documentation

6 years agodnsdist: Clarify doc/completion of setPayloadSizeOnSelfGeneratedAnswers
Remi Gacogne [Wed, 22 Aug 2018 13:50:48 +0000 (15:50 +0200)]
dnsdist: Clarify doc/completion of setPayloadSizeOnSelfGeneratedAnswers

6 years agodnsdist: Handle EDNS on truncateTC answers
Remi Gacogne [Mon, 20 Aug 2018 13:21:10 +0000 (15:21 +0200)]
dnsdist: Handle EDNS on truncateTC answers

6 years agodnsdist: Set a correct EDNS OPT RR for self-generated answers
Remi Gacogne [Fri, 17 Aug 2018 15:59:54 +0000 (17:59 +0200)]
dnsdist: Set a correct EDNS OPT RR for self-generated answers

6 years agoMerge pull request #6901 from pavel-odintsov/master
Remi Gacogne [Mon, 3 Sep 2018 08:29:03 +0000 (10:29 +0200)]
Merge pull request #6901 from pavel-odintsov/master

Added Prometheus stats support for dnsdist

6 years agoMerge pull request #6881 from phonedph1/top-timeouts
Remi Gacogne [Mon, 3 Sep 2018 07:59:59 +0000 (09:59 +0200)]
Merge pull request #6881 from phonedph1/top-timeouts

Keep track of what destinations are causing the most timeouts

6 years agoRelease memory in case of error in the OpenSSL ECDSA constructor
Remi Gacogne [Mon, 3 Sep 2018 07:43:45 +0000 (09:43 +0200)]
Release memory in case of error in the OpenSSL ECDSA constructor

The current code will only fail to release the allocated memory if
called with an invalid algorithm, which won't happen, or if a
memory allocation fails in which case this might not matter much.
Still, it's cleaner to release the memory properly and might avoid
mistakes later if we look at this code while implementing a new
crypto backend.

6 years agoRemove GOST support and Botan in the process
Pieter Lexis [Sun, 2 Sep 2018 15:34:37 +0000 (17:34 +0200)]
Remove GOST support and Botan in the process

6 years agoportablise
Peter van Dijk [Sun, 2 Sep 2018 00:05:22 +0000 (02:05 +0200)]
portablise

6 years agofix
Peter van Dijk [Sat, 1 Sep 2018 22:05:06 +0000 (00:05 +0200)]
fix

6 years agomake negcache-tests-dotted-cname test portable between Python versions
Peter van Dijk [Sat, 1 Sep 2018 21:15:46 +0000 (23:15 +0200)]
make negcache-tests-dotted-cname test portable between Python versions

6 years agoactually truncate truncated responses; fixes #6912
Peter van Dijk [Fri, 31 Aug 2018 20:41:21 +0000 (22:41 +0200)]
actually truncate truncated responses; fixes #6912

6 years agoAdded up to date Prometheus endpoint output
Pavel Odintsov [Fri, 31 Aug 2018 15:33:43 +0000 (16:33 +0100)]
Added up to date Prometheus endpoint output

6 years agoAdded address label and switched code to boost::format
Pavel Odintsov [Fri, 31 Aug 2018 15:25:13 +0000 (16:25 +0100)]
Added address label and switched code to boost::format

6 years agoRenamed dnsdist_pools_servers to singular form dnsdist_pool_servers
Pavel Odintsov [Fri, 31 Aug 2018 15:09:50 +0000 (16:09 +0100)]
Renamed dnsdist_pools_servers to singular form dnsdist_pool_servers

6 years agoReplaced custom host address crafting code to toStringWithPort
Pavel Odintsov [Fri, 31 Aug 2018 15:07:51 +0000 (16:07 +0100)]
Replaced custom host address crafting code to toStringWithPort

6 years agoDo not replace dot in metric names. Use singular form for metric base name
Pavel Odintsov [Fri, 31 Aug 2018 15:04:59 +0000 (16:04 +0100)]
Do not replace dot in metric names. Use singular form for metric base name

6 years agoRemoved dnsdist_querycount_queries metric group
Pavel Odintsov [Fri, 31 Aug 2018 15:01:33 +0000 (16:01 +0100)]
Removed dnsdist_querycount_queries metric group

6 years agoMerge pull request #6864 from pieterlexis/rec-414-changelog
Pieter Lexis [Fri, 31 Aug 2018 13:41:11 +0000 (15:41 +0200)]
Merge pull request #6864 from pieterlexis/rec-414-changelog

Recursor 4.1.4 changelog and secpoll

6 years agoRemoved main from all Prometheus metric names
Pavel Odintsov [Fri, 31 Aug 2018 12:55:32 +0000 (13:55 +0100)]
Removed main from all Prometheus metric names

6 years agoDo not reset per query counters when setQueryCount(true)
Pavel Odintsov [Fri, 31 Aug 2018 12:37:09 +0000 (13:37 +0100)]
Do not reset per query counters when setQueryCount(true)

6 years agoAdded weight and order values for all servers in Prometheus
Pavel Odintsov [Fri, 31 Aug 2018 12:27:48 +0000 (13:27 +0100)]
Added weight and order values for all servers in Prometheus

6 years agoFixed alignment for code
Pavel Odintsov [Fri, 31 Aug 2018 11:53:33 +0000 (12:53 +0100)]
Fixed alignment for code

6 years agoReworked Prometheus metric types to scoped enum
Pavel Odintsov [Fri, 31 Aug 2018 11:51:36 +0000 (12:51 +0100)]
Reworked Prometheus metric types to scoped enum

6 years agoReplaced function arguments to constant references to avoid copying memory
Pavel Odintsov [Fri, 31 Aug 2018 11:13:16 +0000 (12:13 +0100)]
Replaced function arguments to constant references to avoid copying memory

6 years agoReplaced getCopy by getLocal
Pavel Odintsov [Fri, 31 Aug 2018 10:55:19 +0000 (11:55 +0100)]
Replaced getCopy by getLocal

6 years agoReplaced warnlog by vinfolog to reduce log verbosity
Pavel Odintsov [Fri, 31 Aug 2018 10:32:08 +0000 (11:32 +0100)]
Replaced warnlog by vinfolog to reduce log verbosity

6 years agoUpdate settings for backported setting
Pieter Lexis [Mon, 20 Aug 2018 13:42:45 +0000 (15:42 +0200)]
Update settings for backported setting

6 years agoAdd recursor 4.1.4 changelog
Pieter Lexis [Mon, 20 Aug 2018 13:41:23 +0000 (15:41 +0200)]
Add recursor 4.1.4 changelog

6 years agoAdd recursor 4.1.4 to secpoll
Pieter Lexis [Mon, 20 Aug 2018 13:41:51 +0000 (15:41 +0200)]
Add recursor 4.1.4 to secpoll

6 years agoMerge pull request #6902 from ploxiln/loglevel_explain
Pieter Lexis [Fri, 31 Aug 2018 06:17:59 +0000 (08:17 +0200)]
Merge pull request #6902 from ploxiln/loglevel_explain

docs: auth config settings: explain loglevel value

6 years agoMerge pull request #6903 from gibson042/2018-08-DNSQuestion.len-documentation
Pieter Lexis [Fri, 31 Aug 2018 06:17:23 +0000 (08:17 +0200)]
Merge pull request #6903 from gibson042/2018-08-DNSQuestion.len-documentation

dnsdist: Fix documentation of DNSQuestion.len

6 years agoMerge pull request #6904 from gibson042/2018-08-documentation-grammar
Pieter Lexis [Fri, 31 Aug 2018 06:17:02 +0000 (08:17 +0200)]
Merge pull request #6904 from gibson042/2018-08-documentation-grammar

docs: Fix minor grammar issues

6 years agodocs: Fix minor grammar issues
Richard Gibson [Fri, 31 Aug 2018 03:03:09 +0000 (23:03 -0400)]
docs: Fix minor grammar issues

6 years agodnsdist: Fix documentation of DNSQuestion.len
Richard Gibson [Fri, 31 Aug 2018 02:40:03 +0000 (22:40 -0400)]
dnsdist: Fix documentation of DNSQuestion.len

6 years agodocs: auth config settings: explain loglevel value
Pierce Lopez [Thu, 30 Aug 2018 04:19:14 +0000 (00:19 -0400)]
docs: auth config settings: explain loglevel value

6 years agoIntroduced metric description storage and improved Prometheus support
Pavel Odintsov [Thu, 30 Aug 2018 18:00:37 +0000 (19:00 +0100)]
Introduced metric description storage and improved Prometheus support

6 years agoAdded Prometheus stats endpoint. Patch by Kai Storbeck <kai@xs4all.nl>
Pavel Odintsov [Thu, 30 Aug 2018 15:21:54 +0000 (16:21 +0100)]
Added Prometheus stats endpoint. Patch by Kai Storbeck <kai@xs4all.nl>

6 years agoUpdate boost.m4
Pieter Lexis [Thu, 30 Aug 2018 15:43:19 +0000 (17:43 +0200)]
Update boost.m4

6 years agoMerge pull request #6668 from zeha/api-zone-lookup
Pieter Lexis [Thu, 30 Aug 2018 09:48:24 +0000 (11:48 +0200)]
Merge pull request #6668 from zeha/api-zone-lookup

Auth API: add zone lookup by /zones?zone=example.org.

6 years agoMerge pull request #6898 from ploxiln/changelog_414_fix
Pieter Lexis [Thu, 30 Aug 2018 07:50:15 +0000 (09:50 +0200)]
Merge pull request #6898 from ploxiln/changelog_414_fix

changelog: 4.1.4 back-ported #6648 not #6848

6 years agochangelog: 4.1.4 back-ported #6648 not #6848
Pierce Lopez [Thu, 30 Aug 2018 01:12:40 +0000 (21:12 -0400)]
changelog: 4.1.4 back-ported #6648 not #6848

pull-request #6648 is mysql transaction-isolation syntax change
pull-request #6848 is lua logging stuff

6 years agoUpdate auth 4.1.4 release date, we were fast
Pieter Lexis [Wed, 29 Aug 2018 15:23:39 +0000 (17:23 +0200)]
Update auth 4.1.4 release date, we were fast

6 years agoMerge pull request #6863 from pieterlexis/auth-414-changelog
Pieter Lexis [Wed, 29 Aug 2018 15:20:47 +0000 (17:20 +0200)]
Merge pull request #6863 from pieterlexis/auth-414-changelog

Changelog + secpoll for auth 4.1.4

6 years agoAdd auth 4.1.4 to secpoll
Pieter Lexis [Mon, 20 Aug 2018 12:45:22 +0000 (14:45 +0200)]
Add auth 4.1.4 to secpoll

6 years agoAdd authoritative server 4.1.4 changelog
Pieter Lexis [Mon, 20 Aug 2018 12:44:13 +0000 (14:44 +0200)]
Add authoritative server 4.1.4 changelog

6 years agoixfrdist: Add an option to enable record compression, off by default
Remi Gacogne [Wed, 29 Aug 2018 12:52:29 +0000 (14:52 +0200)]
ixfrdist: Add an option to enable record compression, off by default

6 years agoixfrdist: Don't override the original TTL
Remi Gacogne [Wed, 29 Aug 2018 12:32:21 +0000 (14:32 +0200)]
ixfrdist: Don't override the original TTL

6 years agoixfrdist: Speedup and optimize memory usage when writing answers
Remi Gacogne [Wed, 29 Aug 2018 12:29:55 +0000 (14:29 +0200)]
ixfrdist: Speedup and optimize memory usage when writing answers

We now group as many records as possible inside one DNS message,
and send a message as soon as it is ready, so we can reduce the
memory usage by not keeping all outgoing messages in memory,
and send a lower number of messages.

6 years agoMerge pull request #6873 from phonedph1/flush-forward
Pieter Lexis [Wed, 29 Aug 2018 11:59:18 +0000 (13:59 +0200)]
Merge pull request #6873 from phonedph1/flush-forward

Purge all auth/forward zone data including subtree.

6 years agoMerge pull request #6877 from rgacogne/dnsdist-fix-ecs-sign-comparison
Pieter Lexis [Wed, 29 Aug 2018 11:59:01 +0000 (13:59 +0200)]
Merge pull request #6877 from rgacogne/dnsdist-fix-ecs-sign-comparison

dnsdist: Fix a sign-comparison warning in isEDNSOptionInOpt()

6 years agoMerge pull request #6879 from Habbie/ixfrdist-workdir-nit
Pieter Lexis [Wed, 29 Aug 2018 11:58:48 +0000 (13:58 +0200)]
Merge pull request #6879 from Habbie/ixfrdist-workdir-nit

ixfrdist: fix doc nit

6 years agoMerge pull request #6888 from ploxiln/docs_api_axfr_retrieve_fix
Pieter Lexis [Wed, 29 Aug 2018 11:58:34 +0000 (13:58 +0200)]
Merge pull request #6888 from ploxiln/docs_api_axfr_retrieve_fix

API docs: fix zone axfr-retrieve description

6 years agoMerge pull request #6889 from ploxiln/changelog_413_fix
Pieter Lexis [Wed, 29 Aug 2018 11:58:20 +0000 (13:58 +0200)]
Merge pull request #6889 from ploxiln/changelog_413_fix

changelog: fix dup of #6312 in 4.1.3, was in 4.1.2

6 years agoMerge pull request #6890 from rgacogne/ixfrdist-optims
Pieter Lexis [Wed, 29 Aug 2018 11:58:01 +0000 (13:58 +0200)]
Merge pull request #6890 from rgacogne/ixfrdist-optims

ixfrdist: Reduce memory usage and lock contention

6 years agoMerge pull request #6891 from scottbender/patch-1
Remi Gacogne [Tue, 28 Aug 2018 20:49:44 +0000 (22:49 +0200)]
Merge pull request #6891 from scottbender/patch-1

Update quickstart.rst

6 years agoUpdate quickstart.rst
scottbender [Tue, 28 Aug 2018 18:24:58 +0000 (14:24 -0400)]
Update quickstart.rst

Correct spelling mistake

6 years agoMove t_timeout up to the timeout stats, outside of throttle updates.
phonedph1 [Tue, 28 Aug 2018 17:02:44 +0000 (17:02 +0000)]
Move t_timeout up to the timeout stats, outside of throttle updates.
Move t_timeout into syncres.cc - testrunner now builds.

6 years agoRecord full data from map
phonedph1 [Tue, 28 Aug 2018 13:51:01 +0000 (13:51 +0000)]
Record full data from map

6 years agoixfrdist: Don't process records of interrupted AXFR
Remi Gacogne [Tue, 28 Aug 2018 13:29:25 +0000 (15:29 +0200)]
ixfrdist: Don't process records of interrupted AXFR

6 years agoixfrdist: Break out of the domain updates loop if we are exiting
Remi Gacogne [Tue, 28 Aug 2018 09:37:40 +0000 (11:37 +0200)]
ixfrdist: Break out of the domain updates loop if we are exiting

6 years agoixfrdist: Reduce the contention and copies of zone information
Remi Gacogne [Mon, 27 Aug 2018 21:24:36 +0000 (23:24 +0200)]
ixfrdist: Reduce the contention and copies of zone information

6 years agoixfrdist: Small optimizations for a large number of zones, add debug
Remi Gacogne [Mon, 27 Aug 2018 15:47:52 +0000 (17:47 +0200)]
ixfrdist: Small optimizations for a large number of zones, add debug

6 years agoAXFRRetriever: Don't parse records of answers with a non-zero code
Remi Gacogne [Mon, 27 Aug 2018 15:45:45 +0000 (17:45 +0200)]
AXFRRetriever: Don't parse records of answers with a non-zero code

Also reuse records from MOADNSParser whenever possible, instead of
allocating new ones.

6 years agoixfrdist: Correctly retrieve the SOAs from the diff if needed
Remi Gacogne [Mon, 27 Aug 2018 13:35:34 +0000 (15:35 +0200)]
ixfrdist: Correctly retrieve the SOAs from the diff if needed

They might be passed to makeIXFRDiff(), and the code to handle the
case where they aren't was broken.

6 years agoixfrdist: Small optimization in makeAXFRPackets()
Remi Gacogne [Mon, 27 Aug 2018 13:34:35 +0000 (15:34 +0200)]
ixfrdist: Small optimization in makeAXFRPackets()

6 years agoixfrdist: Reduce memory usage during zone retrieval
Remi Gacogne [Mon, 27 Aug 2018 13:33:24 +0000 (15:33 +0200)]
ixfrdist: Reduce memory usage during zone retrieval

6 years agoMerge pull request #6886 from rgacogne/ixfrdist-fix-xfr
Remi Gacogne [Tue, 28 Aug 2018 09:00:29 +0000 (11:00 +0200)]
Merge pull request #6886 from rgacogne/ixfrdist-fix-xfr

ixfrdist: Fix invalid buffer usage in getSerialFromMaster()

6 years agochangelog: fix dup of #6312 in 4.1.3, was in 4.1.2
Pierce Lopez [Tue, 28 Aug 2018 08:12:14 +0000 (04:12 -0400)]
changelog: fix dup of #6312 in 4.1.3, was in 4.1.2

6 years agoAPI docs: fix zone axfr-retrieve description
Pierce Lopez [Tue, 28 Aug 2018 07:47:40 +0000 (03:47 -0400)]
API docs: fix zone axfr-retrieve description

6 years agoMerge pull request #6887 from gibson042/test-any-address
Remi Gacogne [Tue, 28 Aug 2018 07:16:14 +0000 (09:16 +0200)]
Merge pull request #6887 from gibson042/test-any-address

dnsdist: Test retrieving address from any-address binds

6 years agodnsdist: Test retrieving address from any-address binds
Richard Gibson [Tue, 28 Aug 2018 00:37:55 +0000 (20:37 -0400)]
dnsdist: Test retrieving address from any-address binds

6 years agoixfrdist: Fix invalid buffer usage in getSerialFromMaster()
Remi Gacogne [Mon, 27 Aug 2018 21:35:49 +0000 (23:35 +0200)]
ixfrdist: Fix invalid buffer usage in getSerialFromMaster()

6 years agoMerge pull request #6885 from pieterlexis/ixfrdist-fixes
Remi Gacogne [Mon, 27 Aug 2018 18:13:50 +0000 (20:13 +0200)]
Merge pull request #6885 from pieterlexis/ixfrdist-fixes

Several ixfrdist fixes

6 years agoixfrdist: Don't handle SIGSTOP
Pieter Lexis [Mon, 27 Aug 2018 11:55:49 +0000 (13:55 +0200)]
ixfrdist: Don't handle SIGSTOP

6 years agoDump the throttle map
phonedph1 [Fri, 24 Aug 2018 18:11:40 +0000 (18:11 +0000)]
Dump the throttle map

6 years agoixfrdist: make axfr-timeout default match documented default
Pieter Lexis [Fri, 24 Aug 2018 16:23:01 +0000 (18:23 +0200)]
ixfrdist: make axfr-timeout default match documented default

6 years agoixfrdist: clarify exit message
Pieter Lexis [Fri, 24 Aug 2018 16:21:09 +0000 (18:21 +0200)]
ixfrdist: clarify exit message

6 years agoixfrdist: fix typo in error
Pieter Lexis [Fri, 24 Aug 2018 14:59:31 +0000 (16:59 +0200)]
ixfrdist: fix typo in error

6 years agoixfrdist: use port 53 by default for IPs from json
Pieter Lexis [Fri, 24 Aug 2018 14:54:20 +0000 (16:54 +0200)]
ixfrdist: use port 53 by default for IPs from json

6 years agoixfrutils: add timeout to readSerialFromMaster
Pieter Lexis [Fri, 24 Aug 2018 14:50:22 +0000 (16:50 +0200)]
ixfrutils: add timeout to readSerialFromMaster

Make the error messages better in ixfrdist

6 years agoKeep track of what destinations are causing the most timeouts
phonedph1 [Fri, 24 Aug 2018 14:23:14 +0000 (14:23 +0000)]
Keep track of what destinations are causing the most timeouts

6 years agoixfrdist: fix doc nit
Peter van Dijk [Fri, 24 Aug 2018 12:17:52 +0000 (14:17 +0200)]
ixfrdist: fix doc nit

6 years agoMerge pull request #6737 from chbruyand/dnsdist-consistent-hashing
Remi Gacogne [Fri, 24 Aug 2018 12:15:31 +0000 (14:15 +0200)]
Merge pull request #6737 from chbruyand/dnsdist-consistent-hashing

dnsdist: add consistent hash builtin policy

6 years agoPurge all auth/forward zone data including subtree.
phonedph1 [Thu, 23 Aug 2018 17:27:02 +0000 (17:27 +0000)]
Purge all auth/forward zone data including subtree.

Previously this would miss purging out removed entries/data.