]>
granicus.if.org Git - sudo/log
Todd C. Miller [Thu, 22 Apr 2010 14:33:16 +0000 (10:33 -0400)]
get_boottime() now fills in a timeval struct
Todd C. Miller [Thu, 22 Apr 2010 14:16:18 +0000 (10:16 -0400)]
Store info from stat(2)ing the tty in the tty ticket when tty tickets
are in use. On most systems, this closes the loophole whereby a user
can log out of a tty, log back in and still have the timestamp be valid.
Todd C. Miller [Thu, 22 Apr 2010 13:52:26 +0000 (09:52 -0400)]
Add timespec2timeval and use it when getting ctime/mtime
Todd C. Miller [Tue, 20 Apr 2010 21:00:31 +0000 (17:00 -0400)]
Convert perm setting to push/pop model; still needs some work
Use the stashed runas groups instead of using getgrouplist()
Reset perms to the initial value on error
Todd C. Miller [Tue, 20 Apr 2010 20:57:07 +0000 (16:57 -0400)]
fix ctim_get and mtim_get macros
Todd C. Miller [Tue, 20 Apr 2010 20:44:02 +0000 (16:44 -0400)]
Use timeval directly instead of converting to timespec when dealing
with file times and time of day.
Todd C. Miller [Tue, 20 Apr 2010 20:37:41 +0000 (16:37 -0400)]
Don't like sudoreplay with libsudoers.la due to a yacc symbol conflict.
Todd C. Miller [Sun, 18 Apr 2010 16:42:52 +0000 (12:42 -0400)]
Darwin >= 9.x has real setreuid(2)
Todd C. Miller [Sat, 17 Apr 2010 17:28:36 +0000 (13:28 -0400)]
Ansify env.c
Todd C. Miller [Sat, 17 Apr 2010 17:26:03 +0000 (13:26 -0400)]
Remove remaining references to the environ pointer.
Todd C. Miller [Fri, 16 Apr 2010 11:56:16 +0000 (07:56 -0400)]
Don't change the environ directly in the sudoers plugin
Todd C. Miller [Thu, 15 Apr 2010 10:29:31 +0000 (06:29 -0400)]
Fix typo
Todd C. Miller [Thu, 15 Apr 2010 10:14:41 +0000 (06:14 -0400)]
Fix use after free in error message when a duplicate alias exists.
Todd C. Miller [Wed, 14 Apr 2010 12:41:53 +0000 (08:41 -0400)]
Add a "noninteractive" boolean to the settings passed in to the plugin's
open function that is set when the user specifies the -n flag.
Todd C. Miller [Wed, 14 Apr 2010 10:38:32 +0000 (06:38 -0400)]
Add workaround for the lack of the environ pointer on Mac OS X
in dlopen()ed modules. Use of environ in the sudoers plugin should
ultimately be removed but this will do for the moment.
Todd C. Miller [Wed, 14 Apr 2010 10:24:42 +0000 (06:24 -0400)]
Set errorfile to the sudoers path if we set parse_error manually.
This prevents a NULL dereference in printf() when checking a sudoers
file in strict mode when alias errors are present.
Todd C. Miller [Wed, 14 Apr 2010 09:51:11 +0000 (05:51 -0400)]
Main sudo no longer print "unable to execute" on exec failure so do it here.
Todd C. Miller [Tue, 13 Apr 2010 23:40:32 +0000 (19:40 -0400)]
Use a pipe to pass back errno to the parent if execve() fails.
If we get an error in script_child(), kill the command and exit.
Todd C. Miller [Tue, 13 Apr 2010 13:36:43 +0000 (09:36 -0400)]
Handle plugin's open function returning -2 (usage error).
Todd C. Miller [Tue, 13 Apr 2010 11:39:06 +0000 (07:39 -0400)]
If execve() fails, leave it to the plugin to print an error string.
Todd C. Miller [Tue, 13 Apr 2010 10:31:55 +0000 (06:31 -0400)]
If execve fails in logging mode, pass the errno directly to the grandparent
on the backchannel and exit. The immediate parent will get SIGCHLD and
try to report that status but its parent will no longer be listening.
It would probably be cleaner to pass this over a pipe in script_child().
Todd C. Miller [Tue, 13 Apr 2010 09:53:03 +0000 (05:53 -0400)]
Don't override rval with results of check_user() unless it failed.
Todd C. Miller [Mon, 12 Apr 2010 15:29:40 +0000 (11:29 -0400)]
Fix typo
Todd C. Miller [Mon, 12 Apr 2010 11:56:32 +0000 (07:56 -0400)]
NULL-terminate env_add
Todd C. Miller [Sun, 11 Apr 2010 21:13:11 +0000 (17:13 -0400)]
Call the I/O log open function before the I/O version function.
Todd C. Miller [Sun, 11 Apr 2010 21:12:12 +0000 (17:12 -0400)]
Remove io_conv and just use sudo_conv
Todd C. Miller [Sun, 11 Apr 2010 20:38:42 +0000 (16:38 -0400)]
Fix set/restore perms for systems w/o setresuid
Todd C. Miller [Sat, 10 Apr 2010 14:34:37 +0000 (10:34 -0400)]
Primitive set/restore permissions. Will be replaced by a push/pop
model.
Todd C. Miller [Sat, 10 Apr 2010 14:31:47 +0000 (10:31 -0400)]
Only need to take action on SIGCHLD in parent if no I/O logger.
If there is an I/O logger we will receive ECONNRESET or EPIPE when
we try to read from the socketpair.
Todd C. Miller [Fri, 9 Apr 2010 10:18:43 +0000 (06:18 -0400)]
Merge
fb4d571495fa from the 1.7 branch to trunk.
Todd C. Miller [Fri, 9 Apr 2010 10:10:07 +0000 (06:10 -0400)]
Qualify the command even if it is in the current working directory,
e.g. "./foo" instead of just returning "foo". This removes an ambiguity
between real commands and possible pseudo-commands in command matching.
--HG--
branch : 1.7
Todd C. Miller [Fri, 9 Apr 2010 00:17:26 +0000 (20:17 -0400)]
Don't set SA_RESTART when registering SIGALRM handler.
Do set SA_RESTART when registering SIGWINCH handler.
Todd C. Miller [Fri, 9 Apr 2010 00:08:30 +0000 (20:08 -0400)]
Add dev targets for *.man.in and *.cat that don't specfify the $(srcdir)
prefix.
Todd C. Miller [Thu, 8 Apr 2010 13:40:27 +0000 (09:40 -0400)]
If log_input or log_output returns false, terminate the command.
Todd C. Miller [Thu, 8 Apr 2010 11:40:04 +0000 (07:40 -0400)]
Better signal handling.
Instead of using a single variable to store the received signal, use
an array so we can't lose a signal when multiple are sent.
Fix process termination by SIGALRM in non-I/O logger mode.
Fix relaying terminal signals to the child in non-I/O logger mode.
Todd C. Miller [Thu, 8 Apr 2010 10:12:47 +0000 (06:12 -0400)]
Fix a race between when we get the child pid in the parent and when
the child process exits. The problem exhibited as a hang after a
short-lived process, e.g. "sudo id" when no IO logger was enabled.
Todd C. Miller [Wed, 7 Apr 2010 14:09:31 +0000 (10:09 -0400)]
Add a note about the security implications of the fast_glob option.
Todd C. Miller [Wed, 7 Apr 2010 13:34:41 +0000 (09:34 -0400)]
Add a note about the security implications of the fast_glob option.
--HG--
branch : 1.7
Todd C. Miller [Wed, 7 Apr 2010 10:39:35 +0000 (06:39 -0400)]
Remove duplicate includes
--HG--
branch : 1.7
Todd C. Miller [Tue, 6 Apr 2010 08:53:42 +0000 (04:53 -0400)]
Fix up some AC_DEFINE descriptions and regen config.h.in
Todd C. Miller [Mon, 5 Apr 2010 23:47:49 +0000 (19:47 -0400)]
No longer check for strdup or strndup for LIBOBJ replacement.
Todd C. Miller [Mon, 5 Apr 2010 20:27:30 +0000 (16:27 -0400)]
Avoid installing signal handlers that are io-logger specific. Fixes
job control when no io logger is enabled.
Todd C. Miller [Mon, 5 Apr 2010 16:24:12 +0000 (12:24 -0400)]
Only regen man pages from pod when configured with --with-devel
Todd C. Miller [Mon, 5 Apr 2010 00:05:02 +0000 (20:05 -0400)]
Top-level Makefile.in. Nothing is currently substituted but this
is needed for separate build dirs.
Todd C. Miller [Sun, 4 Apr 2010 18:01:21 +0000 (14:01 -0400)]
Fix out-of-tree builds
Todd C. Miller [Sun, 4 Apr 2010 16:47:57 +0000 (12:47 -0400)]
Merge
Todd C. Miller [Sun, 4 Apr 2010 16:31:57 +0000 (12:31 -0400)]
We always install sudoreplay in 1.8
Todd C. Miller [Sun, 4 Apr 2010 12:40:23 +0000 (08:40 -0400)]
Free str after using it in the version method. Use sudo_conv, not
io_conv since we don't have the IO conversation function pointer
in the I/O version method anymore now that io_open is delayed.
Todd C. Miller [Sat, 3 Apr 2010 13:44:32 +0000 (09:44 -0400)]
SIGPOLL is sometimes the same as SIGIO (like on HP-UX)
Todd C. Miller [Fri, 2 Apr 2010 18:46:00 +0000 (14:46 -0400)]
No need to provide strdup() or strndup(), sudo uses estrdup() and estrndup()
Todd C. Miller [Fri, 2 Apr 2010 15:18:57 +0000 (11:18 -0400)]
Add license to mksiglist.c and note that the bits from pdksh are public domain
Todd C. Miller [Fri, 2 Apr 2010 13:49:21 +0000 (09:49 -0400)]
Fix LIBOBJDIR vs. srcdir wrt the siglist bits
Todd C. Miller [Fri, 2 Apr 2010 11:49:29 +0000 (07:49 -0400)]
Add sudoreplay testsudoers and visudo to clean target
Todd C. Miller [Fri, 2 Apr 2010 11:47:19 +0000 (07:47 -0400)]
Create our own sys_siglist for systems without it for use by strsignal()
Todd C. Miller [Fri, 2 Apr 2010 11:15:02 +0000 (07:15 -0400)]
Remove duplicate $(LIBOBJDIR)
Todd C. Miller [Thu, 1 Apr 2010 10:35:19 +0000 (06:35 -0400)]
Main sudo should not block signals; the plugin should do this in
check_policy.
Todd C. Miller [Thu, 1 Apr 2010 00:30:34 +0000 (20:30 -0400)]
Fix a sizeof(ptr) vs. sizeof(*ptr)
Todd C. Miller [Wed, 31 Mar 2010 16:43:26 +0000 (12:43 -0400)]
Unlike most operating systems, HP-UX select() is not interrupted
by SIGCHLD when the signal is registered with SA_RESTART. If
we clear SA_RESTART when calling sigaction() for SIGCHLD we get
the expected behavior and the code in the select() loops already
handles EINTR correctly.
Todd C. Miller [Wed, 31 Mar 2010 14:36:39 +0000 (10:36 -0400)]
progname should be const
Todd C. Miller [Wed, 31 Mar 2010 09:44:17 +0000 (05:44 -0400)]
Move --tag=disable-static to when we link sudoers.la, not when
we install.
Todd C. Miller [Wed, 31 Mar 2010 09:42:58 +0000 (05:42 -0400)]
Load the sudoers I/O plugin by default too now that it is hooked up.
Todd C. Miller [Tue, 30 Mar 2010 16:06:27 +0000 (12:06 -0400)]
It looks like AIX doesn't need to push STREAMS modules for ptys.
Todd C. Miller [Sun, 28 Mar 2010 12:41:06 +0000 (08:41 -0400)]
Delay calling the I/O plugin open function until the policy plugin
returns success.
Todd C. Miller [Sun, 28 Mar 2010 00:19:40 +0000 (20:19 -0400)]
Add back io logging (transcript) support. Currently, the open function
runs too early and it is not possible to use the io module independently
of the policy module.
Todd C. Miller [Sat, 27 Mar 2010 13:12:48 +0000 (09:12 -0400)]
Comment out dead code; will be removed when set_perms is rewritten.
Todd C. Miller [Tue, 23 Mar 2010 09:21:38 +0000 (05:21 -0400)]
Fix off by one error when allocating user_groups.
Todd C. Miller [Mon, 22 Mar 2010 23:55:49 +0000 (19:55 -0400)]
Add REPLAY_LIBS for sudoreplay and add -lrt to it on Solaris.
Todd C. Miller [Mon, 22 Mar 2010 23:39:02 +0000 (19:39 -0400)]
Fix typo in preserve groups case
Todd C. Miller [Mon, 22 Mar 2010 23:27:02 +0000 (19:27 -0400)]
In command_info it is "runas_groups" not "groups".
Todd C. Miller [Mon, 22 Mar 2010 22:08:17 +0000 (18:08 -0400)]
Fix iteration over runas_groups list.
Todd C. Miller [Mon, 22 Mar 2010 14:19:07 +0000 (10:19 -0400)]
Todd C. Miller [Mon, 22 Mar 2010 13:54:10 +0000 (09:54 -0400)]
getgrouplist(3) for those without it
Todd C. Miller [Mon, 22 Mar 2010 13:50:06 +0000 (09:50 -0400)]
Fix installation of sudoers.ldap in "make install" when --with-ldap
was specified without a directory. From Prof. Dr. Andreas Mueller
--HG--
branch : 1.7
Todd C. Miller [Mon, 22 Mar 2010 12:28:11 +0000 (08:28 -0400)]
Set preserve_groups or groups list in command_info
Todd C. Miller [Mon, 22 Mar 2010 12:26:05 +0000 (08:26 -0400)]
Fix setting of groups list
Todd C. Miller [Mon, 22 Mar 2010 12:25:30 +0000 (08:25 -0400)]
Add checks for getgrset and getgrouplist and use replacement getgrouplist
if the system doesn't support it.
Todd C. Miller [Mon, 22 Mar 2010 12:11:06 +0000 (08:11 -0400)]
Pass in preserve_groups when the -P flag is specified as per the design
Todd C. Miller [Mon, 22 Mar 2010 12:09:50 +0000 (08:09 -0400)]
Check preserve_groups and ignore_ticket args with atobool instead
of assuming they are true if present.
Todd C. Miller [Sun, 21 Mar 2010 16:58:14 +0000 (12:58 -0400)]
Rename plugin-specific error.c to plugin_error.c
Wire up visudo, sudoreplay and testsudoers in the build
Todd C. Miller [Sun, 21 Mar 2010 16:57:00 +0000 (12:57 -0400)]
term.c does not needto include sudo.h
Todd C. Miller [Sun, 21 Mar 2010 12:58:13 +0000 (08:58 -0400)]
Document the -2 return in the check_policy section too
Todd C. Miller [Sun, 21 Mar 2010 12:54:06 +0000 (08:54 -0400)]
Fix the -s and -i flags and add support for the "implied_shell"
option. If the user does not specify a command, sudo will now pass
in the path to the user's shell and set impied_shell=true. The
plugin can them either check the command normally or return -2 to
cause sudo to print a usage message and exit.
Todd C. Miller [Sat, 20 Mar 2010 00:01:00 +0000 (20:01 -0400)]
Bring back SUDOERS_PLUGIN but add .dylib -> .so conversion for
Darwin where libraries end in .dylib but modules end in .so
Todd C. Miller [Fri, 19 Mar 2010 12:17:58 +0000 (08:17 -0400)]
Better prefix determination now that we can't rely on len==0 to
tell the beginning on an entry.
Todd C. Miller [Fri, 19 Mar 2010 12:17:09 +0000 (08:17 -0400)]
display_bound_defaults() stub should return 0, not 1 since it is a count,
not a boolean.
Todd C. Miller [Fri, 19 Mar 2010 11:56:06 +0000 (07:56 -0400)]
Document progname in settings
Todd C. Miller [Fri, 19 Mar 2010 11:52:31 +0000 (07:52 -0400)]
Rewrite compat/getprogname.c and add setprogname().
The progname is now passed to the plugin via the settings array.
Todd C. Miller [Fri, 19 Mar 2010 11:32:14 +0000 (07:32 -0400)]
Fix --with-ldap
Todd C. Miller [Fri, 19 Mar 2010 11:31:42 +0000 (07:31 -0400)]
Add missing whitespace for Runas and Command-specific defaults
Todd C. Miller [Fri, 19 Mar 2010 11:04:34 +0000 (07:04 -0400)]
Use embedded newlines in lbuf instead of multiple calls to lbuf_print.
Todd C. Miller [Fri, 19 Mar 2010 10:59:02 +0000 (06:59 -0400)]
Add support for embedded newlines.
Todd C. Miller [Thu, 18 Mar 2010 17:53:12 +0000 (13:53 -0400)]
If system doesn't support getprogname or __programe and we are
building a shared object don't bother with Argc/Argv, just
return "sudo"
Todd C. Miller [Thu, 18 Mar 2010 16:02:05 +0000 (12:02 -0400)]
Hard-code sudoers.so instead of using SUDOERS_PLUGIN since libtool
appears to always install a shared object with the .so suffix.
Todd C. Miller [Thu, 18 Mar 2010 15:42:12 +0000 (11:42 -0400)]
Play more nicely with libtool and let it build libreplace (was libmissing)
for us.
Todd C. Miller [Thu, 18 Mar 2010 12:58:31 +0000 (08:58 -0400)]
Include stdarg.h for va_list rather than requiring all consumers of
missing.h to include stdarg.h themselves.
Todd C. Miller [Thu, 18 Mar 2010 10:42:17 +0000 (06:42 -0400)]
Pass in output function to lbuf_init() instead of writing to stdout.
A side effect is that the usage info can now go to stderr as it should.
Todd C. Miller [Thu, 18 Mar 2010 01:25:32 +0000 (21:25 -0400)]
Use number of tty columns that is passed in user_info instead of
getting it directly in the lbuf code.
Todd C. Miller [Wed, 17 Mar 2010 23:56:27 +0000 (19:56 -0400)]
Kill __P in sudoers
Todd C. Miller [Wed, 17 Mar 2010 22:48:19 +0000 (18:48 -0400)]
Set the sudoers plugin name in configure so we get the extension right.
Todd C. Miller [Wed, 17 Mar 2010 14:44:16 +0000 (10:44 -0400)]
Document lines/cols in user_info