]> granicus.if.org Git - postgresql/log
postgresql
18 years agoAdjust /contrib for new include file contents.
Bruce Momjian [Thu, 13 Jul 2006 16:57:31 +0000 (16:57 +0000)]
Adjust /contrib for new include file contents.

18 years agoAllow include files to compile own their own.
Bruce Momjian [Thu, 13 Jul 2006 16:49:20 +0000 (16:49 +0000)]
Allow include files to compile own their own.

Strip unused include files out unused include files, and add needed
includes to C files.

The next step is to remove unused include files in C files.

18 years agoImprove pginclude tools to process include file usage by other include files.
Bruce Momjian [Thu, 13 Jul 2006 16:39:20 +0000 (16:39 +0000)]
Improve pginclude tools to process include file usage by other include files.

18 years agoRemove trailing comma from CreateStmtLikeOption enum definition. This
Neil Conway [Thu, 13 Jul 2006 15:09:57 +0000 (15:09 +0000)]
Remove trailing comma from CreateStmtLikeOption enum definition. This
is harmless, but it causes a warning with Tru64's cc.

18 years agoBe consistent about not using ECHO_N/ECHO_C (seems unnecessary on Linux).
Peter Eisentraut [Thu, 13 Jul 2006 14:44:33 +0000 (14:44 +0000)]
Be consistent about not using ECHO_N/ECHO_C (seems unnecessary on Linux).

18 years agoFix C++-style comment.
Neil Conway [Thu, 13 Jul 2006 04:52:51 +0000 (04:52 +0000)]
Fix C++-style comment.

18 years ago"Annual" pgcrypto update from Marko Kreen:
Neil Conway [Thu, 13 Jul 2006 04:15:25 +0000 (04:15 +0000)]
"Annual" pgcrypto update from Marko Kreen:

Few cleanups and couple of new things:

 - add SHA2 algorithm to older OpenSSL
 - add BIGNUM math to have public-key cryptography work on non-OpenSSL
   build.
 - gen_random_bytes() function

The status of SHA2 algoritms and public-key encryption can now be
changed to 'always available.'

That makes pgcrypto functionally complete and unless there will be new
editions of AES, SHA2 or OpenPGP standards, there is no major changes
planned.

18 years agoFix pgrminclude to work for stripping include files.
Bruce Momjian [Wed, 12 Jul 2006 16:28:27 +0000 (16:28 +0000)]
Fix pgrminclude to work for stripping include files.

18 years agoUpdate schema USAGE permission description.
Bruce Momjian [Wed, 12 Jul 2006 15:37:10 +0000 (15:37 +0000)]
Update schema USAGE permission description.

18 years agoClean up for warning:
Joe Conway [Wed, 12 Jul 2006 02:31:56 +0000 (02:31 +0000)]
Clean up for warning:
  fe-auth.c:573: warning: passing argument 1 of 'free' discards qualifiers
  from pointer target type
pg_krb5_authname used to return a (const char *) to memory allocated by
krb. Somewhere along the lines this was changed so that a copy was
made, returned, and freed instead. However the const modifier was never
removed.

18 years agoApply entab fix from Marko Kreen for these problems:
Alvaro Herrera [Tue, 11 Jul 2006 21:21:59 +0000 (21:21 +0000)]
Apply entab fix from Marko Kreen for these problems:

- halt.c did not include stdlib.h, thus missed exit() prototype
- Makefile ignores BINDIR for install.
- Makefile calls install with user/group args, thus failing for regular user.

While trying it I noticed that the Makefile does not support VPATH builds ...

18 years agoTweak fillfactor code as per my recent proposal. Fix nbtsort.c so that
Tom Lane [Tue, 11 Jul 2006 21:05:57 +0000 (21:05 +0000)]
Tweak fillfactor code as per my recent proposal.  Fix nbtsort.c so that
it can handle small fillfactors for ordinary-sized index entries without
failing on large ones; fix nbtinsert.c to distinguish leaf and nonleaf
pages; change the minimum fillfactor to 10% for all index types.

18 years agoImprove pginclude tests.
Bruce Momjian [Tue, 11 Jul 2006 20:51:25 +0000 (20:51 +0000)]
Improve pginclude tests.

18 years agoImprove pginclude compile flags.
Bruce Momjian [Tue, 11 Jul 2006 20:12:29 +0000 (20:12 +0000)]
Improve pginclude compile flags.

18 years agoUpdate pginclude documentation.
Bruce Momjian [Tue, 11 Jul 2006 19:52:12 +0000 (19:52 +0000)]
Update pginclude documentation.

18 years agoAdd support to GIN for =(anyarray,anyarray) operation
Teodor Sigaev [Tue, 11 Jul 2006 19:49:14 +0000 (19:49 +0000)]
Add support to GIN for =(anyarray,anyarray) operation

18 years agoHave pgrminclude process include files too.
Bruce Momjian [Tue, 11 Jul 2006 19:45:16 +0000 (19:45 +0000)]
Have pgrminclude process include files too.

18 years agoAdd $CFLAGS support to pgrminclude.
Bruce Momjian [Tue, 11 Jul 2006 19:34:34 +0000 (19:34 +0000)]
Add $CFLAGS support to pgrminclude.

18 years agoMove pgrminclude debug code to be more effective.
Bruce Momjian [Tue, 11 Jul 2006 19:31:29 +0000 (19:31 +0000)]
Move pgrminclude debug code to be more effective.

18 years agoImprove shell script wrapping.
Bruce Momjian [Tue, 11 Jul 2006 19:30:05 +0000 (19:30 +0000)]
Improve shell script wrapping.

18 years agoAdd comments to pgrminclude.
Bruce Momjian [Tue, 11 Jul 2006 19:25:41 +0000 (19:25 +0000)]
Add comments to pgrminclude.

18 years agoCorrect the description of the pg_get_viewdef() function. Do some nearby
Neil Conway [Tue, 11 Jul 2006 19:11:26 +0000 (19:11 +0000)]
Correct the description of the pg_get_viewdef() function. Do some nearby
SGML cleanup: sort table entries alphabetically.

18 years agoAlphabetically order reference to include files, "S"-"Z".
Bruce Momjian [Tue, 11 Jul 2006 18:26:11 +0000 (18:26 +0000)]
Alphabetically order reference to include files, "S"-"Z".

18 years agoAlphabetically order reference to include files, "N" - "S".
Bruce Momjian [Tue, 11 Jul 2006 17:26:59 +0000 (17:26 +0000)]
Alphabetically order reference to include files, "N" - "S".

18 years agoAlphabetically order reference to include files, "G" - "M".
Bruce Momjian [Tue, 11 Jul 2006 17:04:13 +0000 (17:04 +0000)]
Alphabetically order reference to include files, "G" - "M".

18 years agoAdd URL of code presentation to developers FAQ.
Bruce Momjian [Tue, 11 Jul 2006 17:02:16 +0000 (17:02 +0000)]
Add URL of code presentation to developers FAQ.

18 years agoGIN improvements
Teodor Sigaev [Tue, 11 Jul 2006 16:55:34 +0000 (16:55 +0000)]
GIN improvements
- Replace sorted array of entries in maintenance_work_mem to binary tree,
  this should improve create performance.
- More precisely calculate allocated memory, eliminate leaks
  with user-defined extractValue()
- Improve wordings in tsearch2

18 years agoSort reference of include files, "A" - "F".
Bruce Momjian [Tue, 11 Jul 2006 16:35:33 +0000 (16:35 +0000)]
Sort reference of include files, "A" - "F".

18 years agoRemove no-longer-needed configure test for krb5_encrypt(), per Jim Gates.
Tom Lane [Tue, 11 Jul 2006 16:14:50 +0000 (16:14 +0000)]
Remove no-longer-needed configure test for krb5_encrypt(), per Jim Gates.

18 years agoFix bug corrupting query in gist consistent function.
Teodor Sigaev [Tue, 11 Jul 2006 16:00:44 +0000 (16:00 +0000)]
Fix bug corrupting query in gist consistent function.
Thank to Mario Weilguni <mweilguni@sime.com> to discover a bug.

18 years agoReverse inclusion order of <ws2tcpip.h> and <winsock2.h>, per Dave Page.
Tom Lane [Tue, 11 Jul 2006 14:25:09 +0000 (14:25 +0000)]
Reverse inclusion order of <ws2tcpip.h> and <winsock2.h>, per Dave Page.

18 years agoAllow each C include file to compile on its own by including any needed
Bruce Momjian [Tue, 11 Jul 2006 13:54:25 +0000 (13:54 +0000)]
Allow each C include file to compile on its own by including any needed
header files.

18 years agoAdd libpq include directory to script.
Bruce Momjian [Tue, 11 Jul 2006 02:01:24 +0000 (02:01 +0000)]
Add libpq include directory to script.

18 years agoFix ALTER TABLE to check pre-existing NOT NULL constraints when rewriting
Tom Lane [Mon, 10 Jul 2006 22:10:39 +0000 (22:10 +0000)]
Fix ALTER TABLE to check pre-existing NOT NULL constraints when rewriting
a table.  Otherwise a USING clause that yields NULL can leave the table
violating its constraint (possibly there are other cases too).  Per report
from Alexander Pravking.

18 years agoAllow /contrib include files to compile on their own.
Bruce Momjian [Mon, 10 Jul 2006 22:06:11 +0000 (22:06 +0000)]
Allow /contrib include files to compile on their own.

18 years agoAdd #include code to prevent multiple inclusion.
Bruce Momjian [Mon, 10 Jul 2006 21:03:58 +0000 (21:03 +0000)]
Add #include code to prevent multiple inclusion.

18 years agoMove pthread-win32.h to /port, modify bcc/msvc makefiles.
Bruce Momjian [Mon, 10 Jul 2006 18:53:29 +0000 (18:53 +0000)]
Move pthread-win32.h to /port, modify bcc/msvc makefiles.

18 years agoRemove a few baby-C macros in fuzzystrmatch. Add a few missing includes.
Bruce Momjian [Mon, 10 Jul 2006 18:40:16 +0000 (18:40 +0000)]
Remove a few baby-C macros in fuzzystrmatch.  Add a few missing includes.

18 years agoImprove compile line for tool.
Bruce Momjian [Mon, 10 Jul 2006 18:39:32 +0000 (18:39 +0000)]
Improve compile line for tool.

18 years agoUpdate usage documention for pginclude
Bruce Momjian [Mon, 10 Jul 2006 17:13:34 +0000 (17:13 +0000)]
Update usage documention for pginclude

18 years agoAdd $CFLAGS handling to pgcompinclude.
Bruce Momjian [Mon, 10 Jul 2006 17:11:43 +0000 (17:11 +0000)]
Add $CFLAGS handling to pgcompinclude.

18 years agoFix 'find' args for pgcompinclude tool.
Bruce Momjian [Mon, 10 Jul 2006 17:08:38 +0000 (17:08 +0000)]
Fix 'find' args for pgcompinclude tool.

18 years agoUpdate schema GRANT USAGE description.
Bruce Momjian [Mon, 10 Jul 2006 16:48:46 +0000 (16:48 +0000)]
Update schema GRANT USAGE description.

18 years agoImprove tool coding.
Bruce Momjian [Mon, 10 Jul 2006 16:45:44 +0000 (16:45 +0000)]
Improve tool coding.

18 years agoImprove vacuum code to track minimum Xids per table instead of per database.
Alvaro Herrera [Mon, 10 Jul 2006 16:20:52 +0000 (16:20 +0000)]
Improve vacuum code to track minimum Xids per table instead of per database.
To this end, add a couple of columns to pg_class, relminxid and relvacuumxid,
based on which we calculate the pg_database columns after each vacuum.

We now force all databases to be vacuumed, even template ones.  A backend
noticing too old a database (meaning pg_database.datminxid is in danger of
falling behind Xid wraparound) will signal the postmaster, which in turn will
start an autovacuum iteration to process the offending database.  In principle
this is only there to cope with frozen (non-connectable) databases without
forcing users to set them to connectable, but it could force regular user
database to go through a database-wide vacuum at any time.  Maybe we should
warn users about this somehow.  Of course the real solution will be to use
autovacuum all the time ;-)

There are some additional improvements we could have in this area: for example
the vacuum code could be smarter about not updating pg_database for each table
when called by autovacuum, and do it only once the whole autovacuum iteration
is done.

I updated the system catalogs documentation, but I didn't modify the
maintenance section.  Also having some regression tests for this would be nice
but it's not really a very straightforward thing to do.

Catalog version bumped due to system catalog changes.

18 years agoImprove script by processing only C files.
Bruce Momjian [Mon, 10 Jul 2006 16:07:24 +0000 (16:07 +0000)]
Improve script by processing only C files.

18 years agoTesting commit stuff
Alvaro Herrera [Mon, 10 Jul 2006 15:50:02 +0000 (15:50 +0000)]
Testing commit stuff

18 years agoTest commit.
Bruce Momjian [Mon, 10 Jul 2006 15:44:31 +0000 (15:44 +0000)]
Test commit.

18 years agoFix typo in comment.
Alvaro Herrera [Sat, 8 Jul 2006 20:45:38 +0000 (20:45 +0000)]
Fix typo in comment.

18 years agoAdd index information to /contrib/pgstattuple:
Bruce Momjian [Thu, 6 Jul 2006 02:18:07 +0000 (02:18 +0000)]
Add index information to /contrib/pgstattuple:

This is an extension of pgstattuple to query information from indexes.
It supports btree, hash and gist. Gin is not supported. It scans only
index pages and does not read corresponding heap tuples. Therefore,
'dead_tuple' means the number of tuples with LP_DELETE flag.

Also, I added an experimental feature for btree indexes. It checks
fragmentation factor of indexes. If an leaf has the right link on the
next adjacent page in the file, it is assumed to be continuous (not
fragmented). It will help us to decide when to REINDEX.

ITAGAKI Takahiro

18 years agoWIN32 fixes:
Bruce Momjian [Thu, 6 Jul 2006 02:12:32 +0000 (02:12 +0000)]
WIN32 fixes:

I take out patch for this as a promise. This is client-build support of
MS-VC6+.

Fix for different getaddrinfo structure ordering on Win32 for IPv6.

Hiroshi Saito

18 years agoBackpatch dbmirror fix for escape handling.
Bruce Momjian [Thu, 6 Jul 2006 01:57:25 +0000 (01:57 +0000)]
Backpatch dbmirror fix for escape handling.

> Upstream confirmed my reply in the last mail in [1]: the complete
> escaping logic in DBMirror.pl is seriously screwew.
>
> [1] http://archives.postgresql.org/pgsql-bugs/2006-06/msg00065.php

I finally found some time to debug this, and I think I found a better
patch than the one you proposed. Mine is still hackish and is still a
workaround around a proper quoting solution, but at least it repairs
the parsing without introducing the \' quoting again.

I consider this a band-aid patch to fix the recent security update.
PostgreSQL gurus, would you consider applying this until a better
solution is found for DBMirror.pl?

Olivier, can you please confirm that the patch works for you, too?

Backpatched to 8.0.X.

Martin Pitt

18 years agoAttached patch is required ot build with the CRT that comes with Visual
Bruce Momjian [Thu, 6 Jul 2006 01:55:51 +0000 (01:55 +0000)]
Attached patch is required ot build with the CRT that comes with Visual
Studio 2005. Basically MS defined errcode in the headers with a typedef,
so we have to #define it out of the way.

While at it, fix a function declaration in plpython that didn't match
the implementation (volatile missing).

Magnus Hagander

18 years agoPlease find attached two patches for documentation and regression tests
Bruce Momjian [Thu, 6 Jul 2006 01:46:38 +0000 (01:46 +0000)]
Please find attached two patches for documentation and regression tests
for the usage of full time zone names.

Joachim Wieland

18 years agoFixed remaining Coverity bugs.
Michael Meskes [Wed, 5 Jul 2006 10:49:56 +0000 (10:49 +0000)]
Fixed remaining Coverity bugs.

18 years agoDocumentation fixes for FILLFACTOR patch. Minor other editorialization.
Tom Lane [Tue, 4 Jul 2006 18:07:24 +0000 (18:07 +0000)]
Documentation fixes for FILLFACTOR patch.  Minor other editorialization.

18 years agoModify:
Bruce Momjian [Tue, 4 Jul 2006 13:22:41 +0000 (13:22 +0000)]
Modify:

<  o -Add PQescapeIdentifier()
>  o Add PQescapeIdentifierConn()

18 years agoRemove libpq's PQescapeIdentifier(), not safe from injection attacks.
Bruce Momjian [Tue, 4 Jul 2006 13:22:15 +0000 (13:22 +0000)]
Remove libpq's PQescapeIdentifier(), not safe from injection attacks.

18 years agoFix typos in comments.
Neil Conway [Tue, 4 Jul 2006 04:35:49 +0000 (04:35 +0000)]
Fix typos in comments.

18 years agoCode review for FILLFACTOR patch. Change WITH grammar as per earlier
Tom Lane [Mon, 3 Jul 2006 22:45:41 +0000 (22:45 +0000)]
Code review for FILLFACTOR patch.  Change WITH grammar as per earlier
discussion (including making def_arg allow reserved words), add missed
opt_definition for UNIQUE case.  Put the reloptions support code in a less
random place (I chose to make a new file access/common/reloptions.c).
Eliminate header inclusion creep.  Make the index options functions safely
user-callable (seems like client apps might like to be able to test validity
of options before trying to make an index).  Reduce overhead for normal case
with no options by allowing rd_options to be NULL.  Fix some unmaintainably
klugy code, including getting rid of Natts_pg_class_fixed at long last.
Some stylistic cleanup too, and pay attention to keeping comments in sync
with code.

Documentation still needs work, though I did fix the omissions in
catalogs.sgml and indexam.sgml.

18 years agoFix broken markup.
Tom Lane [Mon, 3 Jul 2006 16:43:14 +0000 (16:43 +0000)]
Fix broken markup.

18 years agoDo a pass of code review for the ALTER TABLE ADD INHERITS patch. Keep
Neil Conway [Sun, 2 Jul 2006 05:17:26 +0000 (05:17 +0000)]
Do a pass of code review for the ALTER TABLE ADD INHERITS patch. Keep
the read lock we hold on the table's parent relation until commit.
Update equalfuncs.c for the new field in AlterTableCmd. Various
improvements to comments, variable names, and error reporting.

There is room for further improvement here, but this is at least
a step in the right direction.

18 years agoAdd FILLFACTOR to CREATE INDEX.
Bruce Momjian [Sun, 2 Jul 2006 02:23:23 +0000 (02:23 +0000)]
Add FILLFACTOR to CREATE INDEX.

ITAGAKI Takahiro

18 years agoDone:
Bruce Momjian [Sun, 2 Jul 2006 02:22:39 +0000 (02:22 +0000)]
Done:

> * -Add fillfactor to control reserved free space during index creation

18 years agoDone:
Bruce Momjian [Sun, 2 Jul 2006 01:59:46 +0000 (01:59 +0000)]
Done:

<  o Add ALTER TABLE tab ADD/DROP INHERITS parent
<
<    This allows tables to be added/removed from an inheritance
<    hierarchy.  This is particularly useful for table partitioning.
<    http://archives.postgresql.org/pgsql-hackers/2006-05/msg00988.php
<
>  o -Add ALTER TABLE tab INHERIT / NO INHERIT  parent

18 years agoALTER TABLE ... ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)
Bruce Momjian [Sun, 2 Jul 2006 01:58:36 +0000 (01:58 +0000)]
ALTER TABLE ... ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)

Open items:

There were a few tangentially related issues that have come up that I think
are TODOs. I'm likely to tackle one or two of these next so I'm interested in
hearing feedback on them as well.

. Constraints currently do not know anything about inheritance. Tom suggested
  adding a coninhcount and conislocal like attributes have to track their
  inheritance status.

. Foreign key constraints currently do not get copied to new children (and
  therefore my code doesn't verify them). I don't think it would be hard to
  add them and treat them like CHECK constraints.

. No constraints at all are copied to tables defined with LIKE. That makes it
  hard to use LIKE to define new partitions. The standard defines LIKE and
  specifically says it does not copy constraints. But the standard already has
  an option called INCLUDING DEFAULTS; we could always define a non-standard
  extension LIKE table INCLUDING CONSTRAINTS that gives the user the option to
  request a copy including constraints.

. Personally, I think the whole attislocal thing is bunk. The decision about
  whether to drop a column from children tables or not is something that
  should be up to the user and trying to DWIM based on whether there was ever
  a local definition or the column was acquired purely through inheritance is
  hardly ever going to match up with user expectations.

. And of course there's the whole unique and primary key constraint issue. I
  think to get any traction at all on this you have a prerequisite of a real
  partitioned table implementation where the system knows what the partition
  key is so it can recognize when it's a leading part of an index key.

Greg Stark

18 years agoFix oversight in planning for multiple indexscans driven by
Tom Lane [Sat, 1 Jul 2006 22:07:23 +0000 (22:07 +0000)]
Fix oversight in planning for multiple indexscans driven by
ScalarArrayOpExpr index quals: we were estimating the right total
number of rows returned, but treating the index-access part of the
cost as if a single scan were fetching that many consecutive index
tuples.  Actually we should treat it as a multiple indexscan, and
if there are enough of 'em the Mackert-Lohman discount should kick in.

18 years agoRevise the planner's handling of "pseudoconstant" WHERE clauses, that is
Tom Lane [Sat, 1 Jul 2006 18:38:33 +0000 (18:38 +0000)]
Revise the planner's handling of "pseudoconstant" WHERE clauses, that is
clauses containing no variables and no volatile functions.  Such a clause
can be used as a one-time qual in a gating Result plan node, to suppress
plan execution entirely when it is false.  Even when the clause is true,
putting it in a gating node wins by avoiding repeated evaluation of the
clause.  In previous PG releases, query_planner() would do this for
pseudoconstant clauses appearing at the top level of the jointree, but
there was no ability to generate a gating Result deeper in the plan tree.
To fix it, get rid of the special case in query_planner(), and instead
process pseudoconstant clauses through the normal RestrictInfo qual
distribution mechanism.  When a pseudoconstant clause is found attached to
a path node in create_plan(), pull it out and generate a gating Result at
that point.  This requires special-casing pseudoconstants in selectivity
estimation and cost_qual_eval, but on the whole it's pretty clean.
It probably even makes the planner a bit faster than before for the normal
case of no pseudoconstants, since removing pull_constant_clauses saves one
useless traversal of the qual tree.  Per gripe from Phil Frost.

18 years agoFix memory leak introduced in the prior commit, detected by Tom Lane.
Alvaro Herrera [Fri, 30 Jun 2006 16:55:35 +0000 (16:55 +0000)]
Fix memory leak introduced in the prior commit, detected by Tom Lane.

18 years agoFix use-after-free error reported by Neil Conway.
Alvaro Herrera [Fri, 30 Jun 2006 15:06:05 +0000 (15:06 +0000)]
Fix use-after-free error reported by Neil Conway.

18 years agoUpdate item for GUID:
Bruce Momjian [Fri, 30 Jun 2006 15:04:32 +0000 (15:04 +0000)]
Update item for GUID:

< * Add 128-bit Universally Unique Identifier (UUID)
> * Add Globally/Universally Unique Identifier (GUID/UUID)

18 years agoRemove the separate 'stats buffer' process, letting backend stats messages
Tom Lane [Thu, 29 Jun 2006 20:00:08 +0000 (20:00 +0000)]
Remove the separate 'stats buffer' process, letting backend stats messages
be delivered directly to the collector process.  The extra process context
swaps required to transfer data through the buffer process seem to outweigh
any value the buffering might have.  Per recent discussion and tests.
I modified Bruce's draft patch to use poll() rather than select() where
available (this makes a noticeable difference on my system), and fixed
up the EXEC_BACKEND case.

18 years agoChange TRUNCATE's method for searching for foreign-key references so that
Tom Lane [Thu, 29 Jun 2006 16:07:29 +0000 (16:07 +0000)]
Change TRUNCATE's method for searching for foreign-key references so that
the order in which it visits tables is not dependent on the physical order
of pg_constraint entries, and neither are the error messages it gives.
This should correct recently-noticed instability in regression tests.

18 years agoChange URL for SITC:
Bruce Momjian [Thu, 29 Jun 2006 03:04:59 +0000 (03:04 +0000)]
Change URL for SITC:

<   http://momjian.us/cgi-bin/pgsitc
>   http://archives.postgresql.org/pgsql-hackers/2006-06/msg01534.php

18 years agoAdd:
Bruce Momjian [Thu, 29 Jun 2006 01:33:36 +0000 (01:33 +0000)]
Add:

> * Add 128-bit Universally Unique Identifier (UUID)

18 years agoAdd missing #include directive: pg_constraint.h declares some functions
Neil Conway [Wed, 28 Jun 2006 22:11:01 +0000 (22:11 +0000)]
Add missing #include directive: pg_constraint.h declares some functions
whose prototypes include the "List" type, so it ought to include the
list header file.

18 years agoFix typo in comment.
Neil Conway [Wed, 28 Jun 2006 22:05:37 +0000 (22:05 +0000)]
Fix typo in comment.

18 years agoEditorialization for the additions to the CREATE TABLE reference page
Neil Conway [Wed, 28 Jun 2006 22:01:52 +0000 (22:01 +0000)]
Editorialization for the additions to the CREATE TABLE reference page
made as part of the recent INCLUDING CONSTRAINTS patch. The text could
stand further improvement, but this is at least a step in the right
direction.

18 years agoAdd URL for SITC
Bruce Momjian [Wed, 28 Jun 2006 21:05:22 +0000 (21:05 +0000)]
Add URL for SITC

>   http://momjian.us/cgi-bin/pgsitc

18 years agoImprove planner estimates for size of tuple hash tables.
Tom Lane [Wed, 28 Jun 2006 20:04:38 +0000 (20:04 +0000)]
Improve planner estimates for size of tuple hash tables.

18 years agoFix hash aggregation to suppress unneeded columns from being stored in
Tom Lane [Wed, 28 Jun 2006 19:40:52 +0000 (19:40 +0000)]
Fix hash aggregation to suppress unneeded columns from being stored in
tuple hash table entries.  This addresses the problem previously noted
that use of a 'physical tlist' in the input scan node could bloat the
hash table entries far beyond what the planner expects.  It's a better
answer than my previous thought of undoing the physical tlist optimization,
because we can also remove columns that are needed to compute the aggregate
functions but aren't part of the grouping column set.

18 years agoAdjust TupleHashTables to use MinimalTuple format for contained tuples.
Tom Lane [Wed, 28 Jun 2006 17:05:49 +0000 (17:05 +0000)]
Adjust TupleHashTables to use MinimalTuple format for contained tuples.

18 years agoUpdate:
Bruce Momjian [Wed, 28 Jun 2006 15:39:32 +0000 (15:39 +0000)]
Update:

<  o Add support for WITH HOLD cursors
>  o Add support for WITH HOLD and SCROLL cursors
>
>    PL/pgSQL cursors should support the same syntax as
>    backend cursors.
>

18 years agoUpdate Russian FAQ.
Bruce Momjian [Wed, 28 Jun 2006 13:10:18 +0000 (13:10 +0000)]
Update Russian FAQ.

Viktor Vislobokov

18 years agoForget to add new file :((
Teodor Sigaev [Wed, 28 Jun 2006 12:08:35 +0000 (12:08 +0000)]
Forget to add new file :((

18 years agoChanges
Teodor Sigaev [Wed, 28 Jun 2006 12:00:14 +0000 (12:00 +0000)]
Changes
* new split algorithm (as proposed in http://archives.postgresql.org/pgsql-hackers/2006-06/msg00254.php)
  * possible call pickSplit() for second and below columns
  * add spl_(l|r)datum_exists to GIST_SPLITVEC -
    pickSplit should check its values to use already defined
    spl_(l|r)datum for splitting. pickSplit should set
    spl_(l|r)datum_exists to 'false' (if they was 'true') to
    signal to caller about using spl_(l|r)datum.
  * support for old pickSplit(): not very optimal
    but correct split
* remove 'bytes' field from GISTENTRY: in any case size of
  value is defined by it's type.
* split GIST_SPLITVEC to two structures: one for using in picksplit
  and second - for internal use.
* some code refactoring
* support of subsplit to rtree opclasses

TODO: add support of subsplit to contrib modules

18 years agoRemove embedded newline in string literal --- seems to make newer gcc
Tom Lane [Tue, 27 Jun 2006 23:25:28 +0000 (23:25 +0000)]
Remove embedded newline in string literal --- seems to make newer gcc
versions very unhappy, and shouldn't be there anyway.

18 years agoAdd GUC update_process_title to control whether 'ps' display is updated
Bruce Momjian [Tue, 27 Jun 2006 22:16:44 +0000 (22:16 +0000)]
Add GUC update_process_title to control whether 'ps' display is updated
for every command, default to on.

18 years agoConvert hash join code to use MinimalTuple format in tuple hash table
Tom Lane [Tue, 27 Jun 2006 21:31:20 +0000 (21:31 +0000)]
Convert hash join code to use MinimalTuple format in tuple hash table
and batch files.  Should reduce memory and I/O demands for such joins.

18 years agoDefault stats_command_string to 'on', now that its overhead is minimal.
Bruce Momjian [Tue, 27 Jun 2006 19:07:50 +0000 (19:07 +0000)]
Default stats_command_string to 'on', now that its overhead is minimal.

18 years agoPut #ifdef NOT_USED around posix_fadvise call. We may want to resurrect
Tom Lane [Tue, 27 Jun 2006 18:59:17 +0000 (18:59 +0000)]
Put #ifdef NOT_USED around posix_fadvise call.  We may want to resurrect
this someday, but right now it seems that posix_fadvise is immature to
the point of being broken on many platforms ... and we don't have any
benchmark evidence proving it's worth spending time on.

18 years agoRevert patch, doesn't do what it should:
Bruce Momjian [Tue, 27 Jun 2006 18:35:05 +0000 (18:35 +0000)]
Revert patch, doesn't do what it should:

* %Disallow changing default expression of a SERIAL column

Dhanaraj M

18 years agoExtend the MinimalTuple concept to tuplesort.c, thereby reducing the
Tom Lane [Tue, 27 Jun 2006 16:53:02 +0000 (16:53 +0000)]
Extend the MinimalTuple concept to tuplesort.c, thereby reducing the
per-tuple space overhead for sorts in memory.  I chose to replace the
previous patch that tried to write out the bare minimum amount of data
when sorting on disk; instead, just dump the MinimalTuples as-is.  This
wastes 3 to 10 bytes per tuple depending on architecture and null-bitmap
length, but the simplification in the writetup/readtup routines seems
worth it.

18 years agoWill revert in next patch more cleanly.
Bruce Momjian [Tue, 27 Jun 2006 16:42:00 +0000 (16:42 +0000)]
Will revert in next patch more cleanly.

> * -Disallow changing DEFAULT expression of a SERIAL column

18 years agoNot done:
Bruce Momjian [Tue, 27 Jun 2006 16:39:27 +0000 (16:39 +0000)]
Not done:

< * -Disallow changing DEFAULT expression of a SERIAL column
> * %Disallow changing DEFAULT expression of a SERIAL column

18 years agoClamp last_anl_tuples to n_live_tuples, in case we vacuum a table without
Alvaro Herrera [Tue, 27 Jun 2006 03:45:16 +0000 (03:45 +0000)]
Clamp last_anl_tuples to n_live_tuples, in case we vacuum a table without
analyzing, so that future analyze threshold calculations don't get confused.
Also, make sure we correctly track the decrease of live tuples cause by
deletes.

Per report from Dylan Hansen, patches by Tom Lane and me.

18 years agoAdd INCLUDING CONSTRAINTS to CREATE TABLE LIKE.
Bruce Momjian [Tue, 27 Jun 2006 03:43:20 +0000 (03:43 +0000)]
Add INCLUDING CONSTRAINTS to CREATE TABLE LIKE.

Greg Stark

18 years agoDone:
Bruce Momjian [Tue, 27 Jun 2006 03:22:45 +0000 (03:22 +0000)]
Done:

< * %Disallow changing DEFAULT expression of a SERIAL column?
<
<   This should be done only if the existing SERIAL problems cannot be
<   fixed.
<
> * -Disallow changing DEFAULT expression of a SERIAL column

18 years agoDisallow changing/dropping default expression of a SERIAL column
Bruce Momjian [Tue, 27 Jun 2006 03:21:55 +0000 (03:21 +0000)]
Disallow changing/dropping default expression of a SERIAL column

Dhanaraj M

18 years agoFix for recent Win32 pg_dump tar temp file patch.
Bruce Momjian [Tue, 27 Jun 2006 02:56:41 +0000 (02:56 +0000)]
Fix for recent Win32 pg_dump tar temp file patch.

Hiroshi Saito