]> granicus.if.org Git - python/log
python
4 years agobpo-38332: Catch KeyError from unknown cte in encoded-word. (GH-16503)
Andrei Troie [Sat, 5 Oct 2019 16:19:15 +0000 (17:19 +0100)]
bpo-38332: Catch KeyError from unknown cte in encoded-word. (GH-16503)

KeyError should cause a failure in parsing the encoded word and should be caught and raised as a _InvalidEWError instead.

4 years agobpo-38341: Add SMTPNotSupportedError in the exports of smtplib (#16525)
nde [Sat, 5 Oct 2019 00:30:58 +0000 (02:30 +0200)]
bpo-38341: Add SMTPNotSupportedError in the exports of smtplib (#16525)

Add SMTPNotSupportedError in the exports of smtplib

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
4 years agobpo-38353: getpath.c: allocates strings on the heap (GH-16585)
Victor Stinner [Fri, 4 Oct 2019 17:53:43 +0000 (19:53 +0200)]
bpo-38353: getpath.c: allocates strings on the heap (GH-16585)

* _Py_FindEnvConfigValue() now returns a string allocated
  by PyMem_RawMalloc().
* calculate_init() now decodes VPATH macro.
* Add calculate_open_pyenv() function.
* Add substring() and joinpath2() functions.

* Fix add_exe_suffix()

And a few cleanup changes.

4 years agobpo-38353: getpath.c uses dynamically allocated strings (GH-16582)
Victor Stinner [Fri, 4 Oct 2019 13:25:50 +0000 (15:25 +0200)]
bpo-38353: getpath.c uses dynamically allocated strings (GH-16582)

* PyCalculatePath: add "_macro" to the 3 fields storing macro values
* Add dynamically allocated strings to PyCalculatePath

4 years agobpo-38266: Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal (GH-16558)
Joannah Nanjekye [Fri, 4 Oct 2019 11:35:42 +0000 (08:35 -0300)]
bpo-38266: Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal (GH-16558)

Revert the removal of PyThreadState_DeleteCurrent() with documentation.

4 years agobpo-13153: Use OS native encoding for converting between Python and Tcl. (GH-16545)
Serhiy Storchaka [Fri, 4 Oct 2019 10:09:52 +0000 (13:09 +0300)]
bpo-13153: Use OS native encoding for converting between Python and Tcl. (GH-16545)

On Windows use UTF-16 (or UTF-32 for 32-bit Tcl_UniChar) with the
"surrogatepass" error handler for converting to/from Tcl Unicode objects.

On Linux use UTF-8 with the "surrogateescape" error handler for converting
to/from Tcl String objects.

Converting strings from Tcl to Python and back now never fails
(except MemoryError).

4 years agoUpdated CODEOWNERS to indicate ownership of some modules. (GH-16578)
Vinay Sajip [Fri, 4 Oct 2019 08:48:24 +0000 (09:48 +0100)]
Updated CODEOWNERS to indicate ownership of some modules. (GH-16578)

4 years agobpo-38235: Correct some arguments names in logging documentation (GH-16571)
Ashley Whetter [Fri, 4 Oct 2019 07:55:14 +0000 (00:55 -0700)]
bpo-38235: Correct some arguments names in logging documentation (GH-16571)

4 years agobpo-38353: Rework ismodule() in getpath.c (GH-16574)
Victor Stinner [Fri, 4 Oct 2019 01:53:26 +0000 (03:53 +0200)]
bpo-38353: Rework ismodule() in getpath.c (GH-16574)

* ismodule() no longer modify the input string.
* copy_absolute(), joinpath(): rename parameters and local variables.

4 years agobpo-38353: Add subfunctions to getpath.c (GH-16572)
Victor Stinner [Fri, 4 Oct 2019 00:22:39 +0000 (02:22 +0200)]
bpo-38353: Add subfunctions to getpath.c (GH-16572)

Following symbolic links is now limited to 40 attempts, just to
prevent loops.

Add subfunctions:

* Add resolve_symlinks()
* Add calculate_argv0_path_framework()
* Add calculate_which()
* Add calculate_program_macos()

Fix also _Py_wreadlink(): readlink() result type is Py_ssize_t, not
int.

4 years agobpo-38353: Fix compiler warning in internal headers (GH-16573)
Victor Stinner [Fri, 4 Oct 2019 00:21:05 +0000 (02:21 +0200)]
bpo-38353: Fix compiler warning in internal headers (GH-16573)

Replace "_PyRuntimeState" with "struct pyruntimestate" to avoid
a warning on typedef re-definition.

4 years agobpo-38353: Fix compiler warning in pycore_initconfig.h (GH-16570)
Victor Stinner [Thu, 3 Oct 2019 22:43:10 +0000 (00:43 +0200)]
bpo-38353: Fix compiler warning in pycore_initconfig.h (GH-16570)

Replace "_PyRuntimeState" with "struct pyruntimestate" to avoid
a warning on typedef re-definition.

4 years agobpo-38353: Fix calculate_argv0_path() for symlinks (GH-16549)
Victor Stinner [Thu, 3 Oct 2019 21:17:00 +0000 (23:17 +0200)]
bpo-38353: Fix calculate_argv0_path() for symlinks (GH-16549)

calculate_argv0_path() must read argv0_path link, not read
program_full_path link.

4 years agobpo-34344 Fix AbstractEventLoopPolicy.get_event_loop docstring (GH-16463)
idomic [Thu, 3 Oct 2019 21:08:29 +0000 (00:08 +0300)]
bpo-34344 Fix AbstractEventLoopPolicy.get_event_loop docstring (GH-16463)

4 years agobpo-38359: Ensures pyw.exe launcher reads correct registry key (GH-16561)
Steve Dower [Thu, 3 Oct 2019 15:31:21 +0000 (08:31 -0700)]
bpo-38359: Ensures pyw.exe launcher reads correct registry key (GH-16561)

4 years agobpo-38355: Fix ntpath.realpath failing on sys.executable (GH-16551)
Steve Dower [Thu, 3 Oct 2019 15:31:03 +0000 (08:31 -0700)]
bpo-38355: Fix ntpath.realpath failing on sys.executable (GH-16551)

4 years agobpo-36670: Enhance regrtest (GH-16556)
Victor Stinner [Thu, 3 Oct 2019 14:15:16 +0000 (16:15 +0200)]
bpo-36670: Enhance regrtest (GH-16556)

* Add log() method: add timestamp and load average prefixes
  to main messages.
* WindowsLoadTracker:

  * LOAD_FACTOR_1 is now computed using SAMPLING_INTERVAL
  * Initialize the load to the arithmetic mean of the first 5 values
    of the Processor Queue Length value (so over 5 seconds), rather
    than 0.0.
  * Handle BrokenPipeError and when typeperf exit.

* format_duration(1.5) now returns '1.5 sec', rather than
  '1 sec 500 ms'

4 years agobpo-36670: Enhance regrtest WindowsLoadTracker (GH-16553)
Victor Stinner [Thu, 3 Oct 2019 08:53:17 +0000 (10:53 +0200)]
bpo-36670: Enhance regrtest WindowsLoadTracker (GH-16553)

The last line is now passed to the parser even if it does not end
with a newline, but only if it's a valid value.

4 years agobpo-36670, regrtest: Fix WindowsLoadTracker() for partial line (GH-16550)
Victor Stinner [Wed, 2 Oct 2019 23:04:09 +0000 (01:04 +0200)]
bpo-36670, regrtest: Fix WindowsLoadTracker() for partial line (GH-16550)

WindowsLoadTracker.read_output() now uses a short buffer for
incomplete line.

4 years agobpo-38353: Cleanup includes in the internal C API (GH-16548)
Victor Stinner [Wed, 2 Oct 2019 21:51:20 +0000 (23:51 +0200)]
bpo-38353: Cleanup includes in the internal C API (GH-16548)

Use forward declaration of types to avoid includes in the internal C
API. Add also comment to justify other includes.

4 years agobpo-38338, test.pythoninfo: add more ssl infos (GH-16539)
Victor Stinner [Wed, 2 Oct 2019 15:52:35 +0000 (17:52 +0200)]
bpo-38338, test.pythoninfo: add more ssl infos (GH-16539)

test.pythoninfo now logs environment variables used by OpenSSL and
Python ssl modules, and logs attributes of 3 SSL contexts
(SSLContext, default HTTPS context, stdlib context).

4 years agobpo-36670: regrtest bug fixes (GH-16537)
Victor Stinner [Wed, 2 Oct 2019 11:35:11 +0000 (13:35 +0200)]
bpo-36670: regrtest bug fixes (GH-16537)

* Fix TestWorkerProcess.__repr__(): start_time is only valid
  if _popen is not None.
* Fix _kill(): don't set _killed to True if _popen is None.
* _run_process(): only set _killed to False after calling
  run_test_in_subprocess().

4 years agobpo-38343: Fixes version handling for nuget packages (GH-16527)
Steve Dower [Tue, 1 Oct 2019 23:42:24 +0000 (16:42 -0700)]
bpo-38343: Fixes version handling for nuget packages (GH-16527)

4 years agobpo-37802: Fix a compiler warning in longobject.c (GH-16517)
Victor Stinner [Tue, 1 Oct 2019 11:29:53 +0000 (13:29 +0200)]
bpo-37802: Fix a compiler warning in longobject.c (GH-16517)

bpo-37802, bpo-38321: Fix the following warnings:

    longobject.c(420): warning C4244: 'function': conversion from
    'unsigned __int64' to 'sdigit', possible loss of data

    longobject.c(428): warning C4267: 'function': conversion from
    'size_t' to 'sdigit', possible loss of data

4 years agobpo-37474: Don't call fedisableexcept() on FreeBSD (GH-16515)
Victor Stinner [Tue, 1 Oct 2019 11:12:29 +0000 (13:12 +0200)]
bpo-37474: Don't call fedisableexcept() on FreeBSD (GH-16515)

On FreeBSD, Python no longer calls fedisableexcept() at startup to
control the floating point control mode. The call became useless
since FreeBSD 6: it became the default mode.

4 years agobpo-38321: Fix compiler warning in _randommodule.c (GH-16512)
Victor Stinner [Tue, 1 Oct 2019 10:45:52 +0000 (12:45 +0200)]
bpo-38321: Fix compiler warning in _randommodule.c (GH-16512)

Fix the GCC warning: "initialization discards ‘const’ qualifier from
pointer target type".

4 years agobpo-36670: Multiple regrtest bugfixes (GH-16511)
Victor Stinner [Tue, 1 Oct 2019 10:29:36 +0000 (12:29 +0200)]
bpo-36670: Multiple regrtest bugfixes (GH-16511)

* Windows: Fix counter name in WindowsLoadTracker. Counter names are
  localized: use the registry to get the counter name. Original
  change written by Lorenz Mende.
* Regrtest.main() now ensures that the Windows load tracker is also
  killed if an exception is raised
* TestWorkerProcess now ensures that worker processes are no longer
  running before exiting: kill also worker processes when an
  exception is raised.
* Enhance regrtest messages and warnings: include test name,
  duration, add a worker identifier, etc.
* Rename MultiprocessRunner to TestWorkerProcess
* Use print_warning() to display warnings.

Co-Authored-By: Lorenz Mende <Lorenz.mende@gmail.com>
4 years agobpo-38304: PyConfig_InitPythonConfig() cannot fail anymore (GH-16509)
Victor Stinner [Tue, 1 Oct 2019 10:06:16 +0000 (12:06 +0200)]
bpo-38304: PyConfig_InitPythonConfig() cannot fail anymore (GH-16509)

PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no
longer return PyStatus: they cannot fail anymore.

4 years agobpo-38304: Remove PyConfig.struct_size (GH-16500) (GH-16508)
Victor Stinner [Tue, 1 Oct 2019 08:56:37 +0000 (10:56 +0200)]
bpo-38304: Remove PyConfig.struct_size (GH-16500) (GH-16508)

For now, we'll rely on the fact that the config structures aren't covered by the stable ABI.

We may revisit this in the future if we further explore the idea of offering a stable embedding API.

(cherry picked from commit bdace21b769998396d0ccc8da99a8ca9b507bfdf)

4 years agobpo-38319: Fix shutil._fastcopy_sendfile(): set sendfile() max block size (GH-16491)
Giampaolo Rodola [Tue, 1 Oct 2019 03:40:54 +0000 (11:40 +0800)]
bpo-38319: Fix shutil._fastcopy_sendfile(): set sendfile() max block size (GH-16491)

4 years agobpo-32689: Updates shutil.move to allow for Path objects to be used as source arg...
Maxwell A McKinnon [Tue, 1 Oct 2019 02:41:16 +0000 (19:41 -0700)]
bpo-32689: Updates shutil.move to allow for Path objects to be used as source arg (GH-15326)

Important work originally done by @emilyemorehouse two years ago and nearly ready to go in.

This bug has affected many people and in some cases has been a dealbreaker to the adoption of the otherwise wonderful pathlib and PEP519. https://stackoverflow.com/questions/33625931/copy-file-with-pathlib-in-python.

This adds the outstanding test request from that PR @vstinner (https://github.com/python/cpython/pull/5393).

Test fails without the change, passes with it, along with every other test in test_shutil.

Some variants were experimented with to make the one line change and the most performant one was picked.

# Added Test for PathLike directory destination, the current fail case

```
Lib/test/test_shutil.py::TestMove::test_move_file_pathlike FAILED                                                               [100%]

============================================================== FAILURES ===============================================================
__________________________________________________ TestMove.test_move_file_pathlike ___________________________________________________

self = <test.test_shutil.TestMove testMethod=test_move_file_pathlike>

    def test_move_file_pathlike(self):
        # Move a file to another location on the same filesystem.
        src = pathlib.Path(self.src_file)
>       self._check_move_file(src, self.dst_dir, self.dst_file)

Lib/test/test_shutil.py:1563:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
Lib/test/test_shutil.py:1545: in _check_move_file
    shutil.move(src, dst)
/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/shutil.py:562: in move
    real_dst = os.path.join(dst, _basename(src))
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

path = PosixPath('/var/folders/r2/psq74t5x3nbfzlph8bh2pvdw0000gn/T/tmp9ie0wh9_/foo')

    def _basename(path):
        # A basename() variant which first strips the trailing slash, if present.
        # Thus we always get the last component of the path, even for directories.
        sep = os.path.sep + (os.path.altsep or '')
>       return os.path.basename(path.rstrip(sep))
E       AttributeError: 'PosixPath' object has no attribute 'rstrip'

/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/shutil.py:526: AttributeError
============================================== 1 failed, 102 deselected in 0.30 seconds ===============================================
```

After change:

```
========================================================= test session starts =========================================================
platform darwin -- Python 3.7.4, pytest-5.0.1, py-1.8.0, pluggy-0.12.0 -- /Users/maxwellmckinnon/.venvs/TA3.7/bin/python3.7
cachedir: .pytest_cache
rootdir: /Users/maxwellmckinnon/dev/cpython
plugins: cov-2.7.1, mock-1.10.4
collected 103 items / 102 deselected / 1 selected

Lib/test/test_shutil.py::TestMove::test_move_file_pathlike PASSED                                                               [100%]

============================================== 1 passed, 102 deselected in 0.06 seconds ===============================================
```

Running all the tests in test_shutil.py
```
╰─ pytest Lib/test/test_shutil.py -v
========================================================= test session starts =========================================================
platform darwin -- Python 3.7.4, pytest-5.0.1, py-1.8.0, pluggy-0.12.0 -- /Users/maxwellmckinnon/.venvs/TA3.7/bin/python3.7
cachedir: .pytest_cache
rootdir: /Users/maxwellmckinnon/dev/cpython
plugins: cov-2.7.1, mock-1.10.4
collected 103 items

Lib/test/test_shutil.py::TestShutil::test_chown PASSED                                                                          [  0%]
Lib/test/test_shutil.py::TestShutil::test_copy PASSED                                                                           [  1%]
...
Lib/test/test_shutil.py::TermsizeTests::test_stty_match SKIPPED                                                                 [ 99%]
Lib/test/test_shutil.py::PublicAPITests::test_module_all_attribute PASSED                                                       [100%]

================================================ 96 passed, 7 skipped in 1.25 seconds =================================================
```

# Performance Considerations
Is it considered poor form to get rid of _basename altogether and make use of pathlib in the move function? I'm not sure if the idea is for all these modules to strictly avoid circular dependencies. They are already using os.path which is just as much a citizen in 3.8 as pathlib right?

e.g.

`real_dst = os.path.join(dst, _basename(src))`
becomes
`real_dst = Path(dst) / Path(src).name`

I've looked around and familiarized myself, and I now think importing pathlib here is fine. My only remaining concern is that of performance.

Here's the performance difference for this step.

```
In [46]: %timeit real_dst = os.path.join("a/b/c", _basename('b/'))
2.71 µs ± 62.6 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

In [47]: %timeit real_dst = Path("a/b/c") / Path('b/').name
12.4 µs ± 65.3 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
```

Is 10us significant or insignificant compared to the least expensive operation this function will do? I don't know. Let's find out.

```
In [55]: %timeit os.rename('/tmp/a/a.txt', '/tmp/a/b.txt'); os.rename('/tmp/a/b.txt', '/tmp/a/a.txt')
124 µs ± 2.18 µs per loop (mean ± std. dev. of 7 runs, 10000 loops each)
```
62us to rename. 10us seems significant enough that we wouldn't want to favor the Path sugar suggestion. 16% speed decrease from adding the 10us.

What do people think? I was hoping to get to use pathlib.Path here, but I suspect for this low level move, it should be as fast as possible, and 16% is not worth one line of sugary code to me.

https://bugs.python.org/issue32689

Automerge-Triggered-By: @gvanrossum
4 years agoFix and improve `asyncio.run()` docs (GH-16403)
Kyle Stanley [Tue, 1 Oct 2019 00:12:21 +0000 (20:12 -0400)]
Fix and improve `asyncio.run()` docs (GH-16403)

4 years agobpo-38321: Fix _testcapimodule.c warning (GH-16494)
Victor Stinner [Mon, 30 Sep 2019 19:14:26 +0000 (21:14 +0200)]
bpo-38321: Fix _testcapimodule.c warning (GH-16494)

Fix the following warning:

    modules\_testcapimodule.c(6409):
    warning C4146: unary minus operator applied to unsigned type,
    result still unsigned

4 years agoClear weakrefs in garbage found by the GC (#16495)
Neil Schemenauer [Mon, 30 Sep 2019 17:06:45 +0000 (10:06 -0700)]
Clear weakrefs in garbage found by the GC (#16495)

Fix a bug due to the interaction of weakrefs and the cyclic garbage
collector. We must clear any weakrefs in garbage in order to prevent
their callbacks from executing and causing a crash.

4 years agobpo-38321: Fix PyCStructUnionType_update_stgdict() warning (GH-16492)
Victor Stinner [Mon, 30 Sep 2019 15:49:48 +0000 (17:49 +0200)]
bpo-38321: Fix PyCStructUnionType_update_stgdict() warning (GH-16492)

bpo-22273, bpo-38321: Fix following warning:

    modules\_ctypes\stgdict.c(704):
    warning C4244: 'initializing': conversion from 'Py_ssize_t' to 'int', possible loss of data

4 years agobpo-38321: Fix _asynciomodule.c compiler warning (GH-16493)
Victor Stinner [Mon, 30 Sep 2019 14:41:34 +0000 (16:41 +0200)]
bpo-38321: Fix _asynciomodule.c compiler warning (GH-16493)

bpo-38248, bpo-38321: Fix warning:

    modules\_asynciomodule.c(2667):
    warning C4102: 'set_exception': unreferenced label

The related goto has been removed by
commit edad4d89e357c92f70c0324b937845d652b20afd.

4 years agobpo-38322: Fix gotlandmark() of PC/getpathp.c (GH-16489)
Victor Stinner [Mon, 30 Sep 2019 12:49:34 +0000 (14:49 +0200)]
bpo-38322: Fix gotlandmark() of PC/getpathp.c (GH-16489)

Write the filename into a temporary buffer instead of reusing prefix.
The problem is that join() modifies prefix inplace. If prefix is not
normalized, join() can make prefix shorter and so gotlandmark()
does modify prefix instead of returning it unmodified.

4 years agobpo-38304: Fix PyConfig usage in python_uwp.cpp (GH-16487)
Victor Stinner [Mon, 30 Sep 2019 10:52:29 +0000 (12:52 +0200)]
bpo-38304: Fix PyConfig usage in python_uwp.cpp (GH-16487)

* Set PyPreConfig.struct_size and PyConfig.struct_size as required by
  the API.
* PyPreConfig_InitPythonConfig() can now fail: check PyStatus result.

4 years agobpo-30773: Fix ag_running; prohibit running athrow/asend/aclose in parallel (#7468)
Yury Selivanov [Mon, 30 Sep 2019 05:59:11 +0000 (22:59 -0700)]
bpo-30773: Fix ag_running; prohibit running athrow/asend/aclose in parallel (#7468)

4 years agobpo-38242: Revert "bpo-36889: Merge asyncio streams (GH-13251)" (#16482)
Yury Selivanov [Mon, 30 Sep 2019 04:59:55 +0000 (21:59 -0700)]
bpo-38242: Revert "bpo-36889: Merge asyncio streams (GH-13251)" (#16482)

See https://bugs.python.org/issue38242 for more details

4 years agobpo-38163: Child mocks detect their type as sync or async (GH-16471)
Lisa Roach [Mon, 30 Sep 2019 04:56:47 +0000 (21:56 -0700)]
bpo-38163: Child mocks detect their type as sync or async (GH-16471)

4 years agobpo-37096: Add large-file tests for modules using sendfile(2) (GH-13676)
Giampaolo Rodola [Mon, 30 Sep 2019 04:51:55 +0000 (12:51 +0800)]
bpo-37096: Add large-file tests for modules using sendfile(2) (GH-13676)

4 years agobpo-38161: Removes _AwaitEvent from AsyncMock. (GH-16443)
Lisa Roach [Mon, 30 Sep 2019 04:01:28 +0000 (21:01 -0700)]
bpo-38161: Removes _AwaitEvent from AsyncMock. (GH-16443)

4 years agobpo-38317: Fix PyConfig.warnoptions priority (GH-16478)
Victor Stinner [Sun, 29 Sep 2019 23:40:17 +0000 (01:40 +0200)]
bpo-38317: Fix PyConfig.warnoptions priority (GH-16478)

Fix warnings options priority: PyConfig.warnoptions has the highest
priority, as stated in the PEP 587.

* Document options order in PyConfig.warnoptions documentation.
* Make PyWideStringList_INIT macro private: replace "Py" prefix
  with "_Py".
* test_embed: add test_init_warnoptions().

4 years agobpo-38019: correctly handle pause/resume reading of closed asyncio unix pipe (GH...
Andrew Svetlov [Sun, 29 Sep 2019 12:00:35 +0000 (15:00 +0300)]
bpo-38019: correctly handle pause/resume reading of closed asyncio unix pipe (GH-16472)

5 years agobpo-38108: Makes mock objects inherit from Base (GH-16060)
Lisa Roach [Sun, 29 Sep 2019 01:42:44 +0000 (18:42 -0700)]
bpo-38108: Makes mock objects inherit from Base (GH-16060)

5 years agobpo-38310: Predict BUILD_MAP_UNPACK_WITH_CALL -> CALL_FUNCTION_EX. (GH-16467)
Brandt Bucher [Sun, 29 Sep 2019 00:12:49 +0000 (17:12 -0700)]
bpo-38310: Predict BUILD_MAP_UNPACK_WITH_CALL -> CALL_FUNCTION_EX. (GH-16467)

5 years agobpo-37408: Precise that Tarfile "format" argument only concerns writing. (GH-14389)
Pascal Chambon [Sat, 28 Sep 2019 15:04:44 +0000 (17:04 +0200)]
bpo-37408: Precise that Tarfile "format" argument only concerns writing. (GH-14389)

5 years agobpo-38115: Deal with invalid bytecode offsets in lnotab (GH-16079)
T. Wouters [Sat, 28 Sep 2019 14:49:15 +0000 (16:49 +0200)]
bpo-38115: Deal with invalid bytecode offsets in lnotab (GH-16079)

Document that lnotab can contain invalid bytecode offsets (because of
terrible reasons that are difficult to fix). Make dis.findlinestarts()
ignore invalid offsets in lnotab. All other uses of lnotab in CPython
(various reimplementations of addr2line or line2addr in Python, C and gdb)
already ignore this, because they take an address to look for, instead.

Add tests for the result of dis.findlinestarts() on wacky constructs in
test_peepholer.py, because it's the easiest place to add them.

5 years agobpo-38216, bpo-36274: Allow subclasses to separately override validation and encoding...
Jason R. Coombs [Sat, 28 Sep 2019 12:32:01 +0000 (08:32 -0400)]
bpo-38216, bpo-36274: Allow subclasses to separately override validation and encoding behavior (GH-16448)

* bpo-38216: Allow bypassing input validation

* bpo-36274: Also allow the URL encoding to be overridden.

* bpo-38216, bpo-36274: Add tests demonstrating a hook for overriding validation, test demonstrating override encoding, and a test to capture expectation of the interface for the URL.

* Call with skip_host to avoid tripping on the host checking in the URL.

* Remove obsolete comment.

* Make _prepare_path_encoding its own attr.

This makes overriding just that simpler.

Also, don't use the := operator to make backporting easier.

* Add a news entry.

* _prepare_path_encoding -> _encode_prepared_path()

* Once again separate the path validation and request encoding, drastically simplifying the behavior. Drop the guarantee that all processing happens in _prepare_path.

5 years agobpo-38304: Add PyConfig.struct_size (GH-16451)
Victor Stinner [Sat, 28 Sep 2019 02:28:35 +0000 (04:28 +0200)]
bpo-38304: Add PyConfig.struct_size (GH-16451)

Add a new struct_size field to PyPreConfig and PyConfig structures to
allow to modify these structures in the future without breaking the
backward compatibility.

* Replace private _config_version field with public struct_size field
  in PyPreConfig and PyConfig.
* Public PyPreConfig_InitIsolatedConfig() and
  PyPreConfig_InitPythonConfig()
  return type becomes PyStatus, instead of void.
* Internal _PyConfig_InitCompatConfig(),
  _PyPreConfig_InitCompatConfig(), _PyPreConfig_InitFromConfig(),
  _PyPreConfig_InitFromPreConfig() return type becomes PyStatus,
  instead of void.
* Remove _Py_CONFIG_VERSION
* Update the Initialization Configuration documentation.

5 years agobpo-38301: In Solaris family, we must be sure to use '-D_REENTRANT' (#16446)
Jesús Cea [Sat, 28 Sep 2019 01:44:32 +0000 (03:44 +0200)]
bpo-38301: In Solaris family, we must be sure to use '-D_REENTRANT' (#16446)

5 years agobpo-38243, xmlrpc.server: Escape the server_title (GH-16373)
Dong-hee Na [Fri, 27 Sep 2019 19:59:37 +0000 (04:59 +0900)]
bpo-38243, xmlrpc.server: Escape the server_title (GH-16373)

Escape the server title of xmlrpc.server.DocXMLRPCServer
when rendering the document page as HTML.

5 years agoFix typo in the "Porting to Python 3.8" section. (GH-16435)
bariod [Fri, 27 Sep 2019 18:01:33 +0000 (20:01 +0200)]
Fix typo in the "Porting to Python 3.8" section. (GH-16435)

5 years agobpo-32820: Simplify __format__ implementation for ipaddress. (GH-16378)
Serhiy Storchaka [Fri, 27 Sep 2019 17:02:58 +0000 (20:02 +0300)]
bpo-32820: Simplify __format__ implementation for ipaddress. (GH-16378)

Also cache the compiled RE for parsing the format specifier.

5 years agobpo-38187: Fix a refleak in Tools/c-analyzer. (gh-16304)
Eric Snow [Fri, 27 Sep 2019 14:53:34 +0000 (15:53 +0100)]
bpo-38187: Fix a refleak in Tools/c-analyzer. (gh-16304)

The "Slot" helper (descriptor) is leaking references due to its caching mechanism. The change includes a partial fix to Slot, but also adds Variable.storage to replace the problematic use of Slot.

https://bugs.python.org/issue38187

5 years agobpo-38270: More fixes for strict crypto policy (GH-16418)
Christian Heimes [Fri, 27 Sep 2019 13:03:53 +0000 (15:03 +0200)]
bpo-38270: More fixes for strict crypto policy (GH-16418)

test_hmac and test_hashlib test built-in hashing implementations and
OpenSSL-based hashing implementations. Add more checks to skip OpenSSL
implementations when a strict crypto policy is active.

Use EVP_DigestInit_ex() instead of EVP_DigestInit() to initialize the
EVP context. The EVP_DigestInit() function clears alls flags and breaks
usedforsecurity flag again.

Signed-off-by: Christian Heimes <christian@python.org>
https://bugs.python.org/issue38270

5 years agobpo-38206: Clarify tp_dealloc requirements for heap allocated types. (GH-16248)
Ammar Askar [Fri, 27 Sep 2019 11:11:27 +0000 (07:11 -0400)]
bpo-38206: Clarify tp_dealloc requirements for heap allocated types. (GH-16248)

As mentioned in the bpo ticket, this mistake came up on two reviews:
- https://github.com/python/cpython/pull/16127#pullrequestreview-288312751
- https://github.com/python/cpython/pull/16071#pullrequestreview-287819525

Would be nice to have it documented in a more permanent place than 3.8's whatsnew entry.

https://bugs.python.org/issue38206

Automerge-Triggered-By: @encukou
5 years agocleanup ababstractproperty in typing.py (GH-16432)
HongWeipeng [Fri, 27 Sep 2019 07:54:26 +0000 (15:54 +0800)]
cleanup ababstractproperty in typing.py (GH-16432)

5 years agobpo-28009: Fix uuid.uuid1() and uuid.get_node() on AIX (GH-8672)
Michael Felt [Thu, 26 Sep 2019 19:43:15 +0000 (20:43 +0100)]
bpo-28009: Fix uuid.uuid1() and uuid.get_node() on AIX (GH-8672)

5 years agobpo-38275: Fix test_ssl issue caused by GH-16386 (#16428)
Christian Heimes [Thu, 26 Sep 2019 16:23:17 +0000 (18:23 +0200)]
bpo-38275: Fix test_ssl issue caused by GH-16386 (#16428)

Check presence of SSLContext.minimum_version to make tests pass with
old versions of OpenSSL.

Signed-off-by: Christian Heimes <christian@python.org>
5 years agobpo-38275: Skip ssl tests for disabled versions (GH-16386)
Christian Heimes [Thu, 26 Sep 2019 15:02:59 +0000 (17:02 +0200)]
bpo-38275: Skip ssl tests for disabled versions (GH-16386)

test_ssl now handles disabled TLS/SSL versions better. OpenSSL's crypto
policy and run-time settings are recognized and tests for disabled versions
are skipped.

Signed-off-by: Christian Heimes <christian@python.org>
https://bugs.python.org/issue38275

5 years agobpo-38239: Fix test_gdb for Link Time Optimization (LTO) (GH-16422)
Victor Stinner [Thu, 26 Sep 2019 14:54:13 +0000 (16:54 +0200)]
bpo-38239: Fix test_gdb for Link Time Optimization (LTO) (GH-16422)

5 years agobpo-38234: Py_Initialize() sets global path configuration (GH-16421)
Victor Stinner [Thu, 26 Sep 2019 13:51:50 +0000 (15:51 +0200)]
bpo-38234: Py_Initialize() sets global path configuration (GH-16421)

* Py_InitializeFromConfig() now writes PyConfig path configuration to
  the global path configuration (_Py_path_config).
* Add test_embed.test_get_pathconfig().
* Fix typo in _PyWideStringList_Join().

5 years agocompileall tests: Use shorter name for long_path test (GH-16419)
Petr Viktorin [Thu, 26 Sep 2019 13:16:32 +0000 (15:16 +0200)]
compileall tests: Use shorter name for long_path test (GH-16419)

Apparently, the path needs to be limited to 260 characters on
(some versions of) Windows.

5 years agobpo-38223: Reorganize test_shutil. (GH-16281)
Serhiy Storchaka [Thu, 26 Sep 2019 10:15:08 +0000 (13:15 +0300)]
bpo-38223: Reorganize test_shutil. (GH-16281)

* Group tests for specific functions and groups of related functions
into separate classes.
* Clean up creating and cleaning up temporary directories.
* Simplify and make more robust monkey patching of shutil.open.

5 years agobpo-38112: compileall: Skip long path path on Windows if the path can't be created...
Petr Viktorin [Thu, 26 Sep 2019 09:53:51 +0000 (11:53 +0200)]
bpo-38112: compileall: Skip long path path on Windows if the path can't be created (GH-16414)

This avoids the buildbot failure on Windows:
```
FileNotFoundError: [WinError 206] The filename or extension is too long: 'd:\\temp\\tmp5r3z438t\\long\\1\\2\\3\\4\\5\\6\\7\\8\\9\\10\\11\\12\\13\\14\\15\\16\\17\\18\\19\\20\\21\\22\\23\\24\\25\\26\\27\\28\\29\\30\\31\\32\\33\\34\\35\\36\\37\\38\\39\\40\\41\\42\\43\\44\\45\\46\\47\\48\\49\\50\\51\\52\\53\\54\\55\\56\\57\\58\\59\\60\\61\\62\\63\\64\\65\\66\\67\\68\\69\\70\\71\\72\\73\\74\\75\\76\\77\\78'
```
Creates a path that's long but avoids OS restrictions.

https://bugs.python.org/issue38112

5 years agobpo-38244: [Documentation] Fix unreliable link to sever in ftplib.rst (#16319)
Prateek Nayak [Thu, 26 Sep 2019 09:22:31 +0000 (14:52 +0530)]
bpo-38244: [Documentation] Fix unreliable link to sever in ftplib.rst (#16319)

5 years agobpo-38130: Fix error in explaining when an exception is re-raised (GH-16016)
Mohammad Dehghan [Thu, 26 Sep 2019 09:09:05 +0000 (12:39 +0330)]
bpo-38130: Fix error in explaining when an exception is re-raised (GH-16016)

Co-Authored-By: Ashwin Ramaswami <aramaswamis@gmail.com>
5 years agoDoc: Several fixes and improvements for 3.9 whatsnew (GH-16375)
Kyle Stanley [Thu, 26 Sep 2019 07:06:46 +0000 (03:06 -0400)]
Doc: Several fixes and improvements for 3.9 whatsnew (GH-16375)

5 years agoDoc: Use the `with` statement in the first example of the ftplib doc. (GH-16271)
Stéphane Wirtel [Thu, 26 Sep 2019 07:01:18 +0000 (09:01 +0200)]
Doc: Use the `with` statement in the first example of the ftplib doc. (GH-16271)

5 years agobpo-38112: Compileall improvements (GH-16012)
Lumír 'Frenzy' Balhar [Thu, 26 Sep 2019 06:28:26 +0000 (08:28 +0200)]
bpo-38112: Compileall improvements (GH-16012)

* Raise the limit of maximum path depth to actual  recursion limit

* Add posibilities to adjust a path compiled in .pyc  file.

Now, you can:
- Strip a part of path from a beggining of path into compiled file
   example "-s /test /test/build/real/test.py" → "build/real/test.py"
- Append some new path to a beggining of path into compiled file
   example "-p /boo real/test.py" → "/boo/real/test.py"

You can also use both options in the same time. In that case,
striping is done before appending.

* Add a possibility to specify multiple optimization levels

Each optimization level then leads to separated compiled file.
Use `action='append'` instead of `nargs='+'` for the -o option.
Instead of `-o 0 1 2`, specify `-o 0 -o 1 -o 2`. It's more to type,
but much more explicit.

* Add a symlinks limitation feature

This feature allows us to limit byte-compilation of symbolic
links if they are pointing outside specified dir (build root
for example).

5 years agocloses bpo-38174: Update vendored expat library to 2.2.8. (GH-16346)
Benjamin Peterson [Thu, 26 Sep 2019 04:33:58 +0000 (21:33 -0700)]
closes bpo-38174: Update vendored expat library to 2.2.8. (GH-16346)

Fixes CVE-2019-15903. See full changelog at https://github.com/libexpat/libexpat/blob/R_2_2_8/expat/Changes.

5 years agobpo-38234: Fix test_embed.test_init_setpath_config() on FreeBSD (GH-16406)
Victor Stinner [Thu, 26 Sep 2019 02:01:49 +0000 (04:01 +0200)]
bpo-38234: Fix test_embed.test_init_setpath_config() on FreeBSD (GH-16406)

Explicitly preinitializes with a Python preconfiguration to avoid
Py_SetPath() implicit preinitialization with a compat
preconfiguration.

Fix also test_init_setpath() and test_init_setpythonhome() on macOS:
use self.test_exe as the executable (and base_executable), rather
than shutil.which('python3').

5 years agobpo-38234: Complete init config documentation (GH-16404)
Victor Stinner [Thu, 26 Sep 2019 01:15:07 +0000 (03:15 +0200)]
bpo-38234: Complete init config documentation (GH-16404)

5 years agobpo-38234: Add test_init_setpath_config() to test_embed (GH-16402)
Victor Stinner [Thu, 26 Sep 2019 00:22:35 +0000 (02:22 +0200)]
bpo-38234: Add test_init_setpath_config() to test_embed (GH-16402)

* Add test_embed.test_init_setpath_config(): test Py_SetPath()
  with PyConfig.
* test_init_setpath() and test_init_setpythonhome() no longer call
  Py_SetProgramName(), but use the default program name.
* _PyPathConfig: isolated, site_import  and base_executable
  fields are now only available on Windows.
* If executable is set explicitly in the configuration, ignore
  calculated base_executable: _PyConfig_InitPathConfig() copies
  executable to base_executable.
* Complete path config documentation.

5 years agobpo-38142: Updated _hashopenssl.c to be PEP 384 compliant (#16071)
Christian Heimes [Wed, 25 Sep 2019 21:03:30 +0000 (23:03 +0200)]
bpo-38142: Updated _hashopenssl.c to be PEP 384 compliant (#16071)

* Updated _hashopenssl.c to be PEP 384 compliant
* Remove refleak test from test_hashlib. The updated type no longer accepts random arguments to __init__.

5 years agobpo-22273: Removed temporary test skipping on PPC platforms. (GH-16399)
Vinay Sajip [Wed, 25 Sep 2019 19:57:20 +0000 (20:57 +0100)]
bpo-22273: Removed temporary test skipping on PPC platforms. (GH-16399)

5 years agobpo-38271: encrypt private key test files with AES256 (GH-16385)
Christian Heimes [Wed, 25 Sep 2019 15:55:02 +0000 (17:55 +0200)]
bpo-38271: encrypt private key test files with AES256 (GH-16385)

The private keys for test_ssl were encrypted with 3DES in traditional
PKCS#5 format. 3DES and the digest algorithm of PKCS#5 are blocked by
some strict crypto policies. Use PKCS#8 format with AES256 encryption
instead.

Signed-off-by: Christian Heimes <christian@python.org>
https://bugs.python.org/issue38271

Automerge-Triggered-By: @tiran
5 years agobpo-38005: Remove support of string argument in InterpreterID(). (GH-16227)
Serhiy Storchaka [Wed, 25 Sep 2019 15:35:57 +0000 (18:35 +0300)]
bpo-38005: Remove support of string argument in InterpreterID(). (GH-16227)

Make negative interpreter id to raise ValueError instead of RuntimeError.

5 years agobpo-38255: super() can search attributes as well as methods (GH-16368)
Raymond Hettinger [Wed, 25 Sep 2019 15:13:19 +0000 (08:13 -0700)]
bpo-38255: super() can search attributes as well as methods (GH-16368)

Improvement suggested by Géry Ogam.

5 years agobpo-38234: Fix test_embed pathconfig tests (GH-16390)
Victor Stinner [Wed, 25 Sep 2019 14:30:36 +0000 (16:30 +0200)]
bpo-38234: Fix test_embed pathconfig tests (GH-16390)

bpo-38234: On macOS and FreeBSD, the temporary directory can be
symbolic link. For example, /tmp can be a symbolic link to /var/tmp.
Call realpath() to resolve all symbolic links.

5 years agobpo-38270: Check for hash digest algorithms and avoid MD5 (GH-16382)
Christian Heimes [Wed, 25 Sep 2019 14:30:20 +0000 (16:30 +0200)]
bpo-38270: Check for hash digest algorithms and avoid MD5 (GH-16382)

Make it easier to run and test Python on systems with restrict crypto policies:

* add requires_hashdigest to test.support to check if a hash digest algorithm is available and working
* avoid MD5 in test_hmac
* replace MD5 with SHA256 in test_tarfile
* mark network tests that require MD5 for MD5-based digest auth or CRAM-MD5

https://bugs.python.org/issue38270

5 years agobpo-22273: Re-enabled ctypes test on ARM machines. (GH-16388)
Vinay Sajip [Wed, 25 Sep 2019 14:05:55 +0000 (15:05 +0100)]
bpo-22273: Re-enabled ctypes test on ARM machines. (GH-16388)

5 years agobpo-36046: posix_spawn() doesn't support uid/gid (GH-16384)
Victor Stinner [Wed, 25 Sep 2019 13:52:49 +0000 (15:52 +0200)]
bpo-36046: posix_spawn() doesn't support uid/gid (GH-16384)

* subprocess.Popen now longer uses posix_spawn() if uid, gid or gids are set.
* test_subprocess: add "nobody" and "nfsnobody" group names for test_group().
* test_subprocess: test_user() and test_group() are now also tested with close_fds=False.

5 years agobpo-37064: Add option -a to pathfix.py tool (GH-15717)
PatrikKopkan [Wed, 25 Sep 2019 12:26:28 +0000 (14:26 +0200)]
bpo-37064: Add option -a to pathfix.py tool (GH-15717)

Add option -a to Tools/Scripts/pathfix.py script: add flags.

5 years agobpo-38140: Document offsets in PyMemberDef (GH-16354)
Petr Viktorin [Wed, 25 Sep 2019 11:06:16 +0000 (13:06 +0200)]
bpo-38140: Document offsets in PyMemberDef (GH-16354)

bpo-38140: Document offsets in PyMemberDef

Co-Authored-By: Ammar Askar <ammar_askar@hotmail.com>
5 years agobpo-38248: Fix inconsistent immediate asyncio.Task cancellation (GH-16330)
Yury Selivanov [Wed, 25 Sep 2019 10:32:08 +0000 (03:32 -0700)]
bpo-38248: Fix inconsistent immediate asyncio.Task cancellation (GH-16330)

5 years agoChanged conditions for ctypes array-in-struct handling. (GH-16381)
Vinay Sajip [Wed, 25 Sep 2019 10:11:57 +0000 (11:11 +0100)]
Changed conditions for ctypes array-in-struct handling. (GH-16381)

5 years agobpo-38260: Add Docs on asyncio.run (GH-16337)
Emmanuel Arias [Wed, 25 Sep 2019 08:53:49 +0000 (05:53 -0300)]
bpo-38260: Add Docs on asyncio.run (GH-16337)

Add docs about return and raise exception on asyncio.run

https://bugs.python.org/issue38260

Automerge-Triggered-By: @asvetlov
5 years agobpo-22273: Disabled tests while investigating buildbot failures on ARM7L/PPC64. ...
Vinay Sajip [Wed, 25 Sep 2019 06:58:32 +0000 (07:58 +0100)]
bpo-22273: Disabled tests while investigating buildbot failures on ARM7L/PPC64. (GH-16377)

5 years agobpo-38219: Optimize dict creating and updating by a dict. (GH-16268)
Serhiy Storchaka [Wed, 25 Sep 2019 06:47:00 +0000 (09:47 +0300)]
bpo-38219: Optimize dict creating and updating by a dict. (GH-16268)

5 years agobpo-38265: Update os.pread to accept the length type as Py_ssize_t. (GH-16359)
Dong-hee Na [Wed, 25 Sep 2019 05:47:04 +0000 (14:47 +0900)]
bpo-38265: Update os.pread to accept the length type as Py_ssize_t. (GH-16359)

5 years agobpo-22273: Update ctypes to correctly handle arrays in small structur… (GH-15839)
Vinay Sajip [Wed, 25 Sep 2019 03:38:44 +0000 (04:38 +0100)]
bpo-22273: Update ctypes to correctly handle arrays in small structur… (GH-15839)

5 years agobpo-38234: Cleanup getpath.c (GH-16367)
Victor Stinner [Wed, 25 Sep 2019 00:54:25 +0000 (02:54 +0200)]
bpo-38234: Cleanup getpath.c (GH-16367)

* search_for_prefix() directly calls reduce() if found is greater
  than 0.
* Add calculate_pybuilddir() subfunction.
* search_for_prefix(): add path string buffer for readability.
* Fix some error handling code paths: release resources on error.
* calculate_read_pyenv(): rename tmpbuffer to filename.
* test.pythoninfo now also logs windows.dll_path

5 years agobpo-38234: test_embed: test pyvenv.cfg and pybuilddir.txt (GH-16366)
Victor Stinner [Wed, 25 Sep 2019 00:10:35 +0000 (02:10 +0200)]
bpo-38234: test_embed: test pyvenv.cfg and pybuilddir.txt (GH-16366)

Add test_init_pybuilddir() and test_init_pyvenv_cfg() to test_embed
to test pyvenv.cfg and pybuilddir.txt configuration files.

Fix sysconfig._generate_posix_vars(): pybuilddir.txt uses UTF-8
encoding, not ASCII.

5 years agobpo-36871: Avoid duplicated 'Actual:' in assertion message (GH-16361)
Samuel Freilich [Tue, 24 Sep 2019 22:04:29 +0000 (18:04 -0400)]
bpo-36871: Avoid duplicated 'Actual:' in assertion message (GH-16361)

Fixes an issue caught after merge of PR 16005.

Tightened test assertions to check the entire assertion message.

5 years agobpo-36871: Handle spec errors in assert_has_calls (GH-16005)
Samuel Freilich [Tue, 24 Sep 2019 19:08:31 +0000 (15:08 -0400)]
bpo-36871: Handle spec errors in assert_has_calls (GH-16005)

The fix in PR 13261 handled the underlying issue about the spec for specific methods not being applied correctly, but it didn't fix the issue that was causing the misleading error message.

The code currently grabs a list of responses from _call_matcher (which may include exceptions). But it doesn't reach inside the list when checking if the result is an exception. This results in a misleading error message when one of the provided calls does not match the spec.

https://bugs.python.org/issue36871

Automerge-Triggered-By: @gpshead
5 years agobpo-38234: Add tests for Python init path config (GH-16358)
Victor Stinner [Tue, 24 Sep 2019 16:21:02 +0000 (18:21 +0200)]
bpo-38234: Add tests for Python init path config (GH-16358)

5 years agobpo-38234: Py_SetPath() uses the program full path (GH-16357)
Victor Stinner [Tue, 24 Sep 2019 15:44:15 +0000 (17:44 +0200)]
bpo-38234: Py_SetPath() uses the program full path (GH-16357)

Py_SetPath() now sets sys.executable to the program full path
(Py_GetProgramFullPath()), rather than to the program name
(Py_GetProgramName()).

Fix also memory leaks in pathconfig_set_from_config().