]> granicus.if.org Git - sudo/log
sudo
13 years agoUse SUDO_CONV_DEBUG_MSG in the plugin instead of writing
Todd C. Miller [Sun, 13 Nov 2011 18:55:19 +0000 (13:55 -0500)]
Use SUDO_CONV_DEBUG_MSG in the plugin instead of writing
directly to the debug file.

13 years agoMake sudo_goodpath() return value bolean
Todd C. Miller [Sun, 13 Nov 2011 17:11:00 +0000 (12:11 -0500)]
Make sudo_goodpath() return value bolean

13 years agoRemove obsolete securid auth method.
Todd C. Miller [Sun, 13 Nov 2011 16:54:06 +0000 (11:54 -0500)]
Remove obsolete securid auth method.

13 years agoPrefix authentication functions with a "sudo_" prefix to avoid
Todd C. Miller [Sun, 13 Nov 2011 16:46:39 +0000 (11:46 -0500)]
Prefix authentication functions with a "sudo_" prefix to avoid
namespace problems.

13 years agoRemove the old Kerberos IV support
Todd C. Miller [Sun, 13 Nov 2011 14:12:43 +0000 (09:12 -0500)]
Remove the old Kerberos IV support

13 years agoDon't print garbage at the end of the custom lecture.
Todd C. Miller [Sat, 12 Nov 2011 18:08:13 +0000 (13:08 -0500)]
Don't print garbage at the end of the custom lecture.

13 years agoAdd lexer tracing as debug@parser
Todd C. Miller [Sat, 12 Nov 2011 17:41:44 +0000 (12:41 -0500)]
Add lexer tracing as debug@parser

13 years agoRevert 003bdb078a15. We need to #include <gram.h> not "gram.h" and
Todd C. Miller [Sat, 12 Nov 2011 17:18:44 +0000 (12:18 -0500)]
Revert 003bdb078a15.  We need to #include <gram.h> not "gram.h" and
<def_data.h> and not "def_data.h" when generating the parser in a
build dir.

13 years agoBetter devdir support in mkdep.pl
Todd C. Miller [Tue, 8 Nov 2011 20:05:10 +0000 (15:05 -0500)]
Better devdir support in mkdep.pl

13 years agoAdd devdir before srcdir in include path and fix up dependecies
Todd C. Miller [Tue, 8 Nov 2011 19:10:34 +0000 (14:10 -0500)]
Add devdir before srcdir in include path and fix up dependecies
accordingly.

13 years ago#include "gram.h" not <gram.h> and "def_data.h" and not <def_data.h>.
Todd C. Miller [Tue, 8 Nov 2011 19:09:48 +0000 (14:09 -0500)]
#include "gram.h" not <gram.h> and "def_data.h" and not <def_data.h>.

13 years agoMark libexec files as optional. If we build without shared object
Todd C. Miller [Tue, 8 Nov 2011 13:38:21 +0000 (08:38 -0500)]
Mark libexec files as optional.  If we build without shared object
support, libexec is not used.

13 years agoChange Debug sudo.conf setting to take a program name as the first
Todd C. Miller [Tue, 8 Nov 2011 13:24:45 +0000 (08:24 -0500)]
Change Debug sudo.conf setting to take a program name as the first
argument.  In the future, this will allow visudo and sudoreplay to
use their own Debug entries.

13 years agofix sudo_debug_printf priority
Todd C. Miller [Tue, 8 Nov 2011 13:22:48 +0000 (08:22 -0500)]
fix sudo_debug_printf priority

13 years agoadd missing debug_return_int
Todd C. Miller [Tue, 8 Nov 2011 13:22:07 +0000 (08:22 -0500)]
add missing debug_return_int

13 years agoFold SUDO_DEBUG_PROGERR and SUDO_DEBUG_SYSERR into SUDO_DEBUG_ERROR
Todd C. Miller [Mon, 7 Nov 2011 21:33:49 +0000 (16:33 -0500)]
Fold SUDO_DEBUG_PROGERR and SUDO_DEBUG_SYSERR into SUDO_DEBUG_ERROR

13 years agoAdd missing word in HOME security note.
Todd C. Miller [Mon, 7 Nov 2011 20:52:29 +0000 (15:52 -0500)]
Add missing word in HOME security note.

13 years agoPrevent "testsudoers -d username" from trying to malloc(0).
Todd C. Miller [Mon, 7 Nov 2011 13:44:05 +0000 (08:44 -0500)]
Prevent "testsudoers -d username" from trying to malloc(0).

13 years agoTests for empty sudoers (should parse OK) and syntax errors within
Todd C. Miller [Sun, 6 Nov 2011 22:04:55 +0000 (17:04 -0500)]
Tests for empty sudoers (should parse OK) and syntax errors within
a line (should report correct line number) both with and without
the trailing newline.

13 years agoPrint line number when there is a parser error.
Todd C. Miller [Sun, 6 Nov 2011 22:00:40 +0000 (17:00 -0500)]
Print line number when there is a parser error.

13 years agoKeep track of the last token returned. On error, if the last token was
Todd C. Miller [Sat, 5 Nov 2011 11:37:14 +0000 (07:37 -0400)]
Keep track of the last token returned.  On error, if the last token was
COMMENT, decrement sudolineno since the error most likely occurred on
the preceding line.  Previously we always uses sudolineno-1 which will
give the wrong line number for errors within a line.

13 years agoupdate with sudo 1.8.3p1 info
Todd C. Miller [Thu, 3 Nov 2011 13:31:44 +0000 (09:31 -0400)]
update with sudo 1.8.3p1 info

13 years agoFix crash when "sudo -g group -i" is run. Fixes bug 521
Todd C. Miller [Thu, 3 Nov 2011 13:31:20 +0000 (09:31 -0400)]
Fix crash when "sudo -g group -i" is run.  Fixes bug 521

13 years agoMake alias_remove_recursive() return TRUE/FALSE as its callers
Todd C. Miller [Wed, 26 Oct 2011 14:42:30 +0000 (10:42 -0400)]
Make alias_remove_recursive() return TRUE/FALSE as its callers
expect and remove two unused arguments.  Fixes bug 519.

13 years agoAdd regress test for bugzilla 519
Todd C. Miller [Wed, 26 Oct 2011 14:20:32 +0000 (10:20 -0400)]
Add regress test for bugzilla 519

13 years agoDisable warning/error wrapping in regress tests.
Todd C. Miller [Wed, 26 Oct 2011 14:19:48 +0000 (10:19 -0400)]
Disable warning/error wrapping in regress tests.

13 years agoDo compile-po as part of sync-po so that the .mo files get rebuild
Todd C. Miller [Tue, 25 Oct 2011 18:54:38 +0000 (14:54 -0400)]
Do compile-po as part of sync-po so that the .mo files get rebuild
automatically when we sync with translationproject.org

13 years agocheck_addr needs to link with the network libraries on Solaris
Todd C. Miller [Tue, 25 Oct 2011 18:50:54 +0000 (14:50 -0400)]
check_addr needs to link with the network libraries on Solaris

13 years agoWhen matching a RunasAlias for a runas group, pass the alias in as
Todd C. Miller [Tue, 25 Oct 2011 14:34:31 +0000 (10:34 -0400)]
When matching a RunasAlias for a runas group, pass the alias in as
the group_list, not the user_list.  From Daniel Kopecek.

13 years agoWe need to init the auth system regardless of whether we need a
Todd C. Miller [Tue, 25 Oct 2011 14:08:26 +0000 (10:08 -0400)]
We need to init the auth system regardless of whether we need a
password since we will be closing the PAM session in the monitor
process.  Fixes a crash in the monitor on Solaris; bugzilla #518

13 years agoGet rid of done: label. If the child exits we still need to close
Todd C. Miller [Mon, 24 Oct 2011 15:14:20 +0000 (11:14 -0400)]
Get rid of done: label.  If the child exits we still need to close
the pty, update utmp and restore the SELinux tty context.

13 years agoAdd debug_decl/debug_return (almost) everywhere.
Todd C. Miller [Sat, 22 Oct 2011 18:40:21 +0000 (14:40 -0400)]
Add debug_decl/debug_return (almost) everywhere.
Remove old sudo_debug() and convert users to sudo_debug_printf().

13 years agoWrap error/errorx and warning/warningx functions with debug statements.
Todd C. Miller [Sat, 22 Oct 2011 18:28:33 +0000 (14:28 -0400)]
Wrap error/errorx and warning/warningx functions with debug statements.
Disable wrapping for standalone sudoers programs as well as memory
allocation functions (to avoid infinite recursion).

13 years agoAdd checks for __func__ and __FUNCTION__ and mention that we now
Todd C. Miller [Sat, 22 Oct 2011 18:20:52 +0000 (14:20 -0400)]
Add checks for __func__ and __FUNCTION__ and mention that we now
require a cpp that supports variadic macros.

13 years agoNew debug framework for sudo and plugins using /etc/sudo.conf that
Todd C. Miller [Sat, 22 Oct 2011 18:00:52 +0000 (14:00 -0400)]
New debug framework for sudo and plugins using /etc/sudo.conf that
also supports function call tracing.

13 years agoUpdate Japanese sudoers translation from translationproject.org
Todd C. Miller [Fri, 21 Oct 2011 13:00:42 +0000 (09:00 -0400)]
Update Japanese sudoers translation from translationproject.org

13 years agoOverride and ignore the --disable-static option. Sudo already runs
Todd C. Miller [Wed, 12 Oct 2011 12:24:13 +0000 (08:24 -0400)]
Override and ignore the --disable-static option.  Sudo already runs
libtool with -tag=disable-static where applicable and we need non-PIC
objects to build the executables.

13 years agoAdd sudoedit fix
Todd C. Miller [Mon, 10 Oct 2011 19:52:47 +0000 (15:52 -0400)]
Add sudoedit fix

13 years agoregen pot files
Todd C. Miller [Mon, 10 Oct 2011 19:50:41 +0000 (15:50 -0400)]
regen pot files

13 years agoIgnore set_logname (which is now the default) for sudoedit since
Todd C. Miller [Mon, 10 Oct 2011 17:10:24 +0000 (13:10 -0400)]
Ignore set_logname (which is now the default) for sudoedit since
we want the LOGNAME, USER and USERNAME environment variables to
refer to the calling user since that is who the editor runs as.
This allows the editor to find the user's startup files.
Fixes bugzilla #515

13 years agoInstead of trying to grow the buffer in make_grlist_item(), simply
Todd C. Miller [Mon, 10 Oct 2011 15:10:59 +0000 (11:10 -0400)]
Instead of trying to grow the buffer in make_grlist_item(), simply
increase the total length, free the old buffer and allocate a new
one.  This is less error prone and saves us from having to adjust
all the pointers in the buffer.  This code path is only taken when
there are groups longer than the length of the user field in struct
utmp or utmpx, which should be quite rare.

13 years agoAdd Italian translation for sudo from translationproject.org
Todd C. Miller [Mon, 10 Oct 2011 15:00:09 +0000 (11:00 -0400)]
Add Italian translation for sudo from translationproject.org

13 years agoJapanese translation for sudo and sudoers from translationproject.org
Todd C. Miller [Mon, 10 Oct 2011 10:45:28 +0000 (06:45 -0400)]
Japanese translation for sudo and sudoers from translationproject.org

13 years agosudoreplay depends on timestr.lo too; from Mike Frysinger
Todd C. Miller [Fri, 7 Oct 2011 20:09:48 +0000 (16:09 -0400)]
sudoreplay depends on timestr.lo too; from Mike Frysinger

13 years agoRegen sudoers pot file.
Todd C. Miller [Tue, 4 Oct 2011 16:32:05 +0000 (12:32 -0400)]
Regen sudoers pot file.

13 years agoUpdate with latest sudo 1.8.3 news
Todd C. Miller [Tue, 4 Oct 2011 16:22:08 +0000 (12:22 -0400)]
Update with latest sudo 1.8.3 news

13 years agoIt appears that LDAP or NSS may modify the euid so we need to be
Todd C. Miller [Tue, 4 Oct 2011 15:15:06 +0000 (11:15 -0400)]
It appears that LDAP or NSS may modify the euid so we need to be
root for the open().  We restore the old perms at the end of
sudoers_policy_open().

13 years agoBetter warning message on setuid() failure for the setreuid()
Todd C. Miller [Tue, 4 Oct 2011 15:13:28 +0000 (11:13 -0400)]
Better warning message on setuid() failure for the setreuid()
version of set_perms().

13 years agoDelref auth_pw at the end of check_user() instead of getting a ref
Todd C. Miller [Tue, 27 Sep 2011 20:21:21 +0000 (16:21 -0400)]
Delref auth_pw at the end of check_user() instead of getting a ref
twice.

13 years agoMake sudo_auth_{init,cleanup} return TRUE on success and check for
Todd C. Miller [Tue, 27 Sep 2011 19:41:22 +0000 (15:41 -0400)]
Make sudo_auth_{init,cleanup} return TRUE on success and check for
sudo_auth_init() return value in check_user().

13 years agoDo not return without restoring permissions.
Todd C. Miller [Tue, 27 Sep 2011 19:22:08 +0000 (15:22 -0400)]
Do not return without restoring permissions.

13 years agoregen pot files
Todd C. Miller [Tue, 27 Sep 2011 18:07:18 +0000 (14:07 -0400)]
regen pot files

13 years agoModify the authentication API such that the init and cleanup functions
Todd C. Miller [Tue, 27 Sep 2011 17:18:46 +0000 (13:18 -0400)]
Modify the authentication API such that the init and cleanup functions
are always called, regardless of whether or not we are going to
verify a password.  This is needed for proper PAM session support.

13 years agoAdd missing dependency for getspwuid.lo and regen other depends.
Todd C. Miller [Tue, 27 Sep 2011 17:15:48 +0000 (13:15 -0400)]
Add missing dependency for getspwuid.lo and regen other depends.

13 years agoFix a PAM_USER mismatch in session open/close. We update PAM_USER
Todd C. Miller [Tue, 27 Sep 2011 15:13:44 +0000 (11:13 -0400)]
Fix a PAM_USER mismatch in session open/close.  We update PAM_USER
to the target user immediately before setting resource limits, which
is after the monitor process has forked (so it has the old value).
Also, if the user did not authenticate, there is no pamh in the
monitor so we need to init pam here too.  This means we end up
calling pam_start() twice, which should be fixed, but at least the
session is always properly closed now.

13 years agoAdd check for old being NULL in utmp_setid(); from Steven McDonald
Todd C. Miller [Tue, 27 Sep 2011 13:30:59 +0000 (09:30 -0400)]
Add check for old being NULL in utmp_setid(); from Steven McDonald

13 years agoIf the invoking user cannot be resolved by uid fake the struct
Todd C. Miller [Sun, 25 Sep 2011 10:35:40 +0000 (06:35 -0400)]
If the invoking user cannot be resolved by uid fake the struct
passwd and store it in the cache so we can delref it on exit.

13 years agoDon't error out if the group plugin cannot be loaded, just warn.
Todd C. Miller [Sat, 24 Sep 2011 14:24:40 +0000 (10:24 -0400)]
Don't error out if the group plugin cannot be loaded, just warn.

13 years agoQuiet a false positive found by several static analysis tools.
Todd C. Miller [Fri, 23 Sep 2011 23:37:21 +0000 (19:37 -0400)]
Quiet a false positive found by several static analysis tools.
These tools don't know that log_error() does not return (it longjmps
to error_jmp which returns to the sudo front-end).

13 years agoAdd Italian translation for sudo from translationproject.org
Todd C. Miller [Thu, 22 Sep 2011 18:56:43 +0000 (14:56 -0400)]
Add Italian translation for sudo from translationproject.org
Regen .mo files

13 years agoUpdate to current reality and add bit about ssh auth
Todd C. Miller [Wed, 21 Sep 2011 16:30:09 +0000 (12:30 -0400)]
Update to current reality and add bit about ssh auth

13 years agoMake "verbose" static; fixes a namespace clash with pam_ssh_agent_auth
Todd C. Miller [Wed, 21 Sep 2011 14:15:13 +0000 (10:15 -0400)]
Make "verbose" static; fixes a namespace clash with pam_ssh_agent_auth
(and it doesn't need to be extern these days).

13 years agoFreeBSD has libutil.h not util.h
Todd C. Miller [Wed, 21 Sep 2011 13:52:33 +0000 (09:52 -0400)]
FreeBSD has libutil.h not util.h

13 years agoDefine _BSD_SOURCE on FreeBSD, OpenBSD and DragonflyBSD
Todd C. Miller [Wed, 21 Sep 2011 13:46:52 +0000 (09:46 -0400)]
Define _BSD_SOURCE on FreeBSD, OpenBSD and DragonflyBSD

13 years agoUpdate po files from translationproject.org
Todd C. Miller [Tue, 20 Sep 2011 18:57:43 +0000 (14:57 -0400)]
Update po files from translationproject.org

13 years agoAdd support for DEREF in ldap.conf.
Todd C. Miller [Fri, 16 Sep 2011 20:50:04 +0000 (16:50 -0400)]
Add support for DEREF in ldap.conf.

13 years agoinstall target should depend on ChangeLog too, not just install-doc
Todd C. Miller [Fri, 16 Sep 2011 18:20:15 +0000 (14:20 -0400)]
install target should depend on ChangeLog too, not just install-doc

13 years agoOnly iolog_file (not iolog_dir) supports mktemp-style suffixes.
Todd C. Miller [Fri, 16 Sep 2011 18:05:44 +0000 (14:05 -0400)]
Only iolog_file (not iolog_dir) supports mktemp-style suffixes.

13 years agoSync with 1.8 branch for sudo 1.8.2 and 1.8.3 changes.
Todd C. Miller [Fri, 16 Sep 2011 17:30:16 +0000 (13:30 -0400)]
Sync with 1.8 branch for sudo 1.8.2 and 1.8.3 changes.

13 years agoDocument group lookup change and possible side effects.
Todd C. Miller [Fri, 16 Sep 2011 17:29:50 +0000 (13:29 -0400)]
Document group lookup change and possible side effects.

13 years agoFix some square brackets in case statements that needed to be doubled
Todd C. Miller [Fri, 16 Sep 2011 17:05:21 +0000 (13:05 -0400)]
Fix some square brackets in case statements that needed to be doubled
up.  While here, use $OSMAJOR when it makes sense.

13 years agoFix a crash in make_grlist_item() on 64-bit machines with strict
Todd C. Miller [Fri, 16 Sep 2011 13:05:37 +0000 (09:05 -0400)]
Fix a crash in make_grlist_item() on 64-bit machines with strict
alignment.

13 years agoRemove list_options() function that is no longer used now that "sudo
Todd C. Miller [Fri, 16 Sep 2011 13:05:17 +0000 (09:05 -0400)]
Remove list_options() function that is no longer used now that "sudo
-L" is gone.

13 years agoError message if user tries --with-CC
Todd C. Miller [Fri, 16 Sep 2011 13:04:58 +0000 (09:04 -0400)]
Error message if user tries --with-CC

13 years agoCheck for -libmldap too when looking for ldap libs, which is the
Todd C. Miller [Fri, 16 Sep 2011 13:04:27 +0000 (09:04 -0400)]
Check for -libmldap too when looking for ldap libs, which is the
Tivoli Directory Server client library.

13 years agoHonor NOPASSWD tag for denied commands too.
Todd C. Miller [Fri, 9 Sep 2011 13:57:39 +0000 (09:57 -0400)]
Honor NOPASSWD tag for denied commands too.

13 years agoRemove --with-CC option; it doesn't work correctly now that we use
Todd C. Miller [Thu, 8 Sep 2011 13:36:24 +0000 (09:36 -0400)]
Remove --with-CC option; it doesn't work correctly now that we use
libtool.  Users can get the same effect by setting the CC environment
variable when running configure.

13 years agoAssume all modern systems support fstat(2).
Todd C. Miller [Wed, 31 Aug 2011 15:19:10 +0000 (11:19 -0400)]
Assume all modern systems support fstat(2).

13 years agoAdd configure test for missing errno declaration and only
Todd C. Miller [Tue, 30 Aug 2011 14:05:30 +0000 (10:05 -0400)]
Add configure test for missing errno declaration and only
declare it ourselves if it is missing.

13 years agoInclude errno.h before sudo.h to avoid conflicting with the system
Todd C. Miller [Tue, 30 Aug 2011 13:46:12 +0000 (09:46 -0400)]
Include errno.h before sudo.h to avoid conflicting with the system
definition of errno.

13 years agoOnly print individual check status when there is a failure.
Todd C. Miller [Mon, 29 Aug 2011 18:53:47 +0000 (14:53 -0400)]
Only print individual check status when there is a failure.

13 years agoAdd calls to setprogname() for test programs.
Todd C. Miller [Mon, 29 Aug 2011 18:51:12 +0000 (14:51 -0400)]
Add calls to setprogname() for test programs.

13 years agoAdd -Wall and -Werror after all tests so they don't cause failures.
Todd C. Miller [Mon, 29 Aug 2011 18:49:10 +0000 (14:49 -0400)]
Add -Wall and -Werror after all tests so they don't cause failures.

13 years agoActually run check_addr in the check target
Todd C. Miller [Mon, 29 Aug 2011 18:48:09 +0000 (14:48 -0400)]
Actually run check_addr in the check target

13 years agoSplit out address matching into its own file and add regression
Todd C. Miller [Mon, 29 Aug 2011 18:10:18 +0000 (14:10 -0400)]
Split out address matching into its own file and add regression
tests for it.

13 years agoWhen matching an address with a netmask in sudoers, AND the mask
Todd C. Miller [Sat, 27 Aug 2011 16:09:30 +0000 (12:09 -0400)]
When matching an address with a netmask in sudoers, AND the mask
and addr before checking against the local addresses.

13 years agoFix netmask matching.
Todd C. Miller [Fri, 26 Aug 2011 20:01:39 +0000 (16:01 -0400)]
Fix netmask matching.

13 years agoDon't assume all editors support the +linenumber command line argument,
Todd C. Miller [Fri, 26 Aug 2011 18:03:49 +0000 (14:03 -0400)]
Don't assume all editors support the +linenumber command line argument,
use a whitelist of known good editors.

13 years agoSilence compiler warnings on Solaris with gcc 3.4.3
Todd C. Miller [Tue, 23 Aug 2011 20:42:18 +0000 (16:42 -0400)]
Silence compiler warnings on Solaris with gcc 3.4.3

13 years agoFix building on RHEL 3
Todd C. Miller [Tue, 23 Aug 2011 19:24:55 +0000 (15:24 -0400)]
Fix building on RHEL 3

13 years agoAdd --enable-werror configure option.
Todd C. Miller [Tue, 23 Aug 2011 14:15:28 +0000 (10:15 -0400)]
Add --enable-werror configure option.

13 years agosetgroups() proto lives in grp.h on RHEL4, perhaps others.
Todd C. Miller [Tue, 23 Aug 2011 14:14:52 +0000 (10:14 -0400)]
setgroups() proto lives in grp.h on RHEL4, perhaps others.

13 years agoUse PAM by default on AIX 6 and higher.
Todd C. Miller [Tue, 23 Aug 2011 13:50:40 +0000 (09:50 -0400)]
Use PAM by default on AIX 6 and higher.

13 years agoAdd new Esperanto translation from translationproject.org
Todd C. Miller [Mon, 22 Aug 2011 12:26:50 +0000 (08:26 -0400)]
Add new Esperanto translation from translationproject.org

13 years agoQuiet an innocuous valgrind warning.
Todd C. Miller [Fri, 19 Aug 2011 13:32:25 +0000 (09:32 -0400)]
Quiet an innocuous valgrind warning.

13 years agoFix expansion of strftime() escapes in log_dir and add a regress test
Todd C. Miller [Thu, 18 Aug 2011 17:41:40 +0000 (13:41 -0400)]
Fix expansion of strftime() escapes in log_dir and add a regress test
that exhibited the problem.

13 years agoFix "make check" return value.
Todd C. Miller [Thu, 18 Aug 2011 16:09:34 +0000 (12:09 -0400)]
Fix "make check" return value.

13 years agoRegen pot files
Todd C. Miller [Wed, 17 Aug 2011 15:40:14 +0000 (11:40 -0400)]
Regen pot files

13 years agoFix logic inversion in pot file up to date check.
Todd C. Miller [Wed, 17 Aug 2011 15:38:53 +0000 (11:38 -0400)]
Fix logic inversion in pot file up to date check.

13 years agoAdd caching for gettext() checks.
Todd C. Miller [Mon, 15 Aug 2011 17:41:58 +0000 (13:41 -0400)]
Add caching for gettext() checks.