]> granicus.if.org Git - transmission/log
transmission
14 years ago(trunk libT) #3571 "Torrent done script clears important env vars" -- fixed.
Charles Kerr [Tue, 21 Sep 2010 16:26:48 +0000 (16:26 +0000)]
(trunk libT) #3571 "Torrent done script clears important env vars" -- fixed.

14 years ago(trunk Qt) update Russian i18n
Charles Kerr [Mon, 20 Sep 2010 20:40:40 +0000 (20:40 +0000)]
(trunk Qt) update Russian i18n

14 years ago(trunk libT) fix unchoke regression
Charles Kerr [Mon, 20 Sep 2010 20:32:40 +0000 (20:32 +0000)]
(trunk libT) fix unchoke regression

14 years ago(trunk qt) silence a couple of gcc warnings by adding reasonable defaults at the...
Charles Kerr [Mon, 20 Sep 2010 13:46:08 +0000 (13:46 +0000)]
(trunk qt) silence a couple of gcc warnings by adding reasonable defaults at the bottom of a switch statement in case bad tr_ratiolimits or FilterModes get used in the switch

14 years agotweak the valgrind script
Charles Kerr [Sun, 19 Sep 2010 22:21:36 +0000 (22:21 +0000)]
tweak the valgrind script

14 years agoupdate Brazilian Portuguese localization
Mitchell Livingston [Sun, 19 Sep 2010 21:33:28 +0000 (21:33 +0000)]
update Brazilian Portuguese localization

14 years ago(trunk libT) #3539 "Transmission sending corrupt data in metadata exchange" -- fixed...
Charles Kerr [Sun, 19 Sep 2010 21:07:57 +0000 (21:07 +0000)]
(trunk libT) #3539 "Transmission sending corrupt data in metadata exchange" -- fixed.  Thanks to The_8472 of Vuze fame for reporting this. :)

14 years ago(trunk) bounds check trackerIds passed over rpc
Daniel Lee [Sun, 19 Sep 2010 20:36:31 +0000 (20:36 +0000)]
(trunk) bounds check trackerIds passed over rpc

14 years agoupdate Russian localization
Mitchell Livingston [Sun, 19 Sep 2010 19:50:03 +0000 (19:50 +0000)]
update Russian localization

14 years ago(trunk qt,gtk) #3549 "torrent properties window doesn't fix netbook screen" -- merge...
Charles Kerr [Sun, 19 Sep 2010 17:33:25 +0000 (17:33 +0000)]
(trunk qt,gtk) #3549 "torrent properties window doesn't fix netbook screen" -- merge the "Uploaded" and "Ratio" rows to save a little vertical space

14 years agotweak German inspector views for spacing fixes
Mitchell Livingston [Sun, 19 Sep 2010 16:44:07 +0000 (16:44 +0000)]
tweak German inspector views for spacing fixes

14 years agosmall alignment fix in the inspector's options view
Mitchell Livingston [Sun, 19 Sep 2010 14:11:30 +0000 (14:11 +0000)]
small alignment fix in the inspector's options view

14 years agoupdate German localization
Mitchell Livingston [Sun, 19 Sep 2010 13:18:51 +0000 (13:18 +0000)]
update German localization

14 years agoupdate Italian localization
Mitchell Livingston [Sun, 19 Sep 2010 13:17:28 +0000 (13:17 +0000)]
update Italian localization

14 years ago(trunk libT) #3568 "don't optimistically unchoke torrents when our bandwidth is maxed...
Charles Kerr [Sun, 19 Sep 2010 01:04:49 +0000 (01:04 +0000)]
(trunk libT) #3568 "don't optimistically unchoke torrents when our bandwidth is maxed out" -- fixed.

14 years ago(trunk) #3547 "Wrong speed display in web UI" -- fixed
Charles Kerr [Sat, 18 Sep 2010 23:06:03 +0000 (23:06 +0000)]
(trunk) #3547 "Wrong speed display in web UI" -- fixed

14 years ago(trunk libT) #3567 "Minor memory leak in pthread_create()" -- fixed
Charles Kerr [Sat, 18 Sep 2010 22:13:46 +0000 (22:13 +0000)]
(trunk libT) #3567 "Minor memory leak in pthread_create()" -- fixed

14 years ago(trunk libT) #3566 "Memory leak in libtransmission/torrent.c: refreshCurrentDir(...
Charles Kerr [Sat, 18 Sep 2010 21:57:22 +0000 (21:57 +0000)]
(trunk libT) #3566 "Memory leak in libtransmission/torrent.c: refreshCurrentDir()" -- fixed.

14 years agoone less localizable string
Mitchell Livingston [Sat, 18 Sep 2010 19:49:34 +0000 (19:49 +0000)]
one less localizable string

14 years agoupdate strings file
Mitchell Livingston [Sat, 18 Sep 2010 19:40:12 +0000 (19:40 +0000)]
update strings file

14 years agoanother NEWS tweak
Mitchell Livingston [Sat, 18 Sep 2010 16:00:00 +0000 (16:00 +0000)]
another NEWS tweak

14 years ago(qt) Don't lose selection when changing to and from compact mode.
Daniel Lee [Sat, 18 Sep 2010 15:51:38 +0000 (15:51 +0000)]
(qt) Don't lose selection when changing to and from compact mode.

14 years agoweb changes in NEWS were a bit overzealous
Daniel Lee [Sat, 18 Sep 2010 15:45:04 +0000 (15:45 +0000)]
web changes in NEWS were a bit overzealous

14 years agoremove "Seed ratio support" from NEWS
Mitchell Livingston [Sat, 18 Sep 2010 15:08:25 +0000 (15:08 +0000)]
remove "Seed ratio support" from NEWS

14 years agotweak NEWS
Mitchell Livingston [Fri, 17 Sep 2010 21:53:32 +0000 (21:53 +0000)]
tweak NEWS

14 years agoadd first draft of 2.10 NEWS
Charles Kerr [Fri, 17 Sep 2010 18:50:57 +0000 (18:50 +0000)]
add first draft of 2.10 NEWS

14 years ago(trunk gtk) #3529 "slow priority-sorting in file list" -- fixed
Charles Kerr [Fri, 17 Sep 2010 13:23:20 +0000 (13:23 +0000)]
(trunk gtk) #3529 "slow priority-sorting in file list" -- fixed

14 years ago(trunk) #3549 "torrent properties window does not fit netbook screen" -- fixed
Charles Kerr [Fri, 17 Sep 2010 05:43:06 +0000 (05:43 +0000)]
(trunk) #3549 "torrent properties window does not fit netbook screen" -- fixed

14 years ago(trunk gtk) #3554 "alternate speed (turtle) button does not update when toggled via...
Charles Kerr [Fri, 17 Sep 2010 02:27:03 +0000 (02:27 +0000)]
(trunk gtk) #3554 "alternate speed (turtle) button does not update when toggled via RPC" -- fixed.

14 years ago(trunk gtk) #3555 "disambiguate the string 'None' for better i18n" -- fixed
Charles Kerr [Thu, 16 Sep 2010 17:45:24 +0000 (17:45 +0000)]
(trunk gtk) #3555 "disambiguate the string 'None' for better i18n" -- fixed

14 years ago(trunk daemon) #3547 "Regression: wrong speed display in transmission-remote and...
Charles Kerr [Thu, 16 Sep 2010 02:13:14 +0000 (02:13 +0000)]
(trunk daemon) #3547 "Regression: wrong speed display in transmission-remote and web ui" -- fix peer-info regression reported by gunzip

14 years ago(trunk) revert downloadSpeed and uploadSpeed in session stats to Bps
Daniel Lee [Thu, 16 Sep 2010 02:01:49 +0000 (02:01 +0000)]
(trunk) revert downloadSpeed and uploadSpeed in session stats to Bps

14 years ago(trunk) don't display "Got a list of 0 peers" for currently paused torrents
Daniel Lee [Thu, 16 Sep 2010 02:00:54 +0000 (02:00 +0000)]
(trunk) don't display "Got a list of 0 peers" for currently paused torrents

14 years ago(trunk) check for duplicate ids when removing trackers
Daniel Lee [Tue, 14 Sep 2010 18:07:42 +0000 (18:07 +0000)]
(trunk) check for duplicate ids when removing trackers

14 years agoswitch trackerRemove and trackerReplace rpc calls to use tracker id instead of announ...
Daniel Lee [Tue, 14 Sep 2010 06:23:48 +0000 (06:23 +0000)]
switch trackerRemove and trackerReplace rpc calls to use tracker id instead of announce urls as identifiers

14 years agofix last activity display in qt client
Daniel Lee [Tue, 14 Sep 2010 04:08:24 +0000 (04:08 +0000)]
fix last activity display in qt client

14 years ago#3518 Snow Leopard systems should show file sizes and speeds in base 10
Mitchell Livingston [Sun, 12 Sep 2010 22:20:19 +0000 (22:20 +0000)]
#3518 Snow Leopard systems should show file sizes and speeds in base 10

14 years agofix a display issue with the idle time for a split second after the transfer starts...
Mitchell Livingston [Sun, 12 Sep 2010 19:49:06 +0000 (19:49 +0000)]
fix a display issue with the idle time for a split second after the transfer starts, since the transfer would be marked as downloading but would not yet have a start time

14 years ago(trunk daemon) #3547: "regression: wrong speed display in transission-remote and...
Charles Kerr [Sun, 12 Sep 2010 19:35:53 +0000 (19:35 +0000)]
(trunk daemon) #3547: "regression: wrong speed display in transission-remote and web ui" -- apply KyleK's patch for transmission-remote

14 years ago#3513 inactive limit should set torrent state as finished, not stopped
Mitchell Livingston [Sun, 12 Sep 2010 18:58:49 +0000 (18:58 +0000)]
#3513 inactive limit should set torrent state as finished, not stopped

14 years ago(trunk daemon) sync transmission-remote with r11194: fix speed up/down speed units
Charles Kerr [Sun, 12 Sep 2010 02:18:37 +0000 (02:18 +0000)]
(trunk daemon) sync transmission-remote with r11194: fix speed up/down speed units

14 years ago(trunk, web) we were appending lots and lots of strings. instead, use array.join()
Charles Kerr [Sun, 12 Sep 2010 02:07:43 +0000 (02:07 +0000)]
(trunk, web) we were appending lots and lots of strings.  instead, use array.join()

14 years ago(trunk, web client) fix speed display
Charles Kerr [Sun, 12 Sep 2010 01:13:38 +0000 (01:13 +0000)]
(trunk, web client) fix speed display

14 years ago(trunk libT) #3077 "add support for cookies files"
Charles Kerr [Thu, 9 Sep 2010 18:28:20 +0000 (18:28 +0000)]
(trunk libT) #3077 "add support for cookies files"

14 years ago(trunk) fix clutch Makefiles
Charles Kerr [Thu, 9 Sep 2010 18:23:06 +0000 (18:23 +0000)]
(trunk) fix clutch Makefiles

14 years ago(qt) missing colon in progresString
Daniel Lee [Wed, 8 Sep 2010 01:09:52 +0000 (01:09 +0000)]
(qt) missing colon in progresString

14 years agoremove sort-by-tracker from the GTK+ client
Charles Kerr [Mon, 6 Sep 2010 00:23:44 +0000 (00:23 +0000)]
remove sort-by-tracker from the GTK+ client

14 years agoremove sort-by-tracker from the Qt client
Charles Kerr [Mon, 6 Sep 2010 00:19:37 +0000 (00:19 +0000)]
remove sort-by-tracker from the Qt client

14 years agoreadd dialog.js. :/
Charles Kerr [Sun, 5 Sep 2010 03:02:02 +0000 (03:02 +0000)]
readd dialog.js. :/

14 years ago(trunk) revert the RPC behavior of rateUpload, rateDownload, rateToClient, and rateTo...
Charles Kerr [Fri, 3 Sep 2010 04:30:43 +0000 (04:30 +0000)]
(trunk) revert the RPC behavior of rateUpload, rateDownload, rateToClient, and rateToPeer as discussed with Longinus00

14 years agoand the css and index.html change
Charles Kerr [Fri, 3 Sep 2010 00:41:17 +0000 (00:41 +0000)]
and the css and index.html change

14 years ago(trunk web) part 2 of reverting the web client changes: adding Longinus00's filter...
Charles Kerr [Fri, 3 Sep 2010 00:20:40 +0000 (00:20 +0000)]
(trunk web) part 2 of reverting the web client changes: adding Longinus00's filter-by-finished patch back in.  I've learned my lesson -- no more hacking in clutch.  http://github.com/charlesk/gearbox

14 years ago(trunk web) revert the web client back to r11156 to erase the traces of the attempt...
Charles Kerr [Fri, 3 Sep 2010 00:03:21 +0000 (00:03 +0000)]
(trunk web) revert the web client back to r11156 to erase the traces of the attempt to get clutch working with jQuery's GUI widgets.

14 years ago(trunk) RPC: add "scrape" to the trackerStats array, making it a proper superset...
Charles Kerr [Wed, 1 Sep 2010 20:54:04 +0000 (20:54 +0000)]
(trunk) RPC: add "scrape" to the trackerStats array, making it a proper superset of the "trackers" array.  Also, very minor tweaks to the RPC spec

14 years ago#3535 remove unnecessary escape characters and use lowercase in escaped letters in...
Mitchell Livingston [Tue, 31 Aug 2010 11:49:09 +0000 (11:49 +0000)]
#3535 remove unnecessary escape characters and use lowercase in escaped letters in info_hash

14 years agoChange "Transfer is stalled when no activity for:" to "Transfer is stalled when inact...
Mitchell Livingston [Mon, 30 Aug 2010 01:05:47 +0000 (01:05 +0000)]
Change "Transfer is stalled when no activity for:" to "Transfer is stalled when inactive for:"

14 years ago(trunk) sync to libT changes: rename the 'inactive-seeding-limit' keys as 'idle-seedi...
Charles Kerr [Sun, 22 Aug 2010 18:43:19 +0000 (18:43 +0000)]
(trunk) sync to libT changes: rename the 'inactive-seeding-limit' keys as 'idle-seeding-limit'

14 years ago(trunk libT) #3519 "webseeds don't work" -- patch from gostrc to add support for...
Charles Kerr [Sun, 22 Aug 2010 18:40:18 +0000 (18:40 +0000)]
(trunk libT) #3519 "webseeds don't work" -- patch from gostrc to add support for a single string in the url-list

14 years ago(qt) set an initial value for QDoubleSpinBox in the prefs dialog
Daniel Lee [Sun, 22 Aug 2010 16:45:29 +0000 (16:45 +0000)]
(qt) set an initial value for QDoubleSpinBox in the prefs dialog

14 years ago(libt) Fix tr_cacheFlushDone overrunning run_info
Daniel Lee [Sun, 22 Aug 2010 09:49:10 +0000 (09:49 +0000)]
(libt) Fix tr_cacheFlushDone overrunning run_info

14 years ago(trunk libT) handle URLs, as well as filenames, via the rpc server's /transmission...
Charles Kerr [Sat, 21 Aug 2010 12:50:13 +0000 (12:50 +0000)]
(trunk libT) handle URLs, as well as filenames, via the rpc server's /transmission/upload mechanism

14 years ago(trunk libT) add a string length argument to tr_urlIsValid()
Charles Kerr [Sat, 21 Aug 2010 12:47:28 +0000 (12:47 +0000)]
(trunk libT) add a string length argument to tr_urlIsValid()

14 years ago#3517 Only apply the idle seed limit when the transfer is comple
Mitchell Livingston [Thu, 19 Aug 2010 22:14:59 +0000 (22:14 +0000)]
#3517 Only apply the idle seed limit when the transfer is comple

14 years ago(trunk libT) peer-port-random-on-start was being returned as an int(0,1) instead...
Charles Kerr [Mon, 16 Aug 2010 02:11:10 +0000 (02:11 +0000)]
(trunk libT) peer-port-random-on-start was being returned as an int(0,1) instead of a bool(true,false)

14 years ago(trunk libT) if we compile with TR_EMBEDDED, use Z_DEFAULT_COMPRESSION. otherwise...
Charles Kerr [Sun, 15 Aug 2010 23:45:58 +0000 (23:45 +0000)]
(trunk libT) if we compile with TR_EMBEDDED, use Z_DEFAULT_COMPRESSION.  otherwise, use Z_BEST_COMPRESSION

14 years agodon't set an idle eta if the transfer is currently uploading
Mitchell Livingston [Sat, 14 Aug 2010 19:44:43 +0000 (19:44 +0000)]
don't set an idle eta if the transfer is currently uploading

14 years agosimplify the code to check if an eta string should be displayed
Mitchell Livingston [Sat, 14 Aug 2010 17:51:04 +0000 (17:51 +0000)]
simplify the code to check if an eta string should be displayed

14 years agoif there is both an idle limit and ratio limit set, display the ratio limit unless...
Mitchell Livingston [Sat, 14 Aug 2010 17:41:12 +0000 (17:41 +0000)]
if there is both an idle limit and ratio limit set, display the ratio limit unless the idle limit is less than 2 minutes

14 years agoonly show the eta string for idle seeding time remaining if the time is less than...
Mitchell Livingston [Sat, 14 Aug 2010 17:32:52 +0000 (17:32 +0000)]
only show the eta string for idle seeding time remaining if the time is less than 2 minutes

14 years agoadd a stat for the eta of the seeding idle limit, and use it in the Mac eta display
Mitchell Livingston [Sat, 14 Aug 2010 15:30:43 +0000 (15:30 +0000)]
add a stat for the eta of the seeding idle limit, and use it in the Mac eta display

14 years agoin Prefs -> Transfers -> Management, properly gray-out the "minutes" field for the...
Mitchell Livingston [Thu, 12 Aug 2010 23:48:30 +0000 (23:48 +0000)]
in Prefs -> Transfers -> Management, properly gray-out the "minutes" field for the inactive seeding check

14 years ago(trunk libT) hm, this debugging line wasn't supposed to get checked in...
Charles Kerr [Tue, 10 Aug 2010 11:43:29 +0000 (11:43 +0000)]
(trunk libT) hm, this debugging line wasn't supposed to get checked in...

14 years ago(web) remove cruft
Daniel Lee [Tue, 10 Aug 2010 00:12:42 +0000 (00:12 +0000)]
(web) remove cruft

14 years ago(web) yet another test fix
Daniel Lee [Tue, 10 Aug 2010 00:10:08 +0000 (00:10 +0000)]
(web) yet another test fix

14 years ago(web) yet another test fix
Daniel Lee [Mon, 9 Aug 2010 23:13:46 +0000 (23:13 +0000)]
(web) yet another test fix

14 years ago(web) Another try at iphone fix
Daniel Lee [Mon, 9 Aug 2010 22:57:29 +0000 (22:57 +0000)]
(web) Another try at iphone fix

14 years ago(web) Left out some stuff from the last commit
Daniel Lee [Mon, 9 Aug 2010 21:05:56 +0000 (21:05 +0000)]
(web) Left out some stuff from the last commit

14 years ago(trunk) Update 'TryExec' in transmission-gtk.destkop to the new binary name
Daniel Lee [Mon, 9 Aug 2010 01:01:48 +0000 (01:01 +0000)]
(trunk) Update 'TryExec' in transmission-gtk.destkop to the new binary name

14 years ago(trunk) #3483:Add 'finished' filter to webui
Daniel Lee [Mon, 9 Aug 2010 00:40:46 +0000 (00:40 +0000)]
(trunk) #3483:Add 'finished' filter to webui

14 years ago(trunk web) #3485 "Add ratio to compact seeding display" -- fixed.
Charles Kerr [Mon, 9 Aug 2010 00:25:02 +0000 (00:25 +0000)]
(trunk web) #3485 "Add ratio to compact seeding display" -- fixed.

14 years ago(trunk) make --version/-V behave the same in the other apps too
Charles Kerr [Mon, 9 Aug 2010 00:18:26 +0000 (00:18 +0000)]
(trunk) make --version/-V behave the same in the other apps too

14 years ago(trunk web) tweak the statistics dialog size a little
Charles Kerr [Sun, 8 Aug 2010 23:25:34 +0000 (23:25 +0000)]
(trunk web) tweak the statistics dialog size a little

14 years ago(trunk qt) #3497 "Trackerlist not cleared/disabled when torrent selection cleared...
Charles Kerr [Sun, 8 Aug 2010 23:21:19 +0000 (23:21 +0000)]
(trunk qt) #3497 "Trackerlist not cleared/disabled when torrent selection cleared" -- fixed.

14 years ago(trunk utils) add support for --version/-V
Charles Kerr [Sun, 8 Aug 2010 22:53:24 +0000 (22:53 +0000)]
(trunk utils) add support for --version/-V

14 years ago(trunk web) #3278 "add sorting by size support to web client" -- fixed.
Charles Kerr [Sun, 8 Aug 2010 21:11:20 +0000 (21:11 +0000)]
(trunk web) #3278 "add sorting by size support to web client" -- fixed.

14 years ago(trunk web) use the preference dialog's "compact" mode based on browser window size...
Charles Kerr [Sun, 8 Aug 2010 20:58:58 +0000 (20:58 +0000)]
(trunk web) use the preference dialog's "compact" mode based on browser window size, rather than whether or not it's an iPhone -- that way it should work for other mobile devices too.

14 years ago(trunk web) rewrite the dialogs to use jQuery.UI instead of a homerolled dialog....
Charles Kerr [Sun, 8 Aug 2010 20:06:46 +0000 (20:06 +0000)]
(trunk web) rewrite the dialogs to use jQuery.UI instead of a homerolled dialog.  This partially to use more standardized components, and partially to get rid of as many browser/platform-specific hardcodings as possible to make the code more flexible.  I'm flying blind wrt iPhone support, so for a little while this may be a two-steps-forward-one-step-back process.  Feedback from users runnin the web client on their phones is encouraged...

14 years ago(trunk) annotate the RPC spec to explain that the units for rateDownload and rateUplo...
Charles Kerr [Sat, 7 Aug 2010 18:52:07 +0000 (18:52 +0000)]
(trunk) annotate the RPC spec to explain that the units for rateDownload and rateUpload changed in RPC version 10

14 years agofix another warning regarding casting during logging
Mitchell Livingston [Sat, 7 Aug 2010 16:44:31 +0000 (16:44 +0000)]
fix another warning regarding casting during logging

14 years agofix warning regarding casting during logging
Mitchell Livingston [Sat, 7 Aug 2010 16:44:17 +0000 (16:44 +0000)]
fix warning regarding casting during logging

14 years ago(trunk) tweak NEWS
Mitchell Livingston [Sat, 7 Aug 2010 03:46:49 +0000 (03:46 +0000)]
(trunk) tweak NEWS

14 years ago(trunk libT) #3493 "transmission doesn't exit cleanly if LPD is disabled during the...
Charles Kerr [Sat, 7 Aug 2010 03:29:47 +0000 (03:29 +0000)]
(trunk libT) #3493 "transmission doesn't exit cleanly if LPD is disabled during the session" -- fixed.

14 years ago(trunk libT) when shutting down, use a shorter timeout interval for tracker announces
Charles Kerr [Sat, 7 Aug 2010 02:17:29 +0000 (02:17 +0000)]
(trunk libT) when shutting down, use a shorter timeout interval for tracker announces

14 years ago(trunk qt) set the step values for the properties dialog's spinboxes
Charles Kerr [Sat, 7 Aug 2010 01:38:50 +0000 (01:38 +0000)]
(trunk qt) set the step values for the properties dialog's spinboxes

14 years ago(trunk gtk) fix label clipping issue in the statusbar
Charles Kerr [Fri, 6 Aug 2010 23:50:35 +0000 (23:50 +0000)]
(trunk gtk) fix label clipping issue in the statusbar

14 years ago(trunk libT) fix compiler warnings on non-glibc systems
Charles Kerr [Fri, 6 Aug 2010 23:28:30 +0000 (23:28 +0000)]
(trunk libT) fix compiler warnings on non-glibc systems

14 years ago(trunk) update to 2.04+
Mitchell Livingston [Fri, 6 Aug 2010 23:15:29 +0000 (23:15 +0000)]
(trunk) update to 2.04+

14 years ago(trunk qt) annoy Lacrocivious by removing the unused dancing hula girls icon from...
Charles Kerr [Fri, 6 Aug 2010 20:27:52 +0000 (20:27 +0000)]
(trunk qt) annoy Lacrocivious by removing the unused dancing hula girls icon from the Qt client's resource file

14 years ago(trunk qt) bump Qt prerequisite from 4.4 to 4.6
Charles Kerr [Fri, 6 Aug 2010 20:23:32 +0000 (20:23 +0000)]
(trunk qt) bump Qt prerequisite from 4.4 to 4.6

14 years ago(trunk qt) now that 4.6 has a standard call QIcon::fromTheme(), we can drop the third...
Charles Kerr [Fri, 6 Aug 2010 20:21:35 +0000 (20:21 +0000)]
(trunk qt) now that 4.6 has a standard call QIcon::fromTheme(), we can drop the third-party qticonloader code