]>
granicus.if.org Git - graphviz/log
Matthew Fernandez [Thu, 29 Dec 2022 21:42:03 +0000 (13:42 -0800)]
sparse SingleLinkedList_new_int: fix unchecked allocation failure
Matthew Fernandez [Fri, 18 Nov 2022 01:14:41 +0000 (17:14 -0800)]
sparse SingleLinkedList_new: use cgraph wrapper for allocation
The lib/cgraph/alloc.h wrappers are similar to the older lib/common/memory.h
wrappers except (1) they are header-only and (2) they live in a directory
(cgraph) that is at the root of the dependency tree. The long term plan is to
replace all use of lib/common/memory.h with lib/cgraph/alloc.h.
Matthew Fernandez [Fri, 30 Dec 2022 18:25:37 +0000 (18:25 +0000)]
Merge branch 'smattr/gitlab-2332' into 'main'
Autotools: remove legacy `python` discovery
See merge request graphviz/graphviz!3022
Matthew Fernandez [Thu, 29 Dec 2022 21:16:01 +0000 (13:16 -0800)]
Autotools: remove legacy `python` discovery
When removing Python 2 support, the discovery paths that checked for the Python
interpreter as `python` were retained to support older distros in the Red Hat
ecosystem where Python 3 goes by the name `python`. All currently supported
distros use the name `python3`, so this code is no longer needed.
Gitlab: related to #2332
Matthew Fernandez [Fri, 30 Dec 2022 07:36:19 +0000 (07:36 +0000)]
Merge branch 'smattr/
baf8fad8 -8d84-44e2-8ff6-
1ac1ee98a0e2 ' into 'main'
sfdpgen: remove unused control options
See merge request graphviz/graphviz!3021
Matthew Fernandez [Thu, 29 Dec 2022 20:03:06 +0000 (12:03 -0800)]
sfdpgen: remove unused 'maximal_independent_vertex_set'
Matthew Fernandez [Thu, 29 Dec 2022 20:01:09 +0000 (12:01 -0800)]
sfdpgen: remove unused 'maximal_independent_vertex_set_RS'
Matthew Fernandez [Thu, 29 Dec 2022 19:59:12 +0000 (11:59 -0800)]
sfdpgen: remove unused 'maximal_independent_edge_set'
Matthew Fernandez [Thu, 29 Dec 2022 19:57:28 +0000 (11:57 -0800)]
sfdpgen: remove unused 'maximal_independent_edge_set_heavest_edge_pernode'
Matthew Fernandez [Thu, 29 Dec 2022 19:55:39 +0000 (11:55 -0800)]
sfdpgen: remove unused 'maximal_independent_edge_set_heavest_edge_pernode_leaves_first'
Matthew Fernandez [Thu, 29 Dec 2022 19:53:30 +0000 (11:53 -0800)]
sfdpgen: remove unused 'maximal_independent_edge_set_heavest_cluster_pernode_leaves_first'
Matthew Fernandez [Thu, 29 Dec 2022 19:48:43 +0000 (11:48 -0800)]
sfdpgen: remove unused 'maximal_independent_edge_set_heavest_edge_pernode_scaled'
Matthew Fernandez [Thu, 29 Dec 2022 19:47:56 +0000 (11:47 -0800)]
sfdpgen: remove unused 'D' parameter threaded through functions
Matthew Fernandez [Thu, 29 Dec 2022 19:44:02 +0000 (11:44 -0800)]
sfdpgen: remove 'coarsen_scheme' control parameter that is always set the same
Matthew Fernandez [Thu, 29 Dec 2022 19:28:55 +0000 (11:28 -0800)]
sfdpgen: remove 'randomize' control parameter that is always true
Matthew Fernandez [Thu, 29 Dec 2022 19:15:44 +0000 (11:15 -0800)]
sparse Multilevel_MQ_Clustering_establish: remove unnecessary cast
Matthew Fernandez [Thu, 29 Dec 2022 19:15:27 +0000 (11:15 -0800)]
sparse get_mq: remove unnecessary cast
Matthew Fernandez [Thu, 29 Dec 2022 19:15:13 +0000 (11:15 -0800)]
sparse SparseMatrix_import_dot: remove unnecessary cast
Matthew Fernandez [Thu, 29 Dec 2022 19:14:55 +0000 (11:14 -0800)]
neatogen OverlapSmoother_new: remove unnecessary casts
Matthew Fernandez [Thu, 29 Dec 2022 19:14:22 +0000 (11:14 -0800)]
neatogen ideal_distance_avoid_overlap: remove useless return statement
Matthew Fernandez [Thu, 29 Dec 2022 19:14:03 +0000 (11:14 -0800)]
neatogen fdpAdjust: remove unused return value
Matthew Fernandez [Thu, 29 Dec 2022 19:11:15 +0000 (11:11 -0800)]
gvmap get_polygon_solids: remove commented out code
Matthew Fernandez [Thu, 29 Dec 2022 19:10:18 +0000 (11:10 -0800)]
gvmap get_polygon_solids: remove unnecessary casts
Matthew Fernandez [Thu, 29 Dec 2022 19:10:00 +0000 (11:10 -0800)]
gvmap get_poly_lines: remove unnecessary cast
Matthew Fernandez [Thu, 29 Dec 2022 19:09:47 +0000 (11:09 -0800)]
gvmap plot_dot_polygons: remove unnecessary cast
Matthew Fernandez [Thu, 29 Dec 2022 19:09:27 +0000 (11:09 -0800)]
gvmap improve_contiguity: remove unnecessary cast
Matthew Fernandez [Thu, 29 Dec 2022 19:08:55 +0000 (11:08 -0800)]
sparse SparseMatrix: use a 'size_t' for 'size'
Squashes 20 -Wsign-conversion, -Wconversion warnings.
Matthew Fernandez [Fri, 30 Dec 2022 00:25:47 +0000 (00:25 +0000)]
Merge branch 'smattr/gitlab-2322' into 'main'
remove gv.php include from PHP demo
Closes #2322
See merge request graphviz/graphviz!3024
Matthew Fernandez [Thu, 29 Dec 2022 22:17:41 +0000 (14:17 -0800)]
remove gv.php include from PHP demo
As of SWIG 4.1.0, PHP source is no longer generated when SWIG is targeting PHP.
Gitlab: closes #2322
Reported-by: Petr Sumbera
Matthew Fernandez [Sun, 25 Dec 2022 21:23:58 +0000 (21:23 +0000)]
Merge branch 'smattr/
0f210128 -9f5a-42e9-b2cd-
9a2a16a12a7c ' into 'main'
CI: remove Fedora 35 jobs
See merge request graphviz/graphviz!3013
Matthew Fernandez [Sun, 25 Dec 2022 20:33:26 +0000 (12:33 -0800)]
CI: remove Fedora 35 jobs
Fedora 35 has been EOLed since 2022-12-13¹.
¹ https://docs.fedoraproject.org/en-US/releases/eol/
Matthew Fernandez [Sun, 25 Dec 2022 16:57:21 +0000 (16:57 +0000)]
Merge branch 'smattr/
4fc2dbeb -1d26-463e-9258-
c6bbfda1b586 ' into 'main'
smyrna: remove more unused code
See merge request graphviz/graphviz!3012
Matthew Fernandez [Sun, 25 Dec 2022 02:29:09 +0000 (02:29 +0000)]
Merge branch 'smattr/
441b433a -bf42-4224-b269-
29de6bd0e153 ' into 'main'
neatogen: fix memory leak
See merge request graphviz/graphviz!3006
Matthew Fernandez [Thu, 22 Dec 2022 03:33:05 +0000 (19:33 -0800)]
neatogen: push queue allocation into 'bfs_bounded'
Similar to the previous commit, the callee does not care about the contents of
the queue on entry and the caller does not care about the contents of the queue
on exit. Note that in this case we need to add an extra parameter because
`bfs_bounded` did not have the queue size already.
Matthew Fernandez [Thu, 22 Dec 2022 03:18:54 +0000 (19:18 -0800)]
neatogen: push queue allocation into 'bfs'
Callers of `bfs` were constructing `Queue` objects and passing them into `bfs`.
But in all of these cases neither the callee nor the caller care about the
contents of the queue. This appears to have been an optimization to hoist
allocation of this object outside loops in callers. This is nowhere close to the
most expensive operation these locations are performing. And replicating
operations like this led to opportunities for errors like that fixed in the
prior commit. It seems a win to undo this for readability.
Matthew Fernandez [Thu, 22 Dec 2022 03:08:15 +0000 (19:08 -0800)]
neatogen embed_graph: fix memory leak of queue
Every call to `mkQueue` is intended to be paired with a call to `freeQueue`.
This function was missing its call to the free function.
Matthew Fernandez [Thu, 22 Dec 2022 03:00:31 +0000 (19:00 -0800)]
neatogen embed_graph: remove free of output parameter
The only call into this function passes `NULL` for the `coords` parameter.
Additionally it did not make much sense to free this pointer on behalf of the
caller. This function is not designed to be called in a loop, so if the caller
wants their passed-in parameter freed they should do it themselves prior to
calling.
Matthew Fernandez [Sun, 25 Dec 2022 01:16:09 +0000 (01:16 +0000)]
Merge branch 'smattr/
9d358411 -5cf8-4ba0-90f6-
97c5708027dc ' into 'main'
also allow macOS to fail the long chain test
See merge request graphviz/graphviz!3011
Matthew Fernandez [Sat, 24 Dec 2022 22:11:05 +0000 (14:11 -0800)]
smyrna: remove unused 'dlgOpenGraph_OK_Clicked'
The last use of this was removed in
7d1170f8d5208c296db891f5d93bbb158b1c1b56 .
Matthew Fernandez [Sat, 24 Dec 2022 22:07:42 +0000 (14:07 -0800)]
smyrna: remove unused 'on_newNode'
This has never been used.
Matthew Fernandez [Sat, 24 Dec 2022 22:05:30 +0000 (14:05 -0800)]
smyrna set_combobox_widget: remove no-op casts
Matthew Fernandez [Sat, 24 Dec 2022 21:53:59 +0000 (13:53 -0800)]
smyrna: remove unused 'nodesize'
Matthew Fernandez [Sat, 24 Dec 2022 21:46:58 +0000 (13:46 -0800)]
smyrna appmouse_up: remove no-op branches
Matthew Fernandez [Sat, 24 Dec 2022 21:44:30 +0000 (13:44 -0800)]
smyrna: remove unused 'prevX', 'prevY'
These have never been used.
Matthew Fernandez [Sat, 24 Dec 2022 21:30:04 +0000 (13:30 -0800)]
gvedit: remove unused 'initFiles'
Matthew Fernandez [Sat, 24 Dec 2022 21:24:25 +0000 (13:24 -0800)]
smyrna: remove disabled test mode code
Matthew Fernandez [Sat, 24 Dec 2022 21:22:52 +0000 (13:22 -0800)]
smyrna: remove unused top view user mode constants
The last use of these was removed in
34d079565882fbffdf58fe61d0f493274438a699 .
Matthew Fernandez [Sat, 24 Dec 2022 21:22:03 +0000 (13:22 -0800)]
smyrna: remove unused 'DEFAULT_FISHEYE_MAGNIFIER_RADIUS'
The last use of this was removed in
95730136091ba690f74d1ef802ca42b3cb4ed71c .
Matthew Fernandez [Sat, 24 Dec 2022 21:20:56 +0000 (13:20 -0800)]
smyrna: remove unused magnifier constants
The last use of these was removed in
6baa97a6e98923364f9d1b9a613f2b1aed87fb1b .
Matthew Fernandez [Sat, 24 Dec 2022 21:17:36 +0000 (13:17 -0800)]
also allow macOS to fail the long chain test
It seems this test can also fail in CI on macOS.
Gitlab: #1710, #1720
Matthew Fernandez [Sat, 24 Dec 2022 20:31:59 +0000 (20:31 +0000)]
Merge branch 'smattr/
0ecb9860 -22d9-40d2-9f38-
d0e434414c10 ' into 'main'
smyrna: remove some unused code
See merge request graphviz/graphviz!3005
Matthew Fernandez [Wed, 21 Dec 2022 06:05:56 +0000 (22:05 -0800)]
smyrna: remove unused 'defaultnodeshape'
Matthew Fernandez [Wed, 21 Dec 2022 05:57:16 +0000 (21:57 -0800)]
smyrna: remove unused 'filtered_attr_list'
Matthew Fernandez [Wed, 21 Dec 2022 05:50:44 +0000 (21:50 -0800)]
smyrna: remove unused 'magnifier'
Matthew Fernandez [Wed, 21 Dec 2022 05:46:22 +0000 (21:46 -0800)]
smyrna: remove unused 'fisheye_magnifier'
Matthew Fernandez [Wed, 21 Dec 2022 05:44:47 +0000 (21:44 -0800)]
smyrna: remove unused 'FontSize'
Matthew Fernandez [Wed, 21 Dec 2022 05:42:36 +0000 (21:42 -0800)]
smyrna: remove duplicate 'defaultmagnifierwidth' retrieval
The return value of this call was being ignored. It seems accidentally
copy-pasted from the lines below.
Matthew Fernandez [Wed, 21 Dec 2022 05:39:48 +0000 (21:39 -0800)]
smyrna: remove unused 'topviewusermode'
Matthew Fernandez [Wed, 21 Dec 2022 05:36:49 +0000 (21:36 -0800)]
smyrna: remove unused 'edgerendertype'
Matthew Fernandez [Wed, 21 Dec 2022 05:32:52 +0000 (21:32 -0800)]
smyrna set_viewport_settings_from_template: remove shadowing of 'view' global
Matthew Fernandez [Wed, 21 Dec 2022 05:27:05 +0000 (21:27 -0800)]
smyrna get_attribute_value: remove shadowing of 'view' global
Matthew Fernandez [Wed, 21 Dec 2022 05:26:37 +0000 (21:26 -0800)]
smyrna close_graph: remove shadowing of 'view' global
Matthew Fernandez [Wed, 21 Dec 2022 05:26:04 +0000 (21:26 -0800)]
smyrna clear_viewport: remove shadowing of 'view' global
Matthew Fernandez [Wed, 21 Dec 2022 05:22:19 +0000 (21:22 -0800)]
smyrna add_camera_to_viewport: remove shadowing of 'view' global
Matthew Fernandez [Wed, 21 Dec 2022 05:20:18 +0000 (21:20 -0800)]
smyrna new_viewport_camera: remove unused 'view' parameter
Matthew Fernandez [Wed, 21 Dec 2022 05:18:38 +0000 (21:18 -0800)]
smyrna: squash some -Wmissing-prototypes warnings
Matthew Fernandez [Wed, 21 Dec 2022 05:11:53 +0000 (21:11 -0800)]
symrna: squash -Wunused-parameter warnings in data callbacks
Matthew Fernandez [Wed, 21 Dec 2022 05:09:52 +0000 (21:09 -0800)]
smyrna new_attr: remove shadowing of global 'attr'
Note that none of the zero assignments in this function were necessary because
`gv_alloc` zeros memory.
Matthew Fernandez [Wed, 21 Dec 2022 05:08:47 +0000 (21:08 -0800)]
smyrna new_attr_with_ref: remove shadowing of 'attr' global
Matthew Fernandez [Wed, 21 Dec 2022 05:07:47 +0000 (21:07 -0800)]
smyrna new_attr_ref: remove shadowing of global 'attr'
Matthew Fernandez [Wed, 21 Dec 2022 05:06:34 +0000 (21:06 -0800)]
smyrna attr_list_new: remove unused 'g' parameter
Matthew Fernandez [Wed, 21 Dec 2022 05:00:41 +0000 (21:00 -0800)]
common startElement: remove an unnecessary cast
Matthew Fernandez [Wed, 21 Dec 2022 04:59:35 +0000 (20:59 -0800)]
cgraph: fix comment typo
Matthew Fernandez [Sat, 24 Dec 2022 19:39:23 +0000 (19:39 +0000)]
Merge branch 'smattr/
ae4b501f -6c51-4f2c-8ccb-
b8f433b8685c ' into 'main'
common: warning squashing
See merge request graphviz/graphviz!3007
Matthew Fernandez [Fri, 23 Dec 2022 03:43:38 +0000 (19:43 -0800)]
common: remove unnecessary parens
Matthew Fernandez [Fri, 18 Nov 2022 01:14:41 +0000 (17:14 -0800)]
common newItem: use cgraph wrapper for allocation
The lib/cgraph/alloc.h wrappers are similar to the older lib/common/memory.h
wrappers except (1) they are header-only and (2) they live in a directory
(cgraph) that is at the root of the dependency tree. The long term plan is to
replace all use of lib/common/memory.h with lib/cgraph/alloc.h.
Matthew Fernandez [Fri, 18 Nov 2022 01:14:41 +0000 (17:14 -0800)]
common fillMap: use cgraph wrapper for allocation
The lib/cgraph/alloc.h wrappers are similar to the older lib/common/memory.h
wrappers except (1) they are header-only and (2) they live in a directory
(cgraph) that is at the root of the dependency tree. The long term plan is to
replace all use of lib/common/memory.h with lib/cgraph/alloc.h.
Matthew Fernandez [Fri, 23 Dec 2022 03:07:25 +0000 (19:07 -0800)]
common cvtAndAppend: use a more appropriate type for 'len'
Squashes a -Wsign-conversion warning.
Matthew Fernandez [Fri, 23 Dec 2022 03:04:58 +0000 (19:04 -0800)]
common scanEntity: use a more appropriate type for 'len'
This addresses a problem where the subtraction of two pointers, `endp - t`, can
in theory exceed the size of an `int`. In practice this cannot occur, but using
a more correct type squashes a -Wconversion and -Wsign-conversion warning in
this code.
Matthew Fernandez [Fri, 18 Nov 2022 01:14:41 +0000 (17:14 -0800)]
common undoClusterEdges: use cgraph wrapper for allocation
The lib/cgraph/alloc.h wrappers are similar to the older lib/common/memory.h
wrappers except (1) they are header-only and (2) they live in a directory
(cgraph) that is at the root of the dependency tree. The long term plan is to
replace all use of lib/common/memory.h with lib/cgraph/alloc.h.
Matthew Fernandez [Fri, 23 Dec 2022 03:00:30 +0000 (19:00 -0800)]
common undoClusterEdges: remove shadowing of 'elist' global
Matthew Fernandez [Fri, 23 Dec 2022 02:56:37 +0000 (18:56 -0800)]
common gvToggle: squash -Wunused-parameter warning
Matthew Fernandez [Fri, 23 Dec 2022 02:55:25 +0000 (18:55 -0800)]
common late_int: detect and reject int out of range
Squashes a -Wconversion warning.
Matthew Fernandez [Fri, 23 Dec 2022 02:50:57 +0000 (18:50 -0800)]
common new_queue: squash -Wsign-conversion warning
`sz` is known ≥ 2 here.
Matthew Fernandez [Fri, 18 Nov 2022 01:14:41 +0000 (17:14 -0800)]
common new_queue: use cgraph wrappers for allocation
The lib/cgraph/alloc.h wrappers are similar to the older lib/common/memory.h
wrappers except (1) they are header-only and (2) they live in a directory
(cgraph) that is at the root of the dependency tree. The long term plan is to
replace all use of lib/common/memory.h with lib/cgraph/alloc.h.
Matthew Fernandez [Sat, 24 Dec 2022 18:42:08 +0000 (18:42 +0000)]
Merge branch 'smattr/
1b8f5782 -a2fc-4215-b3d5-
d82c6944966a ' into 'main'
remove some dynamic allocations
See merge request graphviz/graphviz!3009
Matthew Fernandez [Fri, 23 Dec 2022 22:06:11 +0000 (14:06 -0800)]
dotgen _dot_splines: remove unnecessary dynamic allocation of 'P'
Matthew Fernandez [Fri, 23 Dec 2022 21:57:47 +0000 (13:57 -0800)]
common init_job_viewport: remove unnecessary 'junk' string allocation
Matthew Fernandez [Fri, 23 Dec 2022 21:50:19 +0000 (13:50 -0800)]
common taper: return 'stroke_t' by value
Saves unnecessary dynamic allocation and caller clean up.
Matthew Fernandez [Fri, 23 Dec 2022 21:37:04 +0000 (13:37 -0800)]
gxl2gv: remove unnecessary dynamic allocation of user data
Matthew Fernandez [Fri, 23 Dec 2022 21:33:15 +0000 (13:33 -0800)]
gv2gxl: remove unnecessary dynamic allocation of state
Matthew Fernandez [Fri, 23 Dec 2022 21:27:01 +0000 (13:27 -0800)]
graphml2gv: remove unnecessary dynamic allocation of user data
Matthew Fernandez [Fri, 23 Dec 2022 21:12:45 +0000 (13:12 -0800)]
dotgen make_flat_adj_edges: remove unnecessary dynamic allocation of 'attrs'
Matthew Fernandez [Sat, 24 Dec 2022 17:50:34 +0000 (17:50 +0000)]
Merge branch 'smattr/gitlab-1720' into 'main'
fix reading incorrect input in #1710 test case
See merge request graphviz/graphviz!3010
Matthew Fernandez [Fri, 23 Dec 2022 04:16:56 +0000 (20:16 -0800)]
fix reading incorrect input in #1710 test case
A mistake in
632fe0bd1cfc6a4f636db4f85206aff6720bdc6b made this test read from
/dev/null instead of the input file it was supposed to read. Note that this
required some tweak to the skip condition. The Windows platforms on which this
fails seems all over the place and expressing the exact pattern seemed too
complex. For the curious, what we currently see in CI is:
┌──────────────┬─────────┬──────────────┬─────────┬────────┐
│ architecture │ OS │ build system │ mode │ result │
╞══════════════╪═════════╪══════════════╪═════════╪════════╡
│ x86 │ Windows │ MS Build │ debug │ FAIL │
│ │ │ ├─────────┼────────┤
│ │ │ │ release │ pass │
│ │ ├──────────────┼─────────┼────────┤
│ │ │ CMake │ debug │ FAIL │
│ │ │ ├─────────┼────────┤
│ │ │ │ release │ FAIL │
│ ├─────────┼──────────────┼─────────┼────────┤
│ │ MinGW │ CMake │ - │ pass │
├──────────────┼─────────┼──────────────┼─────────┼────────┤
│ x86-64 │ Windows │ CMake │ debug │ FAIL │
│ │ │ ├─────────┼────────┤
│ │ │ │ release │ FAIL │
│ ├─────────┼──────────────┼─────────┼────────┤
│ │ MinGW │ CMake │ - │ FAIL │
└──────────────┴─────────┴──────────────┴─────────┴────────┘
I would not be surprised if these results are not stable. It is likely this
failure presents across all platforms, but is dependent on things like Address
Space Layout Randomization to exhibit.
Gitlab: #1710, #1720
Matthew Fernandez [Fri, 23 Dec 2022 20:20:37 +0000 (20:20 +0000)]
Merge branch 'smattr/
331f7848 -cb40-4753-91cb-
c1599c4e3000 ' into 'main'
Start 7.0.6 development
See merge request graphviz/graphviz!3008
Matthew Fernandez [Fri, 23 Dec 2022 19:32:00 +0000 (11:32 -0800)]
Start 7.0.6 development
Matthew Fernandez [Fri, 23 Dec 2022 19:30:12 +0000 (19:30 +0000)]
Merge branch 'smattr/
26ab1e3b -7718-4870-a101-
5767137531c5 ' into 'main'
Stable Release 7.0.5
See merge request graphviz/graphviz!3001
Matthew Fernandez [Wed, 14 Dec 2022 16:05:32 +0000 (08:05 -0800)]
Stable Release 7.0.5
Matthew Fernandez [Wed, 21 Dec 2022 05:26:48 +0000 (05:26 +0000)]
Merge branch 'smattr/gitlab-2329' into 'main'
CI: disable Cygwin jobs
See merge request graphviz/graphviz!3004