]> granicus.if.org Git - taglib/log
taglib
9 years agoMake use of List iterators and setAutoDelete() in FLAC::File.
Tsuda Kageyu [Tue, 15 Dec 2015 06:31:33 +0000 (15:31 +0900)]
Make use of List iterators and setAutoDelete() in FLAC::File.

9 years agoUpdate NEWS.
Tsuda Kageyu [Tue, 15 Dec 2015 06:18:07 +0000 (15:18 +0900)]
Update NEWS.

9 years agoMerge pull request #682 from TsudaKageyu/save-flac
Tsuda Kageyu [Tue, 15 Dec 2015 06:08:14 +0000 (15:08 +0900)]
Merge pull request #682 from TsudaKageyu/save-flac

Fix saving FLAC files.

9 years agoMerge pull request #698 from TsudaKageyu/mpeg-header-check
Tsuda Kageyu [Tue, 15 Dec 2015 01:11:13 +0000 (10:11 +0900)]
Merge pull request #698 from TsudaKageyu/mpeg-header-check

More robust checks for invalid MPEG frame headers.

9 years agoMore robust checks for invalid MPEG frame headers.
Tsuda Kageyu [Tue, 8 Dec 2015 02:11:50 +0000 (11:11 +0900)]
More robust checks for invalid MPEG frame headers.

9 years agoFix careless copy-and-paste code.
Tsuda Kageyu [Fri, 4 Dec 2015 05:28:56 +0000 (14:28 +0900)]
Fix careless copy-and-paste code.

9 years agoUpdate NEWS.
Tsuda Kageyu [Fri, 4 Dec 2015 05:15:51 +0000 (14:15 +0900)]
Update NEWS.

9 years agoMerge pull request #694 from FestusHagen/fh1.m_NoSharedLibTests
Tsuda Kageyu [Fri, 4 Dec 2015 02:41:44 +0000 (11:41 +0900)]
Merge pull request #694 from FestusHagen/fh1.m_NoSharedLibTests

Disable tests with a shared library.

9 years agoDisable tests with a shared library.
Festus Hagen [Thu, 3 Dec 2015 19:36:42 +0000 (14:36 -0500)]
Disable tests with a shared library.

9 years agoRemove some unused private data members.
Tsuda Kageyu [Thu, 3 Dec 2015 07:55:05 +0000 (16:55 +0900)]
Remove some unused private data members.

9 years agoMove a test to the proper place.
Tsuda Kageyu [Thu, 3 Dec 2015 04:05:18 +0000 (13:05 +0900)]
Move a test to the proper place.

The test is actually for XiphComment, not Vorbis::File.

9 years agoSimpler conversion from bits to bytes.
Tsuda Kageyu [Thu, 3 Dec 2015 03:34:54 +0000 (12:34 +0900)]
Simpler conversion from bits to bytes.

9 years agoRevert some ABI breaking changes.
Tsuda Kageyu [Thu, 3 Dec 2015 01:06:04 +0000 (10:06 +0900)]
Revert some ABI breaking changes.

9 years agoSmall cosmetic fixes.
Tsuda Kageyu [Wed, 2 Dec 2015 17:25:16 +0000 (02:25 +0900)]
Small cosmetic fixes.

9 years agoUse a standard type rather than TagLib::uint.
Tsuda Kageyu [Wed, 2 Dec 2015 16:50:44 +0000 (01:50 +0900)]
Use a standard type rather than TagLib::uint.

This won't break the ABI compatibility.

9 years agoUse a standard type rather than TagLib::ulong.
Tsuda Kageyu [Wed, 2 Dec 2015 15:03:06 +0000 (00:03 +0900)]
Use a standard type rather than TagLib::ulong.

This won't break the ABI compatibility.

9 years agoSmall cosmetic fixes.
Tsuda Kageyu [Wed, 2 Dec 2015 14:21:23 +0000 (23:21 +0900)]
Small cosmetic fixes.

9 years agoMerge pull request #545 from FestusHagen/fh1.m_TDRC
Tsuda Kageyu [Wed, 2 Dec 2015 12:11:53 +0000 (21:11 +0900)]
Merge pull request #545 from FestusHagen/fh1.m_TDRC

Append TIME to TDRC, adjusted test_id3v2.cpp as appropriate.

9 years agoUse a standard type rather than TagLib::ushort.
Tsuda Kageyu [Wed, 2 Dec 2015 09:59:45 +0000 (18:59 +0900)]
Use a standard type rather than TagLib::ushort.

This won't break the ABI compatibility.

9 years agoUse a standard type rather than TagLib::uchar.
Tsuda Kageyu [Wed, 2 Dec 2015 09:11:52 +0000 (18:11 +0900)]
Use a standard type rather than TagLib::uchar.

This won't break the ABI compatibility.

9 years agoMake use of List iterators and setAutoDelete() in XiphComment.
Tsuda Kageyu [Wed, 2 Dec 2015 08:33:11 +0000 (17:33 +0900)]
Make use of List iterators and setAutoDelete() in XiphComment.

9 years agoFix saving FLAC files.
Tsuda Kageyu [Tue, 24 Nov 2015 03:27:39 +0000 (12:27 +0900)]
Fix saving FLAC files.

This fixes all the issues reported at #622.

9 years agoUpdate NEWS.
Tsuda Kageyu [Wed, 2 Dec 2015 06:01:10 +0000 (15:01 +0900)]
Update NEWS.

9 years agoMerge branch 'xiph-picture' of https://github.com/gogglesmm/taglib into gogglesmm...
Tsuda Kageyu [Wed, 2 Dec 2015 05:59:50 +0000 (14:59 +0900)]
Merge branch 'xiph-picture' of https://github.com/gogglesmm/taglib into gogglesmm-xiph-picture

# Conflicts:
# tests/test_bytevector.cpp
# tests/test_ogg.cpp

9 years agoUpdate NEWS.
Tsuda Kageyu [Wed, 2 Dec 2015 05:28:41 +0000 (14:28 +0900)]
Update NEWS.

9 years agoMerge branch 'cmake-allow-BUILD_SHARED_LIBS-to-drive-ENABLE_STATIC' of https://github...
Tsuda Kageyu [Wed, 2 Dec 2015 05:21:58 +0000 (14:21 +0900)]
Merge branch 'cmake-allow-BUILD_SHARED_LIBS-to-drive-ENABLE_STATIC' of https://github.com/tSed/taglib into tSed-cmake-allow-BUILD_SHARED_LIBS-to-drive-ENABLE_STATIC

# Conflicts:
# CMakeLists.txt
# examples/CMakeLists.txt

9 years agoRemove an unreachable statement.
Tsuda Kageyu [Wed, 2 Dec 2015 05:08:20 +0000 (14:08 +0900)]
Remove an unreachable statement.

9 years agoSurround some internal stuff by anonymous namespaces.
Tsuda Kageyu [Wed, 2 Dec 2015 03:00:43 +0000 (12:00 +0900)]
Surround some internal stuff by anonymous namespaces.

9 years agoAmend some comments refer to the 'offset_t' type. It no longer exists.
Tsuda Kageyu [Wed, 2 Dec 2015 02:36:54 +0000 (11:36 +0900)]
Amend some comments refer to the 'offset_t' type. It no longer exists.

9 years agoUse a standard type rather than TagLib::wchar.
Tsuda Kageyu [Wed, 2 Dec 2015 02:30:29 +0000 (11:30 +0900)]
Use a standard type rather than TagLib::wchar.

This won't break the ABI compatibility.

9 years agoUse a standard type rather than TagLib::ulonglong.
Tsuda Kageyu [Wed, 2 Dec 2015 00:13:10 +0000 (09:13 +0900)]
Use a standard type rather than TagLib::ulonglong.

TagLib::ulonglong is not used in the public headers, so the changes are trivial.

9 years agoMerge pull request #690 from stefansaraev/pkgconfig
Lukáš Lalinský [Tue, 1 Dec 2015 15:47:47 +0000 (16:47 +0100)]
Merge pull request #690 from stefansaraev/pkgconfig

fix pkgconfig file for cross compiling

9 years agoMerge pull request #691 from FestusHagen/fh1.m_ushortAmbiguities
Tsuda Kageyu [Mon, 30 Nov 2015 15:02:25 +0000 (00:02 +0900)]
Merge pull request #691 from FestusHagen/fh1.m_ushortAmbiguities

Silence ushort ambiguity errors

9 years agoSilence ushort ambiguity errors
Festus Hagen [Sun, 29 Nov 2015 10:13:44 +0000 (05:13 -0500)]
Silence ushort ambiguity errors

9 years agofix pkgconfig file for cross compiling
Stefan Saraev [Mon, 30 Nov 2015 12:09:15 +0000 (14:09 +0200)]
fix pkgconfig file for cross compiling

9 years agoThe new test wasn't called.
Tsuda Kageyu [Mon, 30 Nov 2015 09:32:49 +0000 (18:32 +0900)]
The new test wasn't called.

9 years agoAdd some tests for M4V files.
Tsuda Kageyu [Mon, 30 Nov 2015 08:18:50 +0000 (17:18 +0900)]
Add some tests for M4V files.

9 years agoMerge branch 'm4v' of https://github.com/videolabs/taglib into videolabs-m4v
Tsuda Kageyu [Mon, 30 Nov 2015 08:12:03 +0000 (17:12 +0900)]
Merge branch 'm4v' of https://github.com/videolabs/taglib into videolabs-m4v

# Conflicts:
# taglib/fileref.cpp

9 years agoUnify some duplicate internal functions.
Tsuda Kageyu [Mon, 30 Nov 2015 07:35:37 +0000 (16:35 +0900)]
Unify some duplicate internal functions.

9 years agoAdd const to an unchanged data member.
Tsuda Kageyu [Mon, 30 Nov 2015 07:21:58 +0000 (16:21 +0900)]
Add const to an unchanged data member.

9 years agoRemove some private data members not needed to belong to private classes.
Tsuda Kageyu [Mon, 30 Nov 2015 06:43:18 +0000 (15:43 +0900)]
Remove some private data members not needed to belong to private classes.

9 years agoAvoid trying to remove tag chunks when an AIFF file doesn't have an ID3v2 tag.
Tsuda Kageyu [Mon, 30 Nov 2015 05:17:26 +0000 (14:17 +0900)]
Avoid trying to remove tag chunks when an AIFF file doesn't have an ID3v2 tag.

9 years agoAdd some tests to check if the internal flags are updated when writing WAV files.
Tsuda Kageyu [Mon, 30 Nov 2015 04:46:43 +0000 (13:46 +0900)]
Add some tests to check if the internal flags are updated when writing WAV files.

9 years agoAvoid writing an empty ID3v2 tag in an AIFF file.
Tsuda Kageyu [Mon, 30 Nov 2015 04:42:25 +0000 (13:42 +0900)]
Avoid writing an empty ID3v2 tag in an AIFF file.

9 years agoRemove some private data members not needed to be carried.
Tsuda Kageyu [Mon, 30 Nov 2015 04:09:11 +0000 (13:09 +0900)]
Remove some private data members not needed to be carried.

9 years agoRemove some private data members not needed to be carried.
Tsuda Kageyu [Mon, 30 Nov 2015 03:53:52 +0000 (12:53 +0900)]
Remove some private data members not needed to be carried.

9 years agoRemove some private data members not needed to be carried.
Tsuda Kageyu [Mon, 30 Nov 2015 03:35:29 +0000 (12:35 +0900)]
Remove some private data members not needed to be carried.

9 years agoAdd some tests about splitting/merging Ogg pages.
Tsuda Kageyu [Sat, 28 Nov 2015 16:57:15 +0000 (01:57 +0900)]
Add some tests about splitting/merging Ogg pages.

9 years agoAppend TIME to TDRC, adjusted test_id3v2.cpp as appropriate.
Festus Hagen [Sat, 16 May 2015 20:06:14 +0000 (16:06 -0400)]
Append TIME to TDRC, adjusted test_id3v2.cpp as appropriate.

9 years agoClose temporary files regardless if the tests are successful or not.
Tsuda Kageyu [Fri, 27 Nov 2015 06:20:16 +0000 (15:20 +0900)]
Close temporary files regardless if the tests are successful or not.

delete statements are skipped when assertions fail.

9 years agoAdd ENABLE_CCACHE build option to allow users opt in to use ccache.
Tsuda Kageyu [Fri, 27 Nov 2015 03:15:03 +0000 (12:15 +0900)]
Add ENABLE_CCACHE build option to allow users opt in to use ccache.

9 years agoUpdate NEWS.
Tsuda Kageyu [Fri, 27 Nov 2015 00:37:29 +0000 (09:37 +0900)]
Update NEWS.

9 years agoMerge branch 'fh1.m_AddBuildBindingsOption' of https://github.com/FestusHagen/taglib...
Tsuda Kageyu [Fri, 27 Nov 2015 00:35:13 +0000 (09:35 +0900)]
Merge branch 'fh1.m_AddBuildBindingsOption' of https://github.com/FestusHagen/taglib into FestusHagen-fh1.m_AddBuildBindingsOption

# Conflicts:
# CMakeLists.txt

9 years agoSilence a GCC warning in tests about ignoring a return value.
Tsuda Kageyu [Thu, 26 Nov 2015 17:45:33 +0000 (02:45 +0900)]
Silence a GCC warning in tests about ignoring a return value.

9 years agoSmall cleanups in CMakeLists.txt.
Tsuda Kageyu [Thu, 26 Nov 2015 17:27:24 +0000 (02:27 +0900)]
Small cleanups in CMakeLists.txt.

9 years agoMerge pull request #685 from g-coder/patch-2
Tsuda Kageyu [Thu, 26 Nov 2015 11:03:17 +0000 (20:03 +0900)]
Merge pull request #685 from g-coder/patch-2

Added ccache support for faster compilation

9 years agoUpdate CMakeLists.txt
g-coder [Thu, 26 Nov 2015 10:21:42 +0000 (15:51 +0530)]
Update CMakeLists.txt

9 years agoAdded ccache support for faster compilation
g-coder [Thu, 26 Nov 2015 09:42:23 +0000 (15:12 +0530)]
Added ccache support for faster compilation

ccache is a compiler cache. It speeds up recompilation by caching previous compilations and detecting when the same compilation is being done again. It provides support for C/C++ languages.
It makes compilation fast if it is available on the machine.
https://ccache.samba.org/

9 years agoSmall cosmetic fixes.
Tsuda Kageyu [Tue, 24 Nov 2015 15:12:18 +0000 (00:12 +0900)]
Small cosmetic fixes.

9 years agoFix instance references to a static member function.
Tsuda Kageyu [Tue, 24 Nov 2015 07:36:50 +0000 (16:36 +0900)]
Fix instance references to a static member function.

9 years agoSmall cosmetic fix.
Tsuda Kageyu [Tue, 24 Nov 2015 06:45:38 +0000 (15:45 +0900)]
Small cosmetic fix.

9 years agoMerge pull request #676 from TsudaKageyu/string-hide-private
Tsuda Kageyu [Mon, 23 Nov 2015 08:48:06 +0000 (17:48 +0900)]
Merge pull request #676 from TsudaKageyu/string-hide-private

Hide private things from a public header.

9 years agoHide some private functions from a public header.
Tsuda Kageyu [Sun, 22 Nov 2015 18:26:38 +0000 (03:26 +0900)]
Hide some private functions from a public header.

9 years agoHide a private static variable.
Tsuda Kageyu [Sun, 22 Nov 2015 16:32:12 +0000 (01:32 +0900)]
Hide a private static variable.

This is so-called Scott Mayers' singleton pattern.

9 years agoRemove duplicate tags when saving AIFF files.
Tsuda Kageyu [Sun, 22 Nov 2015 12:03:33 +0000 (21:03 +0900)]
Remove duplicate tags when saving AIFF files.

Just the same way as WAV already does.

9 years agoReduce redundant ref()/deref() operations.
Tsuda Kageyu [Sun, 22 Nov 2015 11:11:08 +0000 (20:11 +0900)]
Reduce redundant ref()/deref() operations.

9 years agoFix an instance reference to a static data member.
Tsuda Kageyu [Sun, 22 Nov 2015 10:43:17 +0000 (19:43 +0900)]
Fix an instance reference to a static data member.

9 years agoSilence some GCC warnings about no return statement.
Tsuda Kageyu [Sun, 22 Nov 2015 09:42:49 +0000 (18:42 +0900)]
Silence some GCC warnings about no return statement.

9 years agoAvoid using obsolete XiphComment::removeField().
Tsuda Kageyu [Sun, 22 Nov 2015 09:30:56 +0000 (18:30 +0900)]
Avoid using obsolete XiphComment::removeField().

9 years agoUpdate NEWS.
Tsuda Kageyu [Sun, 22 Nov 2015 07:23:53 +0000 (16:23 +0900)]
Update NEWS.

9 years agoMerge pull request #681 from TsudaKageyu/xiph-remove-fields
Tsuda Kageyu [Sun, 22 Nov 2015 07:19:15 +0000 (16:19 +0900)]
Merge pull request #681 from TsudaKageyu/xiph-remove-fields

Add alternative methods to XiphComment::removeField() that may cause …

9 years agoMerge branch 'genversion' of https://github.com/ufleisch/taglib into ufleisch-genversion
Tsuda Kageyu [Sun, 22 Nov 2015 01:38:35 +0000 (10:38 +0900)]
Merge branch 'genversion' of https://github.com/ufleisch/taglib into ufleisch-genversion

# Conflicts:
# CMakeLists.txt

9 years agoMake FileRef::FileTypeResolver work properly.
Tsuda Kageyu [Sat, 21 Nov 2015 09:29:41 +0000 (18:29 +0900)]
Make FileRef::FileTypeResolver work properly.

9 years agoStyle fixes in fileref.cpp.
Tsuda Kageyu [Sat, 21 Nov 2015 08:06:26 +0000 (17:06 +0900)]
Style fixes in fileref.cpp.

9 years agoFix a typo in a comment.
Tsuda Kageyu [Sat, 21 Nov 2015 01:32:32 +0000 (10:32 +0900)]
Fix a typo in a comment.

9 years agoUpdate NEWS.
Tsuda Kageyu [Sat, 21 Nov 2015 01:30:48 +0000 (10:30 +0900)]
Update NEWS.

9 years agoStyle fixes in fileref.cpp.
Tsuda Kageyu [Sat, 21 Nov 2015 01:29:37 +0000 (10:29 +0900)]
Style fixes in fileref.cpp.

9 years agoMerge pull request #528 from chouquette/master
Tsuda Kageyu [Sat, 21 Nov 2015 00:51:03 +0000 (09:51 +0900)]
Merge pull request #528 from chouquette/master

FileRef: Allow an IOStream to be used

9 years agoUnify common functions for finding tags.
Tsuda Kageyu [Sat, 21 Nov 2015 00:30:04 +0000 (09:30 +0900)]
Unify common functions for finding tags.

Several classes have exactly identical functions for finding tags.
This also hides the functions from public headers.

9 years agoAdd alternative methods to XiphComment::removeField().
Tsuda Kageyu [Wed, 18 Nov 2015 02:45:27 +0000 (11:45 +0900)]
Add alternative methods to XiphComment::removeField().

Using XiphComment::removeField() may lead to a linkage error, however we can't fix the method itself without breaking the ABI or changing its behavior.
So we added some alternative method and marked the old one deprecated.

9 years agoUpdate NEWS.
Tsuda Kageyu [Fri, 20 Nov 2015 14:08:43 +0000 (23:08 +0900)]
Update NEWS.

9 years agoMerge pull request #654 from TsudaKageyu/xiph-setcomment
Tsuda Kageyu [Fri, 20 Nov 2015 14:02:51 +0000 (23:02 +0900)]
Merge pull request #654 from TsudaKageyu/xiph-setcomment

Fix XiphComment::setComment() for the case that a Vorbis comment has …

9 years agoAvoid using String::null where an empty string is required.
Tsuda Kageyu [Fri, 20 Nov 2015 13:21:47 +0000 (22:21 +0900)]
Avoid using String::null where an empty string is required.

String::null is not necessarily be empty or remains the same instance.
Using it in a public header may lead to a linkage error.

9 years agoAvoid using String::isNull() where it is considered to be confused with isEmpty().
Tsuda Kageyu [Fri, 20 Nov 2015 11:59:13 +0000 (20:59 +0900)]
Avoid using String::isNull() where it is considered to be confused with isEmpty().

9 years agoRevert "Add a test about handing "COMMENT" and "DESCIPRION" fields in XiphComment."
Tsuda Kageyu [Fri, 20 Nov 2015 05:18:40 +0000 (14:18 +0900)]
Revert "Add a test about handing "COMMENT" and "DESCIPRION" fields in XiphComment."

This reverts commit 8f147034d6af7a4c2830b3113d4b257c1836fabe.

9 years agoRevert "Use always "COMMENT" field when updating XiphComment."
Tsuda Kageyu [Fri, 20 Nov 2015 05:18:23 +0000 (14:18 +0900)]
Revert "Use always "COMMENT" field when updating XiphComment."

This reverts commit ba5137bf2d3b1bcca9269e3a7f5f194243c87d23.

9 years agoMerge pull request #643 from TsudaKageyu/save-asf
Tsuda Kageyu [Fri, 20 Nov 2015 04:52:33 +0000 (13:52 +0900)]
Merge pull request #643 from TsudaKageyu/save-asf

Avoid writing duplicate tags when saving ASF files.

9 years agoRemove a warning from a comment and update NEWS.
Tsuda Kageyu [Fri, 20 Nov 2015 02:12:37 +0000 (11:12 +0900)]
Remove a warning from a comment and update NEWS.

9 years agoAvoid writing duplicate tags when saving ASF files.
Tsuda Kageyu [Tue, 4 Aug 2015 04:50:09 +0000 (13:50 +0900)]
Avoid writing duplicate tags when saving ASF files.
Reduce memory reallocations and copies when saving ASF files.

9 years agoUpdate NEWS.
Tsuda Kageyu [Fri, 20 Nov 2015 04:35:07 +0000 (13:35 +0900)]
Update NEWS.

9 years agoUpdate NEWS.
Tsuda Kageyu [Fri, 20 Nov 2015 04:25:28 +0000 (13:25 +0900)]
Update NEWS.

9 years agoMerge pull request #642 from TsudaKageyu/strip-and-properties
Tsuda Kageyu [Fri, 20 Nov 2015 04:24:01 +0000 (13:24 +0900)]
Merge pull request #642 from TsudaKageyu/strip-and-properties

Fix segfaults when calling File::properties() after strip().

9 years agoUpdate NEWS.
Tsuda Kageyu [Fri, 20 Nov 2015 01:50:21 +0000 (10:50 +0900)]
Update NEWS.

9 years agoMerge pull request #623 from TsudaKageyu/erase-duplicate-id3v2
Tsuda Kageyu [Fri, 20 Nov 2015 01:49:11 +0000 (10:49 +0900)]
Merge pull request #623 from TsudaKageyu/erase-duplicate-id3v2

Skip duplicate ID3v2 tags and treat them as an extra blank of the first one.

9 years agoConsistent rounding when calculating the MP4 audio length.
Tsuda Kageyu [Thu, 19 Nov 2015 09:24:20 +0000 (18:24 +0900)]
Consistent rounding when calculating the MP4 audio length.

9 years agoUpdate NEWS.
Tsuda Kageyu [Thu, 19 Nov 2015 08:55:18 +0000 (17:55 +0900)]
Update NEWS.

9 years agoEfficient lookup for an ID3v2 tag in a MPEG file.
Tsuda Kageyu [Thu, 19 Nov 2015 08:29:25 +0000 (17:29 +0900)]
Efficient lookup for an ID3v2 tag in a MPEG file.

An ID3v2 tag or MPEG frame is most likely be at the beginning of the file.

9 years agoEfficient lookup for the MP4/ASF field name and ID3v1 genre tables.
Tsuda Kageyu [Thu, 19 Nov 2015 07:35:55 +0000 (16:35 +0900)]
Efficient lookup for the MP4/ASF field name and ID3v1 genre tables.

Linear lookup is much faster and memory efficient when an array is very small.

9 years agoAdd some tests for String::toInt() with too large values.
Tsuda Kageyu [Thu, 19 Nov 2015 05:52:02 +0000 (14:52 +0900)]
Add some tests for String::toInt() with too large values.

9 years agoBackport shorter versions of some functions from taglib2.
Tsuda Kageyu [Thu, 19 Nov 2015 05:42:36 +0000 (14:42 +0900)]
Backport shorter versions of some functions from taglib2.