]> granicus.if.org Git - postgresql/log
postgresql
17 years agoApplied another patch by ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Michael Meskes [Sun, 30 Sep 2007 11:38:48 +0000 (11:38 +0000)]
Applied another patch by ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
to get memory allocation thread-safe. He also did some cleaning up.

17 years agoSupport functions for index opclasses should be immutable.
Tom Lane [Sun, 30 Sep 2007 00:03:47 +0000 (00:03 +0000)]
Support functions for index opclasses should be immutable.
Found by running opr_sanity on contrib modules.

17 years agoSupport functions for index opclasses should be immutable.
Tom Lane [Sat, 29 Sep 2007 23:48:22 +0000 (23:48 +0000)]
Support functions for index opclasses should be immutable.
Found by running opr_sanity on contrib modules.

17 years agoSupport functions for index opclasses should be immutable.
Tom Lane [Sat, 29 Sep 2007 23:43:18 +0000 (23:43 +0000)]
Support functions for index opclasses should be immutable.
Found by running opr_sanity on contrib modules.

17 years agoSupport functions for index opclasses should be immutable.
Tom Lane [Sat, 29 Sep 2007 23:38:17 +0000 (23:38 +0000)]
Support functions for index opclasses should be immutable.
Found by running opr_sanity on contrib modules.

17 years agoRemove bogus commutator marking --- the module doesn't actually supply
Tom Lane [Sat, 29 Sep 2007 23:32:42 +0000 (23:32 +0000)]
Remove bogus commutator marking --- the module doesn't actually supply
any commutator operator for =(chkpass,text), so this was creating a
shell operator that would fail on use.  Found by opr_sanity testing.

17 years agoSupport functions for index opclasses should be immutable.
Tom Lane [Sat, 29 Sep 2007 23:24:39 +0000 (23:24 +0000)]
Support functions for index opclasses should be immutable.
Found by running opr_sanity on contrib modules.

17 years agoMake recovery show the current input WAL segment name in the startup
Tom Lane [Sat, 29 Sep 2007 18:32:56 +0000 (18:32 +0000)]
Make recovery show the current input WAL segment name in the startup
process' PS display.  After a suggestion by Simon (not exactly his
patch though).

17 years agoDisallow CLUSTER using an invalid index (that is, one left over from a failed
Tom Lane [Sat, 29 Sep 2007 18:05:20 +0000 (18:05 +0000)]
Disallow CLUSTER using an invalid index (that is, one left over from a failed
CREATE INDEX CONCURRENTLY).  Such an index might not have entries for every
heap row and thus clustering with it would result in silent data loss.
The scenario requires a pretty foolish DBA, but still ...

17 years agoImprove consistency of the error messages generated when you try to use
Tom Lane [Sat, 29 Sep 2007 17:18:58 +0000 (17:18 +0000)]
Improve consistency of the error messages generated when you try to use
ALTER TABLE on a composite type or ALTER TYPE on a table's rowtype.
We already rejected these cases, but the error messages were a bit
random and didn't always provide a HINT to use the other command type.

17 years agoIn the release checklist, mention packagers will see the minor upgrade
Bruce Momjian [Sat, 29 Sep 2007 12:19:16 +0000 (12:19 +0000)]
In the release checklist, mention packagers will see the minor upgrade
numbering for additional functions.

17 years agoAdd chklocale.c to pgport files for msvc builds, per
Magnus Hagander [Sat, 29 Sep 2007 07:15:33 +0000 (07:15 +0000)]
Add chklocale.c to pgport files for msvc builds, per
buildfarm failures.

17 years agoDefend against openssl libraries that fail on keys longer than 128 bits;
Tom Lane [Sat, 29 Sep 2007 02:18:15 +0000 (02:18 +0000)]
Defend against openssl libraries that fail on keys longer than 128 bits;
which is the case at least on some Solaris versions.  Marko Kreen

17 years agoMake archive recovery always start a new timeline, rather than only when a
Tom Lane [Sat, 29 Sep 2007 01:36:10 +0000 (01:36 +0000)]
Make archive recovery always start a new timeline, rather than only when a
recovery stop time was used.  This avoids a corner-case risk of trying to
overwrite an existing archived copy of the last WAL segment, and seems
simpler and cleaner all around than the original definition.  Per example
from Jon Colverson and subsequent analysis by Simon.

17 years agoMake use of additional chklocale.c entries to reject locales that we
Tom Lane [Sat, 29 Sep 2007 00:14:40 +0000 (00:14 +0000)]
Make use of additional chklocale.c entries to reject locales that we
cannot support.

17 years agoTeach chklocale.c about a few names for frontend-only encodings,
Tom Lane [Sat, 29 Sep 2007 00:01:43 +0000 (00:01 +0000)]
Teach chklocale.c about a few names for frontend-only encodings,
since this will allow initdb to reject attempts to initdb in a locale
that uses such an encoding.  We'll probably find out more such names
during beta ...

17 years agoOn OS X, assume that an empty-string result for nl_langinfo(CODESET)
Tom Lane [Fri, 28 Sep 2007 23:36:06 +0000 (23:36 +0000)]
On OS X, assume that an empty-string result for nl_langinfo(CODESET)
means UTF-8.  Per examination of /usr/share/locale in 10.4.10.

17 years agoUpdate TCL comment:
Bruce Momjian [Fri, 28 Sep 2007 22:33:20 +0000 (22:33 +0000)]
Update TCL comment:

 * We can only fix this with Tcl >= 8.4, when Tcl_SetNotifier()

17 years agoChange initdb and CREATE DATABASE to actively reject attempts to create
Tom Lane [Fri, 28 Sep 2007 22:25:49 +0000 (22:25 +0000)]
Change initdb and CREATE DATABASE to actively reject attempts to create
databases with encodings that are incompatible with the server's LC_CTYPE
locale, when we can determine that (which we can on most modern platforms,
I believe).  C/POSIX locale is compatible with all encodings, of course,
so there is still some usefulness to CREATE DATABASE's ENCODING option,
but this will insulate us against all sorts of recurring complaints
caused by mismatched settings.

I moved initdb's existing LC_CTYPE-to-encoding mapping knowledge into
a new src/port/ file so it could be shared by CREATE DATABASE.

17 years agoRemove:
Bruce Momjian [Fri, 28 Sep 2007 21:32:29 +0000 (21:32 +0000)]
Remove:

< * SQL*Net listener that makes PostgreSQL appear as an Oracle database
<   to clients

17 years agoTweak initdb's text search configuration selection code so it can
Tom Lane [Fri, 28 Sep 2007 15:25:44 +0000 (15:25 +0000)]
Tweak initdb's text search configuration selection code so it can
cope with LANG settings like 'es_ES@euro'.

17 years agoexclude contrib/tsearch2 from regression tests.
Andrew Dunstan [Fri, 28 Sep 2007 00:14:58 +0000 (00:14 +0000)]
exclude contrib/tsearch2 from regression tests.

17 years agoTurn build and vcregress .bat files into pure one line wrappers for
Andrew Dunstan [Thu, 27 Sep 2007 21:13:11 +0000 (21:13 +0000)]
Turn build and vcregress .bat files into pure one line wrappers for
the perl scripts. Remove the now superfluous getregress.pl.

17 years agoFix typos in two comments. Spotted by Brendan Jurd
Tom Lane [Thu, 27 Sep 2007 21:01:59 +0000 (21:01 +0000)]
Fix typos in two comments.  Spotted by Brendan Jurd

17 years agoTweak pgbench.c to remove the hidden assumption that a WIN32 machine
Tom Lane [Thu, 27 Sep 2007 20:39:43 +0000 (20:39 +0000)]
Tweak pgbench.c to remove the hidden assumption that a WIN32 machine
couldn't possibly HAVE_GETOPT.  I believe this is the most appropriate
form of the patch submitted 2007-08-07 by Hiroshi Saito, though not
having a Windows build environment I won't know for sure till I see
the buildfarm results.

17 years agoDefine the FRONTEND symbol in postgres_fe.h, which allows us to eliminate
Tom Lane [Thu, 27 Sep 2007 19:53:44 +0000 (19:53 +0000)]
Define the FRONTEND symbol in postgres_fe.h, which allows us to eliminate
duplicative -DFRONTEND flags from many Makefiles.  We still need Makefile
control of the symbol in a few places that compile frontend-or-backend
src/port/ files, but it's a lot cleaner than before.

Hiroshi Saito

17 years agoAdd virtual transaction IDs to CSVLOG output, so that messages coming from
Tom Lane [Thu, 27 Sep 2007 18:15:36 +0000 (18:15 +0000)]
Add virtual transaction IDs to CSVLOG output, so that messages coming from
the same transaction can be identified even when no regular XID was assigned.
This seems essential after addition of the lazy-XID patch.  Also some
minor code cleanup in write_csvlog().

17 years agoFix Assert failure in ExpandColumnRefStar --- what I thought was a can't
Tom Lane [Thu, 27 Sep 2007 17:42:03 +0000 (17:42 +0000)]
Fix Assert failure in ExpandColumnRefStar --- what I thought was a can't
happen condition can happen given incorrect input.  The real problem is that
gram.y should try harder to distinguish * from "*" --- the latter is a legal
column name per spec, and someday we ought to treat it that way.  However
fixing that is too invasive for a back-patch, and it's too late for the 8.3
cycle too.  So just reduce the Assert to a plain elog for now.  Per report
from NikhilS.

17 years agoLowercase all mentions of "PostgreSQL" in URLs, per Magnus.
Bruce Momjian [Thu, 27 Sep 2007 06:14:47 +0000 (06:14 +0000)]
Lowercase all mentions of "PostgreSQL" in URLs, per Magnus.

17 years agoSome small tuptoaster improvements from Greg Stark. Avoid unnecessary
Tom Lane [Wed, 26 Sep 2007 23:29:10 +0000 (23:29 +0000)]
Some small tuptoaster improvements from Greg Stark.  Avoid unnecessary
decompression of an already-compressed external value when we have to copy
it; save a few cycles when a value is too short for compression; and
annotate various lines that are currently unreachable.

17 years agoMinor improvements in backup and recovery:
Tom Lane [Wed, 26 Sep 2007 22:36:30 +0000 (22:36 +0000)]
Minor improvements in backup and recovery:

- create a separate archive_mode GUC, on which archive_command is dependent

- %r option in recovery.conf sends last restartpoint to recovery command

- %r used in pg_standby, updated README

- minor other code cleanup in pg_standby

- doc on Warm Standby now mentions pg_standby and %r

- log_restartpoints recovery option emits LOG message at each restartpoint

- end of recovery now displays last transaction end time, as requested
  by Warren Little; also shown at each restartpoint

- restart archiver if needed to carry away WAL files at shutdown

Simon Riggs

17 years agoRename "PostgreSQL" to "Postgres" in 3 places.
Bruce Momjian [Wed, 26 Sep 2007 20:38:28 +0000 (20:38 +0000)]
Rename "PostgreSQL" to "Postgres" in 3 places.

17 years agoRename "PostgreSQL" to "Postgres" in 7 places in the FAQ.
Bruce Momjian [Wed, 26 Sep 2007 20:36:50 +0000 (20:36 +0000)]
Rename "PostgreSQL" to "Postgres" in 7 places in the FAQ.

17 years agoAdjust the new memory limit in the lazy vacuum code to use MaxHeapTuplesPerPage
Alvaro Herrera [Wed, 26 Sep 2007 20:16:28 +0000 (20:16 +0000)]
Adjust the new memory limit in the lazy vacuum code to use MaxHeapTuplesPerPage
tuples per page instead of fixed 200, to better cope with systems that use a
different block size.

17 years agoCreate a function variable "join_search_hook" to let plugins override the
Tom Lane [Wed, 26 Sep 2007 18:51:51 +0000 (18:51 +0000)]
Create a function variable "join_search_hook" to let plugins override the
join search order portion of the planner; this is specifically intended to
simplify developing a replacement for GEQO planning.  Patch by Julius
Stroffek, editorialized on by me.  I renamed make_one_rel_by_joins to
standard_join_search and make_rels_by_joins to join_search_one_level to better
reflect their place within this scheme.

17 years agoProperly pass -c parameter to ecpg when building regression tests.
Magnus Hagander [Wed, 26 Sep 2007 11:19:09 +0000 (11:19 +0000)]
Properly pass -c parameter to ecpg when building regression tests.
Per Michael.

17 years agoApplied patch by ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp> to get prepare...
Michael Meskes [Wed, 26 Sep 2007 10:57:01 +0000 (10:57 +0000)]
Applied patch by ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp> to get prepare thread-safe.

17 years agoFix crash of to_tsvector() function on huge input: compareWORD()
Teodor Sigaev [Wed, 26 Sep 2007 10:09:57 +0000 (10:09 +0000)]
Fix crash of to_tsvector() function on huge input: compareWORD()
function didn't return correct result for word position greate than
limit.

Per report from Stuart Bishop <stuart@stuartbishop.net>

17 years agoAdd:
Bruce Momjian [Wed, 26 Sep 2007 08:47:43 +0000 (08:47 +0000)]
Add:

> * Implement Boyer-Moore searching in strpos()
>
>   http://archives.postgresql.org/pgsql-patches/2007-08/msg00012.php

17 years agoDocument that libpq's PQntuples() might overflow.
Bruce Momjian [Wed, 26 Sep 2007 08:45:50 +0000 (08:45 +0000)]
Document that libpq's PQntuples() might overflow.

17 years agoIn the integer-datetimes case, date2timestamp and date2timestamptz need
Tom Lane [Wed, 26 Sep 2007 01:10:42 +0000 (01:10 +0000)]
In the integer-datetimes case, date2timestamp and date2timestamptz need
to check for overflow because the legal range of type date is actually
wider than timestamp's.  Problem found by Neil Conway.

17 years agoUse SYSV semaphores rather than POSIX on Darwin >= 6.0 (i.e., OS X 10.2
Tom Lane [Wed, 26 Sep 2007 00:32:46 +0000 (00:32 +0000)]
Use SYSV semaphores rather than POSIX on Darwin >= 6.0 (i.e., OS X 10.2
and up), per Chris Marcellino.  This avoids consuming O(N^2) file
descriptors to support N backends.  Tests suggest it's about a wash for
small installations, but large ones would have a problem.

17 years agoChange on-disk representation of NUMERIC datatype so that the sign_dscale
Tom Lane [Tue, 25 Sep 2007 22:21:55 +0000 (22:21 +0000)]
Change on-disk representation of NUMERIC datatype so that the sign_dscale
word comes before the weight instead of after.  This will allow future
binary-compatible extension of the representation to support compact formats,
as discussed on pgsql-hackers around 2007/06/18.  The reason to do it now is
that we've already pretty well broken any chance of simple in-place upgrade
from 8.2 to 8.3, but it's possible that 8.3 to 8.4 (or whenever we get around
to squeezing NUMERIC) could otherwise be data-compatible.

17 years agoDept. of second thoughts: fix loop in BgBufferSync so that the exit when
Tom Lane [Tue, 25 Sep 2007 22:11:48 +0000 (22:11 +0000)]
Dept. of second thoughts: fix loop in BgBufferSync so that the exit when
bgwriter_lru_maxpages is exceeded leaves the loop variables in the
expected state.  In the original coding, we'd fail to advance
next_to_clean, causing that buffer to be probably-uselessly rechecked next
time, and also have an off-by-one idea of the number of buffers scanned.

17 years agoJust-in-time background writing strategy. This code avoids re-scanning
Tom Lane [Tue, 25 Sep 2007 20:03:38 +0000 (20:03 +0000)]
Just-in-time background writing strategy.  This code avoids re-scanning
buffers that cannot possibly need to be cleaned, and estimates how many
buffers it should try to clean based on moving averages of recent allocation
requests and density of reusable buffers.  The patch also adds a couple
more columns to pg_stat_bgwriter to help measure the effectiveness of the
bgwriter.

Greg Smith, building on his own work and ideas from several other people,
in particular a much older patch from Itagaki Takahiro.

17 years agoSmall string tweaks
Peter Eisentraut [Tue, 25 Sep 2007 16:29:34 +0000 (16:29 +0000)]
Small string tweaks

17 years agoUse proper search for contrib makefiles in vcregress.pl
Andrew Dunstan [Mon, 24 Sep 2007 21:42:34 +0000 (21:42 +0000)]
Use proper search for contrib makefiles in vcregress.pl

17 years agofix typo in vcregress.pl
Andrew Dunstan [Mon, 24 Sep 2007 21:14:54 +0000 (21:14 +0000)]
fix typo in vcregress.pl

17 years agoAdd comments re text <-> bytea internal equivalence in convert routines.
Andrew Dunstan [Mon, 24 Sep 2007 16:38:24 +0000 (16:38 +0000)]
Add comments re text <-> bytea internal equivalence in convert routines.

17 years agoUse correct PG_GETARG macro in pg_convert
Andrew Dunstan [Mon, 24 Sep 2007 14:59:37 +0000 (14:59 +0000)]
Use correct PG_GETARG macro in pg_convert

17 years agoAvoid having autovacuum read pgstats data too many times in quick succession.
Alvaro Herrera [Mon, 24 Sep 2007 04:12:01 +0000 (04:12 +0000)]
Avoid having autovacuum read pgstats data too many times in quick succession.
This is problematic for the autovac launcher when there are many databases,
so we keep data for a full second before reading it again.

17 years agoReduce the size of memory allocations by lazy vacuum when processing a small
Alvaro Herrera [Mon, 24 Sep 2007 03:52:55 +0000 (03:52 +0000)]
Reduce the size of memory allocations by lazy vacuum when processing a small
table, by allocating just enough for a hardcoded number of dead tuples per
page.  The current estimate is 200 dead tuples per page.

Per reports from Jeff Amiel, Erik Jones and Marko Kreen, and subsequent
discussion.
CVS: ----------------------------------------------------------------------
CVS: Enter Log.  Lines beginning with `CVS:' are removed automatically
CVS:
CVS: Committing in .
CVS:
CVS: Modified Files:
CVS:  commands/vacuumlazy.c
CVS: ----------------------------------------------------------------------

17 years agoSimplify and rename some GUC variables, per various recent discussions:
Tom Lane [Mon, 24 Sep 2007 03:12:23 +0000 (03:12 +0000)]
Simplify and rename some GUC variables, per various recent discussions:

* stats_start_collector goes away; we always start the collector process,
unless prevented by a problem with setting up the stats UDP socket.

* stats_reset_on_server_start goes away; it seems useless in view of the
availability of pg_stat_reset().

* stats_block_level and stats_row_level are merged into a single variable
"track_counts", which controls all reports sent to the collector process.

* stats_command_string is renamed to track_activities.

* log_autovacuum is renamed to log_autovacuum_min_duration to better reflect
its meaning.

The log_autovacuum change is not a compatibility issue since it didn't exist
before 8.3 anyway.  The other changes need to be release-noted.

17 years agoRemove "convert 'blah' using conversion_name" facility, because if it
Andrew Dunstan [Mon, 24 Sep 2007 01:29:30 +0000 (01:29 +0000)]
Remove "convert 'blah' using conversion_name" facility, because if it
produces text it is an encoding hole and if not it's incompatible
with the spec, whatever the spec means (which we're not sure about anyway).

17 years agoReplace linear searches with binary searches in pg_dump's code to
Tom Lane [Sun, 23 Sep 2007 23:39:36 +0000 (23:39 +0000)]
Replace linear searches with binary searches in pg_dump's code to
lookup objects by OID.  Per gripe from nikitathespider.

17 years agoAdd perl replacements for build.bat and vcregress.bat. In due course
Andrew Dunstan [Sun, 23 Sep 2007 21:52:56 +0000 (21:52 +0000)]
Add perl replacements for build.bat and vcregress.bat. In due course
the .bat files will be altered to become tiny wrappers for these scripts,
and one or two other .bat files will disappear.

17 years agoFix bugs in XML binary I/O functions. Heikki and Tom
Tom Lane [Sun, 23 Sep 2007 21:36:42 +0000 (21:36 +0000)]
Fix bugs in XML binary I/O functions.  Heikki and Tom

17 years agoRestrict overly broad searches, and fix typo, in recent fix. Per Hannes Eder.
Andrew Dunstan [Sun, 23 Sep 2007 20:32:40 +0000 (20:32 +0000)]
Restrict overly broad searches, and fix typo, in recent fix. Per Hannes Eder.

17 years agoMake autovacuum report the start time of its current activity in
Tom Lane [Sun, 23 Sep 2007 20:07:33 +0000 (20:07 +0000)]
Make autovacuum report the start time of its current activity in
pg_stat_activity.  Per gripe from Jim Nasby.

17 years agoTransactionIdIsInProgress can skip scanning the ProcArray if the target XID is
Tom Lane [Sun, 23 Sep 2007 18:50:38 +0000 (18:50 +0000)]
TransactionIdIsInProgress can skip scanning the ProcArray if the target XID is
later than latestCompletedXid, per Florian Pflug.  Also some minor
improvements in the XIDCACHE_DEBUG code --- make sure each call of
TransactionIdIsInProgress is counted one way or another.

17 years agoTypo fix from Brendan Jurd.
Bruce Momjian [Sun, 23 Sep 2007 18:06:47 +0000 (18:06 +0000)]
Typo fix from Brendan Jurd.

17 years agoTemporarily modify tsearch regression tests to suppress notice that comes
Tom Lane [Sun, 23 Sep 2007 15:58:58 +0000 (15:58 +0000)]
Temporarily modify tsearch regression tests to suppress notice that comes
out at erratic times, because it is creating a totally unacceptable level
of noise in our buildfarm results.  This patch can be reverted when and if
the code is fixed to not issue notices during cache reload events.

17 years agoFix cost estimates for EXISTS subqueries that are evaluated as initPlans
Tom Lane [Sat, 22 Sep 2007 21:36:40 +0000 (21:36 +0000)]
Fix cost estimates for EXISTS subqueries that are evaluated as initPlans
(because they are uncorrelated with the immediate parent query).  We were
charging the full run cost to the parent node, disregarding the fact that
only one row need be fetched for EXISTS.  While this would only be a
cosmetic issue in most cases, it might possibly affect planning outcomes
if the parent query were itself a subquery to some upper query.
Per recent discussion with Steve Crawford.

17 years agoReplace calls to external dir program with perlish globs and File::Find
Andrew Dunstan [Sat, 22 Sep 2007 20:38:10 +0000 (20:38 +0000)]
Replace calls to external dir program with perlish globs and File::Find
calls. Fixes complaint fron Hannes Eder, whose environment found a different
dir program.

17 years agoDocument the translations from Postgres message severity levels to
Tom Lane [Sat, 22 Sep 2007 19:10:44 +0000 (19:10 +0000)]
Document the translations from Postgres message severity levels to
syslog and eventlog severity levels, per suggestion from Josh Drake.
Also, some wordsmithing for the csvlog documentation.

17 years agoFix erroneous Assert() in syslogger process start in EXEC_BACKEND case,
Tom Lane [Sat, 22 Sep 2007 18:19:18 +0000 (18:19 +0000)]
Fix erroneous Assert() in syslogger process start in EXEC_BACKEND case,
per ITAGAKI Takahiro.  Also, rewrite syslogger_forkexec() in hopes of
eliminating the confusion in the first place.

17 years agoFix bogus calculation of potential output string length in translate().
Tom Lane [Sat, 22 Sep 2007 05:35:42 +0000 (05:35 +0000)]
Fix bogus calculation of potential output string length in translate().

17 years agoParenthesize macro arguments safely. I see no bug among the current
Tom Lane [Sat, 22 Sep 2007 04:41:19 +0000 (04:41 +0000)]
Parenthesize macro arguments safely.  I see no bug among the current
uses of PG_DETOAST_DATUM_SLICE, but it's clearly trouble waiting to
happen.

17 years agoAlthough I'd misdiagnosed the reason for the recent failures on
Tom Lane [Sat, 22 Sep 2007 04:40:03 +0000 (04:40 +0000)]
Although I'd misdiagnosed the reason for the recent failures on
buildfarm member grebe, I see no reason to revert the 1-byte-header-friendly
changes I made in varlena.c.  Instead, tweak the code a little bit to
get more advantage out of that.

17 years agoDoh --- what's really happening on buildfarm member grebe is that its
Tom Lane [Sat, 22 Sep 2007 04:37:53 +0000 (04:37 +0000)]
Doh --- what's really happening on buildfarm member grebe is that its
malloc returns NULL for malloc(0).  Defend against that case.

17 years agoGo back to using a separate method for doing ILIKE for single byte
Andrew Dunstan [Sat, 22 Sep 2007 03:58:34 +0000 (03:58 +0000)]
Go back to using a separate method for doing ILIKE for single byte
character encodings that doesn't involve calling lower(). This should
cure the performance regression in this case complained of by Guillaume
Smet. It still leaves the horrid performance for multi-byte encodings
introduced in 8.2, but there's no obvious solution for that in sight.

17 years agoFix varlena.c routines to allow 1-byte-header text values. This is now
Tom Lane [Sat, 22 Sep 2007 00:36:38 +0000 (00:36 +0000)]
Fix varlena.c routines to allow 1-byte-header text values.  This is now
demonstrably necessary for text_substring() since regexp_split functions
may pass it such a value; and we might as well convert the whole file
at once.  Per buildfarm results (though I wonder why most machines aren't
showing a failure).

17 years agoFix regex, LIKE, and some other second-rank text-manipulation functions
Tom Lane [Fri, 21 Sep 2007 22:52:52 +0000 (22:52 +0000)]
Fix regex, LIKE, and some other second-rank text-manipulation functions
to not cause needless copying of text datums that have 1-byte headers.
Greg Stark, in response to performance gripe from Guillaume Smet and
ITAGAKI Takahiro.

17 years agoImprove handling of prune/no-prune decisions by storing a page's oldest
Tom Lane [Fri, 21 Sep 2007 21:25:42 +0000 (21:25 +0000)]
Improve handling of prune/no-prune decisions by storing a page's oldest
unpruned XMAX in its header.  At the cost of 4 bytes per page, this keeps us
from performing heap_page_prune when there's no chance of pruning anything.
Seems to be necessary per Heikki's preliminary performance testing.

17 years agoChange tqual.c tests to use !TransactionIdIsCurrentTransactionId, rather than
Tom Lane [Fri, 21 Sep 2007 18:24:28 +0000 (18:24 +0000)]
Change tqual.c tests to use !TransactionIdIsCurrentTransactionId, rather than
TransactionIdDidAbort, when handling the case that xmin is one of the current
transaction's XIDs and the tuple has been deleted.  xmax must also be one of
the current transaction's XIDs, since no one else can see it yet, and it's
cheaper to look at local state than shared state to find out if xmax aborted.
Per an idea of Heikki's.

17 years agoMake some simple performance improvements in TransactionIdIsInProgress().
Tom Lane [Fri, 21 Sep 2007 17:36:53 +0000 (17:36 +0000)]
Make some simple performance improvements in TransactionIdIsInProgress().
For XIDs of our own transaction and subtransactions, it's cheaper to ask
TransactionIdIsCurrentTransactionId() than to look in shared memory.
Also, the xids[] work array is always the same size within any given
process, so malloc it just once instead of doing a palloc/pfree on every
call; aside from being faster this lets us get rid of some goto's, since
we no longer have any end-of-function pfree to do.  Both ideas by Heikki.

17 years agoFix comments that misspelled TransactionIdIsInProgress, per Heikki.
Tom Lane [Fri, 21 Sep 2007 16:32:19 +0000 (16:32 +0000)]
Fix comments that misspelled TransactionIdIsInProgress, per Heikki.

17 years agoRemoved superfluous ECPGfree() call.
Michael Meskes [Fri, 21 Sep 2007 10:59:27 +0000 (10:59 +0000)]
Removed superfluous ECPGfree() call.

17 years agoIf we're gonna provide an --enable-profiling configure option, surely
Tom Lane [Fri, 21 Sep 2007 02:33:46 +0000 (02:33 +0000)]
If we're gonna provide an --enable-profiling configure option, surely
it ought to know that you need -DLINUX_PROFILE on Linux.

17 years agoInsert a hack in pl/tcl to disable Tcl's built-in Notifier subsystem, which
Tom Lane [Fri, 21 Sep 2007 00:30:49 +0000 (00:30 +0000)]
Insert a hack in pl/tcl to disable Tcl's built-in Notifier subsystem, which
has a bad habit of launching multiple threads within the backend and thereby
causing all kinds of havoc.  Fortunately, we don't need it, and recent Tcl
versions provide an easy way to disable it.  Diagnosis and fix by
Steve Marshall, Paul Bayer, and Doug Knight of WSI Corporation.

17 years agoSolaris portability fix that was previously made in contrib/tsearch2
Tom Lane [Thu, 20 Sep 2007 23:27:11 +0000 (23:27 +0000)]
Solaris portability fix that was previously made in contrib/tsearch2
but got lost from the version committed to main tree.  Per Greg Stark.

17 years agoRevert ill-fated patch to release exclusive lock early after vacuum
Tom Lane [Thu, 20 Sep 2007 21:43:27 +0000 (21:43 +0000)]
Revert ill-fated patch to release exclusive lock early after vacuum
truncates a table.  Introduces race condition, as shown by buildfarm
failures.

17 years agoDone:
Bruce Momjian [Thu, 20 Sep 2007 18:54:19 +0000 (18:54 +0000)]
Done:

> * -Consider shrinking expired tuples to just their headers
> * -Allow heap reuse of UPDATEd rows if no indexed columns are changed,
>   and old and new versions are on the same heap page

Not needed anymore:

< * Reuse index tuples that point to heap tuples that are not visible to
<   anyone?

17 years agoCleanup items from csvlog changes, per ITAGAKI Takahiro.
Andrew Dunstan [Thu, 20 Sep 2007 18:19:08 +0000 (18:19 +0000)]
Cleanup items from csvlog changes, per ITAGAKI Takahiro.

17 years agoFix msvc warnings, patch by Hannes Eder <Hannes@HannesEder.net>
Teodor Sigaev [Thu, 20 Sep 2007 18:10:57 +0000 (18:10 +0000)]
Fix msvc warnings, patch by Hannes Eder <Hannes@HannesEder.net>

17 years agoHOT updates. When we update a tuple without changing any of its indexed
Tom Lane [Thu, 20 Sep 2007 17:56:33 +0000 (17:56 +0000)]
HOT updates.  When we update a tuple without changing any of its indexed
columns, and the new version can be stored on the same heap page, we no longer
generate extra index entries for the new version.  Instead, index searches
follow the HOT-chain links to ensure they find the correct tuple version.

In addition, this patch introduces the ability to "prune" dead tuples on a
per-page basis, without having to do a complete VACUUM pass to recover space.
VACUUM is still needed to clean up dead index entries, however.

Pavan Deolasee, with help from a bunch of other people.

17 years agoPrevent corr() from returning the wrong results for negative correlation
Neil Conway [Wed, 19 Sep 2007 22:31:48 +0000 (22:31 +0000)]
Prevent corr() from returning the wrong results for negative correlation
values. The previous coding essentially assumed that x = sqrt(x*x), which
does not hold for x < 0.

Thanks to Jie Zhang at Greenplum and Gavin Sherry for reporting this
issue.

17 years agoRemove tabs from SGML file.
Bruce Momjian [Wed, 19 Sep 2007 03:13:57 +0000 (03:13 +0000)]
Remove tabs from SGML file.

17 years agoClose previously open holes for invalidly encoded data to enter the
Andrew Dunstan [Tue, 18 Sep 2007 17:41:17 +0000 (17:41 +0000)]
Close previously open holes for invalidly encoded data to enter the
database via builtin functions, as recently discussed on -hackers.

chr() now returns a character in the database encoding. For UTF8 encoded databases
the argument is treated as a Unicode code point. For other multi-byte encodings
the argument must designate a strict ascii character, or an error is raised,
as is also the case if the argument is 0.

ascii() is adjusted so that it remains the inverse of chr().

The two argument form of convert() is gone, and the three argument form now
takes a bytea first argument and returns a bytea. To cover this loss three new
functions are introduced:
. convert_from(bytea, name) returns text - converts the first argument from the
  named encoding to the database encoding
. convert_to(text, name) returns bytea - converts the first argument from the
  database encoding to the named encoding
. length(bytea, name) returns int - gives the length of the first argument in
  characters in the named encoding

17 years agoAvoid possibly-unportable initializer, per buildfarm warning
Teodor Sigaev [Tue, 18 Sep 2007 15:03:23 +0000 (15:03 +0000)]
Avoid possibly-unportable initializer, per buildfarm warning

per notice by Gregory Stark <stark@enterprisedb.com>

17 years agoDoc reminder that integer pg version also needs updating.
Bruce Momjian [Tue, 18 Sep 2007 01:52:39 +0000 (01:52 +0000)]
Doc reminder that integer pg version also needs updating.

17 years agoRemove extra tab in postgresql.conf
Bruce Momjian [Mon, 17 Sep 2007 21:40:40 +0000 (21:40 +0000)]
Remove extra tab in postgresql.conf

17 years agoRemove Assert(BgWriterShmem != NULL), which is rather pointless since
Tom Lane [Sun, 16 Sep 2007 16:33:04 +0000 (16:33 +0000)]
Remove Assert(BgWriterShmem != NULL), which is rather pointless since
we'd dump core anyway immediately afterward if it were null; and it
seems to confuse some versions of icc into generating bad code.
Per report from Sergey Koposov.  Patched in HEAD only, for the moment,
since this is only likely to affect developers.

17 years agoFix overflow in extract(epoch from interval) for intervals exceeding 68 years.
Tom Lane [Sun, 16 Sep 2007 15:56:20 +0000 (15:56 +0000)]
Fix overflow in extract(epoch from interval) for intervals exceeding 68 years.
Seems to have been introduced in 8.1 by careless SECS_PER_DAY
search-and-replace.

17 years agoUpdate release notes for last-minute fix.
Tom Lane [Sun, 16 Sep 2007 03:03:00 +0000 (03:03 +0000)]
Update release notes for last-minute fix.

17 years agoFix aboriginal mistake in lazy VACUUM's code for truncating away
Tom Lane [Sun, 16 Sep 2007 02:37:46 +0000 (02:37 +0000)]
Fix aboriginal mistake in lazy VACUUM's code for truncating away
no-longer-needed pages at the end of a table.  We thought we could throw away
pages containing HEAPTUPLE_DEAD tuples; but this is not so, because such
tuples very likely have index entries pointing at them, and we wouldn't have
removed the index entries.  The problem only emerges in a somewhat unlikely
race condition: the dead tuples have to have been inserted by a transaction
that later aborted, and this has to have happened between VACUUM's initial
scan of the page and then rechecking it for empty in count_nondeletable_pages.
But that timespan will include an index-cleaning pass, so it's not all that
hard to hit.  This seems to explain a couple of previously unsolved bug
reports.

17 years agoUpdate Japanese FAQ.
Bruce Momjian [Sat, 15 Sep 2007 00:58:19 +0000 (00:58 +0000)]
Update Japanese FAQ.

Jun Kuwamura

17 years agoAdd:
Bruce Momjian [Fri, 14 Sep 2007 19:02:46 +0000 (19:02 +0000)]
Add:

>
>  o Prevent long-lived temporary tables from causing frozen-xid
>    advancement starvation
>
>    http://archives.postgresql.org/pgsql-general/2007-06/msg01645.php

17 years agoAdd:
Bruce Momjian [Fri, 14 Sep 2007 18:50:48 +0000 (18:50 +0000)]
Add:

>
> * Make it possible to use RETURNING together with conditional DO INSTEAD
>   rules, such as for partitioning setups
>
>   http://archives.postgresql.org/pgsql-hackers/2007-09/msg00577.php

17 years agoFix markup.
Bruce Momjian [Fri, 14 Sep 2007 18:39:58 +0000 (18:39 +0000)]
Fix markup.