]> granicus.if.org Git - taglib/log
taglib
18 years agoSVN_SILENT another minor-typo
Scott Wheeler [Thu, 31 Aug 2006 22:49:38 +0000 (22:49 +0000)]
SVN_SILENT another minor-typo

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@579372 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoSVN_SILENT extra space
Scott Wheeler [Thu, 31 Aug 2006 22:46:41 +0000 (22:46 +0000)]
SVN_SILENT extra space

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@579371 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoPatches from Aaron VonderHaar for a GEOB frame implementation.
Scott Wheeler [Thu, 31 Aug 2006 22:44:17 +0000 (22:44 +0000)]
Patches from Aaron VonderHaar for a GEOB frame implementation.

Nice patches Aaron!

CCMAIL:taglib-devel@kde.org
CCMAIL:gruen0aermel@gmail.com

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@579369 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoStarting in a bit on my TODO list from taglib-devel.
Scott Wheeler [Thu, 31 Aug 2006 21:25:00 +0000 (21:25 +0000)]
Starting in a bit on my TODO list from taglib-devel.

This is an invalid conversion.  It may be worthwhile to do the conversions at a
higher level at some point (in the tag, rather than frame generation), but for
now just remove this one.

CCMAIL:taglib-devel@kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@579343 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoHmm. Actually assign the flag here. Thanks to Dirk for catching this.
Scott Wheeler [Thu, 31 Aug 2006 00:51:22 +0000 (00:51 +0000)]
Hmm.  Actually assign the flag here.  Thanks to Dirk for catching this.

BUG:130754

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@579077 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoMake sure that these flags are set to the values that are actually used.
Scott Wheeler [Tue, 29 Aug 2006 23:19:21 +0000 (23:19 +0000)]
Make sure that these flags are set to the values that are actually used.

BUG:132191

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@578697 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoUpdate the TCON (genre) frame as we create it so that we don't keep ID3v2.3
Scott Wheeler [Tue, 29 Aug 2006 23:06:14 +0000 (23:06 +0000)]
Update the TCON (genre) frame as we create it so that we don't keep ID3v2.3
formatted data sitting around waiting to be written to 2.4 tags.

BUG:132018

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@578687 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoAdd a warning note to File::save()
Scott Wheeler [Thu, 17 Aug 2006 10:31:52 +0000 (10:31 +0000)]
Add a warning note to File::save()

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@573841 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoMake sure that there's always a description and content even if they're empty.
Scott Wheeler [Sun, 13 Aug 2006 23:49:27 +0000 (23:49 +0000)]
Make sure that there's always a description and content even if they're empty.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@572797 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoThis if doesn't need to be there. The encoding byte should be there even if there
Scott Wheeler [Sun, 13 Aug 2006 23:10:43 +0000 (23:10 +0000)]
This if doesn't need to be there.  The encoding byte should be there even if there
is no string content.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@572787 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoMake removeField() actually remove the map content, not just
Scott Wheeler [Sun, 13 Aug 2006 15:25:48 +0000 (15:25 +0000)]
Make removeField() actually remove the map content, not just
empty the list.  Also added an erase method to Map that works on keys
rather than itterators.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@572681 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoAdd a simple function for checking for membership in the fieldListMap.
Scott Wheeler [Sun, 13 Aug 2006 15:19:36 +0000 (15:19 +0000)]
Add a simple function for checking for membership in the fieldListMap.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@572680 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoThe non-const functions here should call detach.
Scott Wheeler [Sun, 13 Aug 2006 12:29:26 +0000 (12:29 +0000)]
The non-const functions here should call detach.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@572630 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoignoring
Stephan Kulow [Sat, 5 Aug 2006 18:04:04 +0000 (18:04 +0000)]
ignoring

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@570113 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoDefault to ID3v2.4 in the header (fixes the bug just reported on the list)
Scott Wheeler [Sun, 25 Jun 2006 20:27:17 +0000 (20:27 +0000)]
Default to ID3v2.4 in the header (fixes the bug just reported on the list)

CCMAIL:taglib-devel@kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@554946 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoDon't overrun the buffer if the first byte is 0xff
Scott Wheeler [Tue, 20 Jun 2006 20:41:30 +0000 (20:41 +0000)]
Don't overrun the buffer if the first byte is 0xff

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@553365 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agooops
Scott Wheeler [Fri, 16 Jun 2006 23:26:25 +0000 (23:26 +0000)]
oops

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@552202 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoHere's another easy one that helps out on ginormus strings.
Scott Wheeler [Fri, 16 Jun 2006 22:50:09 +0000 (22:50 +0000)]
Here's another easy one that helps out on ginormus strings.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@552198 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoA couple more optimizations for splitting vectors. One of them makes search
Scott Wheeler [Fri, 16 Jun 2006 22:38:20 +0000 (22:38 +0000)]
A couple more optimizations for splitting vectors.  One of them makes search
faster in the simple case (no need for Boyer-Moore for a one-character search)
and append a null vector rather than instantiating a new one when we find empty
fields.

This gets the reading time down to 6 seconds here for the reported bug, which
still isn't great, but it's starting to get close to acceptable.  I'll see if I
can get it a little tighter...

BUG:122183

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@552196 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoThis is much, much faster on large byte vectors and gets the current bug down
Scott Wheeler [Fri, 16 Jun 2006 20:36:36 +0000 (20:36 +0000)]
This is much, much faster on large byte vectors and gets the current bug down
to where it can read the tag in around 18 seconds unstead of 30 minutes.

I'm going to see if I can find the other hot paths now...

CCBUG:122183

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@552178 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoAllan's commit was in the wrong branch -- don't corrupt files on
Scott Wheeler [Fri, 9 Jun 2006 09:48:28 +0000 (09:48 +0000)]
Allan's commit was in the wrong branch -- don't corrupt files on
write...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@549613 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoThis comes from strdup, so it should be freed rather than deleted.
Scott Wheeler [Thu, 8 Jun 2006 12:22:18 +0000 (12:22 +0000)]
This comes from strdup, so it should be freed rather than deleted.
Patch from Jon Burgess.

BUG:127260

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@549379 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoInitialize tag to avoid possible crashes
Allan Sandfeld Jensen [Sun, 14 May 2006 19:18:47 +0000 (19:18 +0000)]
Initialize tag to avoid possible crashes

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@540838 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoSVN_SILENT accidentally inserted tabs
Scott Wheeler [Mon, 8 May 2006 20:49:01 +0000 (20:49 +0000)]
SVN_SILENT accidentally inserted tabs

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@538782 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoAdd a function to set the default ID3v2 encoding in the C API.
Scott Wheeler [Mon, 8 May 2006 20:45:42 +0000 (20:45 +0000)]
Add a function to set the default ID3v2 encoding in the C API.

BUG:126192

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@538781 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoPatch from John Stirling to fix bitmasks for header fields.
Scott Wheeler [Mon, 8 May 2006 20:08:33 +0000 (20:08 +0000)]
Patch from John Stirling to fix bitmasks for header fields.

BUG:70649

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@538764 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agodocs typo
Scott Wheeler [Thu, 20 Apr 2006 20:31:25 +0000 (20:31 +0000)]
docs typo

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@532016 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoSVN_SILENT
Scott Wheeler [Thu, 2 Mar 2006 15:13:54 +0000 (15:13 +0000)]
SVN_SILENT

Forgot to add docs.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@515072 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoTwo things:
Scott Wheeler [Thu, 2 Mar 2006 15:02:27 +0000 (15:02 +0000)]
Two things:
 - Fix the channel mode, copyright and original flags, as noticed by
   Bjoern Petersen.
 - Check in the "findByDescription()" function that I've had sitting
   around for a while.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@515068 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

18 years agoAdd a wide string export fuction.
Scott Wheeler [Sat, 11 Feb 2006 21:18:03 +0000 (21:18 +0000)]
Add a wide string export fuction.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@508477 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoAlright -- most of this code is just more cleanups, and the bugfix part of it
Scott Wheeler [Sun, 29 Jan 2006 17:47:38 +0000 (17:47 +0000)]
Alright -- most of this code is just more cleanups, and the bugfix part of it
is relatively small.  Basically it took a while for me to be convinced that the
ID3v2 location was always going to be before the FLAC data stream pointer.  I've
added a check to make sure that it stays that way, but I don't expect us to
actually hit that code.

BUG:120578

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503614 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoA prelude to bugfixing. A few more cleanups.
Scott Wheeler [Sun, 29 Jan 2006 16:59:40 +0000 (16:59 +0000)]
A prelude to bugfixing.  A few more cleanups.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503592 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoCleanups -- no functional changes.
Scott Wheeler [Sun, 29 Jan 2006 16:06:07 +0000 (16:06 +0000)]
Cleanups -- no functional changes.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503573 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoFix up the stuff here for appending values to an APE::Item and round out the API...
Scott Wheeler [Sat, 28 Jan 2006 15:18:31 +0000 (15:18 +0000)]
Fix up the stuff here for appending values to an APE::Item and round out the API a bit.
Based on Michael's patch...

BUG:120256

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503255 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoIf a frame has both compression and encryption, since we currently
Scott Wheeler [Sat, 28 Jan 2006 14:00:48 +0000 (14:00 +0000)]
If a frame has both compression and encryption, since we currently
don't support encrypted frames, don't try to decompress it.  Decryption
is supposed to be applied before decompression, so currently the decompression
isn't possible.

BUG:112919

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503234 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoSwitch this to "rb" and "rb+" since Windows seems to barf on it without the "b"
Scott Wheeler [Sat, 28 Jan 2006 13:40:05 +0000 (13:40 +0000)]
Switch this to "rb" and "rb+" since Windows seems to barf on it without the "b"
and it doesn't make a difference at all on UNIX.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503213 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoAnother method that didn't actually have an implementation around. Also
Scott Wheeler [Thu, 24 Nov 2005 10:27:45 +0000 (10:27 +0000)]
Another method that didn't actually have an implementation around.  Also
picked some default values for some of the d-pointer members.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@482863 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoActually implement this constructor...
Scott Wheeler [Wed, 23 Nov 2005 10:36:06 +0000 (10:36 +0000)]
Actually implement this constructor...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@482540 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoMissing class name on the method declaration. I'm sure this caused some
Scott Wheeler [Wed, 23 Nov 2005 10:27:33 +0000 (10:27 +0000)]
Missing class name on the method declaration.  I'm sure this caused some
fun symbol conflicts...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@482539 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoSVN_SILENT a couple of missing docs
Scott Wheeler [Tue, 18 Oct 2005 12:33:48 +0000 (12:33 +0000)]
SVN_SILENT a couple of missing docs

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@471683 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoSilly second declaration of the variable here that triggers an infinite
Scott Wheeler [Tue, 27 Sep 2005 14:34:32 +0000 (14:34 +0000)]
Silly second declaration of the variable here that triggers an infinite
loop in some cases (I'm surprised that it doesn't happen in more...this
code has been around for a while.).

BUG:113437

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@464483 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoA couple of things pointed out by a colleage -- fix ByteVector::size()
Scott Wheeler [Mon, 12 Sep 2005 16:52:07 +0000 (16:52 +0000)]
A couple of things pointed out by a colleage -- fix ByteVector::size()
and make the return type semantics consistant for methods that modify
the object (specifically, return a reference instead of void).

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@460002 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoJust a couple of docs updates.
Scott Wheeler [Tue, 6 Sep 2005 11:39:26 +0000 (11:39 +0000)]
Just a couple of docs updates.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@457702 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoFix the documentation for this method.
Scott Wheeler [Sun, 4 Sep 2005 20:06:27 +0000 (20:06 +0000)]
Fix the documentation for this method.

CCMAIL:Umesh Shankar <ushankar@cs.berkeley.edu>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@457127 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoLeave the year field blank if it's set to zero (i.e. cleared).
Scott Wheeler [Wed, 10 Aug 2005 08:33:28 +0000 (08:33 +0000)]
Leave the year field blank if it's set to zero (i.e. cleared).

BUG:109920

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@444448 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoForgot that this doesn't work for those not using
Scott Wheeler [Wed, 27 Jul 2005 07:29:41 +0000 (07:29 +0000)]
Forgot that this doesn't work for those not using
my hacked up build environment for TagLib.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@439118 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoLast docs updates and a small function signature change. I'm pretty sure that's...
Scott Wheeler [Wed, 27 Jul 2005 00:25:40 +0000 (00:25 +0000)]
Last docs updates and a small function signature change.  I'm pretty sure that's it for 1.4.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@439059 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agonote other bindings
Scott Wheeler [Tue, 26 Jul 2005 00:37:39 +0000 (00:37 +0000)]
note other bindings

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438757 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoBug in UTF-8 rendering. Small change, but well, without the "break;" it was doing
Scott Wheeler [Mon, 25 Jul 2005 21:34:18 +0000 (21:34 +0000)]
Bug in UTF-8 rendering.  Small change, but well, without the "break;" it was doing
the UTF-8 rendering and the UTF16-LE rendering to the same string, which was, well,
ungood.

(Sorry Dan, that's bad news for those files -- but this bug was only introduced 4
days ago, so it just hadn't been caught yet.)

BUG:109604

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438731 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoDon't actually install the tdebug.h header.
Scott Wheeler [Mon, 25 Jul 2005 19:51:52 +0000 (19:51 +0000)]
Don't actually install the tdebug.h header.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438704 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoDon't include tdebug.h in any installed header. I'll remove it from installation
Scott Wheeler [Mon, 25 Jul 2005 19:26:00 +0000 (19:26 +0000)]
Don't include tdebug.h in any installed header.  I'll remove it from installation
shortly.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438692 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoAdd a list of the default file extensions that TagLib knows about, as requested
Scott Wheeler [Sun, 24 Jul 2005 16:25:33 +0000 (16:25 +0000)]
Add a list of the default file extensions that TagLib knows about, as requested
by Stefan.  Also did a few additional updates on the API docs.

CCMAIL:Stefan Gehn <mETz81@web.de>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438212 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoSVN_SILENT another place to update the version
Scott Wheeler [Sun, 24 Jul 2005 08:03:37 +0000 (08:03 +0000)]
SVN_SILENT another place to update the version

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438078 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoMake sure that buffer allocations for file reads aren't completely bogus.
Scott Wheeler [Sat, 23 Jul 2005 23:49:29 +0000 (23:49 +0000)]
Make sure that buffer allocations for file reads aren't completely bogus.
Specifically make sure that we don't actually allocate a buffer for a read that
extends beyond the end of the file.

BUG:101401

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438035 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoFinally took Tommi's suggestion here and introduced a version of the ByteVectorList...
Scott Wheeler [Sat, 23 Jul 2005 23:11:20 +0000 (23:11 +0000)]
Finally took Tommi's suggestion here and introduced a version of the ByteVectorList::split()
that takes a maximum number of values.  This should probably be used more widely in
places where the max is known ahead of time for this to be a more useful fix than nailing
just this special case.  Anyway, fixes the bug.

BUG:103622

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438030 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoThis is a better way of doing this too... Now I have to remember to
Scott Wheeler [Sat, 23 Jul 2005 21:46:39 +0000 (21:46 +0000)]
This is a better way of doing this too...  Now I have to remember to
update the configure.in.in in the root...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438007 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoAdd pkg-config file.
Scott Wheeler [Sat, 23 Jul 2005 21:43:09 +0000 (21:43 +0000)]
Add pkg-config file.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438006 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoBump to 1.4
Scott Wheeler [Sat, 23 Jul 2005 20:58:43 +0000 (20:58 +0000)]
Bump to 1.4

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438002 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoSVN_SILENT missing docs
Scott Wheeler [Fri, 22 Jul 2005 09:03:15 +0000 (09:03 +0000)]
SVN_SILENT missing docs

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437534 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoGo ahead and increment the libtool version in preparation for 1.4.
Scott Wheeler [Fri, 22 Jul 2005 08:33:45 +0000 (08:33 +0000)]
Go ahead and increment the libtool version in preparation for 1.4.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437529 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoAdd UTF16LE support. Patch mostly by Umesh Shankar.
Scott Wheeler [Thu, 21 Jul 2005 18:45:12 +0000 (18:45 +0000)]
Add UTF16LE support.  Patch mostly by Umesh Shankar.

BUG:106815

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437399 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoHmm, that last one wasn't really quite ready. Now we actually check our list
Scott Wheeler [Thu, 21 Jul 2005 18:10:10 +0000 (18:10 +0000)]
Hmm, that last one wasn't really quite ready.  Now we actually check our list
of FileTypeResolvers.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437391 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoAdd a mechanism for extending the file type resolution in JuK using FileRefs.
Scott Wheeler [Thu, 21 Jul 2005 17:45:23 +0000 (17:45 +0000)]
Add a mechanism for extending the file type resolution in JuK using FileRefs.

This is generally much better thought out than the current method of creating
FileRefs using the native mime system and also allows for extension to additional
file formats.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437382 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoContinuing going through my pile-o-patches:
Scott Wheeler [Thu, 21 Jul 2005 17:33:36 +0000 (17:33 +0000)]
Continuing going through my pile-o-patches:

Make it possible to save files using the save() with a tag mask
without stripping the tags that do not fit the mask.  I still need
to do a little testing on this to make sure that the offsets are
still computed correctly.

BUG:96460

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437380 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoIf there is no value set for DESCRIPTION, also check COMMENT.
Scott Wheeler [Thu, 21 Jul 2005 17:30:03 +0000 (17:30 +0000)]
If there is no value set for DESCRIPTION, also check COMMENT.

BUG:98714

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437379 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoAdd accessors for the image description.
Scott Wheeler [Thu, 21 Jul 2005 17:27:37 +0000 (17:27 +0000)]
Add accessors for the image description.

BUG:94258

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437378 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoFix up the RVA2 handling. I'm still not thrilled with the API, but this
Scott Wheeler [Thu, 21 Jul 2005 00:10:57 +0000 (00:10 +0000)]
Fix up the RVA2 handling.  I'm still not thrilled with the API, but this
should be functional enough to hold over to the next binary
incompatible change and has a minimum of differences to the previous
API.

I did a slightly nasty hack so that the API docs will see just methods
with an optional argument, but those are actually two separate methods
(for BC).

Brian, please feel free to take a look at this prior to 1.4 going out.

BUG:107025

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437115 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoFix from Felix Berger to get RVA2 frames a little closer
Scott Wheeler [Wed, 20 Jul 2005 22:23:34 +0000 (22:23 +0000)]
Fix from Felix Berger to get RVA2 frames a little closer
to working.  The more complicated fix for #107025 will
follow shortly.

BUG:95545

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437091 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoAdding and updating svn:ignore
Thiago Macieira [Sat, 16 Jul 2005 14:39:38 +0000 (14:39 +0000)]
Adding and updating svn:ignore

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@435313 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoMisspelling.
Scott Wheeler [Wed, 13 Jul 2005 12:22:34 +0000 (12:22 +0000)]
Misspelling.

BUG:107847

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@434245 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoInstead of returning 0 on finding a deprecated frame type, create an
Scott Wheeler [Tue, 17 May 2005 23:57:23 +0000 (23:57 +0000)]
Instead of returning 0 on finding a deprecated frame type, create an
UnknownFrame and set the flag to discard it on write.

As a special bonus this meant implementing the discard-on-tag-alter
flag.

BUG:100515

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415248 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoPatch from Umesh Shankar to make sure that the frameID is current.
Scott Wheeler [Tue, 17 May 2005 22:38:01 +0000 (22:38 +0000)]
Patch from Umesh Shankar to make sure that the frameID is current.

CCMAIL:Umesh Shankar <ushankar@cs.berkeley.edu>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415233 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoCheck to make sure that there's content before trying to return it.
Scott Wheeler [Tue, 17 May 2005 21:27:51 +0000 (21:27 +0000)]
Check to make sure that there's content before trying to return it.

Almost the same as a patch from Clemens Fuchslocher

CCMAIL:clemens@allesdurcheinander.de

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415211 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoDo a bounds check before trying to find the mid.
Scott Wheeler [Tue, 17 May 2005 20:45:05 +0000 (20:45 +0000)]
Do a bounds check before trying to find the mid.

CCMAIL:Felix Hupfeld <hupfeld@zib.de>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415196 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoDouble-deleting won't make it much better
Allan Sandfeld Jensen [Sun, 3 Apr 2005 16:41:17 +0000 (16:41 +0000)]
Double-deleting won't make it much better

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402896 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years ago...or this
Scott Wheeler [Sun, 3 Apr 2005 16:37:56 +0000 (16:37 +0000)]
...or this

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402894 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoDidn't mean to check this in.
Scott Wheeler [Sun, 3 Apr 2005 16:36:17 +0000 (16:36 +0000)]
Didn't mean to check this in.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402892 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agofix memory leaks
Scott Wheeler [Sun, 3 Apr 2005 16:35:55 +0000 (16:35 +0000)]
fix memory leaks

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402891 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoDecode samplerate correctly.
Allan Sandfeld Jensen [Sat, 2 Apr 2005 20:53:11 +0000 (20:53 +0000)]
Decode samplerate correctly.
BUG: 99829

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402712 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoSorry, that was actually wrong.
Allan Sandfeld Jensen [Fri, 18 Mar 2005 00:10:21 +0000 (00:10 +0000)]
Sorry, that was actually wrong.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@398578 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoSupport the new OggFLAC 1.0 standard from FLAC 1.1.2
Allan Sandfeld Jensen [Fri, 18 Mar 2005 00:02:27 +0000 (00:02 +0000)]
Support the new OggFLAC 1.0 standard from FLAC 1.1.2

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@398574 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoNice catch from Gunnar Roth -- the iterator was invalid here.
Scott Wheeler [Wed, 2 Feb 2005 19:04:54 +0000 (19:04 +0000)]
Nice catch from Gunnar Roth -- the iterator was invalid here.

BUG:94662

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@385470 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoDon't dereference the iterator before checking to make sure that we're not
Scott Wheeler [Fri, 14 Jan 2005 13:04:36 +0000 (13:04 +0000)]
Don't dereference the iterator before checking to make sure that we're not
at the end of the list.  Thanks to Gunnar Roth for catching this one.

BUG:96926

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@378404 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agostartsWith() should be used to avoid bugs like: s.mid(0, 4) == "Foo".
Benjamin Meyer [Sun, 19 Dec 2004 05:45:33 +0000 (05:45 +0000)]
startsWith() should be used to avoid bugs like: s.mid(0, 4) == "Foo".

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@371832 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoMake the private class a friend so that it can access the protected Header
Scott Wheeler [Wed, 8 Dec 2004 16:50:10 +0000 (16:50 +0000)]
Make the private class a friend so that it can access the protected Header
class.
BUG:93869

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@369269 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoconvert "" comparison to use built in empty() function
Benjamin Meyer [Mon, 22 Nov 2004 20:08:11 +0000 (20:08 +0000)]
convert "" comparison to use built in empty() function

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@365215 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years ago1.3.1
Scott Wheeler [Sun, 7 Nov 2004 16:10:40 +0000 (16:10 +0000)]
1.3.1

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@361202 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years ago...and now implement the missing contructor.
Scott Wheeler [Sat, 6 Nov 2004 14:43:24 +0000 (14:43 +0000)]
...and now implement the missing contructor.

BUG:92803

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360973 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoClean up includes and actually install apeitem.h. Prior to this the APE
Scott Wheeler [Sat, 6 Nov 2004 14:31:55 +0000 (14:31 +0000)]
Clean up includes and actually install apeitem.h.  Prior to this the APE
API wasn't usable.  Fortunately I'm planning on releasing a 1.3.1 tomorrow.

CCMAIL:Allan Sandfeld Jensen <kde@carewolf.com>
CCBUG:92803

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360971 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoSince these headers weren't even usable when installed, might as well go
Scott Wheeler [Sat, 6 Nov 2004 14:24:40 +0000 (14:24 +0000)]
Since these headers weren't even usable when installed, might as well go
ahead and remove the deprecated crap...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360969 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoDo bounds checking before assuming that just because we've been told that
Scott Wheeler [Sun, 31 Oct 2004 20:30:47 +0000 (20:30 +0000)]
Do bounds checking before assuming that just because we've been told that
there are actually more items that there actually are.

BUG:92028

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359382 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoAdd some text explaining the APE format since it's non-obvious trying to
Scott Wheeler [Sun, 31 Oct 2004 19:27:24 +0000 (19:27 +0000)]
Add some text explaining the APE format since it's non-obvious trying to
find it online and it's poorly written once found.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359360 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoCVS_SILENT back in here again -- checking in formatting before content...
Scott Wheeler [Sat, 30 Oct 2004 16:14:35 +0000 (16:14 +0000)]
CVS_SILENT back in here again -- checking in formatting before content...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359015 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoDon't write a track number if the track is larger than 255.
Scott Wheeler [Fri, 29 Oct 2004 13:48:55 +0000 (13:48 +0000)]
Don't write a track number if the track is larger than 255.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358768 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoMake sure that the type conversion happens so that this number ends up being
Scott Wheeler [Thu, 28 Oct 2004 23:27:29 +0000 (23:27 +0000)]
Make sure that the type conversion happens so that this number ends up being
the appropriate seek location.  I'm pretty sure that this is what was causing
Ogg length information to not work on x86_64.  Can you confirm Hamish?

BUG:86806

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358653 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoCVS_SILENT this comment belongs here now
Scott Wheeler [Thu, 28 Oct 2004 22:20:00 +0000 (22:20 +0000)]
CVS_SILENT this comment belongs here now

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358639 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoMake sure that there's (a) data in a bytevector that we're trying to convert
Scott Wheeler [Thu, 28 Oct 2004 22:11:41 +0000 (22:11 +0000)]
Make sure that there's (a) data in a bytevector that we're trying to convert
to an integer before trying to convert it and (b) make sure that there's data
in an APE::Item before trying to parse it.

BUG:92028

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358637 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoMore cleanups and some API docs additions.
Scott Wheeler [Thu, 28 Oct 2004 22:05:43 +0000 (22:05 +0000)]
More cleanups and some API docs additions.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358636 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoSemantic and style cleanups. render() should be const. Use for() loops to
Scott Wheeler [Thu, 28 Oct 2004 21:22:33 +0000 (21:22 +0000)]
Semantic and style cleanups.  render() should be const.  Use for() loops to
loop through lists rather than while, fix bracket style.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358627 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoThis line is redundant.
Scott Wheeler [Wed, 20 Oct 2004 23:34:55 +0000 (23:34 +0000)]
This line is redundant.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@356359 283d02a7-25f6-0310-bc7c-ecb5cbfe19da