]>
granicus.if.org Git - icu/log
Hugo van der Merwe [Tue, 9 Jun 2020 13:56:53 +0000 (15:56 +0200)]
Add six more unit tests for getPreferencesFor.
Hugo [Thu, 28 May 2020 08:42:56 +0000 (10:42 +0200)]
Merge pull request #23 from younies/unit_header
add usage to number formatter settings header
Hugo [Thu, 28 May 2020 08:41:28 +0000 (10:41 +0200)]
Merge pull request #45 from hugovdm/usagefix
Support usage component dropping, and more
Hugo van der Merwe [Wed, 27 May 2020 22:46:28 +0000 (00:46 +0200)]
Drop unnecessary reference to "draft API".
Hugo van der Merwe [Wed, 27 May 2020 22:33:11 +0000 (00:33 +0200)]
Add an error check, as per code review.
Hugo van der Merwe [Wed, 27 May 2020 22:09:55 +0000 (00:09 +0200)]
Support usage component dropping, and more:
- Improve efficiency by not constructing UnitPreferenceMetadata instance
in binarySearch: reuse an instance passed in.
- Fix stale documentation. (Doc freshness is hard! ;-)
- getPreferenceMetadataIndex actually returns -1 upon failure.
Hugo van der Merwe [Wed, 27 May 2020 18:04:36 +0000 (20:04 +0200)]
Add test cases for dropping last component(s) of usage.
Hugo van der Merwe [Tue, 26 May 2020 22:49:19 +0000 (00:49 +0200)]
ICU 68 (not 67). Add U_HIDE_DRAFT_API ifdef guards.
Hugo van der Merwe [Tue, 26 May 2020 13:40:32 +0000 (15:40 +0200)]
Some more documentation tweaks.
Hugo van der Merwe [Mon, 25 May 2020 22:28:56 +0000 (00:28 +0200)]
Clarify the documentation.
Younies Mahmoud [Tue, 19 May 2020 13:45:51 +0000 (15:45 +0200)]
Merge pull request #42 from younies/unit_header_staging
Add missing comments ...
Younies Mahmoud [Tue, 19 May 2020 13:42:23 +0000 (15:42 +0200)]
add a note about with sub usage
Younies Mahmoud [Tue, 19 May 2020 13:34:48 +0000 (15:34 +0200)]
add a note about with empty string
Hugo [Thu, 14 May 2020 19:42:45 +0000 (21:42 +0200)]
Merge pull request #43 from hugovdm/getUnitCategory
Add getUnitCategory()
Hugo van der Merwe [Thu, 14 May 2020 19:07:59 +0000 (21:07 +0200)]
Merge branch 'units-staging' into getUnitCategory
Hugo van der Merwe [Thu, 14 May 2020 19:05:03 +0000 (21:05 +0200)]
TODO(CLDR-13787) for improving inverse handling.
Hugo van der Merwe [Wed, 13 May 2020 14:44:50 +0000 (16:44 +0200)]
Add unit tests, improve docs, add a FIXME for consumption-inverse.
Shane F. Carr [Tue, 12 May 2020 18:41:30 +0000 (13:41 -0500)]
Merge pull request #42 from hugovdm/UnitPreferences
UnitPreferences class in unitsdata.cpp
Hugo van der Merwe [Mon, 11 May 2020 22:43:03 +0000 (00:43 +0200)]
Add getUnitCategory.
Hugo van der Merwe [Sat, 9 May 2020 00:56:11 +0000 (02:56 +0200)]
const implemented: const UnitPreferences *const
Hugo van der Merwe [Fri, 8 May 2020 00:30:06 +0000 (02:30 +0200)]
Code review feedback incorporated.
Hugo van der Merwe [Thu, 7 May 2020 11:28:40 +0000 (13:28 +0200)]
Merge branch 'units-staging' into UnitPreferences
Younies Mahmoud [Thu, 7 May 2020 11:24:31 +0000 (13:24 +0200)]
Merge pull request #21 from younies/tryingdouble
Add unit converter.
Hugo van der Merwe [Wed, 6 May 2020 13:20:23 +0000 (15:20 +0200)]
const annotations for getPreferencesFor() and thus getAlias()
Hugo van der Merwe [Wed, 6 May 2020 13:07:48 +0000 (15:07 +0200)]
Implement slicing via `UnitPreference **&outPreferences`.
(Still multiple TODOs for make things cleaner/neater.)
Younies Mahmoud [Wed, 6 May 2020 02:49:32 +0000 (04:49 +0200)]
Merge pull request #39 from younies/tryingdouble_staging
add a TODO to load the constants\' values from the units data
Younies Mahmoud [Wed, 6 May 2020 02:48:35 +0000 (04:48 +0200)]
add a TODO to load the constants\' values from the units data
Younies Mahmoud [Wed, 6 May 2020 02:45:04 +0000 (04:45 +0200)]
Merge pull request #38 from younies/tryingdouble_staging
fix substituteConstans function
Younies Mahmoud [Wed, 6 May 2020 02:28:35 +0000 (04:28 +0200)]
fix substituteConstans function
Younies Mahmoud [Wed, 6 May 2020 00:12:13 +0000 (02:12 +0200)]
Merge pull request #37 from younies/tryingdouble_staging
add substitution of the constant to `Factor`
Younies Mahmoud [Wed, 6 May 2020 00:07:36 +0000 (02:07 +0200)]
add substitution of the constant to
Younies Mahmoud [Tue, 5 May 2020 13:54:40 +0000 (15:54 +0200)]
Merge pull request #36 from younies/tryingdouble_staging
Fix Shane's comment about unitconverter.cpp
Younies Mahmoud [Tue, 5 May 2020 13:48:19 +0000 (15:48 +0200)]
fix UnitConverter
Hugo van der Merwe [Tue, 5 May 2020 13:19:38 +0000 (15:19 +0200)]
Reduce number of binary searches again, resulting in more complexity.
Hugo van der Merwe [Tue, 5 May 2020 12:40:34 +0000 (14:40 +0200)]
More readable binarySearch at 4x worst-case cost.
With this hopefully more readable version, looking for an unknown
usage and region will result in the binary search being repeated four
times.
The previous version did not use a metadata instance comparator so
that individual components of the metadata key could be compared. A
comparator that returns status information on which of the components
had been found would be able to improve on this.
Hugo van der Merwe [Tue, 5 May 2020 12:40:15 +0000 (14:40 +0200)]
One improvement to error reporting.
Younies Mahmoud [Tue, 5 May 2020 01:50:19 +0000 (03:50 +0200)]
Merge pull request #35 from younies/tryingdouble_staging
Fix dependencies and small nits
Younies Mahmoud [Tue, 5 May 2020 01:43:49 +0000 (03:43 +0200)]
fix dependices and small nits
Hugo van der Merwe [Tue, 5 May 2020 00:42:03 +0000 (02:42 +0200)]
First set of code review improvements.
Hugo van der Merwe [Mon, 4 May 2020 19:39:37 +0000 (21:39 +0200)]
Fix dependencies.txt, add documentation, add appropriate UMemory inheritence.
Younies Mahmoud [Mon, 4 May 2020 13:07:05 +0000 (15:07 +0200)]
Merge pull request #34 from younies/tryingdouble_staging
Remove extractUnitInfo from UnitConverter's helpers
Younies Mahmoud [Mon, 4 May 2020 13:06:05 +0000 (15:06 +0200)]
remove extra spaces from the factors
Hugo van der Merwe [Wed, 29 Apr 2020 21:30:04 +0000 (23:30 +0200)]
UnitPreferences class in unitsdata.cpp
Younies Mahmoud [Mon, 4 May 2020 03:34:45 +0000 (05:34 +0200)]
remove extractUnitInfo from UnitConverter's helpers
Younies Mahmoud [Sun, 3 May 2020 18:17:06 +0000 (20:17 +0200)]
Merge pull request #33 from hugovdm/tryingdouble_unitsTestTxt
testConversions: test UnitConverter against unitsTest.txt test cases
Shane F. Carr [Sat, 2 May 2020 02:11:40 +0000 (21:11 -0500)]
Merge pull request #41 from hugovdm/units-staging
Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
Hugo van der Merwe [Thu, 30 Apr 2020 13:46:23 +0000 (15:46 +0200)]
Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master.
Hugo van der Merwe [Wed, 29 Apr 2020 12:07:50 +0000 (14:07 +0200)]
testConversions: test UnitConverter against unitsTest.txt test cases
Younies Mahmoud [Thu, 30 Apr 2020 12:06:58 +0000 (14:06 +0200)]
Merge pull request #32 from hugovdm/tryingdouble
Reinstate assertEqualsNear that got lost in merge.
Hugo van der Merwe [Thu, 30 Apr 2020 08:25:28 +0000 (10:25 +0200)]
Reinstate assertEqualsNear that got lost in merge.
- Code compiles, `make check` returns OK.
Younies Mahmoud [Wed, 29 Apr 2020 23:48:25 +0000 (01:48 +0200)]
merge sffc/units-staging
Shane F. Carr [Wed, 29 Apr 2020 21:52:34 +0000 (16:52 -0500)]
Merge pull request #39 from hugovdm/unitsTestTxt
testConversions: test convertibility of unitsTest.txt test cases.
Hugo van der Merwe [Wed, 29 Apr 2020 19:55:13 +0000 (21:55 +0200)]
Add IntlTest::assertNotEquals() for int32_t.
Hugo van der Merwe [Wed, 29 Apr 2020 16:14:55 +0000 (18:14 +0200)]
Remove hard-coded unit tests that were pulled out of unitsTest.txt.
Hugo van der Merwe [Wed, 29 Apr 2020 16:10:08 +0000 (18:10 +0200)]
Add some comments to UnitsTestContext.
Hugo van der Merwe [Wed, 29 Apr 2020 15:11:28 +0000 (17:11 +0200)]
Remove the 'FIXME_skip_tests' bool and branch.
Hugo van der Merwe [Wed, 29 Apr 2020 12:10:28 +0000 (14:10 +0200)]
Uncomment pound-force-per-square-inch test in unitsTest.txt
Hugo van der Merwe [Tue, 28 Apr 2020 19:48:28 +0000 (21:48 +0200)]
testConversions: test convertibility of unitsTest.txt test cases.
Hugo van der Merwe [Wed, 29 Apr 2020 07:28:10 +0000 (09:28 +0200)]
Complicated manual merge of branch 'units-staging' into tryingdouble
This adds a ConversionRates::getInternalList() that needs to be
removed again, by improving APIs appropriately.
Shane F. Carr [Tue, 28 Apr 2020 22:39:05 +0000 (17:39 -0500)]
Merge pull request #32 from younies/check_convirtible_units
Check convertible units
Younies Mahmoud [Tue, 28 Apr 2020 21:54:54 +0000 (23:54 +0200)]
add units_extra to unitsformatter dependencies
Younies Mahmoud [Tue, 28 Apr 2020 15:35:08 +0000 (17:35 +0200)]
Merge pull request #31 from hugovdm/check_convirtible_units
Enable "testConversions" test again
Younies Mahmoud [Tue, 28 Apr 2020 15:34:35 +0000 (17:34 +0200)]
Merge branch 'check_convirtible_units' into check_convirtible_units
Younies Mahmoud [Tue, 28 Apr 2020 15:31:41 +0000 (17:31 +0200)]
fix unitConverter and add ConversionRates class
Hugo van der Merwe [Tue, 28 Apr 2020 15:16:01 +0000 (17:16 +0200)]
Fix make check: dependencies.txt, fix units_extra deps
Hugo van der Merwe [Tue, 28 Apr 2020 12:34:47 +0000 (14:34 +0200)]
Merge branch 'units-staging' into tryingdouble
Conflict resolution: uncomment unit tests that pass now, but were
previously disabled by commenting-out within units-staging.
Hugo van der Merwe [Mon, 27 Apr 2020 17:43:08 +0000 (19:43 +0200)]
Enable "testConversions" test again.
With MeasureUnit fixes merged, these tests seem to pass now.
Younies Mahmoud [Mon, 27 Apr 2020 13:40:45 +0000 (15:40 +0200)]
fix dependencies.txt
Younies Mahmoud [Mon, 27 Apr 2020 12:53:13 +0000 (14:53 +0200)]
fix the header
Younies Mahmoud [Wed, 22 Apr 2020 14:19:32 +0000 (16:19 +0200)]
merge sffc/units-staging
Younies Mahmoud [Wed, 22 Apr 2020 10:16:43 +0000 (12:16 +0200)]
Merge branch 'units-staging' of github.com:sffc/icu into unit_header
Shane F. Carr [Tue, 21 Apr 2020 20:47:01 +0000 (15:47 -0500)]
Merge pull request #31 from hugovdm/units-staging-getConversionRatesInfo
Add unitsdata.cpp, getConversionRatesInfo, and unit tests.
Younies Mahmoud [Fri, 17 Apr 2020 12:23:29 +0000 (14:23 +0200)]
Merge pull request #30 from hugovdm/check_convertible_units_identifierfixes
Fix the broken testConversionCapability unit identifiers.
Hugo van der Merwe [Fri, 17 Apr 2020 00:57:09 +0000 (02:57 +0200)]
Fix the broken testConversionCapability unit identifiers.
Hugo van der Merwe [Thu, 16 Apr 2020 23:49:29 +0000 (01:49 +0200)]
Remove testGetConversionRateInfo.
Hugo van der Merwe [Thu, 16 Apr 2020 23:47:57 +0000 (01:47 +0200)]
Fix deps: use UMemory as base class for it's new().
Hugo van der Merwe [Thu, 16 Apr 2020 22:49:06 +0000 (00:49 +0200)]
dependencies.txt attempt #1: where's "operator new(unsigned long)" coming from?
Hugo van der Merwe [Thu, 16 Apr 2020 22:47:30 +0000 (00:47 +0200)]
Nit: remove two unneeded #includes
Hugo van der Merwe [Thu, 16 Apr 2020 02:10:43 +0000 (04:10 +0200)]
Comment out broken test cases as per younies'
476ca805c
Hugo van der Merwe [Thu, 16 Apr 2020 01:59:44 +0000 (03:59 +0200)]
Lint: add copyright notices to .txt files from CLDR.
Hugo van der Merwe [Wed, 15 Apr 2020 11:59:48 +0000 (13:59 +0200)]
Switch result parameter from pointer to reference.
Hugo van der Merwe [Wed, 15 Apr 2020 11:55:00 +0000 (13:55 +0200)]
Return getAllConversionRates result via pointer parameter.
Younies Mahmoud [Tue, 14 Apr 2020 21:01:57 +0000 (23:01 +0200)]
fix check Convertibility
Hugo van der Merwe [Tue, 14 Apr 2020 18:59:41 +0000 (20:59 +0200)]
Improve documentation comments.
Hugo van der Merwe [Tue, 14 Apr 2020 15:10:56 +0000 (17:10 +0200)]
Change outVector from reference to pointer for clarity of lack of ownership.
Hugo van der Merwe [Tue, 14 Apr 2020 14:33:59 +0000 (16:33 +0200)]
Add getAllConversionRates(), drop selective code.
Younies Mahmoud [Tue, 14 Apr 2020 13:52:51 +0000 (15:52 +0200)]
fix compound basic unit
Younies Mahmoud [Tue, 14 Apr 2020 12:13:39 +0000 (14:13 +0200)]
Merge pull request #28 from hugovdm/hugovdm_check_convertible_units_unitstest
Test convertibility of some unitsTest.txt tests
Younies Mahmoud [Tue, 14 Apr 2020 09:13:28 +0000 (11:13 +0200)]
small fixes
Younies Mahmoud [Tue, 7 Apr 2020 20:15:34 +0000 (22:15 +0200)]
Merge branch 'check_convirtible_units' of github.com:younies/icu into check_convirtible_units
Shane F. Carr [Tue, 7 Apr 2020 16:44:16 +0000 (11:44 -0500)]
Merge remote-tracking branch 'upstream/maint/maint-67' into units-staging
Hugo van der Merwe [Tue, 7 Apr 2020 14:14:24 +0000 (16:14 +0200)]
fixup! Rip out compound base unit calculation.
Hugo van der Merwe [Tue, 7 Apr 2020 13:18:03 +0000 (15:18 +0200)]
Copy failing unitsTest.txt examples into testConversionCapability.
Hugo [Tue, 7 Apr 2020 12:06:50 +0000 (14:06 +0200)]
Merge pull request #33 from hugovdm/units-staging-testcases
Update to latest CLDR test files:
b7a23f3f41 CLDR-13587.
Hugo [Tue, 7 Apr 2020 12:05:48 +0000 (14:05 +0200)]
Merge pull request #34 from hugovdm/units-staging-testimprovements
Improve test output: no more fprintfs.
Hugo van der Merwe [Fri, 3 Apr 2020 02:35:29 +0000 (04:35 +0200)]
ICU-21060 Fix the foo-per-a-b -> foo-b-per-a bug.
Shane F. Carr [Fri, 3 Apr 2020 21:47:36 +0000 (16:47 -0500)]
Merge branch 'master' into units-staging
Steven R. Loomis [Fri, 3 Apr 2020 14:28:08 +0000 (07:28 -0700)]
ICU-20979 API Change Report for 67 RC
Hugo van der Merwe [Fri, 3 Apr 2020 09:52:41 +0000 (11:52 +0200)]
fixup! Rip out compound base unit calculation.
Shane F. Carr [Fri, 3 Apr 2020 02:16:11 +0000 (21:16 -0500)]
ICU-20979 Update TODOs in formatting code to point to open issues.
Also see: ICU-20920 ICU-21059 ICU-20429 ICU-21058